[{"id":1770376,"web_url":"http://patchwork.ozlabs.org/comment/1770376/","msgid":"<20170918174432.4fksyzco2g6gczwe@intel.com>","date":"2017-09-18T17:44:32","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":105,"url":"http://patchwork.ozlabs.org/api/people/105/","name":"Luck, Tony","email":"tony.luck@intel.com"},"content":"On Sat, Sep 16, 2017 at 12:53:42PM +0900, Sergey Senozhatsky wrote:\n> \tHello\n> \n> \tRFC\n> \n> \tOn some arches C function pointers are indirect and point to\n> a function descriptor, which contains the actual pointer to the code.\n> This mostly doesn't matter, except for cases when people want to print\n> out function pointers in symbolic format, because the usual '%pS/%ps'\n> does not work on those arches as expected. That's the reason why we\n> have '%pF/%pf', but since it's here because of a subtle ABI detail\n> specific to some arches (ppc64/ia64/parisc64) it's easy to misuse\n> '%pF/%pf' and '%pS/%ps' (see [1], for example).\n\nA few new warnings when building on ia64:\n\narch/ia64/kernel/module.c:931: warning: passing argument 1 of 'dereference_function_descriptor' makes pointer from integer without a cast\narch/ia64/kernel/module.c:931: warning: return makes integer from pointer without a cast\nkernel/kallsyms.c:325: warning: assignment makes integer from pointer without a cast\nkernel/kallsyms.c:325: warning: passing argument 1 of 'dereference_kernel_function_descriptor' makes pointer from integer without a cast\n\nTried out the module case with a simple Hello-world test case.\nThis code:\n\nchar buf[1];\n\nint init_module(void)\n{\n\tprintk(KERN_INFO \"Hello world 1.\\n\");\n\n\tprintk(\"using %%p my init_module is at %p\\n\", init_module);\n\tprintk(\"using %%pF my init_module is at %pF\\n\", init_module);\n\tprintk(\"using %%pS my init_module is at %pS\\n\", init_module);\n\n\tprintk(\"using %%p my buf is at %p\\n\", buf);\n\tprintk(\"using %%pF my buf is at %pF\\n\", buf);\n\tprintk(\"using %%pS my buf is at %pS\\n\", buf);\n\n\treturn 0;\n}\n\nGave this console output:\n\nHello world 1.\nusing %p my init_module is at a000000203bf0328\nusing %pF my init_module is at init_module+0x0/0x140 [hello_1]\nusing %pS my init_module is at init_module+0x0/0x140 [hello_1]\nusing %p my buf is at a000000203bf0648\nusing %pF my buf is at buf+0x0/0xfffffffffffffb58 [hello_1]\nusing %pS my buf is at buf+0x0/0xfffffffffffffb58 [hello_1]\n\n\nWhich looks like what you wanted. People unaware of the vagaries\nof ppc64/ia64/parisc64 can use the wrong %p[SF] variant, but still\nget the right output.\n\n-Tony","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwty24w62z9s06\n\tfor ;\n\tTue, 19 Sep 2017 03:57:30 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xwty23lDkzDrZr\n\tfor ;\n\tTue, 19 Sep 2017 03:57:30 +1000 (AEST)","from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xwtvy13GyzDqr8\n\tfor ;\n\tTue, 19 Sep 2017 03:55:41 +1000 (AEST)","from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga105.jf.intel.com with ESMTP; 18 Sep 2017 10:44:33 -0700","from agluck-desk.sc.intel.com (HELO intel.com) ([10.3.52.160])\n\tby orsmga005.jf.intel.com with ESMTP; 18 Sep 2017 10:44:32 -0700"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=intel.com\n\t(client-ip=134.134.136.100; helo=mga07.intel.com;\n\tenvelope-from=tony.luck@intel.com; receiver=)","X-Greylist":"delayed 660 seconds by postgrey-1.36 at bilbo;\n\tTue, 19 Sep 2017 03:55:42 AEST","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,413,1500966000\"; d=\"scan'208\";a=\"150509442\"","Date":"Mon, 18 Sep 2017 10:44:32 -0700","From":"\"Luck, Tony\" ","To":"Sergey Senozhatsky ","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Message-ID":"<20170918174432.4fksyzco2g6gczwe@intel.com>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , linux-ia64@vger.kernel.org,\n\tlinux-parisc@vger.kernel.org, Petr Mladek ,\n\tHelge Deller , Jessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , Paul Mackerras ,\n\tAndrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1770422,"web_url":"http://patchwork.ozlabs.org/comment/1770422/","msgid":"<20170918183902.GA30752@p100.box>","date":"2017-09-18T18:39:02","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":1115,"url":"http://patchwork.ozlabs.org/api/people/1115/","name":"Helge Deller","email":"deller@gmx.de"},"content":"* Luck, Tony :\n> On Sat, Sep 16, 2017 at 12:53:42PM +0900, Sergey Senozhatsky wrote:\n> > \tHello\n> > \n> > \tRFC\n> > \n> > \tOn some arches C function pointers are indirect and point to\n> > a function descriptor, which contains the actual pointer to the code.\n> > This mostly doesn't matter, except for cases when people want to print\n> > out function pointers in symbolic format, because the usual '%pS/%ps'\n> > does not work on those arches as expected. That's the reason why we\n> > have '%pF/%pf', but since it's here because of a subtle ABI detail\n> > specific to some arches (ppc64/ia64/parisc64) it's easy to misuse\n> > '%pF/%pf' and '%pS/%ps' (see [1], for example).\n> \n> A few new warnings when building on ia64:\n> \n> arch/ia64/kernel/module.c:931: warning: passing argument 1 of 'dereference_function_descriptor' makes pointer from integer without a cast\n> arch/ia64/kernel/module.c:931: warning: return makes integer from pointer without a cast\n> kernel/kallsyms.c:325: warning: assignment makes integer from pointer without a cast\n> kernel/kallsyms.c:325: warning: passing argument 1 of 'dereference_kernel_function_descriptor' makes pointer from integer without a cast\n\n\nI got similiar warnings on parisc.\nThis patch on top of yours fixed those:\n\ndiff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c\nindex bc2eae8..4f34b46 100644\n--- a/arch/parisc/kernel/module.c\n+++ b/arch/parisc/kernel/module.c\n@@ -66,6 +66,7 @@\n \n #include \n #include \n+#include \n \n #if 0\n #define DEBUGP printk\n@@ -959,12 +960,12 @@ void module_arch_cleanup(struct module *mod)\n unsigned long dereference_module_function_descriptor(struct module *mod,\n \t\t\t\t\t unsigned long addr)\n {\n-\tvoid *opd_sz = mod->arch.fdesc_offset +\n+\tunsigned long opd_sz = mod->arch.fdesc_offset +\n \t\t mod->arch.fdesc_max * sizeof(Elf64_Fdesc);\n \n \tif (addr < mod->arch.fdesc_offset || opd_sz < addr)\n \t\treturn addr;\n \n-\treturn dereference_function_descriptor(addr);\n+\treturn (unsigned long) dereference_function_descriptor((void *) addr);\n }\n #endif\ndiff --git a/kernel/kallsyms.c b/kernel/kallsyms.c\nindex e2fc09e..76f4de6 100644\n--- a/kernel/kallsyms.c\n+++ b/kernel/kallsyms.c\n@@ -322,7 +322,7 @@ const char *kallsyms_lookup(unsigned long addr,\n \tif (is_ksym_addr(addr)) {\n \t\tunsigned long pos;\n \n-\t\taddr = dereference_kernel_function_descriptor(addr);\n+\t\taddr = dereference_kernel_function_descriptor((void *) addr);\n \t\tpos = get_symbol_pos(addr, symbolsize, offset);\n \t\t/* Grab name */\n \t\tkallsyms_expand_symbol(get_symbol_offset(pos),\n\n\nI did tried your testcases too.\n\n\"echo 1 > /proc/sys/vm/drop_caches\" gave correct output:\n printk#1 schedule_timeout+0x0/0x4a8\n printk#2 schedule_timeout+0x0/0x4a8\n printk#3 proc_sys_call_handler+0x120/0x180\n printk#4 proc_sys_call_handler+0x120/0x180\n printk#5 proc_sys_call_handler+0x120/0x180\n printk#6 proc_sys_call_handler+0x120/0x180\n\nand here is \"modprobe zram\":\n printk#7 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n printk#8 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n printk#9 do_one_initcall+0x194/0x290\n printk#10 do_one_initcall+0x194/0x290\n printk#11 do_one_initcall+0x194/0x290\n printk#12 do_one_initcall+0x194/0x290\n printk#13 zram_init+0x22c/0x2a0 [zram]\n printk#14 zram_init+0x22c/0x2a0 [zram]\n printk#15 zram_init+0x22c/0x2a0 [zram]\n printk#16 zram_init+0x22c/0x2a0 [zram]\n\nI wonder why printk#7 and printk#8 don't show \"zram_init\"...\n\n\nRegarding your patches:\n\nIn arch/parisc/kernel/process.c:\n+void *dereference_kernel_function_descriptor(void *ptr)\n+{\n+ if (ptr < (void *)__start_opd || (void *)__end_opd < ptr)\n\nThis needs to be (__end_opd is outside):\n+ if (ptr < (void *)__start_opd || (void *)__end_opd <= ptr)\n\nThe same is true for the checks in the other arches.\n\n\nI'd suggest to move the various\n\textern char __start_opd[], __end_opd[];\nout of arch//include/asm/sections.h and into \n\n\nI'll continue to test.\n\nHelge","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xww4S3ZW3z9s7B\n\tfor ;\n\tTue, 19 Sep 2017 04:48:08 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xww4S2cmFzDqHc\n\tfor ;\n\tTue, 19 Sep 2017 04:48:08 +1000 (AEST)","from mout.gmx.net (mout.gmx.net [212.227.15.19])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xww1K1XYvzDq78\n\tfor ;\n\tTue, 19 Sep 2017 04:45:23 +1000 (AEST)","from p100.box ([193.159.30.106]) by mail.gmx.com (mrgmx003\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 0LskfZ-1dEk2G2iPx-012Joz;\n\tMon, 18 Sep 2017 20:39:09 +0200"],"Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmx.de\n\t(client-ip=212.227.15.19; helo=mout.gmx.net;\n\tenvelope-from=deller@gmx.de; receiver=)","X-Greylist":"delayed 341 seconds by postgrey-1.36 at bilbo;\n\tTue, 19 Sep 2017 04:45:25 AEST","Date":"Mon, 18 Sep 2017 20:39:02 +0200","From":"Helge Deller ","To":"Sergey Senozhatsky ","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Message-ID":"<20170918183902.GA30752@p100.box>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918174432.4fksyzco2g6gczwe@intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Provags-ID":"V03:K0:3I94tXjBDeuYOBUoXRt9hk2APt/72fUGNY6h2xkyCwOOfOJUQQo\n\tBuE4oSPSFxcdxrDyGkae+T2jars4bW/fkmQbKsCKcHtekKqr1CdL1yNUA5L0i7C6tuzBn8h\n\t8JmDS5aeD0rcwLoSOWNGYxnoEshdVQlbcbFGDfiOKC0FVoZ3ygCupWoXDBEFkclAmsy7Qsz\n\tyRNquATqyydPm+iDi7eyg==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:gFn/UihEA7o=:0DfJp/nEyaBFmWjm0ZIl9r\n\tL8dwv+/XYyIPShKWdXbgwF3a5iqul8+kEAWekwv6dU+GClTPNJyAMgPIQMUHwv9HdGfnTmpEo\n\tKY1wWirkboqxBJJcDKftaiLB+d5GyqpAeG4PVHygLVhAikxspmk+xNn318jviTgUoYsrgqxGt\n\t0OSB9G60+ry4QE0ewlXrQ0v1n44i/3sxi4Z4c2dOvniH3fk/L3lYAxL5VmJ+OjKl+nBsuFR32\n\tDrODBhw2NoAK+wC/GSIX3ul4B6WfMlNKWS3B3xjibn841zObmzQUNLroteTChj973AKQpfdpT\n\ttWTBIgcB8ynmnqOMrJRRzF7ng/PkBBjD7ClRMN6GPVpIeaD9etnFZzty/bQoG81HFDULlto6H\n\tkq2dtZ3X2AgQGPb6lm+nT6Ea19I3asJDYPBaY4yJ5jwAfSs0MjL6+2nM0ML+mYCePRuy+9Hqx\n\t3Mwj5N+5A94WjNbCyChwRODHD44vg4YBV/xHt8D3mSdyZeiww1F5CO+VP+9f15KPTmRAuInEl\n\t59XSGsc9NeFgP9c+ai1TCCRAtGjHF7k9wZCBp0r61eyhqHoji+lzjF4PzpCzMDigX2Zd13wCn\n\ttRDDpY6pRmGUvaolI9WFtdhJEOKLHyI0HbOGN+Qi7OALTt0a2vBtnYpbIS2jPruoi8zyltaiZ\n\t+lgwQDIvvafC1m5JYMesqku/YJy3z7a4aPzNLoOB32n+2M3aNUajWSl1y6cMXB16+pbCj4Kdu\n\t54xv01F6BOmqBPKyJccRUeDzJuLiTBslgnWsJLq39Db/dHroknDvTapaQ+fFxPRU7BaMiwHlo\n\tmUG8dDR5AHAMLgpe3yJrWJE29umJw==","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\tlinux-ia64@vger.kernel.org, Petr Mladek ,\n\tHelge Deller , Jessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , Paul Mackerras ,\n\tAndrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1770608,"web_url":"http://patchwork.ozlabs.org/comment/1770608/","msgid":"<20170919020537.GA16991@jagdpanzerIV.localdomain>","date":"2017-09-19T02:05:38","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":67261,"url":"http://patchwork.ozlabs.org/api/people/67261/","name":"Sergey Senozhatsky","email":"sergey.senozhatsky.work@gmail.com"},"content":"On (09/18/17 20:39), Helge Deller wrote:\n[..]\n> > A few new warnings when building on ia64:\n> > \n> > arch/ia64/kernel/module.c:931: warning: passing argument 1 of 'dereference_function_descriptor' makes pointer from integer without a cast\n> > arch/ia64/kernel/module.c:931: warning: return makes integer from pointer without a cast\n> > kernel/kallsyms.c:325: warning: assignment makes integer from pointer without a cast\n> > kernel/kallsyms.c:325: warning: passing argument 1 of 'dereference_kernel_function_descriptor' makes pointer from integer without a cast\n> \n> \n> I got similiar warnings on parisc.\n> This patch on top of yours fixed those:\n> \n\nTony, Helge,\n\nthanks for the reports!\n\nI'll simply convert everything to `unsigned long'. including the\ndereference_function_descriptor() function [I believe there are\nstill some casts happening when we pass addr from kernel/module\ndereference functions to dereference_function_descriptor(), or\nwhen we return `void *' back to symbol resolution code, etc.)\nbesides, it seems that everything that uses\ndereference_function_descriptor() wants `unsigned long' anyway:\n\ndrivers/misc/kgdbts.c: addr = (unsigned long) dereference_function_descriptor((void *)addr);\ninit/main.c: addr = (unsigned long) dereference_function_descriptor(fn);\nkernel/extable.c: addr = (unsigned long) dereference_function_descriptor(ptr);\nkernel/module.c: unsigned long a = (unsigned long)dereference_function_descriptor(addr);\n\nso I'll just switch it to ulong.\n\n\n> I did tried your testcases too.\n> \n> \"echo 1 > /proc/sys/vm/drop_caches\" gave correct output:\n> printk#1 schedule_timeout+0x0/0x4a8\n> printk#2 schedule_timeout+0x0/0x4a8\n> printk#3 proc_sys_call_handler+0x120/0x180\n> printk#4 proc_sys_call_handler+0x120/0x180\n> printk#5 proc_sys_call_handler+0x120/0x180\n> printk#6 proc_sys_call_handler+0x120/0x180\n> \n> and here is \"modprobe zram\":\n> printk#7 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n> printk#8 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n> printk#9 do_one_initcall+0x194/0x290\n> printk#10 do_one_initcall+0x194/0x290\n> printk#11 do_one_initcall+0x194/0x290\n> printk#12 do_one_initcall+0x194/0x290\n> printk#13 zram_init+0x22c/0x2a0 [zram]\n> printk#14 zram_init+0x22c/0x2a0 [zram]\n> printk#15 zram_init+0x22c/0x2a0 [zram]\n> printk#16 zram_init+0x22c/0x2a0 [zram]\n> \n> I wonder why printk#7 and printk#8 don't show \"zram_init\"...\n\ninteresting... what does the unpatched kernel show?\n\n\n> Regarding your patches:\n> \n> In arch/parisc/kernel/process.c:\n> +void *dereference_kernel_function_descriptor(void *ptr)\n> +{\n> + if (ptr < (void *)__start_opd || (void *)__end_opd < ptr)\n> \n> This needs to be (__end_opd is outside):\n> + if (ptr < (void *)__start_opd || (void *)__end_opd <= ptr)\n> \n> The same is true for the checks in the other arches.\n\num... yeah. __end_opd is definitely not a valid place for a descriptor!\nI think I had `if (!(ptr >= __start_opd && ptr < __end_opd))' which I\nwrongly converted. \"shame, shame, shame\".\n\nthanks!\n\n\n> I'd suggest to move the various\n> \textern char __start_opd[], __end_opd[];\n> out of arch//include/asm/sections.h and into \n\nok, will take a look.\n\n\t-ss","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx5qL0BYlz9s3w\n\tfor ;\n\tTue, 19 Sep 2017 12:07:26 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xx5qK5ps8zDqT0\n\tfor ;\n\tTue, 19 Sep 2017 12:07:25 +1000 (AEST)","from mail-pg0-x243.google.com (mail-pg0-x243.google.com\n\t[IPv6:2607:f8b0:400e:c05::243])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xx5nR1m6LzDqF3\n\tfor ;\n\tTue, 19 Sep 2017 12:05:45 +1000 (AEST)","by mail-pg0-x243.google.com with SMTP id u18so1093232pgo.1\n\tfor ;\n\tMon, 18 Sep 2017 19:05:45 -0700 (PDT)","from localhost ([39.7.53.230]) by smtp.gmail.com with ESMTPSA id\n\tb68sm851719pfk.23.2017.09.18.19.05.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 19:05:42 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mqoVncHJ\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mqoVncHJ\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::243; helo=mail-pg0-x243.google.com;\n\tenvelope-from=sergey.senozhatsky.work@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mqoVncHJ\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=4yGyamY0S3H/zB7YW/Zi1gSMrBJU6FtI/RDLFDTMO78=;\n\tb=mqoVncHJKnkGc4f8h5C9Zmh66e0S9VW21fQ4KL3L/RzX8+za61eNmLxhvR+MnmysWS\n\tO9UUTzAhtppU+MEiFXHe4/Q/h820IRiQknNwLr5iNeTE9Vd+11dT/RVDb7hGVthBU5rv\n\tPpOozC2keeWdB6wCpV3hyYh6K1QEV7p5SGy4QMYMYYnLd1qUy7+r9CsuwKO9pootLgDN\n\t6T05mUAw6x4POyyepeHr8qWpdh1jT+HMxukxPQhPUaZ/q5WU6eEXzncA9lbnrfJDzag6\n\txWLXkwmPyVgtFr7NiA/RMatU5Wji4+vvHGH2cDxyiRd4P14jqcxdlq1Jd94MhL8qaJCa\n\tTbAQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=4yGyamY0S3H/zB7YW/Zi1gSMrBJU6FtI/RDLFDTMO78=;\n\tb=kVP4upgQaJIHYfbob78HdaxMoyb2VrpDPvdGdVz+Yn1FfoPjN9u1KWiwRp+jmGXqTV\n\ttW5YCsKW7ydlJN6dAlvkhc9MlLFbIOutMa3qdN+Y1p/MWExM32nl7MrheVLDhyJH0Z/G\n\tMJa2iduT8ubbjMc6tRW1nhRDK1ffuGc3kP/Mf3nIphA0APGYL6QJ5Fa86dacWfR8SE0X\n\twiTQ3HPCowNLq/vdSXUJTspqCjaXOTkAJPGd+L/MhFYyHgeQdKApGkHSY9yzn2eUQMKD\n\tQAgwDyLKqVgnvyoWe4LWTyw3YvI3A/4O1fJDAPk2J2I6r+8FsJqWsYdkiH05XX0mJ+Vv\n\tefsQ==","X-Gm-Message-State":"AHPjjUhmBOq0SZHfYyqGujCftPI93kTs/WlqrYNb9lD9eH4Q+7WXbZkm\n\tSlWSyRbfueTmXQ==","X-Google-Smtp-Source":"AOwi7QARZHfTwsrjQvYB6QAfcBe/YXlTunPx0KpfassnOlinvdjmkGZe8grIlWyIOTU0Ckx7EvI0hA==","X-Received":"by 10.84.205.70 with SMTP id o6mr528906plh.350.1505786743546;\n\tMon, 18 Sep 2017 19:05:43 -0700 (PDT)","Date":"Tue, 19 Sep 2017 11:05:38 +0900","From":"Sergey Senozhatsky ","To":"Helge Deller ","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Message-ID":"<20170919020537.GA16991@jagdpanzerIV.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918183902.GA30752@p100.box>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\tlinux-ia64@vger.kernel.org, Petr Mladek ,\n\tJessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras ,\n\tAndrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1770610,"web_url":"http://patchwork.ozlabs.org/comment/1770610/","msgid":"<20170919020812.GB16991@jagdpanzerIV.localdomain>","date":"2017-09-19T02:08:13","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":67261,"url":"http://patchwork.ozlabs.org/api/people/67261/","name":"Sergey Senozhatsky","email":"sergey.senozhatsky.work@gmail.com"},"content":"On (09/18/17 10:44), Luck, Tony wrote:\n[..]\n> \n> A few new warnings when building on ia64:\n> \n> arch/ia64/kernel/module.c:931: warning: passing argument 1 of 'dereference_function_descriptor' makes pointer from integer without a cast\n> arch/ia64/kernel/module.c:931: warning: return makes integer from pointer without a cast\n> kernel/kallsyms.c:325: warning: assignment makes integer from pointer without a cast\n> kernel/kallsyms.c:325: warning: passing argument 1 of 'dereference_kernel_function_descriptor' makes pointer from integer without a cast\n\ngot it, will address in v2.\n\n[..]\n> Which looks like what you wanted. People unaware of the vagaries\n> of ppc64/ia64/parisc64 can use the wrong %p[SF] variant, but still\n> get the right output.\n\nthanks!\n\n\t-ss","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xx5sz1yCTz9s7B\n\tfor ;\n\tTue, 19 Sep 2017 12:09:43 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xx5sz0FkYzDqNc\n\tfor ;\n\tTue, 19 Sep 2017 12:09:43 +1000 (AEST)","from mail-pg0-x241.google.com (mail-pg0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c05::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xx5rM1ZgjzDqF3\n\tfor ;\n\tTue, 19 Sep 2017 12:08:19 +1000 (AEST)","by mail-pg0-x241.google.com with SMTP id m30so1207206pgn.5\n\tfor ;\n\tMon, 18 Sep 2017 19:08:19 -0700 (PDT)","from localhost ([39.7.53.230]) by smtp.gmail.com with ESMTPSA id\n\tp12sm678240pgn.90.2017.09.18.19.08.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 19:08:15 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"T6pP2E/J\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"T6pP2E/J\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::241; helo=mail-pg0-x241.google.com;\n\tenvelope-from=sergey.senozhatsky.work@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"T6pP2E/J\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=CWHBB82xXR0vVyiB0vhLpyJ67HSLQGlo252sX0/9kVs=;\n\tb=T6pP2E/J+f0838Zk1hWI/37N5n0h0SRjZQh+YCwF4vIyOjYSWxlg3j0Tz36uj579Wa\n\tRD2DNCUKrW8W67s5SH9w/+tuN7C3Bp6bem5aZOv3Lmm/NL9Ei6zft73EFtEqX6vHpO4S\n\t3d2JU7sspzA1zYTym/ny4CKkbGy5aBn0zmX5+mgCJ3lzQYtAuXBPGGYKLzbSi9dW5XRR\n\tW4LDiMOtkz8uB4TaX6aztFISddp5+eIHHtXiqgvG3PB5WLGCNfnVnVaF60Qa/kysmAXW\n\tvQVbVrX+F0Ma0fNQUJu8eCUNzd24/hUxvOovdNuO2zHU9aqMtlIScd8QRibsfGS4aqBG\n\t+Asg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=CWHBB82xXR0vVyiB0vhLpyJ67HSLQGlo252sX0/9kVs=;\n\tb=sIwcp1+0h8Yv4fy6QC7bkKfShpcy0N/MK9x2hTctLh86I4nUYuz3vSEDoNsGbJ71Jd\n\tcFfYXBUKFRP9KMvl+vL2rtN7DA13PVE7/PfwUT+lLQkFvGIov9HGxeJ/szQ/BSZChqP0\n\t5WS+SicFbwExg4frBrE8+lesCMZwzw0RhgJu06jRqPzCpAmeXY6p/ja6af3LmmIjZhvP\n\tsz5yf5wCu+FbzyvYR3kfNSMnjsTpCzrQfhmlQeNCVMTtRy5btAsLI8k4xm+NevK3WgSh\n\tYXmJ/tTerr6JZ+2rdmU8VSn4YUEwEe6xg9DHxC3mw864oxS1FBMIYgVzYNzfuR7zSmcX\n\tEqvA==","X-Gm-Message-State":"AHPjjUjpBenb+BfPfBY8JhBnO2Zi/J52pPNubqPnMpYzEF11O4J3vZce\n\t64yM6vHIXZYvXg==","X-Google-Smtp-Source":"AOwi7QAPCrbk3yKZ/kPvrjmu4k3YW4Bo5C5y6E2l9z4RxDP1viZQKJyA0qeJt7crOx3TtRM5K2xryQ==","X-Received":"by 10.84.129.103 with SMTP id 94mr521626plb.151.1505786897062;\n\tMon, 18 Sep 2017 19:08:17 -0700 (PDT)","Date":"Tue, 19 Sep 2017 11:08:13 +0900","From":"Sergey Senozhatsky ","To":"\"Luck, Tony\" ","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Message-ID":"<20170919020812.GB16991@jagdpanzerIV.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170918174432.4fksyzco2g6gczwe@intel.com>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , linux-ia64@vger.kernel.org,\n\tlinux-parisc@vger.kernel.org, Petr Mladek ,\n\tHelge Deller , Jessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras ,\n\tAndrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771026,"web_url":"http://patchwork.ozlabs.org/comment/1771026/","msgid":"<063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>","date":"2017-09-19T13:38:42","subject":"RE: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":6689,"url":"http://patchwork.ozlabs.org/api/people/6689/","name":"David Laight","email":"David.Laight@ACULAB.COM"},"content":"From: Sergey Senozhatsky\n> Sent: 19 September 2017 03:06\n...\n> I'll simply convert everything to `unsigned long'. including the\n> dereference_function_descriptor() function [I believe there are\n> still some casts happening when we pass addr from kernel/module\n> dereference functions to dereference_function_descriptor(), or\n> when we return `void *' back to symbol resolution code, etc.)\n> besides, it seems that everything that uses\n> dereference_function_descriptor() wants `unsigned long' anyway:\n\nUsing 'unsigned long' for any kind of pointer is an accident\nwaiting do happen.\nIt also makes it difficult to typecheck the function calls.\nUsing 'void *' isn't any better.\nEither a pointer to an undefined struct, or a struct containing\na single 'char' member, is likely to be safest.\n\n\tDavid","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxPBW3sLQz9rxl\n\tfor ;\n\tTue, 19 Sep 2017 23:40:03 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxPBW2sqCzDqlR\n\tfor ;\n\tTue, 19 Sep 2017 23:40:03 +1000 (AEST)","from smtp-out4.electric.net (smtp-out4.electric.net\n\t[192.162.216.186])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxP9D4pp2zDq8f\n\tfor ;\n\tTue, 19 Sep 2017 23:38:56 +1000 (AEST)","from 1duIja-0006Bc-Tq by out4b.electric.net with emc1-ok (Exim\n\t4.87) (envelope-from )\n\tid 1duIjc-0006Ju-Ub; Tue, 19 Sep 2017 06:38:44 -0700","by emcmailer; Tue, 19 Sep 2017 06:38:44 -0700","from [156.67.243.126] (helo=AcuExch.aculab.com)\n\tby out4b.electric.net with esmtps (TLSv1:AES128-SHA:128) (Exim 4.87)\n\t(envelope-from )\n\tid 1duIja-0006Bc-Tq; Tue, 19 Sep 2017 06:38:42 -0700","from ACUEXCH.Aculab.com ([::1]) by AcuExch.aculab.com ([::1]) with\n\tmapi id 14.03.0123.003; Tue, 19 Sep 2017 14:38:43 +0100"],"Authentication-Results":"ozlabs.org;\n\tspf=softfail (mailfrom) smtp.mailfrom=aculab.com\n\t(client-ip=192.162.216.186; helo=smtp-out4.electric.net;\n\tenvelope-from=david.laight@aculab.com; receiver=)","From":"David Laight ","To":"'Sergey Senozhatsky' , Helge Deller\n\t","Subject":"RE: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Thread-Topic":"[PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Thread-Index":"AQHTMOwDT4Uu8fKFA0OVdqOPpU6rUKK8Noug","Date":"Tue, 19 Sep 2017 13:38:42 +0000","Message-ID":"<063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>","In-Reply-To":"<20170919020537.GA16991@jagdpanzerIV.localdomain>","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.202.99.200]","Content-Type":"text/plain; charset=\"Windows-1252\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Outbound-IP":"156.67.243.126","X-Env-From":"David.Laight@ACULAB.COM","X-Proto":"esmtps","X-Revdns":"","X-HELO":"AcuExch.aculab.com","X-TLS":"TLSv1:AES128-SHA:128","X-Authenticated_ID":"","X-PolicySMART":"3396946, 3397078","X-Virus-Status":["Scanned by VirusSMART (c)","Scanned by VirusSMART (s)"],"X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\t\"linux-ia64@vger.kernel.org\" ,\n\tPetr Mladek ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt , Alexei\n\tStarovoitov ,\n\tSergey Senozhatsky , \n\tPaul Mackerras , Jessica Yu , Andrew\n\tMorton ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771058,"web_url":"http://patchwork.ozlabs.org/comment/1771058/","msgid":"","date":"2017-09-19T14:07:17","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":1115,"url":"http://patchwork.ozlabs.org/api/people/1115/","name":"Helge Deller","email":"deller@gmx.de"},"content":"On 19.09.2017 04:05, Sergey Senozhatsky wrote:\n> On (09/18/17 20:39), Helge Deller wrote:\n>> I did tried your testcases [on parisc] too.\n...\n>> and here is \"modprobe zram\":\n>> printk#7 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n>> printk#8 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n>> printk#9 do_one_initcall+0x194/0x290\n>> printk#10 do_one_initcall+0x194/0x290\n>> printk#11 do_one_initcall+0x194/0x290\n>> printk#12 do_one_initcall+0x194/0x290\n>> printk#13 zram_init+0x22c/0x2a0 [zram]\n>> printk#14 zram_init+0x22c/0x2a0 [zram]\n>> printk#15 zram_init+0x22c/0x2a0 [zram]\n>> printk#16 zram_init+0x22c/0x2a0 [zram]\n>>\n>> I wonder why printk#7 and printk#8 don't show \"zram_init\"...\n> \n> interesting... what does the unpatched kernel show?\n\nReally strange.\nThe unpatched kernel shows __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 too.\nThe symbol should be known, because later on in printk13 it shows correctly zram_init.\nI'll need to dig deeper into it, but at least the regression is not due\nto your patch.\n\nHelge","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxPr03pfMz9s7c\n\tfor ;\n\tWed, 20 Sep 2017 00:09:04 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxPr02yq9zDqp9\n\tfor ;\n\tWed, 20 Sep 2017 00:09:04 +1000 (AEST)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxPpn6MWZzDq8f\n\tfor ;\n\tWed, 20 Sep 2017 00:08:01 +1000 (AEST)","from [192.168.20.60] ([91.36.202.199]) by mail.gmx.com (mrgmx103\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 0LaGfK-1dXrwD0g8M-00m3LT;\n\tTue, 19 Sep 2017 16:07:23 +0200"],"Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmx.de\n\t(client-ip=212.227.17.22; helo=mout.gmx.net;\n\tenvelope-from=deller@gmx.de; receiver=)","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","To":"Sergey Senozhatsky ","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>","From":"Helge Deller ","Message-ID":"","Date":"Tue, 19 Sep 2017 16:07:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170919020537.GA16991@jagdpanzerIV.localdomain>","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Provags-ID":"V03:K0:MvwSk7vV+UYhlPeQEivqkVvXstEZY0bsyokmZTY02pvJwPHqv0x\n\tI5Ze/NP0xu3sZgfivpbeMoNriw/2RQCJF92yEI29uxolgL5mDL0XlbRU7ZP2yk4ah491vZG\n\t/QF+9abuWmXbbmf0xpe/Vdg5O88DuZPeGAkrRITFpnR6bzmY4OosLLbzWO86t6x9376hQY4\n\tiZQ/iYI3qI8swlCsnlWKw==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:ByIlaUwYsfI=:+6WzVjZMGnzu9bqq2Ko5E5\n\tjI+ablsGcQej6vC7CnI/Nw9v7sOXij8cCHSaLHy3D/LlvQKRiA6iuxzHoA3k1Jm1V+q8OFUfV\n\t+qWKUPA3TD4E6/yfUIvp0tPZSwaR0naPcs4fJ1RQhgULadLHvwgn67fnZL85PFWXt9FIpSgCI\n\tZqS6xF2ps0B6uQVvtr4f/hEGZdpZjrwSngoYYkmJukLgL4bzfDFWLASRZfj8+Gsdy/cDI232t\n\t3t3p1FL1fMklQr+Rlmz8LNyaWSamRhNc3g73OL7+S3MbgPLimKd3LTmx9WNLL6oNTcX5hbTYg\n\tQH5ubV254pq4v8vxMbpWgcMeyRkFqztrv6WrYcgKdNokYyRNEQX2y4VR3JaBgeiMP9sOTxY9l\n\tBBi2VA7VtVezcFw7qZz84djbJruxEW07pDN+CrD7w7rkd9VhsAeupEIgc+1/A92JJZ7nv2Wt1\n\thdUePFmOiNeYYNrjoahf+6cnnIxLlWEUWZLEJ97B7yzA88lUScZRLurdv03xY6r5SgaZ/IHWT\n\tTYLghjFSuzc5RUsL82sZ+RAdwoQo4RmMEQ3/3sobbRQUtUEjBHppKfYhOg64qpcYRE8y7qk4a\n\t46V+gQkA/OEE4WIbqOzp64egHlikzKdrznPsjAqYk9dMH6MQ101O7SriSOCNz/lvgXGVJCn6N\n\t5RsJZfJtFMAv89uVdX11AU9I4ttzeABK0Jw1SAzry8dmTolqi7yEawwABAuXchpRPn2Fl13E3\n\tvVAP1jeGFHqKOUKPr8lgkd1ENXM9dfButv5pQF9i5IhGDm///m3b4L9zP3TD+v2AKfWPRP3ar\n\tBRUeXJahjJMVHnV5RJm4qO/Cdr33R7PA2pgeeR9xOzvQ+PTCoE=","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\tlinux-ia64@vger.kernel.org, Petr Mladek ,\n\tJessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras ,\n\tAndrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771348,"web_url":"http://patchwork.ozlabs.org/comment/1771348/","msgid":"<20170919200357.GA15803@p100.box>","date":"2017-09-19T20:03:57","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":1115,"url":"http://patchwork.ozlabs.org/api/people/1115/","name":"Helge Deller","email":"deller@gmx.de"},"content":"* Helge Deller :\n> On 19.09.2017 04:05, Sergey Senozhatsky wrote:\n> >On (09/18/17 20:39), Helge Deller wrote:\n> >>I did tried your testcases [on parisc] too.\n> ...\n> >>and here is \"modprobe zram\":\n> >> printk#7 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n> >> printk#8 __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 [zram]\n> >> printk#9 do_one_initcall+0x194/0x290\n> >> printk#10 do_one_initcall+0x194/0x290\n> >> printk#11 do_one_initcall+0x194/0x290\n> >> printk#12 do_one_initcall+0x194/0x290\n> >> printk#13 zram_init+0x22c/0x2a0 [zram]\n> >> printk#14 zram_init+0x22c/0x2a0 [zram]\n> >> printk#15 zram_init+0x22c/0x2a0 [zram]\n> >> printk#16 zram_init+0x22c/0x2a0 [zram]\n> >>\n> >>I wonder why printk#7 and printk#8 don't show \"zram_init\"...\n> >\n> >interesting... what does the unpatched kernel show?\n> \n> Really strange.\n> The unpatched kernel shows __UNIQUE_ID_vermagic8+0xb9a4/0xbd04 too.\n> The symbol should be known, because later on in printk13 it shows correctly zram_init.\n> I'll need to dig deeper into it, but at least the regression is not due\n> to your patch.\n\nSergey, I was wrong with this assumption.\n\nYour implementation of dereference_module_function_descriptor() in\narch/parisc/kernel/module.c is faulty.\nmod->arch.fdesc_offset is relative to the base address of the module,\nso you need to add to mod->core_layout.base.\n\nHere is the relevant patch to fix this issue (against mainline).\nAdditionally I compare against mod->arch.fdesc_count instead of\nmod->arch.fdesc_max.\nCan you please fold it into your patch\n[PATCH 4/5] parisc64: Add .opd based function descriptor dereference\nfor the next round?\n\nThanks,\nHelge\n\nSigned-off-by: Helge Deller \n\ndiff --git a/arch/parisc/kernel/module.c b/arch/parisc/kernel/module.c\nindex f1a7693..ae3e6c5 100644\n--- a/arch/parisc/kernel/module.c\n+++ b/arch/parisc/kernel/module.c\n@@ -66,6 +66,7 @@\n \n #include \n #include \n+#include \n \n #if 0\n #define DEBUGP printk\n@@ -954,3 +955,19 @@ void module_arch_cleanup(struct module *mod)\n {\n \tderegister_unwind_table(mod);\n }\n+\n+#ifdef CONFIG_64BIT\n+unsigned long dereference_module_function_descriptor(struct module *mod,\n+\t\t\t\t\t unsigned long addr)\n+{\n+\tunsigned long opd_start = (Elf64_Addr) mod->core_layout.base\n+\t\t\t\t\t+ mod->arch.fdesc_offset;\n+\tunsigned long opd_end = opd_start\n+\t\t\t+ mod->arch.fdesc_count * sizeof(Elf64_Fdesc);\n+\n+\tif (addr < opd_start || addr >= opd_end)\n+\t\treturn addr;\n+\n+\treturn (unsigned long) dereference_function_descriptor((void *) addr);\n+}\n+#endif","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxYmT0Nwsz9sMN\n\tfor ;\n\tWed, 20 Sep 2017 06:06:33 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxYmS4V51zDqXv\n\tfor ;\n\tWed, 20 Sep 2017 06:06:32 +1000 (AEST)","from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxYkL0QqHzDqNh\n\tfor ;\n\tWed, 20 Sep 2017 06:04:41 +1000 (AEST)","from p100.box ([91.36.202.199]) by mail.gmx.com (mrgmx003\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 0Lugbo-1dCR623osS-00zqoU;\n\tTue, 19 Sep 2017 22:04:03 +0200"],"Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmx.de\n\t(client-ip=212.227.15.18; helo=mout.gmx.net;\n\tenvelope-from=deller@gmx.de; receiver=)","Date":"Tue, 19 Sep 2017 22:03:57 +0200","From":"Helge Deller ","To":"Sergey Senozhatsky ","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Message-ID":"<20170919200357.GA15803@p100.box>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-Provags-ID":"V03:K0:SnNtMtv19b7zOj3XVlK8MTLu6lF7pUKyLUkIN+fmxIPW0376ABE\n\tE3ft58gK0vZwsn4aBILv5ypB14/VG/QBU+RtZyViswkblmqc1kAWxQ7TmEXxg/8u4+nE4tD\n\tfSu7g2cbg3E8T+yo4FORl6a7TWBH7rDmSNclpqnoquy5JF+HhOgXP5+KdcaQq4wSsBMM+Po\n\tMUY9Yb9wgY/+pbQTdw4Ww==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:8dxopjyzuTg=:4sfUfdcg6Exf8BS9uxG8PW\n\tp46ULnat8aWKCp4FpD+owdqxEw2FeweRN074CrLpP/UEEXtX1Qwes2G68TQSl7ud1EPvEU7Nz\n\t9ABFIBsQjX4EndHXQwGbcQLWGDGW8qZoO9Ww2/hhKE6Y1CniQvhyxLT9vWHttsIZFEagQUGuH\n\tJRVCO/Gs3rXvpIVYelybMdM18MRznlOwizswih3CK0/BBCEVn09pFc+1JrQwKnZ7992U/ZGcR\n\tQ085kVrDcm9cnNx8QWQjEEQ7HeftCU6B+Mx7N80YxT4cBwMWSmu2BrZ2xmZjGaD4VCeOp+4UT\n\tKlufnM8ltcxJbyTFQAgfkM10gPoEoRnhgJhctBipfZaulI6Qh7n83BmbU5Jdqgv+TCX4i4YKA\n\tGNjDVN2MG+F5H63/gYFMCan8/Kp9oc2YXOm0KpGTWob9+mBQjQgTdDnkyhMS5+TUUvzGes3+c\n\tPh3d9lvQGr+eKDcdJAxmzqfAQPLxdOtyLRScI+brVC4cTmKqat7w4sFm5WKajIchrB7z9nys3\n\tmcv7NPjYNs5rbPdEsobHxOVlFPO33DPadsz3fjc2D2Z4n+9hi4NMY0GdEy2x0qj83VaVaRrJ2\n\tT2iF7deiNFHvWZxiRFX5jPrn2dkQKLqSkzkpr/RUyqWN/48BQDe/Zv3EohqwH87CS0jNjYc9d\n\t5rljiqIQXQ2021csMbDMfd/qCoIRXsLF7vYqnliufX0XVSnDcF8Xl47xB0YTkZU+3r+e1v/TR\n\ta/BX79oM/fCQItzO0hE8J2q5j/NiiinublbGhz0Kei7imEP6zUK9CY9b80+UyxgWf4vB+Z/eZ\n\toLLo9cgWaE+NzgxN46N2aNilb+bDw==","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\tlinux-ia64@vger.kernel.org, Petr Mladek ,\n\tJessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras ,\n\tAndrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771355,"web_url":"http://patchwork.ozlabs.org/comment/1771355/","msgid":"","date":"2017-09-19T20:07:31","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":1115,"url":"http://patchwork.ozlabs.org/api/people/1115/","name":"Helge Deller","email":"deller@gmx.de"},"content":"On 19.09.2017 15:38, David Laight wrote:\n> From: Sergey Senozhatsky\n>> Sent: 19 September 2017 03:06\n> ...\n>> I'll simply convert everything to `unsigned long'. including the\n>> dereference_function_descriptor() function [I believe there are\n>> still some casts happening when we pass addr from kernel/module\n>> dereference functions to dereference_function_descriptor(), or\n>> when we return `void *' back to symbol resolution code, etc.)\n>> besides, it seems that everything that uses\n>> dereference_function_descriptor() wants `unsigned long' anyway:\n> \n> Using 'unsigned long' for any kind of pointer is an accident\n> waiting do happen.\n> It also makes it difficult to typecheck the function calls.\n> Using 'void *' isn't any better.\n> Either a pointer to an undefined struct, or a struct containing\n> a single 'char' member, is likely to be safest.\n\nDavid, you might be right in most cases, but in this case I'd prefer\nunsigned long too. I think this will create the least amount of\ntypecasts here.\n\nHelge","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxYqv49Rjz9s81\n\tfor ;\n\tWed, 20 Sep 2017 06:09:31 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxYqv3G5szDqb5\n\tfor ;\n\tWed, 20 Sep 2017 06:09:31 +1000 (AEST)","from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxYpC0jTWzDqNh\n\tfor ;\n\tWed, 20 Sep 2017 06:08:02 +1000 (AEST)","from [192.168.20.60] ([91.36.202.199]) by mail.gmx.com (mrgmx003\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 0Lg0wl-1daxEz2G2F-00pcBz;\n\tTue, 19 Sep 2017 22:07:34 +0200"],"Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmx.de\n\t(client-ip=212.227.15.18; helo=mout.gmx.net;\n\tenvelope-from=deller@gmx.de; receiver=)","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","To":"David Laight ,\n\t'Sergey Senozhatsky' ","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>\n\t<063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>","From":"Helge Deller ","Message-ID":"","Date":"Tue, 19 Sep 2017 22:07:31 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Provags-ID":"V03:K0:5D74uQQEyTAfMr25zbg/O8eS4OrjnVk8S7Yxslxgt+BH/R9D8tK\n\tJesMpa990WhUza/JO2xrVH7nrRquAzH/zGmmOWbz+KCBEPXKIEMA6AEdqQBMzy0z6ATKHJC\n\tipl7NDAAaFqfFIS4L2Tz6c6EKSrUUU+uvvFYusHWxwL8xztD5MyQON31N1jTyN0wsAUJwNA\n\tVdy+FoN1wUqImFxyndqPA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:QlWbCJ5Cacg=:dHOKVBaGTvsiuXjmOeVs/c\n\tSPyi55BqsbYf/eILgIYvBqcH2M/qrrW6NURimPyH81UeNwS4vLJxYzW36fsce07idomnwvlD4\n\tw54nEInf4EMWOPeBYrGg2fl1zePGY16LUMIf/ITZJz7buCjo0CQX27y3FbmgUmfdCTCs/WjL1\n\tvRz501BXhdm1m9wUcJic+fragTZ3iWHKo5df5f4a8MZ8r0rlrpQqKfjrHponb8FJiUoQjnQWl\n\ty/riFC/0Cr6wUT8Yp7F+WRJEI5VHlKHFgCjdNQgzg+r8SIARtpTu4lE5Et7hHeFIbVtqjkSrC\n\t933DpUAppYPIpxi56mWFRd8zdJL4GHVBO3swcbVmEgUaLG8Sgv4KriB8W1b+Spye1r4xzwbGo\n\tj3rqj2eHx8yzh8tEeQI77GvpY0QJZEHyE7/Tc6FuQSrtv01pwkeqqI7zOKv4PipawqsOIKpNl\n\tOl2b9Iknnog66gAoqkbUyaWjDS2qKvLN1yS2ps18YWYl+jWwj11VRZs0HzAXTYRBp05d9d2Gv\n\tT55acjxDz+4eiaGtgpGrK6oAi4Q0eceWulhh7oZmTYDvXqXSC2AmJAHh+sqAw+74RQq0VTltD\n\tAZsh9mUDql8p82PJGwtvci2RrP+ZBNTE5EY69WS5YSnIrbK+VrnBvGSK7KNBttt0cayI5/qDm\n\tmkizaBAqqXOQ3py87Eaa1e+qoEOZfC2K0+dtqrv7URWJqi1uOWTqDTBxJuJ7LxuQySKGa9gMn\n\tYETOZohzT2skecpjXB7riJzZ7bkCY5up3ul6s03FseFtSRZUVP/ptMX3xAb9dXXXyLPN7t9qb\n\tjMfh24Gy+rHwZjGXqg52t1b/RaNddMMYtsY/qb+TFyYiQZ6y+0=","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\t\"linux-ia64@vger.kernel.org\" ,\n\tPetr Mladek ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras , Jessica Yu ,\n\tAndrew Morton ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771483,"web_url":"http://patchwork.ozlabs.org/comment/1771483/","msgid":"<20170920004715.GA6298@jagdpanzerIV.localdomain>","date":"2017-09-20T00:47:15","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":67261,"url":"http://patchwork.ozlabs.org/api/people/67261/","name":"Sergey Senozhatsky","email":"sergey.senozhatsky.work@gmail.com"},"content":"On (09/19/17 22:03), Helge Deller wrote:\n[..]\n> Your implementation of dereference_module_function_descriptor() in\n> arch/parisc/kernel/module.c is faulty.\n> mod->arch.fdesc_offset is relative to the base address of the module,\n> so you need to add to mod->core_layout.base.\n\naha, got it. I should have figured that out.\nmany thanks!\n\n\n> Here is the relevant patch to fix this issue (against mainline).\n> Additionally I compare against mod->arch.fdesc_count instead of\n> mod->arch.fdesc_max.\n\nhmm, .fdesc_max looked relevant to me. it's count_fdescs() - the\nnumber of R_PARISC_FPTR64 relocation entries.\n\nbut ok, will use .fdesc_count.\n\n\n> Can you please fold it into your patch\n> [PATCH 4/5] parisc64: Add .opd based function descriptor dereference\n> for the next round?\n\nsure, will fold. + SoB.\n\nI think I'll try to re-spin the series today (or tomorrow, I'm slightly\noverloaded with another stuff right now). I've received enough bug reports\nno need to wait for another week ;)\n\n\t-ss","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxh2S5ng5z9sNr\n\tfor ;\n\tWed, 20 Sep 2017 10:49:04 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxh2S4GMZzDqYw\n\tfor ;\n\tWed, 20 Sep 2017 10:49:04 +1000 (AEST)","from mail-pg0-x244.google.com (mail-pg0-x244.google.com\n\t[IPv6:2607:f8b0:400e:c05::244])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxh0V6hkGzDqNm\n\tfor ;\n\tWed, 20 Sep 2017 10:47:22 +1000 (AEST)","by mail-pg0-x244.google.com with SMTP id i130so724717pgc.0\n\tfor ;\n\tTue, 19 Sep 2017 17:47:22 -0700 (PDT)","from localhost ([110.70.59.92]) by smtp.gmail.com with ESMTPSA id\n\tm190sm6499671pga.2.2017.09.19.17.47.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 19 Sep 2017 17:47:19 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lMbPNnvJ\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lMbPNnvJ\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c05::244; helo=mail-pg0-x244.google.com;\n\tenvelope-from=sergey.senozhatsky.work@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"lMbPNnvJ\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=DIG+CRu8wUXt6S6+pCxAf5xOi0B1xbHg+eMQjC+gHDE=;\n\tb=lMbPNnvJjxJgbhmWkrOIBlTPtQB9hm40QDAfhIBeU5m7WRMVul+FK7hcO1OYC/3Vzg\n\thmIbMEoEIG0yykHFtkJODHXSAGseGLO+NTF+ramNlrNd8SNLGg59zHUa4c1zjOXm2W+t\n\tJAWU9OAtQfXIh9y3Hny4Eh0dxetQVH1pMmErq6bh7whaceCusbW3bqjhFPWbdNdkwmfc\n\toKqlKPccv4WrcseI3VqL3h7kzdXr8dDViTBjzxN84A2qsutI3jJQ+FO8m3RDlVs1aReX\n\twRDjeyBSQDc427igrKZrrNYxAK/zri2fvzijMXaJFLSTsGgSdPjNwbrCsgeGiN5Iqolg\n\teNlw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=DIG+CRu8wUXt6S6+pCxAf5xOi0B1xbHg+eMQjC+gHDE=;\n\tb=gsZeG0fULV8npyEUHZ8DRGlRyjwvYxFhz+M10nUUfVmza6G0Ct9UoRxjgxkTriGo4P\n\tBjdvtwsPnSYfndbolPY/Py3fMboGE4mpN6mwvuZjVt9CzY5WXSQ28wNBBVlDW3cRDeiW\n\toFGesg5UhEyuvWT5WKpWTB55sVeWlRm4EXhy6+bYdSRrTlTOZ4puAM/LZ+PHElKS8TyT\n\tU4WSxc01BCouQIh1xoRQsfnzyNoEusiOwESDVX9d3Gw2zQJKQfvpSLa+dHyQ3GqIoILA\n\tr7mCTuNsVg/E0sP/U46zjEwLPq2OvPQwqcHu2oqOVicHO1g32lQaLOMvC2gJ/hQhjWdI\n\txjEg==","X-Gm-Message-State":"AHPjjUjc5TGT0SUFG/qXlA25tmC83RhyXM/8biLpOhhbhqm3HbXrLzU/\n\tIP3MR/hjm9cv2FDXVkuRUe4=","X-Google-Smtp-Source":"AOwi7QDt+hUr4IVP3JZd6Q8sQhNRQyq2obPq0tP3LJUd9kNN65VIMcCHgSnyUJEdBBLmhZYNXwHr/g==","X-Received":"by 10.98.150.27 with SMTP id c27mr396608pfe.123.1505868440829;\n\tTue, 19 Sep 2017 17:47:20 -0700 (PDT)","Date":"Wed, 20 Sep 2017 09:47:15 +0900","From":"Sergey Senozhatsky ","To":"Helge Deller ","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Message-ID":"<20170920004715.GA6298@jagdpanzerIV.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>\n\t\n\t<20170919200357.GA15803@p100.box>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170919200357.GA15803@p100.box>","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\tlinux-ia64@vger.kernel.org,\n\tSergey Senozhatsky ,\n\tPetr Mladek , Jessica Yu ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras ,\n\tAndrew Morton , \n\tlinuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771689,"web_url":"http://patchwork.ozlabs.org/comment/1771689/","msgid":"<063D6719AE5E284EB5DD2968C1650D6DD007AF31@AcuExch.aculab.com>","date":"2017-09-20T08:41:40","subject":"RE: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":6689,"url":"http://patchwork.ozlabs.org/api/people/6689/","name":"David Laight","email":"David.Laight@ACULAB.COM"},"content":"From: Helge Deller\n> Sent: 19 September 2017 21:08\n...\n> > Using 'unsigned long' for any kind of pointer is an accident\n> > waiting do happen.\n> > It also makes it difficult to typecheck the function calls.\n> > Using 'void *' isn't any better.\n> > Either a pointer to an undefined struct, or a struct containing\n> > a single 'char' member, is likely to be safest.\n> \n> David, you might be right in most cases, but in this case I'd prefer\n> unsigned long too. I think this will create the least amount of\n> typecasts here.\n\nI've not looked at the specifics case...\n\nAnother option is using a struct with a single member and\npassing it by value.\nThis could be used for things like user-space pointers or\neven errno values.\nThe only problem is old ABI where even small structures are\nalways passed by reference.\n\n\tDavid","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxtkg274Jz9sBW\n\tfor ;\n\tWed, 20 Sep 2017 18:51:07 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxtkg0z9zzDqjr\n\tfor ;\n\tWed, 20 Sep 2017 18:51:07 +1000 (AEST)","from smtp-out4.electric.net (smtp-out4.electric.net\n\t[192.162.216.185])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxtXT5cR6zDqlw\n\tfor ;\n\tWed, 20 Sep 2017 18:42:17 +1000 (AEST)","from 1duaZg-0007jx-Uf by out4b.electric.net with emc1-ok (Exim\n\t4.87) (envelope-from )\n\tid 1duaa8-0001d9-T6; Wed, 20 Sep 2017 01:42:08 -0700","by emcmailer; Wed, 20 Sep 2017 01:42:08 -0700","from [156.67.243.126] (helo=AcuExch.aculab.com)\n\tby out4b.electric.net with esmtps (TLSv1:AES128-SHA:128) (Exim 4.87)\n\t(envelope-from )\n\tid 1duaZg-0007jx-Uf; Wed, 20 Sep 2017 01:41:40 -0700","from ACUEXCH.Aculab.com ([::1]) by AcuExch.aculab.com ([::1]) with\n\tmapi id 14.03.0123.003; Wed, 20 Sep 2017 09:41:41 +0100"],"Authentication-Results":"ozlabs.org;\n\tspf=softfail (mailfrom) smtp.mailfrom=aculab.com\n\t(client-ip=192.162.216.185; helo=smtp-out4.electric.net;\n\tenvelope-from=david.laight@aculab.com; receiver=)","From":"David Laight ","To":"'Helge Deller' , 'Sergey Senozhatsky'\n\t","Subject":"RE: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Thread-Topic":"[PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Thread-Index":"AQHTMOwDT4Uu8fKFA0OVdqOPpU6rUKK8NouggABcsoCAAOKrsA==","Date":"Wed, 20 Sep 2017 08:41:40 +0000","Message-ID":"<063D6719AE5E284EB5DD2968C1650D6DD007AF31@AcuExch.aculab.com>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>\n\t<063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>\n\t","In-Reply-To":"","Accept-Language":"en-GB, en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.202.99.200]","Content-Type":"text/plain; charset=\"Windows-1252\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Outbound-IP":"156.67.243.126","X-Env-From":"David.Laight@ACULAB.COM","X-Proto":"esmtps","X-Revdns":"","X-HELO":"AcuExch.aculab.com","X-TLS":"TLSv1:AES128-SHA:128","X-Authenticated_ID":"","X-PolicySMART":"3396946, 3397078","X-Virus-Status":["Scanned by VirusSMART (c)","Scanned by VirusSMART (s)"],"X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\t\"linux-ia64@vger.kernel.org\" ,\n\tPetr Mladek ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt , Alexei\n\tStarovoitov ,\n\tSergey Senozhatsky , \n\tPaul Mackerras , Jessica Yu , Andrew\n\tMorton ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1771723,"web_url":"http://patchwork.ozlabs.org/comment/1771723/","msgid":"","date":"2017-09-20T10:20:56","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":1115,"url":"http://patchwork.ozlabs.org/api/people/1115/","name":"Helge Deller","email":"deller@gmx.de"},"content":"On 20.09.2017 10:41, David Laight wrote:\n> From: Helge Deller\n>> Sent: 19 September 2017 21:08\n> ...\n>>> Using 'unsigned long' for any kind of pointer is an accident\n>>> waiting do happen.\n>>> It also makes it difficult to typecheck the function calls.\n>>> Using 'void *' isn't any better.\n>>> Either a pointer to an undefined struct, or a struct containing\n>>> a single 'char' member, is likely to be safest.\n>>\n>> David, you might be right in most cases, but in this case I'd prefer\n>> unsigned long too. I think this will create the least amount of\n>> typecasts here.\n> \n> I've not looked at the specifics case...\n> \n> Another option is using a struct with a single member and\n> passing it by value.\n\nActually, we do already have correct structs which could be referenced:\nparisc: struct Elf64_Fdesc\nia64:\tstruct fdesc\nppc64:\tstruct ppc64_opd_entry\n\nOne could \"#define platform_opd_entry\" to each of those depending on the platform and use it.\nIt might be misleading though, because the pointer which is handed over to\ndereference_function_descriptor() can be such a pointer but isn't necessary.\nI'll leave it up to Sergey to decide.\n\nHelge","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxwnP6q89z9s4q\n\tfor ;\n\tWed, 20 Sep 2017 20:23:37 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xxwnP5r13zDrJw\n\tfor ;\n\tWed, 20 Sep 2017 20:23:37 +1000 (AEST)","from mout.gmx.net (mout.gmx.net [212.227.15.15])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xxwl54GBPzDrFT\n\tfor ;\n\tWed, 20 Sep 2017 20:21:36 +1000 (AEST)","from [192.168.20.60] ([91.36.201.242]) by mail.gmx.com (mrgmx003\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 0MaZrd-1dfQed2tMf-00K9Ee;\n\tWed, 20 Sep 2017 12:21:02 +0200"],"Authentication-Results":"ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmx.de\n\t(client-ip=212.227.15.15; helo=mout.gmx.net;\n\tenvelope-from=deller@gmx.de; receiver=)","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","To":"David Laight ,\n\t'Sergey Senozhatsky' ","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>\n\t<063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>\n\t\n\t<063D6719AE5E284EB5DD2968C1650D6DD007AF31@AcuExch.aculab.com>","From":"Helge Deller ","Message-ID":"","Date":"Wed, 20 Sep 2017 12:20:56 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<063D6719AE5E284EB5DD2968C1650D6DD007AF31@AcuExch.aculab.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Provags-ID":"V03:K0:xR/cC1MKBKOs+N77qewqMET/QVGMeIcDq7IGPI0F2F/VcgB3Y4B\n\tx34z+ph/wRg5uFzTMdTfZ+j6IxOXk+BInxNgThOP8XtvAZ9om4TTJo/oaT2+VU2jr5xA7vp\n\tXnwqFM0M53SXustGqpOVIc0MOAVY7eKaT235n/f9jJGiM+cRik+ovDm8K7bdTR2m83qHqEH\n\t9dHA+RpLvP9TfT5SNgXig==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:L3hgo3ezFuI=:gXVgNOoav/LLo/bTU6PdWD\n\trN01afnY8HBAcb4nWG2ubn4EQLOmf1mxwjPMCnxBMID1yg5+ysgMtaINf6K+cNCWv59RTFcTZ\n\tlBUWP9ftitbJq35qR7XeC6ehvRCvrtJM9M9y20UQc48vB8vgNlPvpzaVqSOdBYm/rQnEOIIM6\n\trw/IZHrARb+MsaDVJHw3MGjoy3eh03U7lGPnLynvsbm5AGBQNXDCf8iLMSNghz3QDGrBE6n0u\n\tnD6LJDtmKSeI4yKpORtwQPjpinLodj9+ZnFEJRy72bzJStRLnQEbGWfDIGF2uQkgOXigCbr0j\n\tr7xSIZukSltNAkVBJiRXRF54uVrMK0UcIJDGve5RFBW4tUnFKLokSUkNXtbpM2uTPZMm57tCw\n\tYTNBenNsCDsPYXKCG2U9AbPYXLyEscVhoLo/+ydcTaKVTgvfiQjBQ3mWuo6GBsYD/DhU7fDrm\n\tkgVynXLW5W82cATB+QXqSp3DUQmzyE0bHbcmiVmsyXVd6kLrHIEQSDAAwE3+rjr9nI+bjuVPI\n\tUkuRqSMU2iLz7YoYXyrOhKG8pjC31Nv7gsFXRmE7+SmWKUn0UT2G3RDBNVwTxGZmS3TzQMhQm\n\tLj7g08C1q1N4qHFTJVyD2+IMc6w/d35Rkc9Xwx4uAnZYrxa+fgVnSmmqgXWTkcvmJnaJS1Vnh\n\tMyyE83MsHkbYQoRBLSiBgE6wE6pB4mX1Mlh1XsPzcW2brH1pgF9/aZjAB+DnKSwU6Ey0qz6cg\n\tFeipyBcJ94135tKntn8o+dEKUvIuNehbDmKEHkXGkqR6vxRg5NGrqKEYd5Coq+GihQ+I15zZN\n\tKdovs7QYtKQQZaFqPFQSQRN6DAR965/MVGyC4g7pUsVtEsQb0Q=","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\t\"linux-ia64@vger.kernel.org\" ,\n\tPetr Mladek ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras , Jessica Yu ,\n\tAndrew Morton ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}},{"id":1772060,"web_url":"http://patchwork.ozlabs.org/comment/1772060/","msgid":"<20170920163117.GA502@tigerII.localdomain>","date":"2017-09-20T16:31:17","subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","submitter":{"id":3905,"url":"http://patchwork.ozlabs.org/api/people/3905/","name":"Sergey Senozhatsky","email":"sergey.senozhatsky@gmail.com"},"content":"On (09/20/17 12:20), Helge Deller wrote:\n[..]\n> > I've not looked at the specifics case...\n> > \n> > Another option is using a struct with a single member and\n> > passing it by value.\n> \n> Actually, we do already have correct structs which could be referenced:\n> parisc: struct Elf64_Fdesc\n> ia64:\tstruct fdesc\n> ppc64:\tstruct ppc64_opd_entry\n> \n> One could \"#define platform_opd_entry\" to each of those depending on the platform and use it.\n> It might be misleading though, because the pointer which is handed over to\n> dereference_function_descriptor() can be such a pointer but isn't necessary.\n> I'll leave it up to Sergey to decide.\n\nHello,\n\nI think I'll keep 'unsigned long' for now.\n\n\t-ss","headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy5Lp6vbRz9sP1\n\tfor ;\n\tThu, 21 Sep 2017 02:49:38 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3xy5Lp5kR6zDqj2\n\tfor ;\n\tThu, 21 Sep 2017 02:49:38 +1000 (AEST)","from mail-pf0-x241.google.com (mail-pf0-x241.google.com\n\t[IPv6:2607:f8b0:400e:c00::241])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3xy4xk52DSzDqYP\n\tfor ;\n\tThu, 21 Sep 2017 02:31:22 +1000 (AEST)","by mail-pf0-x241.google.com with SMTP id i23so1386497pfi.2\n\tfor ;\n\tWed, 20 Sep 2017 09:31:22 -0700 (PDT)","from localhost ([121.137.63.184]) by smtp.gmail.com with ESMTPSA id\n\tu73sm8209896pfi.58.2017.09.20.09.31.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 09:31:20 -0700 (PDT)"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mjXy+yLY\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mjXy+yLY\"; dkim-atps=neutral","ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=gmail.com\n\t(client-ip=2607:f8b0:400e:c00::241; helo=mail-pf0-x241.google.com;\n\tenvelope-from=sergey.senozhatsky@gmail.com; receiver=)","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mjXy+yLY\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=noi78KycZmFW0SaLioMAHXiBzJAVWMXItrBDENtxfFY=;\n\tb=mjXy+yLYy57NiY3S2TBZjV0QdFazM4iiT3/e/zOBKsIu8RdB4LIC1YgPaQgvYX/dRv\n\thK9UkAQzJjpjEq7pRcoAXewHgBoAG7eqfOV4bt/Sn4DmbtJgR4nEOT0/fMXu/i9djfBB\n\tO6CXEP2UnrxCNrJo7NtVvm33dBOgEeKDO16eSZDae+q1Yx+DkdU3A3TnOScNlL7PODSS\n\tEwuu3hC6g41C3ie5c8NH6eL3qc5pZZ8y8p8lzwnwx7RSaH+hxlUFG2PosRfJb2u3Gvn5\n\tRnDTJN4URMWSFNYkUAZh6XyytykQfzI7VQdgw0zuZYGMqpND4FX6iLOAGKh9l0bWXr7v\n\tATGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=noi78KycZmFW0SaLioMAHXiBzJAVWMXItrBDENtxfFY=;\n\tb=k4C0ZrN3mPbw8HLB/uLAFLfPYWcr+/DcyZSQUqkU12B+t7nf81PwqIKZaZhKtg6Tl5\n\tJJvrDi7LHNVGqmoA2ssz4Fmm/Tah0On1ZUq0jEo679Icz4hNvjAbqVVKZGmwGj4FJm2C\n\trYlF9kWY9HRTYUKP1IMpop+LDFEzAj6ge9aiPn84FmSM4uwhPzjBZ7JMZt6fc9iaxlvI\n\tSveTr+vdLfmZ2bKO9EVfoB2RysoI+x0NNUlk9uRMs6nlxoUQBwfuwKoZbat3UXrcHBMf\n\tS8w12RS4MnDn8eNyy/PlbY7rbrxnki93M1L+JPjGpHH9RnwrFhJNbD59CmrS6f4YwN3B\n\tmhKA==","X-Gm-Message-State":"AHPjjUjEcXRg7iA/gaZDbOcmY9aOhdppFxr2Jzd9bj1BpAqKkVLxGVnp\n\tIHYTmdtX7559rQunibm5wzQ=","X-Google-Smtp-Source":"AOwi7QDaNLekSvdKEEVAVYJ7/8fCvUt0X4oAHScYLCJyXZdZjl/yVTrq7Ve2cDxwJF3FALvQ2F99oQ==","X-Received":"by 10.84.238.198 with SMTP id l6mr2647737pln.152.1505925080791; \n\tWed, 20 Sep 2017 09:31:20 -0700 (PDT)","Date":"Thu, 21 Sep 2017 01:31:17 +0900","From":"Sergey Senozhatsky ","To":"Helge Deller , David Laight ","Subject":"Re: [PATCH 0/5] [RFC] printk/ia64/ppc64/parisc64: let's deprecate\n\t%pF/%pf printk specifiers","Message-ID":"<20170920163117.GA502@tigerII.localdomain>","References":"<20170916035347.19705-1-sergey.senozhatsky@gmail.com>\n\t<20170918174432.4fksyzco2g6gczwe@intel.com>\n\t<20170918183902.GA30752@p100.box>\n\t<20170919020537.GA16991@jagdpanzerIV.localdomain>\n\t<063D6719AE5E284EB5DD2968C1650D6DD007A0D0@AcuExch.aculab.com>\n\t\n\t<063D6719AE5E284EB5DD2968C1650D6DD007AF31@AcuExch.aculab.com>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.9.0 (2017-09-02)","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.24","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Fenghua Yu , \"Luck, Tony\" ,\n\t\"linux-ia64@vger.kernel.org\" ,\n\t'Sergey Senozhatsky' ,\n\tPetr Mladek ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"James E . J . Bottomley\" ,\n\tSteven Rostedt ,\n\tAlexei Starovoitov , \n\tSergey Senozhatsky ,\n\tPaul Mackerras , Jessica Yu ,\n\tAndrew Morton ,\n\t\"linuxppc-dev@lists.ozlabs.org\" ","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"}}]