[{"id":1769350,"web_url":"http://patchwork.ozlabs.org/comment/1769350/","msgid":"<1505499388.27581.13.camel@perches.com>","list_archive_url":null,"date":"2017-09-15T18:16:28","subject":"Re: [PATCH 2/2] [media] stm32-dcmi: Improve four size determinations","submitter":{"id":771,"url":"http://patchwork.ozlabs.org/api/people/771/","name":"Joe Perches","email":"joe@perches.com"},"content":"On Fri, 2017-09-15 at 19:29 +0200, SF Markus Elfring wrote:\n> diff --git a/drivers/media/platform/stm32/stm32-dcmi.c b/drivers/media/platform/stm32/stm32-dcmi.c\n[]\n> @@ -1372,9 +1372,8 @@ static int dcmi_formats_init(struct stm32_dcmi *dcmi)\n> \tdcmi->sd_formats = devm_kcalloc(dcmi->dev,\n> -\t\t\t\t\tnum_fmts, sizeof(struct dcmi_format *),\n> +\t\t\t\t\tnum_fmts, sizeof(*dcmi->sd_formats),\n> \t\t\t\t\tGFP_KERNEL);\n> \tif (!dcmi->sd_formats)\n> \t\treturn -ENOMEM;\n> \n> -\tmemcpy(dcmi->sd_formats, sd_fmts,\n> -\t num_fmts * sizeof(struct dcmi_format *));\n> +\tmemcpy(dcmi->sd_formats, sd_fmts, num_fmts * sizeof(*dcmi->sd_formats));\n\ndevm_kmemdup","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"hslos+4N\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv3X20pdtz9s7h\n\tfor ;\n\tSat, 16 Sep 2017 04:17:06 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsvAk-00086f-PU; Fri, 15 Sep 2017 18:17:02 +0000","from smtprelay0168.hostedemail.com ([216.40.44.168]\n\thelo=smtprelay.hostedemail.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsvAg-00081E-3o for linux-arm-kernel@lists.infradead.org;\n\tFri, 15 Sep 2017 18:17:00 +0000","from filter.hostedemail.com (clb03-v110.bra.tucows.net\n\t[216.40.38.60])\n\tby smtprelay07.hostedemail.com (Postfix) with ESMTP id 02E0A181D3419; \n\tFri, 15 Sep 2017 18:16:33 +0000 (UTC)","from XPS-9350 (unknown [47.151.132.55])\n\t(Authenticated sender: joe@perches.com)\n\tby omf08.hostedemail.com (Postfix) with ESMTPA;\n\tFri, 15 Sep 2017 18:16:30 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To:\n\tDate:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=PGROUWmrMv+JRA/sj8Ope2WjYe9iofb10zC8cglJCRo=;\n\tb=hslos+4NdxHsFz\n\tgtTmoTUg2FKX5+70xGBG4oTF2WFGl0rDOt0HIvcVk9xvkYTWUny8lX6oLlN6FwRn/kc5BVySOquI5\n\tYtV05XQWIWV5mOlNStmbI7U73Bg1m6secMDTRYoGLiGd15rZUSiRpg6kJGxZ1IKa+yUwiZSMyR7wt\n\tipVH+Hj3SZ5FV2FFMBmYktWTpCdTwGF8syRpBI0Zb6K5XW3O6bB64Bmx/FXpe0s1vOV4cHfW87B8x\n\tmA+MGT76M7sPSRbssTweaQWfXO9zwwC69BuHdazloMgHO6QpnKhZHnrhcPHEVtdDuIpxdOp5puvvd\n\t27vcvgYWAH8pQaPniwzQ==;","X-Session-Marker":"6A6F6540706572636865732E636F6D","X-Spam-Summary":"2, 0, 0, , d41d8cd98f00b204, joe@perches.com,\n\t:::::::::::::::::::::::::,\n\tRULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1515:1516:1518:1534:1539:1567:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3622:3876:3877:4321:4605:5007:6114:6642:6737:10004:10400:10848:11026:11657:11658:11914:12043:12048:12296:12740:12760:12895:13069:13311:13357:13439:14659:14721:21080:21627:30054:30091,\n\t0, RBL:none, CacheIP:none, Bayesian:0.5, 0.5, 0.5, Netcheck:none,\n\tDomainCache:0, MSF:not bulk, SPF:, MSBL:0, DNSBL:none,\n\tCustom_rules:0:0:0, LFtime:2, LUA_SUMMARY:none","X-HE-Tag":"frame83_38ce0ecd0282b","X-Filterd-Recvd-Size":"1950","Message-ID":"<1505499388.27581.13.camel@perches.com>","Subject":"Re: [PATCH 2/2] [media] stm32-dcmi: Improve four size determinations","From":"Joe Perches ","To":"SF Markus Elfring , \n\tlinux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,\n\tAlexandre Torgue , \"Gustavo A. R. Silva\"\n\t, Hans Verkuil , Hugues\n\tFruchet , Mauro Carvalho Chehab\n\t, Maxime Coquelin ,\n\tPhilipp Zabel ,\n\tSakari Ailus ","Date":"Fri, 15 Sep 2017 11:16:28 -0700","In-Reply-To":"","References":"<730b535e-39a5-2c2b-f463-e76da967a723@users.sourceforge.net>\n\t","X-Mailer":"Evolution 3.22.6-1ubuntu1 ","Mime-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170915_111658_363186_219EA146 ","X-CRM114-Status":"UNSURE ( 6.85 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [216.40.44.168 listed in list.dnswl.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel-janitors@vger.kernel.org, LKML ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769364,"web_url":"http://patchwork.ozlabs.org/comment/1769364/","msgid":"","list_archive_url":null,"date":"2017-09-15T18:54:44","subject":"Re: [media] stm32-dcmi: Improve four size determinations","submitter":{"id":65077,"url":"http://patchwork.ozlabs.org/api/people/65077/","name":"SF Markus Elfring","email":"elfring@users.sourceforge.net"},"content":">> +\tmemcpy(dcmi->sd_formats, sd_fmts, num_fmts * sizeof(*dcmi->sd_formats));\n> \n> devm_kmemdup\n\nAre function variants provided which handle memory duplications\nfor arrays explicitly?\n\nRegards,\nMarkus","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"sYwm9Yp4\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xv4P045tzz9s7g\n\tfor ;\n\tSat, 16 Sep 2017 04:56:04 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsvmT-0002eS-6L; Fri, 15 Sep 2017 18:56:01 +0000","from mout.web.de ([212.227.15.14])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dsvmO-0002ap-Kx for linux-arm-kernel@lists.infradead.org;\n\tFri, 15 Sep 2017 18:55:58 +0000","from [192.168.1.2] ([78.48.52.106]) by smtp.web.de (mrweb004\n\t[213.165.67.108]) with ESMTPSA (Nemesis) id 0LcUIo-1dAUPQ0CQg-00juSu;\n\tFri, 15 Sep 2017 20:55:02 +0200"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=1xlOQCVfdoheeCA0kMVePtrKqv/iTzmUuT5D9/fGWKI=;\n\tb=sYwm9Yp4o/D+/M\n\tAWjzwBJgc0ntAxn+TL9oiqbR9H2YH0g6+/O0jpOtmi8f6X/IwncxNKyAUvO3C5qBmIg1u0hUyGBIW\n\tXQvggAgYuqGFQHnGhg7rkgtDRYZ9MUau1mkJm0mVKlZrqI/+McU19EIlq/Sa3HCYOLz3xn6aia9bJ\n\tfWIHE0z8GnpA7lwHFYPTjlIOdWChrNDW5RR6NcYiBeDoYahJT7BGihum0z0sN1MlHWVbiGr+kEyde\n\tYH8+MaDAvPJYttOnuSdVMHm8CTH0iJwdZouFdOVNTMXmvrXirnhvXmcBrWaz9wsf91+T76Ycw6WP7\n\t3oYymALS3XL9qL936dfQ==;","Subject":"Re: [media] stm32-dcmi: Improve four size determinations","To":"Joe Perches , linux-arm-kernel@lists.infradead.org,\n\tlinux-media@vger.kernel.org","References":"<730b535e-39a5-2c2b-f463-e76da967a723@users.sourceforge.net>\n\t\n\t<1505499388.27581.13.camel@perches.com>","From":"SF Markus Elfring ","Message-ID":"","Date":"Fri, 15 Sep 2017 20:54:44 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505499388.27581.13.camel@perches.com>","Content-Language":"en-GB","X-Provags-ID":"V03:K0:HM+zbnyHqjT1xdNHTbX/GZfsyiOuotMy+cQdlA+j6xLfe9zeslD\n\tAJvUJd6cZjFIkaONrHZ/rLupAwB1VySy5wH9dnXm6y9JFsVJrAeIfsbBadj4RZaaoF5//1V\n\t3E8Lm4jRYyJgtECwlXGjTYv1v3NprUdZqwSoB/3lwIQk69D0ycfHLcspRZE1pt4IWPnHTHR\n\tWPnba3zlZC0UdrSpRUBMA==","X-UI-Out-Filterresults":"notjunk:1; V01:K0:Rw14abY9rZU=:dsKP4klp2hkbuNLgU7QOeK\n\t7SD72T6esfZzSNYkMbsmK+hg04CftGIZ63DjA0uSEh+9nT8rPIeuwdfG4ADHAiyD5DEsY2B7o\n\tUjsO/mg3z8OY7TleqpBRMONxQ8eF6apHf4PJqDsh6zhxHFDR95ZdJEQ7zWT9RVCkB1e/f8M/t\n\tkSnYrmYO0t1nUhS7yMhZDndCB5nz3F0uimJKjnChDi8AoGfm6TWhoOavlF4OCzeUhMVUUxFD7\n\tgRtM1cnhNeItksW7ZxjHeSA2pA+CFNAsQnV7R6pliMmkMcabXgfXIa+lXtR3vAt4sz0yo3J97\n\tvr32oBRzZxR1OTqDedFH8wZVJsj6KeBOofnCtneWsgnnmeebvM8oeAgFiuQqSagdgJbCEyIkd\n\tUo0UA2HJ+X+1YNZ9tykllGIZx9kDVjSGLZKrrMon2z/naTgkq93uWuxYXYUoqHa3sWz8VzLPE\n\tv3/VN7Dm/i+dHnhUTOY7aH83GVfg0C77UEabQ5f6TBI+1vJDykNen16l/cw818zFs0xoqFXRb\n\tWLoALalTidEm9oVBrRKAGdIuhzMMZOk+XrGh0C96PWszJ3UCfYJ0hmidSHOLmxPqTIyjSBuM7\n\tXUB9pbKxwqpf6v2jB6UMcHDh91CbTZpXyRcWvpyTHtOD/zefg+gvmWnEX1hBCQFGEsnzb3mq5\n\tblXlRuTJm1dwC1GIDnHMfQUbpriRl8zC0+EMDwFXspt77JBVCXXwwIhWkQj58oYt95Ox3H+4V\n\t3AR7Q96HIyQ3GIIxiXh/Ia18dslaBhnDwcWVgEHNl0k1h7GDSuE1kbG0PzNnlUALJIX6oE7fv\n\tmEw9FGsF3sJ8edhol1hdobcD7VBr/1mjaMdYDqksjH8pdbyOGw=","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170915_115557_081765_C6626C15 ","X-CRM114-Status":"UNSURE ( 4.27 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.6 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [212.227.15.14 listed in list.dnswl.org]\n\t-0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4)\n\t[212.227.15.14 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Philipp Zabel ,\n\tAlexandre Torgue ,\n\tkernel-janitors@vger.kernel.org, LKML ,\n\tSakari Ailus ,\n\tHans Verkuil , \n\t\"Gustavo A. R. Silva\" ,\n\tMaxime Coquelin ,\n\tHugues Fruchet ,\n\tMauro Carvalho Chehab ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]