[{"id":1770011,"web_url":"http://patchwork.ozlabs.org/comment/1770011/","msgid":"<20170918092908.GF3617@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-18T09:29:08","subject":"Re: [Qemu-devel] [PATCH v2 0/2] x86_iommu: Fix segfault when\n\tstarting on non-PCI machines","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Fri, Sep 15, 2017 at 05:04:35PM +0200, Mohammed Gamal wrote:\n> Starting qemu with\n> qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu\n> leads to a segfault. The code assume PCI bus is present and\n> tries to access the bus structure without checking.\n> \n> The patch series moves the error checks from vtd_realize()\n> and amdvi_realize() to the generic x86_iommu_realize() and\n> adds a check for PCI bus presence.\n> \n> v1 --> v2:\n> * Change error message with capitalized acronym\n> \n> Mohammed Gamal (2):\n> x86_iommu: Move machine check to x86_iommu_realize()\n> x86_iommu: check if machine has PCI bus\n\nI'm fine with even keeping object_dynamic_cast() there in patch 1, but\nI agree with Eduardo's questioning.\n\nFor either case:\n\nReviewed-by: Peter Xu \n\n> \n> hw/i386/amd_iommu.c | 10 +---------\n> hw/i386/intel_iommu.c | 10 +---------\n> hw/i386/x86-iommu.c | 13 +++++++++++++\n> 3 files changed, 15 insertions(+), 18 deletions(-)\n> \n> -- \n> 1.8.3.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwgh82L1xz9s72\n\tfor ;\n\tMon, 18 Sep 2017 19:29:44 +1000 (AEST)","from localhost ([::1]:35408 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtsN4-00084C-FE\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 05:29:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55379)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtsMk-00082k-PL\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:29:23 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtsMh-0007qX-9z\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:29:22 -0400","from mx1.redhat.com ([209.132.183.28]:60788)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtsMh-0007pz-3j\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 05:29:19 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 26921356F0\n\tfor ; Mon, 18 Sep 2017 09:29:18 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5A2195D760;\n\tMon, 18 Sep 2017 09:29:09 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 26921356F0","Date":"Mon, 18 Sep 2017 17:29:08 +0800","From":"Peter Xu ","To":"Mohammed Gamal ","Message-ID":"<20170918092908.GF3617@pxdev.xzpeter.org>","References":"<1505487877-22799-1-git-send-email-mgamal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<1505487877-22799-1-git-send-email-mgamal@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tMon, 18 Sep 2017 09:29:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/2] x86_iommu: Fix segfault when\n\tstarting on non-PCI machines","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, thuth@redhat.com, mst@redhat.com,\n\tqemu-devel@nongnu.org, ehabkost@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]