[{"id":1770128,"web_url":"http://patchwork.ozlabs.org/comment/1770128/","msgid":"<20170918142902.1aa7fa4d.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-18T12:29:02","subject":"Re: [Qemu-devel] [PATCH v3 0/2] Virtio GPU for S390","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Fri, 15 Sep 2017 10:40:30 -0400\nFarhan Ali wrote:\n\n> These patches wire up the virtio-gpu device for CCW bus for\n> S390.\n> \n> For the S390 architecture which does not natively support any graphics\n> device, virtio gpu in 2D mode could be used to emulate a simple graphics\n> card and use VNC as the display.\n> \n> eg: qemu-system-s390x ... -device virtio-gpu-ccw,devno=fe.0.0101\n> -vnc host_ip_addr:5900\n> \n> Note, to actually see any display content the\n> guest kernel needs to support DRM layer, Virtio GPU driver,\n> the Virtual Terminal layer etc.\n> \n> I would appreciate any feedback on these patches, specially the\n> first patch.\n> \n> ChangeLog\n> --------\n> v1 -> v2\n> - remove error_propagate (patch 2)\n> - Add byteswap functions (patch 1)\n> - Handle endian conversion for virtio_gpu_ctrl_response (patch 1)\n> \n> v2 -> v3\n> - updated patch 1 based on Gerd's feedback\n> - rename bswap functions (patch 1)\n> - use in-place swapping functions (patch 1)\n> - Handle endian conversion for cursor update (patch 1)\n> \n> Thank you\n> Farhan\n> \n> \n> Farhan Ali (2):\n> virtio-gpu: Handle endian conversion\n> virtio-gpu-ccw: Create a virtio gpu device for the ccw bus\n> \n> hw/display/virtio-gpu.c | 70 +++++++++++++++++++++++++++++++++++++++++++------\n> hw/s390x/virtio-ccw.c | 49 ++++++++++++++++++++++++++++++++++\n> hw/s390x/virtio-ccw.h | 10 +++++++\n> 3 files changed, 121 insertions(+), 8 deletions(-)\n> \n\nThanks, applied.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwlgj5N4gz9s7M\n\tfor ;\n\tMon, 18 Sep 2017 22:29:34 +1000 (AEST)","from localhost ([::1]:36313 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtvB5-0006Qj-Mt\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 08:29:31 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57844)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtvAm-0006QX-EN\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:29:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtvAj-0006cb-8M\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:29:12 -0400","from mx1.redhat.com ([209.132.183.28]:32866)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dtvAj-0006cK-2C\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:29:09 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 8D3DC4A6E6;\n\tMon, 18 Sep 2017 12:29:07 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 2B6545D9C0;\n\tMon, 18 Sep 2017 12:29:04 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 8D3DC4A6E6","Date":"Mon, 18 Sep 2017 14:29:02 +0200","From":"Cornelia Huck ","To":"Farhan Ali ","Message-ID":"<20170918142902.1aa7fa4d.cohuck@redhat.com>","In-Reply-To":"","References":"","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tMon, 18 Sep 2017 12:29:07 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/2] Virtio GPU for S390","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com,\n\tqemu-devel@nongnu.org, kraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1770134,"web_url":"http://patchwork.ozlabs.org/comment/1770134/","msgid":"<34d07f47-a089-345b-273d-c864baf2b461@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-18T12:43:24","subject":"Re: [Qemu-devel] [PATCH v3 0/2] Virtio GPU for S390","submitter":{"id":71051,"url":"http://patchwork.ozlabs.org/api/people/71051/","name":"Farhan Ali","email":"alifm@linux.vnet.ibm.com"},"content":"On 09/18/2017 08:29 AM, Cornelia Huck wrote:\n> On Fri, 15 Sep 2017 10:40:30 -0400\n> Farhan Ali wrote:\n>\n>> These patches wire up the virtio-gpu device for CCW bus for\n>> S390.\n>>\n>> For the S390 architecture which does not natively support any graphics\n>> device, virtio gpu in 2D mode could be used to emulate a simple graphics\n>> card and use VNC as the display.\n>>\n>> eg: qemu-system-s390x ... -device virtio-gpu-ccw,devno=fe.0.0101\n>> -vnc host_ip_addr:5900\n>>\n>> Note, to actually see any display content the\n>> guest kernel needs to support DRM layer, Virtio GPU driver,\n>> the Virtual Terminal layer etc.\n>>\n>> I would appreciate any feedback on these patches, specially the\n>> first patch.\n>>\n>> ChangeLog\n>> --------\n>> v1 -> v2\n>> - remove error_propagate (patch 2)\n>> - Add byteswap functions (patch 1)\n>> - Handle endian conversion for virtio_gpu_ctrl_response (patch 1)\n>>\n>> v2 -> v3\n>> - updated patch 1 based on Gerd's feedback\n>> - rename bswap functions (patch 1)\n>> - use in-place swapping functions (patch 1)\n>> - Handle endian conversion for cursor update (patch 1)\n>>\n>> Thank you\n>> Farhan\n>>\n>>\n>> Farhan Ali (2):\n>> virtio-gpu: Handle endian conversion\n>> virtio-gpu-ccw: Create a virtio gpu device for the ccw bus\n>>\n>> hw/display/virtio-gpu.c | 70 +++++++++++++++++++++++++++++++++++++++++++------\n>> hw/s390x/virtio-ccw.c | 49 ++++++++++++++++++++++++++++++++++\n>> hw/s390x/virtio-ccw.h | 10 +++++++\n>> 3 files changed, 121 insertions(+), 8 deletions(-)\n>>\n>\n> Thanks, applied.\n>\n\nThanks","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwm4y3fKFz9s7F\n\tfor ;\n\tMon, 18 Sep 2017 22:48:02 +1000 (AEST)","from localhost ([::1]:36436 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtvSy-00077W-KI\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 08:48:00 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33627)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtvOh-0003tz-GO\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:43:36 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtvOc-0003bo-Hd\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:43:35 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34634\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dtvOc-0003ba-CA\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 08:43:30 -0400","from pps.filterd (m0098420.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8ICcp3b081835\n\tfor ; Mon, 18 Sep 2017 08:43:29 -0400","from e33.co.us.ibm.com (e33.co.us.ibm.com [32.97.110.151])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2d2e1215p4-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Mon, 18 Sep 2017 08:43:29 -0400","from localhost\n\tby e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tMon, 18 Sep 2017 06:43:28 -0600","from b03cxnp08027.gho.boulder.ibm.com (9.17.130.19)\n\tby e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 18 Sep 2017 06:43:26 -0600","from b03ledav004.gho.boulder.ibm.com\n\t(b03ledav004.gho.boulder.ibm.com [9.17.130.235])\n\tby b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8IChP2665667244; Mon, 18 Sep 2017 05:43:25 -0700","from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 7DB977804D;\n\tMon, 18 Sep 2017 06:43:25 -0600 (MDT)","from [9.56.58.73] (unknown [9.56.58.73])\n\tby b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP id D0E3E78037;\n\tMon, 18 Sep 2017 06:43:24 -0600 (MDT)"],"To":"Cornelia Huck ","References":"\n\t<20170918142902.1aa7fa4d.cohuck@redhat.com>","From":"Farhan Ali ","Date":"Mon, 18 Sep 2017 08:43:24 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"<20170918142902.1aa7fa4d.cohuck@redhat.com>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17091812-0008-0000-0000-000008965DC6","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007756; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000229; SDB=6.00918789; UDB=6.00461564;\n\tIPR=6.00699016; \n\tBA=6.00005594; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017195;\n\tXFM=3.00000015; UTC=2017-09-18 12:43:27","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091812-0009-0000-0000-00004404FD17","Message-Id":"<34d07f47-a089-345b-273d-c864baf2b461@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-18_03:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709180183","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v3 0/2] Virtio GPU for S390","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, thuth@redhat.com, kraxel@redhat.com,\n\tpasic@linux.vnet.ibm.com, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]