[{"id":1769585,"web_url":"http://patchwork.ozlabs.org/comment/1769585/","msgid":"<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>","list_archive_url":null,"date":"2017-09-16T09:45:47","subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","submitter":{"id":69366,"url":"http://patchwork.ozlabs.org/api/people/69366/","name":"Quentin Schulz","email":"quentin.schulz@free-electrons.com"},"content":"Hi Icenowy,\n\nOn 14/09/2017 16:52, Icenowy Zheng wrote:\n> This adds support for the Allwinner H3 thermal sensor.\n> \n> Allwinner H3 has a thermal sensor like the one in A33, but have its\n> registers nearly all re-arranged, sample clock moved to CCU and a pair\n> of bus clock and reset added. It's also the base of newer SoCs' thermal\n> sensors.\n> \n> The thermal sensors on A64 and H5 is like the one on H3, but with of\n> course different formula factors.\n> \n> Signed-off-by: Icenowy Zheng \n> ---\n> Changes in v4:\n> - Splitted out some code refactors.\n> - Code sequence changed back. (The gpadc_data went back to the start of\n> the source file)\n> \n> drivers/iio/adc/sun4i-gpadc-iio.c | 48 +++++++++++++++++++++++++++++++++++++++\n> include/linux/mfd/sun4i-gpadc.h | 27 ++++++++++++++++++++++\n> 2 files changed, 75 insertions(+)\n[...]\n> diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h\n> index 78d31984a222..5c2a12101052 100644\n> --- a/include/linux/mfd/sun4i-gpadc.h\n> +++ b/include/linux/mfd/sun4i-gpadc.h\n[...]\n> +#define SUN8I_H3_GPADC_CTRL2_T_ACQ1(x)\t\t\t((GENMASK(15, 0) * (x)) << 16)\n> +\n\nYou want to replace * by &.\n\n((GENMASK(15, 0) & (x)) << 16)\n\nWould ((GENMASK(31, 16) & ((x) << 16)) make the bits you set even more\nobvious?\n\n> #define SUN4I_GPADC_CTRL3\t\t\t\t0x0c\n> +/*\n> + * This register is named \"Average filter Control Register\" in H3 Datasheet,\n> + * but the register's definition is the same as the old CTRL3 register.\n> + */\n> +#define SUN8I_H3_GPADC_CTRL3\t\t\t\t0x70\n> \n\nI would name it as it is in the documentation:\nSUN8I_H3_THS_FILTER\n\nNo need for comments then.\n\n> #define SUN4I_GPADC_CTRL3_FILTER_EN\t\t\tBIT(2)\n> #define SUN4I_GPADC_CTRL3_FILTER_TYPE(x)\t\t(GENMASK(1, 0) & (x))\n> @@ -71,6 +84,13 @@\n> #define SUN4I_GPADC_INT_FIFOC_TP_UP_IRQ_EN\t\tBIT(1)\n> #define SUN4I_GPADC_INT_FIFOC_TP_DOWN_IRQ_EN\t\tBIT(0)\n> \n> +#define SUN8I_H3_GPADC_INTC\t\t\t\t0x44\n> +\n> +#define SUN8I_H3_GPADC_INTC_TEMP_PERIOD(x)\t\t((GENMASK(19, 0) & (x)) << 12)\n> +#define SUN8I_H3_GPADC_INTC_TEMP_DATA\t\t\tBIT(8)\n> +#define SUN8I_H3_GPADC_INTC_TEMP_SHUT\t\t\tBIT(4)\n> +#define SUN8I_H3_GPADC_INTC_TEMP_ALARM\t\t\tBIT(0)\n> +\n\nSince it isn't an ADC anymore but rather just a THS, why don't you use\nSUN8I_H3_THS instead of SUN8I_H3_GPADC? That way, it also matches the\ndatasheet.\n\n> #define SUN4I_GPADC_INT_FIFOS\t\t\t\t0x14\n> \n> #define SUN4I_GPADC_INT_FIFOS_TEMP_DATA_PENDING\t\tBIT(18)\n> @@ -80,9 +100,16 @@\n> #define SUN4I_GPADC_INT_FIFOS_TP_UP_PENDING\t\tBIT(1)\n> #define SUN4I_GPADC_INT_FIFOS_TP_DOWN_PENDING\t\tBIT(0)\n> \n> +#define SUN8I_H3_GPADC_INTS\t\t\t\t0x44\n\n0x48\n\n[...]\n\n1) You're not using irqs, why would you define registers that will never\nbe used?\n\n2) Why aren't you using irqs? I remember we discussed on IRC that you\nhad some problems with the H3 when resuming or when probing the driver.\nThe register would have a zero in it until you have a first sample that\narrived (i.e. after the sample rate you set with T_ACQ) that would make\nthe thermal framework panic since the thermal sensor would return\nsomething way too hot and shutdown your board?\n\nThe H3 apparently supports IRQs, why do you not support them for the\ntemperature? They might be broken as it is on A33 but then it might be a\ngood idea to write it down in a comment in the driver (and not adding\nthe unused registers in the header file) or at least in the commit log.\n\n3) Now that you have support for clocks, wouldn't it be a good idea to\ndisable them during suspend?\n\nThanks,\nQuentin","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"avRh2tCf\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvS8F0Hptz9t2c\n\tfor ;\n\tSat, 16 Sep 2017 19:46:21 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dt9g1-0003VR-K0; Sat, 16 Sep 2017 09:46:17 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dt9fx-0003Ne-4p for linux-arm-kernel@lists.infradead.org;\n\tSat, 16 Sep 2017 09:46:15 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 37521209E2; Sat, 16 Sep 2017 11:45:47 +0200 (CEST)","from [192.168.1.14] (LFbn-1-10600-115.w90-89.abo.wanadoo.fr\n\t[90.89.191.115])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E0BBB20917;\n\tSat, 16 Sep 2017 11:45:46 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=nSlfKsbx4Ghn+1qa+QsfJPbh/O9YL2+ooucLWHmzemY=;\n\tb=avRh2tCfUHK8+s\n\tL7K73+JsyNuilzS77aW6XAccPwGaYUc2ZtW6HSeAc9yz5eTu2+MQ5T6jNQlgKh/nBttPk+Q5/b9V2\n\tkNS6BGqZetucfNIO5DaB6WsXTJMxu638wM5m8blTQ0S0VNJkj5JAIeFwDiVo+i7Ep4SXVgJMy63wb\n\tvf6c+PlKwA44Z8KsVBtfLbRajJ33BDf9vuMfpFvKx+v7dViPhMaukQFPnVm1y36WmHZ1kiSxHlXDM\n\tA56UkOP4synFzdj5kWaPnW02VyTmWHKbdIWpmzXkyC/Q3PEGTu8QnOVqvqpJ2sFS7mqg4WUvcffBn\n\tKmi0AKzL+4x5OLVLRHHw==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","To":"Icenowy Zheng , Lee Jones ,\n\tRob Herring ,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Jonathan Cameron ","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-5-icenowy@aosc.io>","From":"Quentin Schulz ","Message-ID":"<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>","Date":"Sat, 16 Sep 2017 11:45:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170914145251.21784-5-icenowy@aosc.io>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_024613_509169_A922F6A1 ","X-CRM114-Status":"GOOD ( 22.85 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-iio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769589,"web_url":"http://patchwork.ozlabs.org/comment/1769589/","msgid":"","list_archive_url":null,"date":"2017-09-16T10:05:49","subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","submitter":{"id":69366,"url":"http://patchwork.ozlabs.org/api/people/69366/","name":"Quentin Schulz","email":"quentin.schulz@free-electrons.com"},"content":"Hi Icenowy,\n\nOn 14/09/2017 16:52, Icenowy Zheng wrote:\n> Because of the restriction of the OF thermal framework, the thermal\n> sensor will fail to probe if the thermal zone doesn't exist.\n> \n\nOh no, that's not good.\n\nWe discussed about it on IRC and I even proposed a patch for it, telling\nyou I would post it on the mailing list soon after. Of course, I forgot\nand you definitely should have yelled at me for not doing it :)\n\nI won't be able to test the patch soon. I can send it to you so that you\ncan test it and integrate it in your patch series so it won't block you.\nOtherwise, we'll have to wait for a week or two for me to test it.\n\nThanks and sorry for forgetting to post the patch you need,\nQuentin\n\n> Add a partial thermal zone which claims the H3 THS as the thermal sensor.\n> \n> The cooling device (CPU DVFS) is still not added as it's not ready, and\n> the trip points are also not added yet.\n> \n> Signed-off-by: Icenowy Zheng \n> ---\n> arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi\n> index 3220da3ad790..687c6457d214 100644\n> --- a/arch/arm/boot/dts/sun8i-h3.dtsi\n> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi\n> @@ -89,6 +89,15 @@\n> \t\t};\n> \t};\n> \n> +\tthermal-zones {\n> +\t\tcpu-thermal {\n> +\t\t\t/* milliseconds */\n> +\t\t\tpolling-delay-passive = <250>;\n> +\t\t\tpolling-delay = <1000>;\n> +\t\t\tthermal-sensors = <&ths>;\n> +\t\t};\n> +\t};\n> +\n> \ttimer {\n> \t\tcompatible = \"arm,armv7-timer\";\n> \t\tinterrupts = ,\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"SniI5RFK\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvSdH5jSRz9t2l\n\tfor ;\n\tSat, 16 Sep 2017 20:08:02 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtA0v-0004ft-K7; Sat, 16 Sep 2017 10:07:53 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dt9zJ-0004LD-H3 for linux-arm-kernel@lists.infradead.org;\n\tSat, 16 Sep 2017 10:06:17 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid AF8BE209E8; Sat, 16 Sep 2017 12:05:49 +0200 (CEST)","from [192.168.1.14] (LFbn-1-10600-115.w90-89.abo.wanadoo.fr\n\t[90.89.191.115])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 67DCA209E0;\n\tSat, 16 Sep 2017 12:05:49 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=RG47soIYS9C3dyp4jBhW7pADt8SrQV+PaqZEltgdHPA=;\n\tb=SniI5RFK+Y1kCT\n\tcO01t23jkjOa6zCe7fs1Ysqr4nI6sMwKF5gkDzAb5rYHzdOG8c3GeGhL8qcZEfog5K5WuER1CUaPO\n\tzDpKMv4erkGABHq5qF4QVyXMl8TptQGMM+OM3Rm8RGXpg4YYVcWL+p586qbGqyS98fDiY1d0mcXgY\n\t8fpayaYBXtbGeH1c5/nLTJyV2WBj4S994RC0GKFlixFPJhKFYzccFWWmTN7O+DxgzUv4G1Xe/pYgB\n\t/dNwsNsp/xjhV7wxy4/cYQ5zX8nylTW8CP8Zx3WsarxSxuI6ezxdFUo+XmVgcnGBr448QLn3Ex6Fb\n\t/YAjDwm+xVeTW29FC80A==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","To":"Icenowy Zheng , Lee Jones ,\n\tRob Herring ,\n\tMaxime Ripard ,\n\tChen-Yu Tsai , Jonathan Cameron ","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-7-icenowy@aosc.io>","From":"Quentin Schulz ","Message-ID":"","Date":"Sat, 16 Sep 2017 12:05:49 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170914145251.21784-7-icenowy@aosc.io>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_030615_682375_476F6D6D ","X-CRM114-Status":"GOOD ( 17.71 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linux-iio@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769593,"web_url":"http://patchwork.ozlabs.org/comment/1769593/","msgid":"<0b395ea1743a14a62855fc2a2dc74411@aosc.io>","list_archive_url":null,"date":"2017-09-16T10:14:08","subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"在 2017-09-16 17:45，Quentin Schulz 写道：\n> Hi Icenowy,\n> \n> On 14/09/2017 16:52, Icenowy Zheng wrote:\n>> This adds support for the Allwinner H3 thermal sensor.\n>> \n>> Allwinner H3 has a thermal sensor like the one in A33, but have its\n>> registers nearly all re-arranged, sample clock moved to CCU and a pair\n>> of bus clock and reset added. It's also the base of newer SoCs' \n>> thermal\n>> sensors.\n>> \n>> The thermal sensors on A64 and H5 is like the one on H3, but with of\n>> course different formula factors.\n>> \n>> Signed-off-by: Icenowy Zheng \n>> ---\n>> Changes in v4:\n>> - Splitted out some code refactors.\n>> - Code sequence changed back. (The gpadc_data went back to the start \n>> of\n>> the source file)\n>> \n>> drivers/iio/adc/sun4i-gpadc-iio.c | 48 \n>> +++++++++++++++++++++++++++++++++++++++\n>> include/linux/mfd/sun4i-gpadc.h | 27 ++++++++++++++++++++++\n>> 2 files changed, 75 insertions(+)\n> [...]\n>> diff --git a/include/linux/mfd/sun4i-gpadc.h \n>> b/include/linux/mfd/sun4i-gpadc.h\n>> index 78d31984a222..5c2a12101052 100644\n>> --- a/include/linux/mfd/sun4i-gpadc.h\n>> +++ b/include/linux/mfd/sun4i-gpadc.h\n> [...]\n>> +#define SUN8I_H3_GPADC_CTRL2_T_ACQ1(x)\t\t\t((GENMASK(15, 0) * (x)) << \n>> 16)\n>> +\n> \n> You want to replace * by &.\n> \n> ((GENMASK(15, 0) & (x)) << 16)\n> \n> Would ((GENMASK(31, 16) & ((x) << 16)) make the bits you set even more\n> obvious?\n> \n>> #define SUN4I_GPADC_CTRL3\t\t\t\t0x0c\n>> +/*\n>> + * This register is named \"Average filter Control Register\" in H3 \n>> Datasheet,\n>> + * but the register's definition is the same as the old CTRL3 \n>> register.\n>> + */\n>> +#define SUN8I_H3_GPADC_CTRL3\t\t\t\t0x70\n>> \n> \n> I would name it as it is in the documentation:\n> SUN8I_H3_THS_FILTER\n\nThe definition of this register is the same as the CTRL3.\n\nMaybe this name is better, but the similarity between them still needs\nto be documented, as the SUN4I_GPADC_CTRL3_XXX macros will be used to\npopulate this register.\n\n> \n> No need for comments then.\n> \n>> #define SUN4I_GPADC_CTRL3_FILTER_EN\t\t\tBIT(2)\n>> #define SUN4I_GPADC_CTRL3_FILTER_TYPE(x)\t\t(GENMASK(1, 0) & (x))\n>> @@ -71,6 +84,13 @@\n>> #define SUN4I_GPADC_INT_FIFOC_TP_UP_IRQ_EN\t\tBIT(1)\n>> #define SUN4I_GPADC_INT_FIFOC_TP_DOWN_IRQ_EN\t\tBIT(0)\n>> \n>> +#define SUN8I_H3_GPADC_INTC\t\t\t\t0x44\n>> +\n>> +#define SUN8I_H3_GPADC_INTC_TEMP_PERIOD(x)\t\t((GENMASK(19, 0) & (x)) \n>> << 12)\n>> +#define SUN8I_H3_GPADC_INTC_TEMP_DATA\t\t\tBIT(8)\n>> +#define SUN8I_H3_GPADC_INTC_TEMP_SHUT\t\t\tBIT(4)\n>> +#define SUN8I_H3_GPADC_INTC_TEMP_ALARM\t\t\tBIT(0)\n>> +\n> \n> Since it isn't an ADC anymore but rather just a THS, why don't you use\n> SUN8I_H3_THS instead of SUN8I_H3_GPADC? That way, it also matches the\n> datasheet.\n> \n>> #define SUN4I_GPADC_INT_FIFOS\t\t\t\t0x14\n>> \n>> #define SUN4I_GPADC_INT_FIFOS_TEMP_DATA_PENDING\t\tBIT(18)\n>> @@ -80,9 +100,16 @@\n>> #define SUN4I_GPADC_INT_FIFOS_TP_UP_PENDING\t\tBIT(1)\n>> #define SUN4I_GPADC_INT_FIFOS_TP_DOWN_PENDING\t\tBIT(0)\n>> \n>> +#define SUN8I_H3_GPADC_INTS\t\t\t\t0x44\n> \n> 0x48\n> \n> [...]\n> \n> 1) You're not using irqs, why would you define registers that will \n> never\n> be used?\n\nI will then rework it to use IRQs, but not now.\n\nMaybe I should add it when I use them?\n\n> \n> 2) Why aren't you using irqs? I remember we discussed on IRC that you\n> had some problems with the H3 when resuming or when probing the driver.\n> The register would have a zero in it until you have a first sample that\n> arrived (i.e. after the sample rate you set with T_ACQ) that would make\n> the thermal framework panic since the thermal sensor would return\n> something way too hot and shutdown your board?\n\nNope, it's another problem -- the runtime resume function is even not\ncalled before the first sample, and the first sample will happen when\nthe THS is still suspended.\n\n> \n> The H3 apparently supports IRQs, why do you not support them for the\n> temperature? They might be broken as it is on A33 but then it might be \n> a\n> good idea to write it down in a comment in the driver (and not adding\n> the unused registers in the header file) or at least in the commit log.\n> \n> 3) Now that you have support for clocks, wouldn't it be a good idea to\n> disable them during suspend?\n\nInteresting... It's meaningful to disable the mod clock during suspend.\n\n> \n> Thanks,\n> Quentin","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"UfOHangI\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvSmy3xl4z9t2l\n\tfor ;\n\tSat, 16 Sep 2017 20:14:42 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtA7T-0007h8-Bj; Sat, 16 Sep 2017 10:14:39 +0000","from dwarf.birch.relay.mailchannels.net ([23.83.209.53])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtA7O-0007b6-DR for linux-arm-kernel@lists.infradead.org;\n\tSat, 16 Sep 2017 10:14:36 +0000","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id DCE172087FB;\n\tSat, 16 Sep 2017 10:14:11 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.136.197])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id CAB62208B0B;\n\tSat, 16 Sep 2017 10:14:10 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.63.242])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Sat, 16 Sep 2017 10:14:11 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 405014646A;\n\tSat, 16 Sep 2017 10:14:08 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From:\n\tDate:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=Kx3IO2oGKmxqfYCsFVFAQKgpvCr/aZ9cylNd419dlIA=;\n\tb=UfOHangIDqNYvKGPUC2SBNkSi\n\tUg3qmaG74K/ERYBkJj9MQuz1itidNDHgojPb43o7bsudzMGfkl4NV8qrP4vYHD3BCFpoEiJYw75Mg\n\tLfHWX4SQLSZpG6XMIqfEkhJJQwOwLgpbPoCpPlfIPYBl/A4GrCvq3BkIzh+TfQu8BKEcg3/4noVpO\n\tV46GuJc4I6GgMre09uaYwk5oZnXtSCp76vZzRb5KhyMYKTXWZxK8q55xmNJPjeihoWi2O+5+2j2Hg\n\tolYKYJaHEYL/y9ACAMuRwUvg56IXSoHYACNvbt1maQMh6SSEDUOwm01mtvOu8TVHuxJ+1F6PuikK3\n\tGrhRogV0Q==;","X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Attack-Shelf":"49c3b4f4033a25db_1505556851709_535831261","X-MC-Loop-Signature":"1505556851709:709954192","X-MC-Ingress-Time":"1505556851708","MIME-Version":"1.0","Date":"Sat, 16 Sep 2017 18:14:08 +0800","From":"icenowy@aosc.io","To":"Quentin Schulz ","Subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","In-Reply-To":"<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-5-icenowy@aosc.io>\n\t<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>","Message-ID":"<0b395ea1743a14a62855fc2a2dc74411@aosc.io>","X-Sender":"icenowy@aosc.io","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_031434_590749_8A31DA07 ","X-CRM114-Status":"GOOD ( 23.03 )","X-Spam-Score":"-4.7 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [23.83.209.53 listed in list.dnswl.org]\n\t-2.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)\n\t[23.83.209.53 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tMaxime Ripard ,\n\tLee Jones , Jonathan Cameron ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769596,"web_url":"http://patchwork.ozlabs.org/comment/1769596/","msgid":"<486005c0-3954-bd49-d2e1-072661fe31a7@free-electrons.com>","list_archive_url":null,"date":"2017-09-16T10:35:01","subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","submitter":{"id":69366,"url":"http://patchwork.ozlabs.org/api/people/69366/","name":"Quentin Schulz","email":"quentin.schulz@free-electrons.com"},"content":"Hi Icenowy,\n\nOn 16/09/2017 12:14, icenowy@aosc.io wrote:\n> 在 2017-09-16 17:45，Quentin Schulz 写道：\n>> Hi Icenowy,\n>>\n>> On 14/09/2017 16:52, Icenowy Zheng wrote:\n>>> This adds support for the Allwinner H3 thermal sensor.\n>>>\n>>> Allwinner H3 has a thermal sensor like the one in A33, but have its\n>>> registers nearly all re-arranged, sample clock moved to CCU and a pair\n>>> of bus clock and reset added. It's also the base of newer SoCs' thermal\n>>> sensors.\n>>>\n>>> The thermal sensors on A64 and H5 is like the one on H3, but with of\n>>> course different formula factors.\n>>>\n>>> Signed-off-by: Icenowy Zheng \n>>> ---\n>>> Changes in v4:\n>>> - Splitted out some code refactors.\n>>> - Code sequence changed back. (The gpadc_data went back to the start of\n>>>   the source file)\n>>>\n>>>  drivers/iio/adc/sun4i-gpadc-iio.c | 48\n>>> +++++++++++++++++++++++++++++++++++++++\n>>>  include/linux/mfd/sun4i-gpadc.h   | 27 ++++++++++++++++++++++\n>>>  2 files changed, 75 insertions(+)\n[...]\n>>>  #define SUN4I_GPADC_CTRL3                0x0c\n>>> +/*\n>>> + * This register is named \"Average filter Control Register\" in H3\n>>> Datasheet,\n>>> + * but the register's definition is the same as the old CTRL3 register.\n>>> + */\n>>> +#define SUN8I_H3_GPADC_CTRL3                0x70\n>>>\n>>\n>> I would name it as it is in the documentation:\n>> SUN8I_H3_THS_FILTER\n> \n> The definition of this register is the same as the CTRL3.\n> \n> Maybe this name is better, but the similarity between them still needs\n> to be documented, as the SUN4I_GPADC_CTRL3_XXX macros will be used to\n> populate this register.\n> \n>>\n>> No need for comments then.\n>>\n>>>  #define SUN4I_GPADC_CTRL3_FILTER_EN            BIT(2)\n>>>  #define SUN4I_GPADC_CTRL3_FILTER_TYPE(x)        (GENMASK(1, 0) & (x))\n\nThey have _FILTER_ in their name, isn't it enough?\n\nJust a matter of taste for me.\n\n>>> @@ -71,6 +84,13 @@\n>>>  #define SUN4I_GPADC_INT_FIFOC_TP_UP_IRQ_EN        BIT(1)\n>>>  #define SUN4I_GPADC_INT_FIFOC_TP_DOWN_IRQ_EN        BIT(0)\n>>>\n>>> +#define SUN8I_H3_GPADC_INTC                0x44\n>>> +\n>>> +#define SUN8I_H3_GPADC_INTC_TEMP_PERIOD(x)        ((GENMASK(19, 0) &\n>>> (x)) << 12)\n>>> +#define SUN8I_H3_GPADC_INTC_TEMP_DATA            BIT(8)\n>>> +#define SUN8I_H3_GPADC_INTC_TEMP_SHUT            BIT(4)\n>>> +#define SUN8I_H3_GPADC_INTC_TEMP_ALARM            BIT(0)\n>>> +\n>>\n>> Since it isn't an ADC anymore but rather just a THS, why don't you use\n>> SUN8I_H3_THS instead of SUN8I_H3_GPADC? That way, it also matches the\n>> datasheet.\n>>\n>>>  #define SUN4I_GPADC_INT_FIFOS                0x14\n>>>\n>>>  #define SUN4I_GPADC_INT_FIFOS_TEMP_DATA_PENDING        BIT(18)\n>>> @@ -80,9 +100,16 @@\n>>>  #define SUN4I_GPADC_INT_FIFOS_TP_UP_PENDING        BIT(1)\n>>>  #define SUN4I_GPADC_INT_FIFOS_TP_DOWN_PENDING        BIT(0)\n>>>\n>>> +#define SUN8I_H3_GPADC_INTS                0x44\n>>\n>> 0x48\n>>\n>> [...]\n>>\n>> 1) You're not using irqs, why would you define registers that will never\n>> be used?\n> \n> I will then rework it to use IRQs, but not now.\n> \n> Maybe I should add it when I use them?\n> \n\nWhy not make it work right away the way we want :)?\n\n>>\n>> 2) Why aren't you using irqs? I remember we discussed on IRC that you\n>> had some problems with the H3 when resuming or when probing the driver.\n>> The register would have a zero in it until you have a first sample that\n>> arrived (i.e. after the sample rate you set with T_ACQ) that would make\n>> the thermal framework panic since the thermal sensor would return\n>> something way too hot and shutdown your board?\n> \n> Nope, it's another problem -- the runtime resume function is even not\n> called before the first sample, and the first sample will happen when\n> the THS is still suspended.\n> \n\nAs discussed on IRC (a long time ago :) ), it's a combination of two\nproblems:\n1) get_temp (used by thermal framework) uses pm_runtime function that\nisn't ready yet <= I will send a patch for registering thermal framework\nafter pm_runtime to you, hopefully in the upcoming hour or tomorrow,\n\n2) The A33 (and H3 in your implementation) does not wait for an\ninterrupt to read the TEMP_DATA register which resets to 0 when the\nsensor is disabled (or until a first sample arrives) i.e. when probing\nor when resuming. Using IRQs would get rid of 2). It isn't critical for\nA33 as the formula for temp returns something really cold so thermal\ndoes not care. But for the H3, it's critically hot and shuts down your\nboard. To make it work on the H3, we would have to use a delay in the\npm_resume function equal to the sensor sampling rate and I don't really\nlike that. If we could use IRQs, it'd be better IMHO (but they aren't\nworking on A33).\n\nThanks,\nQuentin\n\n>>\n>> The H3 apparently supports IRQs, why do you not support them for the\n>> temperature? They might be broken as it is on A33 but then it might be a\n>> good idea to write it down in a comment in the driver (and not adding\n>> the unused registers in the header file) or at least in the commit log.\n>>\n>> 3) Now that you have support for clocks, wouldn't it be a good idea to\n>> disable them during suspend?\n> \n> Interesting... It's meaningful to disable the mod clock during suspend.\n> \n>>\n>> Thanks,\n>> Quentin\n> \n> _______________________________________________\n> linux-arm-kernel mailing list\n> linux-arm-kernel@lists.infradead.org\n> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"WiIAouQ/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvTF14k3Jz9t30\n\tfor ;\n\tSat, 16 Sep 2017 20:35:33 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtARd-0002E3-Er; Sat, 16 Sep 2017 10:35:29 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtARY-000137-HS for linux-arm-kernel@lists.infradead.org;\n\tSat, 16 Sep 2017 10:35:27 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid B0F65209FC; Sat, 16 Sep 2017 12:35:02 +0200 (CEST)","from [192.168.1.14] (LFbn-1-10600-115.w90-89.abo.wanadoo.fr\n\t[90.89.191.115])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 1CE7C209E8;\n\tSat, 16 Sep 2017 12:35:02 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:\n\tMessage-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description\n\t:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=MdiU9QvSTrdfSwzE9xSVyBoWuYg+Ujl5spNHxAJcvUA=;\n\tb=WiIAouQ/8akSUy\n\toR6rsAO2cKd92+SQ7cf+iYcn0GJ6bs27SIzIx8OtPcD675mM0htHcjaIUfi74+HPICmp85BwKwVjZ\n\tAaPV8dfCvYBQ3qFQd7EwV6wPxkIbaw0SnDzZxTV3hxDKEW4wLejAXIrZdpSQ5vqmo/wQFnPA2HT8o\n\tflGS9elu1ztqJpkL9OqBnikS265XV2N5bgSoeNOph3Oj4o/njnG38IEGmzRBSGF9CWcwHVcXAZ2QE\n\tjbfz3VCs7nSrpKA/W2Tq14zsKr/A9H7q6fcHVV2PKx7Dox0J/4bhxI7ojuckj9OkloEOlBExVWYW6\n\thL9B5wltz+rEL9OGSGjw==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","To":"icenowy@aosc.io","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-5-icenowy@aosc.io>\n\t<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>\n\t<0b395ea1743a14a62855fc2a2dc74411@aosc.io>","From":"Quentin Schulz ","Message-ID":"<486005c0-3954-bd49-d2e1-072661fe31a7@free-electrons.com>","Date":"Sat, 16 Sep 2017 12:35:01 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<0b395ea1743a14a62855fc2a2dc74411@aosc.io>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_033524_880938_D0375546 ","X-CRM114-Status":"GOOD ( 31.57 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tChen-Yu Tsai , linux-kernel@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, Rob Herring ,\n\tJonathan Cameron ,\n\tMaxime Ripard ,\n\tLee Jones , linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769645,"web_url":"http://patchwork.ozlabs.org/comment/1769645/","msgid":"<20170916151224.777e5b56@archlinux>","list_archive_url":null,"date":"2017-09-16T22:12:24","subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Thu, 14 Sep 2017 22:52:46 +0800\nIcenowy Zheng wrote:\n\n> Allwinner H3 features a thermal sensor like the one in A33, but has its\n> register re-arranged, the clock divider moved to CCU (originally the\n> clock divider is in ADC) and added a pair of bus clock and reset.\n> \n> Update the binding document to cover H3.\n> \n> Signed-off-by: Icenowy Zheng \n> Reviewed-by: Chen-Yu Tsai \n> ---\n> Changes in v4:\n> - Add nvmem calibration data (not yet used by the driver)\n> Changes in v3:\n> - Clock name changes.\n> - Example node name changes.\n> - Add interupts (not yet used by the driver).\n> \n> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30 ++++++++++++++++++++--\n> 1 file changed, 28 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> index badff3611a98..6c470d584bf9 100644\n> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor\n> and sometimes as a touchscreen controller.\n> \n> Required properties:\n> - - compatible: \"allwinner,sun8i-a33-ths\",\n> + - compatible: must contain one of the following compatibles:\n> +\t\t- \"allwinner,sun8i-a33-ths\"\n> +\t\t- \"allwinner,sun8i-h3-ths\"\n> - reg: mmio address range of the chip,\n> - #thermal-sensor-cells: shall be 0,\n> - #io-channel-cells: shall be 0,\n> \n> -Example:\n> +Optional properties:\n> + - nvmem-cells: A phandle to the calibration data provided by a nvmem device.\n> + If unspecified default values shall be used.\n> + - nvmem-cell-names: Should be \"calibration-data\"\n\nI think a cross reference to the nvmem binding docs would be good here.\nIt wasn't something I could remember coming across before. Obviously\ngrep gets you there quickly enough, but a cross reference would be even\nbetter.\n\nAlso would it make sense to have an example with these in?\n\nJonathan\n> +\n> +Required properties for the following compatibles:\n> +\t\t- \"allwinner,sun8i-h3-ths\"\n> + - clocks: the bus clock and the input clock of the ADC,\n> + - clock-names: should be \"bus\" and \"mod\",\n> + - resets: the bus reset of the ADC,\n> + - interrupts: the sampling interrupt of the ADC,\n> +\n> +Example for A33:\n> \tths: ths@01c25000 {\n> \t\tcompatible = \"allwinner,sun8i-a33-ths\";\n> \t\treg = <0x01c25000 0x100>;\n> @@ -17,6 +31,18 @@ Example:\n> \t\t#io-channel-cells = <0>;\n> \t};\n> \n> +Example for H3:\n> +\tths: thermal-sensor@1c25000 {\n> +\t\tcompatible = \"allwinner,sun8i-h3-ths\";\n> +\t\treg = <0x01c25000 0x400>;\n> +\t\tclocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;\n> +\t\tclock-names = \"bus\", \"mod\";\n> +\t\tresets = <&ccu RST_BUS_THS>;\n> +\t\tinterrupts = ;\n> +\t\t#thermal-sensor-cells = <0>;\n> +\t\t#io-channel-cells = <0>;\n> +\t};\n> +\n> sun4i, sun5i and sun6i SoCs are also supported via the older binding:\n> \n> sun4i resistive touchscreen controller","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"gJ2tJ03p\"; dkim-atps=neutral","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=jic23@kernel.org"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvmk62kPsz9sRm\n\tfor ;\n\tSun, 17 Sep 2017 08:13:18 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtLKs-0007og-Ct; Sat, 16 Sep 2017 22:13:14 +0000","from mail.kernel.org ([198.145.29.99])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtLKU-0007gU-6R for linux-arm-kernel@lists.infradead.org;\n\tSat, 16 Sep 2017 22:13:11 +0000","from archlinux (unknown [207.243.58.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 1716622A73;\n\tSat, 16 Sep 2017 22:12:27 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=R0Cjj111yacvxzQqUyvAI0JHqKwV7fLflP9lm9EiIf8=;\n\tb=gJ2tJ03pSG4wxC\n\t7/csI9aJt4MGeDVzNq54lTsbQ5cFxldVpLa32OF1BWuw8gH/c98ulOYl6wTgmqfbZkAXe/rcGOadQ\n\tM4wbYKQ9o4+2O4jfYahkd69mNxRScKi2rfLydFbT/korPPQVJG9iCR5JvBpf1n6hFgYx0eIt4fvep\n\tTC2nbPjF/2pEvmR6deEXaZadiSn37uO8aqnwXvokZMBlP+y3TbnR6+Up5aBLHv76VpvxxEOCt92PO\n\tSEvktPVtwa6ADFsq2X05rNVhEMsYY0naWGNaQZN1BFNLax7FfcJbs3hCFIB1u3XUtsYSFtsg8rTRN\n\tuQQhVjYgLheAwxXjRdaw==;","DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 1716622A73","Date":"Sat, 16 Sep 2017 15:12:24 -0700","From":"Jonathan Cameron ","To":"Icenowy Zheng ","Subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","Message-ID":"<20170916151224.777e5b56@archlinux>","In-Reply-To":"<20170914145251.21784-2-icenowy@aosc.io>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_151309_634103_D5E8B6FF ","X-CRM114-Status":"GOOD ( 18.07 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [198.145.29.99 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tMaxime Ripard ,\n\tLee Jones , linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769647,"web_url":"http://patchwork.ozlabs.org/comment/1769647/","msgid":"<20170916151628.001dc421@archlinux>","list_archive_url":null,"date":"2017-09-16T22:16:28","subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Sat, 16 Sep 2017 11:45:47 +0200\nQuentin Schulz wrote:\n\n> Hi Icenowy,\n> \n> On 14/09/2017 16:52, Icenowy Zheng wrote:\n> > This adds support for the Allwinner H3 thermal sensor.\n> > \n> > Allwinner H3 has a thermal sensor like the one in A33, but have its\n> > registers nearly all re-arranged, sample clock moved to CCU and a pair\n> > of bus clock and reset added. It's also the base of newer SoCs' thermal\n> > sensors.\n> > \n> > The thermal sensors on A64 and H5 is like the one on H3, but with of\n> > course different formula factors.\n> > \n> > Signed-off-by: Icenowy Zheng \n> > ---\n> > Changes in v4:\n> > - Splitted out some code refactors.\n> > - Code sequence changed back. (The gpadc_data went back to the start of\n> > the source file)\n> > \n> > drivers/iio/adc/sun4i-gpadc-iio.c | 48 +++++++++++++++++++++++++++++++++++++++\n> > include/linux/mfd/sun4i-gpadc.h | 27 ++++++++++++++++++++++\n> > 2 files changed, 75 insertions(+) \n> [...]\n> > diff --git a/include/linux/mfd/sun4i-gpadc.h b/include/linux/mfd/sun4i-gpadc.h\n> > index 78d31984a222..5c2a12101052 100644\n> > --- a/include/linux/mfd/sun4i-gpadc.h\n> > +++ b/include/linux/mfd/sun4i-gpadc.h \n> [...]\n> > +#define SUN8I_H3_GPADC_CTRL2_T_ACQ1(x)\t\t\t((GENMASK(15, 0) * (x)) << 16)\n> > + \n> \n> You want to replace * by &.\n> \n> ((GENMASK(15, 0) & (x)) << 16)\n> \n> Would ((GENMASK(31, 16) & ((x) << 16)) make the bits you set even more\n> obvious?\n\nAgreed. Would act as better 'documentation'.\n\nJonathan\n> \n> > #define SUN4I_GPADC_CTRL3\t\t\t\t0x0c\n> > +/*\n> > + * This register is named \"Average filter Control Register\" in H3 Datasheet,\n> > + * but the register's definition is the same as the old CTRL3 register.\n> > + */\n> > +#define SUN8I_H3_GPADC_CTRL3\t\t\t\t0x70\n> > \n> \n> I would name it as it is in the documentation:\n> SUN8I_H3_THS_FILTER\n> \n> No need for comments then.\n> \n> > #define SUN4I_GPADC_CTRL3_FILTER_EN\t\t\tBIT(2)\n> > #define SUN4I_GPADC_CTRL3_FILTER_TYPE(x)\t\t(GENMASK(1, 0) & (x))\n> > @@ -71,6 +84,13 @@\n> > #define SUN4I_GPADC_INT_FIFOC_TP_UP_IRQ_EN\t\tBIT(1)\n> > #define SUN4I_GPADC_INT_FIFOC_TP_DOWN_IRQ_EN\t\tBIT(0)\n> > \n> > +#define SUN8I_H3_GPADC_INTC\t\t\t\t0x44\n> > +\n> > +#define SUN8I_H3_GPADC_INTC_TEMP_PERIOD(x)\t\t((GENMASK(19, 0) & (x)) << 12)\n> > +#define SUN8I_H3_GPADC_INTC_TEMP_DATA\t\t\tBIT(8)\n> > +#define SUN8I_H3_GPADC_INTC_TEMP_SHUT\t\t\tBIT(4)\n> > +#define SUN8I_H3_GPADC_INTC_TEMP_ALARM\t\t\tBIT(0)\n> > + \n> \n> Since it isn't an ADC anymore but rather just a THS, why don't you use\n> SUN8I_H3_THS instead of SUN8I_H3_GPADC? That way, it also matches the\n> datasheet.\n> \n> > #define SUN4I_GPADC_INT_FIFOS\t\t\t\t0x14\n> > \n> > #define SUN4I_GPADC_INT_FIFOS_TEMP_DATA_PENDING\t\tBIT(18)\n> > @@ -80,9 +100,16 @@\n> > #define SUN4I_GPADC_INT_FIFOS_TP_UP_PENDING\t\tBIT(1)\n> > #define SUN4I_GPADC_INT_FIFOS_TP_DOWN_PENDING\t\tBIT(0)\n> > \n> > +#define SUN8I_H3_GPADC_INTS\t\t\t\t0x44 \n> \n> 0x48\n> \n> [...]\n> \n> 1) You're not using irqs, why would you define registers that will never\n> be used?\n> \n> 2) Why aren't you using irqs? I remember we discussed on IRC that you\n> had some problems with the H3 when resuming or when probing the driver.\n> The register would have a zero in it until you have a first sample that\n> arrived (i.e. after the sample rate you set with T_ACQ) that would make\n> the thermal framework panic since the thermal sensor would return\n> something way too hot and shutdown your board?\n> \n> The H3 apparently supports IRQs, why do you not support them for the\n> temperature? They might be broken as it is on A33 but then it might be a\n> good idea to write it down in a comment in the driver (and not adding\n> the unused registers in the header file) or at least in the commit log.\n> \n> 3) Now that you have support for clocks, wouldn't it be a good idea to\n> disable them during suspend?\n> \n> Thanks,\n> Quentin","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"js6s85eT\"; dkim-atps=neutral","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=jic23@kernel.org"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvmpS2T9Xz9sRm\n\tfor ;\n\tSun, 17 Sep 2017 08:17:04 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtLOU-0001ge-UG; Sat, 16 Sep 2017 22:16:58 +0000","from mail.kernel.org ([198.145.29.99])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtLON-0001aT-V1 for linux-arm-kernel@lists.infradead.org;\n\tSat, 16 Sep 2017 22:16:53 +0000","from archlinux (unknown [207.243.58.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id D41F322A73;\n\tSat, 16 Sep 2017 22:16:30 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=zL/nU1sMad8qU7Eg3jolcKjNn2Za1kN6sa5tG94250Q=;\n\tb=js6s85eT+UAAfl\n\tD17SvRUWZNFjl0qGl+GaP15ouRMBPQRyCvOi+xhranlQkr0ke5KaB2zC6QFPoSzJY73cKwKPnPerJ\n\tKkY0qFP1FPBzm81gi1q9szzMTs+IuLUxaKypXN7oNP7Q3NZsW86m+XkneFSgnXuCMq0Vb8PcjkeGl\n\t0M+FprtxVT6gbga0gl9ErVs2tRHQqjQUttMlQpf0lulYhCVbcXlKz6X5q+ekggyfJvfALTrpkrLbD\n\tqUshqXMFrNY3o11EiouNb0Gs68tA5vsGF2km12cieleTLcWulVSnI7B1efi5Ft46E/qArZBQ4HN0F\n\tbzHlHJ9/CNNtbypG2iRA==;","DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org D41F322A73","Date":"Sat, 16 Sep 2017 15:16:28 -0700","From":"Jonathan Cameron ","To":"Quentin Schulz ","Subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","Message-ID":"<20170916151628.001dc421@archlinux>","In-Reply-To":"<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-5-icenowy@aosc.io>\n\t<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_151652_107962_904A24E6 ","X-CRM114-Status":"GOOD ( 27.68 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [198.145.29.99 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tChen-Yu Tsai , Rob Herring ,\n\tMaxime Ripard ,\n\tLee Jones , linux-arm-kernel@lists.infradead.org,\n\tIcenowy Zheng ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769649,"web_url":"http://patchwork.ozlabs.org/comment/1769649/","msgid":"<20170916151734.10968b7a@archlinux>","list_archive_url":null,"date":"2017-09-16T22:17:34","subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Sat, 16 Sep 2017 12:05:49 +0200\nQuentin Schulz wrote:\n\n> Hi Icenowy,\n> \n> On 14/09/2017 16:52, Icenowy Zheng wrote:\n> > Because of the restriction of the OF thermal framework, the thermal\n> > sensor will fail to probe if the thermal zone doesn't exist.\n> > \n> \n> Oh no, that's not good.\n> \n> We discussed about it on IRC and I even proposed a patch for it, telling\n> you I would post it on the mailing list soon after. Of course, I forgot\n> and you definitely should have yelled at me for not doing it :)\n> \n> I won't be able to test the patch soon. I can send it to you so that you\n> can test it and integrate it in your patch series so it won't block you.\n> Otherwise, we'll have to wait for a week or two for me to test it.\n> \n> Thanks and sorry for forgetting to post the patch you need,\n> Quentin\n\nOther this outstanding issue I'm happy with the series, so hopefully\nwith Quentin's patch added we should be good to merge this one.\n\nJonathan\n\n> \n> > Add a partial thermal zone which claims the H3 THS as the thermal sensor.\n> > \n> > The cooling device (CPU DVFS) is still not added as it's not ready, and\n> > the trip points are also not added yet.\n> > \n> > Signed-off-by: Icenowy Zheng \n> > ---\n> > arch/arm/boot/dts/sun8i-h3.dtsi | 9 +++++++++\n> > 1 file changed, 9 insertions(+)\n> > \n> > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi\n> > index 3220da3ad790..687c6457d214 100644\n> > --- a/arch/arm/boot/dts/sun8i-h3.dtsi\n> > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi\n> > @@ -89,6 +89,15 @@\n> > \t\t};\n> > \t};\n> > \n> > +\tthermal-zones {\n> > +\t\tcpu-thermal {\n> > +\t\t\t/* milliseconds */\n> > +\t\t\tpolling-delay-passive = <250>;\n> > +\t\t\tpolling-delay = <1000>;\n> > +\t\t\tthermal-sensors = <&ths>;\n> > +\t\t};\n> > +\t};\n> > +\n> > \ttimer {\n> > \t\tcompatible = \"arm,armv7-timer\";\n> > \t\tinterrupts = ,\n> > \n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"tWAGYf0g\"; dkim-atps=neutral","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=jic23@kernel.org"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xvmqj3qdwz9sRm\n\tfor ;\n\tSun, 17 Sep 2017 08:18:09 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtLPZ-00028B-W1; Sat, 16 Sep 2017 22:18:06 +0000","from mail.kernel.org ([198.145.29.99])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtLPR-0001xn-R9 for linux-arm-kernel@lists.infradead.org;\n\tSat, 16 Sep 2017 22:18:03 +0000","from archlinux (unknown [207.243.58.180])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id E68C922A73;\n\tSat, 16 Sep 2017 22:17:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=p8wbhntSfHw5+zao7sENki5wRmZHGGAg9zjQt+ffjS8=;\n\tb=tWAGYf0gjhyzP/\n\tVwjVBmP63jXy3iXwCCseuKW31ANWW4mfDcgW60zGemwbtGMNF1mXzgSPlB/En2ZdLas2szklWxvMf\n\txyJmlhP7+h8faNsTq6UWT7wrKqFq/3M+AstqZ0wTvvl4LyAkF8c1WXWBbvUgwk+oFg4Sc7zcm6dCY\n\t2nDGvRSr2vnACKehwUSKKzQwc4gPmPrQDXww3g1KAcNYnJfH4ZifvKXkutdRpMtROtoMDBWioc1Se\n\tln3nav29iVSalwIkBLvsFkCpC9iLGclY5L1toe5GSQN+5wa8MmwlFUgbgCHD1adbULIj9O7E2lePM\n\tZKM2bk12cRRJ4TLfGFkQ==;","DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org E68C922A73","Date":"Sat, 16 Sep 2017 15:17:34 -0700","From":"Jonathan Cameron ","To":"Quentin Schulz ","Subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","Message-ID":"<20170916151734.10968b7a@archlinux>","In-Reply-To":"","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-7-icenowy@aosc.io>\n\t","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170916_151758_081194_35B842AB ","X-CRM114-Status":"GOOD ( 22.03 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [198.145.29.99 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tChen-Yu Tsai , Rob Herring ,\n\tMaxime Ripard ,\n\tLee Jones , linux-arm-kernel@lists.infradead.org,\n\tIcenowy Zheng ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769910,"web_url":"http://patchwork.ozlabs.org/comment/1769910/","msgid":"<20170918073336.j7finend3g76chsu@flea.lan>","list_archive_url":null,"date":"2017-09-18T07:33:36","subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote:\n> Allwinner H3 features a thermal sensor like the one in A33, but has its\n> register re-arranged, the clock divider moved to CCU (originally the\n> clock divider is in ADC) and added a pair of bus clock and reset.\n> \n> Update the binding document to cover H3.\n> \n> Signed-off-by: Icenowy Zheng \n> Reviewed-by: Chen-Yu Tsai \n> ---\n> Changes in v4:\n> - Add nvmem calibration data (not yet used by the driver)\n> Changes in v3:\n> - Clock name changes.\n> - Example node name changes.\n> - Add interupts (not yet used by the driver).\n> \n> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30 ++++++++++++++++++++--\n> 1 file changed, 28 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> index badff3611a98..6c470d584bf9 100644\n> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also act as a thermal sensor\n> and sometimes as a touchscreen controller.\n> \n> Required properties:\n> - - compatible: \"allwinner,sun8i-a33-ths\",\n> + - compatible: must contain one of the following compatibles:\n> +\t\t- \"allwinner,sun8i-a33-ths\"\n> +\t\t- \"allwinner,sun8i-h3-ths\"\n> - reg: mmio address range of the chip,\n> - #thermal-sensor-cells: shall be 0,\n> - #io-channel-cells: shall be 0,\n> \n> -Example:\n> +Optional properties:\n> + - nvmem-cells: A phandle to the calibration data provided by a nvmem device.\n> + If unspecified default values shall be used.\n> + - nvmem-cell-names: Should be \"calibration-data\"\n\nI'd prefer to have which sensor it applies to here. It wouldn't change\nanything for the H3, but it definitely does for example for the A83t\nthat has two sensors, one for each cluster, and one for the GPU, each\nwith calibration data.\n\nWhat about cluster0-calibration?\n\n> +\n> +Required properties for the following compatibles:\n> +\t\t- \"allwinner,sun8i-h3-ths\"\n> + - clocks: the bus clock and the input clock of the ADC,\n> + - clock-names: should be \"bus\" and \"mod\",\n> + - resets: the bus reset of the ADC,\n> + - interrupts: the sampling interrupt of the ADC,\n\nFor resets and interrupts, you should list all of them. If there's\nonly one, then there's no point telling which one it is.\n\n\nThanks,\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"a3jHiMUF\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwd736Zsxz9ryQ\n\tfor ;\n\tMon, 18 Sep 2017 17:34:22 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqZN-0007We-Oj; Mon, 18 Sep 2017 07:34:17 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqZB-0007Rz-HN for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 07:34:11 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid EC0A8209DF; Mon, 18 Sep 2017 09:33:36 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id B854D2094F;\n\tMon, 18 Sep 2017 09:33:36 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=8zCFhAiCfGJbEjdf4UCGv7Z/0ASVeqR/eeiomXUSyRU=;\n\tb=a3jHiMUFNJeMV/h0Hs0KdwPOp\n\tcN/Bl0DPisSk46zzs4MZpkJ+lewmABCwPaFMv8ILAux0fpvTnMbowLCtEWhRxzYsowq6God/Q8JEY\n\t/wBKp/BlpLzhgIYnjbUO7jM32SiypRNpiNp2cJjBUYFmsN7/zqNIZlgeCfu7DPjWLJl4iTGAxCBUO\n\t+YZH0dcvJ/BfTfW3KvdiGqFRSKACDKJrguitGI49M1FFs6d/J1OG354VtIZ8RE/PcsSU5pJZx8oNL\n\tmgnUHxJd6gRYk4nsVKVnCmYjHPv0ABL8VzfokdDtf03bJSTvNsfBhVv4X7/6yzXJfAw9Z4lElaXtr\n\tvzGu0H6iA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 09:33:36 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","Message-ID":"<20170918073336.j7finend3g76chsu@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<20170914145251.21784-2-icenowy@aosc.io>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_003408_587369_0D0BD8A3 ","X-CRM114-Status":"GOOD ( 19.68 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============6460418565171357810==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769912,"web_url":"http://patchwork.ozlabs.org/comment/1769912/","msgid":"<20170918073452.2jizidgu4rvqesiq@flea.lan>","list_archive_url":null,"date":"2017-09-18T07:34:52","subject":"Re: [PATCH v4 2/6] iio: adc: sun4i-gpadc-iio: rename A33-specified\n\tregisters to contain A33","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 14, 2017 at 10:52:47PM +0800, Icenowy Zheng wrote:\n> As the H3 SoC, which is also in sun8i line, has totally different\n> register map for the thermal sensor (a cut down version of GPADC), we\n> should rename A23/A33-specified registers to contain A33, in order to\n> prevent obfuscation with H3 registers. Currently these registers are\n> only prefixed \"SUN8I\", not \"SUN8I_A33\".\n> \n> Add \"_A33\" after \"SUN8I\" on the register names.\n> \n> Signed-off-by: Icenowy Zheng \n> Reviewed-by: Chen-Yu Tsai \n\nAcked-by: Maxime Ripard \n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"SSrsVx57\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwd8F0vTzz9ryQ\n\tfor ;\n\tMon, 18 Sep 2017 17:35:25 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqaP-0000mM-AC; Mon, 18 Sep 2017 07:35:21 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqaH-0007uW-9Y for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 07:35:18 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 11EFB209DF; Mon, 18 Sep 2017 09:34:52 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id D813F2094F;\n\tMon, 18 Sep 2017 09:34:51 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=LtnmByquZFCYbpXRzXRvO6zC+slHCqGCzTo6svmksbs=;\n\tb=SSrsVx57QqgtDQUhNNLOnSesf\n\tmJyyv4u8XmLE/vytpPzK6FcK96C99zNNDsnAvJFxvGt514zJvRyLV4tC1yBErIW3x8cSnc/RJDZYC\n\teZSeR2SzDMWLCh9gFmE0mPqlBndq2ie8Fs/H7lxAqW/6i9O3JPU+MrgkGNFybFfwJZDDlu6/wgmAp\n\tdpigo3NjXv5/N3Jiep8vooVLl7JuDDKFQyv0kpZ7HwMp6tfzeArQzCWB0H0aDl2LgZ3Ah5fksLPO6\n\t6sEea0SFw8JM+HECwkWBJK70IaDYrx3hlGnmoo736ZunbyNdOds8zedSstA/dWj4LzPpf1Bkd4tJz\n\tK5xf4/DiA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 09:34:52 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Subject":"Re: [PATCH v4 2/6] iio: adc: sun4i-gpadc-iio: rename A33-specified\n\tregisters to contain A33","Message-ID":"<20170918073452.2jizidgu4rvqesiq@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-3-icenowy@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<20170914145251.21784-3-icenowy@aosc.io>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_003513_591940_5E84333F ","X-CRM114-Status":"GOOD ( 11.38 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============5733893595607598087==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769915,"web_url":"http://patchwork.ozlabs.org/comment/1769915/","msgid":"<20170918073601.oiqshnhhl7yb6fv2@flea.lan>","list_archive_url":null,"date":"2017-09-18T07:36:01","subject":"Re: [PATCH v4 3/6] iio: adc: sun4i-gpadc-iio: rework code for\n\tsupporting newer THS variants","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 14, 2017 at 10:52:48PM +0800, Icenowy Zheng wrote:\n> The SoCs after H3 has newer thermal sensor ADCs, which have two clock\n> inputs (bus clock and sampling clock) and a reset. The registers are\n> also re-arranged.\n> \n> This commit reworks the code, adds the process of the clocks and\n> resets, and allows the sampling start/end code and the position of value\n> readout register to be altered.\n> \n> Signed-off-by: Icenowy Zheng \n\nPlease split that into separate commits.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"nNve9Qoy\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwd9v1lcPz9ryQ\n\tfor ;\n\tMon, 18 Sep 2017 17:36:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqbl-0001b4-U4; Mon, 18 Sep 2017 07:36:45 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqbO-0001C7-RW for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 07:36:33 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid C9EEE20A08; Mon, 18 Sep 2017 09:36:01 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 9BCC72094F;\n\tMon, 18 Sep 2017 09:36:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=ChB3ZC4fh4tduor4Id/1MUDaGyjaaUZF40dp9Blrync=;\n\tb=nNve9QoyXZXxgfY2DF60CLdJ/\n\tNlHvztRoyGLwTUWyICOuxRMxPNfI58jjbuWd8dE1/NCn39DOocQ6IQcEMpP9QaA2j9npiYL1FGKf1\n\tfdavn6l+ANiWsFJy9nTIlSJxq740tQ0oUP64nR88xrNB1R7zXsjlDiFFBxYabd5MgOfhoqWnk5r2T\n\teX0Epqydne0gwVhVW/gKoP+Tt6faHJipVAFAw0wvqUqbHYp7V/Dz79LZvdszzunpNKTEnFjjd9qh6\n\tVrfN4U0bqDjQejYhCLSbNLjryZ8tpT4IY2XxlC0dqY6jtL746BdL0Xw9V9bV/aoxJXBZXXWi6uOWV\n\tE0Ujw/v/A==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 09:36:01 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Subject":"Re: [PATCH v4 3/6] iio: adc: sun4i-gpadc-iio: rework code for\n\tsupporting newer THS variants","Message-ID":"<20170918073601.oiqshnhhl7yb6fv2@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-4-icenowy@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<20170914145251.21784-4-icenowy@aosc.io>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_003623_914326_2983A0E5 ","X-CRM114-Status":"GOOD ( 12.07 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============6778837949778119441==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769946,"web_url":"http://patchwork.ozlabs.org/comment/1769946/","msgid":"<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>","list_archive_url":null,"date":"2017-09-18T07:36:43","subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"于 2017年9月18日 GMT+08:00 下午3:33:36, Maxime Ripard 写到:\n>On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote:\n>> Allwinner H3 features a thermal sensor like the one in A33, but has\n>its\n>> register re-arranged, the clock divider moved to CCU (originally the\n>> clock divider is in ADC) and added a pair of bus clock and reset.\n>> \n>> Update the binding document to cover H3.\n>> \n>> Signed-off-by: Icenowy Zheng \n>> Reviewed-by: Chen-Yu Tsai \n>> ---\n>> Changes in v4:\n>> - Add nvmem calibration data (not yet used by the driver)\n>> Changes in v3:\n>> - Clock name changes.\n>> - Example node name changes.\n>> - Add interupts (not yet used by the driver).\n>> \n>> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30\n>++++++++++++++++++++--\n>> 1 file changed, 28 insertions(+), 2 deletions(-)\n>> \n>> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> index badff3611a98..6c470d584bf9 100644\n>> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also\n>act as a thermal sensor\n>> and sometimes as a touchscreen controller.\n>> \n>> Required properties:\n>> - - compatible: \"allwinner,sun8i-a33-ths\",\n>> + - compatible: must contain one of the following compatibles:\n>> +\t\t- \"allwinner,sun8i-a33-ths\"\n>> +\t\t- \"allwinner,sun8i-h3-ths\"\n>> - reg: mmio address range of the chip,\n>> - #thermal-sensor-cells: shall be 0,\n>> - #io-channel-cells: shall be 0,\n>> \n>> -Example:\n>> +Optional properties:\n>> + - nvmem-cells: A phandle to the calibration data provided by a\n>nvmem device.\n>> + If unspecified default values shall be used.\n>> + - nvmem-cell-names: Should be \"calibration-data\"\n>\n>I'd prefer to have which sensor it applies to here. It wouldn't change\n>anything for the H3, but it definitely does for example for the A83t\n>that has two sensors, one for each cluster, and one for the GPU, each\n>with calibration data.\n>\n>What about cluster0-calibration?\n\nThe calibration data is in fact a 2 word (8 bytes) zone,\nwhich is reserved for 4 sensors on all SoCs, even on H3.\nIt's half word per sensor.\n\nI prefer to just assume a 2 word cell for every SoC.\n\n>\n>> +\n>> +Required properties for the following compatibles:\n>> +\t\t- \"allwinner,sun8i-h3-ths\"\n>> + - clocks: the bus clock and the input clock of the ADC,\n>> + - clock-names: should be \"bus\" and \"mod\",\n>> + - resets: the bus reset of the ADC,\n>> + - interrupts: the sampling interrupt of the ADC,\n>\n>For resets and interrupts, you should list all of them. If there's\n>only one, then there's no point telling which one it is.\n>\n>\n>Thanks,\n>Maxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"CEAkoCqg\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"YoRSsKX9\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwdq91qcNz9s3w\n\tfor ;\n\tMon, 18 Sep 2017 18:05:41 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtr3f-0002rp-JX; Mon, 18 Sep 2017 08:05:35 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqyn-0006ew-GL for linux-arm-kernel@bombadil.infradead.org;\n\tMon, 18 Sep 2017 08:00:33 +0000","from elephant.birch.relay.mailchannels.net ([23.83.209.57])\n\tby merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtqcW-0001gk-AZ for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 07:37:34 +0000","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 9AB401277C7;\n\tMon, 18 Sep 2017 07:37:04 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.137.32])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 73BDF127DA1;\n\tMon, 18 Sep 2017 07:37:03 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.63.14])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Mon, 18 Sep 2017 07:37:04 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 66D6547714;\n\tMon, 18 Sep 2017 07:36:56 +0000 (UTC)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Message-ID:From:To:Subject:MIME-Version\n\t:References:In-Reply-To:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=v38wwhvaSXINFLFoIu9BO5GMXkuZb1NsP0OUAq5NH6k=;\n\tb=CEAkoCqgFIj0E3\n\tKgrPZh1P4pLk+AUL2A+EI5VxdwXvOwkZlPBgu1DfpjRM3MbpTGjhb4Di+W5hh5nOPAtOX09R7137E\n\tcKX3vSym3/3krkVwzFeiYYC5pkE6QOb/86jbZ4Q8fh96m/1qQuVlyFGmrWamZtupF0mQ9ZcjuWZFH\n\tFjbd9BbhdIdlhBbBuTqybXAQ0RTdu+HalcbnEFQXzm3XE56tTAlz1cHeAFiqdjJX0pNOjuA+lh8Xq\n\toEDdYGXVrswTRXttz1dxEKLw5bSIbqDTTJFgs+LRC4EDxEdBLAzk53ajv1pYF3wchOU3resMwapZP\n\tshheiGg3zfXgKtUX1QCw==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209; h=Message-ID:From:CC:To:Subject:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:\n\tDate:Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:\n\tList-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=kiEscPOLNKm8mmB06hEHEWc8WQefptJFECwiYgFD0ZI=;\n\tb=YoRSsKX9Du5vlsNDNTDFw/kbc7\n\tQygVUgnXKYJDAu3tXDd1oZ0m4r+DF4sW8nfpofTTpLBGXkZjd5gAPOGrjzpO4khqISMHAXim3sfQ5\n\tfdAdFBcZY82PGNAx79C6olqbHAIyOCDd5tl8B/QAGonfx9B1RvObCDNepVhwHsJzETq4uRyHgfQPz\n\tp59YSHcgkK26dWaifLLKjzgsXCJ++HV6SmwZ5jrCg0rTBXIR2vOadFsbe9INsF4IDU8GxcOAkAbZB\n\tWxEghzUTc/yheayH6ftYgo36IGNttOfUMU2GYdCMRD5zXeQrGsDlvrGMWiN3/fCwmwty9uZ1J+iZ9\n\tN9m9hfKw==;"],"X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Eyes-Quick":"7912e2d9224a5065_1505720224467_376660800","X-MC-Loop-Signature":"1505720224467:1202691607","X-MC-Ingress-Time":"1505720224466","Date":"Mon, 18 Sep 2017 15:36:43 +0800","In-Reply-To":"<20170918073336.j7finend3g76chsu@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>\n\t<20170918073336.j7finend3g76chsu@flea.lan>","MIME-Version":"1.0","Subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","To":"Maxime Ripard ","From":"Icenowy Zheng ","Message-ID":"<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [23.83.209.57 listed in list.dnswl.org]\n\t-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)\n\t[23.83.209.57 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769968,"web_url":"http://patchwork.ozlabs.org/comment/1769968/","msgid":"<20170918082402.fa5mg2ucqouh3ti5@flea.lan>","list_archive_url":null,"date":"2017-09-18T08:24:02","subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Sat, Sep 16, 2017 at 06:14:08PM +0800, icenowy@aosc.io wrote:\n> > The H3 apparently supports IRQs, why do you not support them for the\n> > temperature? They might be broken as it is on A33 but then it might be a\n> > good idea to write it down in a comment in the driver (and not adding\n> > the unused registers in the header file) or at least in the commit log.\n> > \n> > 3) Now that you have support for clocks, wouldn't it be a good idea to\n> > disable them during suspend?\n> \n> Interesting... It's meaningful to disable the mod clock during suspend.\n\nAll clocks, actually. And put the device back into reset.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"KFH7VFSC\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfF46BFfz9s3w\n\tfor ;\n\tMon, 18 Sep 2017 18:24:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrM5-0006k5-7F; Mon, 18 Sep 2017 08:24:37 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrM1-0006an-4c for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 08:24:35 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 1D34F2081C; Mon, 18 Sep 2017 10:24:12 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id E53A3207F6;\n\tMon, 18 Sep 2017 10:24:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=QUlpdDs7hXwppkybAkQ4w9Z0e/41IMW4GI8BnSlZqq4=;\n\tb=KFH7VFSCshz/fqUj2wvYz9wFY\n\tqcymqZe0Jsg7etLxk2pNFiKlhA0VbtBq7V1Ikv28Yob+fMG+jemgnNwEoTZgmEkKSsFkIbu4B20Vc\n\tEyFjHF7oEucUJa52y2k5yqB0oOJn8wyCYHD0Uyp96Yqh4vLHwn5DpNskKI94Kt8jAfK/AEm3BDd+O\n\ts1r2C0Iog5N3/MasL0mjfCO1tbOcxn/chG3n6c9zw6QiqlYfM456D8my8205kKOx/8hfjZsWbPldP\n\t1gvZsvUAA7O4y6OtjlzH4QIIVMhNgYfE7jD3RFEnOYbKUuFhziV/A3YelCMstlgV0TVuC5RZ2ieMK\n\tjsehbxqig==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 10:24:02 +0200","From":"Maxime Ripard ","To":"icenowy@aosc.io","Subject":"Re: [PATCH v4 4/6] iio: adc: sun4i-gpadc-iio: add support for H3\n\tthermal sensor","Message-ID":"<20170918082402.fa5mg2ucqouh3ti5@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-5-icenowy@aosc.io>\n\t<445ea236-35e9-8d5a-e580-b2bdcf5f7776@free-electrons.com>\n\t<0b395ea1743a14a62855fc2a2dc74411@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<0b395ea1743a14a62855fc2a2dc74411@aosc.io>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_012433_357170_470E5BF4 ","X-CRM114-Status":"GOOD ( 15.36 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============0220010989635840926==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769970,"web_url":"http://patchwork.ozlabs.org/comment/1769970/","msgid":"<20170918082512.ovzwuorvwqjkueqa@flea.lan>","list_archive_url":null,"date":"2017-09-18T08:25:12","subject":"Re: [PATCH v4 5/6] ARM: sun8i: h3: add support for the thermal\n\tsensor in H3","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Thu, Sep 14, 2017 at 10:52:50PM +0800, Icenowy Zheng wrote:\n> As we have gained the support for the thermal sensor in H3, we can now\n> add its device nodes to the device tree.\n> \n> Add them to the H3 device tree.\n> \n> The calibration data of the thermal sensor is still not added, as\n> it's currently not used, and the SID node is not added yet.\n> \n> The H5 thermal sensor has some differences, and will be added furtherly.\n> \n> Signed-off-by: Icenowy Zheng \n> Reviewed-by: Chen-Yu Tsai \n> ---\n> Changes in v4:\n> - Mention calibration data in commit message.\n> Changes in v3:\n> - Clock name changes.\n> - Splited out thermal zone addition.\n> \n> arch/arm/boot/dts/sun8i-h3.dtsi | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi\n> index b36f9f423c39..3220da3ad790 100644\n> --- a/arch/arm/boot/dts/sun8i-h3.dtsi\n> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi\n> @@ -72,6 +72,23 @@\n> \t\t};\n> \t};\n> \n> +\tiio-hwmon {\n> +\t\tcompatible = \"iio-hwmon\";\n> +\t\tio-channels = <&ths>;\n> +\t};\n> +\n> +\tsoc {\n> +\t\tths: thermal-sensor@1c25000 {\n> +\t\t\tcompatible = \"allwinner,sun8i-h3-ths\";\n> +\t\t\treg = <0x01c25000 0x100>;\n> +\t\t\tclocks = <&ccu CLK_BUS_THS>, <&ccu CLK_THS>;\n> +\t\t\tclock-names = \"bus\", \"mod\";\n> +\t\t\tresets = <&ccu RST_BUS_THS>;\n> +\t\t\t#thermal-sensor-cells = <0>;\n> +\t\t\t#io-channel-cells = <0>;\n\nYou're missing your interrupt.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ALE6kR2G\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=infradead.org header.i=@infradead.org\n\theader.b=\"iyDwZMio\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfGZ1XhLz9rxm\n\tfor ;\n\tMon, 18 Sep 2017 18:25:58 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrNK-00008J-5f; Mon, 18 Sep 2017 08:25:54 +0000","from merlin.infradead.org ([2001:8b0:10b:1231::1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrNG-00006A-3f for linux-arm-kernel@bombadil.infradead.org;\n\tMon, 18 Sep 2017 08:25:50 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby merlin.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrND-0002wK-8t for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 08:25:48 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid E73AA20811; Mon, 18 Sep 2017 10:25:24 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id B08A420924;\n\tMon, 18 Sep 2017 10:25:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=tysG/c2QgxB184vnqhHSRaWBBrTAUtT9IbflECgGgYc=;\n\tb=ALE6kR2GhCFNYGNppQz1TaFlJ\n\tPBH3qLA6XwG/83XMU92sbpRNwbAELDQabx3zru5KIHVQBR6hdkm+ozk/+eyM5ir7hiDZTRzi8ka0h\n\tzO+Rvbad2OxHDHkznUoR7ApojTN0eNTO7yeZxRJiVcT72IMm8ZNAgr7/eQPdryhUdmfRqbd+bPmW4\n\t06grAYQXcqNgcH3XTSWEgkYPmhaZly5bu9NnjLO6qC285JzhUCwBu1qqupss4XtBXdNcr/062chPS\n\tF9jJqimDxQvvsKQXtN9U8eCT0Jz2rbin004X5Ue5iZv5Y+KpcaxDrEAIN3DPeTFp6wDYIatBIrtod\n\tainDfqKlg==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=merlin.20170209;\n\th=In-Reply-To:Content-Type:MIME-Version:\n\tReferences:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:\n\tList-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;\n\tbh=iDn3VRstr8wkx/hA6gUUx5SOUkSiTJarosBSuG6w8Q0=;\n\tb=iyDwZMio7frKJDit1AOkw/qOI\n\t0g6vuFTDUiV3crnSdbBA25D4X6NQjOUWIcPT0O7AAa61DsHz29JBDNTI2m+zVmyNlwYXg5AyR/9dW\n\t0Rwk8oePW/tefy42P4n8pdxlaAnldjKboDLk0MaxpOnYE8rgbH5JyfKGeAwnCdl5Y+Mihl8MqR6RL\n\tMisdodAVR2eC1AIl5wHdkMJyMmgUHxatNSwz0zPv9N/ZsKtbD0BSWiTlszVuziV5hOyscMowWKocP\n\t4sWI6kmU5xGdzeyk7MeeQeImOclavTcs6KAKvUrPbZE0ExLuU2zuqZnoFidFUVGGm3X7FQIz2YmKY\n\t3+3rLixYQ==;"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 10:25:12 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Subject":"Re: [PATCH v4 5/6] ARM: sun8i: h3: add support for the thermal\n\tsensor in H3","Message-ID":"<20170918082512.ovzwuorvwqjkueqa@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-6-icenowy@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<20170914145251.21784-6-icenowy@aosc.io>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-Spam-Note":"CRM114 invocation failed","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on merlin.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============6068878582035759393==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769972,"web_url":"http://patchwork.ozlabs.org/comment/1769972/","msgid":"<20170918082703.riqntqilakzhirc5@flea.lan>","list_archive_url":null,"date":"2017-09-18T08:27:03","subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi Jonathan,\n\nOn Sat, Sep 16, 2017 at 03:17:34PM -0700, Jonathan Cameron wrote:\n> On Sat, 16 Sep 2017 12:05:49 +0200\n> Quentin Schulz wrote:\n> \n> > Hi Icenowy,\n> > \n> > On 14/09/2017 16:52, Icenowy Zheng wrote:\n> > > Because of the restriction of the OF thermal framework, the thermal\n> > > sensor will fail to probe if the thermal zone doesn't exist.\n> > > \n> > \n> > Oh no, that's not good.\n> > \n> > We discussed about it on IRC and I even proposed a patch for it, telling\n> > you I would post it on the mailing list soon after. Of course, I forgot\n> > and you definitely should have yelled at me for not doing it :)\n> > \n> > I won't be able to test the patch soon. I can send it to you so that you\n> > can test it and integrate it in your patch series so it won't block you.\n> > Otherwise, we'll have to wait for a week or two for me to test it.\n> > \n> > Thanks and sorry for forgetting to post the patch you need,\n> > Quentin\n> \n> Other this outstanding issue I'm happy with the series, so hopefully\n> with Quentin's patch added we should be good to merge this one.\n\nWe will at least need a v5.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"EEBvvyIF\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfJl5Q5Mz9rxm\n\tfor ;\n\tMon, 18 Sep 2017 18:27:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrPA-0001Od-9d; Mon, 18 Sep 2017 08:27:48 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrOw-000150-EQ for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 08:27:43 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 46BCD20B90; Mon, 18 Sep 2017 10:27:13 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 1C11620A5C;\n\tMon, 18 Sep 2017 10:27:03 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=8R74XOdn6/civnd9S4/pt4A2nIKN7PfIOnEL5ze6wK4=;\n\tb=EEBvvyIF/AbQCBMI99Ur0feRY\n\tGnUdsn8PFLL0RxVUGE6AkNLy6GcWZ74q3lczA0ZUd9mPi68IBn+IRuVUZoDHrbokv3xSxKpIe1df4\n\tnX+wNbAxBbNM1apfoCIU747Qu+eXgwtGwp2KLvQ61XQiz9nvWuphid7YjOmjhnDDW/GmVD3iA7QmY\n\tCZwqXqIwo6nzO/6o0PInoCTgGcEPOdMQyKVmn1dt8QE+X8EiUg7/vUA8hrctzc8BSxia78s/axASK\n\t+SV4AG7jI5/Cx0ZkETAma6Q0E9IH74eI+pDuQcYDZxK4yK6qQpIjJXyq42PH4i9u8VtBdAOe+sLeG\n\tFB2iXLNbA==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 10:27:03 +0200","From":"Maxime Ripard ","To":"Jonathan Cameron ","Subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","Message-ID":"<20170918082703.riqntqilakzhirc5@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-7-icenowy@aosc.io>\n\t\n\t<20170916151734.10968b7a@archlinux>","MIME-Version":"1.0","In-Reply-To":"<20170916151734.10968b7a@archlinux>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_012734_965823_A188B1CB ","X-CRM114-Status":"GOOD ( 19.82 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tLee Jones , linux-arm-kernel@lists.infradead.org,\n\tIcenowy Zheng ","Content-Type":"multipart/mixed;\n\tboundary=\"===============1356908577290831887==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769978,"web_url":"http://patchwork.ozlabs.org/comment/1769978/","msgid":"<20170918083045.7bfiialtbm7w6i7j@flea.lan>","list_archive_url":null,"date":"2017-09-18T08:30:45","subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote:\n> 于 2017年9月18日 GMT+08:00 下午3:33:36, Maxime Ripard 写到:\n> >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote:\n> >> Allwinner H3 features a thermal sensor like the one in A33, but has\n> >its\n> >> register re-arranged, the clock divider moved to CCU (originally the\n> >> clock divider is in ADC) and added a pair of bus clock and reset.\n> >> \n> >> Update the binding document to cover H3.\n> >> \n> >> Signed-off-by: Icenowy Zheng \n> >> Reviewed-by: Chen-Yu Tsai \n> >> ---\n> >> Changes in v4:\n> >> - Add nvmem calibration data (not yet used by the driver)\n> >> Changes in v3:\n> >> - Clock name changes.\n> >> - Example node name changes.\n> >> - Add interupts (not yet used by the driver).\n> >> \n> >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30\n> >++++++++++++++++++++--\n> >> 1 file changed, 28 insertions(+), 2 deletions(-)\n> >> \n> >> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >> index badff3611a98..6c470d584bf9 100644\n> >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also\n> >act as a thermal sensor\n> >> and sometimes as a touchscreen controller.\n> >> \n> >> Required properties:\n> >> - - compatible: \"allwinner,sun8i-a33-ths\",\n> >> + - compatible: must contain one of the following compatibles:\n> >> +\t\t- \"allwinner,sun8i-a33-ths\"\n> >> +\t\t- \"allwinner,sun8i-h3-ths\"\n> >> - reg: mmio address range of the chip,\n> >> - #thermal-sensor-cells: shall be 0,\n> >> - #io-channel-cells: shall be 0,\n> >> \n> >> -Example:\n> >> +Optional properties:\n> >> + - nvmem-cells: A phandle to the calibration data provided by a\n> >nvmem device.\n> >> + If unspecified default values shall be used.\n> >> + - nvmem-cell-names: Should be \"calibration-data\"\n> >\n> >I'd prefer to have which sensor it applies to here. It wouldn't change\n> >anything for the H3, but it definitely does for example for the A83t\n> >that has two sensors, one for each cluster, and one for the GPU, each\n> >with calibration data.\n> >\n> >What about cluster0-calibration?\n> \n> The calibration data is in fact a 2 word (8 bytes) zone,\n> which is reserved for 4 sensors on all SoCs, even on H3.\n> It's half word per sensor.\n> \n> I prefer to just assume a 2 word cell for every SoC.\n\nYou have three different data sources, it should be reprensented as\nsuch.\n\nOtherwise, the client has to get some knowledge of how the data are\nstored in the provider, which is an abstraction violation.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"Kd4AD2py\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfP94rNyz9s7c\n\tfor ;\n\tMon, 18 Sep 2017 18:31:41 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrSr-0004M5-V1; Mon, 18 Sep 2017 08:31:37 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrSf-0004D3-I2 for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 08:31:34 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 4FA3E2092D; Mon, 18 Sep 2017 10:31:04 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 362B1207F6;\n\tMon, 18 Sep 2017 10:30:45 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=KyGW5Lbmo+Zulo0dPg+Oyxc6CyWvIZ3twi2whJbKrzU=;\n\tb=Kd4AD2py/59PTiRFxx16Fw/mm\n\t2w834YKBK2YyqufKC60DsmgF27rng9Uq8bdHJ39j6C9051N7ZmE1G6bKGxfC1ve4FKHmZHpPuUNMb\n\t2+kuIjx1Cv4vb5VAd5A6CYFjeLNlfpsgCeB5X7bFOJuNZ4mM7r7MCs1gzxJIz9VeB0+G6uYUVAwe/\n\tVtod70dmZYQcuJ5okd8WLPTCF1XHBDEnqFv/4zyAOToF/a0l8xh0KMNQ8V0qFvaQgTALKwmHxfskc\n\tefF4pHkxvDNufIAye5lrytA3JSy4NVuCHbb2gpvujYOyZyfrHMpQJoSUIR/wp8806iHm3XifUv2xT\n\ti21/mQjIw==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 18 Sep 2017 10:30:45 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Subject":"Re: [PATCH v4 1/6] dt-bindings: update the Allwinner GPADC device\n\ttree binding for H3","Message-ID":"<20170918083045.7bfiialtbm7w6i7j@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>\n\t<20170918073336.j7finend3g76chsu@flea.lan>\n\t<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>","User-Agent":"NeoMutt/20170714 (1.8.3)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_013126_190818_B6A30827 ","X-CRM114-Status":"GOOD ( 23.50 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============4896578819444588065==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769985,"web_url":"http://patchwork.ozlabs.org/comment/1769985/","msgid":"<20170918082948.2bl5e44tzsufdj7n@dell>","list_archive_url":null,"date":"2017-09-18T08:29:48","subject":"Re: [PATCH v4 2/6] iio: adc: sun4i-gpadc-iio: rename A33-specified\n\tregisters to contain A33","submitter":{"id":12720,"url":"http://patchwork.ozlabs.org/api/people/12720/","name":"Lee Jones","email":"lee.jones@linaro.org"},"content":"On Thu, 14 Sep 2017, Icenowy Zheng wrote:\n\n> As the H3 SoC, which is also in sun8i line, has totally different\n> register map for the thermal sensor (a cut down version of GPADC), we\n> should rename A23/A33-specified registers to contain A33, in order to\n> prevent obfuscation with H3 registers. Currently these registers are\n> only prefixed \"SUN8I\", not \"SUN8I_A33\".\n> \n> Add \"_A33\" after \"SUN8I\" on the register names.\n> \n> Signed-off-by: Icenowy Zheng \n> Reviewed-by: Chen-Yu Tsai \n> ---\n> Changes in v4:\n> - Change A23 to A33, as the driver never supports A23.\n> \n> drivers/iio/adc/sun4i-gpadc-iio.c | 2 +-\n\n> include/linux/mfd/sun4i-gpadc.h | 6 +++---\n\nAcked-by: Lee Jones ","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"DqCEgEeN\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"CHO/rHWX\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwfZJ4hqCz9rxm\n\tfor ;\n\tMon, 18 Sep 2017 18:39:36 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtraT-0000Rq-CG; Mon, 18 Sep 2017 08:39:29 +0000","from mail-wr0-x231.google.com ([2a00:1450:400c:c0c::231])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtrRW-0002Bk-Cd for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 08:30:23 +0000","by mail-wr0-x231.google.com with SMTP id l22so5608683wrc.10\n\tfor ;\n\tMon, 18 Sep 2017 01:29:52 -0700 (PDT)","from dell ([2.27.167.120]) by smtp.gmail.com with ESMTPSA id\n\tw2sm5214635wrb.67.2017.09.18.01.29.49\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 01:29:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=9eNceMqTKCdN528saJlGaPMB9pdOz3Hqg9PYzsitj7g=;\n\tb=DqCEgEeNlsyh+V\n\thU6ETdmKlcgzwmxDQBeWgVaHEfTpybPzDoDwT+lPu6k2usJbRHQt1lxjLGfKGOBPD0vSEaoeTY9fQ\n\tCSEV4cYuwerBMIOVdr9G1EGDvLG6oDe2L1VPtDf+XKMQi1YdSNFc2cg9k/riPw/NtokQ9H6h/EwWz\n\ts7/dqvXSXhpFDbtkxFpmrB1owwiP/Ij+dn51Wjm5rTNLG14NtOSAENgIfVSCTWGLnGwiCyf3DSgD2\n\tqzSFxz9tGJkU+7fmWWOqsJ5Dkfbnli6Zx766OenYZoGcG6jM9+bAz/7NL4kKOPvr+XqKJXF3tVwZd\n\tre2/sTSxLkOfpirxSu+Q==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=9KBuAfT1UDDtyaEZOoX6A9ShMpyEroTIVjeRElJ8u4A=;\n\tb=CHO/rHWXyNhcc7otvLwJeOffPFBZgvVSHido50WknIfDrIud5V607UPzosKTZ/58Bu\n\tp7rmH9k88sip3y8vjCzdcNmZ9lJ3xtNKz8sIk1kab9T2LLLMqnS/99TftAzTyUPxWeH0\n\txCGn+DRvaehzhDK84DK3dVL1xzR5xVM8lIjic="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=9KBuAfT1UDDtyaEZOoX6A9ShMpyEroTIVjeRElJ8u4A=;\n\tb=XTYJkWsi56W4AVylMnQOeIPwLfUh7vofjFbgAcsvbgPiTYwNWv17FM227YHqOO6tBe\n\tRw0TXuTLaKKgFQ/a7Q0BmUkka8MbHyhhCfYgJdtukDYYSDWLEVimHf2JUhRZ/3jCTYTL\n\ttWbb/2GdwdasyH0ucOLelQqaqXpw6hk6OmxublMhxTGjaJiijB8CIHbFnmukorFyQ8M8\n\tRucmNrSUPmMShP237lZGPYb/hqjAltz9+7mI/HZH8AxKiZJEMzvXBHcPmoHMz6zjUAKc\n\t2M/x2SVUQ2v9SPAdTmdpybx3OLoei5tuS38kGRRomiUluCaQzyNQfVxfujZe+RZXs2sK\n\tFamA==","X-Gm-Message-State":"AHPjjUhJU6GcmmZMwmHliaK7VHBWQxfSuUg61R8QQCUmwaDRot6UOKNa\n\tWJL/HBMsykd2489E","X-Google-Smtp-Source":"AOwi7QCo5QORgb/N5A5CjagNtLBV3U9AJ1XcMuYM7DpSBQeUpa1G2FVHP5ZNWLa8x7y3VKS8nrwFgQ==","X-Received":"by 10.223.155.157 with SMTP id d29mr93921wrc.24.1505723391016;\n\tMon, 18 Sep 2017 01:29:51 -0700 (PDT)","Date":"Mon, 18 Sep 2017 09:29:48 +0100","From":"Lee Jones ","To":"Icenowy Zheng ","Subject":"Re: [PATCH v4 2/6] iio: adc: sun4i-gpadc-iio: rename A33-specified\n\tregisters to contain A33","Message-ID":"<20170918082948.2bl5e44tzsufdj7n@dell>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-3-icenowy@aosc.io>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20170914145251.21784-3-icenowy@aosc.io>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_013015_457634_C280E923 ","X-CRM114-Status":"GOOD ( 11.07 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:231 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tMaxime Ripard ,\n\tJonathan Cameron ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1770268,"web_url":"http://patchwork.ozlabs.org/comment/1770268/","msgid":"","list_archive_url":null,"date":"2017-09-18T15:47:25","subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"在 2017-09-18 16:30，Maxime Ripard 写道：\n> On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote:\n>> 于 2017年9月18日 GMT+08:00 下午3:33:36, Maxime Ripard \n>> 写到:\n>> >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote:\n>> >> Allwinner H3 features a thermal sensor like the one in A33, but has\n>> >its\n>> >> register re-arranged, the clock divider moved to CCU (originally the\n>> >> clock divider is in ADC) and added a pair of bus clock and reset.\n>> >>\n>> >> Update the binding document to cover H3.\n>> >>\n>> >> Signed-off-by: Icenowy Zheng \n>> >> Reviewed-by: Chen-Yu Tsai \n>> >> ---\n>> >> Changes in v4:\n>> >> - Add nvmem calibration data (not yet used by the driver)\n>> >> Changes in v3:\n>> >> - Clock name changes.\n>> >> - Example node name changes.\n>> >> - Add interupts (not yet used by the driver).\n>> >>\n>> >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30\n>> >++++++++++++++++++++--\n>> >> 1 file changed, 28 insertions(+), 2 deletions(-)\n>> >>\n>> >> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> >> index badff3611a98..6c470d584bf9 100644\n>> >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also\n>> >act as a thermal sensor\n>> >> and sometimes as a touchscreen controller.\n>> >>\n>> >> Required properties:\n>> >> - - compatible: \"allwinner,sun8i-a33-ths\",\n>> >> + - compatible: must contain one of the following compatibles:\n>> >> +\t\t- \"allwinner,sun8i-a33-ths\"\n>> >> +\t\t- \"allwinner,sun8i-h3-ths\"\n>> >> - reg: mmio address range of the chip,\n>> >> - #thermal-sensor-cells: shall be 0,\n>> >> - #io-channel-cells: shall be 0,\n>> >>\n>> >> -Example:\n>> >> +Optional properties:\n>> >> + - nvmem-cells: A phandle to the calibration data provided by a\n>> >nvmem device.\n>> >> + If unspecified default values shall be used.\n>> >> + - nvmem-cell-names: Should be \"calibration-data\"\n>> >\n>> >I'd prefer to have which sensor it applies to here. It wouldn't change\n>> >anything for the H3, but it definitely does for example for the A83t\n>> >that has two sensors, one for each cluster, and one for the GPU, each\n>> >with calibration data.\n>> >\n>> >What about cluster0-calibration?\n\nI prefer sensor0-calibration to sensor3-calibration now.\n(Theortically the new generation THS can support up to 4 sensors)\n\n>> \n>> The calibration data is in fact a 2 word (8 bytes) zone,\n>> which is reserved for 4 sensors on all SoCs, even on H3.\n>> It's half word per sensor.\n>> \n>> I prefer to just assume a 2 word cell for every SoC.\n> \n> You have three different data sources, it should be reprensented as\n> such.\n> \n> Otherwise, the client has to get some knowledge of how the data are\n> stored in the provider, which is an abstraction violation.\n> \n> Maxime\n> \n> --\n> Maxime Ripard, Free Electrons\n> Embedded Linux and Kernel engineering\n> http://free-electrons.com","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"T6wtDHjt\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwr4h4ZVjz9s78\n\tfor ;\n\tTue, 19 Sep 2017 01:48:04 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtyHB-0006KF-H0; Mon, 18 Sep 2017 15:48:01 +0000","from nov-007-i584.relay.mailchannels.net ([46.232.183.138])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtyH6-0006HF-BS for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 15:47:59 +0000","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 2AA6D2097A0;\n\tMon, 18 Sep 2017 15:47:30 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.147.29])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id CD9B5209343;\n\tMon, 18 Sep 2017 15:47:28 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.63.30])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Mon, 18 Sep 2017 15:47:30 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id C9E994771E;\n\tMon, 18 Sep 2017 15:47:25 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From:\n\tDate:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=PNNMnMBWmUzW9CSowJkJB2e5DKWcq+OSgLnPydvCeVg=;\n\tb=T6wtDHjtUY76ke9EsDewIfZDl\n\tnCmNMnb9JuId/ogCTKpeo4fUv5nLkaFNlOGlG6za00IghE1r5qdlnZBYYXm0D5iOQWAY7aiOQ1M57\n\tDR5tOhV+7hWsIh9CPl3t4ihMY42Dpa+icaS8lqLj4tjqpnYuw5jZoHr9qjnWBrjSQMHkytwRravUJ\n\tKBCVDyXfR/95qC1UNhAl27izTcUKdsBcf5xKhpbwll71E+DiKyVPy5h9LbHp2gtBEwv53LJOJWc0B\n\tC3rJCdkrDown4pD6kUa48Lh6hdiQx6ENL60HSCaq70EMaG7RqVq0N48SEDiYD7i3fbVie1q+8I3eC\n\twKjL4zz+Q==;","X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Eight-Cold":"0703f81d750a380a_1505749649823_706633000","X-MC-Loop-Signature":"1505749649823:607977472","X-MC-Ingress-Time":"1505749649822","MIME-Version":"1.0","Date":"Mon, 18 Sep 2017 23:47:25 +0800","From":"icenowy@aosc.io","To":"maxime.ripard@free-electrons.com","Subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","In-Reply-To":"<20170918083045.7bfiialtbm7w6i7j@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>\n\t<20170918073336.j7finend3g76chsu@flea.lan>\n\t<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>\n\t<20170918083045.7bfiialtbm7w6i7j@flea.lan>","Message-ID":"","X-Sender":"icenowy@aosc.io","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170918_084757_144070_C53D3FE2 ","X-CRM114-Status":"GOOD ( 15.73 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [46.232.183.138 listed in list.dnswl.org]\n\t-0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3)\n\t[46.232.183.138 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.0 RCVD_IN_MSPIKE_WL Mailspike good senders","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771655,"web_url":"http://patchwork.ozlabs.org/comment/1771655/","msgid":"<20170920075223.jaeswlhcqgu4yhse@flea.home>","list_archive_url":null,"date":"2017-09-20T07:52:23","subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Mon, Sep 18, 2017 at 03:47:25PM +0000, icenowy@aosc.io wrote:\n> 在 2017-09-18 16:30，Maxime Ripard 写道：\n> > On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote:\n> > > 于 2017年9月18日 GMT+08:00 下午3:33:36, Maxime Ripard\n> > > 写到:\n> > > >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote:\n> > > >> Allwinner H3 features a thermal sensor like the one in A33, but has\n> > > >its\n> > > >> register re-arranged, the clock divider moved to CCU (originally the\n> > > >> clock divider is in ADC) and added a pair of bus clock and reset.\n> > > >>\n> > > >> Update the binding document to cover H3.\n> > > >>\n> > > >> Signed-off-by: Icenowy Zheng \n> > > >> Reviewed-by: Chen-Yu Tsai \n> > > >> ---\n> > > >> Changes in v4:\n> > > >> - Add nvmem calibration data (not yet used by the driver)\n> > > >> Changes in v3:\n> > > >> - Clock name changes.\n> > > >> - Example node name changes.\n> > > >> - Add interupts (not yet used by the driver).\n> > > >>\n> > > >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30\n> > > >++++++++++++++++++++--\n> > > >> 1 file changed, 28 insertions(+), 2 deletions(-)\n> > > >>\n> > > >> diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> > > >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> > > >> index badff3611a98..6c470d584bf9 100644\n> > > >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> > > >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> > > >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can also\n> > > >act as a thermal sensor\n> > > >> and sometimes as a touchscreen controller.\n> > > >>\n> > > >> Required properties:\n> > > >> - - compatible: \"allwinner,sun8i-a33-ths\",\n> > > >> + - compatible: must contain one of the following compatibles:\n> > > >> +\t\t- \"allwinner,sun8i-a33-ths\"\n> > > >> +\t\t- \"allwinner,sun8i-h3-ths\"\n> > > >> - reg: mmio address range of the chip,\n> > > >> - #thermal-sensor-cells: shall be 0,\n> > > >> - #io-channel-cells: shall be 0,\n> > > >>\n> > > >> -Example:\n> > > >> +Optional properties:\n> > > >> + - nvmem-cells: A phandle to the calibration data provided by a\n> > > >nvmem device.\n> > > >> + If unspecified default values shall be used.\n> > > >> + - nvmem-cell-names: Should be \"calibration-data\"\n> > > >\n> > > >I'd prefer to have which sensor it applies to here. It wouldn't change\n> > > >anything for the H3, but it definitely does for example for the A83t\n> > > >that has two sensors, one for each cluster, and one for the GPU, each\n> > > >with calibration data.\n> > > >\n> > > >What about cluster0-calibration?\n> \n> I prefer sensor0-calibration to sensor3-calibration now.\n> (Theortically the new generation THS can support up to 4 sensors)\n\nThe mapping that explains what sensor0 means can change in the\nfuture. It's better to be explicit here, and just say upfront what\nit's about.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"Jnlf4YgN\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxsRd02c4z9s8J\n\tfor ;\n\tWed, 20 Sep 2017 17:53:01 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duZoX-0007lU-Jd; Wed, 20 Sep 2017 07:52:57 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duZoL-0007eB-2i for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 07:52:53 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid D4B3520914; Wed, 20 Sep 2017 09:52:22 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id A3AE52090A;\n\tWed, 20 Sep 2017 09:52:22 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=YllgZ3NvmZWfAxG3rZ0+YNcb31holhgdyym0aosk3ho=;\n\tb=Jnlf4YgNVwf/y9AGsvpI7oLn9\n\txcQQDxTq8YjSoTU4hn3QEhPAMWyyoxx5j9lbl2MCmVHMnRviITd5XCI6ifZ8oyMnd+0fka4fXRkNQ\n\tOQKgCVphAfddHUoLIJC77AuybJTr8mC5OqvL2W3CksFEQbxLp2Le4wGjWUDFQkeGWg8AWW4aqNV72\n\tdHlwv8m1JVj8MhTBPb189jnRF5CTpJUu+0yIBmuFNOglpvLI7J6J1nMRgt0kkG9fLHz/ASgW51jCV\n\tEfsMyzQk0sDg6QaN3Fi8tuOgDkcjm9q0dPwYLUWTzPdETjp6I3/JCdCOLCM2VT7sXzV1UEJ0uTx4I\n\t1QVM2vPSg==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Wed, 20 Sep 2017 09:52:23 +0200","From":"Maxime Ripard ","To":"icenowy@aosc.io","Subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","Message-ID":"<20170920075223.jaeswlhcqgu4yhse@flea.home>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>\n\t<20170918073336.j7finend3g76chsu@flea.lan>\n\t<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>\n\t<20170918083045.7bfiialtbm7w6i7j@flea.lan>\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"NeoMutt/20170914 (1.9.0)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_005247_014829_6E68613D ","X-CRM114-Status":"GOOD ( 22.12 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============4908576174277191738==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771660,"web_url":"http://patchwork.ozlabs.org/comment/1771660/","msgid":"<27449039-F0D4-4663-B596-C95D4408D471@aosc.io>","list_archive_url":null,"date":"2017-09-20T08:04:02","subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"于 2017年9月20日 GMT+08:00 下午3:52:23, Maxime Ripard 写到:\n>On Mon, Sep 18, 2017 at 03:47:25PM +0000, icenowy@aosc.io wrote:\n>> 在 2017-09-18 16:30，Maxime Ripard 写道：\n>> > On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote:\n>> > > 于 2017年9月18日 GMT+08:00 下午3:33:36, Maxime Ripard\n>> > > 写到:\n>> > > >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote:\n>> > > >> Allwinner H3 features a thermal sensor like the one in A33,\n>but has\n>> > > >its\n>> > > >> register re-arranged, the clock divider moved to CCU\n>(originally the\n>> > > >> clock divider is in ADC) and added a pair of bus clock and\n>reset.\n>> > > >>\n>> > > >> Update the binding document to cover H3.\n>> > > >>\n>> > > >> Signed-off-by: Icenowy Zheng \n>> > > >> Reviewed-by: Chen-Yu Tsai \n>> > > >> ---\n>> > > >> Changes in v4:\n>> > > >> - Add nvmem calibration data (not yet used by the driver)\n>> > > >> Changes in v3:\n>> > > >> - Clock name changes.\n>> > > >> - Example node name changes.\n>> > > >> - Add interupts (not yet used by the driver).\n>> > > >>\n>> > > >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30\n>> > > >++++++++++++++++++++--\n>> > > >> 1 file changed, 28 insertions(+), 2 deletions(-)\n>> > > >>\n>> > > >> diff --git\n>a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> > > >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> > > >> index badff3611a98..6c470d584bf9 100644\n>> > > >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> > > >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n>> > > >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can\n>also\n>> > > >act as a thermal sensor\n>> > > >> and sometimes as a touchscreen controller.\n>> > > >>\n>> > > >> Required properties:\n>> > > >> - - compatible: \"allwinner,sun8i-a33-ths\",\n>> > > >> + - compatible: must contain one of the following\n>compatibles:\n>> > > >> +\t\t- \"allwinner,sun8i-a33-ths\"\n>> > > >> +\t\t- \"allwinner,sun8i-h3-ths\"\n>> > > >> - reg: mmio address range of the chip,\n>> > > >> - #thermal-sensor-cells: shall be 0,\n>> > > >> - #io-channel-cells: shall be 0,\n>> > > >>\n>> > > >> -Example:\n>> > > >> +Optional properties:\n>> > > >> + - nvmem-cells: A phandle to the calibration data provided\n>by a\n>> > > >nvmem device.\n>> > > >> + If unspecified default values shall be used.\n>> > > >> + - nvmem-cell-names: Should be \"calibration-data\"\n>> > > >\n>> > > >I'd prefer to have which sensor it applies to here. It wouldn't\n>change\n>> > > >anything for the H3, but it definitely does for example for the\n>A83t\n>> > > >that has two sensors, one for each cluster, and one for the GPU,\n>each\n>> > > >with calibration data.\n>> > > >\n>> > > >What about cluster0-calibration?\n>> \n>> I prefer sensor0-calibration to sensor3-calibration now.\n>> (Theortically the new generation THS can support up to 4 sensors)\n>\n>The mapping that explains what sensor0 means can change in the\n>future. It's better to be explicit here, and just say upfront what\n>it's about.\n\nI think for some SoC (e.g. A64) there's no clear explain on\nthe functions of the sensors.\n\nIn addition, in the THS controller the sensors has a\nexplicit sequence, and when referencing it in the DT\nthe number is still needed (in thermal zones).\n\n>\n>Maxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"lZuTJxVd\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxsjf0W8kz9s8J\n\tfor ;\n\tWed, 20 Sep 2017 18:05:07 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dua0F-0005YP-3d; Wed, 20 Sep 2017 08:05:03 +0000","from caracal.ash.relay.mailchannels.net ([23.83.222.30])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dua08-0005P8-R1 for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 08:05:00 +0000","from relay.mailchannels.net (localhost [127.0.0.1])\n\tby relay.mailchannels.net (Postfix) with ESMTP id 497B4127DAC;\n\tWed, 20 Sep 2017 08:04:27 +0000 (UTC)","from hermes.aosc.io (unknown [100.96.137.55])\n\t(Authenticated sender: lmn-TZDUIOWCRQMW)\n\tby relay.mailchannels.net (Postfix) with ESMTPA id 0952D128D5A;\n\tWed, 20 Sep 2017 08:04:25 +0000 (UTC)","from hermes.aosc.io (hermes.aosc.io [172.20.82.168])\n\t(using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384)\n\tby 0.0.0.0:2500 (trex/5.9.14); Wed, 20 Sep 2017 08:04:27 +0000","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 54B0047A87;\n\tWed, 20 Sep 2017 08:04:14 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Message-ID:From:To:Subject:MIME-Version\n\t:References:In-Reply-To:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=tGn4Co4JTcRhJvf/9ibLpl/uMp7tU7uXBVcJaVY+WCA=;\n\tb=lZuTJxVd0L50CV\n\tuTgBYp65JizlcIVBM6uvIDmKkdhcG5W/nkyfu5Adk03DByYM/xAU4mW28wZKwUCSfC367CaoKc44Y\n\tVE4+6Vo1om2KCQit92kni7L/Cj0MKvSa01MWhDJJTvBm8stpEglyYuLAO6lmG4s86vYpa+am/+weL\n\twMhm9q49u9SuU+h5K81rw+up8R25BXG3FaNGjRCCbj13C4EDfUSAljyd7MhB4vNMM3pMInpa+s7dp\n\tendnf+yqGzy4qFliL9a7tcMSHqxNQX7T471x0miOaBuBjjWCrruTUobNiVY8+r6+phFrcYknuGWq8\n\tFZHRlSvkEikw2mn/AiBA==;","X-Sender-Id":["lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io"],"X-MC-Relay":"Neutral","X-MailChannels-SenderId":"lmn-tzduiowcrqmw|x-authsender|icenowy@aosc.io","X-MailChannels-Auth-Id":"lmn-TZDUIOWCRQMW","X-Tart-Abiding":"08a58e3917e537e3_1505894666920_1773869730","X-MC-Loop-Signature":"1505894666920:3129468078","X-MC-Ingress-Time":"1505894666920","Date":"Wed, 20 Sep 2017 16:04:02 +0800","In-Reply-To":"<20170920075223.jaeswlhcqgu4yhse@flea.home>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>\n\t<20170918073336.j7finend3g76chsu@flea.lan>\n\t<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>\n\t<20170918083045.7bfiialtbm7w6i7j@flea.lan>\n\t\n\t<20170920075223.jaeswlhcqgu4yhse@flea.home>","MIME-Version":"1.0","Subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","To":"maxime.ripard@free-electrons.com,\n\tMaxime Ripard ","From":"Icenowy Zheng ","Message-ID":"<27449039-F0D4-4663-B596-C95D4408D471@aosc.io>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_010457_781342_425BBA3D ","X-CRM114-Status":"GOOD ( 16.52 )","X-Spam-Score":"-4.7 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [23.83.222.30 listed in list.dnswl.org]\n\t-2.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)\n\t[23.83.222.30 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1773187,"web_url":"http://patchwork.ozlabs.org/comment/1773187/","msgid":"<20170921193211.pjsikkez5by46mfh@flea>","list_archive_url":null,"date":"2017-09-21T19:32:11","subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Wed, Sep 20, 2017 at 08:04:02AM +0000, Icenowy Zheng wrote:\n> 于 2017年9月20日 GMT+08:00 下午3:52:23, Maxime Ripard 写到:\n> >On Mon, Sep 18, 2017 at 03:47:25PM +0000, icenowy@aosc.io wrote:\n> >> 在 2017-09-18 16:30，Maxime Ripard 写道：\n> >> > On Mon, Sep 18, 2017 at 03:36:43PM +0800, Icenowy Zheng wrote:\n> >> > > 于 2017年9月18日 GMT+08:00 下午3:33:36, Maxime Ripard\n> >> > > 写到:\n> >> > > >On Thu, Sep 14, 2017 at 10:52:46PM +0800, Icenowy Zheng wrote:\n> >> > > >> Allwinner H3 features a thermal sensor like the one in A33,\n> >but has\n> >> > > >its\n> >> > > >> register re-arranged, the clock divider moved to CCU\n> >(originally the\n> >> > > >> clock divider is in ADC) and added a pair of bus clock and\n> >reset.\n> >> > > >>\n> >> > > >> Update the binding document to cover H3.\n> >> > > >>\n> >> > > >> Signed-off-by: Icenowy Zheng \n> >> > > >> Reviewed-by: Chen-Yu Tsai \n> >> > > >> ---\n> >> > > >> Changes in v4:\n> >> > > >> - Add nvmem calibration data (not yet used by the driver)\n> >> > > >> Changes in v3:\n> >> > > >> - Clock name changes.\n> >> > > >> - Example node name changes.\n> >> > > >> - Add interupts (not yet used by the driver).\n> >> > > >>\n> >> > > >> .../devicetree/bindings/mfd/sun4i-gpadc.txt | 30\n> >> > > >++++++++++++++++++++--\n> >> > > >> 1 file changed, 28 insertions(+), 2 deletions(-)\n> >> > > >>\n> >> > > >> diff --git\n> >a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >> > > >b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >> > > >> index badff3611a98..6c470d584bf9 100644\n> >> > > >> --- a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >> > > >> +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt\n> >> > > >> @@ -4,12 +4,26 @@ The Allwinner SoCs all have an ADC that can\n> >also\n> >> > > >act as a thermal sensor\n> >> > > >> and sometimes as a touchscreen controller.\n> >> > > >>\n> >> > > >> Required properties:\n> >> > > >> - - compatible: \"allwinner,sun8i-a33-ths\",\n> >> > > >> + - compatible: must contain one of the following\n> >compatibles:\n> >> > > >> +\t\t- \"allwinner,sun8i-a33-ths\"\n> >> > > >> +\t\t- \"allwinner,sun8i-h3-ths\"\n> >> > > >> - reg: mmio address range of the chip,\n> >> > > >> - #thermal-sensor-cells: shall be 0,\n> >> > > >> - #io-channel-cells: shall be 0,\n> >> > > >>\n> >> > > >> -Example:\n> >> > > >> +Optional properties:\n> >> > > >> + - nvmem-cells: A phandle to the calibration data provided\n> >by a\n> >> > > >nvmem device.\n> >> > > >> + If unspecified default values shall be used.\n> >> > > >> + - nvmem-cell-names: Should be \"calibration-data\"\n> >> > > >\n> >> > > >I'd prefer to have which sensor it applies to here. It wouldn't\n> >change\n> >> > > >anything for the H3, but it definitely does for example for the\n> >A83t\n> >> > > >that has two sensors, one for each cluster, and one for the GPU,\n> >each\n> >> > > >with calibration data.\n> >> > > >\n> >> > > >What about cluster0-calibration?\n> >> \n> >> I prefer sensor0-calibration to sensor3-calibration now.\n> >> (Theortically the new generation THS can support up to 4 sensors)\n> >\n> >The mapping that explains what sensor0 means can change in the\n> >future. It's better to be explicit here, and just say upfront what\n> >it's about.\n> \n> I think for some SoC (e.g. A64) there's no clear explain on\n> the functions of the sensors.\n\nIt's documented in the user manual (\"sensor0 located in the CPU, sensor1 and\nsensor2 located in the GPU\"\n\n> In addition, in the THS controller the sensors has a explicit\n> sequence, and when referencing it in the DT the number is still\n> needed (in thermal zones).\n\nYes, but that's something that can be made easier through defines too.\n\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"AE/axRQ3\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xytKw1cNHz9tYF\n\tfor ;\n\tFri, 22 Sep 2017 09:36:33 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv7DK-0000y4-5v; Thu, 21 Sep 2017 19:32:46 +0000","from mail.free-electrons.com ([62.4.15.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dv7DE-0000tk-Uu for linux-arm-kernel@lists.infradead.org;\n\tThu, 21 Sep 2017 19:32:43 +0000","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 41C6620985; Thu, 21 Sep 2017 21:32:11 +0200 (CEST)","from localhost (LFbn-TOU-1-209-191.w86-201.abo.wanadoo.fr\n\t[86.201.56.191])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 114662092B;\n\tThu, 21 Sep 2017 21:32:11 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc:\n\tList-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:\n\tIn-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To:\n\tContent-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=jxPCIBEgoXjibUS1IHdOeq2rTB23Z/heSlhwJWaaai8=;\n\tb=AE/axRQ3fXqeaxdz7jaaX2U5Z\n\t9y8KV0S8ThiuHlf9VIb9ntgCzbdfcMii0t+MXtg0Q/e1yW5Hx0uJIeMmMXSsvr+OIrC5Pwh+8FkjY\n\tV+F62mbw2Kms5p04OCMWfp9UTWgM9AaRWrMjysl0XDuPow0ZcL/5bmlCMSHYnpbeAosV54Mhs9htG\n\tMilqBnX80Jyf5rKK0DHfr4onxpPMvVWtGVzkkbqnTpiCpZP8mhJrojXSiI5BZIq26GEj82OuUAjQS\n\t8GHKTBOoNg4SAE0VWwfgByCxM1XYhsobIVHmQoIOPdfGu8BsHlZMKOoqsF3WGA99oZsz9ZO+u3+xl\n\t3s7D7B8VQ==;","X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT\n\tshortcircuit=ham autolearn=disabled version=3.4.0","Date":"Thu, 21 Sep 2017 21:32:11 +0200","From":"Maxime Ripard ","To":"Icenowy Zheng ","Subject":"Re: [linux-sunxi] Re: [PATCH v4 1/6] dt-bindings: update the\n\tAllwinner GPADC device tree binding for H3","Message-ID":"<20170921193211.pjsikkez5by46mfh@flea>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-2-icenowy@aosc.io>\n\t<20170918073336.j7finend3g76chsu@flea.lan>\n\t<310CE549-B8CE-4C0C-95B1-B545E38BDAF5@aosc.io>\n\t<20170918083045.7bfiialtbm7w6i7j@flea.lan>\n\t\n\t<20170920075223.jaeswlhcqgu4yhse@flea.home>\n\t<27449039-F0D4-4663-B596-C95D4408D471@aosc.io>","MIME-Version":"1.0","In-Reply-To":"<27449039-F0D4-4663-B596-C95D4408D471@aosc.io>","User-Agent":"NeoMutt/20170914 (1.9.0)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170921_123241_301465_BA125D17 ","X-CRM114-Status":"GOOD ( 24.36 )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-1.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tlinux-arm-kernel@lists.infradead.org, Lee Jones ,\n\tJonathan Cameron ","Content-Type":"multipart/mixed;\n\tboundary=\"===============6180443770884912552==\"","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1774214,"web_url":"http://patchwork.ozlabs.org/comment/1774214/","msgid":"<20170924152304.02551715@archlinux>","list_archive_url":null,"date":"2017-09-24T14:23:04","subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","submitter":{"id":10151,"url":"http://patchwork.ozlabs.org/api/people/10151/","name":"Jonathan Cameron","email":"jic23@kernel.org"},"content":"On Mon, 18 Sep 2017 10:27:03 +0200\nMaxime Ripard wrote:\n\n> Hi Jonathan,\n> \n> On Sat, Sep 16, 2017 at 03:17:34PM -0700, Jonathan Cameron wrote:\n> > On Sat, 16 Sep 2017 12:05:49 +0200\n> > Quentin Schulz wrote:\n> > \n> > > Hi Icenowy,\n> > > \n> > > On 14/09/2017 16:52, Icenowy Zheng wrote: \n> > > > Because of the restriction of the OF thermal framework, the thermal\n> > > > sensor will fail to probe if the thermal zone doesn't exist.\n> > > > \n> > > \n> > > Oh no, that's not good.\n> > > \n> > > We discussed about it on IRC and I even proposed a patch for it, telling\n> > > you I would post it on the mailing list soon after. Of course, I forgot\n> > > and you definitely should have yelled at me for not doing it :)\n> > > \n> > > I won't be able to test the patch soon. I can send it to you so that you\n> > > can test it and integrate it in your patch series so it won't block you.\n> > > Otherwise, we'll have to wait for a week or two for me to test it.\n> > > \n> > > Thanks and sorry for forgetting to post the patch you need,\n> > > Quentin \n> > \n> > Other this outstanding issue I'm happy with the series, so hopefully\n> > with Quentin's patch added we should be good to merge this one. \n> \n> We will at least need a v5.\n> \n> Maxime\n> \nSure - I can see other issues are coming out of the woodwork!\n\nThanks,\n\nJonathan","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"GBO2LP0a\"; dkim-atps=neutral","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=jic23@kernel.org"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y0TwX463wz9sPk\n\tfor ;\n\tMon, 25 Sep 2017 00:23:40 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw7om-000823-KT; Sun, 24 Sep 2017 14:23:36 +0000","from mail.kernel.org ([198.145.29.99])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dw7of-0007tl-SM for linux-arm-kernel@lists.infradead.org;\n\tSun, 24 Sep 2017 14:23:31 +0000","from archlinux (cpc91196-cmbg18-2-0-cust659.5-4.cable.virginm.net\n\t[81.96.234.148])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 16BCB217C3;\n\tSun, 24 Sep 2017 14:23:06 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=7muxYxsUQlNwQWeEj1hPtnR6fMABOvpi+lxUtw1WCKg=;\n\tb=GBO2LP0a52k+zA\n\tIikdqIrpMY8WXl8qTwJvkV5ALKsOhDTmcqpguLorl0GLjadMw6BATqOzwErWjsyquhBJJSZ4KuPUn\n\tpj1RafG0SDX+20h4wwY7+sX9EN2RcwxMuq+MKFdynUb8xFes/clhKoaO3llI86A01lV/B5vgOMasX\n\t1Q1EFYb/Zy8m25iKNvf2+2zVmuIfJvsyfbnRNPMZLDDwj8BovfgFrUccUzlca1RodmCMP10MVgor1\n\tBmqOv6uMITQICSV0LgHogeQTaS8Ei5cPQAqdxRa/p6s0mARdATPW64w9q5d77rMSWzbgMIdtoEX8K\n\tvkEGXulfeiAX3vFyIFbg==;","DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 16BCB217C3","Date":"Sun, 24 Sep 2017 15:23:04 +0100","From":"Jonathan Cameron ","To":"Maxime Ripard ","Subject":"Re: [PATCH v4 6/6] ARM: sun8i: h3: add partial CPU thermal zone","Message-ID":"<20170924152304.02551715@archlinux>","In-Reply-To":"<20170918082703.riqntqilakzhirc5@flea.lan>","References":"<20170914145251.21784-1-icenowy@aosc.io>\n\t<20170914145251.21784-7-icenowy@aosc.io>\n\t\n\t<20170916151734.10968b7a@archlinux>\n\t<20170918082703.riqntqilakzhirc5@flea.lan>","X-Mailer":"Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu)","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170924_072330_047297_B3A07C1A ","X-CRM114-Status":"GOOD ( 20.86 )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-6.9 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [198.145.29.99 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, linux-iio@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org,\n\tQuentin Schulz ,\n\tChen-Yu Tsai , Rob Herring ,\n\tLee Jones , linux-arm-kernel@lists.infradead.org,\n\tIcenowy Zheng ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]