[{"id":1769127,"web_url":"http://patchwork.ozlabs.org/comment/1769127/","msgid":"","list_archive_url":null,"date":"2017-09-15T12:07:33","subject":"Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip\n\tplatform","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"Andy,\n\n> On 14 Sep 2017, at 10:51, Andy Yan wrote:\n> \n> \n> Most rockchip platform based boards use a key to instruct\n> the board enter download firmware mode, some boards use a\n> adc to detect the key status, and some use a gpio.\n\nI just sent out a series that updates the back-to-bootrom to be\nwritten entirely as C-code.\n\nI’d appreciate if you could review and also modify your changes\nto apply cleanly on top of that one (e.g. save_boot_params.S is\ngone, so you will be able to add your call to check for the download\nkey in bootrom.c).\n\nThe plan would be to apply first the “rewrite in C” changes and\nthen your “download mode” changes on-top.\nIf possible, I’d like to get this into next week’s changes and put a\nPR with both out by the end of next week…\n\nRegards,\nPhilipp.\n\n> \n> This series try to implement all the download mode related\n> functions.\n> \n> Changes in v2:\n> - correct the rk322x boot mode register address\n> - make the help text more clear\n> - implement the back to bootrom download mode check in c, thanks for Dr. Philipp Tomsich's suggestion.\n> - more document\n> - move adc key detect as the defaut\n> \n> Andy Yan (3):\n> rockchip: make boot_mode related codes reused across all platforms\n> rockchip: add support for enter to bootrom download mode\n> rockchip: check download key before bootup\n> \n> arch/arm/include/asm/arch-rockchip/boot_mode.h | 7 +++\n> arch/arm/include/asm/arch-rockchip/bootrom.h | 15 ++++-\n> arch/arm/mach-rockchip/Kconfig | 15 +++++\n> arch/arm/mach-rockchip/Makefile | 4 ++\n> arch/arm/mach-rockchip/boot_mode.c | 76 ++++++++++++++++++++++++++\n> arch/arm/mach-rockchip/bootrom.c | 31 ++++++++++-\n> arch/arm/mach-rockchip/rk3036-board.c | 24 --------\n> arch/arm/mach-rockchip/rk322x-board.c | 24 --------\n> arch/arm/mach-rockchip/rk3288-board.c | 25 ---------\n> arch/arm/mach-rockchip/rk3399-board.c | 14 +++++\n> arch/arm/mach-rockchip/save_boot_param.S | 25 ++++++---\n> 11 files changed, 177 insertions(+), 83 deletions(-)\n> create mode 100644 arch/arm/mach-rockchip/boot_mode.c\n> create mode 100644 arch/arm/mach-rockchip/rk3399-board.c\n> \n> -- \n> 2.7.4\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtvKw3f5Pz9s7C\n\tfor ;\n\tFri, 15 Sep 2017 22:07:48 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 239C5C21FA2; Fri, 15 Sep 2017 12:07:43 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 40FBFC21D5D;\n\tFri, 15 Sep 2017 12:07:41 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 62C6EC21D5D; Fri, 15 Sep 2017 12:07:40 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id 27E3BC21D04\n\tfor ; Fri, 15 Sep 2017 12:07:40 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:56586\n\thelo=[192.168.2.129]) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dspPC-0002N7-Bg; Fri, 15 Sep 2017 14:07:34 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"*","X-Spam-Status":"No, score=1.0 required=5.0 tests=HK_NAME_DR autolearn=no\n\tautolearn_force=no version=3.4.0","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","From":"\"Dr. Philipp Tomsich\" ","In-Reply-To":"<1505379066-5334-1-git-send-email-andy.yan@rock-chips.com>","Date":"Fri, 15 Sep 2017 14:07:33 +0200","Message-Id":"","References":"<1505379066-5334-1-git-send-email-andy.yan@rock-chips.com>","To":"Andy Yan ","X-Mailer":"Apple Mail (2.3273)","Cc":"u-boot@lists.denx.de, david.wu@rock-chips.com","Subject":"Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip\n\tplatform","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769182,"web_url":"http://patchwork.ozlabs.org/comment/1769182/","msgid":"","list_archive_url":null,"date":"2017-09-15T13:23:38","subject":"Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip\n\tplatform","submitter":{"id":71697,"url":"http://patchwork.ozlabs.org/api/people/71697/","name":"Andyshrk","email":"andyshrk@gmail.com"},"content":"Hi Philipp:\n\n2017-09-15 20:07 GMT+08:00 Dr. Philipp Tomsich <\nphilipp.tomsich@theobroma-systems.com>:\n\n> Andy,\n>\n> > On 14 Sep 2017, at 10:51, Andy Yan wrote:\n> >\n> >\n> > Most rockchip platform based boards use a key to instruct\n> > the board enter download firmware mode, some boards use a\n> > adc to detect the key status, and some use a gpio.\n>\n> I just sent out a series that updates the back-to-bootrom to be\n> written entirely as C-code.\n>\n> I’d appreciate if you could review and also modify your changes\n> to apply cleanly on top of that one (e.g. save_boot_params.S is\n> gone, so you will be able to add your call to check for the download\n> key in bootrom.c).\n>\n\n\nThanks very much for the excellent work, I just need a little time to\nunderstand - review and test your patch on more platforms.\nAnd I will send a new version on the top of your patch next Monday.\n\n\n\n>\n> The plan would be to apply first the “rewrite in C” changes and\n> then your “download mode” changes on-top.\n> If possible, I’d like to get this into next week’s changes and put a\n> PR with both out by the end of next week…\n>\n> Regards,\n> Philipp.\n>\n> >\n> > This series try to implement all the download mode related\n> > functions.\n> >\n> > Changes in v2:\n> > - correct the rk322x boot mode register address\n> > - make the help text more clear\n> > - implement the back to bootrom download mode check in c, thanks for Dr.\n> Philipp Tomsich's suggestion.\n> > - more document\n> > - move adc key detect as the defaut\n> >\n> > Andy Yan (3):\n> > rockchip: make boot_mode related codes reused across all platforms\n> > rockchip: add support for enter to bootrom download mode\n> > rockchip: check download key before bootup\n> >\n> > arch/arm/include/asm/arch-rockchip/boot_mode.h | 7 +++\n> > arch/arm/include/asm/arch-rockchip/bootrom.h | 15 ++++-\n> > arch/arm/mach-rockchip/Kconfig | 15 +++++\n> > arch/arm/mach-rockchip/Makefile | 4 ++\n> > arch/arm/mach-rockchip/boot_mode.c | 76\n> ++++++++++++++++++++++++++\n> > arch/arm/mach-rockchip/bootrom.c | 31 ++++++++++-\n> > arch/arm/mach-rockchip/rk3036-board.c | 24 --------\n> > arch/arm/mach-rockchip/rk322x-board.c | 24 --------\n> > arch/arm/mach-rockchip/rk3288-board.c | 25 ---------\n> > arch/arm/mach-rockchip/rk3399-board.c | 14 +++++\n> > arch/arm/mach-rockchip/save_boot_param.S | 25 ++++++---\n> > 11 files changed, 177 insertions(+), 83 deletions(-)\n> > create mode 100644 arch/arm/mach-rockchip/boot_mode.c\n> > create mode 100644 arch/arm/mach-rockchip/rk3399-board.c\n> >\n> > --\n> > 2.7.4\n> >\n> >\n>\n> _______________________________________________\n> U-Boot mailing list\n> U-Boot@lists.denx.de\n> https://lists.denx.de/listinfo/u-boot\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CxTQUJLL\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtx1n0Mv1z9sRm\n\tfor ;\n\tFri, 15 Sep 2017 23:23:56 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid BD688C21DA1; Fri, 15 Sep 2017 13:23:45 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 2FDD3C21DF7;\n\tFri, 15 Sep 2017 13:23:43 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 77E94C21DF7; Fri, 15 Sep 2017 13:23:41 +0000 (UTC)","from mail-io0-f196.google.com (mail-io0-f196.google.com\n\t[209.85.223.196])\n\tby lists.denx.de (Postfix) with ESMTPS id B2B63C21DA1\n\tfor ; Fri, 15 Sep 2017 13:23:40 +0000 (UTC)","by mail-io0-f196.google.com with SMTP id e9so3852825iod.5\n\tfor ; Fri, 15 Sep 2017 06:23:40 -0700 (PDT)","by 10.157.23.232 with HTTP; Fri, 15 Sep 2017 06:23:38 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=a8RBVsf7+iY5oFl+rimZBPQA1eJK1SVHZchkxUE4auQ=;\n\tb=CxTQUJLLy46AIztRlbVNQ6bTAj9vmufMOOOlCu39SXEjpc5qrUvqEFv/z0POTUl4zw\n\tnEQuphOmr0JMGmq/HN8fnMn48Wtw5uFRSLg9o6l+vrDKlb1xqVJS3xcyaVgzbpkERVvL\n\tLmBlmfadQUpsua6JdC37MAf85LN1tVI2GTFfPknUlsYrry+rGE0B8hH8hMrvpKsTdTm7\n\tB2TVYO9aXANDdnPwuBlVhxpguLrKf4sSJy1rjtDx0s/6cWMlXpBNEXFl7+I0moVcyhNG\n\tK+N4k/BEY5fSiNUaDmMcoAp0v8ymmmRkU2OQG918pzY2swI6LdKX6VyPq6Bhog6w36LW\n\trsvw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=a8RBVsf7+iY5oFl+rimZBPQA1eJK1SVHZchkxUE4auQ=;\n\tb=rSewhblyCT9AeQ8ebLh6GuOAi+7Uq9a8P87OiEJcNOQZsLPNjmzWnNLlAWv294tlC2\n\tm9PBlyxk9j/NkDtWXnw0WBE0kTDR93rwzmd3MJgSfa+3v6/yyO888TsyCf5T90ukG4ta\n\tDy4pbsOw+ZLFN9PxyqOs57yFrj917olFA8a/qPkiX/awAMjHwHTvKCPBM/5y91nnhDI9\n\t3YYFi/D3EeaYHTU+mfRbhWFfrZAMB/YiR+zjIA3GypW/6qijYNSD0qkhZ3ZhqRZ6c1VR\n\tMSiMkenboePUE7+EjbT4WQcgFs/iiCH9ngDWcKq1SFkDr4aowQGuhDWt7ay2Fc8Co2m9\n\tX4+A==","X-Gm-Message-State":"AHPjjUjWz5Ghd/jjd1sE1d5PVy7q9qbdKwXfuMEj1Ja2HBOrNWSnbJQ/\n\tAF/6QNIE1E7p06YsNe/A190/033N0pN+Qv72X+M=","X-Google-Smtp-Source":"AOwi7QAq8GYTjrU2CiXT0QcQWE6+M/AvYGTDEP4FNAYfnUaRkGG6DZ/hNVezcUDEgg4qbU2u8uKNfpKroie26OalLQA=","X-Received":"by 10.202.223.7 with SMTP id w7mr1583674oig.237.1505481819283;\n\tFri, 15 Sep 2017 06:23:39 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"","References":"<1505379066-5334-1-git-send-email-andy.yan@rock-chips.com>\n\t","From":"Andy Yan ","Date":"Fri, 15 Sep 2017 21:23:38 +0800","Message-ID":"","To":"\"Dr. Philipp Tomsich\" ","X-Content-Filtered-By":"Mailman/MimeDel 2.1.18","Cc":"Andy Yan , david.wu@rock-chips.com,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip\n\tplatform","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1769185,"web_url":"http://patchwork.ozlabs.org/comment/1769185/","msgid":"<5A7EFACC-E58D-4ADE-AED0-1298D82738EF@theobroma-systems.com>","list_archive_url":null,"date":"2017-09-15T13:26:18","subject":"Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip\n\tplatform","submitter":{"id":53488,"url":"http://patchwork.ozlabs.org/api/people/53488/","name":"Philipp Tomsich","email":"philipp.tomsich@theobroma-systems.com"},"content":"Andy,\n\n> On 15 Sep 2017, at 15:23, Andy Yan wrote:\n> \n> Hi Philipp:\n> \n> 2017-09-15 20:07 GMT+08:00 Dr. Philipp Tomsich >:\n> Andy,\n> \n> > On 14 Sep 2017, at 10:51, Andy Yan > wrote:\n> >\n> >\n> > Most rockchip platform based boards use a key to instruct\n> > the board enter download firmware mode, some boards use a\n> > adc to detect the key status, and some use a gpio.\n> \n> I just sent out a series that updates the back-to-bootrom to be\n> written entirely as C-code.\n> \n> I’d appreciate if you could review and also modify your changes\n> to apply cleanly on top of that one (e.g. save_boot_params.S is\n> gone, so you will be able to add your call to check for the download\n> key in bootrom.c).\n> \n> \n> Thanks very much for the excellent work, I just need a little time to understand - review and test your patch on more platforms.\n> And I will send a new version on the top of your patch next Monday.\n\nTake your time: I’d rather have this fully tested and merge it a week (or\neven a few weeks) later to allow for the testing.\n\nIf there’s a problem with my series, let me know and I’ll take another look. \n\n> \n> The plan would be to apply first the “rewrite in C” changes and\n> then your “download mode” changes on-top.\n> If possible, I’d like to get this into next week’s changes and put a\n> PR with both out by the end of next week…\n> \n> Regards,\n> Philipp.\n> \n> >\n> > This series try to implement all the download mode related\n> > functions.\n> >\n> > Changes in v2:\n> > - correct the rk322x boot mode register address\n> > - make the help text more clear\n> > - implement the back to bootrom download mode check in c, thanks for Dr. Philipp Tomsich's suggestion.\n> > - more document\n> > - move adc key detect as the defaut\n> >\n> > Andy Yan (3):\n> > rockchip: make boot_mode related codes reused across all platforms\n> > rockchip: add support for enter to bootrom download mode\n> > rockchip: check download key before bootup\n> >\n> > arch/arm/include/asm/arch-rockchip/boot_mode.h | 7 +++\n> > arch/arm/include/asm/arch-rockchip/bootrom.h | 15 ++++-\n> > arch/arm/mach-rockchip/Kconfig | 15 +++++\n> > arch/arm/mach-rockchip/Makefile | 4 ++\n> > arch/arm/mach-rockchip/boot_mode.c | 76 ++++++++++++++++++++++++++\n> > arch/arm/mach-rockchip/bootrom.c | 31 ++++++++++-\n> > arch/arm/mach-rockchip/rk3036-board.c | 24 --------\n> > arch/arm/mach-rockchip/rk322x-board.c | 24 --------\n> > arch/arm/mach-rockchip/rk3288-board.c | 25 ---------\n> > arch/arm/mach-rockchip/rk3399-board.c | 14 +++++\n> > arch/arm/mach-rockchip/save_boot_param.S | 25 ++++++---\n> > 11 files changed, 177 insertions(+), 83 deletions(-)\n> > create mode 100644 arch/arm/mach-rockchip/boot_mode.c\n> > create mode 100644 arch/arm/mach-rockchip/rk3399-board.c\n> >\n> > --\n> > 2.7.4\n> >\n> >\n> \n> _______________________________________________\n> U-Boot mailing list\n> U-Boot@lists.denx.de \n> https://lists.denx.de/listinfo/u-boot ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtx4m40K5z9sxR\n\tfor ;\n\tFri, 15 Sep 2017 23:26:32 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 55053C22024; Fri, 15 Sep 2017 13:26:25 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id ADCDFC21DF7;\n\tFri, 15 Sep 2017 13:26:22 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 18601C21DF7; Fri, 15 Sep 2017 13:26:22 +0000 (UTC)","from mail.theobroma-systems.com (vegas.theobroma-systems.com\n\t[144.76.126.164])\n\tby lists.denx.de (Postfix) with ESMTPS id D27F2C21DA1\n\tfor ; Fri, 15 Sep 2017 13:26:21 +0000 (UTC)","from 89-104-28-141.customer.bnet.at ([89.104.28.141]:58161\n\thelo=[192.168.2.129]) by mail.theobroma-systems.com with esmtpsa\n\t(TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80)\n\t(envelope-from )\n\tid 1dsqdP-0004wn-17; Fri, 15 Sep 2017 15:26:19 +0200"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"*","X-Spam-Status":"No, score=1.0 required=5.0 tests=HK_NAME_DR autolearn=no\n\tautolearn_force=no version=3.4.0","From":"\"Dr. Philipp Tomsich\" ","Message-Id":"<5A7EFACC-E58D-4ADE-AED0-1298D82738EF@theobroma-systems.com>","Mime-Version":"1.0 (Mac OS X Mail 10.3 \\(3273\\))","Date":"Fri, 15 Sep 2017 15:26:18 +0200","In-Reply-To":"","To":"Andy Yan ","References":"<1505379066-5334-1-git-send-email-andy.yan@rock-chips.com>\n\t\n\t","X-Mailer":"Apple Mail (2.3273)","X-Content-Filtered-By":"Mailman/MimeDel 2.1.18","Cc":"Andy Yan , david.wu@rock-chips.com,\n\tU-Boot Mailing List ","Subject":"Re: [U-Boot] [PATCH v2 0/3] support enter download mode on rockchip\n\tplatform","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]