[{"id":1768015,"web_url":"http://patchwork.ozlabs.org/comment/1768015/","msgid":"<20170913.093902.570914704132982694.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-13T16:39:02","subject":"Re: [PATCH net 0/3] nfp: wait more carefully for card init","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Jakub Kicinski \r\nDate: Wed, 13 Sep 2017 08:51:28 -0700\r\n\r\n> The first patch is a small fix for flower offload, we need a whitelist\r\n> of supported matches, otherwise the unsupported ones will be ignored.\r\n> \r\n> The second and the third patch are adding wait/polling to the probe path.\r\n> We had reports of driver failing probe because it couldn't find the \r\n> control process (NSP) on the card. Turns out the NSP will only announce\r\n> its existence after it's fully initialized. Until now we assumed it \r\n> will be reachable, just not processing commands (hence we wait for\r\n> a NOOP command to execute successfully).\r\n\r\nPlease build test your changes and look at what the compiler says:\r\n\r\ndrivers/net/ethernet/netronome/nfp/nfp_main.c: In function ‘nfp_fw_unload’:\r\ndrivers/net/ethernet/netronome/nfp/nfp_main.c:395:10: warning: ‘return’ with a value, in function returning void\r\n return err;\r\n ^~~\r\ndrivers/net/ethernet/netronome/nfp/nfp_main.c:388:13: note: declared here\r\n static void nfp_fw_unload(struct nfp_pf *pf)\r\n ^~~~~~~~~~~~~","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsnRt4bKNz9sNV\n\tfor ;\n\tThu, 14 Sep 2017 02:39:06 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751890AbdIMQjE (ORCPT );\n\tWed, 13 Sep 2017 12:39:04 -0400","from shards.monkeyblade.net ([184.105.139.130]:51842 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751117AbdIMQjD (ORCPT\n\t); Wed, 13 Sep 2017 12:39:03 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 3FA1013534D8A;\n\tWed, 13 Sep 2017 09:39:03 -0700 (PDT)"],"Date":"Wed, 13 Sep 2017 09:39:02 -0700 (PDT)","Message-Id":"<20170913.093902.570914704132982694.davem@davemloft.net>","To":"jakub.kicinski@netronome.com","Cc":"netdev@vger.kernel.org, oss-drivers@netronome.com","Subject":"Re: [PATCH net 0/3] nfp: wait more carefully for card init","From":"David Miller ","In-Reply-To":"<20170913155131.18090-1-jakub.kicinski@netronome.com>","References":"<20170913155131.18090-1-jakub.kicinski@netronome.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=iso-8859-7","Content-Transfer-Encoding":"base64","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Wed, 13 Sep 2017 09:39:03 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1768020,"web_url":"http://patchwork.ozlabs.org/comment/1768020/","msgid":"<20170913185308.7c64275e@cakuba.netronome.com>","list_archive_url":null,"date":"2017-09-13T16:53:08","subject":"Re: [PATCH net 0/3] nfp: wait more carefully for card init","submitter":{"id":67484,"url":"http://patchwork.ozlabs.org/api/people/67484/","name":"Jakub Kicinski","email":"jakub.kicinski@netronome.com"},"content":"On Wed, 13 Sep 2017 09:39:02 -0700 (PDT), David Miller wrote:\n> From: Jakub Kicinski \n> Date: Wed, 13 Sep 2017 08:51:28 -0700\n> \n> > The first patch is a small fix for flower offload, we need a whitelist\n> > of supported matches, otherwise the unsupported ones will be ignored.\n> > \n> > The second and the third patch are adding wait/polling to the probe path.\n> > We had reports of driver failing probe because it couldn't find the \n> > control process (NSP) on the card. Turns out the NSP will only announce\n> > its existence after it's fully initialized. Until now we assumed it \n> > will be reachable, just not processing commands (hence we wait for\n> > a NOOP command to execute successfully). \n> \n> Please build test your changes and look at what the compiler says:\n> \n> drivers/net/ethernet/netronome/nfp/nfp_main.c: In function ‘nfp_fw_unload’:\n> drivers/net/ethernet/netronome/nfp/nfp_main.c:395:10: warning: ‘return’ with a value, in function returning void\n> return err;\n> ^~~\n> drivers/net/ethernet/netronome/nfp/nfp_main.c:388:13: note: declared here\n> static void nfp_fw_unload(struct nfp_pf *pf)\n> ^~~~~~~~~~~~~\n\nSorry about that!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=netronome-com.20150623.gappssmtp.com\n\theader.i=@netronome-com.20150623.gappssmtp.com\n\theader.b=\"SKrTYDbe\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsnmL4Xqdz9sNr\n\tfor ;\n\tThu, 14 Sep 2017 02:53:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751413AbdIMQxU (ORCPT );\n\tWed, 13 Sep 2017 12:53:20 -0400","from mail-pg0-f49.google.com ([74.125.83.49]:46970 \"EHLO\n\tmail-pg0-f49.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751121AbdIMQxP (ORCPT\n\t); Wed, 13 Sep 2017 12:53:15 -0400","by mail-pg0-f49.google.com with SMTP id i130so1445970pgc.3\n\tfor ; Wed, 13 Sep 2017 09:53:15 -0700 (PDT)","from cakuba.netronome.com ([2a02:a312:c101:2600::23])\n\tby smtp.gmail.com with ESMTPSA id\n\ts186sm21446289pgb.89.2017.09.13.09.53.12\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 13 Sep 2017 09:53:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=netronome-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:organization:mime-version:content-transfer-encoding;\n\tbh=rtIyJmqNkHKyGrg9uUriUid8OyYb92NdSpKVR9efHOc=;\n\tb=SKrTYDbeXMjZRUXxNlHt6N4mj9/42Y6OnJ5YRDIRDHO/YoF/yKARSO/fslEPDmeVKb\n\tRG6oFOHdu4IG5PWsjzi4vySxyx2V8CnTsQKEYcH6gEpwHlGamM18CHhzukOMSk+NhIt7\n\tIjPrxsXHj5fMhngp8j+/oVu4H92GPYqYYPqpJpjUq0Jy3y+eg+mgw/5nRvDZ6tFWtrU7\n\tTqjUDEhWIs3/12mSa5/5cevah4Vz+E4YCs6k5jEU3i0WqyqwMU88twtkARCmZk+1kTtf\n\tpSUd/GrV6FNcjaKTcq+TaLMqPEdjQ/QCWNP2lPVQpVF3g7mvEeUjc6VirCHnz+LDkgKx\n\tvCmg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:organization:mime-version:content-transfer-encoding;\n\tbh=rtIyJmqNkHKyGrg9uUriUid8OyYb92NdSpKVR9efHOc=;\n\tb=eDoR7ILhUwe9agtUxnYeLffdmid8N+xEK1LhmfZvXGoC2/W3XA7qKzMICbOzO3xeVr\n\t1roHwP5yZLkzEH5T+2po4vjuuL+TEtAgo3BTDlSfsrsbjuLI278gEIlNAarpBvFbIdti\n\tYyIUjqeGPdmLWNS+F1VF5VLs97uNpiAHFtYtIEzU4zYEDDYnrpPtQq5esPSKlo5QDT3H\n\t131tuVKAnioFhh6nmJDCtVL/+L/OAZGxXeOb8Iu6Cb5fV5+tW5jIsNjv8Q9xGeimqaZN\n\tR8wztGTSiIWoVUlFP02daLWRQZ/I+WzFJS6pkzheATg1kOfoiOC77M7FfQ/ln6qhrsVj\n\t6NuQ==","X-Gm-Message-State":"AHPjjUiEOgtbxGDHCfLup1xCCuzEDnEQ7XJ7wCWB+C7l65sf1NBJ5otW\n\tD7ogd4WALeTwUQcZ","X-Google-Smtp-Source":"ADKCNb6OnUjJpjfre3LKv9HbGSdYuM1qcBgZhm7JadMhycJ3nz1kEKra+kBmh40Q1SaBtccXejo2xw==","X-Received":"by 10.84.136.34 with SMTP id 31mr21775003plk.174.1505321594773; \n\tWed, 13 Sep 2017 09:53:14 -0700 (PDT)","Date":"Wed, 13 Sep 2017 18:53:08 +0200","From":"Jakub Kicinski ","To":"David Miller ","Cc":"netdev@vger.kernel.org, oss-drivers@netronome.com","Subject":"Re: [PATCH net 0/3] nfp: wait more carefully for card init","Message-ID":"<20170913185308.7c64275e@cakuba.netronome.com>","In-Reply-To":"<20170913.093902.570914704132982694.davem@davemloft.net>","References":"<20170913155131.18090-1-jakub.kicinski@netronome.com>\n\t<20170913.093902.570914704132982694.davem@davemloft.net>","Organization":"Netronome Systems, Ltd.","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]