[{"id":1768025,"web_url":"http://patchwork.ozlabs.org/comment/1768025/","msgid":"<20170913185827.1f7790f2.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-13T16:58:27","subject":"Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug\n\tvia device_add","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 13 Sep 2017 15:23:55 +0200\nDavid Hildenbrand wrote:\n\n> The first patches are a bunch of cleanups. I decided to go the\n> extra mile and implement CPU hotplug via \"device_add\", as well as\n> \"query-hotpluggable-cpus\".\n> \n> On s390x, only complete cores can be plugged. CPU hot unplug is currently\n> not supported by the architecture.\n> \n> Support for hotplugging CPUs in random core-id order (last two patches)\n> is added. We once hat a KVM bug preventing this, but the stable patch\n> should now be included in relevant places - 152e9f65d66f (\"KVM: s390: fix\n> wrong lookup of VCPUs by array index\"). Current tooling will plug them in\n> sequential order anyway, so it should not hurt.\n\nThanks, applied.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsntr1l3xz9s9Y\n\tfor ;\n\tThu, 14 Sep 2017 02:59:00 +1000 (AEST)","from localhost ([::1]:43669 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsB06-0003Za-CJ\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 12:58:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50639)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsAzn-0003ZP-Sn\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:58:40 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsAzl-0002WI-CQ\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:58:39 -0400","from mx1.redhat.com ([209.132.183.28]:45052)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsAzl-0002UB-6P\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 12:58:37 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 1A782356D9;\n\tWed, 13 Sep 2017 16:58:36 +0000 (UTC)","from gondolin (ovpn-117-3.ams2.redhat.com [10.36.117.3])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 24AEC5C545;\n\tWed, 13 Sep 2017 16:58:29 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 1A782356D9","Date":"Wed, 13 Sep 2017 18:58:27 +0200","From":"Cornelia Huck ","To":"David Hildenbrand ","Message-ID":"<20170913185827.1f7790f2.cohuck@redhat.com>","In-Reply-To":"<20170913132417.24384-1-david@redhat.com>","References":"<20170913132417.24384-1-david@redhat.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 13 Sep 2017 16:58:36 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug\n\tvia device_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Igor Mammedov ,\n\tPaolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1779496,"web_url":"http://patchwork.ozlabs.org/comment/1779496/","msgid":"<20171004100535.3f8116e8.cohuck@redhat.com>","list_archive_url":null,"date":"2017-10-04T08:05:35","subject":"Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug\n\tvia device_add","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Mon, 02 Oct 2017 09:47:58 +0200\nMarkus Armbruster wrote:\n\n> Cornelia Huck writes:\n> \n> > On Wed, 13 Sep 2017 15:23:55 +0200\n> > David Hildenbrand wrote:\n> > \n> >> The first patches are a bunch of cleanups. I decided to go the\n> >> extra mile and implement CPU hotplug via \"device_add\", as well as\n> >> \"query-hotpluggable-cpus\".\n> >> \n> >> On s390x, only complete cores can be plugged. CPU hot unplug is currently\n> >> not supported by the architecture.\n> >> \n> >> Support for hotplugging CPUs in random core-id order (last two patches)\n> >> is added. We once hat a KVM bug preventing this, but the stable patch\n> >> should now be included in relevant places - 152e9f65d66f (\"KVM: s390: fix\n> >> wrong lookup of VCPUs by array index\"). Current tooling will plug them in\n> >> sequential order anyway, so it should not hurt. \n> >\n> > Thanks, applied. \n> \n> Please squash in the one-liner fix I asked for in my (late!) review of\n> PATCH 18.\n\nSadly, the review was a bit too late (already merged)...","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y6T4j612Zz9s5L\n\tfor ;\n\tWed, 4 Oct 2017 19:06:29 +1100 (AEDT)","from localhost ([::1]:33615 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dzehH-0002j9-Uv\n\tfor incoming@patchwork.ozlabs.org; Wed, 04 Oct 2017 04:06:27 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39441)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dzegg-0002eK-FJ\n\tfor qemu-devel@nongnu.org; Wed, 04 Oct 2017 04:05:56 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dzega-0004r6-U2\n\tfor qemu-devel@nongnu.org; Wed, 04 Oct 2017 04:05:50 -0400","from mx1.redhat.com ([209.132.183.28]:59300)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dzega-0004ox-Nr\n\tfor qemu-devel@nongnu.org; Wed, 04 Oct 2017 04:05:44 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C38277E380;\n\tWed, 4 Oct 2017 08:05:43 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0F01D5D9CB;\n\tWed, 4 Oct 2017 08:05:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C38277E380","Date":"Wed, 4 Oct 2017 10:05:35 +0200","From":"Cornelia Huck ","To":"Markus Armbruster ","Message-ID":"<20171004100535.3f8116e8.cohuck@redhat.com>","In-Reply-To":"<87fub2q9ch.fsf@dusky.pond.sub.org>","References":"<20170913132417.24384-1-david@redhat.com>\n\t<20170913185827.1f7790f2.cohuck@redhat.com>\n\t<87fub2q9ch.fsf@dusky.pond.sub.org>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 04 Oct 2017 08:05:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug\n\tvia device_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tDavid Hildenbrand ,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ,\n\tIgor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1791562,"web_url":"http://patchwork.ozlabs.org/comment/1791562/","msgid":"","list_archive_url":null,"date":"2017-10-20T15:45:21","subject":"Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug\n\tvia device_add","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 13.09.2017 15:23, David Hildenbrand wrote:\n> The first patches are a bunch of cleanups. I decided to go the\n> extra mile and implement CPU hotplug via \"device_add\", as well as\n> \"query-hotpluggable-cpus\".\n> \n> On s390x, only complete cores can be plugged. CPU hot unplug is currently\n> not supported by the architecture.\n> \n> Support for hotplugging CPUs in random core-id order (last two patches)\n> is added. We once hat a KVM bug preventing this, but the stable patch\n> should now be included in relevant places - 152e9f65d66f (\"KVM: s390: fix\n> wrong lookup of VCPUs by array index\"). Current tooling will plug them in\n> sequential order anyway, so it should not hurt.\n> \n\nJust played with libvirt. It seems to automatically use the new\ninterface. Works great for me (including migration).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yJVWV5vqdz9t41\n\tfor ;\n\tSat, 21 Oct 2017 02:45:58 +1100 (AEDT)","from localhost ([::1]:54573 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1e5ZUj-0004FC-0O\n\tfor incoming@patchwork.ozlabs.org; Fri, 20 Oct 2017 11:45:57 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41381)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1e5ZUP-0004Eq-8G\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 11:45:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1e5ZUO-00066d-H3\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 11:45:37 -0400","from mx1.redhat.com ([209.132.183.28]:34186)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1e5ZUO-00066G-AR\n\tfor qemu-devel@nongnu.org; Fri, 20 Oct 2017 11:45:36 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2642FC059720;\n\tFri, 20 Oct 2017 15:45:35 +0000 (UTC)","from [10.36.117.142] (ovpn-117-142.ams2.redhat.com [10.36.117.142])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BD8175C3FA;\n\tFri, 20 Oct 2017 15:45:22 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2642FC059720","To":"qemu-devel@nongnu.org","References":"<20170913132417.24384-1-david@redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"","Date":"Fri, 20 Oct 2017 17:45:21 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913132417.24384-1-david@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 20 Oct 2017 15:45:35 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug\n\tvia device_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost , cohuck@redhat.com,\n\tRichard Henderson ,\n\tAlexander Graf ,\n\tMarkus Armbruster , borntraeger@de.ibm.com,\n\tPaolo Bonzini , Igor Mammedov ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]