[{"id":1767806,"web_url":"http://patchwork.ozlabs.org/comment/1767806/","msgid":"<150530295678.330.17315684727719398484@6d89bd104fc3>","list_archive_url":null,"date":"2017-09-13T11:42:37","subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nSubject: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event instrumentation\nMessage-id: 150529642278.10902.18234057937634437857.stgit@frigg.lan\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n * [new tag] patchew/150529642278.10902.18234057937634437857.stgit@frigg.lan -> patchew/150529642278.10902.18234057937634437857.stgit@frigg.lan\nSwitched to a new branch 'test'\n8963b0695e instrument: Add API to manipulate guest memory\nd8552c1e16 instrument: Add event 'guest_user_syscall_ret'\n04bda8d5aa instrument: Add event 'guest_user_syscall'\n1d8370cd51 instrument: Add event 'guest_mem_before_exec'\ndf27827de9 instrument: Add event 'guest_mem_before_trans'\n4d144f90f0 trace: Introduce a proper structure to describe memory accesses\na4aa7e8863 instrument: Add event 'guest_cpu_reset'\n387ca2ea04 instrument: Add event 'guest_cpu_exit'\n5ae9ef5c01 exec: Add function to synchronously flush TB on a stopped vCPU\n13e99981c9 instrument: Support synchronous modification of vCPU state\n722663c82d instrument: Add event 'guest_cpu_enter'\n0dc9a4a367 instrument: Track vCPUs\nd86f598866 instrument: Add support for tracing events\nd4aa1cea7f instrument: Add basic control interface\n2d727bb6fb instrument: [hmp] Add library loader\n3eb4b46981 instrument: [qapi] Add library loader\n5641b387a2 instrument: [softmmu] Add command line library loader\nd94ac79e7f instrument: [bsd-user] Add command line library loader\n77c31d49ed instrument: [linux-user] Add command line library loader\nf47ccffa50 instrument: Add generic library loader\n3234817196 instrument: Add configure-time flag\n67a448c69e instrument: Add documentation\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/22: instrument: Add documentation...\nChecking PATCH 2/22: instrument: Add configure-time flag...\nChecking PATCH 3/22: instrument: Add generic library loader...\nChecking PATCH 4/22: instrument: [linux-user] Add command line library loader...\nChecking PATCH 5/22: instrument: [bsd-user] Add command line library loader...\nChecking PATCH 6/22: instrument: [softmmu] Add command line library loader...\nChecking PATCH 7/22: instrument: [qapi] Add library loader...\nERROR: externs should be avoided in .c files\n#250: FILE: stubs/instrument.c:36:\n+void qmp_instr_unload(const char *id, Error **errp);\n\ntotal: 1 errors, 0 warnings, 200 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 8/22: instrument: [hmp] Add library loader...\nChecking PATCH 9/22: instrument: Add basic control interface...\nWARNING: architecture specific defines should be avoided\n#52: FILE: include/qemu/compiler.h:119:\n+#if defined _WIN32 || defined __CYGWIN__\n\nWARNING: architecture specific defines should be avoided\n#53: FILE: include/qemu/compiler.h:120:\n+ #ifdef __GNUC__\n\nWARNING: architecture specific defines should be avoided\n#59: FILE: include/qemu/compiler.h:126:\n+ #if __GNUC__ >= 4\n\nWARNING: architecture specific defines should be avoided\n#343: FILE: instrument/qemu-instr/control.h:13:\n+#ifdef __cplusplus\n\nWARNING: architecture specific defines should be avoided\n#372: FILE: instrument/qemu-instr/control.h:42:\n+#ifdef __cplusplus\n\ntotal: 0 errors, 5 warnings, 309 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\nChecking PATCH 10/22: instrument: Add support for tracing events...\nWARNING: architecture specific defines should be avoided\n#77: FILE: instrument/qemu-instr/types.h:13:\n+#ifdef __cplusplus\n\nWARNING: architecture specific defines should be avoided\n#111: FILE: instrument/qemu-instr/types.h:47:\n+#ifdef __cplusplus\n\ntotal: 0 errors, 2 warnings, 225 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\nChecking PATCH 11/22: instrument: Track vCPUs...\nChecking PATCH 12/22: instrument: Add event 'guest_cpu_enter'...\nChecking PATCH 13/22: instrument: Support synchronous modification of vCPU state...\nChecking PATCH 14/22: exec: Add function to synchronously flush TB on a stopped vCPU...\nChecking PATCH 15/22: instrument: Add event 'guest_cpu_exit'...\nChecking PATCH 16/22: instrument: Add event 'guest_cpu_reset'...\nChecking PATCH 17/22: trace: Introduce a proper structure to describe memory accesses...\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#244: FILE: trace/mem.h:29:\n+ uint8_t size_shift : 2;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:VxW)\n#245: FILE: trace/mem.h:30:\n+ bool sign_extend: 1;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#246: FILE: trace/mem.h:31:\n+ uint8_t endianness : 1;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#247: FILE: trace/mem.h:32:\n+ bool store : 1;\n ^\n\ntotal: 4 errors, 0 warnings, 227 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 18/22: instrument: Add event 'guest_mem_before_trans'...\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#302: FILE: instrument/qemu-instr/types.h:64:\n+ uint8_t size_shift : 2;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:VxW)\n#303: FILE: instrument/qemu-instr/types.h:65:\n+ bool sign_extend: 1;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#304: FILE: instrument/qemu-instr/types.h:66:\n+ uint8_t endianness : 1;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#305: FILE: instrument/qemu-instr/types.h:67:\n+ bool store : 1;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#430: FILE: trace/control.h:37:\n+ uint8_t size_shift : 2;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:VxW)\n#431: FILE: trace/control.h:38:\n+ bool sign_extend: 1;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#432: FILE: trace/control.h:39:\n+ uint8_t endianness : 1;\n ^\n\nERROR: spaces prohibited around that ':' (ctx:WxW)\n#433: FILE: trace/control.h:40:\n+ bool store : 1;\n ^\n\ntotal: 8 errors, 0 warnings, 389 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 19/22: instrument: Add event 'guest_mem_before_exec'...\nERROR: externs should be avoided in .c files\n#339: FILE: stubs/instrument.c:59:\n+void helper_instr_guest_mem_before_exec(\n\ntotal: 1 errors, 0 warnings, 260 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 20/22: instrument: Add event 'guest_user_syscall'...\nChecking PATCH 21/22: instrument: Add event 'guest_user_syscall_ret'...\nChecking PATCH 22/22: instrument: Add API to manipulate guest memory...\nWARNING: architecture specific defines should be avoided\n#41: FILE: instrument/qemu-instr/state.h:13:\n+#ifdef __cplusplus\n\nWARNING: architecture specific defines should be avoided\n#128: FILE: instrument/qemu-instr/state.h:100:\n+#ifdef __cplusplus\n\ntotal: 0 errors, 2 warnings, 181 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsfv16Xtxz9sNw\n\tfor ;\n\tWed, 13 Sep 2017 21:43:41 +1000 (AEST)","from localhost ([::1]:41726 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1ds64x-0002Mw-KB\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 07:43:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38434)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1ds64K-0002K4-Kg\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:43:02 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1ds64G-0007Hj-8R\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:43:00 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21377)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1ds64G-0007H6-0z\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 07:42:56 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1505302957313544.0999036871766;\n\tWed, 13 Sep 2017 04:42:37 -0700 (PDT)"],"Resent-Date":"Wed, 13 Sep 2017 07:43:00 -0400","Resent-Message-Id":"","In-Reply-To":"<150529642278.10902.18234057937634437857.stgit@frigg.lan>","Message-ID":"<150530295678.330.17315684727719398484@6d89bd104fc3>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"vilanova@ac.upc.edu","Date":"Wed, 13 Sep 2017 04:42:37 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"cota@braap.org, famz@redhat.com, qemu-devel@nongnu.org,\n\tstefanha@redhat.com, armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774832,"web_url":"http://patchwork.ozlabs.org/comment/1774832/","msgid":"<20170922224855.GA6905@flamenco>","list_archive_url":null,"date":"2017-09-22T22:48:55","subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","submitter":{"id":65690,"url":"http://patchwork.ozlabs.org/api/people/65690/","name":"Emilio Cota","email":"cota@braap.org"},"content":"On Wed, Sep 13, 2017 at 12:53:43 +0300, Lluís Vilanova wrote:\n> The instrumentation code is dynamically loaded as a library into QEMU either\n> when it starts or later using its remote control interfaces. The loaded code\n> only has access to function explicitly exported through the QI_VPUBLIC macro.\n> \n> This series is branch 'devel-instrument' in\n> https://code.gso.ac.upc.edu/git/qemu-dbi.\n\nIs this up to date? That tree doesn't build for me with --enable-instrument; I\nget the same error I got in v4:\n\n CC x86_64-linux-user/instrument/state.o\n/data/src/qemu2/instrument/trace.c:13:30: fatal error: qemu-instr/trace.h: No such file or directory\ncompilation terminated.\n/data/src/qemu2/rules.mak:66: recipe for target 'instrument/trace.o' failed\n\nOr maybe I'm doing something wrong?\nI'm configuring with `configure --target-list=x86_64-linux-user --enable-instrument'.\n\nThanks,\n\n\t\tEmilio","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=braap.org header.i=@braap.org\n\theader.b=\"IfVJ+edA\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"JxpfBc2d\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y18QS0hwKz9t3t\n\tfor ;\n\tTue, 26 Sep 2017 02:18:24 +1000 (AEST)","from localhost ([::1]:43364 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwW5O-0003fe-3U\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 12:18:22 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51542)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwW4t-0003fJ-95\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 12:17:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwW4r-0006yR-6v\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 12:17:51 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:45199)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwW4r-0006yF-2E\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 12:17:49 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id C262621C81;\n\tMon, 25 Sep 2017 12:17:48 -0400 (EDT)","from frontend1 ([10.202.2.160])\n\tby compute4.internal (MEProxy); Mon, 25 Sep 2017 12:17:48 -0400","from localhost (flamenco.cs.columbia.edu [128.59.20.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 8256D7F93A;\n\tMon, 25 Sep 2017 12:17:48 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=cc\n\t:content-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=4HybwaQ8MZ0y3rj\n\thK44IqkYGrJCLfNaGnWC52XhuQxs=; b=IfVJ+edAzgKZ7stN3f3oXNVjIAMS7XA\n\tRfZFkBdpPuqNipXgH2IgyR8QvBJnNZivj4iwhgHPLPrFrDg/HIabRbl0QjE5Adhx\n\tcQpvGAlHpENAno3p4rz3lJqDvLUdh403lxUqNCXOCS/QT6nHai3Iku+LyFKCztTP\n\tScyGsTYIyRC0=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=\n\tfm1; bh=4HybwaQ8MZ0y3rjhK44IqkYGrJCLfNaGnWC52XhuQxs=; b=JxpfBc2d\n\trD6iDv8URsf68DF06TT5trbQsMipeWXQuftddQIpYppD2X+3eB4BpK1TT5UOozE4\n\tIxDx2iXHEi6k/MCtTTd1gBCFxEyEC2Q23EZ0Lyhr+Zy+v1J1nP7BQuk9xqjaqmTs\n\tL09D4z6phfw/p4DSNugqqCKR7nktUEs+o1vJrINl5W/Q+EIMwbADoOU1tn5NyRCa\n\tpVATQ5Ked3k4R5Mze7lVXbl7750jw7sajWT/bjm2JC2mlO6zvDOs9g+So4NZw0kM\n\t4kFhAN+hT3KqR1AZKTQCLz9iLOo0weZH9xP+6tO8Z64yKVuuS2vX2/fWMp3Cl11f\n\tDHEyOA6vo9Cx2A=="],"X-ME-Sender":"","X-Sasl-enc":"/Jzi99fGUTIb9g2PPtjBxs5w4DwLZaNuiEDqsYF0RBPc 1506356268","Date":"Fri, 22 Sep 2017 18:48:55 -0400","From":"\"Emilio G. Cota\" ","To":"=?iso-8859-1?q?Llu=EDs?= Vilanova ","Message-ID":"<20170922224855.GA6905@flamenco>","References":"<150529642278.10902.18234057937634437857.stgit@frigg.lan>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<150529642278.10902.18234057937634437857.stgit@frigg.lan>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n\tMarkus Armbruster ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774899,"web_url":"http://patchwork.ozlabs.org/comment/1774899/","msgid":"<87fubawt1q.fsf@frigg.lan>","list_archive_url":null,"date":"2017-09-25T18:07:45","subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Emilio G Cota writes:\n\n> On Wed, Sep 13, 2017 at 12:53:43 +0300, Lluís Vilanova wrote:\n>> The instrumentation code is dynamically loaded as a library into QEMU either\n>> when it starts or later using its remote control interfaces. The loaded code\n>> only has access to function explicitly exported through the QI_VPUBLIC macro.\n>> \n>> This series is branch 'devel-instrument' in\n>> https://code.gso.ac.upc.edu/git/qemu-dbi.\n\n> Is this up to date? That tree doesn't build for me with --enable-instrument; I\n> get the same error I got in v4:\n\n> CC x86_64-linux-user/instrument/state.o\n> /data/src/qemu2/instrument/trace.c:13:30: fatal error: qemu-instr/trace.h: No such file or directory\n> compilation terminated.\n> /data/src/qemu2/rules.mak:66: recipe for target 'instrument/trace.o' failed\n\n> Or maybe I'm doing something wrong?\n> I'm configuring with `configure --target-list=x86_64-linux-user --enable-instrument'.\n\nYou're doing it right, and I've checked that the branch is properly pushed. Can\nyou compile with V=1 to show me the failing cmdline?\n\nThanks,\n Lluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1BsK2Gsdz9t6N\n\tfor ;\n\tTue, 26 Sep 2017 04:08:20 +1000 (AEST)","from localhost ([::1]:43707 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwXnl-0006ua-7T\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 14:08:17 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47802)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwXnS-0006uU-K0\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 14:07:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwXnP-0004Be-Dx\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 14:07:58 -0400","from roura.ac.upc.es ([147.83.33.10]:50372)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwXnP-0004An-26\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 14:07:55 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8PI7pFh024324;\n\tMon, 25 Sep 2017 20:07:51 +0200","from localhost (unknown [132.68.50.201])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id 056D3354;\n\tMon, 25 Sep 2017 20:07:45 +0200 (CEST)"],"From":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ","To":"\"Emilio G. Cota\" ","References":"<150529642278.10902.18234057937634437857.stgit@frigg.lan>\n\t<20170922224855.GA6905@flamenco>","Mail-Followup-To":"\"Emilio G. Cota\" , qemu-devel@nongnu.org, \n\tStefan Hajnoczi , Markus Armbruster\n\t","Date":"Mon, 25 Sep 2017 21:07:45 +0300","In-Reply-To":"<20170922224855.GA6905@flamenco> (Emilio G. Cota's message of\n\t\"Fri, 22 Sep 2017 18:48:55 -0400\")","Message-ID":"<87fubawt1q.fsf@frigg.lan>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n\tMarkus Armbruster ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1774929,"web_url":"http://patchwork.ozlabs.org/comment/1774929/","msgid":"<20170925185507.GA11022@flamenco>","list_archive_url":null,"date":"2017-09-25T18:55:07","subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","submitter":{"id":65690,"url":"http://patchwork.ozlabs.org/api/people/65690/","name":"Emilio Cota","email":"cota@braap.org"},"content":"On Mon, Sep 25, 2017 at 21:07:45 +0300, Lluís Vilanova wrote:\n> You're doing it right, and I've checked that the branch is properly pushed. Can\n> you compile with V=1 to show me the failing cmdline?\n\n$ make V=1\n(cd /data/src/qemu2; printf '#define QEMU_PKGVERSION '; if test -n \"\"; then printf '\"\"\\n'; else if test -d .git; then printf '\" ('; git describe --match 'v*' 2>/dev/null | tr -d '\\n'; if ! git diff-index --quiet HEAD &>/dev/null; then printf -- '-dirty'; fi; printf ')\"\\n'; else printf '\"\"\\n'; fi; fi) > qemu-version.h.tmp\nif ! cmp -s qemu-version.h qemu-version.h.tmp; then mv qemu-version.h.tmp qemu-version.h; else rm qemu-version.h.tmp; fi\nmake -I/data/src/qemu2/dtc VPATH=/data/src/qemu2/dtc -C dtc V=\"1\" LIBFDT_srcdir=/data/src/qemu2/dtc/libfdt CPPFLAGS=\"-I/data/src/qemu2/build/dtc -I/data/src/qemu2/dtc -I/data/src/qemu2/dtc/libfdt\" CFLAGS=\"-O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g -fvisibility=hidden -I/usr/include/pixman-1 -I/data/src/qemu2/dtc/libfdt -Werror -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/libpng12 -I/data/src/qemu2/tests\" LDFLAGS=\"-rdynamic -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g \" ARFLAGS=\"rv\" CC=\"cc\" AR=\"ar\" LD=\"ld\" BUILD_DIR=/data/src/qemu2/build libfdt/libfdt.a\nmake[1]: Entering directory '/data/src/qemu2/build/dtc'\nmake[1]: 'libfdt/libfdt.a' is up to date.\nmake[1]: Leaving directory '/data/src/qemu2/build/dtc'\nmake BUILD_DIR=/data/src/qemu2/build -C x86_64-linux-user V=\"1\" TARGET_DIR=\"x86_64-linux-user/\" all\nmake[1]: Entering directory '/data/src/qemu2/build/x86_64-linux-user'\ncc -I/data/src/qemu2/build/. -I. -I/data/src/qemu2/tcg -I/data/src/qemu2/tcg/i386 -I/data/src/qemu2/instrument -I/data/src/qemu2/linux-headers -I/data/src/qemu2/build/linux-headers -I. -I/data/src/qemu2 -I/data/src/qemu2/accel/tcg -I/data/src/qemu2/include -fvisibility=hidden -I/usr/include/pixman-1 -I/data/src/qemu2/dtc/libfdt -Werror -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/libpng12 -I../linux-headers -I.. -I/data/src/qemu2/target/i386 -DNEED_CPU_H -I/data/src/qemu2/include -I/data/src/qemu2/linux-user/x86_64 -I/data/src/qemu2/linux-user/host/x86_64 -I/data/src/qemu2/linux-user -MMD -MP -MT gdbstub-xml.o -MF ./gdbstub-xml.d -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g -DQEMU_TARGET_BUILD=1 -c -o gdbstub-xml.o gdbstub-xml.c\ncc -I/data/src/qemu2/build/instrument -Iinstrument -I/data/src/qemu2/tcg -I/data/src/qemu2/tcg/i386 -I/data/src/qemu2/instrument -I/data/src/qemu2/linux-headers -I/data/src/qemu2/build/linux-headers -I. -I/data/src/qemu2 -I/data/src/qemu2/accel/tcg -I/data/src/qemu2/include -fvisibility=hidden -I/usr/include/pixman-1 -I/data/src/qemu2/dtc/libfdt -Werror -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/include/libpng12 -I../linux-headers -I.. -I/data/src/qemu2/target/i386 -DNEED_CPU_H -I/data/src/qemu2/include -I/data/src/qemu2/linux-user/x86_64 -I/data/src/qemu2/linux-user/host/x86_64 -I/data/src/qemu2/linux-user -MMD -MP -MT instrument/trace.o -MF instrument/trace.d -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g -DQEMU_TARGET_BUILD=1 -c -o instrument/trace.o /data/src/qemu2/instrument/trace.c\n/data/src/qemu2/instrument/trace.c:13:30: fatal error: qemu-instr/trace.h: No such file or directory\ncompilation terminated.\n/data/src/qemu2/rules.mak:66: recipe for target 'instrument/trace.o' failed\nmake[1]: *** [instrument/trace.o] Error 1\nmake[1]: Leaving directory '/data/src/qemu2/build/x86_64-linux-user'\nMakefile:326: recipe for target 'subdir-x86_64-linux-user' failed\nmake: *** [subdir-x86_64-linux-user] Error 2\n\nThanks,\n\n\t\tEmilio","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=braap.org header.i=@braap.org\n\theader.b=\"ehk4bmqV\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"Ls3W3yss\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1Cvx01T5z9sNr\n\tfor ;\n\tTue, 26 Sep 2017 04:55:37 +1000 (AEST)","from localhost ([::1]:43855 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwYXU-0004UU-8y\n\tfor incoming@patchwork.ozlabs.org; Mon, 25 Sep 2017 14:55:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34338)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwYXA-0004Sq-6S\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 14:55:13 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwYX7-0000Qg-1J\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 14:55:12 -0400","from out1-smtp.messagingengine.com ([66.111.4.25]:42087)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dwYX6-0000Pt-Rk\n\tfor qemu-devel@nongnu.org; Mon, 25 Sep 2017 14:55:08 -0400","from compute4.internal (compute4.nyi.internal [10.202.2.44])\n\tby mailout.nyi.internal (Postfix) with ESMTP id 5650A21E06;\n\tMon, 25 Sep 2017 14:55:08 -0400 (EDT)","from frontend2 ([10.202.2.161])\n\tby compute4.internal (MEProxy); Mon, 25 Sep 2017 14:55:08 -0400","from localhost (flamenco.cs.columbia.edu [128.59.20.216])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id F23742489B;\n\tMon, 25 Sep 2017 14:55:07 -0400 (EDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=braap.org; h=\n\tcontent-transfer-encoding:content-type:date:from:in-reply-to\n\t:message-id:mime-version:references:subject:to:x-me-sender\n\t:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=e+GktxvEhbh7Emj\n\tYMEhYTO9thRvIcTlvUBc/vAfTZY8=; b=ehk4bmqV8irjL00Z7rmGcbuGMOfJw8Q\n\tf/2TDHoq2lQIflqRhT9G82l3WGdiSqfTNWbGkT9DhLn0X6vrlF4gBacaCDWH7Svr\n\tyHJXWVrMpvVsF8sU96KyLGIzJymK/BSnWNsVgJ4IYmKYZ2qJgiqmPxazTvdoaZZU\n\tgfB5PU1v7AmA=","v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=content-transfer-encoding:content-type\n\t:date:from:in-reply-to:message-id:mime-version:references\n\t:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=\n\tfm1; bh=e+GktxvEhbh7EmjYMEhYTO9thRvIcTlvUBc/vAfTZY8=; b=Ls3W3yss\n\tjOJ2mlJ4d0wyqThcmDCZ96iDEdY0UuEQYE86rqd8HL2RpyzRW07OvqQ3lCpWGpMx\n\t6Wck+BLfnuxG+L/LazHcEGb33SMRdyahDf+XQbdHh41ChUCLe9eS6yLONn72mZ7b\n\tXaDm1NVzHVjLW+etl/iHHjBc9Nzu/kNPfZ43poExTZ+APnbncY8N0IuStABl25y3\n\tBMDMKsXq5BG5j6Mj1KIG2TcVWU10wlQhfbCmipBdReIENlKGIFrMhfyDK08B2Wbk\n\tghAa2nBMYKLhUp5u8CQF/ZR35o7vRrNc04damlaegcHWU3dqRkFNhsqK84IR0q/w\n\tw4O2jQSQ0/E5oA=="],"X-ME-Sender":"","X-Sasl-enc":"lL4mOVSaV/Nr/Jk8PNb/GA6Tne9pWQWJ3di4kwyXkApC 1506365707","Date":"Mon, 25 Sep 2017 14:55:07 -0400","From":"\"Emilio G. Cota\" ","To":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n\tMarkus Armbruster ","Message-ID":"<20170925185507.GA11022@flamenco>","References":"<150529642278.10902.18234057937634437857.stgit@frigg.lan>\n\t<20170922224855.GA6905@flamenco> <87fubawt1q.fsf@frigg.lan>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<87fubawt1q.fsf@frigg.lan>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"66.111.4.25","Subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1775238,"web_url":"http://patchwork.ozlabs.org/comment/1775238/","msgid":"<87ing5vpox.fsf@frigg.lan>","list_archive_url":null,"date":"2017-09-26T08:17:50","subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","submitter":{"id":9099,"url":"http://patchwork.ozlabs.org/api/people/9099/","name":"Lluís Vilanova","email":"vilanova@ac.upc.edu"},"content":"Emilio G Cota writes:\n\n> On Mon, Sep 25, 2017 at 21:07:45 +0300, Lluís Vilanova wrote:\n>> You're doing it right, and I've checked that the branch is properly pushed. Can\n>> you compile with V=1 to show me the failing cmdline?\n\n> $ make V=1\n> (cd /data/src/qemu2; printf '#define QEMU_PKGVERSION '; if test -n \"\"; then\n> printf '\"\"\\n'; else if test -d .git; then printf '\" ('; git describe --match\n> 'v*' 2>/dev/null | tr -d '\\n'; if ! git diff-index --quiet HEAD &>/dev/null;\n> then printf -- '-dirty'; fi; printf ')\"\\n'; else printf '\"\"\\n'; fi; fi) >\n> qemu-version.h.tmp\n> if ! cmp -s qemu-version.h qemu-version.h.tmp; then mv qemu-version.h.tmp qemu-version.h; else rm qemu-version.h.tmp; fi\n> make -I/data/src/qemu2/dtc VPATH=/data/src/qemu2/dtc -C dtc V=\"1\"\n> LIBFDT_srcdir=/data/src/qemu2/dtc/libfdt CPPFLAGS=\"-I/data/src/qemu2/build/dtc\n> -I/data/src/qemu2/dtc -I/data/src/qemu2/dtc/libfdt\" CFLAGS=\"-O2\n> -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -g -fvisibility=hidden\n> -I/usr/include/pixman-1 -I/data/src/qemu2/dtc/libfdt -Werror -pthread\n> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -fPIE -DPIE\n> -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE\n> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings\n> -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels\n> -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security\n> -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration\n> -Wold-style-definition -Wtype-limits -fstack-protector-strong\n> -I/usr/include/libpng12 -I/data/src/qemu2/tests\" LDFLAGS=\"-rdynamic\n> -Wl,--warn-common -Wl,-z,relro -Wl,-z,now -pie -m64 -g \" ARFLAGS=\"rv\" CC=\"cc\"\n> AR=\"ar\" LD=\"ld\" BUILD_DIR=/data/src/qemu2/build libfdt/libfdt.a\n> make[1]: Entering directory '/data/src/qemu2/build/dtc'\n> make[1]: 'libfdt/libfdt.a' is up to date.\n> make[1]: Leaving directory '/data/src/qemu2/build/dtc'\n> make BUILD_DIR=/data/src/qemu2/build -C x86_64-linux-user V=\"1\" TARGET_DIR=\"x86_64-linux-user/\" all\n> make[1]: Entering directory '/data/src/qemu2/build/x86_64-linux-user'\n> cc -I/data/src/qemu2/build/. -I. -I/data/src/qemu2/tcg\n> -I/data/src/qemu2/tcg/i386 -I/data/src/qemu2/instrument\n> -I/data/src/qemu2/linux-headers -I/data/src/qemu2/build/linux-headers\n> -I. -I/data/src/qemu2 -I/data/src/qemu2/accel/tcg -I/data/src/qemu2/include\n> -fvisibility=hidden -I/usr/include/pixman-1 -I/data/src/qemu2/dtc/libfdt -Werror\n> -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include\n> -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE\n> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings\n> -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels\n> -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security\n> -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration\n> -Wold-style-definition -Wtype-limits -fstack-protector-strong\n> -I/usr/include/libpng12 -I../linux-headers -I.. -I/data/src/qemu2/target/i386\n> -DNEED_CPU_H -I/data/src/qemu2/include -I/data/src/qemu2/linux-user/x86_64\n> -I/data/src/qemu2/linux-user/host/x86_64 -I/data/src/qemu2/linux-user -MMD -MP\n> -MT gdbstub-xml.o -MF ./gdbstub-xml.d -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2\n> -g -DQEMU_TARGET_BUILD=1 -c -o gdbstub-xml.o gdbstub-xml.c\n> cc -I/data/src/qemu2/build/instrument -Iinstrument -I/data/src/qemu2/tcg\n> -I/data/src/qemu2/tcg/i386 -I/data/src/qemu2/instrument\n> -I/data/src/qemu2/linux-headers -I/data/src/qemu2/build/linux-headers\n> -I. -I/data/src/qemu2 -I/data/src/qemu2/accel/tcg -I/data/src/qemu2/include\n> -fvisibility=hidden -I/usr/include/pixman-1 -I/data/src/qemu2/dtc/libfdt -Werror\n> -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include\n> -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE\n> -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings\n> -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -Wendif-labels\n> -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security\n> -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-declaration\n> -Wold-style-definition -Wtype-limits -fstack-protector-strong\n> -I/usr/include/libpng12 -I../linux-headers -I.. -I/data/src/qemu2/target/i386\n> -DNEED_CPU_H -I/data/src/qemu2/include -I/data/src/qemu2/linux-user/x86_64\n> -I/data/src/qemu2/linux-user/host/x86_64 -I/data/src/qemu2/linux-user -MMD -MP\n> -MT instrument/trace.o -MF instrument/trace.d -O2 -U_FORTIFY_SOURCE\n> -D_FORTIFY_SOURCE=2 -g -DQEMU_TARGET_BUILD=1 -c -o instrument/trace.o\n> /data/src/qemu2/instrument/trace.c\n> /data/src/qemu2/instrument/trace.c:13:30: fatal error: qemu-instr/trace.h: No such file or directory\n> compilation terminated.\n> /data/src/qemu2/rules.mak:66: recipe for target 'instrument/trace.o' failed\n> make[1]: *** [instrument/trace.o] Error 1\n> make[1]: Leaving directory '/data/src/qemu2/build/x86_64-linux-user'\n> Makefile:326: recipe for target 'subdir-x86_64-linux-user' failed\n> make: *** [subdir-x86_64-linux-user] Error 2\n\nThe includes look fine to me... (there's \"-I/data/src/qemu2/instrument\"). Can\nyou paste the result of \"find /data/src/qemu2/instrument\"? You should have a\n\"/data/src/qemu2/instrument/qemu-instr/trace.h\" file there.\n\nIn any case, I was planning to drop the tracing API for the next series.\n\n\nThanks,\n Lluis","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1YkT66ghz9sBd\n\tfor ;\n\tTue, 26 Sep 2017 18:18:40 +1000 (AEST)","from localhost ([::1]:46128 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dwl4f-0003hd-Rr\n\tfor incoming@patchwork.ozlabs.org; Tue, 26 Sep 2017 04:18:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:39022)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwl4F-0003hL-0i\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 04:18:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dwl4A-0008Qf-1B\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 04:18:10 -0400","from roura.ac.upc.edu ([147.83.33.10]:39947 helo=roura.ac.upc.es)\n\tby eggs.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dwl49-0008QH-Hy\n\tfor qemu-devel@nongnu.org; Tue, 26 Sep 2017 04:18:05 -0400","from correu-2.ac.upc.es (correu-2.ac.upc.es [147.83.30.92])\n\tby roura.ac.upc.es (8.13.8/8.13.8) with ESMTP id v8Q8Hwkr008931;\n\tTue, 26 Sep 2017 10:17:58 +0200","from localhost (unknown [31.210.187.58])\n\tby correu-2.ac.upc.es (Postfix) with ESMTPSA id 9068B219;\n\tTue, 26 Sep 2017 10:17:52 +0200 (CEST)"],"From":"=?utf-8?q?Llu=C3=ADs_Vilanova?= ","To":"\"Emilio G. Cota\" ","References":"<150529642278.10902.18234057937634437857.stgit@frigg.lan>\n\t<20170922224855.GA6905@flamenco> <87fubawt1q.fsf@frigg.lan>\n\t<20170925185507.GA11022@flamenco>","Mail-Followup-To":"\"Emilio G. Cota\" , qemu-devel@nongnu.org, \n\tStefan Hajnoczi , Markus Armbruster\n\t","Date":"Tue, 26 Sep 2017 11:17:50 +0300","In-Reply-To":"<20170925185507.GA11022@flamenco> (Emilio G. Cota's message of\n\t\"Mon, 25 Sep 2017 14:55:07 -0400\")","Message-ID":"<87ing5vpox.fsf@frigg.lan>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy]","X-Received-From":"147.83.33.10","Subject":"Re: [Qemu-devel] [PATCH v6 00/22] instrument: Add basic event\n\tinstrumentation","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, Stefan Hajnoczi ,\n\tMarkus Armbruster ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]