[{"id":1767739,"web_url":"http://patchwork.ozlabs.org/comment/1767739/","msgid":"<f7707221-5365-8074-7a83-ac108059aecc@redhat.com>","list_archive_url":null,"date":"2017-09-13T09:53:16","subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 11:36, Peter Xu wrote:\n> It starts from a \"make check\" failure on one of my private tree. The\n> problem is that when we do \"device_del\" we normally looking for two\n> things: one response (which is mostly empty), and a REMOVE event.  The\n> tricky point is the event can either be there before/after the empty\n> response.  So I added qmp_device_del() to make sure the order does not\n> matter, then use it where proper.\n> \n> Since I'm at it, I also added the sister helper qmp_device_add(), it\n> helps to remove LOCs.\n\nI've had a similar idea a couple of weeks ago, see here:\n\nhttp://patchwork.ozlabs.org/patch/801487/\n\n> I still don't 100% sure why my private tree can trigger this error,\n> while the master cannot. Anyway, I think this is something we should\n> have, no matter what.\n\nDid you maybe touch the USB tests in your private tree?\nAs far as I know, some test currently use QMP in a bad way, for example\nusb_test_hotplug() only checks for the DEVICE_DELETED at the end, but\nforgets to read back the final return value. That return value is then\npresented to the next part of the code that uses QMP instead ... it\ncurrently only works more or less by accident, but as soon as you try to\nadd new code inbetween, it certainly will fail.\n==> We really got to clean this up (either with my patch or your patch\nseries).\n\n Thomas","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xscSL39clz9s76\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 19:53:54 +1000 (AEST)","from localhost ([::1]:41269 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds4Mi-0004ZP-KJ\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 05:53:52 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59498)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1ds4MN-0004Z3-Oe\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:53:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1ds4MI-0001wm-Tw\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:53:31 -0400","from mx1.redhat.com ([209.132.183.28]:40264)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1ds4MI-0001wB-Oc\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 05:53:26 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C3A5F4ACBB\n\tfor <qemu-devel@nongnu.org>; Wed, 13 Sep 2017 09:53:25 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 32F8C18236;\n\tWed, 13 Sep 2017 09:53:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C3A5F4ACBB","To":"Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org","References":"<1505295366-25295-1-git-send-email-peterx@redhat.com>","From":"Thomas Huth <thuth@redhat.com>","Message-ID":"<f7707221-5365-8074-7a83-ac108059aecc@redhat.com>","Date":"Wed, 13 Sep 2017 11:53:16 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1505295366-25295-1-git-send-email-peterx@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 09:53:25 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Paolo Bonzini <pbonzini@redhat.com>, Fam Zheng <famz@redhat.com>,\n\tMarkus Armbruster <armbru@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767764,"web_url":"http://patchwork.ozlabs.org/comment/1767764/","msgid":"<20170913102842.GE3617@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-13T10:28:42","subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Wed, Sep 13, 2017 at 11:53:16AM +0200, Thomas Huth wrote:\n> On 13.09.2017 11:36, Peter Xu wrote:\n> > It starts from a \"make check\" failure on one of my private tree. The\n> > problem is that when we do \"device_del\" we normally looking for two\n> > things: one response (which is mostly empty), and a REMOVE event.  The\n> > tricky point is the event can either be there before/after the empty\n> > response.  So I added qmp_device_del() to make sure the order does not\n> > matter, then use it where proper.\n> > \n> > Since I'm at it, I also added the sister helper qmp_device_add(), it\n> > helps to remove LOCs.\n> \n> I've had a similar idea a couple of weeks ago, see here:\n> \n> http://patchwork.ozlabs.org/patch/801487/\n\nGood to know!\n\n> \n> > I still don't 100% sure why my private tree can trigger this error,\n> > while the master cannot. Anyway, I think this is something we should\n> > have, no matter what.\n> \n> Did you maybe touch the USB tests in your private tree?\n\nNo.  But I changed some internals of QMP there, I guess that's the\nreason that caused the misorder to happen more easily.\n\n> As far as I know, some test currently use QMP in a bad way, for example\n> usb_test_hotplug() only checks for the DEVICE_DELETED at the end, but\n> forgets to read back the final return value. That return value is then\n> presented to the next part of the code that uses QMP instead ... it\n> currently only works more or less by accident, but as soon as you try to\n> add new code inbetween, it certainly will fail.\n> ==> We really got to clean this up (either with my patch or your patch\n> series).\n\nAgree.\n\nI think your patch is nicer on the interface (as you have mentioned in\nthe other reply), I can try to review it later.\n\nHowever it seems that your patch didn't really solve the problem I\nencountered (mis-ordered message arrivals).  It would be good if you\nwant to solve it together, or I can draft patch upon yours.\n\nThanks,","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsdFH2hsjz9s7M\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 20:29:23 +1000 (AEST)","from localhost ([::1]:41392 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds4v3-0006Ph-Bk\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 06:29:21 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51124)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1ds4uh-0006Oi-Fb\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:29:03 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1ds4uc-000166-Iq\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:28:59 -0400","from mx1.redhat.com ([209.132.183.28]:58742)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1ds4uc-00015H-DE\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:28:54 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 6C2B1C057FA7\n\tfor <qemu-devel@nongnu.org>; Wed, 13 Sep 2017 10:28:53 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 39B0560BEC;\n\tWed, 13 Sep 2017 10:28:44 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 6C2B1C057FA7","Date":"Wed, 13 Sep 2017 18:28:42 +0800","From":"Peter Xu <peterx@redhat.com>","To":"Thomas Huth <thuth@redhat.com>","Message-ID":"<20170913102842.GE3617@pxdev.xzpeter.org>","References":"<1505295366-25295-1-git-send-email-peterx@redhat.com>\n\t<f7707221-5365-8074-7a83-ac108059aecc@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<f7707221-5365-8074-7a83-ac108059aecc@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tWed, 13 Sep 2017 10:28:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org,\n\tMarkus Armbruster <armbru@redhat.com>,\n\tGerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767771,"web_url":"http://patchwork.ozlabs.org/comment/1767771/","msgid":"<3652b029-7a6d-af98-47e0-2e894f471b46@redhat.com>","list_archive_url":null,"date":"2017-09-13T10:35:17","subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 13.09.2017 12:28, Peter Xu wrote:\n> On Wed, Sep 13, 2017 at 11:53:16AM +0200, Thomas Huth wrote:\n>> On 13.09.2017 11:36, Peter Xu wrote:\n>>> It starts from a \"make check\" failure on one of my private tree. The\n>>> problem is that when we do \"device_del\" we normally looking for two\n>>> things: one response (which is mostly empty), and a REMOVE event.  The\n>>> tricky point is the event can either be there before/after the empty\n>>> response.  So I added qmp_device_del() to make sure the order does not\n>>> matter, then use it where proper.\n>>>\n>>> Since I'm at it, I also added the sister helper qmp_device_add(), it\n>>> helps to remove LOCs.\n>>\n>> I've had a similar idea a couple of weeks ago, see here:\n>>\n>> http://patchwork.ozlabs.org/patch/801487/\n> \n> Good to know!\n> \n>>\n>>> I still don't 100% sure why my private tree can trigger this error,\n>>> while the master cannot. Anyway, I think this is something we should\n>>> have, no matter what.\n>>\n>> Did you maybe touch the USB tests in your private tree?\n> \n> No.  But I changed some internals of QMP there, I guess that's the\n> reason that caused the misorder to happen more easily.\n> \n>> As far as I know, some test currently use QMP in a bad way, for example\n>> usb_test_hotplug() only checks for the DEVICE_DELETED at the end, but\n>> forgets to read back the final return value. That return value is then\n>> presented to the next part of the code that uses QMP instead ... it\n>> currently only works more or less by accident, but as soon as you try to\n>> add new code inbetween, it certainly will fail.\n>> ==> We really got to clean this up (either with my patch or your patch\n>> series).\n> \n> Agree.\n> \n> I think your patch is nicer on the interface (as you have mentioned in\n> the other reply), I can try to review it later.\n> \n> However it seems that your patch didn't really solve the problem I\n> encountered (mis-ordered message arrivals).  It would be good if you\n> want to solve it together, or I can draft patch upon yours.\n\nTrue, I'll try to respin my patch, including the ideas from your patch...\n\n Thomas","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsdPH6Kw6z9sNV\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 20:36:18 +1000 (AEST)","from localhost ([::1]:41431 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds51j-0003zG-Iz\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 06:36:15 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55206)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1ds517-0003xC-7D\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:35:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <thuth@redhat.com>) id 1ds512-0007kR-Cq\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:35:37 -0400","from mx1.redhat.com ([209.132.183.28]:51989)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1ds512-0007jO-7k\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:35:32 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 23B2C4E4F3\n\tfor <qemu-devel@nongnu.org>; Wed, 13 Sep 2017 10:35:31 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6DAF460BEC;\n\tWed, 13 Sep 2017 10:35:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 23B2C4E4F3","To":"Peter Xu <peterx@redhat.com>","References":"<1505295366-25295-1-git-send-email-peterx@redhat.com>\n\t<f7707221-5365-8074-7a83-ac108059aecc@redhat.com>\n\t<20170913102842.GE3617@pxdev.xzpeter.org>","From":"Thomas Huth <thuth@redhat.com>","Message-ID":"<3652b029-7a6d-af98-47e0-2e894f471b46@redhat.com>","Date":"Wed, 13 Sep 2017 12:35:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913102842.GE3617@pxdev.xzpeter.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tWed, 13 Sep 2017 10:35:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org,\n\tMarkus Armbruster <armbru@redhat.com>,\n\tGerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}},{"id":1767781,"web_url":"http://patchwork.ozlabs.org/comment/1767781/","msgid":"<20170913104235.GG3617@pxdev.xzpeter.org>","list_archive_url":null,"date":"2017-09-13T10:42:35","subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","submitter":{"id":67717,"url":"http://patchwork.ozlabs.org/api/people/67717/","name":"Peter Xu","email":"peterx@redhat.com"},"content":"On Wed, Sep 13, 2017 at 12:35:17PM +0200, Thomas Huth wrote:\n\n[...]\n\n> >> As far as I know, some test currently use QMP in a bad way, for example\n> >> usb_test_hotplug() only checks for the DEVICE_DELETED at the end, but\n> >> forgets to read back the final return value. That return value is then\n> >> presented to the next part of the code that uses QMP instead ... it\n> >> currently only works more or less by accident, but as soon as you try to\n> >> add new code inbetween, it certainly will fail.\n> >> ==> We really got to clean this up (either with my patch or your patch\n> >> series).\n> > \n> > Agree.\n> > \n> > I think your patch is nicer on the interface (as you have mentioned in\n> > the other reply), I can try to review it later.\n> > \n> > However it seems that your patch didn't really solve the problem I\n> > encountered (mis-ordered message arrivals).  It would be good if you\n> > want to solve it together, or I can draft patch upon yours.\n> \n> True, I'll try to respin my patch, including the ideas from your patch...\n\nThat would be great.  I've left some comments there already.  Thanks!","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=<UNKNOWN>)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=peterx@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsdYh6gLRz9s5L\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 13 Sep 2017 20:43:36 +1000 (AEST)","from localhost ([::1]:41482 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>)\n\tid 1ds58o-0001dT-TF\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 06:43:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59599)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1ds584-0001bb-Gb\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:42:49 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from <peterx@redhat.com>) id 1ds580-0005mW-IB\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:42:48 -0400","from mx1.redhat.com ([209.132.183.28]:41664)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from <peterx@redhat.com>) id 1ds580-0005lq-CB\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 06:42:44 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5C23D461E0\n\tfor <qemu-devel@nongnu.org>; Wed, 13 Sep 2017 10:42:43 +0000 (UTC)","from pxdev.xzpeter.org (dhcp-15-224.nay.redhat.com [10.66.15.224])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5938B1717C;\n\tWed, 13 Sep 2017 10:42:37 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5C23D461E0","Date":"Wed, 13 Sep 2017 18:42:35 +0800","From":"Peter Xu <peterx@redhat.com>","To":"Thomas Huth <thuth@redhat.com>","Message-ID":"<20170913104235.GG3617@pxdev.xzpeter.org>","References":"<1505295366-25295-1-git-send-email-peterx@redhat.com>\n\t<f7707221-5365-8074-7a83-ac108059aecc@redhat.com>\n\t<20170913102842.GE3617@pxdev.xzpeter.org>\n\t<3652b029-7a6d-af98-47e0-2e894f471b46@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<3652b029-7a6d-af98-47e0-2e894f471b46@redhat.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tWed, 13 Sep 2017 10:42:43 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 0/4] qtest: fix \"device_del\" out-of-order\n\tevents","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"<qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<http://lists.nongnu.org/archive/html/qemu-devel/>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n\t<mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Cc":"Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org,\n\tMarkus Armbruster <armbru@redhat.com>,\n\tGerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>"}}]