[{"id":1768971,"web_url":"http://patchwork.ozlabs.org/comment/1768971/","msgid":"","list_archive_url":null,"date":"2017-09-15T07:04:56","subject":"Re: [Qemu-devel] [PATCH v2 0/3] iotests: cure s390x failures by\n\tswitching to ccw/aliases","submitter":{"id":70124,"url":"http://patchwork.ozlabs.org/api/people/70124/","name":"QingFeng Hao","email":"haoqf@linux.vnet.ibm.com"},"content":"Reviewed-by: QingFeng Hao \n\nfor the series of patches.\n\nThanks\n\n\n在 2017/9/13 17:10, Cornelia Huck 写道:\n> Recent changes in s390x made pci support dependant on the zpci cpu\n> feature, which is not provided on all models (and not on by default).\n> This means we cannot instatiate pci devices on a standard qemu\n> invocation for s390x. Moreover, the zpci instructions are not even\n> wired up for tcg yet, so actually doing anything with those pci devices\n> is bound to fail on tcg.\n>\n> For 040, 051, 139, and 182, this can be fixed by switching to virtio-ccw\n> from virtio-pci on s390x. 051 also needs a bit of post-processing on\n> the output.\n>\n> For 067, it is easier to switch to virtio aliases, which will pick\n> virtio-ccw on s390x and virtio-pci elsewhere. It also exercises the\n> aliasing path.\n>\n> v1->v2:\n> - avoid adding new reference output by adding post-processing to 051\n> and switching to aliases for 067\n>\n> Cornelia Huck (3):\n> iotests: use -ccw on s390x for 040, 139, and 182\n> iotests: use -ccw on s390x for 051\n> iotests: use virtio aliases for 067\n>\n> tests/qemu-iotests/040 | 6 +++++-\n> tests/qemu-iotests/051 | 12 +++++++++++-\n> tests/qemu-iotests/051.out | 2 +-\n> tests/qemu-iotests/051.pc.out | 2 +-\n> tests/qemu-iotests/067 | 3 ++-\n> tests/qemu-iotests/067.out | 2 +-\n> tests/qemu-iotests/139 | 12 ++++++++++--\n> tests/qemu-iotests/182 | 13 +++++++++++--\n> 8 files changed, 42 insertions(+), 10 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtmdN5Qrxz9t2V\n\tfor ;\n\tFri, 15 Sep 2017 17:05:44 +1000 (AEST)","from localhost ([::1]:51677 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dskh4-0001Ue-TN\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 03:05:42 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41751)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dskgg-0001Ta-Ch\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:05:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dskgd-0001yJ-4U\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:05:18 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49522\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dskgc-0001xa-Vm\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 03:05:15 -0400","from pps.filterd (m0098417.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8F74uI5032248\n\tfor ; Fri, 15 Sep 2017 03:05:14 -0400","from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2d08u8jxv2-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Fri, 15 Sep 2017 03:05:13 -0400","from localhost\n\tby e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tFri, 15 Sep 2017 03:05:13 -0400","from b01cxnp22033.gho.pok.ibm.com (9.57.198.23)\n\tby e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 15 Sep 2017 03:05:08 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v8F758DT41484500; Fri, 15 Sep 2017 07:05:08 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B262FAE052;\n\tFri, 15 Sep 2017 03:05:37 -0400 (EDT)","from [9.125.64.156] (unknown [9.125.64.156])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS id 072C8AE034;\n\tFri, 15 Sep 2017 03:05:34 -0400 (EDT)"],"To":"Cornelia Huck , kwolf@redhat.com, mreitz@redhat.com","References":"<20170913091038.2900-1-cohuck@redhat.com>","From":"QingFeng Hao ","Date":"Fri, 15 Sep 2017 15:04:56 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170913091038.2900-1-cohuck@redhat.com>","Content-Type":"text/plain; charset=gbk; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17091507-2213-0000-0000-0000021B63A9","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007739; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000227; SDB=6.00917265; UDB=6.00460693;\n\tIPR=6.00697492; \n\tBA=6.00005589; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017163;\n\tXFM=3.00000015; UTC=2017-09-15 07:05:11","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091507-2214-0000-0000-0000578D4C01","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-15_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709150105","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v8F74uI5032248","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v2 0/3] iotests: cure s390x failures by\n\tswitching to ccw/aliases","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, qemu-block@nongnu.org, david@redhat.com,\n\tqemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1769129,"web_url":"http://patchwork.ozlabs.org/comment/1769129/","msgid":"<20170915121119.GB4077@localhost.localdomain>","list_archive_url":null,"date":"2017-09-15T12:11:19","subject":"Re: [Qemu-devel] [PATCH v2 0/3] iotests: cure s390x failures by\n\tswitching to ccw/aliases","submitter":{"id":2714,"url":"http://patchwork.ozlabs.org/api/people/2714/","name":"Kevin Wolf","email":"kwolf@redhat.com"},"content":"Am 13.09.2017 um 11:10 hat Cornelia Huck geschrieben:\n> Recent changes in s390x made pci support dependant on the zpci cpu\n> feature, which is not provided on all models (and not on by default).\n> This means we cannot instatiate pci devices on a standard qemu\n> invocation for s390x. Moreover, the zpci instructions are not even\n> wired up for tcg yet, so actually doing anything with those pci devices\n> is bound to fail on tcg.\n> \n> For 040, 051, 139, and 182, this can be fixed by switching to virtio-ccw\n> from virtio-pci on s390x. 051 also needs a bit of post-processing on\n> the output.\n> \n> For 067, it is easier to switch to virtio aliases, which will pick\n> virtio-ccw on s390x and virtio-pci elsewhere. It also exercises the\n> aliasing path.\n\nThanks, dropped the whitespace change in patch 3 and applied to the\nblock branch.\n\nKevin","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx08.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kwolf@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtvQp3dwPz9s7C\n\tfor ;\n\tFri, 15 Sep 2017 22:12:01 +1000 (AEST)","from localhost ([::1]:53078 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dspTS-0002pP-0s\n\tfor incoming@patchwork.ozlabs.org; Fri, 15 Sep 2017 08:11:58 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50045)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dspT7-0002kK-Ms\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 08:11:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dspT6-0008VD-Qj\n\tfor qemu-devel@nongnu.org; Fri, 15 Sep 2017 08:11:37 -0400","from mx1.redhat.com ([209.132.183.28]:37410)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dspT0-0008Mp-NF; Fri, 15 Sep 2017 08:11:30 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4D33AC0587C7;\n\tFri, 15 Sep 2017 12:11:25 +0000 (UTC)","from localhost.localdomain (ovpn-117-157.ams2.redhat.com\n\t[10.36.117.157])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 61CDF60A9D;\n\tFri, 15 Sep 2017 12:11:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4D33AC0587C7","Date":"Fri, 15 Sep 2017 14:11:19 +0200","From":"Kevin Wolf ","To":"Cornelia Huck ","Message-ID":"<20170915121119.GB4077@localhost.localdomain>","References":"<20170913091038.2900-1-cohuck@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170913091038.2900-1-cohuck@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]);\n\tFri, 15 Sep 2017 12:11:25 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v2 0/3] iotests: cure s390x failures by\n\tswitching to ccw/aliases","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, haoqf@linux.vnet.ibm.com, qemu-block@nongnu.org,\n\tdavid@redhat.com, agraf@suse.de, qemu-devel@nongnu.org,\n\tborntraeger@de.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]