[{"id":1767792,"web_url":"http://patchwork.ozlabs.org/comment/1767792/","msgid":"","list_archive_url":null,"date":"2017-09-13T10:53:25","subject":"Re: [U-Boot] [PATCH v2 00/14] sunxi: convert musb to the device\n\tmodel and enable usb_ether","submitter":{"id":70701,"url":"http://patchwork.ozlabs.org/api/people/70701/","name":"Lukasz Majewski","email":"lukma@denx.de"},"content":"Hi Maxime,\n> Hi,\n> \n> This serie aims at fixing an issue we had to carry out of tree patches\n> for for a few years.\n> \n> The issue is this: a significant number of Allwinner boards don't have\n> an Ethernet connection, while an Ethernet connection is pretty useful\n> for example during development to do some PXE/NFS boot.\n> \n> However, we needed to have DM_ETH enabled for the boards that use our\n> Ethernet controller drivers that rely on it. It meant having to use\n> the newly introduced DM_ETH support in the usb_ether gadget, but our\n> musb peripheral wasn't converted to the device model, and therefore\n> not usable with it.\n> \n> The other alternative was to use the old-style usb_ether driver, which\n> worked fine but were disabling the Ethernet controller driver.\n> \n> Thus, none were good, upstreamable solution.\n> \n> Fix this properly by adding support for the musb in peripheral mode in\n> the device model. While we're doing so, I also took the occasion to\n> move a number of configuration options to Kconfig, and rework the\n> dependencies between them to ease the selection of related options\n> while trying to avoid as much as possible the combinations that are\n> not valid.\n> \n> This was tested on a Sinlinx SinA33 that is wired as a peripheral-only\n> mUSB.\n> \n> Let me know what you think,\n\nThanks for your effort. I've ack'ed gadget relevant commits, so I think \nthat this series should go through the sunxi tree.\n\nBest regards,\nŁukasz\n\n> Maxime\n> \n> Changes from v1:\n> - Rebased on v2017.09\n> - Added some help on a number of options introduced\n> - Added the various tags collected\n> \n> Maxime Ripard (14):\n> usb: gadget: Move USBNET_DEVADDR option out of g_dnl\n> usb: gadget: Document USBNET_DEVADDR\n> usb: gadget: Move USBNET_HOST_ADDR to Kconfig\n> usb: gadget: Convert USB_ETHER to Kconfig\n> usb: gadget: usb_ether: Move the interfaces to Kconfig\n> usb: gadget: Make g_dnl USB settings common\n> usb: gadget: usb_ether: Move settings to common\n> sunxi: provide default USB gadget setup\n> sunxi: imply USB_GADGET\n> cmd: fastboot: Rework fastboot dependency\n> musb: sunxi: switch to the device model\n> sunxi: Register usb_ether\n> sunxi: Imply USB_ETHER\n> sunxi: sina33: Sync the device tree with the kernel\n> \n> arch/arm/Kconfig | 4 +-\n> arch/arm/dts/axp223.dtsi | 58 ++-\n> arch/arm/dts/axp22x.dtsi | 10 +-\n> arch/arm/dts/sun8i-a23-a33.dtsi | 446 ++++++---------\n> arch/arm/dts/sun8i-a33-sinlinx-sina33.dts | 43 +-\n> arch/arm/dts/sun8i-a33.dtsi | 477 +++++++++++++---\n> arch/arm/include/asm/arch-sunxi/usb_phy.h | 7 +-\n> board/samsung/common/gadget.c | 4 +-\n> board/siemens/common/factoryset.c | 4 +-\n> board/sunxi/board.c | 3 +-\n> cmd/fastboot/Kconfig | 4 +-\n> configs/A13-OLinuXino_defconfig | 5 +-\n> configs/A20-OLinuXino-Lime2-eMMC_defconfig | 5 +-\n> configs/A20-OLinuXino-Lime2_defconfig | 5 +-\n> configs/CHIP_defconfig | 5 +-\n> configs/CHIP_pro_defconfig | 5 +-\n> configs/Cubietruck_defconfig | 5 +-\n> configs/Nintendo_NES_Classic_Edition_defconfig | 5 +-\n> configs/Sinlinx_SinA33_defconfig | 5 +-\n> configs/am335x_baltos_defconfig | 8 +-\n> configs/am335x_boneblack_defconfig | 10 +-\n> configs/am335x_boneblack_vboot_defconfig | 9 +-\n> configs/am335x_evm_defconfig | 9 +-\n> configs/am335x_evm_nor_defconfig | 9 +-\n> configs/am335x_evm_norboot_defconfig | 10 +-\n> configs/am335x_evm_spiboot_defconfig | 9 +-\n> configs/am335x_evm_usbspl_defconfig | 9 +-\n> configs/am335x_hs_evm_defconfig | 7 +-\n> configs/am43xx_evm_defconfig | 6 +-\n> configs/am43xx_evm_ethboot_defconfig | 6 +-\n> configs/am43xx_evm_qspiboot_defconfig | 6 +-\n> configs/am43xx_evm_usbhost_boot_defconfig | 6 +-\n> configs/am43xx_hs_evm_defconfig | 6 +-\n> configs/am57xx_evm_defconfig | 8 +-\n> configs/am57xx_evm_nodt_defconfig | 9 +-\n> configs/am57xx_hs_evm_defconfig | 8 +-\n> configs/apalis-tk1_defconfig | 6 +-\n> configs/apalis_imx6_defconfig | 6 +-\n> configs/apalis_imx6_nospl_com_defconfig | 6 +-\n> configs/apalis_imx6_nospl_it_defconfig | 6 +-\n> configs/apalis_t30_defconfig | 6 +-\n> configs/bcm11130_defconfig | 6 +-\n> configs/bcm11130_nand_defconfig | 6 +-\n> configs/bcm23550_w1d_defconfig | 9 +-\n> configs/bcm28155_ap_defconfig | 9 +-\n> configs/bcm28155_w1d_defconfig | 6 +-\n> configs/beaver_defconfig | 6 +-\n> configs/birdland_bav335a_defconfig | 9 +-\n> configs/birdland_bav335b_defconfig | 9 +-\n> configs/cei-tk1-som_defconfig | 6 +-\n> configs/cgtqmx6eval_defconfig | 9 +-\n> configs/chromebit_mickey_defconfig | 7 +-\n> configs/chromebook_jerry_defconfig | 7 +-\n> configs/chromebook_minnie_defconfig | 7 +-\n> configs/colibri_imx6_defconfig | 6 +-\n> configs/colibri_imx6_nospl_defconfig | 6 +-\n> configs/colibri_imx7_defconfig | 6 +-\n> configs/colibri_t20_defconfig | 6 +-\n> configs/colibri_t30_defconfig | 6 +-\n> configs/colibri_vf_defconfig | 6 +-\n> configs/corvus_defconfig | 6 +-\n> configs/dalmore_defconfig | 6 +-\n> configs/dms-ba16-1g_defconfig | 6 +-\n> configs/dms-ba16_defconfig | 6 +-\n> configs/dra7xx_evm_defconfig | 8 +-\n> configs/dra7xx_hs_evm_defconfig | 8 +-\n> configs/draco_defconfig | 7 +-\n> configs/e2220-1170_defconfig | 6 +-\n> configs/edison_defconfig | 6 +-\n> configs/etamin_defconfig | 7 +-\n> configs/evb-rk3036_defconfig | 7 +-\n> configs/evb-rk3229_defconfig | 7 +-\n> configs/evb-rk3288_defconfig | 7 +-\n> configs/evb-rk3328_defconfig | 6 +-\n> configs/fennec-rk3288_defconfig | 7 +-\n> configs/firefly-rk3288_defconfig | 7 +-\n> configs/gwventana_emmc_defconfig | 8 +-\n> configs/gwventana_gw5904_defconfig | 8 +-\n> configs/gwventana_nand_defconfig | 8 +-\n> configs/jetson-tk1_defconfig | 6 +-\n> configs/kc1_defconfig | 9 +-\n> configs/kylin-rk3036_defconfig | 7 +-\n> configs/ma5d4evk_defconfig | 7 +-\n> configs/miqi-rk3288_defconfig | 7 +-\n> configs/mx6qsabrelite_defconfig | 11 +-\n> configs/mx6sabreauto_defconfig | 6 +-\n> configs/mx6sabresd_defconfig | 6 +-\n> configs/mx7dsabresd_defconfig | 6 +-\n> configs/mx7dsabresd_secure_defconfig | 6 +-\n> configs/nitrogen6dl2g_defconfig | 11 +-\n> configs/nitrogen6dl_defconfig | 11 +-\n> configs/nitrogen6q2g_defconfig | 11 +-\n> configs/nitrogen6q_defconfig | 11 +-\n> configs/nitrogen6s1g_defconfig | 11 +-\n> configs/nitrogen6s_defconfig | 11 +-\n> configs/novena_defconfig | 2 +-\n> configs/nyan-big_defconfig | 6 +-\n> configs/odroid-xu3_defconfig | 6 +-\n> configs/odroid_defconfig | 6 +-\n> configs/omap3_beagle_defconfig | 10 +-\n> configs/omap3_evm_defconfig | 7 +-\n> configs/omap3_logic_defconfig | 9 +-\n> configs/omap5_uevm_defconfig | 6 +-\n> configs/opos6uldev_defconfig | 6 +-\n> configs/origen_defconfig | 6 +-\n> configs/p2371-0000_defconfig | 6 +-\n> configs/p2371-2180_defconfig | 6 +-\n> configs/p2571_defconfig | 6 +-\n> configs/parrot_r16_defconfig | 5 +-\n> configs/pcm051_rev1_defconfig | 1 +-\n> configs/pcm051_rev3_defconfig | 1 +-\n> configs/phycore-rk3288_defconfig | 7 +-\n> configs/pico-imx6ul_defconfig | 6 +-\n> configs/pico-imx7d_defconfig | 6 +-\n> configs/popmetal-rk3288_defconfig | 7 +-\n> configs/pxm2_defconfig | 8 +-\n> configs/rastaban_defconfig | 8 +-\n> configs/rock2_defconfig | 7 +-\n> configs/rut_defconfig | 7 +-\n> configs/s5p_goni_defconfig | 6 +-\n> configs/s5pc210_universal_defconfig | 6 +-\n> configs/sama5d2_ptc_nandflash_defconfig | 2 +-\n> configs/sama5d2_ptc_spiflash_defconfig | 2 +-\n> configs/sansa_fuze_plus_defconfig | 2 +-\n> configs/smartweb_defconfig | 6 +-\n> configs/sniper_defconfig | 9 +-\n> configs/socfpga_arria5_defconfig | 6 +-\n> configs/socfpga_cyclone5_defconfig | 6 +-\n> configs/socfpga_de0_nano_soc_defconfig | 6 +-\n> configs/socfpga_de10_nano_defconfig | 6 +-\n> configs/socfpga_mcvevk_defconfig | 6 +-\n> configs/socfpga_sockit_defconfig | 6 +-\n> configs/socfpga_socrates_defconfig | 6 +-\n> configs/socfpga_vining_fpga_defconfig | 6 +-\n> configs/taurus_defconfig | 6 +-\n> configs/tbs2910_defconfig | 6 +-\n> configs/thuban_defconfig | 7 +-\n> configs/tinker-rk3288_defconfig | 7 +-\n> configs/topic_miami_defconfig | 6 +-\n> configs/topic_miamilite_defconfig | 6 +-\n> configs/topic_miamiplus_defconfig | 6 +-\n> configs/trats2_defconfig | 6 +-\n> configs/trats_defconfig | 6 +-\n> configs/venice2_defconfig | 6 +-\n> configs/vinco_defconfig | 2 +-\n> configs/warp7_defconfig | 9 +-\n> configs/warp7_secure_defconfig | 9 +-\n> configs/warp_defconfig | 6 +-\n> configs/xfi3_defconfig | 2 +-\n> configs/xilinx_zynqmp_ep_defconfig | 6 +-\n> configs/xilinx_zynqmp_zc1751_xm015_dc1_defconfig | 6 +-\n> configs/xilinx_zynqmp_zc1751_xm016_dc2_defconfig | 6 +-\n> configs/xilinx_zynqmp_zcu102_revA_defconfig | 6 +-\n> configs/xilinx_zynqmp_zcu102_revB_defconfig | 6 +-\n> configs/zynq_microzed_defconfig | 6 +-\n> configs/zynq_picozed_defconfig | 6 +-\n> configs/zynq_z_turn_defconfig | 6 +-\n> configs/zynq_zc702_defconfig | 6 +-\n> configs/zynq_zc706_defconfig | 6 +-\n> configs/zynq_zed_defconfig | 6 +-\n> configs/zynq_zybo_defconfig | 6 +-\n> doc/README.android-fastboot | 8 +-\n> drivers/usb/gadget/Kconfig | 78 ++-\n> drivers/usb/gadget/ether.c | 16 +-\n> drivers/usb/gadget/g_dnl.c | 12 +-\n> drivers/usb/musb-new/sunxi.c | 56 +--\n> include/configs/am335x_evm.h | 6 +-\n> include/configs/am3517_evm.h | 5 +-\n> include/configs/am43xx_evm.h | 6 +-\n> include/configs/baltos.h | 6 +-\n> include/configs/gw_ventana.h | 2 +-\n> include/configs/h2200.h | 2 +-\n> include/configs/ma5d4evk.h | 3 +-\n> include/configs/nitrogen6x.h | 2 +-\n> include/configs/novena.h | 2 +-\n> include/configs/odroid_xu3.h | 2 +-\n> include/configs/omap3_beagle.h | 1 +-\n> include/configs/omap3_evm.h | 1 +-\n> include/configs/omap3_logic.h | 1 +-\n> include/configs/pcm051.h | 5 +-\n> include/configs/sama5d2_ptc.h | 3 +-\n> include/configs/sansa_fuze_plus.h | 2 +-\n> include/configs/siemens-am33x-common.h | 6 +-\n> include/configs/tao3530.h | 2 +-\n> include/configs/vinco.h | 3 +-\n> include/configs/warp7.h | 4 +-\n> include/configs/xfi3.h | 2 +-\n> include/dt-bindings/clock/sun8i-a23-a33-ccu.h | 127 ++++-\n> include/dt-bindings/reset/sun8i-a23-a33-ccu.h | 87 +++-\n> scripts/config_whitelist.txt | 5 +-\n> 190 files changed, 1509 insertions(+), 999 deletions(-)\n> create mode 100644 arch/arm/dts/axp223.dtsi\n> create mode 100644 include/dt-bindings/clock/sun8i-a23-a33-ccu.h\n> create mode 100644 include/dt-bindings/reset/sun8i-a23-a33-ccu.h\n> \n> base-commit: c98ac3487e413c71e5d36322ef3324b21c6f60f9\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsdnf2tsYz9s78\n\tfor ;\n\tWed, 13 Sep 2017 20:53:58 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid E6006C22729; Wed, 13 Sep 2017 10:53:52 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B219BC226FF;\n\tWed, 13 Sep 2017 10:53:49 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 28182C226F1; Wed, 13 Sep 2017 10:53:47 +0000 (UTC)","from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10])\n\tby lists.denx.de (Postfix) with ESMTPS id F1D4BC226F1\n\tfor ; Wed, 13 Sep 2017 10:53:28 +0000 (UTC)","from frontend03.mail.m-online.net (unknown [192.168.6.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xsdn42hfCz1qsWZ;\n\tWed, 13 Sep 2017 12:53:28 +0200 (CEST)","from localhost (dynscan3.mnet-online.de [192.168.6.84])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xsdn41n3dz1qqkS;\n\tWed, 13 Sep 2017 12:53:28 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan3.mail.m-online.net [192.168.6.84]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id Yi7icJy02CQ5; Wed, 13 Sep 2017 12:53:26 +0200 (CEST)","from [192.168.2.222] (89-64-27-66.dynamic.chello.pl [89.64.27.66])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPSA;\n\tWed, 13 Sep 2017 12:53:26 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Virus-Scanned":"amavisd-new at mnet-online.de","X-Auth-Info":"a7j8oEkJyM6opGJMLC2WjCAB7aaLiOR7WTU4SQ2GDqo=","To":"Maxime Ripard ,\n\tTom Rini , Jagan Teki ","References":"","From":"=?utf-8?q?=C5=81ukasz_Majewski?= ","Organization":"DENX","Message-ID":"","Date":"Wed, 13 Sep 2017 12:53:25 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Cc":"Thomas Petazzoni , marex@denx.de,\n\tu-boot@lists.denx.de","Subject":"Re: [U-Boot] [PATCH v2 00/14] sunxi: convert musb to the device\n\tmodel and enable usb_ether","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}},{"id":1767808,"web_url":"http://patchwork.ozlabs.org/comment/1767808/","msgid":"<20170913114501.7vascjwynbxnka2m@flea.lan>","list_archive_url":null,"date":"2017-09-13T11:45:01","subject":"Re: [U-Boot] [PATCH v2 00/14] sunxi: convert musb to the device\n\tmodel and enable usb_ether","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi Łukasz,\n\nOn Wed, Sep 13, 2017 at 12:53:25PM +0200, Łukasz Majewski wrote:\n> Hi Maxime,\n> > Hi,\n> > \n> > This serie aims at fixing an issue we had to carry out of tree patches\n> > for for a few years.\n> > \n> > The issue is this: a significant number of Allwinner boards don't have\n> > an Ethernet connection, while an Ethernet connection is pretty useful\n> > for example during development to do some PXE/NFS boot.\n> > \n> > However, we needed to have DM_ETH enabled for the boards that use our\n> > Ethernet controller drivers that rely on it. It meant having to use\n> > the newly introduced DM_ETH support in the usb_ether gadget, but our\n> > musb peripheral wasn't converted to the device model, and therefore\n> > not usable with it.\n> > \n> > The other alternative was to use the old-style usb_ether driver, which\n> > worked fine but were disabling the Ethernet controller driver.\n> > \n> > Thus, none were good, upstreamable solution.\n> > \n> > Fix this properly by adding support for the musb in peripheral mode in\n> > the device model. While we're doing so, I also took the occasion to\n> > move a number of configuration options to Kconfig, and rework the\n> > dependencies between them to ease the selection of related options\n> > while trying to avoid as much as possible the combinations that are\n> > not valid.\n> > \n> > This was tested on a Sinlinx SinA33 that is wired as a peripheral-only\n> > mUSB.\n> > \n> > Let me know what you think,\n> \n> Thanks for your effort. I've ack'ed gadget relevant commits, so I think that\n> this series should go through the sunxi tree.\n\nI just applied them to the sunxi/master branch, with both Simon's and\nyour tags added.\n\n(Jagan, if it's not the right branch, please tell me. I'm still\ngetting used to the u-boot way of managing branches).\n\nThanks!\nMaxime","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xsfww3NSKz9sNw\n\tfor ;\n\tWed, 13 Sep 2017 21:45:19 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid D8535C21D8C; Wed, 13 Sep 2017 11:45:09 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id F33E2C21DAD;\n\tWed, 13 Sep 2017 11:45:03 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 1FFCEC21DAD; Wed, 13 Sep 2017 11:45:03 +0000 (UTC)","from mail.free-electrons.com (mail.free-electrons.com [62.4.15.54])\n\tby lists.denx.de (Postfix) with ESMTP id AC78DC21D8C\n\tfor ; Wed, 13 Sep 2017 11:45:02 +0000 (UTC)","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 5D6C220997; Wed, 13 Sep 2017 13:45:02 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 2F69E20942;\n\tWed, 13 Sep 2017 13:45:02 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=none autolearn=unavailable\n\tautolearn_force=no version=3.4.0","Date":"Wed, 13 Sep 2017 13:45:01 +0200","From":"Maxime Ripard ","To":"=?utf-8?q?=C5=81ukasz?= Majewski ","Message-ID":"<20170913114501.7vascjwynbxnka2m@flea.lan>","References":"\n\t","MIME-Version":"1.0","In-Reply-To":"","User-Agent":"NeoMutt/20170714 (1.8.3)","Cc":"Thomas Petazzoni ,\n\tTom Rini , marex@denx.de, u-boot@lists.denx.de,\n\tJagan Teki ","Subject":"Re: [U-Boot] [PATCH v2 00/14] sunxi: convert musb to the device\n\tmodel and enable usb_ether","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============2716260359658589044==\"","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "}}]