[{"id":1770218,"web_url":"http://patchwork.ozlabs.org/comment/1770218/","msgid":"<20170918144813.GD4141@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-18T14:48:13","subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Tue, Sep 12, 2017 at 08:21:46AM -0700, Brandon Carpenter wrote:\n> We've been experiencing issues where the qemu websocket server closes\n> connections from noVNC clients for no apparent reason. Debugging shows\n> that certain web browsers are injecting ping and pong frames when the\n> connection becomes idle. Some browsers send those frames without a\n> payload, which also is causing closure. This patch series addresses\n> these issues by making the websocket server more conformant to RFC\n> 6455 - The WebSocket Protocol.\n> \n> Remembering the opcode is sufficient for handling fragmented frames from\n> the client, which may be introduced by an intermediary server/proxy.\n> Respond to pings and ignore pongs rather than close the connection as\n> many browsers use ping/pong to test an idle connection. Close\n> connections according to the RFC, including providing a reason code and\n> message to aid debugging of unexpected disconnects. Empty payloads\n> should not cause a disconnect.\n> \n> While updating the websocket code, several other bugs were discovered\n> for which patches are also included early in the set.\n> \n> Brandon Carpenter (7):\n> io: Always remove an old channel watch before adding a new one\n> io: Small updates in preparation for websocket changes\n> io: Add support for fragmented websocket binary frames\n> io: Allow empty websocket payload\n> io: Ignore websocket PING and PONG frames\n> io: Reply to ping frames\n> io: Attempt to send websocket close messages to client\n> \n> include/io/channel-websock.h | 2 +\n> io/channel-websock.c | 282 +++++++++++++++++++++++++++----------------\n> ui/vnc-auth-vencrypt.c | 3 +\n> ui/vnc-ws.c | 6 +\n> ui/vnc.c | 4 +\n> 5 files changed, 194 insertions(+), 103 deletions(-)\n> \n> -- \n> 2.14.1\n\nHi Brandon,\nThanks for the patch series! Please CC the relevant maintainer on\nfuture patches. I've CCed Daniel Berrange on this email to bring your\nwork to his attention.\n\n $ scripts/get_maintainer.pl -f io/channel-websock.c\n \"Daniel P. Berrange\" (maintainer:I/O Channels)\n qemu-devel@nongnu.org (open list:All patches CC here)\n\nStefan\n\n> \n> \n> -- \n> \n> \n> CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is \n> for the sole use of the intended recipient(s) and may contain proprietary, \n> confidential or privileged information or otherwise be protected by law. \n> Any unauthorized review, use, disclosure or distribution is prohibited. If \n> you are not the intended recipient, please notify the sender and destroy \n> all copies and the original message.\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"V74u5q9P\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwpmB06lpz9s3w\n\tfor ;\n\tTue, 19 Sep 2017 00:48:41 +1000 (AEST)","from localhost ([::1]:37068 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dtxLi-0003dZ-VY\n\tfor incoming@patchwork.ozlabs.org; Mon, 18 Sep 2017 10:48:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59372)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dtxLQ-0003dD-Lp\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:48:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dtxLN-0001KA-Ea\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:48:20 -0400","from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243]:38787)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dtxLN-0001Jt-76\n\tfor qemu-devel@nongnu.org; Mon, 18 Sep 2017 10:48:17 -0400","by mail-wr0-x243.google.com with SMTP id p37so489183wrb.5\n\tfor ; Mon, 18 Sep 2017 07:48:17 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tv78sm7136171wmv.48.2017.09.18.07.48.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 18 Sep 2017 07:48:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=a+pvDItXkq5pBXbdScvLfVWZIlEC+Nx9YTKjUoF6NGU=;\n\tb=V74u5q9PZR4uOSp7ZKI7V0F7zK+0Lgnm+Nyg/Bs1KPhS610nn2/ge0wLWD1hre6u8O\n\tyCSkH8MIsvU/NsfyspPb02LyXdY36b8KZEpEhmP4DiWKPg7PVADUNOVG/xqpLDapoQRU\n\tERlb87VBP+YUiQGjv7OMBiiu/M/5Ujo4VPPTo8gsbB+x8T44JHnXNHc4G9dWnZe0xoVn\n\tf4h/wdaczLM528jxiMAqb4fut4vpCTEG2DF49wMukD4W4qRip6RphJoFopIOXGzpXUZ2\n\tAibGs7P0C8y6SOLOk4kpszJIQfCXwzJY8cr+qt/XdRn6tqXDHGiQISvwtcdzQJInOVGQ\n\tSBsg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=a+pvDItXkq5pBXbdScvLfVWZIlEC+Nx9YTKjUoF6NGU=;\n\tb=UnV8StCABuc9gb/spLgfbu5lp7TaGKyePKLOGAyiSwrrT8jDM/Rf3NDHkTbOrOG5Wv\n\twe5jPBPis7/ALGuilaNhwskcJreEA6pmmZa9QFPzVr1PHH9/Jha3KZ7n2fw3HkEHY2L8\n\tGdrzIb/KTm++IFlF05ndLz+n6EUvw6AWJ/THEw4xCGiwJaNbHWOFFAEr3etqL76UoQUi\n\tkUFlDLjwbIpmiE9KOffggJPEqtxLYw4FBTYAGSbBcEVJM66rWc0M3Um1TKb3uigTc8aM\n\tXJkGIUQUbb6Q8grbujvT5FY2HeuX21EP0ddsUutBUXRXdmo/t6KLD7l7ROVtzo2PfOH2\n\tdFsg==","X-Gm-Message-State":"AHPjjUi+wHRFplHmVDe8uNfmJP6RGJEL5rdjQ1j0NYfvZmq6YVOHPHlQ\n\tcJ2hkTKslrEBhg==","X-Google-Smtp-Source":"ADKCNb73mueZ4dzT1nJduWs0M+VMtihwHsBJJLL3BtoMEUXGg9NNuCitfThV5bMLrfKaz5LqQYP9tg==","X-Received":"by 10.223.161.212 with SMTP id\n\tv20mr30898840wrv.195.1505746096003; \n\tMon, 18 Sep 2017 07:48:16 -0700 (PDT)","Date":"Mon, 18 Sep 2017 15:48:13 +0100","From":"Stefan Hajnoczi ","To":"Brandon Carpenter ","Message-ID":"<20170918144813.GD4141@stefanha-x1.localdomain>","References":"<20170912152153.7729-1-brandon.carpenter@cypherpath.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170912152153.7729-1-brandon.carpenter@cypherpath.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c0c::243","Subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772071,"web_url":"http://patchwork.ozlabs.org/comment/1772071/","msgid":"<1505926567.32618.0@smtp.gmail.com>","list_archive_url":null,"date":"2017-09-20T16:56:07","subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","submitter":{"id":72031,"url":"http://patchwork.ozlabs.org/api/people/72031/","name":"Brandon Carpenter","email":"brandon.carpenter@cypherpath.com"},"content":"How are things looking, Daniel. I believe every comment from the \nprevious version of the series was addressed.\n\nI also wanted to mention that I put together a Python script, which \nacts as a proxy between noVNC and qemu, and can inject various frame \ntypes, fragment frames, and shutdown the socket in various ways to help \nexercise the different code paths. I would be happy to post it here to \nhelp test the changes.\n\nThanks,\n--\nBrandon Carpenter | Software Engineer\nCypherpath, Inc.\n400 Columbia Point Drive Ste 101 | Richland, Washington USA\nOffice: (650) 713-3060\n\nOn Tue, Sep 12, 2017 at 8:21 AM, Brandon Carpenter \n wrote:\n> We've been experiencing issues where the qemu websocket server closes\n> connections from noVNC clients for no apparent reason. Debugging shows\n> that certain web browsers are injecting ping and pong frames when the\n> connection becomes idle. Some browsers send those frames without a\n> payload, which also is causing closure. This patch series addresses\n> these issues by making the websocket server more conformant to RFC\n> 6455 - The WebSocket Protocol.\n> \n> Remembering the opcode is sufficient for handling fragmented frames \n> from\n> the client, which may be introduced by an intermediary server/proxy.\n> Respond to pings and ignore pongs rather than close the connection as\n> many browsers use ping/pong to test an idle connection. Close\n> connections according to the RFC, including providing a reason code \n> and\n> message to aid debugging of unexpected disconnects. Empty payloads\n> should not cause a disconnect.\n> \n> While updating the websocket code, several other bugs were discovered\n> for which patches are also included early in the set.\n> \n> Brandon Carpenter (7):\n> io: Always remove an old channel watch before adding a new one\n> io: Small updates in preparation for websocket changes\n> io: Add support for fragmented websocket binary frames\n> io: Allow empty websocket payload\n> io: Ignore websocket PING and PONG frames\n> io: Reply to ping frames\n> io: Attempt to send websocket close messages to client\n> \n> include/io/channel-websock.h | 2 +\n> io/channel-websock.c | 282 \n> +++++++++++++++++++++++++++----------------\n> ui/vnc-auth-vencrypt.c | 3 +\n> ui/vnc-ws.c | 6 +\n> ui/vnc.c | 4 +\n> 5 files changed, 194 insertions(+), 103 deletions(-)\n> \n> --\n> 2.14.1\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=cypherpath.com header.i=@cypherpath.com\n\theader.b=\"ln3gUMhY\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xy5Vy07Ffz9sP1\n\tfor ;\n\tThu, 21 Sep 2017 02:56:40 +1000 (AEST)","from localhost ([::1]:49802 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duiIf-0002i5-K9\n\tfor incoming@patchwork.ozlabs.org; Wed, 20 Sep 2017 12:56:37 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:40072)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1duiIK-0002gW-OH\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 12:56:18 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1duiIG-0005y0-Jo\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 12:56:16 -0400","from mail-pf0-x22a.google.com ([2607:f8b0:400e:c00::22a]:45375)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1duiIG-0005t0-9Z\n\tfor qemu-devel@nongnu.org; Wed, 20 Sep 2017 12:56:12 -0400","by mail-pf0-x22a.google.com with SMTP id z84so1823486pfi.2\n\tfor ; Wed, 20 Sep 2017 09:56:10 -0700 (PDT)","from [10.10.7.25] (68-113-0-218.static.knwc.wa.charter.com.\n\t[68.113.0.218]) by smtp.gmail.com with ESMTPSA id\n\tz8sm7871635pgc.93.2017.09.20.09.56.08\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tWed, 20 Sep 2017 09:56:08 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cypherpath.com; s=google;\n\th=date:from:subject:to:cc:message-id:in-reply-to:references\n\t:mime-version; bh=lcyIVtHDDkyGHq+UL/U84rq1uwTFZNojAIn5XFOBpUs=;\n\tb=ln3gUMhYn+OKjxRLaBoUxSqBS2ZiOJVAKgdmF9xfZM7BwIx4tHRcOlxemd8NKPZ9Lh\n\tO+d3BxfHgZ0P8tHKwz2Sedw5ye8m3jGmLc/aUYjN55irrFaTF1DUSFfhKUcveiS7HE8X\n\tDCccTk4oS9E0k9ljICK63xRijzzk2IYoIavHw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to\n\t:references:mime-version;\n\tbh=lcyIVtHDDkyGHq+UL/U84rq1uwTFZNojAIn5XFOBpUs=;\n\tb=R3ZY1WdWxkq4eA/mgmzOTecctyc8tj5ECljQngc+avjAtMF9TGa01lfu27HvZEt8EO\n\tTU+VuZg4EBh5tINhxuQu634fjeOtzrBLJGb5Bi6z2/ic3wwHm1EcLdb5PHKTul4hGffj\n\tQwHql6mEQ04UxJU+IDjassq2/MBl3CxLyn4NX/lEtXZl5Xy4DViA44nprgylorQgwWFV\n\tianp54KQ29LRa8AEq+8eL1fMWYnuKDOipokrLhb81rCwaGMD+hP7TMRfrOQJ1vt+Obsi\n\toeIBOE9eQ5UjL1A6SETQ4QcSvwl+Eg2FrJzyUt9kU1AB/pZo4IB6lkcp5QKou9vwyc5w\n\t/U1Q==","X-Gm-Message-State":"AHPjjUgXq3LuverEXetgJ/RK1aR7YV2U/guv6zGr0pnpg8PN0tCMT0zt\n\tGXLbbFyNljkDh2YBpzH/tsWM4mQZreutu3EvZoi0BAYuAq+Xqw93VzwZnXJSME7k9sHReqIWbX/\n\tBlNorIi9oP1XA2w==","X-Google-Smtp-Source":"AOwi7QA8zaXT8Jp85VCT6u73qvHDCV3razrK0IyJIJLzVTGT1ESbF/vWKa/Jh15FjFv4BCFzJJRagQ==","X-Received":"by 10.84.253.23 with SMTP id z23mr2708979pll.210.1505926569418; \n\tWed, 20 Sep 2017 09:56:09 -0700 (PDT)","Date":"Wed, 20 Sep 2017 09:56:07 -0700","From":"Brandon Carpenter ","To":"qemu-devel@nongnu.org","Message-Id":"<1505926567.32618.0@smtp.gmail.com>","In-Reply-To":"<20170912152153.7729-1-brandon.carpenter@cypherpath.com>","References":"<20170912152153.7729-1-brandon.carpenter@cypherpath.com>","X-Mailer":"geary/makepkg~g00718198","MIME-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::22a","Content-Type":"text/plain; charset=\"US-ASCII\"; format=flowed","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772634,"web_url":"http://patchwork.ozlabs.org/comment/1772634/","msgid":"<20170921095528.GE26740@redhat.com>","list_archive_url":null,"date":"2017-09-21T09:55:28","subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrange","email":"berrange@redhat.com"},"content":"On Wed, Sep 20, 2017 at 09:56:07AM -0700, Brandon Carpenter wrote:\n> How are things looking, Daniel. I believe every comment from the previous\n> version of the series was addressed.\n> \n> I also wanted to mention that I put together a Python script, which acts as\n> a proxy between noVNC and qemu, and can inject various frame types, fragment\n> frames, and shutdown the socket in various ways to help exercise the\n> different code paths. I would be happy to post it here to help test the\n> changes.\n\nSorry for the delay - I've reviewed this now and it looks good. I've made a\nfew whitespace changes in places, but I've queued it for my next pull request\nnow.\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=berrange@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyX7B1lDCz9t49\n\tfor ;\n\tThu, 21 Sep 2017 19:56:02 +1000 (AEST)","from localhost ([::1]:52671 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1duyD9-0006Te-21\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 05:55:59 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36822)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1duyCn-0006TJ-TR\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:55:38 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1duyCk-0004om-1J\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:55:37 -0400","from mx1.redhat.com ([209.132.183.28]:47800)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1duyCj-0004mo-RK\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:55:33 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9FE29356D7;\n\tThu, 21 Sep 2017 09:55:32 +0000 (UTC)","from redhat.com (unknown [10.33.36.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id D89965C882;\n\tThu, 21 Sep 2017 09:55:31 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 9FE29356D7","Date":"Thu, 21 Sep 2017 10:55:28 +0100","From":"\"Daniel P. Berrange\" ","To":"Brandon Carpenter ","Message-ID":"<20170921095528.GE26740@redhat.com>","References":"<20170912152153.7729-1-brandon.carpenter@cypherpath.com>\n\t<1505926567.32618.0@smtp.gmail.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<1505926567.32618.0@smtp.gmail.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 21 Sep 2017 09:55:32 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"\"Daniel P. Berrange\" ","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1772952,"web_url":"http://patchwork.ozlabs.org/comment/1772952/","msgid":"<1506009264.7363.0@smtp.gmail.com>","list_archive_url":null,"date":"2017-09-21T15:54:24","subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","submitter":{"id":72031,"url":"http://patchwork.ozlabs.org/api/people/72031/","name":"Brandon Carpenter","email":"brandon.carpenter@cypherpath.com"},"content":"Cool. Thanks for helping me through the process and for the great \nfeedback.\n\n--\nBrandon Carpenter | Software Engineer\nCypherpath, Inc.\n400 Columbia Point Drive Ste 101 | Richland, Washington USA\nOffice: (650) 713-3060\n\nOn Thu, Sep 21, 2017 at 2:55 AM, Daniel P. Berrange \n wrote:\n> On Wed, Sep 20, 2017 at 09:56:07AM -0700, Brandon Carpenter wrote:\n>> How are things looking, Daniel. I believe every comment from the \n>> previous\n>> version of the series was addressed.\n>> \n>> I also wanted to mention that I put together a Python script, which \n>> acts as\n>> a proxy between noVNC and qemu, and can inject various frame types, \n>> fragment\n>> frames, and shutdown the socket in various ways to help exercise the\n>> different code paths. I would be happy to post it here to help test \n>> the\n>> changes.\n> \n> Sorry for the delay - I've reviewed this now and it looks good. I've \n> made a\n> few whitespace changes in places, but I've queued it for my next pull \n> request\n> now.\n> \n> Regards,\n> Daniel\n> --\n> |: https://berrange.com -o- \n> https://www.flickr.com/photos/dberrange :|\n> |: https://libvirt.org -o- \n> https://fstop138.berrange.com :|\n> |: https://entangle-photo.org -o- \n> https://www.instagram.com/dberrange :|","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=cypherpath.com header.i=@cypherpath.com\n\theader.b=\"beOmxENZ\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xyh5G1Rzcz9t4B\n\tfor ;\n\tFri, 22 Sep 2017 01:54:58 +1000 (AEST)","from localhost ([::1]:54297 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dv3oW-0005iY-Ai\n\tfor incoming@patchwork.ozlabs.org; Thu, 21 Sep 2017 11:54:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:47369)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dv3o7-0005fv-QT\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 11:54:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dv3o4-0006xL-GT\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 11:54:31 -0400","from mail-pf0-x230.google.com ([2607:f8b0:400e:c00::230]:50909)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dv3o4-0006wr-5x\n\tfor qemu-devel@nongnu.org; Thu, 21 Sep 2017 11:54:28 -0400","by mail-pf0-x230.google.com with SMTP id m63so3410566pfk.7\n\tfor ; Thu, 21 Sep 2017 08:54:27 -0700 (PDT)","from [10.10.7.25] (68-113-0-218.static.knwc.wa.charter.com.\n\t[68.113.0.218]) by smtp.gmail.com with ESMTPSA id\n\ts17sm3298751pgq.25.2017.09.21.08.54.25\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 21 Sep 2017 08:54:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cypherpath.com; s=google;\n\th=date:from:subject:to:cc:message-id:in-reply-to:references\n\t:mime-version; bh=582/8Z0nPpR86jluTvCvTarxyUqVc6OKzQKMEFboKZ0=;\n\tb=beOmxENZwRLzGtBHcW58fMz0j4XAS7G2/ohSqiyuetoq7oYIesQFlsdIsAYHvnp6Ag\n\tH1BMWJ94E6B8j4gXca0AVyqkice/VzsQ9nv8aeyhPCxqNrJy1kZmwc0t1Mvel0zpxOzR\n\txVMd4a01LsydbJGS8Zam77j9Qoy9SovHsZ9w0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to\n\t:references:mime-version;\n\tbh=582/8Z0nPpR86jluTvCvTarxyUqVc6OKzQKMEFboKZ0=;\n\tb=isrGZlltq3ETUqLNBKne2gRnrWlDL9ZPaWLQEd4eP9XB0GsGAA8Qx4vwAssB8LDFoE\n\tNPVkbMd6RsOuUzm8ZjzY8eFrfBoCOw1VNvojVV1Gkn2NLeJ6/YzrefvFv+qXxs12rJT9\n\twvSf+b3HHauBb6uwMP2HAr/L+hF1O62dotY9FtIfgZcRRurhuVPrlmZjSH75YyYkOHxB\n\t3yK6s56U0HcI0DtYycUwOIO5LfzDBIHE+oyIJkIE6ypRg3gZSvcpoLenbsTpXnkWzqUj\n\t9c0eaK13KnCEuYV3I2+gTYdehdUhAFNMD7k2RsIHNgwLQD2iG/k8DB4tL1+z9p9OpLzt\n\tfMkA==","X-Gm-Message-State":"AHPjjUgsESoWsbuu9TE0SlZ3OopbRw9gFVhSlIdaVQVBvAo4Chc3+OO8\n\tB5wRrtb3h0rKcBNs3VY2l1ZpbO+v9Mf6SnQF24jcwtFBhvqai0fjrVorfd4sbEE/NnlhRi4X4Jw\n\tltcmaNvU9Ijipxw==","X-Google-Smtp-Source":"AOwi7QA+CnEfS+HEL1DzdZW6r8A/hcojmT8+P5gI86XJuckQq0akMvrQWPMsnS1SclC8fzhAtKTq/Q==","X-Received":"by 10.98.198.139 with SMTP id x11mr6090181pfk.101.1506009266066; \n\tThu, 21 Sep 2017 08:54:26 -0700 (PDT)","Date":"Thu, 21 Sep 2017 08:54:24 -0700","From":"Brandon Carpenter ","To":"\"Daniel P. Berrange\" ","Message-Id":"<1506009264.7363.0@smtp.gmail.com>","In-Reply-To":"<20170921095528.GE26740@redhat.com>","References":"<20170912152153.7729-1-brandon.carpenter@cypherpath.com>\n\t<1505926567.32618.0@smtp.gmail.com>\n\t<20170921095528.GE26740@redhat.com>","X-Mailer":"geary/makepkg~g00718198","MIME-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::230","Content-Type":"text/plain; charset=\"US-ASCII\"; format=flowed","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v3 0/7] Update websocket code to more fully\n\tsupport the RFC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]