[{"id":1768086,"web_url":"http://patchwork.ozlabs.org/comment/1768086/","msgid":"","list_archive_url":null,"date":"2017-09-13T19:00:53","subject":"Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390","submitter":{"id":66152,"url":"http://patchwork.ozlabs.org/api/people/66152/","name":"Thomas Huth","email":"thuth@redhat.com"},"content":"On 12.09.2017 16:26, Farhan Ali wrote:\n> These patches wire up the virtio-gpu device for CCW bus for\n> S390.\n> \n> For the S390 architecture which does not natively support any graphics\n> device, virtio gpu in 2D mode could be used to emulate a simple graphics\n> card and use VNC as the display.\n> \n> eg: qemu-system-s390x ... -device virtio-gpu-ccw,devno=fe.0.0101\n> -vnc host_ip_addr:5900\n> \n> Note, to actually see any display content the\n> guest kernel needs to support DRM layer, Virtio GPU driver,\n> the Virtual Terminal layer etc.\n\nDo you have a list of CONFIG options that need to be enabled there?\nAre there also any patches to the guest kernel driver required? Or did\nthat work out of the box once you've enabled the right CONFIG options?\n\n> I would appreciate any feedback on these patches, specially the\n> first patch.\n\nPatches look good to me, but I'm not at all familiar with the virtio-gpu\ncode, so that likely does not count...\n\nAnyway, thanks a lot for tackling this! It's pretty cool to finally have\na graphics card on s390x, too :-)\n\n Thomas","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=thuth@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsrcL1NZ2z9sDB\n\tfor ;\n\tThu, 14 Sep 2017 05:01:37 +1000 (AEST)","from localhost ([::1]:44184 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsCuk-0002OJ-JS\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 15:01:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:51476)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsCuO-0002Mz-3y\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 15:01:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsCuJ-0001VX-4m\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 15:01:12 -0400","from mx1.redhat.com ([209.132.183.28]:37126)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsCuI-0001US-Va\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 15:01:07 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BDFB3356D8;\n\tWed, 13 Sep 2017 19:01:05 +0000 (UTC)","from [10.36.116.123] (ovpn-116-123.ams2.redhat.com [10.36.116.123])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 58E2D60C3A;\n\tWed, 13 Sep 2017 19:00:54 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com BDFB3356D8","To":"Farhan Ali , qemu-devel@nongnu.org","References":"","From":"Thomas Huth ","Message-ID":"","Date":"Wed, 13 Sep 2017 21:00:53 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 13 Sep 2017 19:01:05 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com, kraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768093,"web_url":"http://patchwork.ozlabs.org/comment/1768093/","msgid":"","list_archive_url":null,"date":"2017-09-13T19:11:06","subject":"Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390","submitter":{"id":71051,"url":"http://patchwork.ozlabs.org/api/people/71051/","name":"Farhan Ali","email":"alifm@linux.vnet.ibm.com"},"content":"On 09/13/2017 03:00 PM, Thomas Huth wrote:\n> On 12.09.2017 16:26, Farhan Ali wrote:\n>> These patches wire up the virtio-gpu device for CCW bus for S390.\n>>\n>> For the S390 architecture which does not natively support any\n>> graphics device, virtio gpu in 2D mode could be used to emulate a\n>> simple graphics card and use VNC as the display.\n>>\n>> eg: qemu-system-s390x ... -device virtio-gpu-ccw,devno=fe.0.0101\n>> -vnc host_ip_addr:5900\n>>\n>> Note, to actually see any display content the guest kernel needs to\n>> support DRM layer, Virtio GPU driver, the Virtual Terminal layer\n>> etc.\n>\n> Do you have a list of CONFIG options that need to be enabled there?\n> Are there also any patches to the guest kernel driver required? Or\n> did that work out of the box once you've enabled the right CONFIG\n> options?\n>\nIt required some kernel hacking. You need to enable the VT layer for\nS390 to get any kind of graphics displayed.\n\nI experimented on the guest side to enable the VT layer and run a\nframebuffer console and also the Xfce desktop :)\n\nAnyway the CONFIG options I used are:\n\nThe DRM configs to enable the DRM layer and virtio-gpu. I went with the \ndefault options for DRM layer.\n\nCONFIG_DRM\n\nCONFIG_DRM_VIRTIO_GPU\n\nWe also need to enable configs for the VT layer\n\nCONFIG_VT\n\nCONFIG_DUMMY_CONSOLE\n\nAnd to display a framebuffer console for the guest\n\nCONFIG_FRAMEBUFFER_CONSOLE\n\n\n\n>> I would appreciate any feedback on these patches, specially the\n>> first patch.\n>\n> Patches look good to me, but I'm not at all familiar with the\n> virtio-gpu code, so that likely does not count...\n>\n> Anyway, thanks a lot for tackling this! It's pretty cool to finally\n> have a graphics card on s390x, too :-)\n>\n> Thomas\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsrqz6C3tz9sDB\n\tfor ;\n\tThu, 14 Sep 2017 05:11:42 +1000 (AEST)","from localhost ([::1]:44216 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsD4W-0006eS-15\n\tfor incoming@patchwork.ozlabs.org; Wed, 13 Sep 2017 15:11:40 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55382)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsD4A-0006eF-FH\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 15:11:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsD45-0008MS-Gj\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 15:11:18 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5]:52156\n\thelo=mx0a-001b2d01.pphosted.com)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dsD45-0008Lj-Ad\n\tfor qemu-devel@nongnu.org; Wed, 13 Sep 2017 15:11:13 -0400","from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8DJ92FN054644\n\tfor ; Wed, 13 Sep 2017 15:11:12 -0400","from e37.co.us.ibm.com (e37.co.us.ibm.com [32.97.110.158])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 2cy7p01udc-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 13 Sep 2017 15:11:12 -0400","from localhost\n\tby e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 13 Sep 2017 13:11:11 -0600","from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20)\n\tby e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 13 Sep 2017 13:11:08 -0600","from b03ledav001.gho.boulder.ibm.com\n\t(b03ledav001.gho.boulder.ibm.com [9.17.130.232])\n\tby b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with\n\tESMTP id v8DJB7MK32637052; Wed, 13 Sep 2017 12:11:07 -0700","from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id A9A536E048;\n\tWed, 13 Sep 2017 13:11:07 -0600 (MDT)","from [9.56.58.100] (unknown [9.56.58.100])\n\tby b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP id 22B1D6E044;\n\tWed, 13 Sep 2017 13:11:07 -0600 (MDT)"],"To":"Thomas Huth , qemu-devel@nongnu.org","References":"\n\t","From":"Farhan Ali ","Date":"Wed, 13 Sep 2017 15:11:06 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.7.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Transfer-Encoding":"7bit","X-TM-AS-GCONF":"00","x-cbid":"17091319-0024-0000-0000-000017307C34","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007722; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000227; SDB=6.00916547; UDB=6.00460266;\n\tIPR=6.00696778; \n\tBA=6.00005588; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017140;\n\tXFM=3.00000015; UTC=2017-09-13 19:11:09","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091319-0025-0000-0000-00004CB42E20","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-13_06:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709130294","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.158.5","Subject":"Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com, kraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768424,"web_url":"http://patchwork.ozlabs.org/comment/1768424/","msgid":"<1505378813.31557.7.camel@redhat.com>","list_archive_url":null,"date":"2017-09-14T08:46:53","subject":"Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390","submitter":{"id":589,"url":"http://patchwork.ozlabs.org/api/people/589/","name":"Gerd Hoffmann","email":"kraxel@redhat.com"},"content":"Hi,\n\n> Do you have a list of CONFIG options that need to be enabled there?\n> Are there also any patches to the guest kernel driver required?\n\nguest kernel driver should be fine, it works for ppc64 (big endian)\nguests.\n\ncheers,\n Gerd","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kraxel@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtBxQ5ZSMz9sRg\n\tfor ;\n\tThu, 14 Sep 2017 18:47:38 +1000 (AEST)","from localhost ([::1]:46404 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsPo8-0002wK-V3\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 04:47:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:52125)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsPna-0002kz-7o\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 04:47:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsPnU-0003lW-TH\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 04:47:02 -0400","from mx1.redhat.com ([209.132.183.28]:38518)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsPnU-0003jc-MI\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 04:46:56 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A1DD5356CC;\n\tThu, 14 Sep 2017 08:46:55 +0000 (UTC)","from sirius.home.kraxel.org (ovpn-117-51.ams2.redhat.com\n\t[10.36.117.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 771AF17569;\n\tThu, 14 Sep 2017 08:46:54 +0000 (UTC)","from localhost (localhost [IPv6:::1])\n\tby sirius.home.kraxel.org (Postfix) with ESMTP id 9EB7017532;\n\tThu, 14 Sep 2017 10:46:53 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A1DD5356CC","Message-ID":"<1505378813.31557.7.camel@redhat.com>","From":"Gerd Hoffmann ","To":"Thomas Huth , Farhan Ali , \n\tqemu-devel@nongnu.org","Date":"Thu, 14 Sep 2017 10:46:53 +0200","In-Reply-To":"","References":"\n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Mime-Version":"1.0","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 14 Sep 2017 08:46:55 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v1 0/2] Virtio GPU for S390","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"borntraeger@de.ibm.com, cohuck@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]