[{"id":1769677,"web_url":"http://patchwork.ozlabs.org/comment/1769677/","msgid":"<20170917074322.GA27936@kozik-book>","list_archive_url":null,"date":"2017-09-17T07:43:22","subject":"Re: [PATCH v4 2/2] ARM: dts: exynos: Add HDMI and Sil9234 to Trats2\n\tboard","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Tue, Sep 12, 2017 at 09:34:08AM +0200, Maciej Purski wrote:\n> Add HDMI and Sil9234 MHL converter to Trats2 board.\n> Following in SoC devices have been enabled:\n> - HDMI (HDMI signal encoder),\n> - Mixer (video buffer scanout device),\n> - I2C_5 bus (used for HDMI DDC)\n> - I2C_8 bus (used for HDMI_PHY control).\n> \n> Based on previous work by:\n> Tomasz Stanislawski \n> \n> Signed-off-by: Maciej Purski \n> ---\n> arch/arm/boot/dts/exynos4412-trats2.dts | 112 ++++++++++++++++++++++++++++++++\n> 1 file changed, 112 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts\n> index 35e9b94..742e02a 100644\n> --- a/arch/arm/boot/dts/exynos4412-trats2.dts\n> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts\n> @@ -18,6 +18,7 @@\n> #include \n> #include \n> #include \n> +#include \n> \n> / {\n> \tmodel = \"Samsung Trats 2 based on Exynos4412\";\n> @@ -97,6 +98,34 @@\n> \t\t\tgpio = <&gpj0 5 GPIO_ACTIVE_HIGH>;\n> \t\t\tenable-active-high;\n> \t\t};\n> +\n> +\t\tvsil12: voltage-regulator-6 {\n> +\t\t\tcompatible = \"regulator-fixed\";\n> +\t\t\tregulator-name = \"VSIL_1.2V\";\n> +\t\t\tregulator-min-microvolt = <1200000>;\n> +\t\t\tregulator-max-microvolt = <1200000>;\n> +\t\t\tgpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;\n> +\t\t\tenable-active-high;\n> +\t\t\tvin-supply = <&buck7_reg>;\n> +\t\t};\n> +\n> +\t\tvcc33mhl: voltage-regulator-7 {\n> +\t\t\tcompatible = \"regulator-fixed\";\n> +\t\t\tregulator-name = \"VCC_3.3_MHL\";\n> +\t\t\tregulator-min-microvolt = <3300000>;\n> +\t\t\tregulator-max-microvolt = <3300000>;\n> +\t\t\tgpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;\n> +\t\t\tenable-active-high;\n> +\t\t};\n> +\n> +\t\tvcc18mhl: voltage-regulator-8 {\n> +\t\t\tcompatible = \"regulator-fixed\";\n> +\t\t\tregulator-name = \"VCC_1.8_MHL\";\n> +\t\t\tregulator-min-microvolt = <1800000>;\n> +\t\t\tregulator-max-microvolt = <1800000>;\n> +\t\t\tgpio = <&gpl0 4 GPIO_ACTIVE_HIGH>;\n> +\t\t\tenable-active-high;\n> +\t\t};\n> \t};\n> \n> \tgpio-keys {\n> @@ -229,6 +258,36 @@\n> \t\t};\n> \t};\n> \n> +\ti2c-mhl {\n> +\t\tcompatible = \"i2c-gpio\";\n> +\t\tgpios = <&gpf0 4 GPIO_ACTIVE_HIGH &gpf0 6 GPIO_ACTIVE_HIGH>;\n\nPlease split it like in other nodes:\n\tgpios = <...>, <...>\n\nAFAIR they should work the same so keep it consistent.\n\nRest looks good but the bindings have to be accepted first.\n\nBest regards,\nKrzysztof\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xw1N46rkFz9s7c\n\tfor ;\n\tSun, 17 Sep 2017 17:43:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750811AbdIQHn2 (ORCPT\n\t);\n\tSun, 17 Sep 2017 03:43:28 -0400","from mail-wm0-f65.google.com ([74.125.82.65]:34421 \"EHLO\n\tmail-wm0-f65.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750761AbdIQHn1 (ORCPT\n\t); Sun, 17 Sep 2017 03:43:27 -0400","by mail-wm0-f65.google.com with SMTP id i131so6119642wma.1;\n\tSun, 17 Sep 2017 00:43:26 -0700 (PDT)","from kozik-book (pub158181124008.dh-hfc.datazug.ch.\n\t[158.181.124.8]) by smtp.googlemail.com with ESMTPSA id\n\tj37sm3223058ede.12.2017.09.17.00.43.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 17 Sep 2017 00:43:24 -0700 (PDT)"],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=kqeqzrrlW9n9G3M6wFUqcWn/e6ssOQcArQdbo7x8gsw=;\n\tb=TnW4nr5aeGAbrGaSAYbmy4wjDSOjiWSlJ4evmDU8kJBfTzQ0Kpo+vILjVvhoPFfu4g\n\tPiYJ95Ye4PCuugVLDdaz/s1oDyq7/g84/mxrUmh7qEQdLah2IHvV6WhMxDBNgdBbLj6N\n\tPSXCzNsnSJ45Ur674oEZDjGyCmf0BYYb+iI5Ah5/hgXNCaOUflkvmGfTZAHB98vbnz2N\n\tSjlOCXOEu7HtqpKSEncoQPB8KFAKu2P13kbCzipIUO6ea/ZQAj87vrzcGGOzmlmACzQl\n\tlBtnfSoJGUta58F79ALB6U4rBDVYvhZEe0xqxtEaZ+44Mgnoncmy7zV+CNqfQSGetMvv\n\tBplA==","X-Gm-Message-State":"AHPjjUijaUHc2qKFSmw+s4PgVohsO+gMDUTw8aYJ0Fb6jEwSkqECURzZ\n\t1XW4VsKoXCPhIw==","X-Google-Smtp-Source":"ADKCNb7xj6gn9QGr5HRu5CucQvgKerdRuBro3n9HrNq/zHRi88sxpuM0i1uvoxHydBvvRYFGNkAXmA==","X-Received":"by 10.80.161.69 with SMTP id 63mr25726286edj.283.1505634205827; \n\tSun, 17 Sep 2017 00:43:25 -0700 (PDT)","Date":"Sun, 17 Sep 2017 09:43:22 +0200","From":"Krzysztof Kozlowski ","To":"Maciej Purski ","Cc":"dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,\n\tlinux-samsung-soc@vger.kernel.org, airlied@linux.ie,\n\trobh+dt@kernel.org, mark.rutland@arm.com, architt@codeaurora.org,\n\ta.hajda@samsung.com, Laurent.pinchart@ideasonboard.com,\n\tb.zolnierkie@samsung.com, m.szyprowski@samsung.com","Subject":"Re: [PATCH v4 2/2] ARM: dts: exynos: Add HDMI and Sil9234 to Trats2\n\tboard","Message-ID":"<20170917074322.GA27936@kozik-book>","References":"<1505201648-9240-1-git-send-email-m.purski@samsung.com>\n\t\n\t<1505201648-9240-3-git-send-email-m.purski@samsung.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<1505201648-9240-3-git-send-email-m.purski@samsung.com>","User-Agent":"Mutt/1.5.24 (2015-08-30)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]