[{"id":1766645,"web_url":"http://patchwork.ozlabs.org/comment/1766645/","msgid":"","list_archive_url":null,"date":"2017-09-12T01:58:42","subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","submitter":{"id":66012,"url":"http://patchwork.ozlabs.org/api/people/66012/","name":"Baolin Wang","email":"baolin.wang@linaro.org"},"content":"Hi,\n\nOn 12 September 2017 at 04:11, Franklin S Cooper Jr wrote:\n> 66AK2G has I2C instances that are not apart of the ALWAYS_ON power domain\n> unlike other Keystone 2 SoCs and OMAPL138. Therefore, pm_runtime\n> is required to insure the power domain used by the specific I2C instance is\n> properly turned on along with its functional clock.\n>\n> Signed-off-by: Franklin S Cooper Jr \n> ---\n> Version 4 changes:\n> Fix wording on error message\n> Fix additional error path\n>\n> Version 3 changes:\n> Remove several statements that set clk to NULL\n> Fix error path\n>\n> drivers/i2c/busses/i2c-davinci.c | 67 +++++++++++++++++++++++++++++++++-------\n> 1 file changed, 55 insertions(+), 12 deletions(-)\n>\n> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c\n> index b8c4353..a2d9f7c 100644\n> --- a/drivers/i2c/busses/i2c-davinci.c\n> +++ b/drivers/i2c/busses/i2c-davinci.c\n> @@ -36,6 +36,7 @@\n> #include \n> #include \n> #include \n> +#include \n>\n> /* ----- global defines ----------------------------------------------- */\n>\n> @@ -122,6 +123,9 @@\n> /* set the SDA GPIO low */\n> #define DAVINCI_I2C_DCLR_PDCLR1 BIT(1)\n>\n> +/* timeout for pm runtime autosuspend */\n> +#define DAVINCI_I2C_PM_TIMEOUT 1000 /* ms */\n> +\n> struct davinci_i2c_dev {\n> struct device *dev;\n> void __iomem *base;\n> @@ -541,10 +545,17 @@ i2c_davinci_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)\n>\n> dev_dbg(dev->dev, \"%s: msgs: %d\\n\", __func__, num);\n>\n> + ret = pm_runtime_get_sync(dev->dev);\n> + if (ret < 0) {\n> + dev_err(dev->dev, \"Failed to runtime_get device: %d\\n\", ret);\n> + pm_runtime_put_noidle(dev->dev);\n> + return ret;\n> + }\n> +\n> ret = i2c_davinci_wait_bus_not_busy(dev);\n> if (ret < 0) {\n> dev_warn(dev->dev, \"timeout waiting for bus ready\\n\");\n> - return ret;\n> + goto out;\n> }\n>\n> for (i = 0; i < num; i++) {\n> @@ -552,14 +563,19 @@ i2c_davinci_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)\n> dev_dbg(dev->dev, \"%s [%d/%d] ret: %d\\n\", __func__, i + 1, num,\n> ret);\n> if (ret < 0)\n> - return ret;\n> + goto out;\n> }\n>\n> + ret = num;\n> #ifdef CONFIG_CPU_FREQ\n> complete(&dev->xfr_complete);\n> #endif\n>\n> - return num;\n> +out:\n> + pm_runtime_mark_last_busy(dev->dev);\n> + pm_runtime_put_autosuspend(dev->dev);\n> +\n> + return ret;\n> }\n>\n> static u32 i2c_davinci_func(struct i2c_adapter *adap)\n> @@ -599,6 +615,9 @@ static irqreturn_t i2c_davinci_isr(int this_irq, void *dev_id)\n> int count = 0;\n> u16 w;\n>\n> + if (pm_runtime_suspended(dev->dev))\n> + return IRQ_NONE;\n> +\n> while ((stat = davinci_i2c_read_reg(dev, DAVINCI_I2C_IVR_REG))) {\n> dev_dbg(dev->dev, \"%s: stat=0x%x\\n\", __func__, stat);\n> if (count++ == 100) {\n> @@ -802,13 +821,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)\n> dev->clk = devm_clk_get(&pdev->dev, NULL);\n> if (IS_ERR(dev->clk))\n> return PTR_ERR(dev->clk);\n> - clk_prepare_enable(dev->clk);\n\nYou removed clk enable here, I think it can not work if we did not\nopen CONFIG_PM macro. I think you should keep clk enable here, and set\nrpm active by pm_runtime_set_active() before issuing\npm_runtime_enable().\n\n>\n> mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);\n> dev->base = devm_ioremap_resource(&pdev->dev, mem);\n> if (IS_ERR(dev->base)) {\n> - r = PTR_ERR(dev->base);\n> - goto err_unuse_clocks;\n> + return PTR_ERR(dev->base);\n> + }\n> +\n> + pm_runtime_set_autosuspend_delay(dev->dev,\n> + DAVINCI_I2C_PM_TIMEOUT);\n> + pm_runtime_use_autosuspend(dev->dev);\n> +\n> + pm_runtime_enable(dev->dev);\n> +\n> + r = pm_runtime_get_sync(dev->dev);\n> + if (r < 0) {\n> + dev_err(dev->dev, \"failed to runtime_get device: %d\\n\", r);\n> + pm_runtime_put_noidle(dev->dev);\n> + return r;\n> }\n>\n> i2c_davinci_init(dev);\n> @@ -849,27 +879,40 @@ static int davinci_i2c_probe(struct platform_device *pdev)\n> if (r)\n> goto err_unuse_clocks;\n>\n> + pm_runtime_mark_last_busy(dev->dev);\n> + pm_runtime_put_autosuspend(dev->dev);\n> +\n> return 0;\n>\n> err_unuse_clocks:\n> - clk_disable_unprepare(dev->clk);\n> - dev->clk = NULL;\n> + pm_runtime_dont_use_autosuspend(dev->dev);\n> + pm_runtime_put_sync(dev->dev);\n> + pm_runtime_disable(dev->dev);\n> +\n> return r;\n> }\n>\n> static int davinci_i2c_remove(struct platform_device *pdev)\n> {\n> struct davinci_i2c_dev *dev = platform_get_drvdata(pdev);\n> + int ret;\n>\n> i2c_davinci_cpufreq_deregister(dev);\n>\n> i2c_del_adapter(&dev->adapter);\n>\n> - clk_disable_unprepare(dev->clk);\n> - dev->clk = NULL;\n> + ret = pm_runtime_get_sync(&pdev->dev);\n> + if (ret < 0) {\n> + pm_runtime_put_noidle(&pdev->dev);\n> + return ret;\n> + }\n>\n> davinci_i2c_write_reg(dev, DAVINCI_I2C_MDR_REG, 0);\n>\n> + pm_runtime_dont_use_autosuspend(dev->dev);\n> + pm_runtime_put_sync(dev->dev);\n> + pm_runtime_disable(dev->dev);\n> +\n> return 0;\n> }\n>\n> @@ -880,7 +923,6 @@ static int davinci_i2c_suspend(struct device *dev)\n>\n> /* put I2C into reset */\n> davinci_i2c_reset_ctrl(i2c_dev, 0);\n> - clk_disable_unprepare(i2c_dev->clk);\n>\n> return 0;\n> }\n> @@ -889,7 +931,6 @@ static int davinci_i2c_resume(struct device *dev)\n> {\n> struct davinci_i2c_dev *i2c_dev = dev_get_drvdata(dev);\n>\n> - clk_prepare_enable(i2c_dev->clk);\n> /* take I2C out of reset */\n> davinci_i2c_reset_ctrl(i2c_dev, 1);\n>\n> @@ -899,6 +940,8 @@ static int davinci_i2c_resume(struct device *dev)\n> static const struct dev_pm_ops davinci_i2c_pm = {\n> .suspend = davinci_i2c_suspend,\n> .resume = davinci_i2c_resume,\n> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,\n> + pm_runtime_force_resume)\n> };\n>\n> #define davinci_i2c_pm_ops (&davinci_i2c_pm)\n> --\n> 2.9.4.dirty\n>","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"MrObzdfc\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrnyb2c9Kz9s4s\n\tfor ;\n\tTue, 12 Sep 2017 11:58:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751105AbdILB6o (ORCPT\n\t);\n\tMon, 11 Sep 2017 21:58:44 -0400","from mail-io0-f173.google.com ([209.85.223.173]:38641 \"EHLO\n\tmail-io0-f173.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751004AbdILB6n (ORCPT\n\t); Mon, 11 Sep 2017 21:58:43 -0400","by mail-io0-f173.google.com with SMTP id n69so36964980ioi.5\n\tfor ;\n\tMon, 11 Sep 2017 18:58:43 -0700 (PDT)","by 10.157.24.25 with HTTP; Mon, 11 Sep 2017 18:58:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=dzPwkHrBxQDK7qEqUkm004UT6zY3UTBreykIeKlBelI=;\n\tb=MrObzdfca25ag5y3qEWS8g1ukiqMUGVH3T4wdqXjlRXdQqDmUXZMASzEoutd2qmRAQ\n\t930NiUcqoq4cOLvKC2HjWJPtBIP1Ak9ipOGewPpIf0R0owHkxZU0byjLl+Bk5yK3zgK3\n\tQg2iwdZhN4dFlX+MIIYz/pyCmpFgzmN3OQecA=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=dzPwkHrBxQDK7qEqUkm004UT6zY3UTBreykIeKlBelI=;\n\tb=dIYK/QXWR1yAvBlkk6mhxyHLekFSUl4LV+2JRfh8qMymaLeD/g2rx5EF6+WAogsD+S\n\t3Vkay8U0cjvFhRQgc05hxE+0sCQnS3+3DpawdpGPEAlBnyAwrKjEmJoixIXTxur+ldiZ\n\t/uq9x191fYaAcOPOfiNjzOp5GIBErDfmzgFudvKC7vurzx1tHJHgAQ5SIxyReF87cLFV\n\tFLUPpGJgAWJ8CwVixGgIqD3w8FhslUI3weOWvPqp2ANcoyl4xLwsUyr1GZEyVyN6HTFv\n\tdWUspPhXUxuoTUS0APKlXtG8Sb9i+vcRHjpKVQVn1VmetRFwDYN5SOkQ7VfyBlq52H5m\n\tMZXw==","X-Gm-Message-State":"AHPjjUipColW5Xc209QH8bTrAJEvZhHIN7kfF4AmK4U3KaNTaJixLFTm\n\tPJJEegwsdSfSFGmShhcpk9U4e3iHbwV7","X-Google-Smtp-Source":"AOwi7QDu0/XdPl5rPoTpFQdlEY3M754OlXD2gY+HyjNaYgiz0y8L27MVOyB6XISIlk/l7rouzLC60PvdcdgJTm7XZP0=","X-Received":"by 10.202.73.65 with SMTP id w62mr12428336oia.169.1505181522851; \n\tMon, 11 Sep 2017 18:58:42 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170911201145.31257-2-fcooper@ti.com>","References":"<20170911201145.31257-1-fcooper@ti.com>\n\t<20170911201145.31257-2-fcooper@ti.com>","From":"Baolin Wang ","Date":"Tue, 12 Sep 2017 09:58:42 +0800","Message-ID":"","Subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","To":"Franklin S Cooper Jr ","Cc":"Wolfram Sang , Rob Herring ,\n\tlinux@armlinux.org.uk, nsekhar@ti.com, linux-i2c@vger.kernel.org,\n\tdevicetree@vger.kernel.org, LKML ,\n\tlinux-arm-kernel@lists.infradead.org, grygorii.strashko@ti.com,\n\tvigneshr@ti.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766772,"web_url":"http://patchwork.ozlabs.org/comment/1766772/","msgid":"<021a99bb-3670-fff5-6835-b14d28827929@ti.com>","list_archive_url":null,"date":"2017-09-12T08:48:08","subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","submitter":{"id":3234,"url":"http://patchwork.ozlabs.org/api/people/3234/","name":"Sekhar Nori","email":"nsekhar@ti.com"},"content":"On Tuesday 12 September 2017 07:28 AM, Baolin Wang wrote:\n>> @@ -802,13 +821,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)\n>> dev->clk = devm_clk_get(&pdev->dev, NULL);\n>> if (IS_ERR(dev->clk))\n>> return PTR_ERR(dev->clk);\n>> - clk_prepare_enable(dev->clk);\n\n> You removed clk enable here, I think it can not work if we did not\n> open CONFIG_PM macro. I think you should keep clk enable here, and set\n\nWhat do you mean by \"open CONFIG_PM macro\" ?\n\n> rpm active by pm_runtime_set_active() before issuing\n> pm_runtime_enable().\n\nCan you explain why you want to do this instead of relying on\npm_runtime_get_sync() to enable clock?\n\nThanks,\nSekhar\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"mhyfmLSB\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrz3g6SWjz9s0g\n\tfor ;\n\tTue, 12 Sep 2017 18:48:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751363AbdILIsq (ORCPT\n\t);\n\tTue, 12 Sep 2017 04:48:46 -0400","from lelnx194.ext.ti.com ([198.47.27.80]:47505 \"EHLO\n\tlelnx194.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751337AbdILIsp (ORCPT\n\t); Tue, 12 Sep 2017 04:48:45 -0400","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8C8mDOp031059; \n\tTue, 12 Sep 2017 03:48:13 -0500","from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8C8mDXe010463; \n\tTue, 12 Sep 2017 03:48:13 -0500","from DFLE105.ent.ti.com (10.64.6.26) by DFLE103.ent.ti.com\n\t(10.64.6.24) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tTue, 12 Sep 2017 03:48:13 -0500","from dflp32.itg.ti.com (10.64.6.15) by DFLE105.ent.ti.com\n\t(10.64.6.26) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Tue, 12 Sep 2017 03:48:13 -0500","from [172.24.190.171] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8C8m9gf002723;\n\tTue, 12 Sep 2017 03:48:10 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1505206093;\n\tbh=HOexoFkLgkBUJGCDlZK6M12071TqsTAMyFVwpDi7vvo=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=mhyfmLSBjerFXy3RAZ+nunloF7oiCJWl90aw1dNG9WF2r3HGL3Ebt5XAO7pk3PwNn\n\tn0C1CEFsz+m2Qno8gL6E4EZYvkpzqF6XpyBAuBeFZBt4vR1sdoxtNtLn2LGur74AjV\n\tUtMGJqb2Kb8m8MsBDR++rD/g9vzdTpRlu6LSjIY8=","Subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","To":"Baolin Wang ,\n\tFranklin S Cooper Jr ","CC":"Wolfram Sang , Rob Herring ,\n\t, ,\n\t, LKML ,\n\t, ,\n\t","References":"<20170911201145.31257-1-fcooper@ti.com>\n\t<20170911201145.31257-2-fcooper@ti.com>\n\t","From":"Sekhar Nori ","Message-ID":"<021a99bb-3670-fff5-6835-b14d28827929@ti.com>","Date":"Tue, 12 Sep 2017 14:18:08 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766791,"web_url":"http://patchwork.ozlabs.org/comment/1766791/","msgid":"","list_archive_url":null,"date":"2017-09-12T09:14:42","subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","submitter":{"id":66012,"url":"http://patchwork.ozlabs.org/api/people/66012/","name":"Baolin Wang","email":"baolin.wang@linaro.org"},"content":"Hi,\n\nOn 12 September 2017 at 16:48, Sekhar Nori wrote:\n> On Tuesday 12 September 2017 07:28 AM, Baolin Wang wrote:\n>>> @@ -802,13 +821,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)\n>>> dev->clk = devm_clk_get(&pdev->dev, NULL);\n>>> if (IS_ERR(dev->clk))\n>>> return PTR_ERR(dev->clk);\n>>> - clk_prepare_enable(dev->clk);\n>\n>> You removed clk enable here, I think it can not work if we did not\n>> open CONFIG_PM macro. I think you should keep clk enable here, and set\n>\n> What do you mean by \"open CONFIG_PM macro\" ?\n\nIf you did not open CONFIG_PM macro, then the pm_runtime_xxx() will be\ndummy functions, but now the i2c driver can not work since you did not\nenable clock, right?\n\n>\n>> rpm active by pm_runtime_set_active() before issuing\n>> pm_runtime_enable().\n>\n> Can you explain why you want to do this instead of relying on\n> pm_runtime_get_sync() to enable clock?\n\nWhat I mean is you should compatible whether CONFIG_PM is enabled or not.","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"UChb7Q6d\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrzdn5Qchz9s8J\n\tfor ;\n\tTue, 12 Sep 2017 19:14:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751405AbdILJOo (ORCPT\n\t);\n\tTue, 12 Sep 2017 05:14:44 -0400","from mail-io0-f182.google.com ([209.85.223.182]:37239 \"EHLO\n\tmail-io0-f182.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751320AbdILJOn (ORCPT\n\t); Tue, 12 Sep 2017 05:14:43 -0400","by mail-io0-f182.google.com with SMTP id j141so42785052ioj.4\n\tfor ;\n\tTue, 12 Sep 2017 02:14:42 -0700 (PDT)","by 10.157.24.25 with HTTP; Tue, 12 Sep 2017 02:14:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=MpyycmAw2KvMet0pfwiAM5/Lsn35hLZThZqJ9Rf8KjA=;\n\tb=UChb7Q6dqWxOBONfUcdgfA4HLEEj80I9fB8Fa27Nou7ecE7aqLewGxasexY7gQhmdx\n\tdEufyqqgfcInl17nA2hcexWu9+OQUm7QMhfYanbFg4Yk/WcIk1KnMQIj4nLHuI9cjYIt\n\tZ31lCv+Fv86K82PZSfImPbgkvRwo0IblOFLzI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=MpyycmAw2KvMet0pfwiAM5/Lsn35hLZThZqJ9Rf8KjA=;\n\tb=kQhOZAVpPt754B6n9qPoS5nDcSpUghky5olmRJLLVqMgIlWRDHkbow4C82j3Fq4yJZ\n\taxJ5KzXoH2Nxl1SBc4DXxduV2W75c/XeB2rRFoBTHydlBzJz//7ViC0Gl+02NuhcROan\n\t+a8DKod3v+NlHCgdELAR/kTeQXpULctTIRTl/svfEwIPTTGxp6kpCw54uhQNVqX5JXnc\n\txIwUS0GvXUfyT7yiWv+FN5RpgipU9iAeyDeqyfXeZQdVyMxC4ftjpNPhE54qTzjJ9JgT\n\t6i1AD4qbQC5p6LULJwGh0YvYHhnhlLCsbuQecIznrt36QYSxq1cfhWf3xA7nn5FNpqSI\n\tQvww==","X-Gm-Message-State":"AHPjjUiCadOzCflM8vUhEses68Vj0jzbs6nRBjeDdhbkRA1LZ9vtVLkz\n\tTESEq6FMGosSDmsh2Z8HGTjlGa7V+INA","X-Google-Smtp-Source":"AOwi7QBwRyMFZCr1FDKPlEifp1Fvh5UzNiuHpZvwNVIRDJKjPk9x+7mScjtcqI3BFdnU4t+NXNYSHL8TzsIj1PHKhbU=","X-Received":"by 10.202.237.150 with SMTP id\n\tl144mr14642642oih.88.1505207682449; \n\tTue, 12 Sep 2017 02:14:42 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<021a99bb-3670-fff5-6835-b14d28827929@ti.com>","References":"<20170911201145.31257-1-fcooper@ti.com>\n\t<20170911201145.31257-2-fcooper@ti.com>\n\t\n\t<021a99bb-3670-fff5-6835-b14d28827929@ti.com>","From":"Baolin Wang ","Date":"Tue, 12 Sep 2017 17:14:42 +0800","Message-ID":"","Subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","To":"Sekhar Nori ","Cc":"Franklin S Cooper Jr , Wolfram Sang , \n\tRob Herring , linux@armlinux.org.uk,\n\tlinux-i2c@vger.kernel.org, devicetree@vger.kernel.org,\n\tLKML ,\n\tlinux-arm-kernel@lists.infradead.org, grygorii.strashko@ti.com,\n\tvigneshr@ti.com","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1766801,"web_url":"http://patchwork.ozlabs.org/comment/1766801/","msgid":"","list_archive_url":null,"date":"2017-09-12T09:22:02","subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","submitter":{"id":3234,"url":"http://patchwork.ozlabs.org/api/people/3234/","name":"Sekhar Nori","email":"nsekhar@ti.com"},"content":"On Tuesday 12 September 2017 02:44 PM, Baolin Wang wrote:\n> Hi,\n> \n> On 12 September 2017 at 16:48, Sekhar Nori wrote:\n>> On Tuesday 12 September 2017 07:28 AM, Baolin Wang wrote:\n>>>> @@ -802,13 +821,24 @@ static int davinci_i2c_probe(struct platform_device *pdev)\n>>>> dev->clk = devm_clk_get(&pdev->dev, NULL);\n>>>> if (IS_ERR(dev->clk))\n>>>> return PTR_ERR(dev->clk);\n>>>> - clk_prepare_enable(dev->clk);\n>>\n>>> You removed clk enable here, I think it can not work if we did not\n>>> open CONFIG_PM macro. I think you should keep clk enable here, and set\n>>\n>> What do you mean by \"open CONFIG_PM macro\" ?\n> \n> If you did not open CONFIG_PM macro, then the pm_runtime_xxx() will be\n> dummy functions, but now the i2c driver can not work since you did not\n> enable clock, right?\n\nAh, okay. I am not sure thats a concern on platforms on which this\ndriver is used. Without PM runtime support, most likely the platforms\nwill not boot and multiple drivers will fail.\n\nThanks,\nSekhar\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"Eh8H45tz\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrzqL3vR5z9s83\n\tfor ;\n\tTue, 12 Sep 2017 19:23:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751418AbdILJWp (ORCPT\n\t);\n\tTue, 12 Sep 2017 05:22:45 -0400","from lelnx194.ext.ti.com ([198.47.27.80]:49087 \"EHLO\n\tlelnx194.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751419AbdILJWl (ORCPT\n\t); Tue, 12 Sep 2017 05:22:41 -0400","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby lelnx194.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8C9M7XO004319; \n\tTue, 12 Sep 2017 04:22:07 -0500","from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8C9M7vL000871; \n\tTue, 12 Sep 2017 04:22:07 -0500","from DLEE101.ent.ti.com (157.170.170.31) by DLEE100.ent.ti.com\n\t(157.170.170.30) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tTue, 12 Sep 2017 04:22:07 -0500","from dflp33.itg.ti.com (10.64.6.16) by DLEE101.ent.ti.com\n\t(157.170.170.31) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Tue, 12 Sep 2017 04:22:07 -0500","from [172.24.190.171] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8C9M3eP028469;\n\tTue, 12 Sep 2017 04:22:03 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1505208127;\n\tbh=xODJ+a6ZFIwiE1GdTXrSa3/TgCCR4feEl7tfFHPHs+c=;\n\th=Subject:To:CC:References:From:Date:In-Reply-To;\n\tb=Eh8H45tzdd6nKJR9Wc1jkEQ/iLQW6hvlYFFcvRjjiD3QFTBzws/eQwGuSP+T5Yw9u\n\tRLErTnwpghe2y7L7WBK7ZuLaowUyu3xIUnwNx6NdHqO9X32Z5RSWTwr07YrA8Sq2o1\n\t3AMNa7vayRruMdg2RHLonb48EZ+H+S6A5vi86aPk=","Subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","To":"Baolin Wang ","CC":"Franklin S Cooper Jr , Wolfram Sang , \n\tRob Herring , ,\n\t, ,\n\tLKML ,\n\t, ,\n\t","References":"<20170911201145.31257-1-fcooper@ti.com>\n\t<20170911201145.31257-2-fcooper@ti.com>\n\t\n\t<021a99bb-3670-fff5-6835-b14d28827929@ti.com>\n\t","From":"Sekhar Nori ","Message-ID":"","Date":"Tue, 12 Sep 2017 14:52:02 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1770276,"web_url":"http://patchwork.ozlabs.org/comment/1770276/","msgid":"<7b1c9624-01de-84a5-7236-3a0dbe8f9e5f@ti.com>","list_archive_url":null,"date":"2017-09-18T15:58:42","subject":"Re: [PATCH v4 0/2] i2c: davinci: Add PM Runtime Support needed by\n\t66AK2G","submitter":{"id":3234,"url":"http://patchwork.ozlabs.org/api/people/3234/","name":"Sekhar Nori","email":"nsekhar@ti.com"},"content":"On Tuesday 12 September 2017 01:41 AM, Franklin S Cooper Jr wrote:\n> Add I2C support to 66AK2G. Primary requirement is to add PM\n> Runtime support to the driver.\n> \n> This has been tested on following platforms by performing simple i2c test\n> such as i2c detect and reading on board i2c devices:\n> K2G GP evm\n> OMAPL138\n> K2L GP EVM\n> \n> and boot tested on:\n> K2E GP EVM\n> K2HK GP EVM\n> \n> Version 2 changes:\n> Moved ordering of pm runtime calls\n> \n> Version 3 changes:\n> Dropped first patch since it was pulled in.\n> Remove clk = NULL statements\n> Fix error path\n> \n> Version 4 changes:\n> Fix typo in commit message\n> Fix error path\n\nAcked-by: Sekhar Nori \n\nTested on DA850 LCDK board with some basic i2cdetect/i2cdump and\nsuspend/resume tests.\n\nThanks,\nSekhar\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ti.com header.i=@ti.com header.b=\"FuUTWnTH\"; \n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwrLt1xvdz9s78\n\tfor ;\n\tTue, 19 Sep 2017 02:00:21 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752245AbdIRQAT (ORCPT\n\t);\n\tMon, 18 Sep 2017 12:00:19 -0400","from fllnx209.ext.ti.com ([198.47.19.16]:51794 \"EHLO\n\tfllnx209.ext.ti.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752180AbdIRQAS (ORCPT\n\t); Mon, 18 Sep 2017 12:00:18 -0400","from dlelxv90.itg.ti.com ([172.17.2.17])\n\tby fllnx209.ext.ti.com (8.15.1/8.15.1) with ESMTP id v8IFwpHT025371; \n\tMon, 18 Sep 2017 10:58:51 -0500","from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31])\n\tby dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8IFwkSj011720; \n\tMon, 18 Sep 2017 10:58:46 -0500","from DFLE110.ent.ti.com (10.64.6.31) by DFLE110.ent.ti.com\n\t(10.64.6.31) with Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.845.34;\n\tMon, 18 Sep 2017 10:58:45 -0500","from dlep33.itg.ti.com (157.170.170.75) by DFLE110.ent.ti.com\n\t(10.64.6.31) with Microsoft SMTP Server (version=TLS1_0,\n\tcipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.845.34 via Frontend\n\tTransport; Mon, 18 Sep 2017 10:58:45 -0500","from [172.24.190.171] (ileax41-snat.itg.ti.com [10.172.224.153])\n\tby dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id v8IFwgRY011981;\n\tMon, 18 Sep 2017 10:58:43 -0500"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ti.com;\n\ts=ti-com-17Q1; t=1505750331;\n\tbh=c+BfEnlHFt2N16CAsuw355aOSlACe7uQLqMYlD1xo2A=;\n\th=Subject:To:References:From:Date:In-Reply-To;\n\tb=FuUTWnTHxlINTWtp80FvJfdebJ2upqAm/l/Z175m6RCAYKvUx6MMQj7VhXeQ46tED\n\tuqxyI0flY32BISwARscQz/ZRofTXndSsIW12b7Wh1l7kpPFMJyVFfJ9DgD3bdIXaHy\n\tMRoKB9mrMdR+81p+sL0zBH1btVY0NqkMGpwCGZS8=","Subject":"Re: [PATCH v4 0/2] i2c: davinci: Add PM Runtime Support needed by\n\t66AK2G","To":"Franklin S Cooper Jr , ,\n\t, ,\n\t, ,\n\t,\n\t, ,\n\t","References":"<20170911201145.31257-1-fcooper@ti.com>","From":"Sekhar Nori ","Message-ID":"<7b1c9624-01de-84a5-7236-3a0dbe8f9e5f@ti.com>","Date":"Mon, 18 Sep 2017 21:28:42 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170911201145.31257-1-fcooper@ti.com>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-EXCLAIMER-MD-CONFIG":"e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1788923,"web_url":"http://patchwork.ozlabs.org/comment/1788923/","msgid":"<20171017214617.a7ewlkhbpgze76bq@ninjato>","list_archive_url":null,"date":"2017-10-17T21:46:17","subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"On Mon, Sep 11, 2017 at 03:11:44PM -0500, Franklin S Cooper Jr wrote:\n> 66AK2G has I2C instances that are not apart of the ALWAYS_ON power domain\n> unlike other Keystone 2 SoCs and OMAPL138. Therefore, pm_runtime\n> is required to insure the power domain used by the specific I2C instance is\n> properly turned on along with its functional clock.\n> \n> Signed-off-by: Franklin S Cooper Jr \n\nApplied to for-next, thanks!","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yGpfl07LWz9t3f\n\tfor ;\n\tWed, 18 Oct 2017 08:46:23 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S934861AbdJQVqU (ORCPT );\n\tTue, 17 Oct 2017 17:46:20 -0400","from sauhun.de ([88.99.104.3]:54663 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S934998AbdJQVqT (ORCPT );\n\tTue, 17 Oct 2017 17:46:19 -0400","from localhost (p54B339AE.dip0.t-ipconnect.de [84.179.57.174])\n\tby pokefinder.org (Postfix) with ESMTPSA id EA0C92C3214;\n\tTue, 17 Oct 2017 23:46:17 +0200 (CEST)"],"Date":"Tue, 17 Oct 2017 23:46:17 +0200","From":"Wolfram Sang ","To":"Franklin S Cooper Jr ","Cc":"robh+dt@kernel.org, linux@armlinux.org.uk, nsekhar@ti.com,\n\tlinux-i2c@vger.kernel.org, devicetree@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tgrygorii.strashko@ti.com, vigneshr@ti.com","Subject":"Re: [PATCH v4 1/2] i2c: davinci: Add PM Runtime Support","Message-ID":"<20171017214617.a7ewlkhbpgze76bq@ninjato>","References":"<20170911201145.31257-1-fcooper@ti.com>\n\t<20170911201145.31257-2-fcooper@ti.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"fouwsg2lmturjcu4\"","Content-Disposition":"inline","In-Reply-To":"<20170911201145.31257-2-fcooper@ti.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]