[{"id":1769660,"web_url":"http://patchwork.ozlabs.org/comment/1769660/","msgid":"<CAGRGNgXj6sNHzYv9zsTWSD+FULA0x4-J51ytD=mHLZb_ch-y_g@mail.gmail.com>","list_archive_url":null,"date":"2017-09-17T02:34:25","subject":"Re: [linux-sunxi] [PATCH 2/4] ARM: sun8i: h3/h5: add DE2 CCU device\n\tnode for H3","submitter":{"id":1588,"url":"http://patchwork.ozlabs.org/api/people/1588/","name":"Julian Calaby","email":"julian.calaby@gmail.com"},"content":"Hi Icenowy,\n\nOn Tue, Sep 12, 2017 at 1:55 AM, Icenowy Zheng <icenowy@aosc.io> wrote:\n> The DE2 in H3/H5 has a clock control unit in it, and the behavior is\n> slightly different between H3 and H5.\n>\n> Add the common parts in H3/H5 DTSI, and add the compatible string in H3\n> DTSI.\n>\n> The compatible string of H5 DE2 CCU will be added in a separated patch.\n>\n> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n> ---\n>  arch/arm/boot/dts/sun8i-h3.dtsi    |  4 ++++\n>  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 14 ++++++++++++++\n>  2 files changed, 18 insertions(+)\n>\n> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> index 11240a8313c2..76a4cbc99bdb 100644\n> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> @@ -85,6 +87,18 @@\n>                 #size-cells = <1>;\n>                 ranges;\n>\n> +               display_clocks: clock@1000000 {\n> +                       /* compatible is in per SoC .dtsi file */\n\nI don't know device tree very well, but shouldn't this node be\ndisabled so that it doesn't do anything weird on H5? Or are nodes\nwithout compatibles ignored?\n\nThanks,","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"CDoZ/miL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvtWw6kpHz9sPs\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 12:34:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751352AbdIQCes (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tSat, 16 Sep 2017 22:34:48 -0400","from mail-yw0-f193.google.com ([209.85.161.193]:33437 \"EHLO\n\tmail-yw0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751348AbdIQCer (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Sat, 16 Sep 2017 22:34:47 -0400","by mail-yw0-f193.google.com with SMTP id q80so3523760ywg.0;\n\tSat, 16 Sep 2017 19:34:46 -0700 (PDT)","by 10.129.226.70 with HTTP; Sat, 16 Sep 2017 19:34:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=yYKCkKhJA+DxY78JJ/Ke0zXwT1nvIhQArRf08Fbo6is=;\n\tb=CDoZ/miL/HeGnhm/tFzQj0wvu3K72mCI2y+lZNPptpdJaVjCFhHx/MtKdwAqVw+9lz\n\tr1wp8kbC3jeXzcXDxYuap7WhTidVKCTuri4E9WeR/ylMGi2AFtR2hsMFGArD1n5mpYam\n\tK3JkmL+p1oMPmupE+ItIaPsV3Ds+AOo5sDM2uHyIAT+RLvj56ILUWutdrjj5x5U/P6YK\n\tFnUN4j9nDy8zsflGVIC0C0OOX/y/ZLBMWE+8/pW6hspOK7+/Mq7NoP0dviRImDnSqBX1\n\tqUt5uK5Aa+MJ/tIHfXyPu5L4A8qCaljQOfx6DmJa5Imb2rOQ5Rz53NB3sVM2AAyfPXSr\n\t4GtQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=yYKCkKhJA+DxY78JJ/Ke0zXwT1nvIhQArRf08Fbo6is=;\n\tb=DtAB3Gz1us1mb8L9Ng/KXz9qHEKpYyysw+/R3ShRRAynEdPHRJo3g0HM/mKNoIEw97\n\tQDtfITpa7dHO4c4CjthoENvSo2gTTidZnW5OPzbXocZqP4W6ZxgSZu8tvLE/S0WK2XXv\n\t6MdxU/R4w1TtO58mMkACp6aF/pdkCiW2J0svUxmYijXGJzj3dAmJuuRhcnciX+Ns4oAT\n\tph6sI4zf3tFR6Aj6pbuEjeAhVPFQ4H9OnwkQ4sa3ucN8MSxAPrKDnDYw2U+GWc1Ndn+k\n\tbQi+GqHg4pOzq7NMTE4OfNCm540yeaYOg/SEfH30vmZbjMdXCXX2UWFuVA8/UrDg7iLC\n\tR2JQ==","X-Gm-Message-State":"AHPjjUhBIC0guzfZgiS3MANWW/9/Ii/T5oxKFQCcmb41or1mrVxtA6T9\n\tQZuy3qsiH2Q9N93KR8F17MVflL6sVz0TdVMTtzg=","X-Google-Smtp-Source":"AOwi7QAa6DhwmAbp1HCr/wLydo+RcCH+sZ2s4Gw7zAka262ard8RwLkWospZd+lkiIjvR8WA21O7eRmYMKxds+L6csU=","X-Received":"by 10.129.175.92 with SMTP id x28mr6224525ywj.226.1505615686315; \n\tSat, 16 Sep 2017 19:34:46 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170911155529.62891-3-icenowy@aosc.io>","References":"<20170911155529.62891-1-icenowy@aosc.io>\n\t<20170911155529.62891-3-icenowy@aosc.io>","From":"Julian Calaby <julian.calaby@gmail.com>","Date":"Sun, 17 Sep 2017 12:34:25 +1000","Message-ID":"<CAGRGNgXj6sNHzYv9zsTWSD+FULA0x4-J51ytD=mHLZb_ch-y_g@mail.gmail.com>","Subject":"Re: [linux-sunxi] [PATCH 2/4] ARM: sun8i: h3/h5: add DE2 CCU device\n\tnode for H3","To":"icenowy@aosc.io","Cc":"Rob Herring <robh+dt@kernel.org>,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tChen-Yu Tsai <wens@csie.org>, devicetree <devicetree@vger.kernel.org>,\n\t\"Mailing List, Arm\" <linux-arm-kernel@lists.infradead.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tlinux-sunxi <linux-sunxi@googlegroups.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1769662,"web_url":"http://patchwork.ozlabs.org/comment/1769662/","msgid":"<CAGRGNgVNTvUtu47dQafHkRrW8wQDyT84NTZ=sWT+S3o6zpwAog@mail.gmail.com>","list_archive_url":null,"date":"2017-09-17T02:35:37","subject":"Re: [linux-sunxi] [PATCH 3/4] arm64: allwinner: h5: add compatible\n\tstring for DE2 CCU","submitter":{"id":1588,"url":"http://patchwork.ozlabs.org/api/people/1588/","name":"Julian Calaby","email":"julian.calaby@gmail.com"},"content":"Hi Icenowy,\n\nOn Tue, Sep 12, 2017 at 1:55 AM, Icenowy Zheng <icenowy@aosc.io> wrote:\n> The DE2 CCU on Allwinner H5 SoC has a slightly different behavior than\n> the one on H3, so the compatible string is not set in the common DTSI\n> file.\n>\n> Add the compatible string of H5 DE2 CCU in H5 DTSI file.\n>\n> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n> ---\n>  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 4 ++++\n>  1 file changed, 4 insertions(+)\n>\n> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi\n> index d9a720bff05d..e237c05cfdb4 100644\n> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi\n> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi\n> @@ -98,6 +98,10 @@\n>         compatible = \"allwinner,sun50i-h5-ccu\";\n>  };\n>\n> +&display_clocks {\n> +       compatible = \"allwinner,sun50i-h5-de2-clk\";\n> +};\n> +\n\nThis is what I get for reviewing before reading the full patch set.\n\nShouldn't this be rolled into the previous patch?\n\nThanks,","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bhb5ZnQR\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xvtYF0S73z9sPs\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tSun, 17 Sep 2017 12:36:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751352AbdIQCf7 (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tSat, 16 Sep 2017 22:35:59 -0400","from mail-yw0-f194.google.com ([209.85.161.194]:38795 \"EHLO\n\tmail-yw0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751348AbdIQCf6 (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Sat, 16 Sep 2017 22:35:58 -0400","by mail-yw0-f194.google.com with SMTP id t127so3502171ywg.5;\n\tSat, 16 Sep 2017 19:35:58 -0700 (PDT)","by 10.129.226.70 with HTTP; Sat, 16 Sep 2017 19:35:37 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=A8H+x8tkGJLTl9LsBXAhQezfrYMKAVPlblB5Z20Ndbs=;\n\tb=bhb5ZnQRiZN+T8MoV9YbZ0yDXOO69De2t4IlnWGkEFRBcbOlasWolkmeA4CjAyvNev\n\tf2n7GrOlvW7pnKw+HxfIAAOGidgQaap0reF/NeMcnX5IlAnCHexnQqy/4pBclYFwZ2ue\n\ttHtqLMn9eoKmVeEVacxkWnRlKS7N0aPTfCURGkZrZnWMcbtgnozC2TsOeIbrX7B0ODXZ\n\twS6ob18qPZooHqwtxFe1FPpB9chLZbrfj//H3P+71WpQ5EZWdEH2pFyDkaNDzAcrdem5\n\tpVxEdQO8TQPjTIxijftYLY1C3ArxHvlBecq3j05/V4we0VgSYrh/xQe0oTrth0bdqSDB\n\to+0w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=A8H+x8tkGJLTl9LsBXAhQezfrYMKAVPlblB5Z20Ndbs=;\n\tb=rZwUlQ3YJyC1T0xtQvCvRd6Yn+MHeDpCetCf4t/a423CxyYVR5+1sAvS+ZwpQFtRCG\n\tJLkcr/XzUiMXuHq+rTJZEf304D+Xi9JMgSmfmBtxj9icIQ9S5FX2ZpBrGUTFk7+qr4tw\n\t7sUdKsCxEDeYYxRsCp1W5xcIvD95mclbJUqqUcN0QHv1MMlM8/4CojlZjkgax6y1ZOC0\n\tPjJNX6hS5ZfdH6lkX1fpLE7w+EJcHQgOFNJrMnE/GnW/E5zv+VrrUYBnzGIMtmnKR0DF\n\tzZwdOgdX3scnGQYpvZs2Xjy4QqNAZNa1rhCU6wDB/+b27J6pUVIj0wcT9cAImq4yP5oW\n\tHUvw==","X-Gm-Message-State":"AHPjjUh2UR9qnpa5qdS3/yv29UsW7MiHWz13v+3BxG2wU49PTsbwEvlt\n\tpZekYcueBh4f4PWFzqKHVjTvOeXgB6KR6jzlVrU=","X-Google-Smtp-Source":"ADKCNb5Z8P2GeaGxMyKGP53IxWSobV2swUI/e1M/2li9Px1svsGr2Dgfy3xVy0sDJKxMH0dAwZ/Yrug8mjCeevKl1AE=","X-Received":"by 10.129.179.130 with SMTP id\n\tr124mr25151596ywh.58.1505615757925; \n\tSat, 16 Sep 2017 19:35:57 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170911155529.62891-4-icenowy@aosc.io>","References":"<20170911155529.62891-1-icenowy@aosc.io>\n\t<20170911155529.62891-4-icenowy@aosc.io>","From":"Julian Calaby <julian.calaby@gmail.com>","Date":"Sun, 17 Sep 2017 12:35:37 +1000","Message-ID":"<CAGRGNgVNTvUtu47dQafHkRrW8wQDyT84NTZ=sWT+S3o6zpwAog@mail.gmail.com>","Subject":"Re: [linux-sunxi] [PATCH 3/4] arm64: allwinner: h5: add compatible\n\tstring for DE2 CCU","To":"icenowy@aosc.io","Cc":"Rob Herring <robh+dt@kernel.org>,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tChen-Yu Tsai <wens@csie.org>, devicetree <devicetree@vger.kernel.org>,\n\t\"Mailing List, Arm\" <linux-arm-kernel@lists.infradead.org>,\n\t\"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>,\n\tlinux-sunxi <linux-sunxi@googlegroups.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794608,"web_url":"http://patchwork.ozlabs.org/comment/1794608/","msgid":"<239eed81945193af3af465c7ef0008ca@aosc.io>","list_archive_url":null,"date":"2017-10-27T04:07:51","subject":"Re: [PATCH 0/4] Add SimpleFB support for Allwinner H3 SoC","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"在 2017-09-11 23:55，Icenowy Zheng 写道：\n> This patchset adds devicetree-side support of SimpleFB on Allwinner H3\n> SoC.\n> \n> The DE2 CCU is initialized and used by the SimpleFB node, in order to\n> furtherly coexist with the DRM code.\n> \n> The first patch adds pipelines for DE2 displays in simplefb-sunxi\n> device tree binding.\n> \n> The second patch adds DE2 CCU device node for H3 SoC, and the skeleton\n> of the node enters the H3/H5 common DTSI; the H5 support is splited\n> into the third patch, as they will enter different tree.\n> \n> The fourth patch finally adds simplefb nodes, using the\n> pipeline strings introduced in the first patch.\n> \n> Icenowy Zheng (4):\n>   dt-bindings: simplefb-sunxi: add pipelines for DE2\n>   ARM: sun8i: h3/h5: add DE2 CCU device node for H3\n>   arm64: allwinner: h5: add compatible string for DE2 CCU\n>   ARM: sunxi: h3/h5: add simplefb nodes\n\nMaxime,\nas the U-Boot side is applied to u-boot-video, could you take a look at \nthis\npatchset?\n\nThanks!\nIcenowy\n\n> \n>  .../bindings/display/simple-framebuffer-sunxi.txt  |  4 ++\n>  arch/arm/boot/dts/sun8i-h3.dtsi                    |  4 ++\n>  arch/arm/boot/dts/sunxi-h3-h5.dtsi                 | 43 \n> ++++++++++++++++++++++\n>  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi       |  4 ++\n>  4 files changed, 55 insertions(+)\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNVhp5Fkrz9s8J\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri, 27 Oct 2017 15:07:54 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751483AbdJ0EHx (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tFri, 27 Oct 2017 00:07:53 -0400","from hermes.aosc.io ([199.195.250.187]:59597 \"EHLO hermes.aosc.io\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751457AbdJ0EHw (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tFri, 27 Oct 2017 00:07:52 -0400","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 4F4434BDBA;\n\tFri, 27 Oct 2017 04:07:51 +0000 (UTC)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8;\n format=flowed","Content-Transfer-Encoding":"8bit","Date":"Fri, 27 Oct 2017 12:07:51 +0800","From":"icenowy@aosc.io","To":"Rob Herring <robh+dt@kernel.org>,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tChen-Yu Tsai <wens@csie.org>","Cc":"devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH 0/4] Add SimpleFB support for Allwinner H3 SoC","In-Reply-To":"<20170911155529.62891-1-icenowy@aosc.io>","References":"<20170911155529.62891-1-icenowy@aosc.io>","Message-ID":"<239eed81945193af3af465c7ef0008ca@aosc.io>","X-Sender":"icenowy@aosc.io","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1794685,"web_url":"http://patchwork.ozlabs.org/comment/1794685/","msgid":"<0bf125256b4b7d42a2573ae122a52b33@aosc.io>","list_archive_url":null,"date":"2017-10-27T08:01:07","subject":"Re: [PATCH 2/4] ARM: sun8i: h3/h5: add DE2 CCU device node for H3","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"在 2017-09-11 23:55，Icenowy Zheng 写道：\n> The DE2 in H3/H5 has a clock control unit in it, and the behavior is\n> slightly different between H3 and H5.\n> \n> Add the common parts in H3/H5 DTSI, and add the compatible string in H3\n> DTSI.\n> \n> The compatible string of H5 DE2 CCU will be added in a separated patch.\n> \n> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>\n> ---\n>  arch/arm/boot/dts/sun8i-h3.dtsi    |  4 ++++\n>  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 14 ++++++++++++++\n>  2 files changed, 18 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi \n> b/arch/arm/boot/dts/sun8i-h3.dtsi\n> index b36f9f423c39..a8a1db79f362 100644\n> --- a/arch/arm/boot/dts/sun8i-h3.dtsi\n> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi\n> @@ -85,6 +85,10 @@\n>  \tcompatible = \"allwinner,sun8i-h3-ccu\";\n>  };\n> \n> +&display_clocks {\n> +\tcompatible = \"allwinner,sun8i-a83t-de2-clk\";\n\nSorry, this compatible is wrong.\n\nPlease wait for my new version of this patchset to add a\nallwinner,sun8i-h3-de2-clk and use it.\n\n(A83T doesn't have DE mod clk, but H3 has)\n\n> +};\n> +\n>  &mmc0 {\n>  \tcompatible = \"allwinner,sun7i-a20-mmc\";\n>  \tclocks = <&ccu CLK_BUS_MMC0>,\n> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> index 11240a8313c2..76a4cbc99bdb 100644\n> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi\n> @@ -40,9 +40,11 @@\n>   *     OTHER DEALINGS IN THE SOFTWARE.\n>   */\n> \n> +#include <dt-bindings/clock/sun8i-de2.h>\n>  #include <dt-bindings/clock/sun8i-h3-ccu.h>\n>  #include <dt-bindings/clock/sun8i-r-ccu.h>\n>  #include <dt-bindings/interrupt-controller/arm-gic.h>\n> +#include <dt-bindings/reset/sun8i-de2.h>\n>  #include <dt-bindings/reset/sun8i-h3-ccu.h>\n>  #include <dt-bindings/reset/sun8i-r-ccu.h>\n> \n> @@ -85,6 +87,18 @@\n>  \t\t#size-cells = <1>;\n>  \t\tranges;\n> \n> +\t\tdisplay_clocks: clock@1000000 {\n> +\t\t\t/* compatible is in per SoC .dtsi file */\n> +\t\t\treg = <0x01000000 0x100000>;\n> +\t\t\tclocks = <&ccu CLK_DE>,\n> +\t\t\t\t <&ccu CLK_BUS_DE>;\n> +\t\t\tclock-names = \"mod\",\n> +\t\t\t\t      \"bus\";\n> +\t\t\tresets = <&ccu RST_BUS_DE>;\n> +\t\t\t#clock-cells = <1>;\n> +\t\t\t#reset-cells = <1>;\n> +\t\t};\n> +\n>  \t\tsyscon: syscon@1c00000 {\n>  \t\t\tcompatible = \"allwinner,sun8i-h3-system-controller\",\n>  \t\t\t\t\"syscon\";\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3yNbsz186tz9t2W\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tFri, 27 Oct 2017 19:01:11 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751283AbdJ0IBJ (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tFri, 27 Oct 2017 04:01:09 -0400","from hermes.aosc.io ([199.195.250.187]:37653 \"EHLO hermes.aosc.io\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751070AbdJ0IBI (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tFri, 27 Oct 2017 04:01:08 -0400","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id DC1DD4A3C1;\n\tFri, 27 Oct 2017 08:01:07 +0000 (UTC)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8;\n format=flowed","Content-Transfer-Encoding":"8bit","Date":"Fri, 27 Oct 2017 16:01:07 +0800","From":"icenowy@aosc.io","To":"Rob Herring <robh+dt@kernel.org>,\n\tMaxime Ripard <maxime.ripard@free-electrons.com>,\n\tChen-Yu Tsai <wens@csie.org>","Cc":"devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH 2/4] ARM: sun8i: h3/h5: add DE2 CCU device node for H3","In-Reply-To":"<20170911155529.62891-3-icenowy@aosc.io>","References":"<20170911155529.62891-1-icenowy@aosc.io>\n\t<20170911155529.62891-3-icenowy@aosc.io>","Message-ID":"<0bf125256b4b7d42a2573ae122a52b33@aosc.io>","X-Sender":"icenowy@aosc.io","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]