[{"id":1771427,"web_url":"http://patchwork.ozlabs.org/comment/1771427/","msgid":"<CAGXu5jK-i_Eqfm1mZ-Kz5dqsKuCt_-MDymkb735VXCV9aOnvwQ@mail.gmail.com>","list_archive_url":null,"date":"2017-09-19T22:02:22","subject":"Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS","submitter":{"id":10641,"url":"http://patchwork.ozlabs.org/api/people/10641/","name":"Kees Cook","email":"keescook@chromium.org"},"content":"On Mon, Sep 11, 2017 at 8:26 AM, Mark Salyzyn <salyzyn@android.com> wrote:\n> Make it possible to disable the kuser helpers by adding a KUSER_HELPERS\n> config option (enabled by default). When disabled, all kuser\n> helpers-related code is removed from the kernel and no mapping is done\n> at the fixed high address (0xffff0000); any attempt to use a kuser\n> helper from a 32-bit process will result in a segfault.\n>\n> Signed-off-by: Mark Salyzyn <salyzyn@android.com>\n>\n> v2:\n> - vectors_page and compat_vdso_spec as array of 2\n> - free sigpage if vectors allocation failed\n> - adjust makefile so one line for each of the assembler source modules\n> - split off assembler changes to a new previous patch in series to reduce churn\n> - modify slightly the feature documentation to reduce its reach\n> - modify slightly the feature documentation to rationalize the yes default.\n> - There are more ifdefs as a result of the rebase.\n>\n> v3:\n> - rebase (minor conflicts)\n\nThis looks great to me. I'd love to see kuser helpers gone. :)\n\nCatalin, Will, does this need anything else?\n\n-Kees","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qzuqZtk2\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"nD96Ymcb\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"f3wD8Tf/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxcLg4bw0z9sBW\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 08:02:51 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duQbQ-0006Fw-Hi; Tue, 19 Sep 2017 22:02:48 +0000","from mail-io0-x236.google.com ([2607:f8b0:4001:c06::236])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1duQbM-0006Bw-K1 for linux-arm-kernel@lists.infradead.org;\n\tTue, 19 Sep 2017 22:02:46 +0000","by mail-io0-x236.google.com with SMTP id n69so2455056ioi.5\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tTue, 19 Sep 2017 15:02:24 -0700 (PDT)","by 10.107.178.131 with HTTP; Tue, 19 Sep 2017 15:02:22 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=UXFK1FPCrD3PymtBy+fbpP4ZV2hYfhl9GwPMQkfQs2o=;\n\tb=qzuqZtk2mrRiO2\n\txkJn3Tzh9V5q7W25qkXP7NqtPsvNjIdzU3mlvjvbik30pZuYLja6UXazpqAVPZz+pdMsiz8hdvYsT\n\tHwgQZ0pAVoT7+zFp1rqE2fJD7omOEzugVExr7Axf5cbu9vbQ5ILOC6AbSWMQUWyf99nr2GdpenbB6\n\tFk6Sawa7lxYaiJAjR0EZjqcwxcnE7ss8vuGRY0rv7C9KL6Wp/pVJU/2bZlAop5T+HcemlIvDn4wnG\n\tV8runnCP56ybV7gIQEA/D2cqCMgxYdAWycpEJbOj1Svy3SNj7hTGk5fJ+7/MTnkBusFt9bs5O6lrn\n\tLCmYKsxuq3CRwaqLzB0w==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=7d/fhJ4zYnH3ltgI7XwETqnY681RDV1Yn/nw0ALS1EU=;\n\tb=nD96YmcbHLT/ZYY7SGSqV8duKc/LzG8dmcrZhLKyxKZBj9I30FLND1c2n1c+X17f1o\n\trJ3ZY2Tapw5prN72w+2RgrkfF0vNwhg4om1+fBXv2ccZPDKlRjpPMrGnxCTpUuM7kqaz\n\t0V2w9EuR8TF5gMCvFL944XcK46lrmtDPTpiaOLVLj+InNv7TshqqBjYbUprQwteg7pic\n\tNJO0MGFuh5ndoxnJwicpFC/xjw/iEyIL6Xqtr+BvrYEIp3yOiD42Mz7uQkoRihWKi+vP\n\tGr6rSRMp5zT0HZIoHI521i29q25EcDt4mtN6UfhfS4bqP+w2Z8SEBF3PVJ3c7LXVmVZl\n\to1bA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=7d/fhJ4zYnH3ltgI7XwETqnY681RDV1Yn/nw0ALS1EU=;\n\tb=f3wD8Tf/5yBf6MXnghZhoGdHU1MQ5g+hJ2LL97XxeoPJrAnmIF46Iq7rdIgaG9YorR\n\trLGYeV5fY8xql/lVLRdmtkynT5pAbuRj120pN2odgUJ4fcY60EgmarV1hNU7wxHXnM6D\n\t+5NlhgAUZanrmGztBEAHweJ8OKF6Tt57Yeob0="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=7d/fhJ4zYnH3ltgI7XwETqnY681RDV1Yn/nw0ALS1EU=;\n\tb=Pyt+mIsdvml+/T8iio3rGwe5bKlNPiUlXLmuVByyLCc4Fj4B4WUB1TkAesKZ96Y8th\n\tGGHqVM+Iwbl+w1gDJTe5K9kT8P6LajEs1lCYnYpvw0gAYaFD7m5RMVpLRWuQXkuIDWmf\n\tsuA5WfHLWhmyuZWyK2FsV71ULVoDTPUHqAa05Vvm77PJ7yrJxzEKMr9HVN9ne5N5+L3o\n\tfsaON/zQQu8yFy64dE1pXZgD5+e6m1WQ0OKg5pKcDrvu7wJQ8QtRTVFLsA6Rpmj9c07v\n\teH6Nta30GVa3ksOFlAByXL8M3cFHTRIFG4Tr+lK09xubYzd+kkUFHIgUaGMsiIv1lXpj\n\t93jg==","X-Gm-Message-State":"AHPjjUgFXiBz+jIGWFyn+utS9HOMCChPiff+cAsqSaylDhtUGQsniiMc\n\t6wQxOC4ywQoyJ5+WtcNLtPI6xuihSvq84NTlkrNztg==","X-Google-Smtp-Source":"AOwi7QDog6EiyJGC0F42/vcVMPnKQ+33l0tKYJs7Cqa3Z0KJ0YY5FnSq3XdSRBwZAEO5A++IgVkMWswI5Ceb+OmQ/v8=","X-Received":"by 10.107.9.90 with SMTP id j87mr375582ioi.111.1505858543486;\n\tTue, 19 Sep 2017 15:02:23 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170911152635.95367-1-salyzyn@android.com>","References":"<20170911152635.95367-1-salyzyn@android.com>","From":"Kees Cook <keescook@chromium.org>","Date":"Tue, 19 Sep 2017 15:02:22 -0700","X-Google-Sender-Auth":"aS0p35sy7mSALVBBMxq5c01uyFM","Message-ID":"<CAGXu5jK-i_Eqfm1mZ-Kz5dqsKuCt_-MDymkb735VXCV9aOnvwQ@mail.gmail.com>","Subject":"Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS","To":"Mark Salyzyn <salyzyn@android.com>,\n\tCatalin Marinas <catalin.marinas@arm.com>, \n\tWill Deacon <will.deacon@arm.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170919_150244_762776_1350C928 ","X-CRM114-Status":"GOOD (  15.41  )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.7 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:4001:c06:0:0:0:236 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>, Jisheng Zhang <jszhang@marvell.com>,\n\tArd Biesheuvel <ard.biesheuvel@linaro.org>,\n\tJohn Stultz <john.stultz@linaro.org>,\n\tAKASHI Takahiro <takahiro.akashi@linaro.org>,\n\tPeter Zijlstra <peterz@infradead.org>, kevin.brodsky@arm.com,\n\tLKML <linux-kernel@vger.kernel.org>, Dave Martin <Dave.Martin@arm.com>,\n\tChristian Borntraeger <borntraeger@de.ibm.com>,\n\tMichal Marek <mmarek@suse.com>, James Morse <james.morse@arm.com>,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>, \n\tcredmonster@gmail.com, Laura Abbott <labbott@redhat.com>,\n\tIngo Molnar <mingo@kernel.org>, zijun_hu <zijun_hu@htc.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1771700,"web_url":"http://patchwork.ozlabs.org/comment/1771700/","msgid":"<20170920091555.GA3782@arm.com>","list_archive_url":null,"date":"2017-09-20T09:15:56","subject":"Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS","submitter":{"id":7916,"url":"http://patchwork.ozlabs.org/api/people/7916/","name":"Will Deacon","email":"will.deacon@arm.com"},"content":"On Tue, Sep 19, 2017 at 03:02:22PM -0700, Kees Cook wrote:\n> On Mon, Sep 11, 2017 at 8:26 AM, Mark Salyzyn <salyzyn@android.com> wrote:\n> > Make it possible to disable the kuser helpers by adding a KUSER_HELPERS\n> > config option (enabled by default). When disabled, all kuser\n> > helpers-related code is removed from the kernel and no mapping is done\n> > at the fixed high address (0xffff0000); any attempt to use a kuser\n> > helper from a 32-bit process will result in a segfault.\n> >\n> > Signed-off-by: Mark Salyzyn <salyzyn@android.com>\n> >\n> > v2:\n> > - vectors_page and compat_vdso_spec as array of 2\n> > - free sigpage if vectors allocation failed\n> > - adjust makefile so one line for each of the assembler source modules\n> > - split off assembler changes to a new previous patch in series to reduce churn\n> > - modify slightly the feature documentation to reduce its reach\n> > - modify slightly the feature documentation to rationalize the yes default.\n> > - There are more ifdefs as a result of the rebase.\n> >\n> > v3:\n> > - rebase (minor conflicts)\n> \n> This looks great to me. I'd love to see kuser helpers gone. :)\n> \n> Catalin, Will, does this need anything else?\n\nI haven't had chance to look at the patches yet (buried in other stuff), but\nI aim to get to it in the next couple of weeks.\n\nWill","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"hjDI4jiU\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xxvHh3cnkz9sNw\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed, 20 Sep 2017 19:16:16 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dub75-0003zx-7F; Wed, 20 Sep 2017 09:16:11 +0000","from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]\n\thelo=foss.arm.com)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dub6z-0003vA-V3 for linux-arm-kernel@lists.infradead.org;\n\tWed, 20 Sep 2017 09:16:08 +0000","from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9528C15A2;\n\tWed, 20 Sep 2017 02:15:44 -0700 (PDT)","from edgewater-inn.cambridge.arm.com\n\t(usa-sjc-imap-foss1.foss.arm.com [10.72.51.249])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t61F5E3F58C; Wed, 20 Sep 2017 02:15:44 -0700 (PDT)","by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000)\n\tid 3C3171AE13AE; Wed, 20 Sep 2017 10:15:56 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=fImHJ+z/FQKtcGaP83ujelljhPc+bnNWlZ6+1DwCodM=;\n\tb=hjDI4jiUjrKgqm\n\trYT/4PLgmUV3byolMh5VWpRd8c/vgRAjv6AiSr66motWxniPTF/L6ALnuHQuqt/E2ae5cIN2dquz0\n\t2aXM1zOlZfaGyVQ9enlK/wi5pKfTr9DgdEN9fzNR/XVBEdQ92/xvYdLNOYG9SoDvoWNiFbbHBxZEO\n\tyJRRll0rLTkGr+4NLSMnUPWO9fLO9cGr+j0eDTxJYeJmagZn7dr67diRsC/ZtdSxxJlj8QH0g1C29\n\t7ySGhac+FwefCZsiYxsm0EJu3WGsOnAjVvYDGelC+bsIXKX6NDnBHyDJcrl6RwyuT84zbNzvzZZ5A\n\t8oprGqN7KMIpbD3dqmEg==;","Date":"Wed, 20 Sep 2017 10:15:56 +0100","From":"Will Deacon <will.deacon@arm.com>","To":"Kees Cook <keescook@chromium.org>","Subject":"Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS","Message-ID":"<20170920091555.GA3782@arm.com>","References":"<20170911152635.95367-1-salyzyn@android.com>\n\t<CAGXu5jK-i_Eqfm1mZ-Kz5dqsKuCt_-MDymkb735VXCV9aOnvwQ@mail.gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<CAGXu5jK-i_Eqfm1mZ-Kz5dqsKuCt_-MDymkb735VXCV9aOnvwQ@mail.gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170920_021606_015473_CC57E42F ","X-CRM114-Status":"GOOD (  16.72  )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-6.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [217.140.101.70 listed in list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>, Jisheng Zhang <jszhang@marvell.com>,\n\tArd Biesheuvel <ard.biesheuvel@linaro.org>,\n\tJohn Stultz <john.stultz@linaro.org>,\n\tAKASHI Takahiro <takahiro.akashi@linaro.org>,\n\tPeter Zijlstra <peterz@infradead.org>,\n\tCatalin Marinas <catalin.marinas@arm.com>, kevin.brodsky@arm.com,\n\tLKML <linux-kernel@vger.kernel.org>, Mark Salyzyn <salyzyn@android.com>, \n\tChristian Borntraeger <borntraeger@de.ibm.com>,\n\tMichal Marek <mmarek@suse.com>, James Morse <james.morse@arm.com>,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>, \n\tcredmonster@gmail.com, Laura Abbott <labbott@redhat.com>,\n\tIngo Molnar <mingo@kernel.org>, zijun_hu <zijun_hu@htc.com>,\n\tDave Martin <Dave.Martin@arm.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1796852,"web_url":"http://patchwork.ozlabs.org/comment/1796852/","msgid":"<065fd365-4635-ddc7-b683-59a5cb16be8f@android.com>","list_archive_url":null,"date":"2017-10-31T18:42:39","subject":"Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS","submitter":{"id":66452,"url":"http://patchwork.ozlabs.org/api/people/66452/","name":"Mark Salyzyn","email":"salyzyn@android.com"},"content":"On 09/20/2017 02:15 AM, Will Deacon wrote:\n> On Tue, Sep 19, 2017 at 03:02:22PM -0700, Kees Cook wrote:\n>> On Mon, Sep 11, 2017 at 8:26 AM, Mark Salyzyn <salyzyn@android.com> wrote:\n>>> Make it possible to disable the kuser helpers by adding a KUSER_HELPERS\n>>> config option (enabled by default). When disabled, all kuser\n>>> helpers-related code is removed from the kernel and no mapping is done\n>>> at the fixed high address (0xffff0000); any attempt to use a kuser\n>>> helper from a 32-bit process will result in a segfault.\n>>>\n>>> Signed-off-by: Mark Salyzyn <salyzyn@android.com>\n>>>\n>>> v2:\n>>> - vectors_page and compat_vdso_spec as array of 2\n>>> - free sigpage if vectors allocation failed\n>>> - adjust makefile so one line for each of the assembler source modules\n>>> - split off assembler changes to a new previous patch in series to reduce churn\n>>> - modify slightly the feature documentation to reduce its reach\n>>> - modify slightly the feature documentation to rationalize the yes default.\n>>> - There are more ifdefs as a result of the rebase.\n>>>\n>>> v3:\n>>> - rebase (minor conflicts)\n>> This looks great to me. I'd love to see kuser helpers gone. :)\n>>\n>> Catalin, Will, does this need anything else?\n> I haven't had chance to look at the patches yet (buried in other stuff), but\n> I aim to get to it in the next couple of weeks.\n>\n> Will\n\nPing?","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"Mu9VwQf5\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=android.com header.i=@android.com\n\theader.b=\"mjCFBr22\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yRKwt1tVQz9s7G\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed,  1 Nov 2017 05:43:10 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e9bVB-00056L-PX; Tue, 31 Oct 2017 18:43:05 +0000","from mail-io0-x243.google.com ([2607:f8b0:4001:c06::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e9bV8-00055K-NQ for linux-arm-kernel@lists.infradead.org;\n\tTue, 31 Oct 2017 18:43:04 +0000","by mail-io0-x243.google.com with SMTP id n137so925665iod.6\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tTue, 31 Oct 2017 11:42:42 -0700 (PDT)","from nebulus.mtv.corp.google.com\n\t([2620:0:1000:1612:ec31:37d4:85d3:e269])\n\tby smtp.googlemail.com with ESMTPSA id\n\t70sm939614iok.77.2017.10.31.11.42.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 31 Oct 2017 11:42:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=RycRgW6W+vqRoI4RUuxAgplmpaOHbZazIpbZf0E226o=;\n\tb=Mu9VwQf5r+dfqocAL+tn4yi+A\n\t1bOqHCPHk3XlLs4qDRLAdM+6bQzXspai4xn7p6tKjnok1Ywco5DXw9c4CFgFbR06bhJm+wJfvTiig\n\tKeuWw2uCM3KLF8I8tM1zzYX9eEH/3AYoG7A/Ukb5v0HnQBeDbHn5ojNj0W+Ks53mh2E0aIzz/U2nc\n\tElmzBtHSURbz8Q4i13rJBp7FAAZWUXXW+zZjsq3LOyMYJVNJSn4+KLG/VgYWop1Zi4p9Wt/bBaM5d\n\tEctuN+VVn0ojEprnysAzg/ugaoeTcCybXpZ4W/nKwXgKB2WYbuDf/6n7bhWgvfPlKEx84NGqkhP4I\n\t8/f3tGlMg==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=android.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding:content-language; \n\tbh=W/CoUTOZoWNlY1TzeTefjR9H5zi1Lcg5d1uvCR+++L0=;\n\tb=mjCFBr22DPTlWPx4epKwe5EnqPLJcuRFQ/1+AM8Bc0+esZegbFF4W/2Pzz6hG67q+3\n\t6l7fziiIROjZne7tQ7jgJ1ZOC4Zwes/knH/aUpuXglkA1zxrN1M796IeT0SO5YKbxijt\n\t0mskuBSg8R+17JZGvvtxfRaOO/VQwW0tq+2a7v00yhBWpDb2VrniiCtMS2r2XCUDBqfW\n\tMQMXyrvOLjnLNCwjZ7t6B3h0OH3BEeqosqwzlJTdheu1ABwrI5fvN9uhZKQulSNQ7D96\n\tKebNRC3jPAbG9gXGoXdhfz/2XSQcVGelIsmnIDJtUqZQKzVOFARkbl0PhdMNlRu+0zkd\n\tXkMg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding\n\t:content-language;\n\tbh=W/CoUTOZoWNlY1TzeTefjR9H5zi1Lcg5d1uvCR+++L0=;\n\tb=knK0YgZNsTE4OC4IqNuOqY2poI4nhZX5pt04QAkXPH6kEId1qVu1mxVfexzepMki4c\n\tilHO2Kls/ZjSS5auMU/qVZjU/UeIXri6S+tRPWwE348svbKR8x1tuJHj5JdHoeO5TsMB\n\t1uaULxOwy59YUOxSmgVil3+z0QLgp5KIVquSb4B213uHTUeQHX54Ypl72/SKBXshXQFp\n\t9V4NIUJe1POZEUj7DxCIZVkiID2rd9SdyyqDZp8qYorPqzgKmHETNXQdoghWii3oqE5Q\n\tTj+R9UhMQ18eQUPUlCupsif3fMVsyTemn1Hp+U9ZiZPRdRZ46hHTaZsL9ewWW36Dx6DG\n\txdAw==","X-Gm-Message-State":"AMCzsaVT//fvauygq72w2pmin8B0bIcf8BdP5xOeEl4R0BsBG5XE5L0P\n\tO6rkpg2xvnFYr7x6tDDJjQNwpQ==","X-Google-Smtp-Source":"ABhQp+RtgaVP2r0YHKH4gUWRG4nAZM6E+6pHRwxiId40gmzsoPbvDdEZK6D7hbyISZcVhw90MO91fQ==","X-Received":"by 10.36.22.13 with SMTP id a13mr4564185ita.69.1509475361739;\n\tTue, 31 Oct 2017 11:42:41 -0700 (PDT)","Subject":"Re: [PATCH v3 0/3] arm64: Add CONFIG_KUSER_HELPERS","To":"Will Deacon <will.deacon@arm.com>, Kees Cook <keescook@chromium.org>","References":"<20170911152635.95367-1-salyzyn@android.com>\n\t<CAGXu5jK-i_Eqfm1mZ-Kz5dqsKuCt_-MDymkb735VXCV9aOnvwQ@mail.gmail.com>\n\t<20170920091555.GA3782@arm.com>","From":"Mark Salyzyn <salyzyn@android.com>","Message-ID":"<065fd365-4635-ddc7-b683-59a5cb16be8f@android.com>","Date":"Tue, 31 Oct 2017 11:42:39 -0700","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.4.0","MIME-Version":"1.0","In-Reply-To":"<20170920091555.GA3782@arm.com>","Content-Language":"en-US","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171031_114302_815991_49CF9C3E ","X-CRM114-Status":"GOOD (  15.05  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:4001:c06:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mark Rutland <mark.rutland@arm.com>, Jisheng Zhang <jszhang@marvell.com>,\n\tArd Biesheuvel <ard.biesheuvel@linaro.org>,\n\tJohn Stultz <john.stultz@linaro.org>,\n\tAKASHI Takahiro <takahiro.akashi@linaro.org>,\n\tPeter Zijlstra <peterz@infradead.org>,\n\tCatalin Marinas <catalin.marinas@arm.com>, kevin.brodsky@arm.com,\n\tLKML <linux-kernel@vger.kernel.org>, Dave Martin <Dave.Martin@arm.com>,\n\tChristian Borntraeger <borntraeger@de.ibm.com>,\n\tMichal Marek <mmarek@suse.com>, James Morse <james.morse@arm.com>,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>, \n\tcredmonster@gmail.com, Laura Abbott <labbott@redhat.com>,\n\tIngo Molnar <mingo@kernel.org>, zijun_hu <zijun_hu@htc.com>","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]