[{"id":1767079,"web_url":"http://patchwork.ozlabs.org/comment/1767079/","msgid":"<20170912155502.5ee2d753@nial.brq.redhat.com>","list_archive_url":null,"date":"2017-09-12T13:55:02","subject":"Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug\n\tvia device_add","submitter":{"id":11305,"url":"http://patchwork.ozlabs.org/api/people/11305/","name":"Igor Mammedov","email":"imammedo@redhat.com"},"content":"On Mon, 11 Sep 2017 17:21:29 +0200\nDavid Hildenbrand wrote:\n\n> The first patches are a bunch of cleanups. I decided to go the\n> extra mile and implement CPU hotplug via \"device_add\", as well as\n> \"query-hotpluggable-cpus\".\n> \n> On s390x, only complete cores can be plugged. CPU hot unplug is currently\n> not supported by the architecture.\n> \n> Support for hotplugging CPUs in random core-id order (last two patches)\n> is added. We once hat a KVM bug preventing this, but the stable patch\n> should now be included in relevant places - 152e9f65d66f (\"KVM: s390: fix\n> wrong lookup of VCPUs by array index\"). Current tooling will plug them in\n> sequential order anyway, so it should not hurt.\n\ndo you plan to convert hw/s390x/s390-virtio.c machine to possible_cpus as well?\nit's not necessary to enable hotplug on it but sharing code and initializing\ncpus the same way would be plus.\n\n[...]","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=imammedo@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs5v35yQVz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 23:56:47 +1000 (AEST)","from localhost ([::1]:36028 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drlgE-000317-0H\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 09:56:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53539)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drlem-0002IC-JD\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:55:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drleg-00078B-Qy\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:55:16 -0400","from mx1.redhat.com ([209.132.183.28]:38552)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drleg-00077M-Kn\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:55:10 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 75CC9356E2;\n\tTue, 12 Sep 2017 13:55:09 +0000 (UTC)","from nial.brq.redhat.com (unknown [10.43.2.209])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id B9DE977DDD;\n\tTue, 12 Sep 2017 13:55:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 75CC9356E2","Date":"Tue, 12 Sep 2017 15:55:02 +0200","From":"Igor Mammedov ","To":"David Hildenbrand ","Message-ID":"<20170912155502.5ee2d753@nial.brq.redhat.com>","In-Reply-To":"<20170911152150.12535-1-david@redhat.com>","References":"<20170911152150.12535-1-david@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tTue, 12 Sep 2017 13:55:09 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug\n\tvia device_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster , cohuck@redhat.com,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1767080,"web_url":"http://patchwork.ozlabs.org/comment/1767080/","msgid":"<17978d23-82c1-3bf4-23ee-315867fc038d@redhat.com>","list_archive_url":null,"date":"2017-09-12T13:56:17","subject":"Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug\n\tvia device_add","submitter":{"id":70402,"url":"http://patchwork.ozlabs.org/api/people/70402/","name":"David Hildenbrand","email":"david@redhat.com"},"content":"On 12.09.2017 15:55, Igor Mammedov wrote:\n> On Mon, 11 Sep 2017 17:21:29 +0200\n> David Hildenbrand wrote:\n> \n>> The first patches are a bunch of cleanups. I decided to go the\n>> extra mile and implement CPU hotplug via \"device_add\", as well as\n>> \"query-hotpluggable-cpus\".\n>>\n>> On s390x, only complete cores can be plugged. CPU hot unplug is currently\n>> not supported by the architecture.\n>>\n>> Support for hotplugging CPUs in random core-id order (last two patches)\n>> is added. We once hat a KVM bug preventing this, but the stable patch\n>> should now be included in relevant places - 152e9f65d66f (\"KVM: s390: fix\n>> wrong lookup of VCPUs by array index\"). Current tooling will plug them in\n>> sequential order anyway, so it should not hurt.\n> \n> do you plan to convert hw/s390x/s390-virtio.c machine to possible_cpus as well?\n> it's not necessary to enable hotplug on it but sharing code and initializing\n> cpus the same way would be plus.\n\nSee patch #3. s390-virtio.c is an old leftover, the machine doesn't\nexist anymore. So this should be clean.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=david@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs5vT74bDz9s7B\n\tfor ;\n\tTue, 12 Sep 2017 23:57:09 +1000 (AEST)","from localhost ([::1]:36029 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drlga-0003EF-2l\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 09:57:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:53898)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drlfz-0003CV-Aw\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:56:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drlfu-0007Yd-Fw\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:56:31 -0400","from mx1.redhat.com ([209.132.183.28]:36432)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drlfu-0007Y3-Ab\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 09:56:26 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 93A38883BA;\n\tTue, 12 Sep 2017 13:56:24 +0000 (UTC)","from [10.36.117.114] (ovpn-117-114.ams2.redhat.com [10.36.117.114])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CC99D6F426;\n\tTue, 12 Sep 2017 13:56:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 93A38883BA","To":"Igor Mammedov ","References":"<20170911152150.12535-1-david@redhat.com>\n\t<20170912155502.5ee2d753@nial.brq.redhat.com>","From":"David Hildenbrand ","Organization":"Red Hat GmbH","Message-ID":"<17978d23-82c1-3bf4-23ee-315867fc038d@redhat.com>","Date":"Tue, 12 Sep 2017 15:56:17 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170912155502.5ee2d753@nial.brq.redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tTue, 12 Sep 2017 13:56:24 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 00/21] s390x cleanups and CPU hotplug\n\tvia device_add","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Matthew Rosato , thuth@redhat.com,\n\tEduardo Habkost ,\n\tMarkus Armbruster , cohuck@redhat.com,\n\tRichard Henderson ,\n\tqemu-devel@nongnu.org, Alexander Graf ,\n\tborntraeger@de.ibm.com, Paolo Bonzini ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]