[{"id":1766201,"web_url":"http://patchwork.ozlabs.org/comment/1766201/","msgid":"<150512506547.225.9476838140098482777@6d89bd104fc3>","list_archive_url":null,"date":"2017-09-11T10:17:45","subject":"Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nSubject: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup\nMessage-id: 150512483616.8642.15831240906912354238.stgit@bahia.lan\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n * [new tag] patchew/150512483616.8642.15831240906912354238.stgit@bahia.lan -> patchew/150512483616.8642.15831240906912354238.stgit@bahia.lan\nSwitched to a new branch 'test'\nda1ec6583a spapr_pci: don't create 64-bit MMIO window if we don't need to\nf9e9150977 spapr_pci: convert sprintf() to g_strdup_printf()\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/2: spapr_pci: convert sprintf() to g_strdup_printf()...\nChecking PATCH 2/2: spapr_pci: don't create 64-bit MMIO window if we don't need to...\nERROR: spaces required around that '-' (ctx:VxV)\n#54: FILE: hw/ppc/spapr_pci.c:1650:\n+ if (sphb->mem64_win_pciaddr != (hwaddr)-1) {\n ^\n\nERROR: spaces required around that '-' (ctx:VxV)\n#61: FILE: hw/ppc/spapr_pci.c:1657:\n+ if (sphb->mem64_win_addr != (hwaddr)-1) {\n ^\n\ntotal: 2 errors, 0 warnings, 26 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrP650rqlz9s7f\n\tfor ;\n\tMon, 11 Sep 2017 20:18:53 +1000 (AEST)","from localhost ([::1]:56520 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drLnn-0002N7-7a\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 06:18:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57989)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drLnL-0002LQ-U2\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:18:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drLnH-0004l1-HH\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 06:18:23 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21487)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1drLnC-0004gD-0m; Mon, 11 Sep 2017 06:18:14 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1505125065969980.465101422896;\n\tMon, 11 Sep 2017 03:17:45 -0700 (PDT)"],"Resent-Date":"Mon, 11 Sep 2017 06:18:23 -0400","Resent-Message-Id":"","In-Reply-To":"<150512483616.8642.15831240906912354238.stgit@bahia.lan>","Message-ID":"<150512506547.225.9476838140098482777@6d89bd104fc3>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"groug@kaod.org","Date":"Mon, 11 Sep 2017 03:17:45 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"qemu-ppc@nongnu.org, famz@redhat.com, qemu-devel@nongnu.org,\n\tdavid@gibson.dropbear.id.au","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766223,"web_url":"http://patchwork.ozlabs.org/comment/1766223/","msgid":"<20170911130408.3225bbbe@bahia.lan>","list_archive_url":null,"date":"2017-09-11T11:04:08","subject":"Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup","submitter":{"id":69178,"url":"http://patchwork.ozlabs.org/api/people/69178/","name":"Greg Kurz","email":"groug@kaod.org"},"content":"On Mon, 11 Sep 2017 03:17:45 -0700 (PDT)\nno-reply@patchew.org wrote:\n\n> Hi,\n> \n> This series seems to have some coding style problems. See output below for\n> more information:\n> \n> Subject: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup\n> Message-id: 150512483616.8642.15831240906912354238.stgit@bahia.lan\n> Type: series\n> \n> === TEST SCRIPT BEGIN ===\n> #!/bin/bash\n> \n> BASE=base\n> n=1\n> total=$(git log --oneline $BASE.. | wc -l)\n> failed=0\n> \n> git config --local diff.renamelimit 0\n> git config --local diff.renames True\n> \n> commits=\"$(git log --format=%H --reverse $BASE..)\"\n> for c in $commits; do\n> echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n> failed=1\n> echo\n> fi\n> n=$((n+1))\n> done\n> \n> exit $failed\n> === TEST SCRIPT END ===\n> \n> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384\n> From https://github.com/patchew-project/qemu\n> * [new tag] patchew/150512483616.8642.15831240906912354238.stgit@bahia.lan -> patchew/150512483616.8642.15831240906912354238.stgit@bahia.lan\n> Switched to a new branch 'test'\n> da1ec6583a spapr_pci: don't create 64-bit MMIO window if we don't need to\n> f9e9150977 spapr_pci: convert sprintf() to g_strdup_printf()\n> \n> === OUTPUT BEGIN ===\n> Checking PATCH 1/2: spapr_pci: convert sprintf() to g_strdup_printf()...\n> Checking PATCH 2/2: spapr_pci: don't create 64-bit MMIO window if we don't need to...\n> ERROR: spaces required around that '-' (ctx:VxV)\n> #54: FILE: hw/ppc/spapr_pci.c:1650:\n> + if (sphb->mem64_win_pciaddr != (hwaddr)-1) {\n> ^\n> \n> ERROR: spaces required around that '-' (ctx:VxV)\n> #61: FILE: hw/ppc/spapr_pci.c:1657:\n> + if (sphb->mem64_win_addr != (hwaddr)-1) {\n> \n\nFalse positive... Fixable with:\n\n--- a/scripts/checkpatch.pl\n+++ b/scripts/checkpatch.pl\n@@ -213,6 +213,7 @@ our @typeList = (\n qr{${Ident}_handler},\n qr{${Ident}_handler_fn},\n qr{target_(?:u)?long},\n+ qr{hwaddr},\n );\n \n # This can be modified by sub possible. Since it can be empty, be careful\n\n ^\n\n\n> \n> total: 2 errors, 0 warnings, 26 lines checked\n> \n> Your patch has style problems, please review. If any of these errors\n> are false positives report them to the maintainer, see\n> CHECKPATCH in MAINTAINERS.\n> \n> === OUTPUT END ===\n> \n> Test command exited with code: 1\n> \n> \n> ---\n> Email generated automatically by Patchew [http://patchew.org/].\n> Please send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrQ7F3Mckz9s0g\n\tfor ;\n\tMon, 11 Sep 2017 21:04:57 +1000 (AEST)","from localhost ([::1]:56723 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1drMWN-0003v4-Li\n\tfor incoming@patchwork.ozlabs.org; Mon, 11 Sep 2017 07:04:55 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41994)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1drMVp-0003qG-BZ\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:04:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1drMVj-0004vZ-KY\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:04:21 -0400","from 17.mo1.mail-out.ovh.net ([87.98.179.142]:59892)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1drMVj-0004uS-Dw\n\tfor qemu-devel@nongnu.org; Mon, 11 Sep 2017 07:04:15 -0400","from player169.ha.ovh.net (b9.ovh.net [213.186.33.59])\n\tby mo1.mail-out.ovh.net (Postfix) with ESMTP id 6BA3493311\n\tfor ; Mon, 11 Sep 2017 13:04:13 +0200 (CEST)","from bahia.lan (gar31-1-82-66-74-139.fbx.proxad.net [82.66.74.139])\n\t(Authenticated sender: groug@kaod.org)\n\tby player169.ha.ovh.net (Postfix) with ESMTPSA id 60965580095;\n\tMon, 11 Sep 2017 13:04:09 +0200 (CEST)"],"Date":"Mon, 11 Sep 2017 13:04:08 +0200","From":"Greg Kurz ","To":"qemu-devel@nongnu.org","Message-ID":"<20170911130408.3225bbbe@bahia.lan>","In-Reply-To":"<150512506547.225.9476838140098482777@6d89bd104fc3>","References":"<150512483616.8642.15831240906912354238.stgit@bahia.lan>\n\t<150512506547.225.9476838140098482777@6d89bd104fc3>","X-Mailer":"Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tboundary=\"Sig_/nZrH+iY3wyVoz5=wpPQOVkN\";\n\tprotocol=\"application/pgp-signature\"","X-Ovh-Tracer-Id":"7902972925170587968","X-VR-SPAMSTATE":"OK","X-VR-SPAMSCORE":"0","X-VR-SPAMCAUSE":"gggruggvucftvghtrhhoucdtuddrfeelledrgedtgdefjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemuceftddtnecu","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"87.98.179.142","Subject":"Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, famz@redhat.com, david@gibson.dropbear.id.au","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1766847,"web_url":"http://patchwork.ozlabs.org/comment/1766847/","msgid":"<20170912065252.GA7550@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-12T06:52:52","subject":"Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Mon, Sep 11, 2017 at 12:13:56PM +0200, Greg Kurz wrote:\n> ---\n> \n> Greg Kurz (2):\n> spapr_pci: convert sprintf() to g_strdup_printf()\n> spapr_pci: don't create 64-bit MMIO window if we don't need to\n\nApplied to ppc-for-2.11.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"Xifl6hoH\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs1685LGnz9s7g\n\tfor ;\n\tTue, 12 Sep 2017 20:21:04 +1000 (AEST)","from localhost ([::1]:34725 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1driJS-00039z-S1\n\tfor incoming@patchwork.ozlabs.org; Tue, 12 Sep 2017 06:21:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:33425)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1driIx-00039T-N8\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 06:20:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1driIt-000449-OP\n\tfor qemu-devel@nongnu.org; Tue, 12 Sep 2017 06:20:31 -0400","from ozlabs.org ([103.22.144.67]:35839)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1driIt-00041Y-CQ; Tue, 12 Sep 2017 06:20:27 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xs15N71Kmz9sRg; Tue, 12 Sep 2017 20:20:24 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505211624;\n\tbh=CTbdfU2DkOsmg/S4PMr3pdEFmxck22N7bL06vhyPvcI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Xifl6hoH3BhFjRTICCF+6gzOw1JjlNj/4IQKgQb0OK3iKWf9QvX6eGlxy/j3ShCGw\n\tOWta89D0dD8k0huipGyqrW74NIWPKeO+BIQnw4Xgxoem0pWkhs+qgHH60QLTJLo2nG\n\tmlKLyjDGl/f+rZrwxDsxMLiz7wc8ljgH8eoLwo/A=","Date":"Tue, 12 Sep 2017 16:52:52 +1000","From":"David Gibson ","To":"Greg Kurz ","Message-ID":"<20170912065252.GA7550@umbus.fritz.box>","References":"<150512483616.8642.15831240906912354238.stgit@bahia.lan>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"NzB8fVQJ5HfG6fxh\"","Content-Disposition":"inline","In-Reply-To":"<150512483616.8642.15831240906912354238.stgit@bahia.lan>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"103.22.144.67","Subject":"Re: [Qemu-devel] [PATCH 0/2] spapr_pci: some more cleanup","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]