[{"id":1765889,"web_url":"http://patchwork.ozlabs.org/comment/1765889/","msgid":"<20170910014015.GV2735@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-10T01:40:15","subject":"Re: [Qemu-devel] [PATCH 0/5] spapr_pci: various cleanups and\n\timprovements","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Sat, Sep 09, 2017 at 05:05:46PM +0200, Greg Kurz wrote:\n> Before resuming the huge work on PHB hotplug, here are some patches\n> that maybe worth to apply.\n> \n> Patches 1 to 3 are basic improvements.\n\nI've applied these to ppc-for-2.11.\n\n> Patch 4 and 5 may be a bit controversial. Everywhere in the spapr\n> code where we build an FDT portion, libfdt failures cause QEMU to\n> exit, even on hotplug paths. Only spapr_pci doesn't do that and\n> propagates the error instead. My understanding is that a failure\n> when building the FDT is likely to happen because of a bug in QEMU.\n\nStill looking at these.\n\n> \n> Hence the choice to convert spapr_pci to do like the others. We may\n> even consider changing _FDT() to abort() instead of exit().\n> \n> Alternatively, if libfdt failures shouldn't be necessarily fatal,\n> especially on post-realize paths, then we should probably introduce\n> an _FDT_ERR() helper to propagate errors. And use it in may places\n> where we currently terminate QEMU: memory hotplug, CPU hotplug, CAS,\n> machine reset...\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"eRyzpfGa\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqZ4R21KFz9sBZ\n\tfor ;\n\tSun, 10 Sep 2017 11:59:35 +1000 (AEST)","from localhost ([::1]:51431 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqrX3-0000Je-EQ\n\tfor incoming@patchwork.ozlabs.org; Sat, 09 Sep 2017 21:59:33 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:35435)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqrWR-0000Iu-1i\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 21:58:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqrWQ-0002O7-0o\n\tfor qemu-devel@nongnu.org; Sat, 09 Sep 2017 21:58:55 -0400","from ozlabs.org ([2401:3900:2:1::2]:52119)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqrWP-0002Mr-LL; Sat, 09 Sep 2017 21:58:53 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xqZ3W1Jn8z9sQl; Sun, 10 Sep 2017 11:58:47 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505008727;\n\tbh=6dAf3YUeJAyNk2mSoDeOHOXAT/blBNzYKDh0FXAejbk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eRyzpfGa4BQxzZKzk9lfQWlMjZO1v+uVLj3fE91/hoIsuwWchdZSkaHe7WzDCiqNm\n\tG7mbHIDdXsmHi2BVgqUKuCE/z0vergkfr9Ziz7C7na66ziZTbYMdSr0EkRDW/ZvwVp\n\tCgnvcsdEKJTFEp/EtrxVAKm5ndVrF6Bc0DuI8I4o=","Date":"Sun, 10 Sep 2017 11:40:15 +1000","From":"David Gibson ","To":"Greg Kurz ","Message-ID":"<20170910014015.GV2735@umbus.fritz.box>","References":"<150496954641.9654.1998704077006846521.stgit@bahia>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"uOZhbHG+Ruum37TI\"","Content-Disposition":"inline","In-Reply-To":"<150496954641.9654.1998704077006846521.stgit@bahia>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"Re: [Qemu-devel] [PATCH 0/5] spapr_pci: various cleanups and\n\timprovements","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765910,"web_url":"http://patchwork.ozlabs.org/comment/1765910/","msgid":"<20170910071245.GB17405@umbus.fritz.box>","list_archive_url":null,"date":"2017-09-10T07:12:45","subject":"Re: [Qemu-devel] [PATCH 0/5] spapr_pci: various cleanups and\n\timprovements","submitter":{"id":47,"url":"http://patchwork.ozlabs.org/api/people/47/","name":"David Gibson","email":"david@gibson.dropbear.id.au"},"content":"On Sat, Sep 09, 2017 at 05:05:46PM +0200, Greg Kurz wrote:\n> Before resuming the huge work on PHB hotplug, here are some patches\n> that maybe worth to apply.\n> \n> Patches 1 to 3 are basic improvements.\n> \n> Patch 4 and 5 may be a bit controversial. Everywhere in the spapr\n> code where we build an FDT portion, libfdt failures cause QEMU to\n> exit, even on hotplug paths. Only spapr_pci doesn't do that and\n> propagates the error instead. My understanding is that a failure\n> when building the FDT is likely to happen because of a bug in QEMU.\n> \n> Hence the choice to convert spapr_pci to do like the others. We may\n> even consider changing _FDT() to abort() instead of exit().\n> \n> Alternatively, if libfdt failures shouldn't be necessarily fatal,\n> especially on post-realize paths, then we should probably introduce\n> an _FDT_ERR() helper to propagate errors. And use it in may places\n> where we currently terminate QEMU: memory hotplug, CPU hotplug, CAS,\n> machine reset...\n\nI've applied 4 & 5 as well now. If I get to it, I hope to make them\nobsolete by replacing most of the fdt wrangling with a qemu internal\nlive tree representation, but in the meantime it's still a reasonable\ncleanup.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=gibson.dropbear.id.au\n\theader.i=@gibson.dropbear.id.au header.b=\"FI4e9VsH\"; \n\tdkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xqj2Z2j8Jz9sQl\n\tfor ;\n\tSun, 10 Sep 2017 17:13:26 +1000 (AEST)","from localhost ([::1]:51958 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqwQm-0000l6-F8\n\tfor incoming@patchwork.ozlabs.org; Sun, 10 Sep 2017 03:13:24 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:56035)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqwQM-0000km-5X\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 03:12:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqwQK-0000RE-Ve\n\tfor qemu-devel@nongnu.org; Sun, 10 Sep 2017 03:12:58 -0400","from ozlabs.org ([2401:3900:2:1::2]:33283)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqwQK-0000LT-6f; Sun, 10 Sep 2017 03:12:56 -0400","by ozlabs.org (Postfix, from userid 1007)\n\tid 3xqj1v2ZyNz9sRV; Sun, 10 Sep 2017 17:12:51 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n\td=gibson.dropbear.id.au; s=201602; t=1505027571;\n\tbh=T+zIIYY8wmjzH7U84qYvt3Cg3f38QPbbP13dAwBtqQs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FI4e9VsHsxPx/Fe5QS/7Vce7AsxrWj/um8TMOLbbLN0VEdmZhZZmqbb48aqvW528i\n\t9PpyVHVlmWZnEepAxDI8xJ6WssH7VkrlYIJYvS6G+ZQmP61gCFIHESBEC81OjZpGSo\n\tviJkcRhg8F2VwVVL3NMGItQi0DFMQUcdFZhe8LDs=","Date":"Sun, 10 Sep 2017 17:12:45 +1000","From":"David Gibson ","To":"Greg Kurz ","Message-ID":"<20170910071245.GB17405@umbus.fritz.box>","References":"<150496954641.9654.1998704077006846521.stgit@bahia>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"EuxKj2iCbKjpUGkD\"","Content-Disposition":"inline","In-Reply-To":"<150496954641.9654.1998704077006846521.stgit@bahia>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2401:3900:2:1::2","Subject":"Re: [Qemu-devel] [PATCH 0/5] spapr_pci: various cleanups and\n\timprovements","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-ppc@nongnu.org, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]