[{"id":1769080,"web_url":"http://patchwork.ozlabs.org/comment/1769080/","msgid":"<6eff6b50-30e7-fd5f-ef52-a235c398e1f4@canonical.com>","list_archive_url":null,"date":"2017-09-15T09:33:20","subject":"Re: [xenial CVE-2015-8952 0/3] replace mbcache with mbcache2 for\n\text2/ext4","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 09.09.2017 02:25, Thadeu Lima de Souza Cascardo wrote:\n> Third patch needed backport because of context due to commit\n> c6d5612f80923170dad06c04736984cc9bcc8568 (\"ext4: lock the xattr block before checksuming it\").\n> \n> Removal of old mbcache was not included to minimize number of patches.\n> \n> Jan Kara (3):\n> mbcache2: reimplement mbcache\n> ext2: convert to mbcache2\n> ext4: convert to mbcache2\n> \n> fs/Makefile | 2 +-\n> fs/ext2/ext2.h | 3 +\n> fs/ext2/super.c | 25 ++--\n> fs/ext2/xattr.c | 143 +++++++++----------\n> fs/ext2/xattr.h | 21 +--\n> fs/ext4/ext4.h | 2 +-\n> fs/ext4/super.c | 7 +-\n> fs/ext4/xattr.c | 136 +++++++++---------\n> fs/ext4/xattr.h | 5 +-\n> fs/mbcache2.c | 359 +++++++++++++++++++++++++++++++++++++++++++++++\n> include/linux/mbcache2.h | 50 +++++++\n> 11 files changed, 577 insertions(+), 176 deletions(-)\n> create mode 100644 fs/mbcache2.c\n> create mode 100644 include/linux/mbcache2.h\n> \nIt feels a bit excessive to fix that CVE by replacing one cache with another.\nAlso I noticed that in the bugzilla which gets referred to from the CVE data,\nthere are a couple of other changes around the drop of the old code. Those sound\nat least like improving performance.\n\nFor that reason I would at least discuss this with Thadeu next week. And then\ndecide how to go on with this.\n\n-Stefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtqvq22Hwz9s5L;\n\tFri, 15 Sep 2017 19:33:27 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dsmzy-0003rF-SQ; Fri, 15 Sep 2017 09:33:22 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dsmzx-0003r8-J0\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 09:33:21 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dsmzx-000312-BG; Fri, 15 Sep 2017 09:33:21 +0000"],"Subject":"Re: [xenial CVE-2015-8952 0/3] replace mbcache with mbcache2 for\n\text2/ext4","To":"Thadeu Lima de Souza Cascardo ,\n\tkernel-team@lists.ubuntu.com","References":"<20170909002556.23382-1-cascardo@canonical.com>","From":"Stefan Bader ","Message-ID":"<6eff6b50-30e7-fd5f-ef52-a235c398e1f4@canonical.com>","Date":"Fri, 15 Sep 2017 11:33:20 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170909002556.23382-1-cascardo@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============7618529997291899998==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]