[{"id":1765558,"web_url":"http://patchwork.ozlabs.org/comment/1765558/","msgid":"","list_archive_url":null,"date":"2017-09-08T18:01:12","subject":"Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully\n\tsupport the RFC","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/08/2017 12:37 PM, Brandon Carpenter wrote:\n> We've been experiencing issues where the qemu websocket server closes\n> connections from noVNC clients for no apparent reason. Debugging shows\n> that certain web browsers are injecting ping and pong frames when the\n> connection becomes idle. Some browsers send those frames without a\n> payload, which also is causing closure. This patch series addresses\n> these issues by making the websocket server more conformant to RFC\n> 6455 - The WebSocket Protocol.\n\nmeta-comment: sending v2 in-reply-to v1 makes it harder for automated\ntooling to recognize that you are sending new patches. We prefer that\nv2 be a top-level thread. More patch submission hints at:\nhttps://wiki.qemu.org/index.php/Contribute/SubmitAPatch","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx05.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xplWp4YWBz9ryk\n\tfor ;\n\tSat, 9 Sep 2017 04:01:58 +1000 (AEST)","from localhost ([::1]:46793 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqNbI-0004Oe-Os\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 14:01:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57025)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqNan-0004Mq-7M\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:01:26 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqNai-0000qZ-Ni\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:01:25 -0400","from mx1.redhat.com ([209.132.183.28]:45122)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqNai-0000ps-Ev\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:01:20 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 412B7751;\n\tFri, 8 Sep 2017 18:01:19 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id CF748171EB;\n\tFri, 8 Sep 2017 18:01:18 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 412B7751","To":"Brandon Carpenter ,\n\tqemu-devel@nongnu.org","References":"<20170724184217.21381-1-brandon.carpenter@cypherpath.com>\n\t<20170724181544.20292-1-brandon.carpenter@cypherpath.com>\n\t<20170908173801.15205-1-brandon.carpenter@cypherpath.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Fri, 8 Sep 2017 13:01:12 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170908173801.15205-1-brandon.carpenter@cypherpath.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"k369ocbiKRFh1loKjOgiQNNdsnNANO2ev\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.29]);\n\tFri, 08 Sep 2017 18:01:19 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully\n\tsupport the RFC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765560,"web_url":"http://patchwork.ozlabs.org/comment/1765560/","msgid":"<1504894281.1214.0@smtp.gmail.com>","list_archive_url":null,"date":"2017-09-08T18:11:21","subject":"Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully\n\tsupport the RFC","submitter":{"id":72031,"url":"http://patchwork.ozlabs.org/api/people/72031/","name":"Brandon Carpenter","email":"brandon.carpenter@cypherpath.com"},"content":"My apologies. I read that document before submitting the patch, but \nthere was a lot to take in. Would you like me to resend the patch \nwithout the references?\n--\nBrandon Carpenter | Software Engineer\nCypherpath, Inc.\n400 Columbia Point Drive Ste 101 | Richland, Washington USA\nOffice: (650) 713-3060\n\nOn Fri, Sep 8, 2017 at 11:01 AM, Eric Blake wrote:\n> On 09/08/2017 12:37 PM, Brandon Carpenter wrote:\n>> We've been experiencing issues where the qemu websocket server \n>> closes\n>> connections from noVNC clients for no apparent reason. Debugging \n>> shows\n>> that certain web browsers are injecting ping and pong frames when \n>> the\n>> connection becomes idle. Some browsers send those frames without a\n>> payload, which also is causing closure. This patch series addresses\n>> these issues by making the websocket server more conformant to RFC\n>> 6455 - The WebSocket Protocol.\n> \n> meta-comment: sending v2 in-reply-to v1 makes it harder for automated\n> tooling to recognize that you are sending new patches. We prefer that\n> v2 be a top-level thread. More patch submission hints at:\n> https://wiki.qemu.org/index.php/Contribute/SubmitAPatch\n> \n> --\n> Eric Blake, Principal Software Engineer\n> Red Hat, Inc. +1-919-301-3266\n> Virtualization: qemu.org | libvirt.org\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=cypherpath.com header.i=@cypherpath.com\n\theader.b=\"I+uHyvyU\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpllF5myqz9sBZ\n\tfor ;\n\tSat, 9 Sep 2017 04:11:52 +1000 (AEST)","from localhost ([::1]:46816 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqNks-0008Kd-90\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 14:11:50 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34314)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from )\n\tid 1dqNkV-0008KT-Mg\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:11:28 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from )\n\tid 1dqNkS-0000EE-GZ\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:11:27 -0400","from mail-pf0-x234.google.com ([2607:f8b0:400e:c00::234]:34464)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqNkS-0000Dx-8v\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:11:24 -0400","by mail-pf0-x234.google.com with SMTP id e1so5671078pfk.1\n\tfor ; Fri, 08 Sep 2017 11:11:24 -0700 (PDT)","from [10.10.7.25] (68-113-0-218.static.knwc.wa.charter.com.\n\t[68.113.0.218]) by smtp.gmail.com with ESMTPSA id\n\ta25sm5840456pfg.111.2017.09.08.11.11.22\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 08 Sep 2017 11:11:22 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cypherpath.com; s=google;\n\th=date:from:subject:to:cc:message-id:in-reply-to:references\n\t:mime-version; bh=9IZ1A6HiIsU0AmBtn9ywyVx0WTthfwbUY4xh4hZivN4=;\n\tb=I+uHyvyU3oNnkTbZsrt8WA9KAfvUQTgFZpPZyCK8VwLPufptRhEbCiRcTUwFpiy6mW\n\taLCW9e4KZ8449cywpS/8CmA55cvW3XuRuRerWYhxuCrVzdz1wKDJqHn9FO35nfBUfgtO\n\tVC5dhulM06K4EWit1vfXAyCBZgE5Y+HORW8fk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:subject:to:cc:message-id:in-reply-to\n\t:references:mime-version;\n\tbh=9IZ1A6HiIsU0AmBtn9ywyVx0WTthfwbUY4xh4hZivN4=;\n\tb=YZmPU/uoasr9TGnpRzAq2JaB8xMJ4Kz4AaqYBvPcB62bcK4IJUw0/j5t2CEmQNz/Mx\n\teSCgkjjkynh5Vj6TKCD4FMjrjIte0s+gxsTwlAHvb87T4jRI3Tjcnr3Om8jNoE5c1s66\n\tNvzkupn0ZLEAH3azVkJiji647KsMe0gXg2DxgushV5cyPNg/mqxdZyeQdqMjMAt0a/Xm\n\ta39rGFkhjY6Ho92V79hvaPZuj8e55bF03lMhz6i6SE+XfJ0TyxwI+yd2y9KcL6J3CViR\n\tvcOYzXQyGqy4WVpUqM+2h2NIlQd4WJCBYvAaODwMQW5L8VH4tDKVmXcdSR71zD8VsAWx\n\tkY3Q==","X-Gm-Message-State":"AHPjjUjKaGzOh6kAeVWzeWdLRmOdYOgPGhMtNA9wZh/9HULYiQHLqJKZ\n\tbIZYjQS6j9jLGGbe9jASsRxXx3PMq0yYZYp1pLjIIguyz5AsSNmPy/N5xaaXBuueYwow66iVNLU\n\t=","X-Google-Smtp-Source":"ADKCNb5EMpivMBrWyxSTaOK9l3mtC5qTnDiJDAV9kzE0zIaa6dv/VQBvZWJGgqMV8zIwt4nTAx3mQg==","X-Received":"by 10.84.201.6 with SMTP id u6mr163949pld.289.1504894283279;\n\tFri, 08 Sep 2017 11:11:23 -0700 (PDT)","Date":"Fri, 08 Sep 2017 11:11:21 -0700","From":"Brandon Carpenter ","To":"Eric Blake ","Message-Id":"<1504894281.1214.0@smtp.gmail.com>","In-Reply-To":"","References":"<20170724184217.21381-1-brandon.carpenter@cypherpath.com>\n\t<20170724181544.20292-1-brandon.carpenter@cypherpath.com>\n\t<20170908173801.15205-1-brandon.carpenter@cypherpath.com>\n\t","X-Mailer":"geary/makepkg~g00718198","MIME-Version":"1.0","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2607:f8b0:400e:c00::234","Content-Type":"text/plain; charset=\"US-ASCII\"; format=flowed","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully\n\tsupport the RFC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1765562,"web_url":"http://patchwork.ozlabs.org/comment/1765562/","msgid":"<508bf463-445b-415b-7cdc-edd165867a69@redhat.com>","list_archive_url":null,"date":"2017-09-08T18:15:20","subject":"Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully\n\tsupport the RFC","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/08/2017 01:11 PM, Brandon Carpenter wrote:\n> My apologies. I read that document before submitting the patch, but\n> there was a lot to take in. Would you like me to resend the patch\n> without the references?\n\nNot a problem - we all had to submit our first patch at some point in\ntime in the past :)\n\nRe-sending at this point shouldn't be necessary unless a maintainer\nspecifically asks for it; it's more information for next time (if you\nhave to send a v3, for whatever reason).\n\n\n> \n> CONFIDENTIALITY NOTICE: This e-mail message, including any attachments,\n> is for the sole use of the intended recipient(s) and may contain\n> proprietary, confidential or privileged information or otherwise be\n> protected by law. Any unauthorized review, use, disclosure or\n> distribution is prohibited. If you are not the intended recipient,\n> please notify the sender and destroy all copies and the original message.\n\nBy the way, your employer's disclaimer is unenforceable on a\npublicly-archived mailing list; still, it may be worth replying from a\nperson account to avoid the risk of someone refusing to reply to your\nmail on principle.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xplql2RrHz9sDB\n\tfor ;\n\tSat, 9 Sep 2017 04:15:47 +1000 (AEST)","from localhost ([::1]:46826 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqNof-0001E0-CQ\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 14:15:45 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36055)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqNoM-0001Dm-S2\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:15:27 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqNoJ-0003ZL-Mk\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:15:26 -0400","from mx1.redhat.com ([209.132.183.28]:50180)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dqNoJ-0003YJ-DQ\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 14:15:23 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 5B28181E0F;\n\tFri, 8 Sep 2017 18:15:22 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id C3BDE5EDE3;\n\tFri, 8 Sep 2017 18:15:21 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 5B28181E0F","To":"Brandon Carpenter ","References":"<20170724184217.21381-1-brandon.carpenter@cypherpath.com>\n\t<20170724181544.20292-1-brandon.carpenter@cypherpath.com>\n\t<20170908173801.15205-1-brandon.carpenter@cypherpath.com>\n\t\n\t<1504894281.1214.0@smtp.gmail.com>","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"<508bf463-445b-415b-7cdc-edd165867a69@redhat.com>","Date":"Fri, 8 Sep 2017 13:15:20 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<1504894281.1214.0@smtp.gmail.com>","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"UVEHLF53x3V7j6vTwO6X9cDe3uChAa9D1\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 08 Sep 2017 18:15:22 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully\n\tsupport the RFC","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]