[{"id":1766304,"web_url":"http://patchwork.ozlabs.org/comment/1766304/","msgid":"<7140806a-6535-38e3-fd08-2a3a1f7b49df@canonical.com>","list_archive_url":null,"date":"2017-09-11T13:30:15","subject":"ACK: [SRU][Vivid][PATCH 0/1] CIFS: Fix maximum SMB2 header size","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/","name":"Colin Ian King","email":"colin.king@canonical.com"},"content":"On 08/09/17 14:09, Joseph Salisbury wrote:\n> BugLink: http://bugs.launchpad.net/bugs/1713884\n> \n> == SRU Justification ==\n> Currently the maximum size of SMB2/3 header is set incorrectly which\n> leads to hanging of directory listing operations on encrypted SMB3\n> connections. Fix this by setting the maximum size to 170 bytes that\n> is calculated as RFC1002 length field size (4) + transform header\n> size (52) + SMB2 header size (64) + create response size (56).\n> \n> This bug is fixed by commit 9e37b1784f2be9397a903307574ee565bbadfd75 which is in \n> mainline as of 4.13 final.\n> \n> Commit 9e37b1784f2b is needed in X, Z and A as well. However, there are context diffs\n> from Vivid, so their SRUs will be sent separatly.\n> \n> \n> == Fix ==\n> commit 9e37b1784f2be9397a903307574ee565bbadfd75\n> Author: Pavel Shilovsky \n> Date: Thu Aug 24 15:16:40 2017 -0700\n> \n> CIFS: Fix maximum SMB2 header size\n> \n> == Regression Potential ==\n> Patch is specific to to CIFS and only increases MAX_SMB2_HDR_SIZE.\n> \n> Patch submitted to kernel stable trees, so it will also be reivewed by a wider audience \n> upstream.\n> \n> == Test Case ==\n> A test kernel was built with this patch and tested by the original bug reporter.\n> The bug reporter states the test kernel resolved the bug.\n> \n> \n> Pavel Shilovsky (1):\n> CIFS: Fix maximum SMB2 header size\n> \n> fs/cifs/smb2pdu.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \nAcked-by: Colin Ian King ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xrTM34J8Bz9s83;\n\tMon, 11 Sep 2017 23:30:23 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1drOn3-0004Es-BO; Mon, 11 Sep 2017 13:30:17 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1drOn2-0004Eb-Im\n\tfor kernel-team@lists.ubuntu.com; Mon, 11 Sep 2017 13:30:16 +0000","from 1.general.cking.uk.vpn ([10.172.193.212])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1drOn2-0000wD-80; Mon, 11 Sep 2017 13:30:16 +0000"],"Subject":"ACK: [SRU][Vivid][PATCH 0/1] CIFS: Fix maximum SMB2 header size","To":"kernel-team@lists.ubuntu.com","References":"","From":"Colin Ian King ","Message-ID":"<7140806a-6535-38e3-fd08-2a3a1f7b49df@canonical.com>","Date":"Mon, 11 Sep 2017 14:30:15 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1769201,"web_url":"http://patchwork.ozlabs.org/comment/1769201/","msgid":"<75bd26f1-252d-1cee-8ece-c340a087eb22@canonical.com>","list_archive_url":null,"date":"2017-09-15T13:46:32","subject":"REJECTED: [SRU][Vivid][PATCH 0/1] CIFS: Fix maximum SMB2 header size","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 08.09.2017 15:09, Joseph Salisbury wrote:\n> BugLink: http://bugs.launchpad.net/bugs/1713884\n> \n> == SRU Justification ==\n> Currently the maximum size of SMB2/3 header is set incorrectly which\n> leads to hanging of directory listing operations on encrypted SMB3\n> connections. Fix this by setting the maximum size to 170 bytes that\n> is calculated as RFC1002 length field size (4) + transform header\n> size (52) + SMB2 header size (64) + create response size (56).\n> \n> This bug is fixed by commit 9e37b1784f2be9397a903307574ee565bbadfd75 which is in \n> mainline as of 4.13 final.\n> \n> Commit 9e37b1784f2b is needed in X, Z and A as well. However, there are context diffs\n> from Vivid, so their SRUs will be sent separatly.\n> \n> \n> == Fix ==\n> commit 9e37b1784f2be9397a903307574ee565bbadfd75\n> Author: Pavel Shilovsky \n> Date: Thu Aug 24 15:16:40 2017 -0700\n> \n> CIFS: Fix maximum SMB2 header size\n> \n> == Regression Potential ==\n> Patch is specific to to CIFS and only increases MAX_SMB2_HDR_SIZE.\n> \n> Patch submitted to kernel stable trees, so it will also be reivewed by a wider audience \n> upstream.\n> \n> == Test Case ==\n> A test kernel was built with this patch and tested by the original bug reporter.\n> The bug reporter states the test kernel resolved the bug.\n> \n> \n> Pavel Shilovsky (1):\n> CIFS: Fix maximum SMB2 header size\n> \n> fs/cifs/smb2pdu.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \nVivid is EOL and only gets ESM support.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtxWy0myhz9sxR;\n\tFri, 15 Sep 2017 23:46:38 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dsqx0-0002Yg-BL; Fri, 15 Sep 2017 13:46:34 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dsqwz-0002YS-7p\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 13:46:33 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dsqwy-0005go-WC\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 13:46:33 +0000"],"Subject":"REJECTED: [SRU][Vivid][PATCH 0/1] CIFS: Fix maximum SMB2 header size","To":"kernel-team@lists.ubuntu.com","References":"","From":"Stefan Bader ","Message-ID":"<75bd26f1-252d-1cee-8ece-c340a087eb22@canonical.com>","Date":"Fri, 15 Sep 2017 15:46:32 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============2717338525395254614==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]