[{"id":1765342,"web_url":"http://patchwork.ozlabs.org/comment/1765342/","msgid":"<20170908131446.GP18365@amd>","list_archive_url":null,"date":"2017-09-08T13:14:46","subject":"Re: [PATCH 1/3] as3645a: Use ams,\n\tinput-max-microamp as documented in DT bindings","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Fri 2017-09-08 15:42:11, Sakari Ailus wrote:\n> DT bindings document the property \"ams,input-max-microamp\" that limits the\n> chip's maximum input current. The driver and the DTS however used\n> \"peak-current-limit\" property. Fix this by using the property documented\n> in DT binding documentation.\n> \n> Signed-off-by: Sakari Ailus \n\nAcked-by: Pavel Machek ","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpd8X0JNfz9ryk\n\tfor ;\n\tFri, 8 Sep 2017 23:14:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755838AbdIHNOt (ORCPT\n\t);\n\tFri, 8 Sep 2017 09:14:49 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41754 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755463AbdIHNOs (ORCPT\n\t); Fri, 8 Sep 2017 09:14:48 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 0D723824F1; Fri, 8 Sep 2017 15:14:46 +0200 (CEST)"],"Date":"Fri, 8 Sep 2017 15:14:46 +0200","From":"Pavel Machek ","To":"Sakari Ailus ","Cc":"linux-media@vger.kernel.org, linux-leds@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 1/3] as3645a: Use ams,\n\tinput-max-microamp as documented in DT bindings","Message-ID":"<20170908131446.GP18365@amd>","References":"<20170908124213.18904-1-sakari.ailus@linux.intel.com>\n\t<20170908124213.18904-2-sakari.ailus@linux.intel.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"1BKOZKwX7DAU5odC\"","Content-Disposition":"inline","In-Reply-To":"<20170908124213.18904-2-sakari.ailus@linux.intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1765345,"web_url":"http://patchwork.ozlabs.org/comment/1765345/","msgid":"<20170908131758.GQ18365@amd>","list_archive_url":null,"date":"2017-09-08T13:17:58","subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Fri 2017-09-08 15:42:13, Sakari Ailus wrote:\n> Use integer numbers for LEDs, 0 is the flash and 1 is the indicator.\n> \n> Signed-off-by: Sakari Ailus \n\nDunno. Old code is shorter, old device tree is shorter, ... IMO both\nversions are fine, because the LEDs are really different. Do we have\ndocumentation somewhere saying that reg= should be used for this? Are\nyou doing this for consistency?\n\nBest regards,\n\t\t\t\t\t\t\t\t\tPavel\n\n> arch/arm/boot/dts/omap3-n950-n9.dtsi | 8 ++++++--\n> drivers/leds/leds-as3645a.c | 26 ++++++++++++++++++++++++--\n\n\n> @@ -267,15 +267,19 @@\n> \tclock-frequency = <400000>;\n> \n> \tas3645a@30 {\n> +\t\t#address-cells = <1>;\n> +\t\t#size-cells = <0>;\n> \t\treg = <0x30>;\n> \t\tcompatible = \"ams,as3645a\";\n> -\t\tflash {\n> +\t\tflash@0 {\n> +\t\t\treg = <0x0>;\n> \t\t\tflash-timeout-us = <150000>;\n> \t\t\tflash-max-microamp = <320000>;\n> \t\t\tled-max-microamp = <60000>;\n> \t\t\tams,input-max-microamp = <1750000>;\n> \t\t};\n> -\t\tindicator {\n> +\t\tindicator@1 {\n> +\t\t\treg = <0x1>;\n> \t\t\tled-max-microamp = <10000>;\n> \t\t};\n> \t};\n> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c\n> index e3f89c6130d2..605e0c64e974 100644\n> --- a/drivers/leds/leds-as3645a.c\n> +++ b/drivers/leds/leds-as3645a.c\n> @@ -112,6 +112,10 @@\n> #define AS_PEAK_mA_TO_REG(a) \\\n> \t((min_t(u32, AS_PEAK_mA_MAX, a) - 1250) / 250)\n> \n> +/* LED numbers for Devicetree */\n> +#define AS_LED_FLASH\t\t\t\t0\n> +#define AS_LED_INDICATOR\t\t\t1\n> +\n> enum as_mode {\n> \tAS_MODE_EXT_TORCH = 0 << AS_CONTROL_MODE_SETTING_SHIFT,\n> \tAS_MODE_INDICATOR = 1 << AS_CONTROL_MODE_SETTING_SHIFT,\n> @@ -491,10 +495,29 @@ static int as3645a_parse_node(struct as3645a *flash,\n> \t\t\t struct device_node *node)\n> {\n> \tstruct as3645a_config *cfg = &flash->cfg;\n> +\tstruct device_node *child;\n> \tconst char *name;\n> \tint rval;\n> \n> -\tflash->flash_node = of_get_child_by_name(node, \"flash\");\n> +\tfor_each_child_of_node(node, child) {\n> +\t\tu32 id = 0;\n> +\n> +\t\tof_property_read_u32(child, \"reg\", &id);\n> +\n> +\t\tswitch (id) {\n> +\t\tcase AS_LED_FLASH:\n> +\t\t\tflash->flash_node = of_node_get(child);\n> +\t\t\tbreak;\n> +\t\tcase AS_LED_INDICATOR:\n> +\t\t\tflash->indicator_node = of_node_get(child);\n> +\t\t\tbreak;\n> +\t\tdefault:\n> +\t\t\tdev_warn(&flash->client->dev,\n> +\t\t\t\t \"unknown LED %u encountered, ignoring\\n\", id);\n> +\t\t\tbreak;\n> +\t\t}\n> +\t}\n> +\n> \tif (!flash->flash_node) {\n> \t\tdev_err(&flash->client->dev, \"can't find flash node\\n\");\n> \t\treturn -ENODEV;\n> @@ -538,7 +561,6 @@ static int as3645a_parse_node(struct as3645a *flash,\n> \t\t\t &cfg->peak);\n> \tcfg->peak = AS_PEAK_mA_TO_REG(cfg->peak);\n> \n> -\tflash->indicator_node = of_get_child_by_name(node, \"indicator\");\n> \tif (!flash->indicator_node) {\n> \t\tdev_warn(&flash->client->dev,\n> \t\t\t \"can't find indicator node\\n\");","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpdDC1Jzrz9s7f\n\tfor ;\n\tFri, 8 Sep 2017 23:18:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755765AbdIHNSB (ORCPT\n\t);\n\tFri, 8 Sep 2017 09:18:01 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41856 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755013AbdIHNSA (ORCPT\n\t); Fri, 8 Sep 2017 09:18:00 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 2C975824F3; Fri, 8 Sep 2017 15:17:59 +0200 (CEST)"],"Date":"Fri, 8 Sep 2017 15:17:58 +0200","From":"Pavel Machek ","To":"Sakari Ailus ","Cc":"linux-media@vger.kernel.org, linux-leds@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","Message-ID":"<20170908131758.GQ18365@amd>","References":"<20170908124213.18904-1-sakari.ailus@linux.intel.com>\n\t<20170908124213.18904-4-sakari.ailus@linux.intel.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"wr1Q/2bz0MCWWNYv\"","Content-Disposition":"inline","In-Reply-To":"<20170908124213.18904-4-sakari.ailus@linux.intel.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1765362,"web_url":"http://patchwork.ozlabs.org/comment/1765362/","msgid":"<20170908132333.rlhurlwrzq43ss2k@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-08T13:23:34","subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"Hi Pavel,\n\nThanks for the review.\n\nOn Fri, Sep 08, 2017 at 03:17:58PM +0200, Pavel Machek wrote:\n> On Fri 2017-09-08 15:42:13, Sakari Ailus wrote:\n> > Use integer numbers for LEDs, 0 is the flash and 1 is the indicator.\n> > \n> > Signed-off-by: Sakari Ailus \n> \n> Dunno. Old code is shorter, old device tree is shorter, ... IMO both\n> versions are fine, because the LEDs are really different. Do we have\n> documentation somewhere saying that reg= should be used for this? Are\n> you doing this for consistency?\n\nWell, actually for ACPI support. :-) It requires less driver changes this\nway. See 17th and 18th patches in \"[PATCH v9 00/23] Unified fwnode endpoint\nparser, async sub-device notifier support, N9 flash DTS\".\n\nA number of chips have LED binding that is aligned, see e.g.\nDocumentation/devicetree/bindings/leds/leds-bcm6328.txt .","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpdcK6Jppz9s7p\n\tfor ;\n\tFri, 8 Sep 2017 23:35:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1755778AbdIHNf0 (ORCPT\n\t);\n\tFri, 8 Sep 2017 09:35:26 -0400","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:47906 \"EHLO\n\thillosipuli.retiisi.org.uk\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S933298AbdIHNXg (ORCPT\n\t); Fri, 8 Sep 2017 09:23:36 -0400","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id 7BD4D60104;\n\tFri, 8 Sep 2017 16:23:34 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dqJFu-00035G-5M; Fri, 08 Sep 2017 16:23:34 +0300"],"Date":"Fri, 8 Sep 2017 16:23:34 +0300","From":"Sakari Ailus ","To":"Pavel Machek ","Cc":"Sakari Ailus ,\n\tlinux-media@vger.kernel.org, linux-leds@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","Message-ID":"<20170908132333.rlhurlwrzq43ss2k@valkosipuli.retiisi.org.uk>","References":"<20170908124213.18904-1-sakari.ailus@linux.intel.com>\n\t<20170908124213.18904-4-sakari.ailus@linux.intel.com>\n\t<20170908131758.GQ18365@amd>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170908131758.GQ18365@amd>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1765366,"web_url":"http://patchwork.ozlabs.org/comment/1765366/","msgid":"<20170908133841.GS18365@amd>","list_archive_url":null,"date":"2017-09-08T13:38:41","subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"On Fri 2017-09-08 16:23:34, Sakari Ailus wrote:\n> Hi Pavel,\n> \n> Thanks for the review.\n> \n> On Fri, Sep 08, 2017 at 03:17:58PM +0200, Pavel Machek wrote:\n> > On Fri 2017-09-08 15:42:13, Sakari Ailus wrote:\n> > > Use integer numbers for LEDs, 0 is the flash and 1 is the indicator.\n> > > \n> > > Signed-off-by: Sakari Ailus \n> > \n> > Dunno. Old code is shorter, old device tree is shorter, ... IMO both\n> > versions are fine, because the LEDs are really different. Do we have\n> > documentation somewhere saying that reg= should be used for this? Are\n> > you doing this for consistency?\n> \n> Well, actually for ACPI support. :-) It requires less driver changes this\n> way. See 17th and 18th patches in \"[PATCH v9 00/23] Unified fwnode endpoint\n> parser, async sub-device notifier support, N9 flash DTS\".\n\nACPI, I hate ACPI.\n\n> A number of chips have LED binding that is aligned, see e.g.\n> Documentation/devicetree/bindings/leds/leds-bcm6328.txt .\n\nOk, yes, that's common way LED controllers are handled. Usually all\nthe LEDs are \"same\", but...\n\nAcked-by: Pavel Machek \n\n\t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpdh92cJ8z9s7p\n\tfor ;\n\tFri, 8 Sep 2017 23:38:49 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756111AbdIHNip (ORCPT\n\t);\n\tFri, 8 Sep 2017 09:38:45 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:42467 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1755563AbdIHNin (ORCPT\n\t); Fri, 8 Sep 2017 09:38:43 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid ECA6A824F7; Fri, 8 Sep 2017 15:38:41 +0200 (CEST)"],"Date":"Fri, 8 Sep 2017 15:38:41 +0200","From":"Pavel Machek ","To":"Sakari Ailus ","Cc":"Sakari Ailus ,\n\tlinux-media@vger.kernel.org, linux-leds@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","Message-ID":"<20170908133841.GS18365@amd>","References":"<20170908124213.18904-1-sakari.ailus@linux.intel.com>\n\t<20170908124213.18904-4-sakari.ailus@linux.intel.com>\n\t<20170908131758.GQ18365@amd>\n\t<20170908132333.rlhurlwrzq43ss2k@valkosipuli.retiisi.org.uk>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"3sseE1tnmEs+TkKq\"","Content-Disposition":"inline","In-Reply-To":"<20170908132333.rlhurlwrzq43ss2k@valkosipuli.retiisi.org.uk>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1765377,"web_url":"http://patchwork.ozlabs.org/comment/1765377/","msgid":"<20170908134507.7tniq6rfrpbvb45z@valkosipuli.retiisi.org.uk>","list_archive_url":null,"date":"2017-09-08T13:45:08","subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","submitter":{"id":1593,"url":"http://patchwork.ozlabs.org/api/people/1593/","name":"Sakari Ailus","email":"sakari.ailus@iki.fi"},"content":"On Fri, Sep 08, 2017 at 03:38:41PM +0200, Pavel Machek wrote:\n> On Fri 2017-09-08 16:23:34, Sakari Ailus wrote:\n> > Hi Pavel,\n> > \n> > Thanks for the review.\n> > \n> > On Fri, Sep 08, 2017 at 03:17:58PM +0200, Pavel Machek wrote:\n> > > On Fri 2017-09-08 15:42:13, Sakari Ailus wrote:\n> > > > Use integer numbers for LEDs, 0 is the flash and 1 is the indicator.\n> > > > \n> > > > Signed-off-by: Sakari Ailus \n> > > \n> > > Dunno. Old code is shorter, old device tree is shorter, ... IMO both\n> > > versions are fine, because the LEDs are really different. Do we have\n> > > documentation somewhere saying that reg= should be used for this? Are\n> > > you doing this for consistency?\n> > \n> > Well, actually for ACPI support. :-) It requires less driver changes this\n> > way. See 17th and 18th patches in \"[PATCH v9 00/23] Unified fwnode endpoint\n> > parser, async sub-device notifier support, N9 flash DTS\".\n> \n> ACPI, I hate ACPI.\n\n:-D\n\n> \n> > A number of chips have LED binding that is aligned, see e.g.\n> > Documentation/devicetree/bindings/leds/leds-bcm6328.txt .\n> \n> Ok, yes, that's common way LED controllers are handled. Usually all\n> the LEDs are \"same\", but...\n\nI presume that's the case with most LED driver chips: all the outputs are\nalike.\n\n> \n> Acked-by: Pavel Machek \n\nThanks!","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpdqc5stQz9s83\n\tfor ;\n\tFri, 8 Sep 2017 23:45:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S932934AbdIHNpM (ORCPT );\n\tFri, 8 Sep 2017 09:45:12 -0400","from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:48550 \"EHLO\n\thillosipuli.retiisi.org.uk\" rhost-flags-OK-OK-OK-FAIL)\n\tby vger.kernel.org with ESMTP id S932891AbdIHNpL (ORCPT\n\t); Fri, 8 Sep 2017 09:45:11 -0400","from valkosipuli.localdomain (valkosipuli.retiisi.org.uk\n\t[IPv6:2001:1bc8:1a6:d3d5::80:2])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby hillosipuli.retiisi.org.uk (Postfix) with ESMTPS id F2AC6600C3;\n\tFri, 8 Sep 2017 16:45:08 +0300 (EEST)","from sakke by valkosipuli.localdomain with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dqJam-00036P-EJ; Fri, 08 Sep 2017 16:45:08 +0300"],"Date":"Fri, 8 Sep 2017 16:45:08 +0300","From":"Sakari Ailus ","To":"Pavel Machek ","Cc":"Sakari Ailus ,\n\tlinux-media@vger.kernel.org, linux-leds@vger.kernel.org,\n\tdevicetree@vger.kernel.org","Subject":"Re: [PATCH 3/3] as3645a: Use integer numbers for parsing LEDs","Message-ID":"<20170908134507.7tniq6rfrpbvb45z@valkosipuli.retiisi.org.uk>","References":"<20170908124213.18904-1-sakari.ailus@linux.intel.com>\n\t<20170908124213.18904-4-sakari.ailus@linux.intel.com>\n\t<20170908131758.GQ18365@amd>\n\t<20170908132333.rlhurlwrzq43ss2k@valkosipuli.retiisi.org.uk>\n\t<20170908133841.GS18365@amd>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170908133841.GS18365@amd>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1765608,"web_url":"http://patchwork.ozlabs.org/comment/1765608/","msgid":"<4b4517bc-e215-ef48-3431-1fc2396034cd@gmail.com>","list_archive_url":null,"date":"2017-09-08T19:51:22","subject":"Re: [PATCH 0/3] AS3645A fixes","submitter":{"id":66885,"url":"http://patchwork.ozlabs.org/api/people/66885/","name":"Jacek Anaszewski","email":"jacek.anaszewski@gmail.com"},"content":"Hi Sakari,\n\nThanks for the patch set.\n\nOn 09/08/2017 02:42 PM, Sakari Ailus wrote:\n> Hi folks,\n> \n> Here are a few fixes for the as3645a DTS as well as changes in bindings.\n> The driver is not in a release yet. I'd like to get these in as through\n> the media tree fixes branch.\n> \n> Sakari Ailus (3):\n> as3645a: Use ams,input-max-microamp as documented in DT bindings\n> dt: bindings: as3645a: Use LED number to refer to LEDs\n> as3645a: Use integer numbers for parsing LEDs\n> \n> .../devicetree/bindings/leds/ams,as3645a.txt | 28 ++++++++++++++--------\n> arch/arm/boot/dts/omap3-n950-n9.dtsi | 10 +++++---\n> drivers/leds/leds-as3645a.c | 28 +++++++++++++++++++---\n> 3 files changed, 50 insertions(+), 16 deletions(-)\n> \n\nAcked-by: Jacek Anaszewski ","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"qPuusldg\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpnz85fhQz9sCZ\n\tfor ;\n\tSat, 9 Sep 2017 05:52:20 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757048AbdIHTwT (ORCPT\n\t);\n\tFri, 8 Sep 2017 15:52:19 -0400","from mail-wr0-f195.google.com ([209.85.128.195]:34995 \"EHLO\n\tmail-wr0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1757011AbdIHTwR (ORCPT\n\t); Fri, 8 Sep 2017 15:52:17 -0400","by mail-wr0-f195.google.com with SMTP id n64so1655378wrb.2;\n\tFri, 08 Sep 2017 12:52:16 -0700 (PDT)","from [192.168.1.18] (dkt172.neoplus.adsl.tpnet.pl. [83.24.23.172])\n\tby smtp.gmail.com with ESMTPSA id\n\tr72sm2496943wmb.9.2017.09.08.12.52.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 08 Sep 2017 12:52:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:references:cc:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=c24jiKs0xSyN2qMN5Q3uw2eSuiQDn+SdqT2979Y06aY=;\n\tb=qPuusldglhRZaElz2N2OBwudBjKf/sysrnQ9RHtU3LP8gkWkxj3JKIofyTTzi5kKgF\n\tg5xjkRMUS1GOBxe0t2p7tLKlV6qN9Kd85VFDwFY+GdnI2G0Bl3KZC4wEHGQYC5Z/VoeP\n\tyu+S95dMnPmJES2ghKQ+1LyK53ew5XLR1CLiWjEl5W+37HmcpCEO2mDp+caiMQSH4SM8\n\tD/pmL8oFwjVB2SezaQioMKjmBFtCfkuvVZ8RC6v14A818SYEIXjr4EWNqpbXhKPo3bRh\n\t/XNHPCdU1A0tJxLS5aeEv8cwSNKYSv7j9a2y66qblHaStjW/cxRzCsFuaMjFuom0Plak\n\tAWkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:references:cc:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-transfer-encoding;\n\tbh=c24jiKs0xSyN2qMN5Q3uw2eSuiQDn+SdqT2979Y06aY=;\n\tb=LM7EivMrJsgjrhse8S9Uu8QAU21kGmls0YFAVaoqkm7sr38p/CEQHF2K84y+1xOU30\n\tmhiA7AKfqTkNxafdidgIGTHSjtWOb0zwe833kp889Hbw2alC0LbzK6KQI9qDTHDBl+HS\n\txXtKwn+heSmdAn5YO1SiUXeTSDT0qxvmBU3aO1C84TxCzQkx5zsyVUzM+1iP5CdOqgID\n\tI2xBOPt1foTCIMM3Tz1i+ofDjrRv77krOBxo5EVW7cpiRbFw2mZdCXkPCwAaMF8V6thn\n\tmUTo7pGy6Jdp1vrJzYBvbffwVsYzGmklu7VAQTS45jeuPYuL0m0T66Vqhq36MF2JJqiZ\n\tJbrw==","X-Gm-Message-State":"AHPjjUj+rDQl5vJkv495rVuBReoC85NbmWLEr3R5tAcV5l5DGyPMKWO2\n\tZjwOmZ2WIZUG1MKvGC0=","X-Google-Smtp-Source":"ADKCNb4V8GtMr7aqVpoU170u+EsmbpRC0y82WG+aeiRYI54rDWL1F/hhwQxE9vWF2FkkswlWos634g==","X-Received":"by 10.223.156.143 with SMTP id d15mr2844641wre.180.1504900335911;\n\tFri, 08 Sep 2017 12:52:15 -0700 (PDT)","Subject":"Re: [PATCH 0/3] AS3645A fixes","To":"Sakari Ailus , linux-media@vger.kernel.org","References":"<20170908124213.18904-1-sakari.ailus@linux.intel.com>","Cc":"linux-leds@vger.kernel.org, devicetree@vger.kernel.org","From":"Jacek Anaszewski ","Message-ID":"<4b4517bc-e215-ef48-3431-1fc2396034cd@gmail.com>","Date":"Fri, 8 Sep 2017 21:51:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<20170908124213.18904-1-sakari.ailus@linux.intel.com>","Content-Type":"text/plain; charset=windows-1252","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]