[{"id":1765196,"web_url":"http://patchwork.ozlabs.org/comment/1765196/","msgid":"<150486278080.210.2380735069955690933@6d89bd104fc3>","list_archive_url":null,"date":"2017-09-08T09:26:21","subject":"Re: [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up \"make\n\ttest\" with docker","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nSubject: [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up \"make test\" with docker\nMessage-id: 20170908091700.14867-1-famz@redhat.com\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n * [new tag] patchew/20170908091700.14867-1-famz@redhat.com -> patchew/20170908091700.14867-1-famz@redhat.com\n t [tag update] patchew/cover.1504228916.git.alistair.francis@xilinx.com -> patchew/cover.1504228916.git.alistair.francis@xilinx.com\nSwitched to a new branch 'test'\n0c7a642a86 tests: Move i386 tcg tests to check-tcg\n44226ca4fd buildsys: Add \"check-tcg\" target\ne670c4e114 tests: Build fix for linux-test\n09fbbd7842 tests: Build fix for hello-i386\n0546399a8a docker: Add fedora-i386-cross image\n5a8cd21a02 docker: Add \"cc\" subcommand\n89d4346f6e Makefile: Rename TARGET_DIRS to TARGET_LIST\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/7: Makefile: Rename TARGET_DIRS to TARGET_LIST...\nChecking PATCH 2/7: docker: Add \"cc\" subcommand...\nChecking PATCH 3/7: docker: Add fedora-i386-cross image...\nChecking PATCH 4/7: tests: Build fix for hello-i386...\nERROR: externs should be avoided in .c files\n#20: FILE: tests/tcg/hello-i386.c:23:\n+void _start(void);\n\ntotal: 1 errors, 0 warnings, 7 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 5/7: tests: Build fix for linux-test...\nERROR: if this code is redundant consider removing it\n#141: FILE: tests/tcg/linux-test.c:326:\n+#if 0\n\ntotal: 1 errors, 0 warnings, 179 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 6/7: buildsys: Add \"check-tcg\" target...\nChecking PATCH 7/7: tests: Move i386 tcg tests to check-tcg...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xpX9G365kz9ryv\n\tfor ;\n\tFri, 8 Sep 2017 19:30:10 +1000 (AEST)","from localhost ([::1]:44103 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dqFc0-0008Ce-EH\n\tfor incoming@patchwork.ozlabs.org; Fri, 08 Sep 2017 05:30:08 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57531)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dqFYl-0005ph-P1\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:26:52 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dqFYg-0000uf-EJ\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:26:47 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21360)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dqFYg-0000sc-6j\n\tfor qemu-devel@nongnu.org; Fri, 08 Sep 2017 05:26:42 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1504862781586339.2900979973085;\n\tFri, 8 Sep 2017 02:26:21 -0700 (PDT)"],"Resent-Date":"Fri, 08 Sep 2017 05:26:47 -0400","Resent-Message-Id":"","In-Reply-To":"<20170908091700.14867-1-famz@redhat.com>","Message-ID":"<150486278080.210.2380735069955690933@6d89bd104fc3>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"famz@redhat.com","Date":"Fri, 8 Sep 2017 02:26:21 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH RFC 0/7] Proof of concept to power up \"make\n\ttest\" with docker","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"peter.maydell@linaro.org, thuth@redhat.com, famz@redhat.com,\n\tqemu-devel@nongnu.org, f4bug@amsat.org,\n\tprogrammingkidx@gmail.com, crosa@redhat.com, pbonzini@redhat.com,\n\talex.bennee@linaro.org, rth@twiddle.net","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]