[{"id":1765162,"web_url":"http://patchwork.ozlabs.org/comment/1765162/","msgid":"<20170908085405.GB16834@amd>","list_archive_url":null,"date":"2017-09-08T08:54:05","subject":"Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> From: Tristram Ha \n> \n> This series of patches is to modify the original KSZ9477 DSA driver so that other KSZ switch drivers can be added and use the common code.\n> \n\nPlease wrap the lines from time to time...\n\n\n> This patch set is against net-next.\n> \n> drivers/net/dsa/microchip/Makefile | 2 +-\n> drivers/net/dsa/microchip/ksz9477.c | 1317 ++++++++++++++++++++++++++++++++\n\nWe already have ksz_9477_reg.h. So should this be ksz_9477.c for consistency?\n\n> drivers/net/dsa/microchip/ksz_common.c | 1156 +---------------------------\n> drivers/net/dsa/microchip/ksz_priv.h | 105 ++-\n> drivers/net/dsa/microchip/ksz_spi.c | 13 +-\n> net/dsa/tag_ksz.c | 40 +-","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpWMy1s54z9sBW\n\tfor ;\n\tFri, 8 Sep 2017 18:54:22 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756217AbdIHIyI (ORCPT );\n\tFri, 8 Sep 2017 04:54:08 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:33373 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1754751AbdIHIyG (ORCPT\n\t); Fri, 8 Sep 2017 04:54:06 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid 5ADD2824E9; Fri, 8 Sep 2017 10:54:05 +0200 (CEST)"],"Date":"Fri, 8 Sep 2017 10:54:05 +0200","From":"Pavel Machek ","To":"Tristram.Ha@microchip.com","Cc":"andrew@lunn.ch, muvarov@gmail.com, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","Message-ID":"<20170908085405.GB16834@amd>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218B7@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219F8@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"bCsyhTFzCvuiizWE\"","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD411219F8@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765360,"web_url":"http://patchwork.ozlabs.org/comment/1765360/","msgid":"<87lglpz5ah.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","list_archive_url":null,"date":"2017-09-08T13:30:30","subject":"Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","submitter":{"id":15889,"url":"http://patchwork.ozlabs.org/api/people/15889/","name":"Vivien Didelot","email":"vivien.didelot@savoirfairelinux.com"},"content":"Hi Tristram,\n\nTristram.Ha@microchip.com writes:\n\n> From: Tristram Ha \n>\n> This series of patches is to modify the original KSZ9477 DSA driver so that other KSZ switch drivers can be added and use the common code.\n\nPlease see Documentation/process/submitting-patches.rst. Use a correct\nformatting for the messages, and send you patchset as a thread.\n\n> This patch set is against net-next.\n\nThe net subsystem is somehow special. Please see\nDocumentation/networking/netdev-FAQ.txt. The tree must be indicated in\nthe subject prefix of the patch series.\n\n\nThanks,\n\n Vivien","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpdZq5Hf8z9s7p\n\tfor ;\n\tFri, 8 Sep 2017 23:34:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1756523AbdIHNd5 (ORCPT );\n\tFri, 8 Sep 2017 09:33:57 -0400","from mail.savoirfairelinux.com ([208.88.110.44]:41842 \"EHLO\n\tmail.savoirfairelinux.com\" rhost-flags-OK-OK-OK-OK) by\n\tvger.kernel.org with ESMTP id S1756492AbdIHNdz (ORCPT\n\t); Fri, 8 Sep 2017 09:33:55 -0400","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id 48A459C19D8;\n\tFri, 8 Sep 2017 09:33:54 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10032)\n\twith ESMTP id oByekjhwWVtt; Fri, 8 Sep 2017 09:33:53 -0400 (EDT)","from localhost (localhost [127.0.0.1])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTP id A147B9C19ED;\n\tFri, 8 Sep 2017 09:33:53 -0400 (EDT)","from mail.savoirfairelinux.com ([127.0.0.1])\n\tby localhost (mail.savoirfairelinux.com [127.0.0.1]) (amavisd-new,\n\tport 10026)\n\twith ESMTP id jT4zfu3QdBBp; Fri, 8 Sep 2017 09:33:53 -0400 (EDT)","from localhost (unknown [192.168.49.192])\n\tby mail.savoirfairelinux.com (Postfix) with ESMTPSA id 778599C19D8;\n\tFri, 8 Sep 2017 09:33:53 -0400 (EDT)"],"X-Virus-Scanned":"amavisd-new at mail.savoirfairelinux.com","From":"Vivien Didelot ","To":"Tristram.Ha@microchip.com, andrew@lunn.ch, muvarov@gmail.com,\n\tpavel@ucw.cz, nathan.leigh.conrad@gmail.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD411219F8@CHN-SV-EXMX02.mchp-main.com>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218B7@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219F8@CHN-SV-EXMX02.mchp-main.com>","Date":"Fri, 08 Sep 2017 09:30:30 -0400","Message-ID":"<87lglpz5ah.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1765674,"web_url":"http://patchwork.ozlabs.org/comment/1765674/","msgid":"<93AF473E2DA327428DE3D46B72B1E9FD41122FFB@CHN-SV-EXMX02.mchp-main.com>","list_archive_url":null,"date":"2017-09-09T01:10:31","subject":"RE: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","submitter":{"id":72262,"url":"http://patchwork.ozlabs.org/api/people/72262/","name":"","email":"Tristram.Ha@microchip.com"},"content":"> -----Original Message-----\n> From: Pavel Machek [mailto:pavel@ucw.cz]\n> Sent: Friday, September 08, 2017 1:54 AM\n> To: Tristram Ha - C24268\n> Cc: andrew@lunn.ch; muvarov@gmail.com; nathan.leigh.conrad@gmail.com;\n> vivien.didelot@savoirfairelinux.com; f.fainelli@gmail.com;\n> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Woojung Huh -\n> C21699\n> Subject: Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to\n> add other KSZ switch drivers.\n> \n> Hi!\n> \n> > From: Tristram Ha \n> >\n> > This series of patches is to modify the original KSZ9477 DSA driver so that\n> other KSZ switch drivers can be added and use the common code.\n> >\n> \n> Please wrap the lines from time to time...\n> \n> \n> > This patch set is against net-next.\n> >\n> > drivers/net/dsa/microchip/Makefile | 2 +-\n> > drivers/net/dsa/microchip/ksz9477.c | 1317\n> ++++++++++++++++++++++++++++++++\n> \n> We already have ksz_9477_reg.h. So should this be ksz_9477.c for\n> consistency?\n\nThe product name is KSZ9477 and other switches are also like KSZ####,\nso I would prefer to have no separation between KSZ and the product\nnumber. I think the file ksz_9477_reg.h was named that way because\nthe other files were named ksz_common.c and ksz_spi.c. If need to\nwe can change the file name.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xpx2t55n5z9sBZ\n\tfor ;\n\tSat, 9 Sep 2017 11:11:02 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757293AbdIIBKt convert rfc822-to-8bit (ORCPT\n\t);\n\tFri, 8 Sep 2017 21:10:49 -0400","from esa1.microchip.iphmx.com ([68.232.147.91]:50865 \"EHLO\n\tesa1.microchip.iphmx.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1757173AbdIIBKs (ORCPT\n\t); Fri, 8 Sep 2017 21:10:48 -0400","from smtpout.microchip.com (HELO email.microchip.com)\n\t([198.175.253.82])\n\tby esa1.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t08 Sep 2017 18:10:32 -0700","from CHN-SV-EXMX02.mchp-main.com ([fe80::7dfe:3761:863e:3963]) by\n\tCHN-SV-EXCH07.mchp-main.com ([fe80::ad3d:8f75:7e60:e60f%15]) with\n\tmapi id 14.03.0352.000; Fri, 8 Sep 2017 18:10:32 -0700"],"X-IronPort-AV":"E=Sophos;i=\"5.42,364,1500966000\"; d=\"scan'208\";a=\"7242144\"","From":"","To":"","CC":", , ,\n\t, ,\n\t, ,\n\t","Subject":"RE: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","Thread-Topic":"[PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to\n\tadd other KSZ switch drivers.","Thread-Index":"AdMoGlj1Ldl7+iqrS5WSqulTsgvH7QAAfMUgACeZpoAAEyjakA==","Date":"Sat, 9 Sep 2017 01:10:31 +0000","Message-ID":"<93AF473E2DA327428DE3D46B72B1E9FD41122FFB@CHN-SV-EXMX02.mchp-main.com>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218B7@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219F8@CHN-SV-EXMX02.mchp-main.com>\n\t<20170908085405.GB16834@amd>","In-Reply-To":"<20170908085405.GB16834@amd>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-originating-ip":"[10.10.76.4]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}},{"id":1777103,"web_url":"http://patchwork.ozlabs.org/comment/1777103/","msgid":"<20170928152451.GD2482@amd>","list_archive_url":null,"date":"2017-09-28T15:24:51","subject":"Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","submitter":{"id":2109,"url":"http://patchwork.ozlabs.org/api/people/2109/","name":"Pavel Machek","email":"pavel@ucw.cz"},"content":"Hi!\n\n> > > drivers/net/dsa/microchip/Makefile | 2 +-\n> > > drivers/net/dsa/microchip/ksz9477.c | 1317\n> > ++++++++++++++++++++++++++++++++\n> > \n> > We already have ksz_9477_reg.h. So should this be ksz_9477.c for\n> > consistency?\n> \n> The product name is KSZ9477 and other switches are also like KSZ####,\n> so I would prefer to have no separation between KSZ and the product\n> number. I think the file ksz_9477_reg.h was named that way because\n> the other files were named ksz_common.c and ksz_spi.c. If need to\n> we can change the file name.\n\nI don't care either way, but please make it consistent.\n\nThanks,\n\t\t\t\t\t\t\t\t\tPavel","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y2z5g1wynz9tXd\n\tfor ;\n\tFri, 29 Sep 2017 01:25:11 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753452AbdI1PZE (ORCPT );\n\tThu, 28 Sep 2017 11:25:04 -0400","from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49011 \"EHLO\n\tatrey.karlin.mff.cuni.cz\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752130AbdI1PZD (ORCPT\n\t); Thu, 28 Sep 2017 11:25:03 -0400","by atrey.karlin.mff.cuni.cz (Postfix, from userid 512)\n\tid A7C61824A5; Thu, 28 Sep 2017 17:25:01 +0200 (CEST)"],"Date":"Thu, 28 Sep 2017 17:24:51 +0200","From":"Pavel Machek ","To":"Tristram.Ha@microchip.com","Cc":"andrew@lunn.ch, muvarov@gmail.com, nathan.leigh.conrad@gmail.com,\n\tvivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,\n\tnetdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tWoojung.Huh@microchip.com","Subject":"Re: [PATCH RFC 0/6] Modify KSZ9477 DSA driver in preparation to add\n\tother KSZ switch drivers.","Message-ID":"<20170928152451.GD2482@amd>","References":"<93AF473E2DA327428DE3D46B72B1E9FD411218B7@CHN-SV-EXMX02.mchp-main.com>\n\t<93AF473E2DA327428DE3D46B72B1E9FD411219F8@CHN-SV-EXMX02.mchp-main.com>\n\t<20170908085405.GB16834@amd>\n\t<93AF473E2DA327428DE3D46B72B1E9FD41122FFB@CHN-SV-EXMX02.mchp-main.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"uxuisgdDHaNETlh8\"","Content-Disposition":"inline","In-Reply-To":"<93AF473E2DA327428DE3D46B72B1E9FD41122FFB@CHN-SV-EXMX02.mchp-main.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]