[{"id":1765699,"web_url":"http://patchwork.ozlabs.org/comment/1765699/","msgid":"<20170908.205426.624386613610674398.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-09T03:54:26","subject":"Re: [V2 PATCH net-next 0/2] Fixes for XDP_REDIRECT map","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Jesper Dangaard Brouer \nDate: Thu, 07 Sep 2017 14:33:08 +0200\n\n> This my V2 of catching XDP_REDIRECT and bpf_redirect_map() API usage\n> that can potentially crash the kernel. Addressed Daniels feedback in\n> patch01, and added patch02 which catch and cleanup dangling map\n> pointers.\n> \n> I know John and Daniel are working on a more long-term solution, of\n> recording the bpf_prog pointer together with the map pointer. I just\n> wanted to propose these fixes as a stop-gap to the potential crashes.\n\nJesper if these are still relevant, please resubmit against the 'net'\ntree, thanks!","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xq0gT3FBdz9s8J\n\tfor ;\n\tSat, 9 Sep 2017 13:54:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1757444AbdIIDy2 (ORCPT );\n\tFri, 8 Sep 2017 23:54:28 -0400","from shards.monkeyblade.net ([184.105.139.130]:43006 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753213AbdIIDy0 (ORCPT\n\t); Fri, 8 Sep 2017 23:54:26 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id 554B9136D5A7A;\n\tFri, 8 Sep 2017 20:54:26 -0700 (PDT)"],"Date":"Fri, 08 Sep 2017 20:54:26 -0700 (PDT)","Message-Id":"<20170908.205426.624386613610674398.davem@davemloft.net>","To":"brouer@redhat.com","Cc":"netdev@vger.kernel.org, borkmann@iogearbox.net,\n\tjohn.fastabend@gmail.com, andy@greyhouse.net","Subject":"Re: [V2 PATCH net-next 0/2] Fixes for XDP_REDIRECT map","From":"David Miller ","In-Reply-To":"<150478756604.28665.6915020425359475729.stgit@firesoul>","References":"<150478756604.28665.6915020425359475729.stgit@firesoul>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 08 Sep 2017 20:54:26 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]