[{"id":1764734,"web_url":"http://patchwork.ozlabs.org/comment/1764734/","msgid":"","list_archive_url":null,"date":"2017-09-07T13:35:13","subject":"Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition\n\tof actions enum","submitter":{"id":6591,"url":"http://patchwork.ozlabs.org/api/people/6591/","name":"Eric Blake","email":"eblake@redhat.com"},"content":"On 09/07/2017 03:05 AM, Michal Privoznik wrote:\n> diff to v4:\n> - in 3/3 compare passed action string case insensitively to the qapi enum\n> \n> Michal Privoznik (3):\n> qapi: Rename WatchdogExpirationAction enum\n> watchdog.h: Drop local redefinition of actions enum\n> watchdog: Allow setting action on the fly\n\nReviewed-by: Eric Blake \n\n> \n> hw/watchdog/watchdog.c | 65 ++++++++++++++++++++++++-----------------------\n> hw/watchdog/wdt_diag288.c | 6 ++---\n> include/sysemu/watchdog.h | 12 ++-------\n> monitor.c | 4 +--\n> qapi-schema.json | 9 +++++++\n> qapi/run-state.json | 6 ++---\n> 6 files changed, 52 insertions(+), 50 deletions(-)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=eblake@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp23X1skdz9sRV\n\tfor ;\n\tThu, 7 Sep 2017 23:53:28 +1000 (AEST)","from localhost ([::1]:40589 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpxFG-00061C-3G\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 09:53:26 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60591)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpwxr-000743-FB\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:35:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpwxh-0002op-Uv\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:35:27 -0400","from mx1.redhat.com ([209.132.183.28]:29864)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpwxh-0002o2-Lz\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:35:17 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id A817561476\n\tfor ; Thu, 7 Sep 2017 13:35:16 +0000 (UTC)","from [10.10.120.228] (ovpn-120-228.rdu2.redhat.com [10.10.120.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 1879365EBA;\n\tThu, 7 Sep 2017 13:35:14 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com A817561476","To":"Michal Privoznik , qemu-devel@nongnu.org","References":"","From":"Eric Blake ","Openpgp":"url=http://people.redhat.com/eblake/eblake.gpg","Organization":"Red Hat, Inc.","Message-ID":"","Date":"Thu, 7 Sep 2017 08:35:13 -0500","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\";\n\tboundary=\"q9EahWrMljjgQXC4XhCWbKMTC5U9WNhu8\"","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 07 Sep 2017 13:35:16 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","X-Content-Filtered-By":"Mailman/MimeDel 2.1.21","Subject":"Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition\n\tof actions enum","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764737,"web_url":"http://patchwork.ozlabs.org/comment/1764737/","msgid":"<87vaku62oe.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-09-07T13:47:29","subject":"Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition\n\tof actions enum","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Michal Privoznik writes:\n\n> diff to v4:\n> - in 3/3 compare passed action string case insensitively to the qapi enum\n\nIn 2/3, actually.\n\nSeries\nReviewed-by: Markus Armbruster ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xp26m2qkTz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 23:56:16 +1000 (AEST)","from localhost ([::1]:40607 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpxHy-0000ni-HS\n\tfor incoming@patchwork.ozlabs.org; Thu, 07 Sep 2017 09:56:14 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38981)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpx9d-0001DH-MO\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:47:42 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpx9Z-00040K-7f\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:47:37 -0400","from mx1.redhat.com ([209.132.183.28]:56126)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpx9Z-0003yl-1e\n\tfor qemu-devel@nongnu.org; Thu, 07 Sep 2017 09:47:33 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 2F88A356DB\n\tfor ; Thu, 7 Sep 2017 13:47:31 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id F00276031A;\n\tThu, 7 Sep 2017 13:47:30 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 77B401138645; Thu, 7 Sep 2017 15:47:29 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 2F88A356DB","From":"Markus Armbruster ","To":"Michal Privoznik ","References":"","Date":"Thu, 07 Sep 2017 15:47:29 +0200","In-Reply-To":" (Michal Privoznik's\n\tmessage of \"Thu, 7 Sep 2017 10:05:23 +0200\")","Message-ID":"<87vaku62oe.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tThu, 07 Sep 2017 13:47:31 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition\n\tof actions enum","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1773583,"web_url":"http://patchwork.ozlabs.org/comment/1773583/","msgid":"<7296576e-9f52-f385-7bde-d5c6d9de71b7@redhat.com>","list_archive_url":null,"date":"2017-09-22T13:14:47","subject":"Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition\n\tof actions enum","submitter":{"id":11888,"url":"http://patchwork.ozlabs.org/api/people/11888/","name":"Michal Prívozník","email":"mprivozn@redhat.com"},"content":"On 09/07/2017 10:05 AM, Michal Privoznik wrote:\n> diff to v4:\n> - in 3/3 compare passed action string case insensitively to the qapi enum\n> \n> Michal Privoznik (3):\n> qapi: Rename WatchdogExpirationAction enum\n> watchdog.h: Drop local redefinition of actions enum\n> watchdog: Allow setting action on the fly\n> \n> hw/watchdog/watchdog.c | 65 ++++++++++++++++++++++++-----------------------\n> hw/watchdog/wdt_diag288.c | 6 ++---\n> include/sysemu/watchdog.h | 12 ++-------\n> monitor.c | 4 +--\n> qapi-schema.json | 9 +++++++\n> qapi/run-state.json | 6 ++---\n> 6 files changed, 52 insertions(+), 50 deletions(-)\n> \n\nThanks for all the reviews. What do I need to get it pushed ;-)\n\nMichal","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=208.118.235.17; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mprivozn@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [208.118.235.17])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xzDVW20lFz9sP1\n\tfor ;\n\tFri, 22 Sep 2017 23:15:15 +1000 (AEST)","from localhost ([::1]:58865 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dvNnU-00058K-OP\n\tfor incoming@patchwork.ozlabs.org; Fri, 22 Sep 2017 09:15:12 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41663)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dvNnC-00058E-Kp\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:14:55 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dvNn9-0000aM-9H\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:14:54 -0400","from mx1.redhat.com ([209.132.183.28]:38878)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dvNn9-0000Zh-2I\n\tfor qemu-devel@nongnu.org; Fri, 22 Sep 2017 09:14:51 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 612677E43E\n\tfor ; Fri, 22 Sep 2017 13:14:49 +0000 (UTC)","from [10.43.2.192] (unknown [10.43.2.192])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id D6DB3619FF;\n\tFri, 22 Sep 2017 13:14:48 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 612677E43E","From":"Michal Privoznik ","To":"qemu-devel@nongnu.org","References":"","Message-ID":"<7296576e-9f52-f385-7bde-d5c6d9de71b7@redhat.com>","Date":"Fri, 22 Sep 2017 15:14:47 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 22 Sep 2017 13:14:49 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition\n\tof actions enum","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"armbru@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]