[{"id":1764390,"web_url":"http://patchwork.ozlabs.org/comment/1764390/","msgid":"","list_archive_url":null,"date":"2017-09-06T21:24:57","subject":"Re: [PATCH 3/3] phy: rockchip-typec: Do the calibration more\n\tcorrectly","submitter":{"id":9763,"url":"http://patchwork.ozlabs.org/api/people/9763/","name":"Doug Anderson","email":"dianders@chromium.org"},"content":"Hi,\n\nOn Wed, Sep 6, 2017 at 1:52 PM, Douglas Anderson wrote:\n> Calculate the calibration code as per the docs. The docs talk about\n> reading and averaging the pullup and pulldown calibration codes. They\n> also talk about adding in some adjustment codes. Let's do what the\n> docs say.\n>\n> In practice this doesn't seem to matter a whole lot. On a device I\n> tested the pullup and pulldown codes were nearly the same (0x23 and\n> 0x24) and the adjustment codes were 0.\n>\n> Reviewed-by: Chris Zhong \n> Signed-off-by: Douglas Anderson \n> ---\n>\n> drivers/phy/rockchip/phy-rockchip-typec.c | 28 +++++++++++++++++++---------\n> 1 file changed, 19 insertions(+), 9 deletions(-)\n>\n> diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c\n> index b8696a7c45fb..e59983a82dcc 100644\n> --- a/drivers/phy/rockchip/phy-rockchip-typec.c\n> +++ b/drivers/phy/rockchip/phy-rockchip-typec.c\n> @@ -194,6 +194,7 @@\n> /* Use this for \"n\" in macros like \"_MULT_XXX\" to target the aux channel */\n> #define AUX_CH_LANE 8\n>\n> +\n\nNot sure how I missed that this was adding a blank line here. :( If\nthere are no other issues I'm happy to re-post or happy if this blank\nline is removed when the patch is applied. Please let me know which\nyou'd prefer.\n\n-Doug","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"dm+rL+aT\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"D/5XPiKV\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"LxsZDr72\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnc7X6TLNz9sRY\n\tfor ;\n\tThu, 7 Sep 2017 07:25:28 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dphp7-0001Hm-FF; Wed, 06 Sep 2017 21:25:25 +0000","from mail-wr0-x22b.google.com ([2a00:1450:400c:c0c::22b])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dphp3-0008TG-Bv for linux-arm-kernel@lists.infradead.org;\n\tWed, 06 Sep 2017 21:25:23 +0000","by mail-wr0-x22b.google.com with SMTP id o42so5517843wrb.3\n\tfor ;\n\tWed, 06 Sep 2017 14:24:59 -0700 (PDT)","by 10.28.47.143 with HTTP; Wed, 6 Sep 2017 14:24:57 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=RcodoJvahDJZXD2ALJW2fl9MpN2BPa9+hLtS7P6sN/c=;\n\tb=dm+rL+aTHbVZWA\n\tc0HFOc9LmneWapK2qLgk/v2isBEdaYWnncheJmOepdbPO9ClqZ4WB81Yei+Dhqgrj1zOqNsm82Aqo\n\tU17rGhe7rYlWFlcqI3sExHvDBP74p3XaAVb4jxKB8x/S0OsRGkVevS6eOamAxa7bWEqMZZcik8SCx\n\t5VHl6y+80dFZY5qbV/4V5aToh+mOYPYQMz+O7lonDUfCEGW7Ud6JRX0bLgo6amY3rQVt02WoMmmyB\n\tZN729os8BLAj2Ojte+ISsisSX7XmpAYX34pT8LbaCZ5P+myR0+i8Kn8LlUK1zNXDIbUmnB0JjQCmX\n\tPaH3SacgK7GMIwEqXajw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=KFkOUxM5pub9VAFXV8lUwyIICjZ21BgPowp8ghyroOY=;\n\tb=D/5XPiKV/inIG6KSQWJNIB+xVXJoXhCO8DQdK1ZcaN9d7H8HoRc6J8w/L4XxywD9e7\n\tYdnDtYAZeZdbGzb65ZGDTGW9UUu/3DDtMIujPrs5YMeB00okuE9EffiJomqWgE2FFMeO\n\tkbiEr5Pnw3oZ4Yv+A8dEmDyvmKgAvuv7R/nllbQhw/jmb0UYBZ4Q1T7V3jWqIgb2q0UI\n\tAruN+Jb+QX9ui/9NQOeVOCp+DnpCakNMuaCT1FBsQ0aujNDltXg+13yuT/F5KB40bp8V\n\tYhdPGzV0giv5LmpL5R/DZlsYywNcGzh15qT+bMRyuYzdkAQpiYhnKMgpTgPLcEY2LU1+\n\t775g==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=KFkOUxM5pub9VAFXV8lUwyIICjZ21BgPowp8ghyroOY=;\n\tb=LxsZDr72vTZte/DsDac13ewlo+nvrxpw+aqdj6JW2n1hSx9+5xSZIfKU4kGPazOewk\n\tIfWhB2nlXhpfSj4LQy93p521axx+Ubvj5ebKoo47zEAMUEnjkhdf6C+E2dHDStfUk5A/\n\t/S4yjx/49RngdZYvxK5YuX6D6xxdSwAj6ChgY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=KFkOUxM5pub9VAFXV8lUwyIICjZ21BgPowp8ghyroOY=;\n\tb=R1gSQWqmsUGFhOms2K7g5WlN0VTDE7AhWHVYdU9lbJ1pKKfT5+BjCLFXo7kj35aUEB\n\t1y2ooBKsTlcAe1+auZ6f7wU4wVZpkEyNhHnciloUoxcSl2+09NcIektRQfLaCCxGxD4D\n\t8ZEDpI3PLYwR/wccMxb5/hIhzM4LcOeyaeMySQIf7XzgRbR7KO4Swk2wX5P3GLJgifyI\n\twamgFpEBg1rWRKD1NUnBornqF4ko8Athd+H7P5PdC8+jS9w9Fd5rO9jqbuRzAc1LaxXn\n\tFLk34SCuL0Q5uMOVxTFhDZeH2QD1IJ0jIoSvOeraxX32S4tfxuiZ6NHLMLJO/PSrFqI+\n\tR6qg==","X-Gm-Message-State":"AHPjjUh69zw41mqHCD3tDvAtEafewdXC+KX5sW/sfNhjvbW3j34fI1hX\n\tUINCq7hmxLRUtCwSUXUsIR0zXkg+QlKV9nv8TU3OEQ==","X-Google-Smtp-Source":"ADKCNb6m2Wrlwm19GGSz36eCjweL/Zxk8k6/xJze0dNfdRMbA6bYr5FpQIFCQ7vxafzzKxxTzsZ4MziV2sNsNJhO8ZM=","X-Received":"by 10.223.171.206 with SMTP id s72mr282746wrc.27.1504733098007; \n\tWed, 06 Sep 2017 14:24:58 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170906205201.16207-4-dianders@chromium.org>","References":"<20170906205201.16207-1-dianders@chromium.org>\n\t<20170906205201.16207-4-dianders@chromium.org>","From":"Doug Anderson ","Date":"Wed, 6 Sep 2017 14:24:57 -0700","X-Google-Sender-Auth":"dCiwt50cFC2egtHkbv0lRxhfwaI","Message-ID":"","Subject":"Re: [PATCH 3/3] phy: rockchip-typec: Do the calibration more\n\tcorrectly","To":"Kishon Vijay Abraham I , =?utf-8?q?Heiko_St=C3=BCbner?=\n\t, Chris ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170906_142521_620184_33E0AF45 ","X-CRM114-Status":"GOOD ( 16.17 )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:22b listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Shawn Nematbakhsh ,\n\tDouglas Anderson ,\n\tDavid Schneider ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\t\"open list:ARM/Rockchip SoC...\" , \n\t\"linux-arm-kernel@lists.infradead.org\"\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]