[{"id":1764819,"web_url":"http://patchwork.ozlabs.org/comment/1764819/","msgid":"<20170907163009.GQ5024@atomide.com>","list_archive_url":null,"date":"2017-09-07T16:30:13","subject":"Re: [PATCH v3 0/3] mmc: Add OMAP SDHCI driver","submitter":{"id":365,"url":"http://patchwork.ozlabs.org/api/people/365/","name":"Tony Lindgren","email":"tony@atomide.com"},"content":"* Kishon Vijay Abraham I [170906 04:47]:\n> This is the first step in deprecating omap_hsmmc driver completely\n> and moving to sdhci-omap driver which uses the sdhci library.\n\nLooks good to me. A beverage coming your way at some conf\non me for sure for dealing with this :)\n\nAcked-by: Tony Lindgren \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xp5XW6Jz2z9t2f\n\tfor ;\n\tFri, 8 Sep 2017 02:30:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751634AbdIGQaS (ORCPT\n\t);\n\tThu, 7 Sep 2017 12:30:18 -0400","from muru.com ([72.249.23.125]:40070 \"EHLO muru.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1750763AbdIGQaR (ORCPT );\n\tThu, 7 Sep 2017 12:30:17 -0400","from atomide.com (localhost [127.0.0.1])\n\tby muru.com (Postfix) with ESMTPS id 2BFCA82D6;\n\tThu, 7 Sep 2017 16:30:47 +0000 (UTC)"],"Date":"Thu, 7 Sep 2017 09:30:13 -0700","From":"Tony Lindgren ","To":"Kishon Vijay Abraham I ","Cc":"Ulf Hansson ,\n\tAdrian Hunter ,\n\tRob Herring , Mark Rutland ,\n\tLiam Girdwood , \n\tMark Brown , Sekhar Nori ,\n\tRussell King ,\n\tRavikumar Kattekola , linux-mmc@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v3 0/3] mmc: Add OMAP SDHCI driver","Message-ID":"<20170907163009.GQ5024@atomide.com>","References":"<20170906114556.32532-1-kishon@ti.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170906114556.32532-1-kishon@ti.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1768376,"web_url":"http://patchwork.ozlabs.org/comment/1768376/","msgid":"","list_archive_url":null,"date":"2017-09-14T07:26:35","subject":"Re: [PATCH v3 2/3] mmc: sdhci-omap: Add OMAP SDHCI driver","submitter":{"id":11091,"url":"http://patchwork.ozlabs.org/api/people/11091/","name":"Adrian Hunter","email":"adrian.hunter@intel.com"},"content":"On 06/09/17 14:45, Kishon Vijay Abraham I wrote:\n> Create a new sdhci-omap driver to configure the eMMC/SD/SDIO controller\n> in TI's OMAP SoCs making use of the SDHCI core library. For OMAP specific\n> configurations, populate sdhci_ops with OMAP specific callbacks and use\n> SDHCI quirks.\n> Enable only high speed mode for both SD and eMMC here and add other\n> UHS mode support later.\n> \n> Signed-off-by: Kishon Vijay Abraham I \n\nAcked-by: Adrian Hunter \n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xt9Hg5Myzz9t1t\n\tfor ;\n\tThu, 14 Sep 2017 17:33:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751120AbdINHdR (ORCPT\n\t);\n\tThu, 14 Sep 2017 03:33:17 -0400","from mga06.intel.com ([134.134.136.31]:6421 \"EHLO mga06.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751085AbdINHdQ (ORCPT );\n\tThu, 14 Sep 2017 03:33:16 -0400","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 14 Sep 2017 00:33:15 -0700","from ahunter-desktop.fi.intel.com (HELO [10.237.72.168])\n\t([10.237.72.168])\n\tby FMSMGA003.fm.intel.com with ESMTP; 14 Sep 2017 00:33:11 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.42,391,1500966000\"; d=\"scan'208\";a=\"900134554\"","Subject":"Re: [PATCH v3 2/3] mmc: sdhci-omap: Add OMAP SDHCI driver","To":"Kishon Vijay Abraham I ,\n\tUlf Hansson , Rob Herring ,\n\tMark Rutland , Tony Lindgren ,\n\tLiam Girdwood , Mark Brown ","Cc":"Sekhar Nori , Russell King ,\n\tRavikumar Kattekola , linux-mmc@vger.kernel.org,\n\tdevicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org","References":"<20170906114556.32532-1-kishon@ti.com>\n\t<20170906114556.32532-3-kishon@ti.com>","From":"Adrian Hunter ","Organization":"Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, \n\tBusiness Identity Code: 0357606 - 4, Domiciled in Helsinki","Message-ID":"","Date":"Thu, 14 Sep 2017 10:26:35 +0300","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170906114556.32532-3-kishon@ti.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1773401,"web_url":"http://patchwork.ozlabs.org/comment/1773401/","msgid":"","list_archive_url":null,"date":"2017-09-22T09:45:11","subject":"Re: [PATCH v3 0/3] mmc: Add OMAP SDHCI driver","submitter":{"id":21036,"url":"http://patchwork.ozlabs.org/api/people/21036/","name":"Ulf Hansson","email":"ulf.hansson@linaro.org"},"content":"On 6 September 2017 at 13:45, Kishon Vijay Abraham I wrote:\n> This is the first step in deprecating omap_hsmmc driver completely\n> and moving to sdhci-omap driver which uses the sdhci library.\n>\n> This patch that adds a new SDHCI quirk \"MMC_RSP_136\" has already been\n> merged and hence removed it in this revision.\n>\n> Apart from the quirk, sdhci-omap has it's own callbacks\n> to set_clock (clock divider programming is different from generic sdhci)\n> , set_power, set_bus_width, set_bus_mode and platform_send_init_74_clocks.\n> These callback functions are implemented based on omap_hsmmc driver.\n> Since sdhci-omap driver requires pbias regulator fixes to be present, I've\n> sent them as part of this series.\n>\n> The sdhci-omap driver supports only the high speed mode and UHS/HS200\n> mode will be added in a later series.\n>\n> It has been tested only in boards having DRA7 SoCs like dra7-evm, dra72-evm,\n> am571x-idk, am572x-idk, am57xx-evm. (Tested only eMMC and SD.\n> SDIO support will be added later). The plan is to fully convert DRA7\n> SoC to use SDHCI driver and then convert other legacy platforms to use\n> SDHCI.\n>\n> For sdhci-omap to be functional, the following tag should be merged (There\n> are no compilation dependencies).\n> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator\n> tags/regulator-pbias-variants\n\nTag pulled.\n\n>\n> However the above regulator tag will impact omap_hsmmc driver. so [1]\n> should be merged before everything else is merged.\n>\n> [1] -> https://lkml.org/lkml/2017/8/31/300\n\nApplied.\n\n>\n> The patch to add config and dts changes to use sdhci-omap will be sent\n> separately.\n>\n> Next Steps:\n> *) Add UHS support to sdhci-omap\n> *) Add SDIO support\n> *) Add support for older TI platforms\n>\n> Changes from v3:\n> *) removed omap_hsmmc and pbias-regulator patches from the series\n> *) Fixed dt-binding documentation (remove '0x' in node name)\n> *) stop clock if MMC core sends '0' in frequency\n>\n> Changes from v2:\n> *) Rebased on git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next\n> *) Included a couple of patches from Ravikumar to fix pbias-regulator driver\n> to support max-voltage of 3.3V. This is required for sdhci-omap driver.\n> *) Create sdhci-omap as a new driver with MMC generic bindings and hence doesn't\n> have bindings like ti,dual-volt added for omap-hsmmc. (Instead of\n> ti,dual-volt, sdhci-omap driver uses the supported regulator voltage to\n> set controller IO voltage capabilities).\n> When omap-hsmmc driver is deprecated, support for these properties will\n> be added to sdhci-omap.\n> *) Fixed minor comments from Adrian).\n>\n> Changes from v1:\n> *) Remove the quirks and instead use sdhci_omap specific callbacks for\n> set_power, set_busmode etc.\n> *) Add a patch from Adrian to tidy reading 136-bit responses\n>\n> I've also pushed the entire series along with dependent dt patches @\n> https://github.com/kishon/linux-wip.git sdhci_v3 (in case someone\n> wants to test)\n>\n> Kishon Vijay Abraham I (3):\n> dt-bindings: sdhci-omap: Add bindings for the sdhci-omap controller\n> mmc: sdhci-omap: Add OMAP SDHCI driver\n> MAINTAINERS: Add TI OMAP SDHCI Maintainer\n>\n> .../devicetree/bindings/mmc/sdhci-omap.txt | 16 +\n> MAINTAINERS | 6 +\n> drivers/mmc/host/Kconfig | 12 +\n> drivers/mmc/host/Makefile | 1 +\n> drivers/mmc/host/sdhci-omap.c | 607 +++++++++++++++++++++\n> 5 files changed, 642 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/mmc/sdhci-omap.txt\n> create mode 100644 drivers/mmc/host/sdhci-omap.c\n>\n> --\n> 2.11.0\n>\n\nThanks, everything applied/pulled for next! Great work!\n\nKind regards\nUffe\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"BmOtusSs\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xz7rD3nvKz9sP1\n\tfor ;\n\tFri, 22 Sep 2017 19:45:16 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751957AbdIVJpO (ORCPT\n\t);\n\tFri, 22 Sep 2017 05:45:14 -0400","from mail-io0-f172.google.com ([209.85.223.172]:48357 \"EHLO\n\tmail-io0-f172.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751933AbdIVJpN (ORCPT\n\t); Fri, 22 Sep 2017 05:45:13 -0400","by mail-io0-f172.google.com with SMTP id n69so1825269ioi.5\n\tfor ;\n\tFri, 22 Sep 2017 02:45:12 -0700 (PDT)","by 10.2.181.165 with HTTP; Fri, 22 Sep 2017 02:45:11 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=Iw6C/KLUqxNYZxTedQr79UXvKwaN8ORWIzGq/itVzu4=;\n\tb=BmOtusSsghf7qM/kzSp2w95Pw1Pjhe//uOhfkemd9yYLSbKokoGwcLOXk3iSCaU9v4\n\tY7nBEZJY8uXSBvxGw4PNWmyO8V73p4FItK1+IQTby+lSwfkn2Obc7gFemXl38X+eYJUD\n\tvtURwci5U4S8zYBihbXndYhZfPI48/o3BNi0E=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=Iw6C/KLUqxNYZxTedQr79UXvKwaN8ORWIzGq/itVzu4=;\n\tb=nbqHFXwvWAf7R9ltHhfRxuQni0izp3T/3YPlevYgwuIu0K+FhTJoPAS9ywUinv0DkL\n\tqeRy6vA56z4UiLuVZXl2Z947b47p/RsQnbfX8cN+NaA17tyh1Rm0relNAqAhmtCT3ED8\n\tTl5Z9y+rGQYLng3UvkMGlZM+tgRUFgEfnBp5IPksDTM6SRkUYhNwQrvaPinBUjRQJ6bV\n\tAEazlGqh7VmyVQVm/VizEfJ7UYmuQNfcGDSbZrB/NgfN85+B40jckRFbVA3c3DP2/itQ\n\toAHZs7VU3C/eMz2lwAaQcTBMBIy+9qycFcNMsccQJe74IXd1IAwpRdbcPZCwfwaNMJWN\n\tvZFg==","X-Gm-Message-State":"AHPjjUhSGmYCRiZlvgNWaWAhgWNl+CFXhFfbGTE7EIjK4Ei3wdzimkQS\n\tt4+gS65yMn3xKK07ttlUFXnqYGr6QCqPDnmRDmE7mg==","X-Google-Smtp-Source":"AOwi7QBAW/d2GeDa8bkTVx9LW+CPAKRvudLa41+Z/isNqjZPDHBRcBWRjb9gPYdgPyJ1mdEfsiytRtts5Ht/WaBhgAA=","X-Received":"by 10.107.19.139 with SMTP id 11mr6425363iot.286.1506073512247; \n\tFri, 22 Sep 2017 02:45:12 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170906114556.32532-1-kishon@ti.com>","References":"<20170906114556.32532-1-kishon@ti.com>","From":"Ulf Hansson ","Date":"Fri, 22 Sep 2017 11:45:11 +0200","Message-ID":"","Subject":"Re: [PATCH v3 0/3] mmc: Add OMAP SDHCI driver","To":"Kishon Vijay Abraham I , Mark Brown ","Cc":"Adrian Hunter , Rob Herring ,\n\tMark Rutland , Tony Lindgren ,\n\tLiam Girdwood , Sekhar Nori ,\n\tRussell King , Ravikumar Kattekola ,\n\t\"linux-mmc@vger.kernel.org\" ,\n\t\"devicetree@vger.kernel.org\" ,\n\t\"linux-kernel@vger.kernel.org\" ,\n\tlinux-omap ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"devicetree@vger.kernel.org"}}]