[{"id":1764200,"web_url":"http://patchwork.ozlabs.org/comment/1764200/","msgid":"<874lsfvo5j.fsf@dusky.pond.sub.org>","list_archive_url":null,"date":"2017-09-06T15:32:08","subject":"Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on\n\tthe fly","submitter":{"id":2645,"url":"http://patchwork.ozlabs.org/api/people/2645/","name":"Markus Armbruster","email":"armbru@redhat.com"},"content":"Series\nReviewed-by: Markus Armbruster \n\nPerhaps Rich would like to have a look, too.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=armbru@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSJf71Jjz9t3Z\n\tfor ;\n\tThu, 7 Sep 2017 01:32:50 +1000 (AEST)","from localhost ([::1]:36726 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpcJr-0002Bu-MU\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:32:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57699)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpcJL-0002Bn-Tx\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:32:16 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpcJH-0001Zl-HE\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:32:15 -0400","from mx1.redhat.com ([209.132.183.28]:33642)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpcJH-0001Wk-Bq\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:32:11 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 4563680473\n\tfor ; Wed, 6 Sep 2017 15:32:10 +0000 (UTC)","from blackfin.pond.sub.org (ovpn-116-75.ams2.redhat.com\n\t[10.36.116.75])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 11D626E506;\n\tWed, 6 Sep 2017 15:32:09 +0000 (UTC)","by blackfin.pond.sub.org (Postfix, from userid 1000)\n\tid 779FF1138645; Wed, 6 Sep 2017 17:32:08 +0200 (CEST)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 4563680473","From":"Markus Armbruster ","To":"Michal Privoznik ","References":"","Date":"Wed, 06 Sep 2017 17:32:08 +0200","In-Reply-To":" (Michal Privoznik's\n\tmessage of \"Wed, 6 Sep 2017 13:24:37 +0200\")","Message-ID":"<874lsfvo5j.fsf@dusky.pond.sub.org>","User-Agent":"Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)","MIME-Version":"1.0","Content-Type":"text/plain","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 06 Sep 2017 15:32:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on\n\tthe fly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org, \"Richard W. M. Jones\" ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764203,"web_url":"http://patchwork.ozlabs.org/comment/1764203/","msgid":"<20170906153709.GQ20914@redhat.com>","list_archive_url":null,"date":"2017-09-06T15:37:09","subject":"Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on\n\tthe fly","submitter":{"id":3044,"url":"http://patchwork.ozlabs.org/api/people/3044/","name":"Richard W.M. Jones","email":"rjones@redhat.com"},"content":"On Wed, Sep 06, 2017 at 05:32:08PM +0200, Markus Armbruster wrote:\n> Series\n> Reviewed-by: Markus Armbruster \n> \n> Perhaps Rich would like to have a look, too.\n\nI looked at them and they seemed OK but I didn't review them.\n\nI also added this comment on the bug which maybe relevant,\nmaybe not ...\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1447169#c4\n\n \"Not that it matters, but the real hardware was built into the\n southbridge and so not hotpluggable.\n\n Do you know what happens (or should happen) if the guest kernel\n loads the i6300esb driver with nowayout=1 and the hardware is\n unplugged? My reading of the driver says that this will not break\n or crash, although it probably won't work as the guest user\n expects. You can tell from the qemu side if the guest selected\n nowayout because ESB_WDT_LOCK is written to the ESB_LOCK_REG\n register.\n\n Anyway, this may not matter.\"\n\nRich.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx06.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=rjones@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSQF3n0Gz9t43\n\tfor ;\n\tThu, 7 Sep 2017 01:37:41 +1000 (AEST)","from localhost ([::1]:36748 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpcOZ-0005Bn-M3\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:37:39 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:59399)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpcOE-0005Al-8Y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:37:19 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpcO8-0005Eh-48\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:37:16 -0400","from mx1.redhat.com ([209.132.183.28]:44838)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpcO7-0005Cf-UZ\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:37:12 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D0B22356D4\n\tfor ; Wed, 6 Sep 2017 15:37:10 +0000 (UTC)","from localhost (ovpn-117-64.ams2.redhat.com [10.36.117.64])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 7C43F19EF0;\n\tWed, 6 Sep 2017 15:37:10 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D0B22356D4","Date":"Wed, 6 Sep 2017 16:37:09 +0100","From":"\"Richard W.M. Jones\" ","To":"Markus Armbruster ","Message-ID":"<20170906153709.GQ20914@redhat.com>","References":"\n\t<874lsfvo5j.fsf@dusky.pond.sub.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<874lsfvo5j.fsf@dusky.pond.sub.org>","User-Agent":"Mutt/1.5.20 (2009-12-10)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.30]);\n\tWed, 06 Sep 2017 15:37:10 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on\n\tthe fly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Michal Privoznik , qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1764210,"web_url":"http://patchwork.ozlabs.org/comment/1764210/","msgid":"<081be856-0e3d-9b21-6b19-34c88823f730@redhat.com>","list_archive_url":null,"date":"2017-09-06T15:41:15","subject":"Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on\n\tthe fly","submitter":{"id":11888,"url":"http://patchwork.ozlabs.org/api/people/11888/","name":"Michal Prívozník","email":"mprivozn@redhat.com"},"content":"On 09/06/2017 05:37 PM, Richard W.M. Jones wrote:\n> On Wed, Sep 06, 2017 at 05:32:08PM +0200, Markus Armbruster wrote:\n>> Series\n>> Reviewed-by: Markus Armbruster \n>>\n>> Perhaps Rich would like to have a look, too.\n> \n> I looked at them and they seemed OK but I didn't review them.\n> \n> I also added this comment on the bug which maybe relevant,\n> maybe not ...\n> \n> https://bugzilla.redhat.com/show_bug.cgi?id=1447169#c4\n> \n> \"Not that it matters, but the real hardware was built into the\n> southbridge and so not hotpluggable.\n> \n> Do you know what happens (or should happen) if the guest kernel\n> loads the i6300esb driver with nowayout=1 and the hardware is\n> unplugged? My reading of the driver says that this will not break\n> or crash, although it probably won't work as the guest user\n> expects. You can tell from the qemu side if the guest selected\n> nowayout because ESB_WDT_LOCK is written to the ESB_LOCK_REG\n> register.\n> \n> Anyway, this may not matter.\"\n\nI've tested this and the guest continued running happily after I've\ndetached the watchdog.\n\nMichal","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx04.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=mprivozn@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnSWB040gz9t50\n\tfor ;\n\tThu, 7 Sep 2017 01:41:58 +1000 (AEST)","from localhost ([::1]:36767 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpcSi-0008A1-3g\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 11:41:56 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:34279)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpcS9-00087x-Vn\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:41:22 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpcS7-0006wc-Bf\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:41:22 -0400","from mx1.redhat.com ([209.132.183.28]:50328)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dpcS7-0006ve-5Y\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 11:41:19 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 39530821C7\n\tfor ; Wed, 6 Sep 2017 15:41:18 +0000 (UTC)","from [10.43.2.192] (unknown [10.43.2.192])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 6FEDE5C544;\n\tWed, 6 Sep 2017 15:41:17 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 39530821C7","To":"\"Richard W.M. Jones\" ,\n\tMarkus Armbruster ","References":"\n\t<874lsfvo5j.fsf@dusky.pond.sub.org>\n\t<20170906153709.GQ20914@redhat.com>","From":"Michal Privoznik ","Message-ID":"<081be856-0e3d-9b21-6b19-34c88823f730@redhat.com>","Date":"Wed, 6 Sep 2017 17:41:15 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906153709.GQ20914@redhat.com>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.28]);\n\tWed, 06 Sep 2017 15:41:18 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v4 0/3] watchdog: Allow setting action on\n\tthe fly","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]