[{"id":1763842,"web_url":"http://patchwork.ozlabs.org/comment/1763842/","msgid":"<4af30c89-15a8-c3e6-3563-aa4c8e76c577@linux.vnet.ibm.com>","list_archive_url":null,"date":"2017-09-06T06:57:48","subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","submitter":{"id":70124,"url":"http://patchwork.ozlabs.org/api/people/70124/","name":"QingFeng Hao","email":"haoqf@linux.vnet.ibm.com"},"content":"在 2017/9/5 23:16, Cornelia Huck 写道:\n> Recent changes in s390x made pci support dependant on the zpci cpu\n> feature, which is not provided on all models (and not on by default).\n> This means we cannot instatiate pci devices on a standard qemu\n> invocation for s390x. Moreover, the zpci instructions are not even\n> wired up for tcg yet, so actually doing anything with those pci devices\n> is bound to fail on tcg.\n>\n> Let's follow the existing example in 068 and switch to the (default)\n> virtio-ccw transport on s390x. The changes for 051 and 067 are split\n> out as they require adding an output file for s390x (the actual command\n> lines are part of the output).\nWe also found this error and YiMin suggested to change the code in ccw_init\nas below:\n\nif (pci_available) {\n     DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n     ...\n}\nWe tested it and it can make the 5 cases passed.\nHow do you think this? :-)\nThanks!\n\n>\n> Cornelia Huck (3):\n> iotests: use -ccw on s390x for 040, 139, and 182\n> iotests: use -ccw on s390x for 051\n> iotests: use -ccw on s390x for 067\n>\n> tests/qemu-iotests/040 | 6 +-\n> tests/qemu-iotests/051 | 9 +-\n> tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++\n> tests/qemu-iotests/067 | 11 +-\n> tests/qemu-iotests/067.s390-ccw-virtio.out | 458 +++++++++++++++++++++++++++++\n> tests/qemu-iotests/139 | 12 +-\n> tests/qemu-iotests/182 | 13 +-\n> 7 files changed, 936 insertions(+), 7 deletions(-)\n> create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out\n> create mode 100644 tests/qemu-iotests/067.s390-ccw-virtio.out\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnDvG44fYz9sNd\n\tfor ;\n\tWed, 6 Sep 2017 16:58:34 +1000 (AEST)","from localhost ([::1]:34427 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpUIC-0002fq-Nc\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 02:58:32 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:43815)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpUHp-0002f6-Lq\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 02:58:10 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpUHm-0004NU-Jh\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 02:58:09 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:50323)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpUHm-0004Mw-Am\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 02:58:06 -0400","from pps.filterd (m0098393.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv866t97i019943\n\tfor ; Wed, 6 Sep 2017 02:58:03 -0400","from e11.ny.us.ibm.com (e11.ny.us.ibm.com [129.33.205.201])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ct76agt1c-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 02:58:03 -0400","from localhost\n\tby e11.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 6 Sep 2017 02:58:01 -0400","from b01cxnp23032.gho.pok.ibm.com (9.57.198.27)\n\tby e11.ny.us.ibm.com (146.89.104.198) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 02:57:58 -0400","from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com\n\t[9.57.199.110])\n\tby b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP\n\tid v866vwU225690164; Wed, 6 Sep 2017 06:57:58 GMT","from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 66693AE03C;\n\tWed, 6 Sep 2017 02:58:24 -0400 (EDT)","from [9.125.65.66] (unknown [9.125.65.66])\n\tby b01ledav005.gho.pok.ibm.com (Postfix) with ESMTPS id F17F1AE034;\n\tWed, 6 Sep 2017 02:58:20 -0400 (EDT)"],"To":"Cornelia Huck , kwolf@redhat.com, mreitz@redhat.com","References":"<20170905151614.31303-1-cohuck@redhat.com>","From":"QingFeng Hao ","Date":"Wed, 6 Sep 2017 14:57:48 +0800","User-Agent":"Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905151614.31303-1-cohuck@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","X-TM-AS-GCONF":"00","x-cbid":"17090606-2213-0000-0000-0000021501D9","X-IBM-SpamModules-Scores":"","X-IBM-SpamModules-Versions":"BY=3.00007675; HX=3.00000241; KW=3.00000007;\n\tPH=3.00000004; SC=3.00000226; SDB=6.00912956; UDB=6.00458164;\n\tIPR=6.00693219; \n\tBA=6.00005573; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009;\n\tZB=6.00000000; \n\tZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017027;\n\tXFM=3.00000015; UTC=2017-09-06 06:58:00","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090606-2214-0000-0000-0000577315E6","Message-Id":"<4af30c89-15a8-c3e6-3563-aa4c8e76c577@linux.vnet.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060093","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v866t97i019943","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"thuth@redhat.com, Yi Min Zhao ,\n\tqemu-block@nongnu.org, david@redhat.com, qemu-devel@nongnu.org,\n\tagraf@suse.de, borntraeger@de.ibm.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763854,"web_url":"http://patchwork.ozlabs.org/comment/1763854/","msgid":"<20170906091701.6d0fe044.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-06T07:17:01","subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 6 Sep 2017 14:57:48 +0800\nQingFeng Hao wrote:\n\n> 在 2017/9/5 23:16, Cornelia Huck 写道:\n> > Recent changes in s390x made pci support dependant on the zpci cpu\n> > feature, which is not provided on all models (and not on by default).\n> > This means we cannot instatiate pci devices on a standard qemu\n> > invocation for s390x. Moreover, the zpci instructions are not even\n> > wired up for tcg yet, so actually doing anything with those pci devices\n> > is bound to fail on tcg.\n> >\n> > Let's follow the existing example in 068 and switch to the (default)\n> > virtio-ccw transport on s390x. The changes for 051 and 067 are split\n> > out as they require adding an output file for s390x (the actual command\n> > lines are part of the output). \n> We also found this error and YiMin suggested to change the code in ccw_init\n> as below:\n> \n> if (pci_available) {\n>     DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n>     ...\n> }\n> We tested it and it can make the 5 cases passed.\n> How do you think this? :-)\n\nI can take a look at this.\n\nBut I think we want to prefer ccw for s390x in the tests in any case,\nfor the reasons stated above.\n\n> Thanks!\n> \n> >\n> > Cornelia Huck (3):\n> > iotests: use -ccw on s390x for 040, 139, and 182\n> > iotests: use -ccw on s390x for 051\n> > iotests: use -ccw on s390x for 067\n> >\n> > tests/qemu-iotests/040 | 6 +-\n> > tests/qemu-iotests/051 | 9 +-\n> > tests/qemu-iotests/051.s390-ccw-virtio.out | 434 +++++++++++++++++++++++++++\n> > tests/qemu-iotests/067 | 11 +-\n> > tests/qemu-iotests/067.s390-ccw-virtio.out | 458 +++++++++++++++++++++++++++++\n> > tests/qemu-iotests/139 | 12 +-\n> > tests/qemu-iotests/182 | 13 +-\n> > 7 files changed, 936 insertions(+), 7 deletions(-)\n> > create mode 100644 tests/qemu-iotests/051.s390-ccw-virtio.out\n> > create mode 100644 tests/qemu-iotests/067.s390-ccw-virtio.out\n> > \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx02.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnFKY6h9tz9sNd\n\tfor ;\n\tWed, 6 Sep 2017 17:17:52 +1000 (AEST)","from localhost ([::1]:34543 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpUar-0006Sk-Sw\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 03:17:49 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:49842)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpUaI-0006RI-Ok\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 03:17:15 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpUaH-00067U-Se\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 03:17:14 -0400","from mx1.redhat.com ([209.132.183.28]:16479)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpUaD-00065D-AY; Wed, 06 Sep 2017 03:17:09 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3EECF883C4;\n\tWed, 6 Sep 2017 07:17:08 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 35B7A58857;\n\tWed, 6 Sep 2017 07:17:03 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 3EECF883C4","Date":"Wed, 6 Sep 2017 09:17:01 +0200","From":"Cornelia Huck ","To":"QingFeng Hao ","Message-ID":"<20170906091701.6d0fe044.cohuck@redhat.com>","In-Reply-To":"<4af30c89-15a8-c3e6-3563-aa4c8e76c577@linux.vnet.ibm.com>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<4af30c89-15a8-c3e6-3563-aa4c8e76c577@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]);\n\tWed, 06 Sep 2017 07:17:08 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, thuth@redhat.com,\n\tYi Min Zhao , \n\tqemu-block@nongnu.org, david@redhat.com, agraf@suse.de,\n\tqemu-devel@nongnu.org, borntraeger@de.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763878,"web_url":"http://patchwork.ozlabs.org/comment/1763878/","msgid":"<20170906095953.13d5fb01.cohuck@redhat.com>","list_archive_url":null,"date":"2017-09-06T07:59:53","subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","submitter":{"id":71914,"url":"http://patchwork.ozlabs.org/api/people/71914/","name":"Cornelia Huck","email":"cohuck@redhat.com"},"content":"On Wed, 6 Sep 2017 14:57:48 +0800\nQingFeng Hao wrote:\n\n> 在 2017/9/5 23:16, Cornelia Huck 写道:\n> > Recent changes in s390x made pci support dependant on the zpci cpu\n> > feature, which is not provided on all models (and not on by default).\n> > This means we cannot instatiate pci devices on a standard qemu\n> > invocation for s390x. Moreover, the zpci instructions are not even\n> > wired up for tcg yet, so actually doing anything with those pci devices\n> > is bound to fail on tcg.\n> >\n> > Let's follow the existing example in 068 and switch to the (default)\n> > virtio-ccw transport on s390x. The changes for 051 and 067 are split\n> > out as they require adding an output file for s390x (the actual command\n> > lines are part of the output). \n> We also found this error and YiMin suggested to change the code in ccw_init\n> as below:\n> \n> if (pci_available) {\n>     DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n>     ...\n> }\n> We tested it and it can make the 5 cases passed.\n\nOK, looked at this. This won't work: pci_available means \"this qemu has\npci support built in\". _Working_ zpci, however, depends on the presence\nof the zpci feature bit: You'll have a host bridge and can define\ndevices that have absolutely no chance of working, since all pci\ninstruction will return errors. You will be in a similar situation\nunder kvm as under tcg: you can specify virtio-pci devices on the\ncommand line, but they can't work.\n\nThis probably makes the 5 cases pass as they only rely on the ability\nto create the device, not to do anything with them.\n\nSo, I still think the right thing to do is to switch to ccw in the\ntests (and to wire up pci in tcg, but that's an orthogonal issue).","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=cohuck@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnGH252Kkz9sNd\n\tfor ;\n\tWed, 6 Sep 2017 18:00:44 +1000 (AEST)","from localhost ([::1]:34690 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpVGL-00016a-KQ\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 04:00:41 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:36441)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpVFu-00016A-7I\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:00:20 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpVFo-0004n8-Jm\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:00:14 -0400","from mx1.redhat.com ([209.132.183.28]:47988)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpVFh-0004gN-BQ; Wed, 06 Sep 2017 04:00:01 -0400","from smtp.corp.redhat.com\n\t(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DEBE781DE1;\n\tWed, 6 Sep 2017 07:59:59 +0000 (UTC)","from gondolin (dhcp-192-215.str.redhat.com [10.33.192.215])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0B7FF6FAAB;\n\tWed, 6 Sep 2017 07:59:55 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com DEBE781DE1","Date":"Wed, 6 Sep 2017 09:59:53 +0200","From":"Cornelia Huck ","To":"QingFeng Hao ","Message-ID":"<20170906095953.13d5fb01.cohuck@redhat.com>","In-Reply-To":"<4af30c89-15a8-c3e6-3563-aa4c8e76c577@linux.vnet.ibm.com>","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<4af30c89-15a8-c3e6-3563-aa4c8e76c577@linux.vnet.ibm.com>","Organization":"Red Hat GmbH","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.12","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tWed, 06 Sep 2017 08:00:00 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, thuth@redhat.com,\n\tYi Min Zhao , \n\tqemu-block@nongnu.org, david@redhat.com, agraf@suse.de,\n\tqemu-devel@nongnu.org, borntraeger@de.ibm.com, mreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1763886,"web_url":"http://patchwork.ozlabs.org/comment/1763886/","msgid":"","list_archive_url":null,"date":"2017-09-06T08:09:27","subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","submitter":{"id":66807,"url":"http://patchwork.ozlabs.org/api/people/66807/","name":"Yi Min Zhao","email":"zyimin@linux.vnet.ibm.com"},"content":"在 2017/9/6 下午3:59, Cornelia Huck 写道:\n> On Wed, 6 Sep 2017 14:57:48 +0800\n> QingFeng Hao wrote:\n>\n>> 在 2017/9/5 23:16, Cornelia Huck 写道:\n>>> Recent changes in s390x made pci support dependant on the zpci cpu\n>>> feature, which is not provided on all models (and not on by default).\n>>> This means we cannot instatiate pci devices on a standard qemu\n>>> invocation for s390x. Moreover, the zpci instructions are not even\n>>> wired up for tcg yet, so actually doing anything with those pci devices\n>>> is bound to fail on tcg.\n>>>\n>>> Let's follow the existing example in 068 and switch to the (default)\n>>> virtio-ccw transport on s390x. The changes for 051 and 067 are split\n>>> out as they require adding an output file for s390x (the actual command\n>>> lines are part of the output).\n>> We also found this error and YiMin suggested to change the code in ccw_init\n>> as below:\n>>\n>> if (pci_available) {\n>>     DeviceState *dev = qdev_create(NULL, TYPE_S390_PCI_HOST_BRIDGE);\n>>     ...\n>> }\n>> We tested it and it can make the 5 cases passed.\n> OK, looked at this. This won't work: pci_available means \"this qemu has\n> pci support built in\". _Working_ zpci, however, depends on the presence\n> of the zpci feature bit: You'll have a host bridge and can define\n> devices that have absolutely no chance of working, since all pci\n> instruction will return errors. You will be in a similar situation\n> under kvm as under tcg: you can specify virtio-pci devices on the\n> command line, but they can't work.\nOh. Yes, that makes sense. Actually the first way we thought about was \nchange the code\nnot change the testcases. Thanks for your work.\n>\n> This probably makes the 5 cases pass as they only rely on the ability\n> to create the device, not to do anything with them.\n>\n> So, I still think the right thing to do is to switch to ccw in the\n> tests (and to wire up pci in tcg, but that's an orthogonal issue).\nAgree.\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnGWV3qGmz9s8J\n\tfor ;\n\tWed, 6 Sep 2017 18:11:32 +1000 (AEST)","from localhost ([::1]:34867 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpVQh-0003SD-2i\n\tfor incoming@patchwork.ozlabs.org; Wed, 06 Sep 2017 04:11:23 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:41772)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpVQI-0003Rl-V7\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:10:59 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpVQD-0001zr-Sq\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:10:58 -0400","from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49253)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dpVQD-0001zQ-L2\n\tfor qemu-devel@nongnu.org; Wed, 06 Sep 2017 04:10:53 -0400","from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv868AHZU074445\n\tfor ; Wed, 6 Sep 2017 04:10:52 -0400","from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2ctckpswge-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor ; Wed, 06 Sep 2017 04:10:48 -0400","from localhost\n\tby e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor from ;\n\tWed, 6 Sep 2017 18:09:36 +1000","from d23relay06.au.ibm.com (202.81.31.225)\n\tby e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tWed, 6 Sep 2017 18:09:32 +1000","from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8689WcJ38666322; Wed, 6 Sep 2017 18:09:32 +1000","from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8689OHa017964; Wed, 6 Sep 2017 18:09:24 +1000","from zyimindembp.cn.ibm.com (zyimindembp.cn.ibm.com [9.115.193.63])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8689LZV017884; Wed, 6 Sep 2017 18:09:22 +1000"],"To":"Cornelia Huck ,\n\tQingFeng Hao ","References":"<20170905151614.31303-1-cohuck@redhat.com>\n\t<4af30c89-15a8-c3e6-3563-aa4c8e76c577@linux.vnet.ibm.com>\n\t<20170906095953.13d5fb01.cohuck@redhat.com>","From":"Yi Min Zhao ","Date":"Wed, 6 Sep 2017 16:09:27 +0800","User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)\n\tGecko/20100101 Thunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170906095953.13d5fb01.cohuck@redhat.com>","Content-Type":"text/plain; charset=utf-8; format=flowed","X-TM-AS-MML":"disable","x-cbid":"17090608-0044-0000-0000-00000284E545","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17090608-0045-0000-0000-000007187F77","Message-Id":"","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-06_02:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709060111","Content-Transfer-Encoding":"quoted-printable","X-MIME-Autoconverted":"from 8bit to quoted-printable by\n\tmx0a-001b2d01.pphosted.com id v868AHZU074445","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy]","X-Received-From":"148.163.156.1","Subject":"Re: [Qemu-devel] [PATCH 0/3] iotests: cure s390x failures by\n\tswitching to ccw","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, thuth@redhat.com, qemu-block@nongnu.org,\n\tdavid@redhat.com, \n\tagraf@suse.de, qemu-devel@nongnu.org, borntraeger@de.ibm.com,\n\tmreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]