[{"id":1781989,"web_url":"http://patchwork.ozlabs.org/comment/1781989/","msgid":"<20171007030541.GA29421@gondor.apana.org.au>","list_archive_url":null,"date":"2017-10-07T03:05:41","subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","submitter":{"id":357,"url":"http://patchwork.ozlabs.org/api/people/357/","name":"Herbert Xu","email":"herbert@gondor.apana.org.au"},"content":"On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:\n>\n> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c\n> index 5e92bd2..3b3c154 100644\n> --- a/crypto/algif_hash.c\n> +++ b/crypto/algif_hash.c\n> @@ -39,6 +39,20 @@ struct algif_hash_tfm {\n>  \tbool has_key;\n>  };\n>  \n> +/* Previous versions of crypto_* ops used to return -EBUSY\n> + * rather than -EAGAIN to indicate being tied up. The in\n> + * kernel API changed but we don't want to break the user\n> + * space API. As only the hash user interface exposed this\n> + * error ever to the user, do the translation here.\n> + */\n> +static inline int crypto_user_err(int err)\n> +{\n> +\tif (err == -EAGAIN)\n> +\t\treturn -EBUSY;\n> +\n> +\treturn err;\n\nI don't see the need to carry along this baggage.  Does anyone\nin user-space actually rely on EBUSY?\n\nCheers,","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"m7aFlsyG\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8BJR4J9zz9ryr\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tSat,  7 Oct 2017 14:07:35 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e0fSa-0003xU-JO; Sat, 07 Oct 2017 03:07:28 +0000","from orcrist.hmeau.com ([104.223.48.154] helo=deadmen.hmeau.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e0fSW-0003tF-M8; Sat, 07 Oct 2017 03:07:27 +0000","from gondobar.mordor.me.apana.org.au ([192.168.128.4]\n\thelo=gondobar)\n\tby deadmen.hmeau.com with esmtp (Exim 4.84_2 #2 (Debian))\n\tid 1e0fRG-0000aQ-7c; Sat, 07 Oct 2017 11:06:06 +0800","from herbert by gondobar with local (Exim 4.84_2)\n\t(envelope-from <herbert@gondor.apana.org.au>)\n\tid 1e0fQr-0007fa-DT; Sat, 07 Oct 2017 11:05:41 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=YRcR5AdU4CRQK54lDHXAQX3ogtWFjGD1fmFy3qaEzws=;\n\tb=m7aFlsyGQ+AoDU\n\tO2rJ6SKFCMv+V5NKkr/au/MJ9l0nug+01wK53TOrmSgS6jdo9gfDlSubP3GuoefkKVH7viXJECTeE\n\tasVo5JqVTQCPBaxsCxZRr5LXgqu3w00CevijFtARIe8B4M1WytNTPMsniSq4vwr6/QoXzWcoKJLnH\n\t2Rq/Hqp+i7mjKf/g6QQAAG6VcJWDGHMQ3L26T6QzGGz2ntJHAIRX/NPnk00iTDUuUmecA6lb5gob5\n\tccu2j+TqDIoi3xb8rwzKY6wNeBgbEa9HS/0LBAHdVi6Y/8+BE0p18jUuf24YNqVEcl2RYN+/pzHJr\n\t6uxbfM+FP2LnFyUpv+cQ==;","Date":"Sat, 7 Oct 2017 11:05:41 +0800","From":"Herbert Xu <herbert@gondor.apana.org.au>","To":"Gilad Ben-Yossef <gilad@benyossef.com>","Subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","Message-ID":"<20171007030541.GA29421@gondor.apana.org.au>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>\n\t<1504615144-29770-2-git-send-email-gilad@benyossef.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504615144-29770-2-git-send-email-gilad@benyossef.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171006_200725_114103_16623B67 ","X-CRM114-Status":"GOOD (  11.34  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mike Snitzer <snitzer@redhat.com>, linux-doc@vger.kernel.org,\n\tGary Hook <gary.hook@amd.com>, David Howells <dhowells@redhat.com>,\n\tdm-devel@redhat.com, keyrings@vger.kernel.org,\n\tlinux-ima-devel@lists.sourceforge.net, Alasdair Kergon <agk@redhat.com>, \n\tSteffen Klassert <steffen.klassert@secunet.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tJonathan Corbet <corbet@lwn.net>,\n\tAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>, \n\tMimi Zohar <zohar@linux.vnet.ibm.com>,\n\t\"Serge E. Hallyn\" <serge@hallyn.com>, \n\tTom Lendacky <thomas.lendacky@amd.com>, linux-cifs@vger.kernel.org,\n\tlinux-ima-user@lists.sourceforge.net,\n\tArnaud Ebalard <arno@natisbad.org>, \n\tlinux-raid@vger.kernel.org, linux-fscrypt@vger.kernel.org,\n\tlinux-mediatek@lists.infradead.org,\n\tJames Morris <james.l.morris@oracle.com>, \n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tJaegeuk Kim <jaegeuk@kernel.org>, \n\tlinux-arm-kernel@lists.infradead.org, Ofir Drang <ofir.drang@arm.com>,\n\t\"Theodore Y. Ts'o\" <tytso@mit.edu>,\n\tHideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,\n\tDmitry Kasatkin <dmitry.kasatkin@gmail.com>,\n\tsamba-technical@lists.samba.org, \n\tlinux-kernel@vger.kernel.org, Steve French <sfrench@samba.org>,\n\tlinux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, \n\tnetdev@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>,\n\tShaohua Li <shli@kernel.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1782037,"web_url":"http://patchwork.ozlabs.org/comment/1782037/","msgid":"<CAOtvUMd=vtju=VJkCYFRrvANbRRYj+95cdgDoMMfBvmPaPbsAA@mail.gmail.com>","list_archive_url":null,"date":"2017-10-07T07:51:42","subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","submitter":{"id":11198,"url":"http://patchwork.ozlabs.org/api/people/11198/","name":"Gilad Ben-Yossef","email":"gilad@benyossef.com"},"content":"On Sat, Oct 7, 2017 at 6:05 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:\n> On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:\n>>\n>> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c\n>> index 5e92bd2..3b3c154 100644\n>> --- a/crypto/algif_hash.c\n>> +++ b/crypto/algif_hash.c\n>> @@ -39,6 +39,20 @@ struct algif_hash_tfm {\n>>       bool has_key;\n>>  };\n>>\n>> +/* Previous versions of crypto_* ops used to return -EBUSY\n>> + * rather than -EAGAIN to indicate being tied up. The in\n>> + * kernel API changed but we don't want to break the user\n>> + * space API. As only the hash user interface exposed this\n>> + * error ever to the user, do the translation here.\n>> + */\n>> +static inline int crypto_user_err(int err)\n>> +{\n>> +     if (err == -EAGAIN)\n>> +             return -EBUSY;\n>> +\n>> +     return err;\n>\n> I don't see the need to carry along this baggage.  Does anyone\n> in user-space actually rely on EBUSY?\n\n\nI am not aware of anyone who does. I was just trying to avoid\nchanging the user ABI.\n\nShall I roll a new revision without this patch?\n\nThanks,\nGilad\n\n>\n> Cheers,\n> --\n> Email: Herbert Xu <herbert@gondor.apana.org.au>\n> Home Page: http://gondor.apana.org.au/~herbert/\n> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"ZlYG9846\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=benyossef-com.20150623.gappssmtp.com\n\theader.i=@benyossef-com.20150623.gappssmtp.com header.b=\"pPniklwi\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y8Jcv6FwBz9t7F\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tSat,  7 Oct 2017 18:52:15 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e0ju6-0004y7-PJ; Sat, 07 Oct 2017 07:52:10 +0000","from mail-oi0-x241.google.com ([2607:f8b0:4003:c06::241])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e0ju1-0004r2-8N for linux-arm-kernel@lists.infradead.org;\n\tSat, 07 Oct 2017 07:52:07 +0000","by mail-oi0-x241.google.com with SMTP id w197so28240410oif.6\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tSat, 07 Oct 2017 00:51:44 -0700 (PDT)","by 10.157.61.52 with HTTP; Sat, 7 Oct 2017 00:51:42 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=6TuIv6Gmc6VcjAg4DYKO7TEohP9jxU69Xq65RppMCYA=;\n\tb=ZlYG9846CPHVJh\n\tdc0DIc9dOH03xmxSTWyYm6LzeuT8BbvHOsICLI7H2vHFbNCZZWFsZShJ26HOnTa7ipaDn00w8J4gd\n\tl7HoojTAGzqZF2hc4byu1yjuD0pPCppfqxeprCl5IUlJMflfCt870GUl7Vmw0CQgWVhqrnkzRyCdb\n\tJ7KhvP3hBjJr/lcs6+v5/sfxKMTuAanyLhNhxcx8oJnGG+htZjJQKyWck4dGQTAb+EvbxH+5XlDsV\n\t9IE5Z1f8BcLDeDwEFQP4vcz2PPkZKqPl3/OyYKL8zLlukq6ulyIyJNTHsJpbb2UmZkS23htSa/969\n\tMhzk5ZNeyXRoFSC3WPUA==;","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=benyossef-com.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=SR7PT+NpWmM56pEkOYUMjTdZHxtjdBfqEWMZ5hd3TC8=;\n\tb=pPniklwilNdZmMtR02CGVYdVu4WP7cJUA06U2wIxaeoy5sXW5yypthIynPl3xuHgfD\n\tPpwVjF+Vw6A9OH2AzZTJOP2mFw3e2UqsryUNdmjxkk9vul76xm1bDwvR11Xn7LemZyPx\n\t9Si9LmZA4zjPql/IXhbMhLpbs6NvkXi6d6s7p/i7UCrjPGJoksXMRNVLnFVvU4hJ0jyI\n\tKtxEQb9qPrjPYuc8TIvGO3LWDJZS+q0p24uDXpgZoqPpx9aa54+puNF7reVnsSUN0hPt\n\tWLgEIQ3fF35u5lIlE+DgjIqcXlSPWPqMJVeIC6Xst30Hs0z7lWytX2l/KfVSr9MfHFJv\n\tjTfA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=SR7PT+NpWmM56pEkOYUMjTdZHxtjdBfqEWMZ5hd3TC8=;\n\tb=P3sexRWWx3wBk2k3ZVdVI0ry04rgT+DBAjaMbvHVktE3TPZ3i7Y08VHIefMhMls6t3\n\t0huxvZdMaSHVgTGItPwtdYi5KIun0BKO626dRk/NNVGxF9f6ePnbGRGDG8FWrUyi1ydT\n\triJrKlaxFJfr51wY1IQBDgoevf+7SeyGukn1H4B/PlpRjITYCbPnXBxjEkukSsDU4qn2\n\tG6JwPKlGyVy9sd5YLOhV62W13sr994zFFRIfWUoen2iGfmZtjQurr+uslByAnX17zn7C\n\tOeV/SvuwrrZPoV9dbFq4FaDjUDf79Oet5+FV8ABX3JHVaiWUhkY+aFJUd6LSkzPNEGrP\n\tJQJQ==","X-Gm-Message-State":"AMCzsaWtH+zJbPa1DDj6o9cBEWo2u86WDbkOuX8sibPeG6jGmN7uMWMs\n\taMcoiSk8vVqzUIpj7av9LZ1zQaiY+vTMUSmka6W0Kg==","X-Google-Smtp-Source":"AOwi7QDzxXXxtk0jE4PuJLFWNSLEAsgUvKzjWWRn9xoyOfioxYWtoW/uzgVFr5j/YYeyOWm8y7TdQ7l5nzzT4nO9O88=","X-Received":"by 10.202.92.197 with SMTP id q188mr2011346oib.69.1507362702719; \n\tSat, 07 Oct 2017 00:51:42 -0700 (PDT)","MIME-Version":"1.0","X-Originating-IP":"[82.81.71.2]","In-Reply-To":"<20171007030541.GA29421@gondor.apana.org.au>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>\n\t<1504615144-29770-2-git-send-email-gilad@benyossef.com>\n\t<20171007030541.GA29421@gondor.apana.org.au>","From":"Gilad Ben-Yossef <gilad@benyossef.com>","Date":"Sat, 7 Oct 2017 10:51:42 +0300","Message-ID":"<CAOtvUMd=vtju=VJkCYFRrvANbRRYj+95cdgDoMMfBvmPaPbsAA@mail.gmail.com>","Subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","To":"Herbert Xu <herbert@gondor.apana.org.au>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171007_005205_415295_BDD20CEA ","X-CRM114-Status":"GOOD (  14.69  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mike Snitzer <snitzer@redhat.com>, linux-doc@vger.kernel.org,\n\tGary Hook <gary.hook@amd.com>, David Howells <dhowells@redhat.com>,\n\tdevice-mapper development <dm-devel@redhat.com>,\n\tkeyrings@vger.kernel.org, linux-ima-devel@lists.sourceforge.net,\n\tAlasdair Kergon <agk@redhat.com>, \n\tSteffen Klassert <steffen.klassert@secunet.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tJonathan Corbet <corbet@lwn.net>,\n\tAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>, \n\tMimi Zohar <zohar@linux.vnet.ibm.com>,\n\t\"Serge E. Hallyn\" <serge@hallyn.com>, \n\tTom Lendacky <thomas.lendacky@amd.com>, linux-cifs@vger.kernel.org,\n\tlinux-ima-user@lists.sourceforge.net,\n\tArnaud Ebalard <arno@natisbad.org>, \n\tlinux-raid@vger.kernel.org, linux-fscrypt@vger.kernel.org,\n\tlinux-mediatek@lists.infradead.org,\n\tJames Morris <james.l.morris@oracle.com>, \n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tJaegeuk Kim <jaegeuk@kernel.org>, \n\tlinux-arm-kernel@lists.infradead.org, Ofir Drang <ofir.drang@arm.com>,\n\t\"Theodore Y. Ts'o\" <tytso@mit.edu>,\n\tHideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,\n\tDmitry Kasatkin <dmitry.kasatkin@gmail.com>,\n\tsamba-technical@lists.samba.org, \n\tLinux kernel mailing list <linux-kernel@vger.kernel.org>,\n\tSteve French <sfrench@samba.org>, linux-security-module@vger.kernel.org, \n\tLinux Crypto Mailing List <linux-crypto@vger.kernel.org>,\n\tnetdev@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>,\n\tShaohua Li <shli@kernel.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1784308,"web_url":"http://patchwork.ozlabs.org/comment/1784308/","msgid":"<20171011062651.GA18664@gondor.apana.org.au>","list_archive_url":null,"date":"2017-10-11T06:26:51","subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","submitter":{"id":357,"url":"http://patchwork.ozlabs.org/api/people/357/","name":"Herbert Xu","email":"herbert@gondor.apana.org.au"},"content":"On Sat, Oct 07, 2017 at 10:51:42AM +0300, Gilad Ben-Yossef wrote:\n> On Sat, Oct 7, 2017 at 6:05 AM, Herbert Xu <herbert@gondor.apana.org.au> wrote:\n> > On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote:\n> >>\n> >> diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c\n> >> index 5e92bd2..3b3c154 100644\n> >> --- a/crypto/algif_hash.c\n> >> +++ b/crypto/algif_hash.c\n> >> @@ -39,6 +39,20 @@ struct algif_hash_tfm {\n> >>       bool has_key;\n> >>  };\n> >>\n> >> +/* Previous versions of crypto_* ops used to return -EBUSY\n> >> + * rather than -EAGAIN to indicate being tied up. The in\n> >> + * kernel API changed but we don't want to break the user\n> >> + * space API. As only the hash user interface exposed this\n> >> + * error ever to the user, do the translation here.\n> >> + */\n> >> +static inline int crypto_user_err(int err)\n> >> +{\n> >> +     if (err == -EAGAIN)\n> >> +             return -EBUSY;\n> >> +\n> >> +     return err;\n> >\n> > I don't see the need to carry along this baggage.  Does anyone\n> > in user-space actually rely on EBUSY?\n> \n> \n> I am not aware of anyone who does. I was just trying to avoid\n> changing the user ABI.\n> \n> Shall I roll a new revision without this patch?\n\nYes please.  I'd rather not carry this around for eternity unless\nit was actually required.\n\nThanks,","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"RXgUIuyW\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3yBkb93V7Fz9t7X\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed, 11 Oct 2017 17:29:09 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2AVs-0001Of-Bu; Wed, 11 Oct 2017 06:29:04 +0000","from orcrist.hmeau.com ([104.223.48.154] helo=deadmen.hmeau.com)\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e2AVn-0001Kv-Gu; Wed, 11 Oct 2017 06:29:02 +0000","from gondobar.mordor.me.apana.org.au ([192.168.128.4]\n\thelo=gondobar)\n\tby deadmen.hmeau.com with esmtp (Exim 4.84_2 #2 (Debian))\n\tid 1e2AU8-0007XM-Qs; Wed, 11 Oct 2017 14:27:16 +0800","from herbert by gondobar with local (Exim 4.84_2)\n\t(envelope-from <herbert@gondor.apana.org.au>)\n\tid 1e2ATj-0004sA-MA; Wed, 11 Oct 2017 14:26:51 +0800"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=0koHKMp/dw18xMsHkdljQD7YlzynryZDnwNbe0ISJJY=;\n\tb=RXgUIuyWwV4Sg3\n\t8hRPP6eUu9Uj1vcwyg6n51PQt0v3wftisVfj76wCnjGISDQ3OYzqD8WSZK5sKB1+0z4ncSbW9yl0+\n\twyYot/AEfotRjQSOMS63RCdeclBeftLKbYoSdkjO25FdHNS/vAIpfM9/SUdUIV1mMC+C0g6iooAs0\n\tfe3Ear4PtCYY2MkKuWxHGPhPZyu66uCCTRdKTlHmBSM5xdFK0U7QSMn5qmCeSTG1QcDCbmstDvP8A\n\tzA6JNAzbOjJsNxsA52cu6oIwlXYVAFzfCQ2jaQUfMNEaUgrBNLAA0T0QtuTWOcqpsDFVcgjRQyzWZ\n\tgzm3CEi4ShkyB+2jzsRg==;","Date":"Wed, 11 Oct 2017 14:26:51 +0800","From":"Herbert Xu <herbert@gondor.apana.org.au>","To":"Gilad Ben-Yossef <gilad@benyossef.com>","Subject":"Re: [PATCH v8 01/20] crypto: change transient busy return code to\n\t-EAGAIN","Message-ID":"<20171011062651.GA18664@gondor.apana.org.au>","References":"<1504615144-29770-1-git-send-email-gilad@benyossef.com>\n\t<1504615144-29770-2-git-send-email-gilad@benyossef.com>\n\t<20171007030541.GA29421@gondor.apana.org.au>\n\t<CAOtvUMd=vtju=VJkCYFRrvANbRRYj+95cdgDoMMfBvmPaPbsAA@mail.gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<CAOtvUMd=vtju=VJkCYFRrvANbRRYj+95cdgDoMMfBvmPaPbsAA@mail.gmail.com>","User-Agent":"Mutt/1.5.23 (2014-03-12)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171010_232900_158476_48B50F33 ","X-CRM114-Status":"GOOD (  15.25  )","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-1.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Mike Snitzer <snitzer@redhat.com>, linux-doc@vger.kernel.org,\n\tGary Hook <gary.hook@amd.com>, David Howells <dhowells@redhat.com>,\n\tdevice-mapper development <dm-devel@redhat.com>,\n\tkeyrings@vger.kernel.org, linux-ima-devel@lists.sourceforge.net,\n\tAlasdair Kergon <agk@redhat.com>, \n\tSteffen Klassert <steffen.klassert@secunet.com>,\n\tBoris Brezillon <boris.brezillon@free-electrons.com>,\n\tJonathan Corbet <corbet@lwn.net>,\n\tAlexey Kuznetsov <kuznet@ms2.inr.ac.ru>, \n\tMimi Zohar <zohar@linux.vnet.ibm.com>,\n\t\"Serge E. Hallyn\" <serge@hallyn.com>, \n\tTom Lendacky <thomas.lendacky@amd.com>, linux-cifs@vger.kernel.org,\n\tlinux-ima-user@lists.sourceforge.net,\n\tArnaud Ebalard <arno@natisbad.org>, \n\tlinux-raid@vger.kernel.org, linux-fscrypt@vger.kernel.org,\n\tlinux-mediatek@lists.infradead.org,\n\tJames Morris <james.l.morris@oracle.com>, \n\tMatthias Brugger <matthias.bgg@gmail.com>,\n\tJaegeuk Kim <jaegeuk@kernel.org>, \n\tlinux-arm-kernel@lists.infradead.org, Ofir Drang <ofir.drang@arm.com>,\n\t\"Theodore Y. Ts'o\" <tytso@mit.edu>,\n\tHideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,\n\tDmitry Kasatkin <dmitry.kasatkin@gmail.com>,\n\tsamba-technical@lists.samba.org, \n\tLinux kernel mailing list <linux-kernel@vger.kernel.org>,\n\tSteve French <sfrench@samba.org>, linux-security-module@vger.kernel.org, \n\tLinux Crypto Mailing List <linux-crypto@vger.kernel.org>,\n\tnetdev@vger.kernel.org, \"David S. Miller\" <davem@davemloft.net>,\n\tShaohua Li <shli@kernel.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]