[{"id":1763043,"web_url":"http://patchwork.ozlabs.org/comment/1763043/","msgid":"<20170905075900.wsroxyp6mzdzjclu@piout.net>","list_archive_url":null,"date":"2017-09-05T07:59:00","subject":"Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 05/09/2017 at 00:53:21 +0200, Andreas Färber wrote:\n> Hello,\n> \n> This series adds the RTC for the Realtek RTD1295 SoC.\n> Based on my RTD1295 clk series.\n> \n> There being no public source code for RTD1295, the implementation is based on\n> register offsets seen in the vendor DT, as well as older mach-rtk119x code\n> published by QNAP.\n> \n> v4 adds a missing clk_put().\n> \n> The DT node depends on the clk series for clock index and header.\n> \n> More experimental patches at:\n> https://github.com/afaerber/linux/commits/rtd1295-next\n> \n> Have a lot of fun!\n> \n> Cheers,\n> Andreas\n> \n> v3 -> v4:\n> * Added clk_put() (Alexandre)\n> \n> v2 -> v3:\n> * Dropped spinlock (Andrew)\n> * Improved year_days vs. days_in_year readability\n> \n> v1 -> v2:\n> * Updated rtc driver to no longer use open/release (Alexandre)\n> * Cleaned up debug output (Andrew)\n> * Avoided COMPILE_TEST division errors (kbuild)\n> * Various cleanups and extensions\n> \n> Cc: Alessandro Zummo <a.zummo@towertech.it>\n> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>\n> Cc: linux-rtc@vger.kernel.org\n> Cc: Roc He <hepeng@zidoo.tv>\n> Cc: 蒋丽琴 <jiang.liqin@geniatech.com>\n> Cc: devicetree@vger.kernel.org\n> Cc: Andrew Lunn <andrew@lunn.ch>\n> \n> Andreas Färber (3):\n>   dt-bindings: rtc: Add Realtek RTD1295\n>   rtc: Add Realtek RTD1295\n>   arm64: dts: realtek: Add RTD1295 RTC node\n> \n>  .../devicetree/bindings/rtc/realtek,rtd119x.txt    |  16 ++\n>  arch/arm64/boot/dts/realtek/rtd1295.dtsi           |   6 +\n>  drivers/rtc/Kconfig                                |   8 +\n>  drivers/rtc/Makefile                               |   1 +\n>  drivers/rtc/rtc-rtd119x.c                          | 242 +++++++++++++++++++++\n>  5 files changed, 273 insertions(+)\n>  create mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.txt\n>  create mode 100644 drivers/rtc/rtc-rtd119x.c\n> \nApplied, thanks.","headers":{"Return-Path":"<linux-rtc-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmfHy221nz9s4q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 17:59:26 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751393AbdIEH7N (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 5 Sep 2017 03:59:13 -0400","from mail.free-electrons.com ([62.4.15.54]:37164 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751313AbdIEH7M (ORCPT\n\t<rfc822;linux-rtc@vger.kernel.org>); Tue, 5 Sep 2017 03:59:12 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid E3777208D4; Tue,  5 Sep 2017 09:59:09 +0200 (CEST)","from localhost (242.171.71.37.rev.sfr.net [37.71.171.242])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id B2D2E20848;\n\tTue,  5 Sep 2017 09:58:59 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 5 Sep 2017 09:59:00 +0200","From":"Alexandre Belloni <alexandre.belloni@free-electrons.com>","To":"Andreas =?iso-8859-1?q?F=E4rber?= <afaerber@suse.de>","Cc":"linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roc\n\tHe <hepeng@zidoo.tv>, =?utf-8?b?6JKL5Li955C0?=\n\t<jiang.liqin@geniatech.com>, Alessandro Zummo <a.zummo@towertech.it>,\n\tlinux-rtc@vger.kernel.org, devicetree@vger.kernel.org, \n\tAndrew Lunn <andrew@lunn.ch>","Subject":"Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC","Message-ID":"<20170905075900.wsroxyp6mzdzjclu@piout.net>","References":"<20170904225324.29138-1-afaerber@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20170904225324.29138-1-afaerber@suse.de>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-rtc.vger.kernel.org>","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1763047,"web_url":"http://patchwork.ozlabs.org/comment/1763047/","msgid":"<12aac585-64f4-f08b-c5bf-b1f0ac124924@suse.de>","list_archive_url":null,"date":"2017-09-05T08:03:58","subject":"Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC","submitter":{"id":9542,"url":"http://patchwork.ozlabs.org/api/people/9542/","name":"Andreas Färber","email":"afaerber@suse.de"},"content":"Am 05.09.2017 um 09:59 schrieb Alexandre Belloni:\n> On 05/09/2017 at 00:53:21 +0200, Andreas Färber wrote:\n>> Hello,\n>>\n>> This series adds the RTC for the Realtek RTD1295 SoC.\n>> Based on my RTD1295 clk series.\n>>\n>> There being no public source code for RTD1295, the implementation is based on\n>> register offsets seen in the vendor DT, as well as older mach-rtk119x code\n>> published by QNAP.\n>>\n>> v4 adds a missing clk_put().\n>>\n>> The DT node depends on the clk series for clock index and header.\n>>\n>> More experimental patches at:\n>> https://github.com/afaerber/linux/commits/rtd1295-next\n>>\n>> Have a lot of fun!\n>>\n>> Cheers,\n>> Andreas\n>>\n>> v3 -> v4:\n>> * Added clk_put() (Alexandre)\n>>\n>> v2 -> v3:\n>> * Dropped spinlock (Andrew)\n>> * Improved year_days vs. days_in_year readability\n>>\n>> v1 -> v2:\n>> * Updated rtc driver to no longer use open/release (Alexandre)\n>> * Cleaned up debug output (Andrew)\n>> * Avoided COMPILE_TEST division errors (kbuild)\n>> * Various cleanups and extensions\n>>\n>> Cc: Alessandro Zummo <a.zummo@towertech.it>\n>> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>\n>> Cc: linux-rtc@vger.kernel.org\n>> Cc: Roc He <hepeng@zidoo.tv>\n>> Cc: 蒋丽琴 <jiang.liqin@geniatech.com>\n>> Cc: devicetree@vger.kernel.org\n>> Cc: Andrew Lunn <andrew@lunn.ch>\n>>\n>> Andreas Färber (3):\n>>   dt-bindings: rtc: Add Realtek RTD1295\n>>   rtc: Add Realtek RTD1295\n>>   arm64: dts: realtek: Add RTD1295 RTC node\n>>\n>>  .../devicetree/bindings/rtc/realtek,rtd119x.txt    |  16 ++\n>>  arch/arm64/boot/dts/realtek/rtd1295.dtsi           |   6 +\n>>  drivers/rtc/Kconfig                                |   8 +\n>>  drivers/rtc/Makefile                               |   1 +\n>>  drivers/rtc/rtc-rtd119x.c                          | 242 +++++++++++++++++++++\n>>  5 files changed, 273 insertions(+)\n>>  create mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.txt\n>>  create mode 100644 drivers/rtc/rtc-rtd119x.c\n>>\n> Applied, thanks.\n\nErr, I am hoping you only queued patches 1-2? Please do not queue patch\n3, that needs to go through my tree as per the comments - it will not build.\n\nThanks,\nAndreas","headers":{"Return-Path":"<linux-rtc-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmfPq1XL9z9s4q\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 18:04:31 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751677AbdIEIEN (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 5 Sep 2017 04:04:13 -0400","from mx2.suse.de ([195.135.220.15]:39234 \"EHLO mx1.suse.de\"\n\trhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP\n\tid S1751630AbdIEIED (ORCPT <rfc822;linux-rtc@vger.kernel.org>);\n\tTue, 5 Sep 2017 04:04:03 -0400","from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 72215ABDE;\n\tTue,  5 Sep 2017 08:04:00 +0000 (UTC)"],"X-Virus-Scanned":"by amavisd-new at test-mx.suse.de","Subject":"Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC","To":"Alexandre Belloni <alexandre.belloni@free-electrons.com>","Cc":"linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roc\n\tHe <hepeng@zidoo.tv>, =?utf-8?b?6JKL5Li955C0?=\n\t<jiang.liqin@geniatech.com>, Alessandro Zummo <a.zummo@towertech.it>,\n\tlinux-rtc@vger.kernel.org, devicetree@vger.kernel.org, \n\tAndrew Lunn <andrew@lunn.ch>","References":"<20170904225324.29138-1-afaerber@suse.de>\n\t<20170905075900.wsroxyp6mzdzjclu@piout.net>","From":"=?utf-8?q?Andreas_F=C3=A4rber?= <afaerber@suse.de>","Organization":"SUSE Linux GmbH","Message-ID":"<12aac585-64f4-f08b-c5bf-b1f0ac124924@suse.de>","Date":"Tue, 5 Sep 2017 10:03:58 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","In-Reply-To":"<20170905075900.wsroxyp6mzdzjclu@piout.net>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"8bit","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-rtc.vger.kernel.org>","X-Mailing-List":"linux-rtc@vger.kernel.org"}},{"id":1763051,"web_url":"http://patchwork.ozlabs.org/comment/1763051/","msgid":"<20170905080905.iddfowmhwxz73ms4@piout.net>","list_archive_url":null,"date":"2017-09-05T08:09:05","subject":"Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC","submitter":{"id":26276,"url":"http://patchwork.ozlabs.org/api/people/26276/","name":"Alexandre Belloni","email":"alexandre.belloni@free-electrons.com"},"content":"On 05/09/2017 at 10:03:58 +0200, Andreas Färber wrote:\n> Am 05.09.2017 um 09:59 schrieb Alexandre Belloni:\n> > On 05/09/2017 at 00:53:21 +0200, Andreas Färber wrote:\n> >> Hello,\n> >>\n> >> This series adds the RTC for the Realtek RTD1295 SoC.\n> >> Based on my RTD1295 clk series.\n> >>\n> >> There being no public source code for RTD1295, the implementation is based on\n> >> register offsets seen in the vendor DT, as well as older mach-rtk119x code\n> >> published by QNAP.\n> >>\n> >> v4 adds a missing clk_put().\n> >>\n> >> The DT node depends on the clk series for clock index and header.\n> >>\n> >> More experimental patches at:\n> >> https://github.com/afaerber/linux/commits/rtd1295-next\n> >>\n> >> Have a lot of fun!\n> >>\n> >> Cheers,\n> >> Andreas\n> >>\n> >> v3 -> v4:\n> >> * Added clk_put() (Alexandre)\n> >>\n> >> v2 -> v3:\n> >> * Dropped spinlock (Andrew)\n> >> * Improved year_days vs. days_in_year readability\n> >>\n> >> v1 -> v2:\n> >> * Updated rtc driver to no longer use open/release (Alexandre)\n> >> * Cleaned up debug output (Andrew)\n> >> * Avoided COMPILE_TEST division errors (kbuild)\n> >> * Various cleanups and extensions\n> >>\n> >> Cc: Alessandro Zummo <a.zummo@towertech.it>\n> >> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>\n> >> Cc: linux-rtc@vger.kernel.org\n> >> Cc: Roc He <hepeng@zidoo.tv>\n> >> Cc: 蒋丽琴 <jiang.liqin@geniatech.com>\n> >> Cc: devicetree@vger.kernel.org\n> >> Cc: Andrew Lunn <andrew@lunn.ch>\n> >>\n> >> Andreas Färber (3):\n> >>   dt-bindings: rtc: Add Realtek RTD1295\n> >>   rtc: Add Realtek RTD1295\n> >>   arm64: dts: realtek: Add RTD1295 RTC node\n> >>\n> >>  .../devicetree/bindings/rtc/realtek,rtd119x.txt    |  16 ++\n> >>  arch/arm64/boot/dts/realtek/rtd1295.dtsi           |   6 +\n> >>  drivers/rtc/Kconfig                                |   8 +\n> >>  drivers/rtc/Makefile                               |   1 +\n> >>  drivers/rtc/rtc-rtd119x.c                          | 242 +++++++++++++++++++++\n> >>  5 files changed, 273 insertions(+)\n> >>  create mode 100644 Documentation/devicetree/bindings/rtc/realtek,rtd119x.txt\n> >>  create mode 100644 drivers/rtc/rtc-rtd119x.c\n> >>\n> > Applied, thanks.\n> \n> Err, I am hoping you only queued patches 1-2? Please do not queue patch\n> 3, that needs to go through my tree as per the comments - it will not build.\n> \n\nYes, I'm not taking DT patches through the RTC tree.\nI didn't receive v4 of the DT patch that's why I forgot to clarify.","headers":{"Return-Path":"<linux-rtc-owner@vger.kernel.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmfWM6p7Vz9s7c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue,  5 Sep 2017 18:09:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1750989AbdIEIJT (ORCPT <rfc822;incoming@patchwork.ozlabs.org>);\n\tTue, 5 Sep 2017 04:09:19 -0400","from mail.free-electrons.com ([62.4.15.54]:37592 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750927AbdIEIJR (ORCPT\n\t<rfc822;linux-rtc@vger.kernel.org>); Tue, 5 Sep 2017 04:09:17 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid A78AF20912; Tue,  5 Sep 2017 10:09:14 +0200 (CEST)","from localhost (242.171.71.37.rev.sfr.net [37.71.171.242])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 69E96208CE;\n\tTue,  5 Sep 2017 10:09:04 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Tue, 5 Sep 2017 10:09:05 +0200","From":"Alexandre Belloni <alexandre.belloni@free-electrons.com>","To":"Andreas =?iso-8859-1?q?F=E4rber?= <afaerber@suse.de>","Cc":"linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roc\n\tHe <hepeng@zidoo.tv>, =?utf-8?b?6JKL5Li955C0?=\n\t<jiang.liqin@geniatech.com>, Alessandro Zummo <a.zummo@towertech.it>,\n\tlinux-rtc@vger.kernel.org, devicetree@vger.kernel.org, \n\tAndrew Lunn <andrew@lunn.ch>","Subject":"Re: [PATCH v4 0/3] arm64: Realtek RTD1295 RTC","Message-ID":"<20170905080905.iddfowmhwxz73ms4@piout.net>","References":"<20170904225324.29138-1-afaerber@suse.de>\n\t<20170905075900.wsroxyp6mzdzjclu@piout.net>\n\t<12aac585-64f4-f08b-c5bf-b1f0ac124924@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<12aac585-64f4-f08b-c5bf-b1f0ac124924@suse.de>","User-Agent":"NeoMutt/20170609 (1.8.3)","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<linux-rtc.vger.kernel.org>","X-Mailing-List":"linux-rtc@vger.kernel.org"}}]