[{"id":1762920,"web_url":"http://patchwork.ozlabs.org/comment/1762920/","msgid":"<0dbfac40-b8e4-9e13-78ee-6be038db8c4e@redhat.com>","list_archive_url":null,"date":"2017-09-05T02:36:01","subject":"Re: [Qemu-devel] [PATCH v9 0/4] Improve error reporting","submitter":{"id":5225,"url":"http://patchwork.ozlabs.org/api/people/5225/","name":"Jason Wang","email":"jasowang@redhat.com"},"content":"On 2017年09月04日 22:35, Mao Zhongyi wrote:\n> v9:\n> * -rebase on upstream\n> -fix the commit message of patch04\n>\n> v8:\n> * PATCH 02 & 04\n> -resetting the error message for the user to read. [Markus Armbruster]\n> -fix the indentation and commit message. [Markus Armbruster]\n> \n> v7:\n> * PATCH 01\n> -fix the error message. [Daniel P. Berrange]\n> -adjust the indentation problem. [Eric Blake]\n> * PATCH 03\n> -print a generic message when gethostbyname() failed in parse_host_port(),\n> drop the misleading \": unkonwn host\" part. [Markus Armbruster]\n>\n> v6:\n> * PATCH 02\n> -rename the subject\n> -drop the \"qemu: error: \" prefix.\n> -correct inappropriate error information settings.\n> * PATCH 03,04\n> -correct inappropriate error information settings. [Markus Armbruster]\n>\n> v5:\n> * PATCH 01 make the commit message more exact about the actual function. [Markus Armbruster]\n> * PATCH 02, 03, 04 still retains the original function, but specific\n> content and order of each patch has been adjusted substantially,\n> so that ensure each patch is a completed fix. [Markus Armbruster]\n>\n> v4:\n> * PATCH 01 is redoing previous patch 1, replace the fprintf() with error_report()\n> \t\t in the 'default' case of net_socket_fd_init() [Markus Armbruster]\n>\n> v3:\n> * PATCH 01 is suggested by Markus and Daniel that removes the dubious 'default' case\n> in the net_socket_fd_init(). Jason agreed.\n> * PATCH 02 is redoing previous patch 4.\n> * PATCH 04 is redoing previous patch 2, improves sort of error messages.\n>\n> v2:\n> * PATCH 02 reworking of patch 2 following Markus's suggestion that convert error_report()\n> in the function called by net_socket_*_init() to Error. Also add many error\n> handling information.\n> * PATCH 03 net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init()\n> use the function such as fprintf, perror to report an error message. Convert it\n> to Error.\n> * PATCH 04 parse_host_port() may fail without reporting an error. Now, fix it to set an\n> error when it fails.\n>\n> Cc: jasowang@redhat.com\n> Cc: armbru@redhat.com\n> Cc: berrange@redhat.com\n> Cc: kraxel@redhat.com\n> Cc: pbonzini@redhat.com\n> Cc: eblake@redhat.com\n>\n> Mao Zhongyi (4):\n> net/socket: Don't treat odd socket type as SOCK_STREAM\n> net/socket: Convert several helper functions to Error\n> net/net: Convert parse_host_port() to Error\n> net/socket: Improve -net socket error reporting\n>\n> include/qemu/sockets.h | 3 +-\n> net/net.c | 22 +++++--\n> net/socket.c | 156 ++++++++++++++++++++++++++++---------------------\n> 3 files changed, 108 insertions(+), 73 deletions(-)\n>\n\nApplied.\n\nThanks","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jasowang@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmW7s0DtQz9s7c\n\tfor ;\n\tTue, 5 Sep 2017 12:36:55 +1000 (AEST)","from localhost ([::1]:56492 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dp3jP-0008E9-EO\n\tfor incoming@patchwork.ozlabs.org; Mon, 04 Sep 2017 22:36:51 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:44976)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dp3j2-0008DR-3G\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:36:32 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dp3ix-0007tu-D7\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:36:28 -0400","from mx1.redhat.com ([209.132.183.28]:39804)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dp3ix-0007sv-3f\n\tfor qemu-devel@nongnu.org; Mon, 04 Sep 2017 22:36:23 -0400","from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id C10417C858;\n\tTue, 5 Sep 2017 02:36:21 +0000 (UTC)","from [10.72.12.71] (ovpn-12-71.pek2.redhat.com [10.72.12.71])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id DA184121E45;\n\tTue, 5 Sep 2017 02:36:04 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com C10417C858","To":"Mao Zhongyi , qemu-devel@nongnu.org","References":"","From":"Jason Wang ","Message-ID":"<0dbfac40-b8e4-9e13-78ee-6be038db8c4e@redhat.com>","Date":"Tue, 5 Sep 2017 10:36:01 +0800","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"","Content-Type":"text/plain; charset=utf-8; format=flowed","Content-Language":"en-US","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.13","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tTue, 05 Sep 2017 02:36:22 +0000 (UTC)","Content-Transfer-Encoding":"quoted-printable","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v9 0/4] Improve error reporting","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"pbonzini@redhat.com, armbru@redhat.com, kraxel@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]