[{"id":1763674,"web_url":"http://patchwork.ozlabs.org/comment/1763674/","msgid":"<20170905.143842.193794174652230489.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-05T21:38:42","subject":"Re: [PATCH v3 net-next 0/2] Use correct sk->sk_prot for IPV6 ","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Ilya Lesokhin \nDate: Mon, 4 Sep 2017 13:13:59 +0300\n\n> The tls ulp overrides sk->prot with a new tls specific proto structs. \n> The tls specific structs were previously based on the ipv4 specific \n> tcp_prot sturct. \n> As a result, attaching the tls ulp to an ipv6 tcp socket replaced \n> some ipv6 callback with the ipv4 equivalents. \n> \n> This patch adds ipv6 tls proto structs and uses them when \n> attached to ipv6 sockets. \n> \n> Changed since v2: \n> - Dropped patch to fix IPV6_ADDRFORM setsockopt\n> There was some disagreement about the correct way of fixinig it,\n> and this series does not depend on it.\n> \n> Changes since v1: \n> - TLS now dependes on IPV6 \n> This fixes complication issues when TLS is built-in and IPV6 is a module. \n> The downside should be small as it is unlikely that there are kernel TLS \n> users who can't afford to include IPV6 in thier kernel. \n\nThis is not acceptable.\n\nForcing such a huge piece of infrastructure like ipv6 to be statically\nbuilt just because someone wants to enable TLS is not going to pass.\n\nEvery distrubtion out there will enable all features, including TLS,\nso effectively you are forcing every distribution to build ipv6\nnon-modules.\n\nSorry, you will have to fix this in a way that allows TLS and IPV6\nto be modular.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xn0TL5XPSz9t2R\n\tfor ;\n\tWed, 6 Sep 2017 07:38:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753228AbdIEVio (ORCPT );\n\tTue, 5 Sep 2017 17:38:44 -0400","from shards.monkeyblade.net ([184.105.139.130]:39630 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752222AbdIEVin (ORCPT\n\t); Tue, 5 Sep 2017 17:38:43 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id D204713DBCAD8;\n\tTue, 5 Sep 2017 14:38:42 -0700 (PDT)"],"Date":"Tue, 05 Sep 2017 14:38:42 -0700 (PDT)","Message-Id":"<20170905.143842.193794174652230489.davem@davemloft.net>","To":"ilyal@mellanox.com","Cc":"netdev@vger.kernel.org, davejwatson@fb.com, aviadye@mellanox.com","Subject":"Re: [PATCH v3 net-next 0/2] Use correct sk->sk_prot for IPV6 ","From":"David Miller ","In-Reply-To":"<1504520041-55634-1-git-send-email-ilyal@mellanox.com>","References":"<1504520041-55634-1-git-send-email-ilyal@mellanox.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Tue, 05 Sep 2017 14:38:43 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]