[{"id":1762414,"web_url":"http://patchwork.ozlabs.org/comment/1762414/","msgid":"<20170904045645.fb6scegrypdodvfl@ninjato>","list_archive_url":null,"date":"2017-09-04T04:56:47","subject":"Re: [PATCH v4 0/3] i2c: Hookup typec power-negotation to the PMIC\n\tand charger","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"Hi,\n\n> The first 2 patches are i2c patches, if you could review and\n> merge these (preferably for 4.14, but 4.15 is fine too) that would\n> be great.\n\nDefinately for v4.15 and I very likely won't be able to review them\nbefore rc1 or rc2 time, if even that. Sorry, but I2C core changes need\nextra careful review and I2C maintenance is largely done in my limited\nspare time. If you could get other people to review/tag the patches,\nthis would be very helpful.\n\n> Darren, Andy, the single platform/x86 patch in here should only\n> be merged after the 2 i2c patches are in place, otherwise users\n> of the board(s) in question will end up not having any battery\n> monitoring. Also note that this patch applies on top of the\n> \"[PATCH v2] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices\"\n> patch I send out yesterday.\n\nIs that dependency for v4.14? Would it be an idea if I take the platform\npatch via the i2c tree then?\n\nRegards,\n\n Wolfram","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xlyHn4HR4z9sDB\n\tfor ;\n\tMon, 4 Sep 2017 14:56:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753307AbdIDE4v (ORCPT );\n\tMon, 4 Sep 2017 00:56:51 -0400","from sauhun.de ([88.99.104.3]:37423 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751714AbdIDE4v (ORCPT );\n\tMon, 4 Sep 2017 00:56:51 -0400","from localhost (88.red-79-157-204.dynamicip.rima-tde.net\n\t[79.157.204.88])\n\tby pokefinder.org (Postfix) with ESMTPSA id 76CAF2C337B;\n\tMon, 4 Sep 2017 06:56:48 +0200 (CEST)"],"Date":"Mon, 4 Sep 2017 06:56:47 +0200","From":"Wolfram Sang ","To":"Hans de Goede ","Cc":"Darren Hart , Andy Shevchenko ,\n\tGuenter Roeck ,\n\tHeikki Krogerus ,\n\tplatform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-i2c@vger.kernel.org","Subject":"Re: [PATCH v4 0/3] i2c: Hookup typec power-negotation to the PMIC\n\tand charger","Message-ID":"<20170904045645.fb6scegrypdodvfl@ninjato>","References":"<20170903124156.7440-1-hdegoede@redhat.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"rng2v3ppofqxig3k\"","Content-Disposition":"inline","In-Reply-To":"<20170903124156.7440-1-hdegoede@redhat.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1762637,"web_url":"http://patchwork.ozlabs.org/comment/1762637/","msgid":"","list_archive_url":null,"date":"2017-09-04T13:33:22","subject":"Re: [PATCH v4 0/3] i2c: Hookup typec power-negotation to the PMIC\n\tand charger","submitter":{"id":1893,"url":"http://patchwork.ozlabs.org/api/people/1893/","name":"Hans de Goede","email":"hdegoede@redhat.com"},"content":"Hi,\n\nOn 04-09-17 06:56, Wolfram Sang wrote:\n> Hi,\n> \n>> The first 2 patches are i2c patches, if you could review and\n>> merge these (preferably for 4.14, but 4.15 is fine too) that would\n>> be great.\n> \n> Definately for v4.15 and I very likely won't be able to review them\n> before rc1 or rc2 time, if even that. Sorry, but I2C core changes need\n> extra careful review and I2C maintenance is largely done in my limited\n> spare time.\n\nOk, I understand.\n\n> If you could get other people to review/tag the patches,\n> this would be very helpful.\n\nFWIW althought the first patch is a core change it is not really a big\none and won't impact any existing drivers, but I fully understand\nyou still want to take your time to review it.\n\nAndy (Shevchenko) can you perhaps take a look at the first patch\nin this series and give your opinion on it ?\n\n>> Darren, Andy, the single platform/x86 patch in here should only\n>> be merged after the 2 i2c patches are in place, otherwise users\n>> of the board(s) in question will end up not having any battery\n>> monitoring. Also note that this patch applies on top of the\n>> \"[PATCH v2] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices\"\n>> patch I send out yesterday.\n> \n> Is that dependency for v4.14?\n\nYes that dep should make 4.14.\n\n> Would it be an idea if I take the platform\n> patch via the i2c tree then?\n\nI've some other patches pending which require further changes to the\nintel_cht_int33fe driver (*), so I think it would be best if the last\npatch got merged through the platform/x86 tree. The dependencies\nbetween patch 2-3 are runtime only (and not fatal if missing, just\ninconvenient) so merging this to 2 separate trees should be fine\nas long as both patches get merged for 4.15.\n\nRegards,\n\nHans\n\n\n*) The intel_cht_int33fe and i2c/busses/i2c-cht-wc drivers together\ninstantiate 4 i2c devices which together make all the \"magic\" behind\nthe Type-C connector on these boards happen. The patch-series\ncompleted by these 3 patches ties 3 of the 4 drivers together so\nthat charging and battery monitoring fully works. Ideally all 4\ni2c-clients would be instantiated from a single place, e.g.\nintel_cht_int33fe.c, but the charger is hooked up through a \"child\"\ni2c bus on the pmic, which is where i2c/busses/i2c-cht-wc.c\ncomes into play.\n\nThe next series adds support for the 4th chip, the type-c cross-switch/\nmux which is necessary to get superspeed usb and/or displayport working\nover the Type-C connector.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=hdegoede@redhat.com"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm9lq4rZfz9sR9\n\tfor ;\n\tMon, 4 Sep 2017 23:33:27 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753625AbdIDNd0 (ORCPT );\n\tMon, 4 Sep 2017 09:33:26 -0400","from mx1.redhat.com ([209.132.183.28]:50334 \"EHLO mx1.redhat.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752835AbdIDNdZ (ORCPT );\n\tMon, 4 Sep 2017 09:33:25 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D4ACE78EB2;\n\tMon, 4 Sep 2017 13:33:24 +0000 (UTC)","from shalem.localdomain (unknown [10.36.118.49])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 5A5A6C0DB6;\n\tMon, 4 Sep 2017 13:33:23 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D4ACE78EB2","Subject":"Re: [PATCH v4 0/3] i2c: Hookup typec power-negotation to the PMIC\n\tand charger","To":"Wolfram Sang ","Cc":"Darren Hart , Andy Shevchenko ,\n\tGuenter Roeck ,\n\tHeikki Krogerus ,\n\tplatform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-i2c@vger.kernel.org","References":"<20170903124156.7440-1-hdegoede@redhat.com>\n\t<20170904045645.fb6scegrypdodvfl@ninjato>","From":"Hans de Goede ","Message-ID":"","Date":"Mon, 4 Sep 2017 15:33:22 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904045645.fb6scegrypdodvfl@ninjato>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.15","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tMon, 04 Sep 2017 13:33:25 +0000 (UTC)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}},{"id":1762659,"web_url":"http://patchwork.ozlabs.org/comment/1762659/","msgid":"<20170904135614.w3v3yvrrqructa37@ninjato>","list_archive_url":null,"date":"2017-09-04T13:56:14","subject":"Re: [PATCH v4 0/3] i2c: Hookup typec power-negotation to the PMIC\n\tand charger","submitter":{"id":22495,"url":"http://patchwork.ozlabs.org/api/people/22495/","name":"Wolfram Sang","email":"wsa@the-dreams.de"},"content":"> I've some other patches pending which require further changes to the\n> intel_cht_int33fe driver (*), so I think it would be best if the last\n> patch got merged through the platform/x86 tree. The dependencies\n> between patch 2-3 are runtime only (and not fatal if missing, just\n> inconvenient) so merging this to 2 separate trees should be fine\n> as long as both patches get merged for 4.15.\n\nOK. So, I'll just look at the first two patches. You'll know when I done\nthis.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-i2c-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmBGC2wwGz9t2R\n\tfor ;\n\tMon, 4 Sep 2017 23:56:19 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753741AbdIDN4R (ORCPT );\n\tMon, 4 Sep 2017 09:56:17 -0400","from sauhun.de ([88.99.104.3]:38754 \"EHLO pokefinder.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1753591AbdIDN4R (ORCPT );\n\tMon, 4 Sep 2017 09:56:17 -0400","from localhost (161.red-95-123-144.staticip.rima-tde.net\n\t[95.123.144.161])\n\tby pokefinder.org (Postfix) with ESMTPSA id 87B2F2C3639;\n\tMon, 4 Sep 2017 15:56:15 +0200 (CEST)"],"Date":"Mon, 4 Sep 2017 15:56:14 +0200","From":"Wolfram Sang ","To":"Hans de Goede ","Cc":"Darren Hart , Andy Shevchenko ,\n\tGuenter Roeck ,\n\tHeikki Krogerus ,\n\tplatform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tlinux-i2c@vger.kernel.org","Subject":"Re: [PATCH v4 0/3] i2c: Hookup typec power-negotation to the PMIC\n\tand charger","Message-ID":"<20170904135614.w3v3yvrrqructa37@ninjato>","References":"<20170903124156.7440-1-hdegoede@redhat.com>\n\t<20170904045645.fb6scegrypdodvfl@ninjato>\n\t","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"awn2vh3ydoalziol\"","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"NeoMutt/20170113 (1.7.2)","Sender":"linux-i2c-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-i2c@vger.kernel.org"}}]