[{"id":1761927,"web_url":"http://patchwork.ozlabs.org/comment/1761927/","msgid":"<20170901121217.33e93cf9@xeon-e3>","list_archive_url":null,"date":"2017-09-01T19:12:17","subject":"Re: [iproute PATCH 0/6] strlcpy() and strlcat() for iproute2","submitter":{"id":21389,"url":"http://patchwork.ozlabs.org/api/people/21389/","name":"Stephen Hemminger","email":"stephen@networkplumber.org"},"content":"On Fri, 1 Sep 2017 18:52:50 +0200\nPhil Sutter wrote:\n\n> The following series adds my own implementations of strlcpy() and\n> strlcat() in patch 1 and changes the code to make use of them in the\n> following patches but the last two: Patch 5 just eliminates a line of\n> useless code I found while searching for potential users of the\n> introduced functions, patch 6 sanitizes a call to strncpy() in\n> misc/lnstat_util.c without using strlcpy() since lnstat is not being\n> linked against libutil.\n> \n> I implemented both functions solely based on information in libbsd's man\n> pages, so they are safe to be released under the GPL.\n> \n> Phil Sutter (6):\n> utils: Implement strlcpy() and strlcat()\n> Convert the obvious cases to strlcpy()\n> Convert harmful calls to strncpy() to strlcpy()\n> ipxfrm: Replace STRBUF_CAT macro with strlcat()\n> tc_util: No need to terminate an snprintf'ed buffer\n> lnstat_util: Make sure buffer is NUL-terminated\n> \n> genl/ctrl.c | 2 +-\n> include/utils.h | 3 +++\n> ip/ipnetns.c | 3 +--\n> ip/iproute_lwtunnel.c | 3 +--\n> ip/ipvrf.c | 5 ++---\n> ip/ipxfrm.c | 21 +++++----------------\n> ip/xfrm_state.c | 2 +-\n> lib/bpf.c | 3 +--\n> lib/fs.c | 3 +--\n> lib/inet_proto.c | 3 +--\n> lib/utils.c | 19 +++++++++++++++++++\n> misc/lnstat_util.c | 3 ++-\n> misc/ss.c | 3 +--\n> tc/em_ipset.c | 3 +--\n> tc/tc_util.c | 1 -\n> 15 files changed, 40 insertions(+), 37 deletions(-)\n> \n\nApplied, thanks.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=networkplumber-org.20150623.gappssmtp.com\n\theader.i=@networkplumber-org.20150623.gappssmtp.com\n\theader.b=\"CpMu6oUU\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkTQH5HdMz9sPm\n\tfor ;\n\tSat, 2 Sep 2017 05:12:23 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752252AbdIATMV (ORCPT );\n\tFri, 1 Sep 2017 15:12:21 -0400","from mail-pf0-f177.google.com ([209.85.192.177]:33135 \"EHLO\n\tmail-pf0-f177.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751715AbdIATMU (ORCPT\n\t); Fri, 1 Sep 2017 15:12:20 -0400","by mail-pf0-f177.google.com with SMTP id n73so3012206pfj.0\n\tfor ; Fri, 01 Sep 2017 12:12:20 -0700 (PDT)","from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])\n\tby smtp.gmail.com with ESMTPSA id\n\tt73sm1162019pfg.76.2017.09.01.12.12.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 12:12:19 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=6AHcwI19vGZpRvMyFLuZhGhToO6pdhopazXrS01hTjw=;\n\tb=CpMu6oUUPy4Hwx26k7G8hBjXOeTK5R9/TNNOS6kv7HDf4/G4SLBfieRPKjVKMGS1GQ\n\tVaVaQUd535sllCWnQp1otesomIB9SS+lgrlkMPMQ4j07CxGBAiZr1rzV/Tv3bkmdvSRn\n\toor4Q4sFteT8g/P9rttsK4XaFPBm8lU5J/9TTxIPC2PPOlNj13aqk25JBA4dqT6GiAbB\n\tJOXo3rfnjxGni/wfJTc8rZhN2HEsCdPsSZ5rTDhu/NIFvp/GV7zGdb4gPxiwIz//Tv67\n\tm72bd2/NwmARQRCVK5d8Q7WnGz6+wOxHabtWoZXkrqRKxmAGKgNVGYjt68yj6ACFM6GC\n\to4AA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=6AHcwI19vGZpRvMyFLuZhGhToO6pdhopazXrS01hTjw=;\n\tb=PwtpLOk0XxCENlaeawezwvCwsI2FbxHuixEZx/3pPlU0IMg5eVwBB50Nvlb2LlaZc7\n\tc6un/zCA5rb4Ag2V8Kvln27+LYPE/IN5/NHhnA1YxLMdWGUX1GgZjMXARqBEODsmRM06\n\tVbTJPBkGsko964jL/rKC2dYXBeeTeTbWwkd7SOZ++Cbx5iiOCWwois7yf6YFsQL3D8A/\n\t6IFUT7foqG6bhoPj0Vx77mXg1ZKCHhqlQY3FvHYCi2sJ7XaOhtpkhuYGHPLJXphnuKOV\n\t1YUbCoquJMYo8PDpdekPd6rMVOF2aYVIWMVmFspCfJaTYFiuEy083evWrE2Cwe2B8M90\n\tWBrQ==","X-Gm-Message-State":"AHPjjUhCjEJXSBNLY901sGaEC/M58hVAwmHI+GUbqeGK7htd1W12j0SZ\n\t6DzT5pMY7ZR9mN9r","X-Google-Smtp-Source":"ADKCNb77BzO/j6CV1cks90PM8u0Q/htZZeqOo/6az7K1mlBuQuZhqBA5BlgaWPvnLLj14CxvsXxQjg==","X-Received":"by 10.84.225.20 with SMTP id t20mr3773392plj.172.1504293139686; \n\tFri, 01 Sep 2017 12:12:19 -0700 (PDT)","Date":"Fri, 1 Sep 2017 12:12:17 -0700","From":"Stephen Hemminger ","To":"Phil Sutter ","Cc":"netdev@vger.kernel.org","Subject":"Re: [iproute PATCH 0/6] strlcpy() and strlcat() for iproute2","Message-ID":"<20170901121217.33e93cf9@xeon-e3>","In-Reply-To":"<20170901165256.21459-1-phil@nwl.cc>","References":"<20170901165256.21459-1-phil@nwl.cc>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]