[{"id":1762095,"web_url":"http://patchwork.ozlabs.org/comment/1762095/","msgid":"<495813cc0e2ea09e495bfe14d595b926@aosc.io>","list_archive_url":null,"date":"2017-09-02T07:01:57","subject":"Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1\n\ton Nanopi M1 Plus","submitter":{"id":71295,"url":"http://patchwork.ozlabs.org/api/people/71295/","name":"Icenowy Zheng","email":"icenowy@aosc.io"},"content":"在 2017-09-02 00:30，Philipp Rossak 写道：\n> From: Philipp Rossak <embed3d@gmail.com>\n> \n> The WiFi side of the AP6212 WiFi/BT combo module is connected to\n> mmc1. There are also GPIOs for enable and interrupts.\n> \n> Enable WiFi on this board by enabling mmc1 and adding the power\n> sequencing clocks and GPIO, as well as the chip's interrupt line.\n> \n> Signed-off-by: Philipp Rossak <embed3d@gmail.com>\n> ---\n>  arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 25 \n> +++++++++++++++++++++++++\n>  1 file changed, 25 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> index 6256f55..7d18c35 100644\n> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> @@ -48,6 +48,13 @@\n> \n>  \taliases {\n>  \t\tserial1 = &uart3;\n> +\t\tethernet1 = &sdio_wifi;\n\nWhen the Wi-Fi module itself has fixed MAC address, there's\nno need for such an alias.\n\n> +\t};\n> +\n> +\twifi_pwrseq: wifi_pwrseq {\n> +\t\tcompatible = \"mmc-pwrseq-simple\";\n> +\t\tpinctrl-names = \"default\";\n> +\t\treset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */\n>  \t};\n>  };\n> \n> @@ -65,6 +72,24 @@\n>  \tstatus = \"okay\";\n>  };\n> \n> +&mmc1 {\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&mmc1_pins_a>;\n> +\tvmmc-supply = <&reg_vcc3v3>;\n> +\tmmc-pwrseq = <&wifi_pwrseq>;\n> +\tbus-width = <4>;\n> +\tnon-removable;\n> +\tstatus = \"okay\";\n> +\n> +\tsdio_wifi: sdio_wifi@1 {\n> +\t\treg = <1>;\n> +\t\tcompatible = \"brcm,bcm4329-fmac\";\n> +\t\tinterrupt-parent = <&pio>;\n> +\t\tinterrupts = <6 10 IRQ_TYPE_LEVEL_LOW>; /* PG10 / EINT10 */\n> +\t\tinterrupt-names = \"host-wake\";\n> +\t};\n> +};\n> +\n>  &ohci1 {\n>  \tstatus = \"okay\";\n>  };\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkn951KPwz9s7M\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tSat,  2 Sep 2017 17:02:01 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751510AbdIBHB7 (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tSat, 2 Sep 2017 03:01:59 -0400","from hermes.aosc.io ([199.195.250.187]:59891 \"EHLO hermes.aosc.io\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751460AbdIBHB7 (ORCPT <rfc822;devicetree@vger.kernel.org>);\n\tSat, 2 Sep 2017 03:01:59 -0400","from localhost (localhost [127.0.0.1]) (Authenticated sender:\n\ticenowy@aosc.io)\n\tby hermes.aosc.io (Postfix) with ESMTPSA id 4A5064666C;\n\tSat,  2 Sep 2017 07:01:57 +0000 (UTC)"],"MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8;\n format=flowed","Content-Transfer-Encoding":"8bit","Date":"Sat, 02 Sep 2017 15:01:57 +0800","From":"icenowy@aosc.io","To":"Philipp Rossak <embed3d@gmail.com>","Cc":"robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,\n\tmaxime.ripard@free-electrons.com, wens@csie.org,\n\tdevicetree@vger.kernel.org, linux-sunxi@googlegroups.com,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1\n\ton Nanopi M1 Plus","In-Reply-To":"<1504283401-4263-2-git-send-email-embed3d@gmail.com>","References":"<1504283401-4263-1-git-send-email-embed3d@gmail.com>\n\t<1504283401-4263-2-git-send-email-embed3d@gmail.com>","Message-ID":"<495813cc0e2ea09e495bfe14d595b926@aosc.io>","X-Sender":"icenowy@aosc.io","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762501,"web_url":"http://patchwork.ozlabs.org/comment/1762501/","msgid":"<20170904080255.3aywcccu4io2fvxi@flea>","list_archive_url":null,"date":"2017-09-04T08:02:55","subject":"Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1\n\ton Nanopi M1 Plus","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi Philipp,\n\nOn Fri, Sep 01, 2017 at 06:30:00PM +0200, Philipp Rossak wrote:\n> From: Philipp Rossak <embed3d@gmail.com>\n> \n> The WiFi side of the AP6212 WiFi/BT combo module is connected to\n> mmc1. There are also GPIOs for enable and interrupts.\n> \n> Enable WiFi on this board by enabling mmc1 and adding the power\n> sequencing clocks and GPIO, as well as the chip's interrupt line.\n> \n> Signed-off-by: Philipp Rossak <embed3d@gmail.com>\n> ---\n>  arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 25 +++++++++++++++++++++++++\n>  1 file changed, 25 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> index 6256f55..7d18c35 100644\n> --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> @@ -48,6 +48,13 @@\n>  \n>  \taliases {\n>  \t\tserial1 = &uart3;\n> +\t\tethernet1 = &sdio_wifi;\n> +\t};\n> +\n> +\twifi_pwrseq: wifi_pwrseq {\n> +\t\tcompatible = \"mmc-pwrseq-simple\";\n> +\t\tpinctrl-names = \"default\";\n> +\t\treset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */\n>  \t};\n>  };\n>  \n> @@ -65,6 +72,24 @@\n>  \tstatus = \"okay\";\n>  };\n>  \n> +&mmc1 {\n> +\tpinctrl-names = \"default\";\n> +\tpinctrl-0 = <&mmc1_pins_a>;\n> +\tvmmc-supply = <&reg_vcc3v3>;\n\nI know I told you you weren't needing vqmmc, but Chen-Yu later told me\nthat I was wrong about this.\n\nI've added vqmmc back, and applied your patch.\n\nThanks!\nMaxime","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm2RB6855z9s8J\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tMon,  4 Sep 2017 18:03:34 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751949AbdIDIDO (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tMon, 4 Sep 2017 04:03:14 -0400","from mail.free-electrons.com ([62.4.15.54]:35034 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753270AbdIDIDG (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Mon, 4 Sep 2017 04:03:06 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 7D35020970; Mon,  4 Sep 2017 10:03:04 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 4C02F209B0;\n\tMon,  4 Sep 2017 10:02:54 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 4 Sep 2017 10:02:55 +0200","From":"Maxime Ripard <maxime.ripard@free-electrons.com>","To":"Philipp Rossak <embed3d@gmail.com>","Cc":"robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,\n\twens@csie.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com","Subject":"Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1\n\ton Nanopi M1 Plus","Message-ID":"<20170904080255.3aywcccu4io2fvxi@flea>","References":"<1504283401-4263-1-git-send-email-embed3d@gmail.com>\n\t<1504283401-4263-2-git-send-email-embed3d@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"iinwv3hxe3mal5qx\"","Content-Disposition":"inline","In-Reply-To":"<1504283401-4263-2-git-send-email-embed3d@gmail.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762502,"web_url":"http://patchwork.ozlabs.org/comment/1762502/","msgid":"<20170904080415.ptgjnkjwtdthp7ds@flea>","list_archive_url":null,"date":"2017-09-04T08:04:15","subject":"Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1\n\ton Nanopi M1 Plus","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"On Sat, Sep 02, 2017 at 03:01:57PM +0800, icenowy@aosc.io wrote:\n> 在 2017-09-02 00:30，Philipp Rossak 写道：\n> > From: Philipp Rossak <embed3d@gmail.com>\n> > \n> > The WiFi side of the AP6212 WiFi/BT combo module is connected to\n> > mmc1. There are also GPIOs for enable and interrupts.\n> > \n> > Enable WiFi on this board by enabling mmc1 and adding the power\n> > sequencing clocks and GPIO, as well as the chip's interrupt line.\n> > \n> > Signed-off-by: Philipp Rossak <embed3d@gmail.com>\n> > ---\n> >  arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 25\n> > +++++++++++++++++++++++++\n> >  1 file changed, 25 insertions(+)\n> > \n> > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> > b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> > index 6256f55..7d18c35 100644\n> > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts\n> > @@ -48,6 +48,13 @@\n> > \n> >  \taliases {\n> >  \t\tserial1 = &uart3;\n> > +\t\tethernet1 = &sdio_wifi;\n> \n> When the Wi-Fi module itself has fixed MAC address, there's\n> no need for such an alias.\n\nBut the description is also accurate, which is what matters in the DT.\n\nMaxime","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm2SF0LgNz9s8J\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tMon,  4 Sep 2017 18:04:29 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753291AbdIDIE1 (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tMon, 4 Sep 2017 04:04:27 -0400","from mail.free-electrons.com ([62.4.15.54]:35109 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753306AbdIDIE1 (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Mon, 4 Sep 2017 04:04:27 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid AF79B2097F; Mon,  4 Sep 2017 10:04:24 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 8552E207C8;\n\tMon,  4 Sep 2017 10:04:14 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 4 Sep 2017 10:04:15 +0200","From":"Maxime Ripard <maxime.ripard@free-electrons.com>","To":"icenowy@aosc.io","Cc":"Philipp Rossak <embed3d@gmail.com>, robh+dt@kernel.org,\n\tmark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org,\n\tdevicetree@vger.kernel.org, linux-sunxi@googlegroups.com,\n\tlinux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1\n\ton Nanopi M1 Plus","Message-ID":"<20170904080415.ptgjnkjwtdthp7ds@flea>","References":"<1504283401-4263-1-git-send-email-embed3d@gmail.com>\n\t<1504283401-4263-2-git-send-email-embed3d@gmail.com>\n\t<495813cc0e2ea09e495bfe14d595b926@aosc.io>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"ecju2d4hub3viizq\"","Content-Disposition":"inline","In-Reply-To":"<495813cc0e2ea09e495bfe14d595b926@aosc.io>","User-Agent":"NeoMutt/20170714 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762505,"web_url":"http://patchwork.ozlabs.org/comment/1762505/","msgid":"<20170904080519.mec6ypjei7uvo5k7@flea>","list_archive_url":null,"date":"2017-09-04T08:05:19","subject":"Re: [PATCH v2 2/2] ARM: dts: sun8i: h3: Improved Wifi bindings on\n\tBananapi M2 Plus","submitter":{"id":12916,"url":"http://patchwork.ozlabs.org/api/people/12916/","name":"Maxime Ripard","email":"maxime.ripard@free-electrons.com"},"content":"Hi Philipp,\n\nOn Fri, Sep 01, 2017 at 06:30:01PM +0200, Philipp Rossak wrote:\n> From: Philipp Rossak <embed3d@gmail.com>\n> \n> * vqmmc is in this case not needed\n> * no need for pincontrol nodes when the pin is set to a GPIO\n> \n> Signed-off-by: Philipp Rossak <embed3d@gmail.com>\n> ---\n>  arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 7 -------\n>  1 file changed, 7 deletions(-)\n> \n> diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts\n> index d756ff8..f7e5d8a 100644\n> --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts\n> +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts\n> @@ -98,7 +98,6 @@\n>  \twifi_pwrseq: wifi_pwrseq {\n>  \t\tcompatible = \"mmc-pwrseq-simple\";\n>  \t\tpinctrl-names = \"default\";\n> -\t\tpinctrl-0 = <&wifi_en_bpi_m2p>;\n>  \t\treset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */\n>  \t};\n>  };\n> @@ -153,7 +152,6 @@\n>  \tpinctrl-names = \"default\";\n>  \tpinctrl-0 = <&mmc1_pins_a>;\n>  \tvmmc-supply = <&reg_vcc3v3>;\n> -\tvqmmc-supply = <&reg_vcc3v3>;\n\nSo we actually need this one.\n\n>  \tmmc-pwrseq = <&wifi_pwrseq>;\n>  \tbus-width = <4>;\n>  \tnon-removable;\n> @@ -200,11 +198,6 @@\n>  \t\tpins = \"PL3\";\n>  \t\tfunction = \"gpio_in\";\n>  \t};\n> -\n> -\twifi_en_bpi_m2p: wifi_en_pin {\n> -\t\tpins = \"PL7\";\n> -\t\tfunction = \"gpio_out\";\n> -\t};\n\nAnd there's also other GPIO pins here, I'd prefer if you could tackle\nthem all at once.\n\nThanks!\nMaxime","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xm2Tp4p7vz9s82\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tMon,  4 Sep 2017 18:05:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753318AbdIDIFb (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tMon, 4 Sep 2017 04:05:31 -0400","from mail.free-electrons.com ([62.4.15.54]:35146 \"EHLO\n\tmail.free-electrons.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751949AbdIDIFb (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Mon, 4 Sep 2017 04:05:31 -0400","by mail.free-electrons.com (Postfix, from userid 110)\n\tid 9E85620A08; Mon,  4 Sep 2017 10:05:28 +0200 (CEST)","from localhost (LStLambert-657-1-97-87.w90-63.abo.wanadoo.fr\n\t[90.63.216.87])\n\tby mail.free-electrons.com (Postfix) with ESMTPSA id 77F7B209D1;\n\tMon,  4 Sep 2017 10:05:18 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on\n\tmail.free-electrons.com","X-Spam-Level":"","X-Spam-Status":"No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT,\n\tURIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0","Date":"Mon, 4 Sep 2017 10:05:19 +0200","From":"Maxime Ripard <maxime.ripard@free-electrons.com>","To":"Philipp Rossak <embed3d@gmail.com>","Cc":"robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,\n\twens@csie.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com","Subject":"Re: [PATCH v2 2/2] ARM: dts: sun8i: h3: Improved Wifi bindings on\n\tBananapi M2 Plus","Message-ID":"<20170904080519.mec6ypjei7uvo5k7@flea>","References":"<1504283401-4263-1-git-send-email-embed3d@gmail.com>\n\t<1504283401-4263-3-git-send-email-embed3d@gmail.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha1;\n\tprotocol=\"application/pgp-signature\"; boundary=\"m2x3r73jxsrlo2md\"","Content-Disposition":"inline","In-Reply-To":"<1504283401-4263-3-git-send-email-embed3d@gmail.com>","User-Agent":"NeoMutt/20170714 (1.8.3)","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}},{"id":1762653,"web_url":"http://patchwork.ozlabs.org/comment/1762653/","msgid":"<db2d8aed-b3da-7766-1fe5-6ef5d6c5578b@gmail.com>","list_archive_url":null,"date":"2017-09-04T13:52:36","subject":"Re: [PATCH v2 2/2] ARM: dts: sun8i: h3: Improved Wifi bindings on\n\tBananapi M2 Plus","submitter":{"id":72018,"url":"http://patchwork.ozlabs.org/api/people/72018/","name":"Philipp Rossak","email":"embed3d@gmail.com"},"content":"Hi Maxime\n\nAm 04.09.2017 um 10:05 schrieb Maxime Ripard:\n> Hi Philipp,\n> \n> On Fri, Sep 01, 2017 at 06:30:01PM +0200, Philipp Rossak wrote:\n>> From: Philipp Rossak <embed3d@gmail.com>\n>>\n>> * vqmmc is in this case not needed\n>> * no need for pincontrol nodes when the pin is set to a GPIO\n>>\n>> Signed-off-by: Philipp Rossak <embed3d@gmail.com>\n>> ---\n>>   arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts | 7 -------\n>>   1 file changed, 7 deletions(-)\n>>\n>> diff --git a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts\n>> index d756ff8..f7e5d8a 100644\n>> --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts\n>> +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts\n>> @@ -98,7 +98,6 @@\n>>   \twifi_pwrseq: wifi_pwrseq {\n>>   \t\tcompatible = \"mmc-pwrseq-simple\";\n>>   \t\tpinctrl-names = \"default\";\n>> -\t\tpinctrl-0 = <&wifi_en_bpi_m2p>;\n>>   \t\treset-gpios = <&r_pio 0 7 GPIO_ACTIVE_LOW>; /* PL7 */\n>>   \t};\n>>   };\n>> @@ -153,7 +152,6 @@\n>>   \tpinctrl-names = \"default\";\n>>   \tpinctrl-0 = <&mmc1_pins_a>;\n>>   \tvmmc-supply = <&reg_vcc3v3>;\n>> -\tvqmmc-supply = <&reg_vcc3v3>;\n> \n> So we actually need this one.\n> \n>>   \tmmc-pwrseq = <&wifi_pwrseq>;\n>>   \tbus-width = <4>;\n>>   \tnon-removable;\n>> @@ -200,11 +198,6 @@\n>>   \t\tpins = \"PL3\";\n>>   \t\tfunction = \"gpio_in\";\n>>   \t};\n>> -\n>> -\twifi_en_bpi_m2p: wifi_en_pin {\n>> -\t\tpins = \"PL7\";\n>> -\t\tfunction = \"gpio_out\";\n>> -\t};\n> \n> And there's also other GPIO pins here, I'd prefer if you could tackle\n> them all at once.\n> \n> Thanks!\n> Maxime\n> \nThanks for the feedback!\nI will fix that with a new single Patch in the next Days.\n\nPhilipp\n--\nTo unsubscribe from this list: send the line \"unsubscribe devicetree\" in\nthe body of a message to majordomo@vger.kernel.org\nMore majordomo info at  http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"<devicetree-owner@vger.kernel.org>","X-Original-To":"incoming-dt@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-dt@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=devicetree-owner@vger.kernel.org; receiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XZWT/6il\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmBB33qYLz9t39\n\tfor <incoming-dt@patchwork.ozlabs.org>;\n\tMon,  4 Sep 2017 23:52:43 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753599AbdIDNwm (ORCPT\n\t<rfc822;incoming-dt@patchwork.ozlabs.org>);\n\tMon, 4 Sep 2017 09:52:42 -0400","from mail-wm0-f66.google.com ([74.125.82.66]:32888 \"EHLO\n\tmail-wm0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1753557AbdIDNwl (ORCPT\n\t<rfc822; devicetree@vger.kernel.org>); Mon, 4 Sep 2017 09:52:41 -0400","by mail-wm0-f66.google.com with SMTP id 187so404383wmn.0;\n\tMon, 04 Sep 2017 06:52:40 -0700 (PDT)","from [192.168.2.12] (p5B3DD0C2.dip0.t-ipconnect.de.\n\t[91.61.208.194]) by smtp.gmail.com with ESMTPSA id\n\tt5sm574401wma.44.2017.09.04.06.52.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 04 Sep 2017 06:52:39 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:to:cc:references:from:message-id:date:user-agent\n\t:mime-version:in-reply-to:content-language:content-transfer-encoding; \n\tbh=ELOkIq6FfVYypb4EQKy9swRAcz/VxCIMVwXmofqrub0=;\n\tb=XZWT/6ilYSWfrBMjs0BGobPBfRXT2elnmwSsqp4YZgLkLNui3xmvynwgxASp02ciyg\n\t+8LSiP93eAtdRriRwR56Yb0kkWYpSfb519zUPFX9DhqE13ljZFtaRgy3yEqSqGK83TCn\n\tUnHygHB0dLK78PHP6DlAdjIlJ7ZebV2Xaz7+xqIfk1GWcq1i5+oLv62CXN45ZVFR5ks6\n\t4pvb+q5mPQ3SgVFvFSbv1SWmfSFxSf9tcgGdukstdpCR1YxUsIGDIjbWJKHxhhD9fRcY\n\tMUfoMHY8uTxrMCB0EvohGQPNPztvyMsxEXhhtov8Yn8R0z0MV++R+qjC66ovorC8RX1A\n\twftg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:to:cc:references:from:message-id:date\n\t:user-agent:mime-version:in-reply-to:content-language\n\t:content-transfer-encoding;\n\tbh=ELOkIq6FfVYypb4EQKy9swRAcz/VxCIMVwXmofqrub0=;\n\tb=mtac69ckwLBztfg8+Oy94lacWM0IttWWWvIbIv/uWA8iAOPjRPeaiPU5gOQtfKWfRT\n\tHehyifoKUa7xfLnRtmgbVys7ZvQ2G3/N/QTcV41l4r3J/RHvykoG+9zx3FhvLF9ugI+e\n\tEQZTNtMW4JD5NB31ROfWrlJxseZbLg7mzG2as5wEkbv8IOaYzeBMvFcxjGUat2aoafBg\n\t4S1CVhVG1vOWfScc5TK50bU9DLyKQMD8QIFyRTrnCrqaE4EJvThNpR6DZW6EZfrLbBFt\n\tAMnGo59W2vYIDwuUqZLAqcQIZPozVdgCjN7oVyQjQ9c2wjSXNBknalf4AGstOd0wjL/4\n\tClMA==","X-Gm-Message-State":"AHPjjUgbxtb72ejgY8ehj1vvnNfsqZSu+IP6JNQtg3LP7sJQS0yltgjh\n\t+DZ1M5qVml0CO4xmS34=","X-Google-Smtp-Source":"ADKCNb7RpvHVrxnX87qNpTErGaU8UDMd4NVCzJvJORzHRs5UA8k6vJpqI1yBSpKAyhZvQQzClk2LEw==","X-Received":"by 10.28.21.80 with SMTP id 77mr559872wmv.77.1504533159834;\n\tMon, 04 Sep 2017 06:52:39 -0700 (PDT)","Subject":"Re: [PATCH v2 2/2] ARM: dts: sun8i: h3: Improved Wifi bindings on\n\tBananapi M2 Plus","To":"Maxime Ripard <maxime.ripard@free-electrons.com>","Cc":"robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,\n\twens@csie.org, devicetree@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,\n\tlinux-sunxi@googlegroups.com","References":"<1504283401-4263-1-git-send-email-embed3d@gmail.com>\n\t<1504283401-4263-3-git-send-email-embed3d@gmail.com>\n\t<20170904080519.mec6ypjei7uvo5k7@flea>","From":"Philipp Rossak <embed3d@gmail.com>","Message-ID":"<db2d8aed-b3da-7766-1fe5-6ef5d6c5578b@gmail.com>","Date":"Mon, 4 Sep 2017 15:52:36 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170904080519.mec6ypjei7uvo5k7@flea>","Content-Type":"text/plain; charset=windows-1252; format=flowed","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","Sender":"devicetree-owner@vger.kernel.org","Precedence":"bulk","List-ID":"<devicetree.vger.kernel.org>","X-Mailing-List":"devicetree@vger.kernel.org"}}]