[{"id":1763179,"web_url":"http://patchwork.ozlabs.org/comment/1763179/","msgid":"","list_archive_url":null,"date":"2017-09-05T10:18:25","subject":"ACK: [SRU][Zesty][PATCH 1/1] powerpc: Drop GPL from of_node_to_nid()\n\texport to match other arches","submitter":{"id":2900,"url":"http://patchwork.ozlabs.org/api/people/2900/","name":"Colin Ian King","email":"colin.king@canonical.com"},"content":"On 01/09/17 16:53, Joseph Salisbury wrote:\n> From: Shailendra Singh \n> \n> BugLink: http://bugs.launchpad.net/bugs/1709179\n> \n> The generic implementation of of_node_to_nid() is EXPORT_SYMBOL, added\n> in commit 298535c00a2c (\"of, numa: Add NUMA of binding\n> implementation.\").\n> \n> The powerpc implementation added in commit 953039c8df7b (\"[PATCH]\n> powerpc: Allow devices to register with numa topology\") is\n> EXPORT_SYMBOL_GPL.\n> \n> This creates an inconsistency for of_node_to_nid() callers across\n> architectures.\n> \n> Update the powerpc implementation to be exported consistently with the\n> generic implementation.\n> \n> Signed-off-by: Shailendra Singh \n> Reviewed-by: Andy Ritger \n> Signed-off-by: Michael Ellerman \n> (cherry picked from commit be9ba9ff93cc3e44dc46da9ed25655780069411a)\n> Signed-off-by: Joseph Salisbury \n> ---\n> arch/powerpc/mm/numa.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c\n> index b1099cb..8aa4ca3 100644\n> --- a/arch/powerpc/mm/numa.c\n> +++ b/arch/powerpc/mm/numa.c\n> @@ -290,7 +290,7 @@ int of_node_to_nid(struct device_node *device)\n> \n> \treturn nid;\n> }\n> -EXPORT_SYMBOL_GPL(of_node_to_nid);\n> +EXPORT_SYMBOL(of_node_to_nid);\n> \n> static int __init find_min_common_depth(void)\n> {\n> \n\nClean cherry pick, limit regression potential. looks good to me.\n\nAcked-by: Colin Ian King ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmjNQ551Mz9sNq;\n\tTue, 5 Sep 2017 20:18:30 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpAw7-0006tn-G7; Tue, 05 Sep 2017 10:18:27 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpAw5-0006th-Tn\n\tfor kernel-team@lists.ubuntu.com; Tue, 05 Sep 2017 10:18:25 +0000","from 1.general.cking.uk.vpn ([10.172.193.212])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpAw5-00073R-Lg; Tue, 05 Sep 2017 10:18:25 +0000"],"Subject":"ACK: [SRU][Zesty][PATCH 1/1] powerpc: Drop GPL from of_node_to_nid()\n\texport to match other arches","To":"kernel-team@lists.ubuntu.com","References":"\n\t<81b879a51b989c798b25e261506ec6d33396e475.1503672237.git.joseph.salisbury@canonical.com>","From":"Colin Ian King ","Message-ID":"","Date":"Tue, 5 Sep 2017 11:18:25 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101\n\tThunderbird/45.8.0","MIME-Version":"1.0","In-Reply-To":"<81b879a51b989c798b25e261506ec6d33396e475.1503672237.git.joseph.salisbury@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1763413,"web_url":"http://patchwork.ozlabs.org/comment/1763413/","msgid":"<8e7f3785-286d-b39a-ec88-db04478c89a0@canonical.com>","list_archive_url":null,"date":"2017-09-05T14:44:52","subject":"ACK/cmnt: [SRU][Zesty][PATCH 1/1] powerpc: Drop GPL from\n\tof_node_to_nid() export to match other arches","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 01.09.2017 17:53, Joseph Salisbury wrote:\n> From: Shailendra Singh \n> \n> BugLink: http://bugs.launchpad.net/bugs/1709179\n> \n> The generic implementation of of_node_to_nid() is EXPORT_SYMBOL, added\n> in commit 298535c00a2c (\"of, numa: Add NUMA of binding\n> implementation.\").\n> \n> The powerpc implementation added in commit 953039c8df7b (\"[PATCH]\n> powerpc: Allow devices to register with numa topology\") is\n> EXPORT_SYMBOL_GPL.\n> \n> This creates an inconsistency for of_node_to_nid() callers across\n> architectures.\n> \n> Update the powerpc implementation to be exported consistently with the\n> generic implementation.\n> \n> Signed-off-by: Shailendra Singh \n> Reviewed-by: Andy Ritger \n> Signed-off-by: Michael Ellerman \n> (cherry picked from commit be9ba9ff93cc3e44dc46da9ed25655780069411a)\n> Signed-off-by: Joseph Salisbury \nAcked-by: Stefan Bader \n\n> ---\n\nPlease add SRU justification to bug report.\n\nThanks,\nStefan\n\n> arch/powerpc/mm/numa.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c\n> index b1099cb..8aa4ca3 100644\n> --- a/arch/powerpc/mm/numa.c\n> +++ b/arch/powerpc/mm/numa.c\n> @@ -290,7 +290,7 @@ int of_node_to_nid(struct device_node *device)\n> \n> \treturn nid;\n> }\n> -EXPORT_SYMBOL_GPL(of_node_to_nid);\n> +EXPORT_SYMBOL(of_node_to_nid);\n> \n> static int __init find_min_common_depth(void)\n> {\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xmqHt5fXHz9t2W;\n\tWed, 6 Sep 2017 00:44:58 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dpF5z-00037j-9P; Tue, 05 Sep 2017 14:44:55 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dpF5x-00037I-E5\n\tfor kernel-team@lists.ubuntu.com; Tue, 05 Sep 2017 14:44:53 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dpF5x-0004hd-5w\n\tfor kernel-team@lists.ubuntu.com; Tue, 05 Sep 2017 14:44:53 +0000"],"Subject":"ACK/cmnt: [SRU][Zesty][PATCH 1/1] powerpc: Drop GPL from\n\tof_node_to_nid() export to match other arches","To":"kernel-team@lists.ubuntu.com","References":"\n\t<81b879a51b989c798b25e261506ec6d33396e475.1503672237.git.joseph.salisbury@canonical.com>","From":"Stefan Bader ","Message-ID":"<8e7f3785-286d-b39a-ec88-db04478c89a0@canonical.com>","Date":"Tue, 5 Sep 2017 16:44:52 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<81b879a51b989c798b25e261506ec6d33396e475.1503672237.git.joseph.salisbury@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============5750169702734237838==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}},{"id":1769166,"web_url":"http://patchwork.ozlabs.org/comment/1769166/","msgid":"","list_archive_url":null,"date":"2017-09-15T12:57:04","subject":"APPLIED Z: [SRU][Zesty][PATCH 1/1] powerpc: Drop GPL from\n\tof_node_to_nid() export to match other arches","submitter":{"id":2898,"url":"http://patchwork.ozlabs.org/api/people/2898/","name":"Stefan Bader","email":"stefan.bader@canonical.com"},"content":"On 01.09.2017 17:53, Joseph Salisbury wrote:\n> From: Shailendra Singh \n> \n> BugLink: http://bugs.launchpad.net/bugs/1709179\n> \n> The generic implementation of of_node_to_nid() is EXPORT_SYMBOL, added\n> in commit 298535c00a2c (\"of, numa: Add NUMA of binding\n> implementation.\").\n> \n> The powerpc implementation added in commit 953039c8df7b (\"[PATCH]\n> powerpc: Allow devices to register with numa topology\") is\n> EXPORT_SYMBOL_GPL.\n> \n> This creates an inconsistency for of_node_to_nid() callers across\n> architectures.\n> \n> Update the powerpc implementation to be exported consistently with the\n> generic implementation.\n> \n> Signed-off-by: Shailendra Singh \n> Reviewed-by: Andy Ritger \n> Signed-off-by: Michael Ellerman \n> (cherry picked from commit be9ba9ff93cc3e44dc46da9ed25655780069411a)\n> Signed-off-by: Joseph Salisbury \n> ---\n> arch/powerpc/mm/numa.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c\n> index b1099cb..8aa4ca3 100644\n> --- a/arch/powerpc/mm/numa.c\n> +++ b/arch/powerpc/mm/numa.c\n> @@ -290,7 +290,7 @@ int of_node_to_nid(struct device_node *device)\n> \n> \treturn nid;\n> }\n> -EXPORT_SYMBOL_GPL(of_node_to_nid);\n> +EXPORT_SYMBOL(of_node_to_nid);\n> \n> static int __init find_min_common_depth(void)\n> {\n> \nApplied to zesty master-next","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com\n\t(client-ip=91.189.94.19; helo=huckleberry.canonical.com;\n\tenvelope-from=kernel-team-bounces@lists.ubuntu.com;\n\treceiver=)","Received":["from huckleberry.canonical.com (huckleberry.canonical.com\n\t[91.189.94.19])\n\tby ozlabs.org (Postfix) with ESMTP id 3xtwQv6DrXz9sRm;\n\tFri, 15 Sep 2017 22:57:11 +1000 (AEST)","from localhost ([127.0.0.1] helo=huckleberry.canonical.com)\n\tby huckleberry.canonical.com with esmtp (Exim 4.86_2)\n\t(envelope-from )\n\tid 1dsqB8-0008Qe-ST; Fri, 15 Sep 2017 12:57:06 +0000","from youngberry.canonical.com ([91.189.89.112])\n\tby huckleberry.canonical.com with esmtps\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128)\n\t(Exim 4.86_2) (envelope-from )\n\tid 1dsqB7-0008Om-6B\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 12:57:05 +0000","from 1.general.smb.uk.vpn ([10.172.193.28])\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from )\n\tid 1dsqB6-0003T1-UJ\n\tfor kernel-team@lists.ubuntu.com; Fri, 15 Sep 2017 12:57:04 +0000"],"Subject":"APPLIED Z: [SRU][Zesty][PATCH 1/1] powerpc: Drop GPL from\n\tof_node_to_nid() export to match other arches","To":"kernel-team@lists.ubuntu.com","References":"\n\t<81b879a51b989c798b25e261506ec6d33396e475.1503672237.git.joseph.salisbury@canonical.com>","From":"Stefan Bader ","Message-ID":"","Date":"Fri, 15 Sep 2017 14:57:04 +0200","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<81b879a51b989c798b25e261506ec6d33396e475.1503672237.git.joseph.salisbury@canonical.com>","X-BeenThere":"kernel-team@lists.ubuntu.com","X-Mailman-Version":"2.1.20","Precedence":"list","List-Id":"Kernel team discussions ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"multipart/mixed;\n\tboundary=\"===============1571515696146308403==\"","Errors-To":"kernel-team-bounces@lists.ubuntu.com","Sender":"\"kernel-team\" "}}]