[{"id":1761934,"web_url":"http://patchwork.ozlabs.org/comment/1761934/","msgid":"<02874ECE860811409154E81DA85FBB5882A98333@ORSMSX115.amr.corp.intel.com>","list_archive_url":null,"date":"2017-09-01T19:19:39","subject":"RE: [PATCH 0/2] i40e: fix firmware update","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"> -----Original Message-----\n> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org]\n> On Behalf Of Stefan Assmann\n> Sent: Friday, September 01, 2017 7:03 AM\n> To: intel-wired-lan@lists.osuosl.org\n> Cc: netdev@vger.kernel.org; davem@davemloft.net; Kirsher, Jeffrey T\n> ; sassmann@kpanic.de\n> Subject: [PATCH 0/2] i40e: fix firmware update\n> \n> The first patch fixes the firmware update which is currently broken and\n> results in a bad flash (corrupt firmware). Recovery is possible with a\n> fixed driver.\n> The second patch reverts a commit that causes the firmware checksum\n> verification to fail right after a successful flash. This is related to\n> a recent workqueue change. Haven't gotten to the bottom of this yet, but\n> for the sake of a smooth firmware update experience let's revert the\n> commit for now.\n\nHi Stefan,\n\nThanks for these patches, I apologize for the time it took for us to respond to this. \n\nThe first patch is functionally correct, and I'm surprised we missed sending an equivalent ourselves. It looks like some related changes occurred around this code, and we failed to submit the patch.\n\nI think Jeff would prefer if we send the version based directly on the out-of-tree code, which I will be reviving and submitting shortly.\n\nThe second issue I believe is not fixed correctly by the patch, I'm unsure why exactly changing the WQ would cause this but I believe that a similar patch which creates a non-locked version of i40e_nvm_read_buffer() will resolve this, and I will be sending that patch as well, which I believe is the real fix versus halting the work queue.\n\nThanks,\nJake\n\n> \n> Stefan Assmann (2):\n> i40e: use non-locking i40e_read_nvm_word() function during nvmupdate\n> Revert \"i40e: remove WQ_UNBOUND and the task limit of our workqueue\"\n> \n> drivers/net/ethernet/intel/i40e/i40e_main.c | 12 +++++-------\n> drivers/net/ethernet/intel/i40e/i40e_nvm.c | 24 ++++++++++++++++++++++--\n> 2 files changed, 27 insertions(+), 9 deletions(-)\n> \n> --\n> 2.13.5","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkTZp1nkgz9sPm\n\tfor ;\n\tSat, 2 Sep 2017 05:19:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752195AbdIATTn convert rfc822-to-8bit (ORCPT\n\t);\n\tFri, 1 Sep 2017 15:19:43 -0400","from mga02.intel.com ([134.134.136.20]:33794 \"EHLO mga02.intel.com\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1751715AbdIATTm (ORCPT );\n\tFri, 1 Sep 2017 15:19:42 -0400","from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Sep 2017 12:19:41 -0700","from orsmsx110.amr.corp.intel.com ([10.22.240.8])\n\tby fmsmga004.fm.intel.com with ESMTP; 01 Sep 2017 12:19:40 -0700","from orsmsx157.amr.corp.intel.com (10.22.240.23) by\n\tORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server\n\t(TLS) id 14.3.319.2; Fri, 1 Sep 2017 12:19:39 -0700","from orsmsx115.amr.corp.intel.com ([169.254.4.109]) by\n\tORSMSX157.amr.corp.intel.com ([169.254.9.11]) with mapi id\n\t14.03.0319.002; Fri, 1 Sep 2017 12:19:39 -0700"],"X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,459,1498546800\"; d=\"scan'208\";a=\"307056059\"","From":"\"Keller, Jacob E\" ","To":"Stefan Assmann ,\n\t\"intel-wired-lan@lists.osuosl.org\" ","CC":"\"netdev@vger.kernel.org\" ,\n\t\"davem@davemloft.net\" ,\n\t\"Kirsher, Jeffrey T\" ","Subject":"RE: [PATCH 0/2] i40e: fix firmware update","Thread-Topic":"[PATCH 0/2] i40e: fix firmware update","Thread-Index":"AQHTIysHONr/gHFYz0CaNsMX3753FqKgZraw","Date":"Fri, 1 Sep 2017 19:19:39 +0000","Message-ID":"<02874ECE860811409154E81DA85FBB5882A98333@ORSMSX115.amr.corp.intel.com>","References":"<20170901140234.7840-1-sassmann@kpanic.de>","In-Reply-To":"<20170901140234.7840-1-sassmann@kpanic.de>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-titus-metadata-40":"eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTJkMTMxN2EtYTg3OC00MDdiLTg4MGEtMjdkOWE5YWYxNWVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6Ikt4QXBDUjJ3STJ6b3MrWlpSYVU1T2tXSmpwem13WE5CekFzUVQ3Z01zSUE9In0=","x-ctpclassification":"CTP_IC","dlp-product":"dlpe-windows","dlp-version":"11.0.0.116","dlp-reaction":"no-action","x-originating-ip":"[10.22.254.139]","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"8BIT","MIME-Version":"1.0","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]