[{"id":1763168,"web_url":"http://patchwork.ozlabs.org/comment/1763168/","msgid":"<20170905100250.GG17449@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-05T10:02:50","subject":"Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Fri, Sep 01, 2017 at 01:28:16PM +0200, Amador Pahim wrote:\n\nPlease update the patches with Reviewed-bys from past revisions so I\nknow which patches I've already reviewed.\n\nIf someone has posted a R-b then it should be included in the next\nrevision unless you substantially modify that patch.\n\nThanks,\nStefan","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YZ7AabAd\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmj3S11sQz9sNq\n\tfor ;\n\tTue, 5 Sep 2017 20:03:48 +1000 (AEST)","from localhost ([::1]:57864 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dpAhu-0000kX-7y\n\tfor incoming@patchwork.ozlabs.org; Tue, 05 Sep 2017 06:03:46 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38406)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dpAhE-0000XR-MK\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:03:09 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dpAh7-0000vO-76\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:03:04 -0400","from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:36369)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from ) id 1dpAh6-0000tp-WC\n\tfor qemu-devel@nongnu.org; Tue, 05 Sep 2017 06:02:57 -0400","by mail-wm0-x234.google.com with SMTP id i145so16822904wmf.1\n\tfor ; Tue, 05 Sep 2017 03:02:56 -0700 (PDT)","from localhost ([51.15.41.238])\n\tby smtp.gmail.com with ESMTPSA id x4sm71902eda.60.2017.09.05.03.02.54\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 05 Sep 2017 03:02:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=A0GkULZSjbWMnNRxTQsQxJ8Q4gVGKATdga6jJE1xyrQ=;\n\tb=YZ7AabAdbdekDzGlk3D9UDy8/QV9DVkIntgBwm84/CBBQfx9u6gsFL5BiaSo2dloMC\n\tvFhG+5GxFJcEcUL6tnqlnkd/mcU5he/OZyyC8gtj2OlxZ9Kd3/MueN+s0KUFYoA5jd1b\n\tjzU9JHj+uli9ledxnPThhRDAzdfH/mbNPrLTQ0f6KtufoUIzi0YIqxdTQ6/+pEXrRyXg\n\tInmdGEGkhMyC1Mxvd1meDSbYWlvojr+jAYkaHgoI2z6/wNj3KtBFoMYuFHaKHxBz6nWJ\n\tT8kBBo58K2lOYk0lk6Jg8+4irFzQoK28Agxyl3L3lhJPA3p5GiXfOgF4QRqmvd1dXF/H\n\tbuHQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=A0GkULZSjbWMnNRxTQsQxJ8Q4gVGKATdga6jJE1xyrQ=;\n\tb=UjHvOp+sL5kcRfCKBo/Mi5zMNli0eGXyTS3iGH2LYR4C6j+vn8owSEpMF9H3aDMtGA\n\tqI5xhh/2fK5l0mxbOWSywyxs29m/pW9YVlNv4c6Ap3GiBJ5vunINdH1zpSsEdJVPIhnv\n\t/oHX7GwHI8v0o31w/rIUMwnU46kiEZfdYCK1ZALMsodWHtuIdU3uy68xJHRaW259NbnN\n\tpLMDdde+M8Cr/lWPd1QfUaZ4YZcljcoIN6iypzppOMI/LNdzq0nksmlYb2cYfrRuZM80\n\tev+nDuzpwhU7FzCtLlBMTWQ3+GDmxitV/1/5mSv6KyoEMK7Mi+nM7Uf9BWBwqQacHzDz\n\to0wA==","X-Gm-Message-State":"AHPjjUhMW2jkG/rzYPOWw2jZLuB7RXEgo9gGwU4/01NmR15Vi6v8xpmz\n\tvbaf/m+ZZgcUWw==","X-Google-Smtp-Source":"ADKCNb77n8nuU1veulpbS+c2zFsCZsxPiWN7UrFOnTkWgJhIzdYd/7Dy78q/zvN9Kt/O8YbXFv870w==","X-Received":"by 10.80.137.80 with SMTP id f16mr2756895edf.77.1504605775742;\n\tTue, 05 Sep 2017 03:02:55 -0700 (PDT)","Date":"Tue, 5 Sep 2017 11:02:50 +0100","From":"Stefan Hajnoczi ","To":"Amador Pahim ","Message-ID":"<20170905100250.GG17449@stefanha-x1.localdomain>","References":"<20170901112829.2571-1-apahim@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901112829.2571-1-apahim@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::234","Subject":"Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, ehabkost@redhat.com,\n\tarmbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,\n\tcrosa@redhat.com, famz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1768794,"web_url":"http://patchwork.ozlabs.org/comment/1768794/","msgid":"<20170914193133.GA25664@localhost.localdomain>","list_archive_url":null,"date":"2017-09-14T19:31:33","subject":"Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups","submitter":{"id":195,"url":"http://patchwork.ozlabs.org/api/people/195/","name":"Eduardo Habkost","email":"ehabkost@redhat.com"},"content":"Patches 01-05 were queued on my python-next branch:\nhttps://github.com/ehabkost/qemu/commits/python-next\n\nPlease use python-next as base for v9, as I plan to submit a pull\nrequest with the contents of python-next soon.\n\n\nOn Fri, Sep 01, 2017 at 01:28:16PM +0200, Amador Pahim wrote:\n> Changes v1->v2:\n> - Style fixes to make checkpatch.pl happy.\n> - Rebased.\n> Changes v2->v3:\n> - Fix typo in patch 3 (\"qemu.py: make 'args' public\") commit message.\n> Changes v3->v4:\n> - Squash the 2 first commits since they are co-dependant.\n> - Cleanup launch() and shutdown().\n> - Reorder the commits, putting the rename of self._args first.\n> - Rebased.\n> Changes v4->v5:\n> - Break the cleanup commit into logical changes and include in the\n> commit messages the rationale for making them.\n> Changes v5->v6:\n> - Remove the commit to rename self._args.\n> - Fix is_running() return before first call to maunch().\n> - Use python logging system.\n> - Include the full command line on negative exit code error message.\n> - Use os.path.null instead of /dev/null.\n> - Improve the control over the created/deleted files.\n> Changes v6->v7:\n> - Split commits in self-contained/atomic changes.\n> - Addressed the comments from previous version, basically improving the\n> logging messages and the control over created files. See individual\n> commit messages for details.\n> Changes v7->v8:\n> - Rebased.\n> - Reorder commits to avoid break->fix sequence.\n> - Split commits \"use poll() instead of 'returncode'\" and \"refactor\n> launch()\".\n> - Don't ignore errors in _load_io_log(). Instead, check if we created\n> the file before reading it.\n> - Use LOG.warn() instead of LOG.debug() for the negative exit code\n> message.\n> - Fix the exception name called in commits \"launch vm only if it's not\n> running\" and \"don't launch again before shutdown()\".\n> - Minor style fixes.\n> \n> Amador Pahim (13):\n> qemu.py: fix is_running() return before first launch()\n> qemu.py: avoid writing to stdout/stderr\n> qemu.py: use os.path.null instead of /dev/null\n> qemu.py: improve message on negative exit code\n> qemu.py: include debug information on launch error\n> qemu.py: make sure we only remove files we create\n> qemu.py: close _qemu_log_path on cleanup\n> qemu.py: refactor launch()\n> qemu.py: always cleanup on shutdown()\n> qemu.py: use poll() instead of 'returncode'\n> qemu.py: cleanup redundant calls in launch()\n> qemu.py: launch vm only if it's not running\n> qemu.py: don't launch again before shutdown()\n> \n> scripts/qemu.py | 136 +++++++++++++++++++++++++++++++++++++++++---------------\n> 1 file changed, 101 insertions(+), 35 deletions(-)\n> \n> -- \n> 2.13.5\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx10.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=ehabkost@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xtTF021pqz9s7M\n\tfor ;\n\tFri, 15 Sep 2017 05:32:04 +1000 (AEST)","from localhost ([::1]:49686 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dsZrm-0005Ca-F1\n\tfor incoming@patchwork.ozlabs.org; Thu, 14 Sep 2017 15:32:02 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:57311)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dsZrT-0005CG-H0\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 15:31:44 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dsZrQ-0001p1-80\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 15:31:43 -0400","from mx1.redhat.com ([209.132.183.28]:45252)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from ) id 1dsZrP-0001oX-VQ\n\tfor qemu-devel@nongnu.org; Thu, 14 Sep 2017 15:31:40 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id D9D2E5F73A;\n\tThu, 14 Sep 2017 19:31:38 +0000 (UTC)","from localhost (ovpn-116-51.gru2.redhat.com [10.97.116.51])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 75E595D96F;\n\tThu, 14 Sep 2017 19:31:34 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com D9D2E5F73A","Date":"Thu, 14 Sep 2017 16:31:33 -0300","From":"Eduardo Habkost ","To":"Amador Pahim ","Message-ID":"<20170914193133.GA25664@localhost.localdomain>","References":"<20170901112829.2571-1-apahim@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901112829.2571-1-apahim@redhat.com>","X-Fnord":"you can see the fnord","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.39]);\n\tThu, 14 Sep 2017 19:31:39 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, ldoktor@redhat.com, famz@redhat.com, stefanha@gmail.com,\n\tqemu-devel@nongnu.org, armbru@redhat.com, crosa@redhat.com,\n\tmreitz@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]