[{"id":1761611,"web_url":"http://patchwork.ozlabs.org/comment/1761611/","msgid":"<150426555188.216.3681080346934443112@b5667b65043c>","list_archive_url":null,"date":"2017-09-01T11:32:32","subject":"Re: [Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nMessage-id: 20170901105818.31956-1-otubo@redhat.com\nSubject: [Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nSwitched to a new branch 'test'\nb93c9e7648 seccomp: adding documentation to new seccomp model\n19f0713063 seccomp: add resourcecontrol argument to command line\n0d2a553bce seccomp: add spawn argument to command line\n7899a23fb6 seccomp: add elevateprivileges argument to command line\nd43b3cbcf8 seccomp: add obsolete argument to command line\n2765752f8e seccomp: changing from whitelist to blacklist\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/6: seccomp: changing from whitelist to blacklist...\nChecking PATCH 2/6: seccomp: add obsolete argument to command line...\nERROR: code indent should never use tabs\n#128: FILE: vl.c:1048:\n+^I^I * to provide a little bit of consistency for$\n\nERROR: code indent should never use tabs\n#129: FILE: vl.c:1049:\n+^I^I * the command line */$\n\nERROR: code indent should never use tabs\n#130: FILE: vl.c:1050:\n+^I } else {$\n\nERROR: code indent should never use tabs\n#131: FILE: vl.c:1051:\n+^I^Ierror_report(\"invalid argument for obsolete\");$\n\nERROR: code indent should never use tabs\n#132: FILE: vl.c:1052:\n+^I }$\n\ntotal: 5 errors, 0 warnings, 104 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 3/6: seccomp: add elevateprivileges argument to command line...\nChecking PATCH 4/6: seccomp: add spawn argument to command line...\nChecking PATCH 5/6: seccomp: add resourcecontrol argument to command line...\nERROR: space required after that ',' (ctx:VxV)\n#78: FILE: qemu-seccomp.c:83:\n+ { SCMP_SYS(sched_get_priority_max),16, QEMU_SECCOMP_SET_RESOURCECTL },\n ^\n\nERROR: space required after that ',' (ctx:VxV)\n#79: FILE: qemu-seccomp.c:84:\n+ { SCMP_SYS(sched_get_priority_min),16, QEMU_SECCOMP_SET_RESOURCECTL },\n ^\n\nERROR: code indent should never use tabs\n#124: FILE: vl.c:1109:\n+^I^Ierror_report(\"invalid argument for resourcecontrol\");$\n\nERROR: code indent should never use tabs\n#125: FILE: vl.c:1110:\n+^I^Ireturn -1;$\n\nERROR: code indent should never use tabs\n#126: FILE: vl.c:1111:\n+^I }$\n\ntotal: 5 errors, 0 warnings, 95 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 6/6: seccomp: adding documentation to new seccomp model...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHSG6NGkz9sRV\n\tfor ;\n\tFri, 1 Sep 2017 21:43:26 +1000 (AEST)","from localhost ([::1]:36525 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnkM8-0002ur-Vc\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 07:43:25 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:60058)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnkBn-0001up-6h\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:48 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnkBk-0007Aa-1D\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:43 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21302)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnkBj-0007AF-Q5\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 07:32:39 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1504265552401521.7340181147292;\n\tFri, 1 Sep 2017 04:32:32 -0700 (PDT)"],"Resent-Date":"Fri, 01 Sep 2017 07:32:43 -0400","Resent-Message-Id":"","In-Reply-To":"<20170901105818.31956-1-otubo@redhat.com>","Message-ID":"<150426555188.216.3681080346934443112@b5667b65043c>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"otubo@redhat.com","Date":"Fri, 1 Sep 2017 04:32:32 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCHv4 0/6] seccomp: feature refactoring","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"thuth@redhat.com, famz@redhat.com, qemu-devel@nongnu.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]