[{"id":1761848,"web_url":"http://patchwork.ozlabs.org/comment/1761848/","msgid":"<20170901.101538.1176427534027457129.davem@davemloft.net>","list_archive_url":null,"date":"2017-09-01T17:15:38","subject":"Re: [net 0/3] gianfar: Tx flow control fix (adjust_link)","submitter":{"id":15,"url":"http://patchwork.ozlabs.org/api/people/15/","name":"David Miller","email":"davem@davemloft.net"},"content":"From: Claudiu Manoil \nDate: Fri, 1 Sep 2017 12:41:00 +0300\n\n> Fix a small blunder in the Tx pause frame settings, that\n> went unnoticed in the tangled code of adjust_link().\n> I followed up with a couple of simple refactoring patches,\n> aiming to make adjust_link() more manageable.\n> \n> (The last 2 patches may be postponed if they are too much\n> for the current stage of net.)\n\nYou need to fix some things up here.\n\nFirst, do not mix bug fixes with cleanups. Refactoring is a cleanup.\n\nSubmit the bug fix for 'net' and then later you can submit the\ncleanups for 'net-next'.\n\nSecond, do not CC: stable for networking bug fixes, instead explicitly\nask me to queue up the fix for -stable.\n\nThird, you need to fix how you specify your Fixes tag, it must\nbe exactly:\n\nFixes: $(SHA1_ID) (\"Commit header text.\")\n\nAnd no matter how long the line is, do not break it up.\n\nThank you.","headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkQqd6ZNvz9t2x\n\tfor ;\n\tSat, 2 Sep 2017 03:15:41 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752473AbdIARPj (ORCPT );\n\tFri, 1 Sep 2017 13:15:39 -0400","from shards.monkeyblade.net ([184.105.139.130]:49702 \"EHLO\n\tshards.monkeyblade.net\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752197AbdIARPj (ORCPT\n\t); Fri, 1 Sep 2017 13:15:39 -0400","from localhost (74-93-104-98-Washington.hfc.comcastbusiness.net\n\t[74.93.104.98]) (using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(Client did not present a certificate)\n\t(Authenticated sender: davem-davemloft)\n\tby shards.monkeyblade.net (Postfix) with ESMTPSA id B7AC213429C92;\n\tFri, 1 Sep 2017 10:15:38 -0700 (PDT)"],"Date":"Fri, 01 Sep 2017 10:15:38 -0700 (PDT)","Message-Id":"<20170901.101538.1176427534027457129.davem@davemloft.net>","To":"claudiu.manoil@nxp.com","Cc":"netdev@vger.kernel.org","Subject":"Re: [net 0/3] gianfar: Tx flow control fix (adjust_link)","From":"David Miller ","In-Reply-To":"<1504258863-2058-1-git-send-email-claudiu.manoil@nxp.com>","References":"<1504258863-2058-1-git-send-email-claudiu.manoil@nxp.com>","X-Mailer":"Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO)","Mime-Version":"1.0","Content-Type":"Text/Plain; charset=us-ascii","Content-Transfer-Encoding":"7bit","X-Greylist":"Sender succeeded SMTP AUTH, not delayed by\n\tmilter-greylist-4.5.12 (shards.monkeyblade.net\n\t[149.20.54.216]); Fri, 01 Sep 2017 10:15:38 -0700 (PDT)","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"}}]