[{"id":1761564,"web_url":"http://patchwork.ozlabs.org/comment/1761564/","msgid":"<20170901100919.GZ2598@lahna.fi.intel.com>","list_archive_url":null,"date":"2017-09-01T10:09:19","subject":"Re: [PATCH 00/10] spi-nor: intel-spi: Various fixes and enhancements","submitter":{"id":14534,"url":"http://patchwork.ozlabs.org/api/people/14534/","name":"Mika Westerberg","email":"mika.westerberg@linux.intel.com"},"content":"On Fri, Sep 01, 2017 at 01:00:31AM -0700, Bin Meng wrote:\n> This series does several bug fixes and clean ups against the intel-spi\n> spi-nor driver, as well as enhancements to make the driver independent\n> on the underlying BIOS/bootloader.\n> \n> At present the driver uses the HW sequencer for the read/write/erase on\n> all supported platforms, read_reg/write_reg for BXT, and the SW sequencer\n> for read_reg/write_reg for BYT/LPT. The way the driver uses the HW and SW\n> sequencer relies on some programmed register settings and hence creates\n> unneeded dependencies with the underlying BIOS/bootloader. For example,\n> the driver unfortunately does not work as expected when booting from\n> Intel Baytrail FSP based bootloaders like U-Boot, as the Baytrail FSP\n> does not set up some SPI controller settings to make the driver happy.\n> Now such limitation has been removed with this series.\n> \n> \n> Bin Meng (10):\n> spi-nor: intel-spi: Fix number of protected range registers for\n> BYT/LPT\n> spi-nor: intel-spi: Remove useless 'buf' parameter in the HW/SW cycle\n> spi-nor: intel-spi: Fix broken software sequencing codes\n> spi-nor: intel-spi: Check transfer length in the HW/SW cycle\n> spi-nor: intel-spi: Use SW sequencer for BYT/LPT\n> spi-nor: intel-spi: Remove 'Atomic Cycle Sequence' in\n> intel_spi_write()\n> spi-nor: intel-spi: Don't assume OPMENU0/1 to be programmed by BIOS\n> spi-nor: intel-spi: Remove the unnecessary HSFSTS register RW\n> spi-nor: intel-spi: Rename swseq to swseq_reg in 'struct intel_spi'\n> spi-nor: intel-spi: Fall back to use SW sequencer to erase\n> \n> drivers/mtd/spi-nor/intel-spi.c | 209 +++++++++++++++++++++++++++++-----------\n> 1 file changed, 151 insertions(+), 58 deletions(-)\n\nNice work!\n\nFor the whole series,\n\nAcked-by: Mika Westerberg ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"nAmkILm1\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkFNQ1jRDz9t2Z\n\tfor ;\n\tFri, 1 Sep 2017 20:09:58 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnitX-00056Y-Ny; Fri, 01 Sep 2017 10:09:47 +0000","from mga07.intel.com ([134.134.136.100])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnitU-0004n4-9G\n\tfor linux-mtd@lists.infradead.org; Fri, 01 Sep 2017 10:09:46 +0000","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga105.jf.intel.com with ESMTP; 01 Sep 2017 03:09:23 -0700","from lahna.fi.intel.com (HELO lahna) ([10.237.72.157])\n\tby FMSMGA003.fm.intel.com with SMTP; 01 Sep 2017 03:09:20 -0700","by lahna (sSMTP sendmail emulation);\n\tFri, 01 Sep 2017 13:09:19 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=sgdZDwLwsYeLb6AAXmEuvNrnQyFqR5oQavW9NwVGDS4=;\n\tb=nAmkILm1SRafBH\n\tzccpYDpUncoo47/JwcyarJCn89BQ2AchkSv4P2lEEXNkyorrQyRysR9+NM1dbh8jyWjUwczETFSkG\n\tXy7Kw4FO2/TkkrB4yCkSJcdgCmFUSfhN+yIcsOnEn08Bp+Qv9aw9tDSinacPt8HVKf0FqutL4zSZ1\n\tIMsw6AJknx2vhRZh7EpQC8oTzI29wFBX3tDjJzS47XesvITzduTAR0q/T08iEL8nFoFE4GKEh3lZI\n\tGTBwBRazRkrCQMt/EHi3jGapRBhVwkUuETBJcgRh3VSppBQ3D0DWwY9GD7q8WvwZXTMv/srF1B9eP\n\tSiZMnp0C8GJtD/584e6A==;","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.41,457,1498546800\"; d=\"scan'208\";a=\"896174376\"","Date":"Fri, 1 Sep 2017 13:09:19 +0300","From":"Mika Westerberg ","To":"Bin Meng ","Subject":"Re: [PATCH 00/10] spi-nor: intel-spi: Various fixes and enhancements","Message-ID":"<20170901100919.GZ2598@lahna.fi.intel.com>","References":"<1504252841-2445-1-git-send-email-bmeng.cn@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<1504252841-2445-1-git-send-email-bmeng.cn@gmail.com>","Organization":"Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170901_030944_370950_2981101C ","X-CRM114-Status":"GOOD ( 14.33 )","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [134.134.136.100 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Boris Brezillon ,\n\tStefan Roese , Richard Weinberger ,\n\tlinux-kernel ,\n\tMarek Vasut ,\n\tlinux-mtd , \n\tCyrille Pitchen ,\n\tBrian Norris ,\n\tDavid Woodhouse ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]