[{"id":1761540,"web_url":"http://patchwork.ozlabs.org/comment/1761540/","msgid":"<CAKv+Gu84njSF5uOvNtknGdOd5auU7zw9scFeTq5v-=OhExgOqA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-01T09:21:28","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":26857,"url":"http://patchwork.ozlabs.org/api/people/26857/","name":"Ard Biesheuvel","email":"ard.biesheuvel@linaro.org"},"content":"On 1 September 2017 at 08:27, Daniel Axtens <dja@axtens.net> wrote:\n> This patch set:\n>\n>  - splits the default display handling out from VGA arbiter, into its\n>    own file and behind its own Kconfig option (and gives the functions\n>    better names).\n>\n>  - adds extra detection of default devices. To be nominated, the vga\n>    arbiter and platform hooks must not have nominated a default. A\n>    card will then only be nominated if it has a driver attached and\n>    has IO or memory decoding enabled.\n>\n>  - adds relevant documentation.\n>\n> The practical impact of this is improved X autoconfiguration on some\n> arm64 systems.\n>\n> Changes in v3:\n>\n>  - Add documentation - thanks Daniel Vetter for pointing it out.\n>\n>  - Clarify explanations. Thanks to everyone for continuing to bear\n>    with my incomplete understanding of PCI and provide some clarity.\n>\n>  - Split refactoring and adding functionality.\n>\n> Changes in v2: https://www.spinics.net/lists/linux-pci/msg64007.html\n>\n> Drop all the powerpc patches. [explanation snipped]\n>\n> v1: https://www.spinics.net/lists/linux-pci/msg63581.html\n>\n\nIf we are all in agreement that fixing X is not an option, I think\nthis is a reasonable approach\n\nAcked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"S3mZ8udk\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"LX2pt3Hp\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkDK20NkZz9s7C\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 19:21:58 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dni9C-0003VP-4F; Fri, 01 Sep 2017 09:21:54 +0000","from mail-io0-x22b.google.com ([2607:f8b0:4001:c06::22b])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dni98-0003SS-Kh for linux-arm-kernel@lists.infradead.org;\n\tFri, 01 Sep 2017 09:21:52 +0000","by mail-io0-x22b.google.com with SMTP id b2so13247163iof.0\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tFri, 01 Sep 2017 02:21:29 -0700 (PDT)","by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 02:21:28 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=XeF/vPaPdmmWp0SXF8GlOizyRmpnVMcuPGF+KbB+/ZE=;\n\tb=S3mZ8udkAxRkXI\n\tvMN2QhR7e2ChpnL0tF82/MpzErvyPCdzfCucaK/JfvWV5ricF9W49paI2oJSHHs8SYJInmUFaCPYs\n\taxm2NNbPYRxxVeWYbZZHDxoGAOaP7mifP3+ttPLVzbHwQZ8hMuJ+XlJPKExh0f/owQea2z86QsBVj\n\t1CE9gVZ6Pnaew+px3xIZBK4e2n397xX5k6L3626zIXQ4LYo/+IEmKN0JE+L7RI0I7GFjtZswmI3gC\n\tdht6PN/8OMI6xQFgcMPDXz8aUuKjy3HPicvu3OJS7UwxgdSIQd1StY37XTdK+xbYRseo7UxvvRCtr\n\tEgcpB28gyfQJqumuNMGw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=vUu84/h/jvtCItaGwo1bc5wC7lcY/Sh/FYatpb3W5IU=;\n\tb=LX2pt3HpWW4ieJq0Quy+9dCS4JRP3kDHv1UBqMlco+SGlzCRw6t3ywr64J8ayjFmaQ\n\thMi/M71fi9XCoxqnu2EGpjHVeO/5hT8VEzgO1OC8zoYGLK1D/f6Gd+UuNXgbPtZ15gSI\n\tjOEzQuOrbCcb+3yKSsbayDB44mFD6zqiS1coY="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=vUu84/h/jvtCItaGwo1bc5wC7lcY/Sh/FYatpb3W5IU=;\n\tb=ZZTCpg9SPaeG3NFAtISPG6OZO2Z7V7EuS7oI1KvwwucMCenGR5eAnQjJHqbt1Tu4SM\n\tM1W+VXtSq9ZM9MihzST//nf+fW2GKjx3mwNcyn7c2FgGq+6K9JXWjLlSZ8oiVqO5SFle\n\tHEeL+Z4Th6yO8iwyBzsWloj3PnqcQShFtWGsJk/nnty0rzuEc23yYwK1piC3UKeBqRay\n\t9qqJIptLF6x0VsVSly2x9TxNwcQvA3oqnr1gPBDb11gr3LYojAASwZEHfJqHiN1DuC7t\n\tcCypqnoNnCLzG3xDbxX3ZQjFQniEQnydO3EhUOCED5xCYzJh3Mv41tvMAExrrmSfbbC6\n\tBKvQ==","X-Gm-Message-State":"AHPjjUg0IV8IBTxfZC78ut2LJq78GbtTuMNOeNZEbZCrh2myZVr/Y9Tg\n\tJJTzgirOVcd9vlAn77tsQjAW768nsAjX","X-Google-Smtp-Source":"ADKCNb4iKKv5ao+lHVeCqJiTNjesZPYM/oP+erkLwKZ6hGQLVGPEd2xVZkVmmcgf3TieP27Fcp8VlmLHLmS4//zv4To=","X-Received":"by 10.107.157.78 with SMTP id g75mr939055ioe.190.1504257689324; \n\tFri, 01 Sep 2017 02:21:29 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901072744.2409-1-dja@axtens.net>","References":"<20170901072744.2409-1-dja@axtens.net>","From":"Ard Biesheuvel <ard.biesheuvel@linaro.org>","Date":"Fri, 1 Sep 2017 10:21:28 +0100","Message-ID":"<CAKv+Gu84njSF5uOvNtknGdOd5auU7zw9scFeTq5v-=OhExgOqA@mail.gmail.com>","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","To":"Daniel Axtens <dja@axtens.net>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170901_022150_723808_450BA8F4 ","X-CRM114-Status":"GOOD (  12.92  )","X-Spam-Score":"-2.7 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.7 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow\n\ttrust [2607:f8b0:4001:c06:0:0:0:22b listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tGabriele Paoloni <gabriele.paoloni@huawei.com>,\n\tDavid Airlie <airlied@linux.ie>, linux-pci <linux-pci@vger.kernel.org>,\n\tWill Deacon <will.deacon@arm.com>,\n\tdri-devel <dri-devel@lists.freedesktop.org>, \n\t\"Liuxinliang \\(Matthew Liu\\)\" <z.liuxinliang@hisilicon.com>,\n\tAlex Williamson <alex.williamson@redhat.com>,\n\tLukas Wunner <lukas@wunner.de>, Bjorn Helgaas <helgaas@kernel.org>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>,\n\tZou Rongrong <zourongrong@gmail.com>, \"Vetter,\n\tDaniel\" <daniel.vetter@intel.com>,\n\tlinuxppc-dev <linuxppc-dev@lists.ozlabs.org>,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1761603,"web_url":"http://patchwork.ozlabs.org/comment/1761603/","msgid":"<877exi4pqs.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-01T11:34:03","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Ard,\n\n> If we are all in agreement that fixing X is not an option, I think\n> this is a reasonable approach\n\nThis did come up in discussion at some earlier point in one of the many\nspins we've done of this - I don't remember if you brought it up or\nsomeone else did - but my concern was this: If it were just X we would\nbe fine, but if we go down that path I'm worried about also having to\nfix Mir/Wayland/whatever-the-new-exciting-display-server-is-this-week,\nad nauseum.\n\n> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>\n\nThanks!\n\nRegards,\nDaniel","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"qJESnmWp\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"jpF9V08N\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkHG31PY8z9t1t\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tFri,  1 Sep 2017 21:34:35 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnkDY-00060Z-GJ; Fri, 01 Sep 2017 11:34:32 +0000","from mail-pf0-x22e.google.com ([2607:f8b0:400e:c00::22e])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dnkDV-0005z8-1M for linux-arm-kernel@lists.infradead.org;\n\tFri, 01 Sep 2017 11:34:30 +0000","by mail-pf0-x22e.google.com with SMTP id n73so7465555pfj.0\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tFri, 01 Sep 2017 04:34:08 -0700 (PDT)","from localhost (124-171-202-56.dyn.iinet.net.au. [124.171.202.56])\n\tby smtp.gmail.com with ESMTPSA id\n\ti186sm3396283pfg.81.2017.09.01.04.34.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 04:34:07 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References\n\t:In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=cOLfGSBd9l02AjHCRo1fHrhkExgJRX+L96xZJrbCiAE=;\n\tb=qJESnmWp4U8XOL\n\tIwKOyRpdLp+KF9v3JxcZ8W2vQ+0s7HM0o9sTlkuTs5yLdKvWX1AyP7dQcje6buroS/i32f8sZP+Y0\n\tmDqKcp5SYqxSunYPAwjQuGkRuTfyJ63W3vN7fbxtE/e8K9mm15lT1Vq7JwbSZ9IK4KDQ6+kRQMAn4\n\tKSpjxlXnyRaDVGPTaQA4sfaK7clstcxs0IeCuOvwxIp3fhEF8pnd74OJCCuA41NVO966pZ2T7F0VL\n\tHKRhNG9/gngqNh4W1+ABUl/taurWv6x/5DMkraYNhJDJa7V349wKjiPZPg8tfp+kOMbKhkaJr/iWX\n\tiwA3RQpMZAmGWJwmpTqA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version; bh=qWGL5c4JBTLwNXuqKxllXPmtqu9UUSkea6L203jvn5M=;\n\tb=jpF9V08NvdX2YZfEkbWfnlzUovqjv/160WGos83bRhvGLxz1oKPqqIRhIskT2YXPnn\n\tkP38Xx6rRTMQOCW4deR6W5T28kLRAgPrxA8NS2W20Fm1HXSqak60xDW9N1Rb+fCfbPdb\n\td2P9f+hR3hQjmrPUtK5H9SyDMvoooaii2fEJ4="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=qWGL5c4JBTLwNXuqKxllXPmtqu9UUSkea6L203jvn5M=;\n\tb=NAoq4ERohuW9OmNli/J0HeSgwlR5hP6BF2jDq1o465iCToO/KbaB2BHg7+xr5anDUU\n\tCTp+an2/0uFVYIaMTyDlbOQIeBRQqm1YcZXxTyZfkvRR3/+A3wVH3+2wcJswi5cRCrrB\n\twp68bBToCWIndUGxBNBkXpqnKou+nHX0kwZpFMo07zsKW+H147zDSp1IO+Vf4ABdPlIW\n\tTJUWWnWO4QzNgj7DqfKITvCYGRouCleFVfd5BvWQKf4/t9H8s1eut8g5IkqG1npXME0o\n\tS3T+3eThDwiS9T9VHzb4puYxNzR9tfOTYn5U86a92YePOyMzMZ0zQfs302MjM2oGL+J+\n\tNwxw==","X-Gm-Message-State":"AHPjjUgD0aXcaEuIkaJEpBVVa0sqJVqTy/5hj6p7kzVrmIpgPr0CvrWV\n\tO5wFAYnWQTYaXcpq","X-Google-Smtp-Source":"ADKCNb5q/niM3gxxOq005BTvH+03JTr/qks3Gpc4iymYQD4huGxKIUGsgc/cuT7PbzcybDJrQSYmng==","X-Received":"by 10.98.215.80 with SMTP id v16mr1937136pfl.342.1504265647741; \n\tFri, 01 Sep 2017 04:34:07 -0700 (PDT)","From":"Daniel Axtens <dja@axtens.net>","To":"Ard Biesheuvel <ard.biesheuvel@linaro.org>","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"<CAKv+Gu84njSF5uOvNtknGdOd5auU7zw9scFeTq5v-=OhExgOqA@mail.gmail.com>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<CAKv+Gu84njSF5uOvNtknGdOd5auU7zw9scFeTq5v-=OhExgOqA@mail.gmail.com>","Date":"Fri, 01 Sep 2017 21:34:03 +1000","Message-ID":"<877exi4pqs.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170901_043429_134498_357A79E0 ","X-CRM114-Status":"UNSURE (   8.10  )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:22e listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,\n\tCatalin Marinas <catalin.marinas@arm.com>,\n\tGabriele Paoloni <gabriele.paoloni@huawei.com>,\n\tDavid Airlie <airlied@linux.ie>, linux-pci <linux-pci@vger.kernel.org>,\n\tWill Deacon <will.deacon@arm.com>,\n\tdri-devel <dri-devel@lists.freedesktop.org>, \n\t\"Liuxinliang \\(Matthew Liu\\)\" <z.liuxinliang@hisilicon.com>,\n\tAlex Williamson <alex.williamson@redhat.com>,\n\tLukas Wunner <lukas@wunner.de>, Bjorn Helgaas <helgaas@kernel.org>,\n\tBenjamin Herrenschmidt <benh@kernel.crashing.org>,\n\tZou Rongrong <zourongrong@gmail.com>, \"Vetter,\n\tDaniel\" <daniel.vetter@intel.com>,\n\tlinuxppc-dev <linuxppc-dev@lists.ozlabs.org>,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1766041,"web_url":"http://patchwork.ozlabs.org/comment/1766041/","msgid":"<ccea6f96-4658-b25a-a8ba-2959815318e3@au1.ibm.com>","list_archive_url":null,"date":"2017-09-11T04:35:51","subject":"Re: [PATCH v3 2/3] drm: add fallback default device detection","submitter":{"id":66955,"url":"http://patchwork.ozlabs.org/api/people/66955/","name":"Andrew Donnellan","email":"andrew.donnellan@au1.ibm.com"},"content":"On 01/09/17 17:27, Daniel Axtens wrote:\n> The VGA arbiter selects a default VGA device that is enabled and\n> reachable via the legacy VGA resources (mem 0xa0000-0xbffff, io\n> 0x3b0-0x3bb, io 0x3c0-0x3df, etc).\n> \n> (As a special case for x86 and IA64, this can be overridden by\n> EFI.)\n> \n> If there is no such device, e.g., because there's no enabled VGA\n> device, the host bridge doesn't support access to those legacy\n> resources, or a PCI-PCI bridge doesn't have VGA Enable set, a\n> platform may select an arbitrary device by calling\n> pci_set_default_display(). powerpc does this, for example.\n> \n> If there is also no platform hook, there will be no default\n> device nominated. This is not necessarily what we want.\n> \n> Add handling for devices that aren't handled by the vga arbiter or\n> platform by adding a late initcall and a class enable hook. If there\n> is no default from vgaarb or the platform then the first VGA card\n> that is enabled, has a driver bound, and can decode memory or I/O\n> will be marked as default.\n> \n> This means single-card setups on systems without access to legacy\n> areas and without arch hooks will work. Multi-card setups on these\n> systems will nominate an arbitrary device, rather than no devices.\n> \n> Signed-off-by: Daniel Axtens <dja@axtens.net>\n> \n> ---\n> \n> v3:\n> \n> Split out from re-organisation for simplicity.\n> Add better description and better documentaion.\n> \n> Thanks to (in no particular order), Daniel Vetter, Lorenzo Pieralisi,\n> Ard Biesheuvel and Dave Airlie. Special thanks to Ben Herrenschmidt\n> and Bjorn Helgass, whose prose I have borrowed.\n> \n> v1:\n> \n> Tested on:\n>   - x86_64 laptop\n>   - arm64 D05 board with hibmc card\n>   - qemu powerpc with tcg and bochs std-vga\n> \n> I know this adds another config option and that's a bit sad, but\n> we can't include it unconditionally as it depends on PCI.\n> Suggestions welcome.\n\nTested on our iMac G5, the fallback handler doesn't fire (which should \nbe correct).\n\nTested-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>\n\n> +static void vga_default_enable_hook(struct pci_dev *pdev)\n> +{\n> +       if (!vga_default_active)\n> +\t       return;\n> +\n> +       if (pci_default_display())\n> +               return;\n> +\n> +       vga_default_try_device(pdev);\n> +}\n> +DECLARE_PCI_FIXUP_CLASS_ENABLE(PCI_ANY_ID, PCI_ANY_ID,\n> +\t\t\t       PCI_CLASS_DISPLAY_VGA, 8,\n> +\t\t\t       vga_default_enable_hook)\n> \n\nLooks like you have some spaces/tabs inconsistencies here.","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"ptPC6Gb8\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xrFWH2zxCz9sBd\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tMon, 11 Sep 2017 14:36:42 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drGSc-0007i9-K2; Mon, 11 Sep 2017 04:36:38 +0000","from mx0a-001b2d01.pphosted.com ([148.163.156.1])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drGST-0007Wk-LP for linux-arm-kernel@lists.infradead.org;\n\tMon, 11 Sep 2017 04:36:36 +0000","from pps.filterd (m0098410.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id\n\tv8B4YQPk144599 for <linux-arm-kernel@lists.infradead.org>;\n\tMon, 11 Sep 2017 00:35:59 -0400","from e23smtp03.au.ibm.com (e23smtp03.au.ibm.com [202.81.31.145])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 2cwdg4mh22-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tMon, 11 Sep 2017 00:35:58 -0400","from localhost\n\tby e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <linux-arm-kernel@lists.infradead.org> from\n\t<andrew.donnellan@au1.ibm.com>; Mon, 11 Sep 2017 14:35:56 +1000","from d23relay10.au.ibm.com (202.81.31.229)\n\tby e23smtp03.au.ibm.com (202.81.31.209) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tMon, 11 Sep 2017 14:35:54 +1000","from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97])\n\tby d23relay10.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tv8B4Zrek40108156 for <linux-arm-kernel@lists.infradead.org>;\n\tMon, 11 Sep 2017 14:35:53 +1000","from d23av03.au.ibm.com (localhost [127.0.0.1])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tv8B4ZiY9014296 for <linux-arm-kernel@lists.infradead.org>;\n\tMon, 11 Sep 2017 14:35:46 +1000","from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tv8B4ZiLi014293; Mon, 11 Sep 2017 14:35:44 +1000","from [10.61.2.125] (haven.au.ibm.com [9.192.254.114])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby ozlabs.au.ibm.com (Postfix) with ESMTPSA id A1914A0173;\n\tMon, 11 Sep 2017 14:35:51 +1000 (AEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:Message-Id:In-Reply-To:MIME-Version:Date:From:\n\tReferences:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=WfdQAlHWPCl9BNEUuskpmksxxFzQStTOrmKVKX5rMT4=;\n\tb=ptPC6Gb8fRCb+5dQ3qgB7xFZm\n\tg9H5B7CGI1zHv0WYQDig4QOqlLqksHqrEsBTRs3h75gqHHrskPok5LB6DMnfnNm5rZKl3mSkiQB9w\n\tWPNDux/U53kZGkxVE1RMiOE6j6Oa0vIOZm1pIg7EBiP4LenM62FM2IAoLphDaget3M2vblpWP6ZlG\n\t/ea14Twt0ExNNljQIjvxVF4XsKLYlIk0jYerUBaIt9Q1ayDKcwiO8l5PVLfooEDXzMAZKx7q1fl/S\n\txHKtdnPuVOI15SdcBquNpedWzye179lnC9waB+IOcI3BrIm0BHbe2H4Z1X5+n8bWEUTJx6QyynJeP\n\t7mr4QlzIA==;","Subject":"Re: [PATCH v3 2/3] drm: add fallback default device detection","To":"Daniel Axtens <dja@axtens.net>, linux-pci@vger.kernel.org,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<20170901072744.2409-3-dja@axtens.net>","From":"Andrew Donnellan <andrew.donnellan@au1.ibm.com>","Date":"Mon, 11 Sep 2017 14:35:51 +1000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901072744.2409-3-dja@axtens.net>","Content-Language":"en-AU","X-TM-AS-MML":"disable","x-cbid":"17091104-0008-0000-0000-00000157392F","X-IBM-AV-DETECTION":"SAVI=unused REMOTE=unused XFE=unused","x-cbparentid":"17091104-0009-0000-0000-0000098B5D4A","Message-Id":"<ccea6f96-4658-b25a-a8ba-2959815318e3@au1.ibm.com>","X-Proofpoint-Virus-Version":"vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2017-09-11_01:, , signatures=0","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=0\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1707230000\n\tdefinitions=main-1709110070","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170910_213633_533278_849FE163 ","X-CRM114-Status":"GOOD (  23.52  )","X-Spam-Score":"-2.6 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.6 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_MSPIKE_H3      RBL: Good reputation (+3)\n\t[148.163.156.1 listed in wl.mailspike.net]\n\t-0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/,\n\tlow trust [148.163.156.1 listed in list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.0 RCVD_IN_MSPIKE_WL      Mailspike good senders","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"lorenzo.pieralisi@arm.com, gabriele.paoloni@huawei.com,\n\tard.biesheuvel@linaro.org, airlied@linux.ie, catalin.marinas@arm.com, \n\twill.deacon@arm.com, dri-devel@lists.freedesktop.org,\n\tz.liuxinliang@hisilicon.com, alex.williamson@redhat.com,\n\tlukas@wunner.de, \n\thelgaas@kernel.org, zourongrong@gmail.com, daniel.vetter@intel.com","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1769875,"web_url":"http://patchwork.ozlabs.org/comment/1769875/","msgid":"<87d16oeeti.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-18T05:49:45","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi all,\n\nThe merge window is well over by now - is there anything else I can do\nto get this series to a mergeable state? I'm not particularly across the\nrules for drm-misc, so please let me know if there are things I need to\nbe doing.\n\nRegards,\nDaniel\n\nDaniel Axtens <dja@axtens.net> writes:\n\n> This patch set:\n>\n>  - splits the default display handling out from VGA arbiter, into its\n>    own file and behind its own Kconfig option (and gives the functions\n>    better names).\n>\n>  - adds extra detection of default devices. To be nominated, the vga\n>    arbiter and platform hooks must not have nominated a default. A\n>    card will then only be nominated if it has a driver attached and\n>    has IO or memory decoding enabled.\n>\n>  - adds relevant documentation.\n>\n> The practical impact of this is improved X autoconfiguration on some\n> arm64 systems.\n>\n> Changes in v3:\n>\n>  - Add documentation - thanks Daniel Vetter for pointing it out.\n>\n>  - Clarify explanations. Thanks to everyone for continuing to bear\n>    with my incomplete understanding of PCI and provide some clarity.\n>\n>  - Split refactoring and adding functionality.\n>\n> Changes in v2: https://www.spinics.net/lists/linux-pci/msg64007.html\n>\n> Drop all the powerpc patches. [explanation snipped]\n>\n> v1: https://www.spinics.net/lists/linux-pci/msg63581.html\n>\n> Regards,\n> Daniel\n>\n> Daniel Axtens (3):\n>   drm: split default display handler out of VGA arbiter\n>   drm: add fallback default device detection\n>   drm: documentation for default display device\n>\n>  Documentation/gpu/default_display.rst |  93 +++++++++++++++++++\n>  Documentation/gpu/index.rst           |   1 +\n>  arch/ia64/pci/fixup.c                 |   6 +-\n>  arch/powerpc/kernel/pci-common.c      |   6 +-\n>  arch/x86/pci/fixup.c                  |   6 +-\n>  arch/x86/video/fbdev.c                |   4 +-\n>  drivers/gpu/vga/Kconfig               |  12 +++\n>  drivers/gpu/vga/Makefile              |   1 +\n>  drivers/gpu/vga/default_display.c     | 163 ++++++++++++++++++++++++++++++++++\n>  drivers/gpu/vga/vga_switcheroo.c      |   8 +-\n>  drivers/gpu/vga/vgaarb.c              |  61 +++----------\n>  drivers/pci/pci-sysfs.c               |   4 +-\n>  include/linux/default_display.h       |  44 +++++++++\n>  include/linux/vgaarb.h                |  15 ----\n>  14 files changed, 344 insertions(+), 80 deletions(-)\n>  create mode 100644 Documentation/gpu/default_display.rst\n>  create mode 100644 drivers/gpu/vga/default_display.c\n>  create mode 100644 include/linux/default_display.h\n>\n> -- \n> 2.11.0","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"tCoLJAjy\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"nn9R1Un/\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xwZq71MP1z9s7g\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tMon, 18 Sep 2017 15:50:27 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtowp-0005Ik-DB; Mon, 18 Sep 2017 05:50:23 +0000","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dtowd-0003zL-M1 for linux-arm-kernel@lists.infradead.org;\n\tMon, 18 Sep 2017 05:50:18 +0000","by mail-pg0-x244.google.com with SMTP id i130so4757170pgc.0\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tSun, 17 Sep 2017 22:49:50 -0700 (PDT)","from localhost (114-198-116-25.dyn.iinet.net.au. [114.198.116.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tm69sm7786579pfc.38.2017.09.17.22.49.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 17 Sep 2017 22:49:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References\n\t:In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=1qLES+cPJCFmp//S0u8vs3ufiEySfq/hegIKofnPFKY=;\n\tb=tCoLJAjy7LtlHy\n\tQmZdtytNgm2wCZPDIV25qqLPaXLRT5wFh9vbB8kYmEnIJ4HsEkN9uuFQGxfUgwxIOZEQDVBtHoITT\n\tfo9VPsCCE8/6N7dQlMudsOodKg2KMh5CI+LTo/7ieKux3oUGRlflidIvdHQtnlZ1PY9Q07my+QVKn\n\tGAooCxfZg9ztEslWQiDPrSDHsaI7YIbN5QUiqCi/pA6nuOwVVNU2XPqpzIhQgPYbFhM0IHenGPzwc\n\tzM45TI6knb5+9mJgzMqau9miKCUpT7hblxkBdknDxidUhf8UaReVFXUq8AZ0kmhS9P7MjGRqzezfn\n\t8IuThNBYz5S1WICQW7Kw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version; bh=pCA2819zwHAt1VdndIDBz0V+VQcLAvdGTW+mM48T/7c=;\n\tb=nn9R1Un/z+2Fh3nI7amwmqYtH9/aXcjo/JHUaLllfRwSoapbIXcoMaaCYR/AjIL+bA\n\tSURFccCezbVXGh3vk0ou1F/kG6FBQQVj7JQWM3xCt72O/OdSLagokw9dy0fYV03mDcWg\n\tWkmm+R3+2MBmmZUb0JirSOe4ieNSr8MuZhThI="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=pCA2819zwHAt1VdndIDBz0V+VQcLAvdGTW+mM48T/7c=;\n\tb=BvYqmPJ975vLxuE3e8HJrOfIqfZO6H+KI2MC/yZenH5kyQCpfQNMKEgThKRtr5bltT\n\tYi4TJWDfAyklSlEfP/vrKx7oplFb6+yNupAIyY73rtVeNgbFAYvW5qBoDF9DdODQy3r9\n\tpeWCqsq384Q2BA691Ek3m8rYvfC2mRkyuvw898bM11jWKRUfTVqtFXLLM6Io8+W8i6iu\n\tKkrS0awWtxrr+vjR/1224jqFNKc8+yhVvDrV4Cp++MXweQlXWIOq6z3mMLyYqlpLtsO/\n\t1+uzQRw6FVnknXO/ipUAlBpqr8idqwFI0v381WlyM6ob3yKzlca4BFpZ4do5gRK7Nu7y\n\tCeLA==","X-Gm-Message-State":"AHPjjUiQgPeOxcJfGChy0lEL1mKl6KDf8XQs/DJvY0iZXH4WOAo9uNrP\n\t4Wxg46bs/N/oM3h+","X-Google-Smtp-Source":"ADKCNb6kWuPU7FEBb2YDGmvP+hOaGXyvA+wxizNis+N7NuqFOFoiGHfQ1+Ev2rz/b63uRfAV1P61dg==","X-Received":"by 10.99.120.197 with SMTP id t188mr31228675pgc.3.1505713789866; \n\tSun, 17 Sep 2017 22:49:49 -0700 (PDT)","From":"Daniel Axtens <dja@axtens.net>","To":"linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"<20170901072744.2409-1-dja@axtens.net>","References":"<20170901072744.2409-1-dja@axtens.net>","Date":"Mon, 18 Sep 2017 15:49:45 +1000","Message-ID":"<87d16oeeti.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170917_225011_840637_FAE525C0 ","X-CRM114-Status":"GOOD (  16.69  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"lorenzo.pieralisi@arm.com, gabriele.paoloni@huawei.com,\n\tard.biesheuvel@linaro.org, airlied@linux.ie, benh@kernel.crashing.org,\n\twill.deacon@arm.com, dri-devel@lists.freedesktop.org,\n\tz.liuxinliang@hisilicon.com, alex.williamson@redhat.com,\n\tlukas@wunner.de, \n\thelgaas@kernel.org, catalin.marinas@arm.com, zourongrong@gmail.com,\n\tdaniel.vetter@intel.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1775037,"web_url":"http://patchwork.ozlabs.org/comment/1775037/","msgid":"<87zi9ixsfn.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-25T23:35:40","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Bjorn,\n\n> But I think trying to split the \"default device\" part out from the VGA\n> arbiter ends up being overkill and making things more complicated\n> instead of simpler.\nFair enough.\n\n> Would something like the following work for you as well as the powerpc\n> case?  On powerpc, we already use vga_set_default_device() to select a\n> device that doesn't use legacy VGA resources, so maybe we can just do\n> the same on ARM64?\n\nIt looks good. I'll try to get some time on the test system to test it\nand I'll pester my friends at IBM to give it a go as well.\n\n> I suppose there might be wrinkles in how the arbiter deals with\n> multiple graphics devices on those systems, since I don't think it\n> identifies these devices that don't use the legacy resources, but it\n> seems like we live with whatever those on are powerpc and probably can\n> on ARM64 as well.\n\nI would say so, yes.\n\nThanks for sticking with this!\n\nRegards,\nDaniel\n\n>\n>\n> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\n> index 02831a396419..0ac7aa346c69 100644\n> --- a/arch/powerpc/kernel/pci-common.c\n> +++ b/arch/powerpc/kernel/pci-common.c\n> @@ -1740,15 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n>  }\n>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> -\n> -static void fixup_vga(struct pci_dev *pdev)\n> -{\n> -\tu16 cmd;\n> -\n> -\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> -\tif ((cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) || !vga_default_device())\n> -\t\tvga_set_default_device(pdev);\n> -\n> -}\n> -DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n> -\t\t\t      PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\n> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c\n> index 76875f6299b8..9df4802c5f04 100644\n> --- a/drivers/gpu/vga/vgaarb.c\n> +++ b/drivers/gpu/vga/vgaarb.c\n> @@ -1468,6 +1468,21 @@ static int __init vga_arb_device_init(void)\n>  \t\t\tvgaarb_info(dev, \"no bridge control possible\\n\");\n>  \t}\n>  \n> +\tif (!vga_default_device()) {\n> +\t\tlist_for_each_entry(vgadev, &vga_list, list) {\n> +\t\t\tstruct device *dev = &vgadev->pdev->dev;\n> +\t\t\tu16 cmd;\n> +\n> +\t\t\tpdev = vgadev->pdev;\n> +\t\t\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> +\t\t\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {\n> +\t\t\t\tvgaarb_info(dev, \"setting as boot device\\n\");\n> +\t\t\t\tvga_set_default_device(pdev);\n> +\t\t\t\tbreak;\n> +\t\t\t}\n> +\t\t}\n> +\t}\n> +\n>  \tpr_info(\"loaded\\n\");\n>  \treturn rc;\n>  }","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"oP/48qMR\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"egmHQ8Gs\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1L853QbFz9t2Q\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 09:36:37 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwcvR-00076F-Mw; Mon, 25 Sep 2017 23:36:33 +0000","from mail-pf0-x242.google.com ([2607:f8b0:400e:c00::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwcuz-0006IB-NE for linux-arm-kernel@lists.infradead.org;\n\tMon, 25 Sep 2017 23:36:14 +0000","by mail-pf0-x242.google.com with SMTP id i23so4237025pfi.2\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tMon, 25 Sep 2017 16:35:44 -0700 (PDT)","from localhost (114-198-116-25.dyn.iinet.net.au. [114.198.116.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tx8sm13209181pff.104.2017.09.25.16.35.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 25 Sep 2017 16:35:43 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References\n\t:In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=WlC4GMXrRe3EoWzkuLGUIreIM5tgHHqCDe9AIu+q3PA=;\n\tb=oP/48qMRzZW9uz\n\twsBidzEANw08WpLYFDo+A+cHHNJU1iit2m3bsM0krU3Q0CHdv3Zr4iyHoP8FKiJRK+as7aPN0J6Bx\n\tOji40baT5kVmxJmVSuX0nWnO/pxUatrRaKsltlwEfN8BY84saj1p3tdxxLbtJjdUZEj35oDOstjP7\n\tIVFgisKX/g0mxA/7PQgoQc/AkdKJ9ZRDx0jvn9zEu3R/YmN0Qf5q0Lt5FS2tZOglz9+twhI60+6fR\n\tJR8BdxAlxW76kTj9fEa6vZ53g/U0fFM7ssq2kWF40vdK1tV/kV70Ry2F/XyIzjfOYVjir23iKOYK9\n\tArGE5KCgZEPf4nCrWlZQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version; bh=V50pAjIi0RbEDtISkae4udQJQ7u8Q3BoSX6Zv1wU0Wo=;\n\tb=egmHQ8Gs1ZVqN/4IfyIPODIjgLEQLql4F0qPThFBRs+JBuP0o4Jgg3F+3h0L49IaUb\n\tgpxDute4dE76JD/shkeWG/lJ4WxzdML+bRMnol3FRpclDLaOwqMyadI2aK2p1HW2ciyE\n\tJ7sIxNLA5n443ezqweGuSyC39rbVluAnYDyIs="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=V50pAjIi0RbEDtISkae4udQJQ7u8Q3BoSX6Zv1wU0Wo=;\n\tb=pnRhLgs9oTyHnD23QhcitKWyV4rNoDPVfLMqhg7Nd/UsqxFA1N5LdZ8jgYx6CNdV37\n\te8FfLXtJm6huOizb92Y1zsacTgYofnw8QwUfNcMzRpH0WITbMDbPspOih+/SfkvV0+lE\n\tyX+n7HL3edH3sJJsdeMobpqTLH1qr5nzlgb0jM5V8cMbpGDfE0cs7HTaa8kRpzkbq3B3\n\t0nGV1qz5oxSJUsgnr5A3fCqRwCM5NSZgG7c2R0vttbvVKCPvFCQtQ4BncfwpVNkaFqwA\n\t5/+LmNgqohKgeTBlMb1DOyq0bzfFnvHj2jfdxW3HgIaCZYGkxocWI+vmUwrnMzCVCIiB\n\t9QxQ==","X-Gm-Message-State":"AHPjjUifvRw+Swxz6Z0o/K+oNpBnzaQkwInDRfJlCu5w4jhztHt3u7sg\n\tB+qDpb0iqLkctH9ZpwmYQRz72sqJP1s=","X-Google-Smtp-Source":"AOwi7QBpwdjXnt+2YxQ8SdiYlmt4u7cQUk48lCNIS4wDX6xvRUeAgBUFr19MYh0Te0ApD6v0lXEkiw==","X-Received":"by 10.159.198.11 with SMTP id f11mr9057924plo.290.1506382544519; \n\tMon, 25 Sep 2017 16:35:44 -0700 (PDT)","From":"Daniel Axtens <dja@axtens.net>","To":"Bjorn Helgaas <helgaas@kernel.org>","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","Date":"Tue, 26 Sep 2017 09:35:40 +1000","Message-ID":"<87zi9ixsfn.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170925_163606_713342_B8779A55 ","X-CRM114-Status":"GOOD (  15.00  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c00:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"lorenzo.pieralisi@arm.com, catalin.marinas@arm.com,\n\tgabriele.paoloni@huawei.com, ard.biesheuvel@linaro.org,\n\tairlied@linux.ie, linux-pci@vger.kernel.org, will.deacon@arm.com,\n\tdri-devel@lists.freedesktop.org, z.liuxinliang@hisilicon.com,\n\talex.williamson@redhat.com, lukas@wunner.de, benh@kernel.crashing.org,\n\tzourongrong@gmail.com, daniel.vetter@intel.com,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1775150,"web_url":"http://patchwork.ozlabs.org/comment/1775150/","msgid":"<CAKMK7uFq=WEYoeBBvBgSeFq9PCsqzbGiq6KiC10b1KabcayDQA@mail.gmail.com>","list_archive_url":null,"date":"2017-09-26T04:50:47","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":1959,"url":"http://patchwork.ozlabs.org/api/people/1959/","name":"Daniel Vetter","email":"daniel@ffwll.ch"},"content":"On Mon, Sep 18, 2017 at 7:49 AM, Daniel Axtens <dja@axtens.net> wrote:\n> Hi all,\n>\n> The merge window is well over by now - is there anything else I can do\n> to get this series to a mergeable state? I'm not particularly across the\n> rules for drm-misc, so please let me know if there are things I need to\n> be doing.\n\ndrm-misc is always open for feature merging, but the patch series\nlacks full r-b by someone with clue on this stuff (i.e. probably not\nme). Pls find someone who can do the in-depth review. Just an Ack\nfeels a bit thin.\n-Daniel\n\n>\n> Regards,\n> Daniel\n>\n> Daniel Axtens <dja@axtens.net> writes:\n>\n>> This patch set:\n>>\n>>  - splits the default display handling out from VGA arbiter, into its\n>>    own file and behind its own Kconfig option (and gives the functions\n>>    better names).\n>>\n>>  - adds extra detection of default devices. To be nominated, the vga\n>>    arbiter and platform hooks must not have nominated a default. A\n>>    card will then only be nominated if it has a driver attached and\n>>    has IO or memory decoding enabled.\n>>\n>>  - adds relevant documentation.\n>>\n>> The practical impact of this is improved X autoconfiguration on some\n>> arm64 systems.\n>>\n>> Changes in v3:\n>>\n>>  - Add documentation - thanks Daniel Vetter for pointing it out.\n>>\n>>  - Clarify explanations. Thanks to everyone for continuing to bear\n>>    with my incomplete understanding of PCI and provide some clarity.\n>>\n>>  - Split refactoring and adding functionality.\n>>\n>> Changes in v2: https://www.spinics.net/lists/linux-pci/msg64007.html\n>>\n>> Drop all the powerpc patches. [explanation snipped]\n>>\n>> v1: https://www.spinics.net/lists/linux-pci/msg63581.html\n>>\n>> Regards,\n>> Daniel\n>>\n>> Daniel Axtens (3):\n>>   drm: split default display handler out of VGA arbiter\n>>   drm: add fallback default device detection\n>>   drm: documentation for default display device\n>>\n>>  Documentation/gpu/default_display.rst |  93 +++++++++++++++++++\n>>  Documentation/gpu/index.rst           |   1 +\n>>  arch/ia64/pci/fixup.c                 |   6 +-\n>>  arch/powerpc/kernel/pci-common.c      |   6 +-\n>>  arch/x86/pci/fixup.c                  |   6 +-\n>>  arch/x86/video/fbdev.c                |   4 +-\n>>  drivers/gpu/vga/Kconfig               |  12 +++\n>>  drivers/gpu/vga/Makefile              |   1 +\n>>  drivers/gpu/vga/default_display.c     | 163 ++++++++++++++++++++++++++++++++++\n>>  drivers/gpu/vga/vga_switcheroo.c      |   8 +-\n>>  drivers/gpu/vga/vgaarb.c              |  61 +++----------\n>>  drivers/pci/pci-sysfs.c               |   4 +-\n>>  include/linux/default_display.h       |  44 +++++++++\n>>  include/linux/vgaarb.h                |  15 ----\n>>  14 files changed, 344 insertions(+), 80 deletions(-)\n>>  create mode 100644 Documentation/gpu/default_display.rst\n>>  create mode 100644 drivers/gpu/vga/default_display.c\n>>  create mode 100644 include/linux/default_display.h\n>>\n>> --\n>> 2.11.0\n> _______________________________________________\n> dri-devel mailing list\n> dri-devel@lists.freedesktop.org\n> https://lists.freedesktop.org/mailman/listinfo/dri-devel","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"WZTlJx9R\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ffwll.ch header.i=@ffwll.ch header.b=\"H3Tzntws\";\n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y1T7W6nLzz9t49\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tTue, 26 Sep 2017 14:51:35 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwhq1-00037f-Ab; Tue, 26 Sep 2017 04:51:17 +0000","from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dwhpu-0002Xi-Ij for linux-arm-kernel@lists.infradead.org;\n\tTue, 26 Sep 2017 04:51:13 +0000","by mail-io0-x244.google.com with SMTP id e9so3967379iod.5\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tMon, 25 Sep 2017 21:50:48 -0700 (PDT)","by 10.79.196.218 with HTTP; Mon, 25 Sep 2017 21:50:47 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=vynUcoNWdMAAY1T9t+26fQjDELn5k0/ZkpbseEqoPrQ=;\n\tb=WZTlJx9RmbT6XD\n\tCB804mL9yF2A76wqkXt7BflvWNCqxSaDCiyxOYOryJgiJ5Vklvr2S4dZOcHlsggaaBtxJZxYb2x2k\n\taaxQyz932lzH0rKdnsFPV4JuYgdjtNp1n8fEo0pcUATQ50FOIPy4lTUts0DxqmOLirw/1kFIV9vtd\n\txJZSwL/liUOXHuN8g1o5qNxVTpU0gGLhXw0NaPpmHA++FfQ0m30pCmNkMnFE/jCKVaMNGZBlztM+G\n\tk7p7piYgw2p1jqGz4upLjqBKLOm4KnpmYhIA08hDKsNWMBIdVgWExdfXgDXFkPLITSM8NJEQ22UQU\n\thEak5JNvoAHdbyrssjPw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; \n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=ALaR7ZPUKJAvxC9ec44smT1itV2hk5mm+wlcPk8/Szg=;\n\tb=H3TzntwsJBGEkgqCp7bqNqVAnMqbFwSSH2E95Ou3WUuDVd5JsaLsgLF4YcIwyPkJMk\n\tZEgxSqqDEqFDauZLW37YUw9+qOpkN8diLKlahoaIBR+cRlvKN2wJn8xYvqu/qotfvZLV\n\t5I5PoXdqYkn+RuFLzo5XXOqu1qI08dsJfAnx0="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=ALaR7ZPUKJAvxC9ec44smT1itV2hk5mm+wlcPk8/Szg=;\n\tb=FktsEDQauFbOT0/0OC8+LiVyEO0Pc+M0eoaIm1FwQUIprOqOOzxJvo335IT5rL+1HQ\n\tFeBXkSHEdSve8ZMYaBSwqep/BNyFuyp70iO5SSNnil/P2Yx0SdB0uMpvOXU6pUyhKUgF\n\twrM7LfyYc2IY97HdT37nMJNF2Sm08sub6kLBQXM7c5wSTJ/6Ki5WuFTXclVUwlKqLZFH\n\tdUMDFaitT14XO9oAe6roF+P5CS9I/xceV50PixzAIEemucYlI/Rv7WsoIg4vjWIO2uuk\n\tycTeZZy/r7ixkR9aeofv+uv8/ViRNbwvpvsrxQM1WJZ2lzVu/LysA7a7RD9ccAkxQtds\n\tnx6A==","X-Gm-Message-State":"AHPjjUhqdNNpwJQ6RvezN4TbTY8RND96Tr0ou59KukeO7HXNzv5I9K/b\n\taBlcad0mCcvkgJZDnvC9P5ddAcT45laiZTy/GQQdlQ==","X-Google-Smtp-Source":"AOwi7QADp6IJE9+VdK2+9dma+1Tid9d28AIGXgaKl9CJgflJRkz0V4PyriRhq7Yyp71wP9xnA2xbIRFRSe8qgVZ/RJ8=","X-Received":"by 10.107.78.19 with SMTP id c19mr12199367iob.205.1506401447938; \n\tMon, 25 Sep 2017 21:50:47 -0700 (PDT)","MIME-Version":"1.0","X-Originating-IP":"[2a02:168:5635:0:39d2:f87e:2033:9f6]","In-Reply-To":"<87d16oeeti.fsf@linkitivity.dja.id.au>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<87d16oeeti.fsf@linkitivity.dja.id.au>","From":"Daniel Vetter <daniel@ffwll.ch>","Date":"Tue, 26 Sep 2017 06:50:47 +0200","X-Google-Sender-Auth":"rri8DyWNfxLwjPRRXClnCNPlmLM","Message-ID":"<CAKMK7uFq=WEYoeBBvBgSeFq9PCsqzbGiq6KiC10b1KabcayDQA@mail.gmail.com>","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","To":"Daniel Axtens <dja@axtens.net>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170925_215110_996484_429492C3 ","X-CRM114-Status":"GOOD (  19.78  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"lorenzo.pieralisi@arm.com, gabriele.paoloni@huawei.com,\n\tard.biesheuvel@linaro.org, Linux PCI <linux-pci@vger.kernel.org>,\n\tWill Deacon <will.deacon@arm.com>,\n\tdri-devel <dri-devel@lists.freedesktop.org>, \n\tXinliang Liu <z.liuxinliang@hisilicon.com>,\n\tAlex Williamson <alex.williamson@redhat.com>,\n\tBjorn Helgaas <helgaas@kernel.org>,\n\tCatalin Marinas <catalin.marinas@arm.com>, \n\tRongrong Zou <zourongrong@gmail.com>,\n\tDaniel Vetter <daniel.vetter@intel.com>, \n\tlinuxppc-dev <linuxppc-dev@lists.ozlabs.org>,\n\t\"linux-arm-kernel@lists.infradead.org\"\n\t<linux-arm-kernel@lists.infradead.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1776018,"web_url":"http://patchwork.ozlabs.org/comment/1776018/","msgid":"<87k20kyezs.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-27T03:52:55","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Bjorn,\n\nYes, this works:\n\nTested-by: Daniel Axtens <dja@axtens.net> # arm64, ppc64-qemu-tcg\n\n\nRegards,\nDaniel\n> On Fri, Sep 01, 2017 at 05:27:41PM +1000, Daniel Axtens wrote:\n>> This patch set:\n>> \n>>  - splits the default display handling out from VGA arbiter, into its\n>>    own file and behind its own Kconfig option (and gives the functions\n>>    better names).\n>> \n>>  - adds extra detection of default devices. To be nominated, the vga\n>>    arbiter and platform hooks must not have nominated a default. A\n>>    card will then only be nominated if it has a driver attached and\n>>    has IO or memory decoding enabled.\n>> \n>>  - adds relevant documentation.\n>> \n>> The practical impact of this is improved X autoconfiguration on some\n>> arm64 systems.\n>\n> I think I gave you bad advice about trying to separate the \"default\n> device\" idea from the VGA arbiter.\n>\n> It is true that the \"VGA arbiter\" per se is related to routing the\n> legacy VGA resources, and the arbiter currently only selects a default\n> device if it finds a device to which those resources are routed.\n>\n> We have some cases where we want to select a default device that may\n> not support the legacy VGA resources, or where they might not be\n> routed to the device:\n>\n>   - systems where we match the EFI framebuffer address with a BAR, and\n>     select that device as default,\n>\n>   - powerpc systems where there may be no host bridge window that maps\n>     to the legacy VGA resources,\n>\n>   - your ARM64 systems where the default device may be behind a bridge\n>     that doesn't support legacy VGA routing (PCI_BRIDGE_CTL_VGA)\n>\n> But I think trying to split the \"default device\" part out from the VGA\n> arbiter ends up being overkill and making things more complicated\n> instead of simpler.\n>\n> Would something like the following work for you as well as the powerpc\n> case?  On powerpc, we already use vga_set_default_device() to select a\n> device that doesn't use legacy VGA resources, so maybe we can just do\n> the same on ARM64?\n>\n> I suppose there might be wrinkles in how the arbiter deals with\n> multiple graphics devices on those systems, since I don't think it\n> identifies these devices that don't use the legacy resources, but it\n> seems like we live with whatever those on are powerpc and probably can\n> on ARM64 as well.\n>\n>\n> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\n> index 02831a396419..0ac7aa346c69 100644\n> --- a/arch/powerpc/kernel/pci-common.c\n> +++ b/arch/powerpc/kernel/pci-common.c\n> @@ -1740,15 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n>  }\n>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n>  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> -\n> -static void fixup_vga(struct pci_dev *pdev)\n> -{\n> -\tu16 cmd;\n> -\n> -\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> -\tif ((cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) || !vga_default_device())\n> -\t\tvga_set_default_device(pdev);\n> -\n> -}\n> -DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n> -\t\t\t      PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\n> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c\n> index 76875f6299b8..9df4802c5f04 100644\n> --- a/drivers/gpu/vga/vgaarb.c\n> +++ b/drivers/gpu/vga/vgaarb.c\n> @@ -1468,6 +1468,21 @@ static int __init vga_arb_device_init(void)\n>  \t\t\tvgaarb_info(dev, \"no bridge control possible\\n\");\n>  \t}\n>  \n> +\tif (!vga_default_device()) {\n> +\t\tlist_for_each_entry(vgadev, &vga_list, list) {\n> +\t\t\tstruct device *dev = &vgadev->pdev->dev;\n> +\t\t\tu16 cmd;\n> +\n> +\t\t\tpdev = vgadev->pdev;\n> +\t\t\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> +\t\t\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {\n> +\t\t\t\tvgaarb_info(dev, \"setting as boot device\\n\");\n> +\t\t\t\tvga_set_default_device(pdev);\n> +\t\t\t\tbreak;\n> +\t\t\t}\n> +\t\t}\n> +\t}\n> +\n>  \tpr_info(\"loaded\\n\");\n>  \treturn rc;\n>  }","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"A8YLbtqg\"; \n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"rXPPJvwL\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y23p22kWcz9sRg\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tWed, 27 Sep 2017 13:53:30 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx3Pa-0007We-Fk; Wed, 27 Sep 2017 03:53:26 +0000","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dx3PW-0007SY-6g for linux-arm-kernel@lists.infradead.org;\n\tWed, 27 Sep 2017 03:53:23 +0000","by mail-pg0-x244.google.com with SMTP id j16so7952075pga.2\n\tfor <linux-arm-kernel@lists.infradead.org>;\n\tTue, 26 Sep 2017 20:53:00 -0700 (PDT)","from localhost (114-198-116-25.dyn.iinet.net.au. [114.198.116.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tz78sm122006pfd.178.2017.09.26.20.52.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 26 Sep 2017 20:52:58 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:References\n\t:In-Reply-To:Subject:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=jhPNtY+Bk3uXSm5zS+28+x++d7xzd5MHAcFu4xoDPy0=;\n\tb=A8YLbtqgqcpPJT\n\tGGpVcEiZ5JazH1gYK0HHaLcdzH4pt+5OQZZwtXFqSBAC5zvhr6hG3eMuTkSjS6el6EWX35TnaaxN4\n\t9EVrOzZnL47i8NC+WRRsWQAbefWbFF0Culz96zNh9dwaoEqPZAt3D6DUAFzgoxvYYkPLo6LOMgRvy\n\tXAs6MqBZKXGOTpD077tkJRTXSs9Z9kqzhc27y8I46ZcEEy9dCPPsqZ/q5b3bXsfFccVXQtYBGo9p2\n\tfCwl+R/tlTagO9ZD9Kp2w9LbzH7yi07sJ3iMIoiKpIuF+gHXbXxXK0/KW+VlzSCPHRnyov9I+1r9u\n\tLzvhiBbIGkbjnrZSQXVg==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version; bh=2zm4YkB0xmZwxQhUEwq4HYM1b/zI46iK9KMneDwvCUU=;\n\tb=rXPPJvwLKHOeSbR26eQ6xU1ltTjGi6qggEG65sWa+Nk6I2PZs0dwToFPzYdW75/s+p\n\ts2kpIaK3wwR7Al0giHIcQS3KBkCA58a8tGemhWvIbY0XJJ+KZ2/+iAu8MRrEgkrahaEp\n\tuuE6NFLCVbz71vuvCjNivYMFd7tka/3wpGwuo="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=2zm4YkB0xmZwxQhUEwq4HYM1b/zI46iK9KMneDwvCUU=;\n\tb=oM9dNoCxxOZOTooEuv+yiw/9FcE7LJ3dXUIH16SbO3x8TvvnExGEMgWHJKGpIJ7fgq\n\tOYSbh6QTwoGwNCNgeXUVHifyH2gd1/GPw/8mMd1vqAOY6hMPVQXHUC5VzhnuzC5NvxKp\n\tC/hB7gcsCUjnL7j8shCIJKUdWSxrjyAW74EEvRQ+LGvlB2ZYnQfPbcdMC9v8pmYF2P7n\n\tMF0ssMECjcWgGmHEdhabmMm+UguwIo4tFPvlm/1LHeE/dX0BkRBMJQErVwULukpwLmu3\n\tCkymY8gPz+EzlVZ7UkaXk7WVMvXgAmWSwMNvkc3LIrFvOCyz0SQE/xtvF/YzFP0tMZ1J\n\teQyA==","X-Gm-Message-State":"AHPjjUjGdLYOa2PIRudv+s/139w+NofOO7zPwGr6fF/r86K2wMfLRZIn\n\tFra4NzS79nP+hHrmlO2Dhzx96A==","X-Google-Smtp-Source":"AOwi7QAQ4+M6mdFDpdv+DrhRjLZlPoXg+niDkoqCZTtj3f8jNq0Srv24b4sdw/kwsi5gdVbUAglWxQ==","X-Received":"by 10.99.104.6 with SMTP id d6mr82666pgc.168.1506484379705;\n\tTue, 26 Sep 2017 20:52:59 -0700 (PDT)","From":"Daniel Axtens <dja@axtens.net>","To":"Bjorn Helgaas <helgaas@kernel.org>","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","Date":"Wed, 27 Sep 2017 13:52:55 +1000","Message-ID":"<87k20kyezs.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170926_205322_285831_61B16257 ","X-CRM114-Status":"GOOD (  21.51  )","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-2.0 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS               SPF: sender matches SPF record\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED            Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"lorenzo.pieralisi@arm.com, catalin.marinas@arm.com,\n\tgabriele.paoloni@huawei.com, ard.biesheuvel@linaro.org,\n\tairlied@linux.ie, linux-pci@vger.kernel.org, will.deacon@arm.com,\n\tdri-devel@lists.freedesktop.org, z.liuxinliang@hisilicon.com,\n\talex.williamson@redhat.com, lukas@wunner.de, benh@kernel.crashing.org,\n\tzourongrong@gmail.com, daniel.vetter@intel.com,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1781872,"web_url":"http://patchwork.ozlabs.org/comment/1781872/","msgid":"<20171006195118.GG25517@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-10-06T19:51:18","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Sep 27, 2017 at 01:52:55PM +1000, Daniel Axtens wrote:\n> Hi Bjorn,\n> \n> Yes, this works:\n> \n> Tested-by: Daniel Axtens <dja@axtens.net> # arm64, ppc64-qemu-tcg\n\nI guess I was assuming you'd pick this up, but that doesn't really\nmake sense because I didn't give you a signed-off-by or anything.\nI'll post this with a changelog and signed-off-by so it doesn't get\nlost.\n\nI also noticed that I didn't correctly handle the powerpc quirk case\nwhere it doesn't require the device to be enabled at all.  I'll try to\nfix that up, too.\n\nBjorn\n\n> > On Fri, Sep 01, 2017 at 05:27:41PM +1000, Daniel Axtens wrote:\n> >> This patch set:\n> >> \n> >>  - splits the default display handling out from VGA arbiter, into its\n> >>    own file and behind its own Kconfig option (and gives the functions\n> >>    better names).\n> >> \n> >>  - adds extra detection of default devices. To be nominated, the vga\n> >>    arbiter and platform hooks must not have nominated a default. A\n> >>    card will then only be nominated if it has a driver attached and\n> >>    has IO or memory decoding enabled.\n> >> \n> >>  - adds relevant documentation.\n> >> \n> >> The practical impact of this is improved X autoconfiguration on some\n> >> arm64 systems.\n> >\n> > I think I gave you bad advice about trying to separate the \"default\n> > device\" idea from the VGA arbiter.\n> >\n> > It is true that the \"VGA arbiter\" per se is related to routing the\n> > legacy VGA resources, and the arbiter currently only selects a default\n> > device if it finds a device to which those resources are routed.\n> >\n> > We have some cases where we want to select a default device that may\n> > not support the legacy VGA resources, or where they might not be\n> > routed to the device:\n> >\n> >   - systems where we match the EFI framebuffer address with a BAR, and\n> >     select that device as default,\n> >\n> >   - powerpc systems where there may be no host bridge window that maps\n> >     to the legacy VGA resources,\n> >\n> >   - your ARM64 systems where the default device may be behind a bridge\n> >     that doesn't support legacy VGA routing (PCI_BRIDGE_CTL_VGA)\n> >\n> > But I think trying to split the \"default device\" part out from the VGA\n> > arbiter ends up being overkill and making things more complicated\n> > instead of simpler.\n> >\n> > Would something like the following work for you as well as the powerpc\n> > case?  On powerpc, we already use vga_set_default_device() to select a\n> > device that doesn't use legacy VGA resources, so maybe we can just do\n> > the same on ARM64?\n> >\n> > I suppose there might be wrinkles in how the arbiter deals with\n> > multiple graphics devices on those systems, since I don't think it\n> > identifies these devices that don't use the legacy resources, but it\n> > seems like we live with whatever those on are powerpc and probably can\n> > on ARM64 as well.\n> >\n> >\n> > diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\n> > index 02831a396419..0ac7aa346c69 100644\n> > --- a/arch/powerpc/kernel/pci-common.c\n> > +++ b/arch/powerpc/kernel/pci-common.c\n> > @@ -1740,15 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n> >  }\n> >  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> >  DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> > -\n> > -static void fixup_vga(struct pci_dev *pdev)\n> > -{\n> > -\tu16 cmd;\n> > -\n> > -\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> > -\tif ((cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) || !vga_default_device())\n> > -\t\tvga_set_default_device(pdev);\n> > -\n> > -}\n> > -DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n> > -\t\t\t      PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\n> > diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c\n> > index 76875f6299b8..9df4802c5f04 100644\n> > --- a/drivers/gpu/vga/vgaarb.c\n> > +++ b/drivers/gpu/vga/vgaarb.c\n> > @@ -1468,6 +1468,21 @@ static int __init vga_arb_device_init(void)\n> >  \t\t\tvgaarb_info(dev, \"no bridge control possible\\n\");\n> >  \t}\n> >  \n> > +\tif (!vga_default_device()) {\n> > +\t\tlist_for_each_entry(vgadev, &vga_list, list) {\n> > +\t\t\tstruct device *dev = &vgadev->pdev->dev;\n> > +\t\t\tu16 cmd;\n> > +\n> > +\t\t\tpdev = vgadev->pdev;\n> > +\t\t\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> > +\t\t\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {\n> > +\t\t\t\tvgaarb_info(dev, \"setting as boot device\\n\");\n> > +\t\t\t\tvga_set_default_device(pdev);\n> > +\t\t\t\tbreak;\n> > +\t\t\t}\n> > +\t\t}\n> > +\t}\n> > +\n> >  \tpr_info(\"loaded\\n\");\n> >  \treturn rc;\n> >  }\n> \n>","headers":{"Return-Path":"<linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org>","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"DZe9aq4Z\"; dkim-atps=neutral","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3y80dc2Sm7z9t3R\n\tfor <incoming-imx@patchwork.ozlabs.org>;\n\tSat,  7 Oct 2017 06:51:48 +1100 (AEDT)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e0Yeu-0003y4-4t; Fri, 06 Oct 2017 19:51:44 +0000","from mail.kernel.org ([198.145.29.99])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1e0Yeq-0003wo-7u for linux-arm-kernel@lists.infradead.org;\n\tFri, 06 Oct 2017 19:51:42 +0000","from localhost (unknown [69.55.156.165])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 5782A217C5;\n\tFri,  6 Oct 2017 19:51:19 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=yAQ+Eizjai5p778sW6PdDfi+2Q/Ks3l/NEd7dyCDJL0=;\n\tb=DZe9aq4ZSQmHqE\n\txDCGzCEOWaDCng59IN/tAV+RsaXH+fJTsdH/Q1+GAmtiTufnFl8x+n841eUwt3mrmFwJZebbuETsO\n\tve//1MNao2aK1zq5Oyp60XeQ+p7bjIJjOnXdyJ1FaG31vHkv1M7mcHmr8JJS0SRJGl9dHcq8nr+VM\n\tNRpJDu/Zfhf/sgns1l48tzc+97HFenht39VHuAuQ5Ztk3sH5GTSaUEdbP0xuPMyhqgwJMzBn6tm09\n\tQUHrXokVZ7ygfU6cRfl+FFBDpvednwtJ2bum03XHRhfPwOCfyF9OeBiv+fniZ6YrfPzPBvQIxJfgH\n\t4d2nVgy3NUBh0qg1kcnA==;","DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 5782A217C5","Date":"Fri, 6 Oct 2017 14:51:18 -0500","From":"Bjorn Helgaas <helgaas@kernel.org>","To":"Daniel Axtens <dja@axtens.net>","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","Message-ID":"<20171006195118.GG25517@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>\n\t<87k20kyezs.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<87k20kyezs.fsf@linkitivity.dja.id.au>","User-Agent":"Mutt/1.5.21 (2010-09-15)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20171006_125140_344401_2E94A7D4 ","X-CRM114-Status":"GOOD (  30.99  )","X-Spam-Score":"-6.9 (------)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details:   (-6.9 points)\n\tpts rule name              description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at http://www.dnswl.org/,\n\thigh trust [198.145.29.99 listed in list.dnswl.org]\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":"<http://lists.infradead.org/mailman/options/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe>","List-Archive":"<http://lists.infradead.org/pipermail/linux-arm-kernel/>","List-Post":"<mailto:linux-arm-kernel@lists.infradead.org>","List-Help":"<mailto:linux-arm-kernel-request@lists.infradead.org?subject=help>","List-Subscribe":"<http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>,\n\t<mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe>","Cc":"lorenzo.pieralisi@arm.com, catalin.marinas@arm.com,\n\tgabriele.paoloni@huawei.com, ard.biesheuvel@linaro.org,\n\tairlied@linux.ie, linux-pci@vger.kernel.org, will.deacon@arm.com,\n\tdri-devel@lists.freedesktop.org, z.liuxinliang@hisilicon.com,\n\talex.williamson@redhat.com, lukas@wunner.de, benh@kernel.crashing.org,\n\tzourongrong@gmail.com, daniel.vetter@intel.com,\n\tlinuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" <linux-arm-kernel-bounces@lists.infradead.org>","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]