[{"id":1761538,"web_url":"http://patchwork.ozlabs.org/comment/1761538/","msgid":"","list_archive_url":null,"date":"2017-09-01T09:21:28","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":26857,"url":"http://patchwork.ozlabs.org/api/people/26857/","name":"Ard Biesheuvel","email":"ard.biesheuvel@linaro.org"},"content":"On 1 September 2017 at 08:27, Daniel Axtens wrote:\n> This patch set:\n>\n> - splits the default display handling out from VGA arbiter, into its\n> own file and behind its own Kconfig option (and gives the functions\n> better names).\n>\n> - adds extra detection of default devices. To be nominated, the vga\n> arbiter and platform hooks must not have nominated a default. A\n> card will then only be nominated if it has a driver attached and\n> has IO or memory decoding enabled.\n>\n> - adds relevant documentation.\n>\n> The practical impact of this is improved X autoconfiguration on some\n> arm64 systems.\n>\n> Changes in v3:\n>\n> - Add documentation - thanks Daniel Vetter for pointing it out.\n>\n> - Clarify explanations. Thanks to everyone for continuing to bear\n> with my incomplete understanding of PCI and provide some clarity.\n>\n> - Split refactoring and adding functionality.\n>\n> Changes in v2: https://www.spinics.net/lists/linux-pci/msg64007.html\n>\n> Drop all the powerpc patches. [explanation snipped]\n>\n> v1: https://www.spinics.net/lists/linux-pci/msg63581.html\n>\n\nIf we are all in agreement that fixing X is not an option, I think\nthis is a reasonable approach\n\nAcked-by: Ard Biesheuvel ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"LX2pt3Hp\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkDJX3Ffgz9s7C\n\tfor ;\n\tFri, 1 Sep 2017 19:21:32 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751747AbdIAJVb (ORCPT );\n\tFri, 1 Sep 2017 05:21:31 -0400","from mail-io0-f180.google.com ([209.85.223.180]:35971 \"EHLO\n\tmail-io0-f180.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751742AbdIAJV3 (ORCPT\n\t); Fri, 1 Sep 2017 05:21:29 -0400","by mail-io0-f180.google.com with SMTP id f99so12998443ioi.3\n\tfor ; Fri, 01 Sep 2017 02:21:29 -0700 (PDT)","by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 02:21:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:in-reply-to:references:from:date:message-id:subject:to\n\t:cc; bh=vUu84/h/jvtCItaGwo1bc5wC7lcY/Sh/FYatpb3W5IU=;\n\tb=LX2pt3HpWW4ieJq0Quy+9dCS4JRP3kDHv1UBqMlco+SGlzCRw6t3ywr64J8ayjFmaQ\n\thMi/M71fi9XCoxqnu2EGpjHVeO/5hT8VEzgO1OC8zoYGLK1D/f6Gd+UuNXgbPtZ15gSI\n\tjOEzQuOrbCcb+3yKSsbayDB44mFD6zqiS1coY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:in-reply-to:references:from:date\n\t:message-id:subject:to:cc;\n\tbh=vUu84/h/jvtCItaGwo1bc5wC7lcY/Sh/FYatpb3W5IU=;\n\tb=QZ8rBD9WhdhibwQ0MgI6POjkF9pgWykM7xKKilDHNu++MsxueIBDn+GoSgl5SI4uDO\n\t6O9YFfKA/1igAw2W+EiBVAQ0AUKSO/n4tgB4uPzVszvzr9gEsUJhPyMIW9svbpPjpHM4\n\tItXNX0LxlcPepIUC6PXGPMNFqQtlghMOK6/4iNUwQuNQIOtrYbhdcVQxl/4LAl0ePJEx\n\tp8ZxVH+9FKu+iXxjJWgNJlZ1As2BC/QNbhcJFgY3/tSg59RMTTQspfGV9Zl6vmh2sbgJ\n\t7vvk+SMhPkA3rx5QRyg4sxSDJwOwiiQfkT6EAvPOWCQpJUStBvOk/Nj1ajTgWDOiunw4\n\thmhw==","X-Gm-Message-State":"AHPjjUgB8uhtZq07KQ3Re80MESsJ2YJV3XkNiy+27cTqDwDWDaqLZ4sL\n\tM9H06BlgwgZChqELPQVSrlxWfHTwHDol","X-Google-Smtp-Source":"ADKCNb4iKKv5ao+lHVeCqJiTNjesZPYM/oP+erkLwKZ6hGQLVGPEd2xVZkVmmcgf3TieP27Fcp8VlmLHLmS4//zv4To=","X-Received":"by 10.107.157.78 with SMTP id g75mr939055ioe.190.1504257689324; \n\tFri, 01 Sep 2017 02:21:29 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<20170901072744.2409-1-dja@axtens.net>","References":"<20170901072744.2409-1-dja@axtens.net>","From":"Ard Biesheuvel ","Date":"Fri, 1 Sep 2017 10:21:28 +0100","Message-ID":"","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","To":"Daniel Axtens ","Cc":"linux-pci ,\n\tlinuxppc-dev ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t,\n\tBenjamin Herrenschmidt ,\n\t\"Liuxinliang (Matthew Liu)\" ,\n\tZou Rongrong ,\n\tCatalin Marinas ,\n\tWill Deacon ,\n\tGabriele Paoloni ,\n\tBjorn Helgaas , David Airlie ,\n\t\"Vetter, Daniel\" ,\n\tAlex Williamson ,\n\tdri-devel ,\n\tLukas Wunner ,\n\tLorenzo Pieralisi ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1761602,"web_url":"http://patchwork.ozlabs.org/comment/1761602/","msgid":"<877exi4pqs.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-01T11:34:03","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Ard,\n\n> If we are all in agreement that fixing X is not an option, I think\n> this is a reasonable approach\n\nThis did come up in discussion at some earlier point in one of the many\nspins we've done of this - I don't remember if you brought it up or\nsomeone else did - but my concern was this: If it were just X we would\nbe fine, but if we go down that path I'm worried about also having to\nfix Mir/Wayland/whatever-the-new-exciting-display-server-is-this-week,\nad nauseum.\n\n> Acked-by: Ard Biesheuvel \n\nThanks!\n\nRegards,\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"jpF9V08N\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xkHFZ1Kygz9sRV\n\tfor ;\n\tFri, 1 Sep 2017 21:34:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751516AbdIALeI (ORCPT );\n\tFri, 1 Sep 2017 07:34:08 -0400","from mail-pf0-f179.google.com ([209.85.192.179]:36343 \"EHLO\n\tmail-pf0-f179.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751479AbdIALeI (ORCPT\n\t); Fri, 1 Sep 2017 07:34:08 -0400","by mail-pf0-f179.google.com with SMTP id r187so7339570pfr.3\n\tfor ; Fri, 01 Sep 2017 04:34:08 -0700 (PDT)","from localhost (124-171-202-56.dyn.iinet.net.au. [124.171.202.56])\n\tby smtp.gmail.com with ESMTPSA id\n\ti186sm3396283pfg.81.2017.09.01.04.34.06\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 04:34:07 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version;\n\tbh=qWGL5c4JBTLwNXuqKxllXPmtqu9UUSkea6L203jvn5M=;\n\tb=jpF9V08NvdX2YZfEkbWfnlzUovqjv/160WGos83bRhvGLxz1oKPqqIRhIskT2YXPnn\n\tkP38Xx6rRTMQOCW4deR6W5T28kLRAgPrxA8NS2W20Fm1HXSqak60xDW9N1Rb+fCfbPdb\n\td2P9f+hR3hQjmrPUtK5H9SyDMvoooaii2fEJ4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=qWGL5c4JBTLwNXuqKxllXPmtqu9UUSkea6L203jvn5M=;\n\tb=gcx0dwJMousXf9Jd/nZdNdhh1GrMvgrqt3Sr4196NmpK5F9ASt5LYdonOig5qkxXsK\n\tX5BDJA3L9+fik6BmbtKUIY5T6dIQFbVvXOXtIXHIbH4rQ/5PIwWK7aJFjiVnBQH4Fbzt\n\tfxrobx9T718PTEjfEag3LGboMMR7A+FdEUitfTFk4DI3Knk+eVVj0Ma6z1Qz7kCpET41\n\teiqsvvCVrX8pd2S8SPksiipn0+y0MV4xIg8opL3nsb22i3f4Bo1VXEyAedlZ0etcGP2P\n\thfwFuWPCaY+p85bOR0AjBAiDQUBHLkepA6ms6YnHRZ+PUV8KgAl/4K4R+s+1cS3vRMdZ\n\tr8oQ==","X-Gm-Message-State":"AHPjjUh7oLzbRftYCKj/r66YhD5DB/e7G7Go01MDXEQcFsBvQ48Z/3Kz\n\tcGVlRU2DxgMpMT/h","X-Google-Smtp-Source":"ADKCNb5q/niM3gxxOq005BTvH+03JTr/qks3Gpc4iymYQD4huGxKIUGsgc/cuT7PbzcybDJrQSYmng==","X-Received":"by 10.98.215.80 with SMTP id v16mr1937136pfl.342.1504265647741; \n\tFri, 01 Sep 2017 04:34:07 -0700 (PDT)","From":"Daniel Axtens ","To":"Ard Biesheuvel ","Cc":"linux-pci ,\n\tlinuxppc-dev ,\n\t\"linux-arm-kernel\\@lists.infradead.org\" \n\t,\n\tBenjamin Herrenschmidt ,\n\t\"Liuxinliang \\(Matthew Liu\\)\" ,\n\tZou Rongrong ,\n\tCatalin Marinas ,\n\tWill Deacon ,\n\tGabriele Paoloni ,\n\tBjorn Helgaas , David Airlie ,\n\t\"Vetter\\, Daniel\" ,\n\tAlex Williamson ,\n\tdri-devel ,\n\tLukas Wunner ,\n\tLorenzo Pieralisi ","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"","References":"<20170901072744.2409-1-dja@axtens.net>\n\t","Date":"Fri, 01 Sep 2017 21:34:03 +1000","Message-ID":"<877exi4pqs.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1769874,"web_url":"http://patchwork.ozlabs.org/comment/1769874/","msgid":"<87d16oeeti.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-18T05:49:45","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi all,\n\nThe merge window is well over by now - is there anything else I can do\nto get this series to a mergeable state? I'm not particularly across the\nrules for drm-misc, so please let me know if there are things I need to\nbe doing.\n\nRegards,\nDaniel\n\nDaniel Axtens writes:\n\n> This patch set:\n>\n> - splits the default display handling out from VGA arbiter, into its\n> own file and behind its own Kconfig option (and gives the functions\n> better names).\n>\n> - adds extra detection of default devices. To be nominated, the vga\n> arbiter and platform hooks must not have nominated a default. A\n> card will then only be nominated if it has a driver attached and\n> has IO or memory decoding enabled.\n>\n> - adds relevant documentation.\n>\n> The practical impact of this is improved X autoconfiguration on some\n> arm64 systems.\n>\n> Changes in v3:\n>\n> - Add documentation - thanks Daniel Vetter for pointing it out.\n>\n> - Clarify explanations. Thanks to everyone for continuing to bear\n> with my incomplete understanding of PCI and provide some clarity.\n>\n> - Split refactoring and adding functionality.\n>\n> Changes in v2: https://www.spinics.net/lists/linux-pci/msg64007.html\n>\n> Drop all the powerpc patches. [explanation snipped]\n>\n> v1: https://www.spinics.net/lists/linux-pci/msg63581.html\n>\n> Regards,\n> Daniel\n>\n> Daniel Axtens (3):\n> drm: split default display handler out of VGA arbiter\n> drm: add fallback default device detection\n> drm: documentation for default display device\n>\n> Documentation/gpu/default_display.rst | 93 +++++++++++++++++++\n> Documentation/gpu/index.rst | 1 +\n> arch/ia64/pci/fixup.c | 6 +-\n> arch/powerpc/kernel/pci-common.c | 6 +-\n> arch/x86/pci/fixup.c | 6 +-\n> arch/x86/video/fbdev.c | 4 +-\n> drivers/gpu/vga/Kconfig | 12 +++\n> drivers/gpu/vga/Makefile | 1 +\n> drivers/gpu/vga/default_display.c | 163 ++++++++++++++++++++++++++++++++++\n> drivers/gpu/vga/vga_switcheroo.c | 8 +-\n> drivers/gpu/vga/vgaarb.c | 61 +++----------\n> drivers/pci/pci-sysfs.c | 4 +-\n> include/linux/default_display.h | 44 +++++++++\n> include/linux/vgaarb.h | 15 ----\n> 14 files changed, 344 insertions(+), 80 deletions(-)\n> create mode 100644 Documentation/gpu/default_display.rst\n> create mode 100644 drivers/gpu/vga/default_display.c\n> create mode 100644 include/linux/default_display.h\n>\n> -- \n> 2.11.0","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"nn9R1Un/\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xwZpT1NJwz9s7g\n\tfor ;\n\tMon, 18 Sep 2017 15:49:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751663AbdIRFtv (ORCPT );\n\tMon, 18 Sep 2017 01:49:51 -0400","from mail-pg0-f67.google.com ([74.125.83.67]:34056 \"EHLO\n\tmail-pg0-f67.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1750711AbdIRFtu (ORCPT\n\t); Mon, 18 Sep 2017 01:49:50 -0400","by mail-pg0-f67.google.com with SMTP id v82so4753782pgb.1\n\tfor ; Sun, 17 Sep 2017 22:49:50 -0700 (PDT)","from localhost (114-198-116-25.dyn.iinet.net.au. [114.198.116.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tm69sm7786579pfc.38.2017.09.17.22.49.48\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 17 Sep 2017 22:49:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version;\n\tbh=pCA2819zwHAt1VdndIDBz0V+VQcLAvdGTW+mM48T/7c=;\n\tb=nn9R1Un/z+2Fh3nI7amwmqYtH9/aXcjo/JHUaLllfRwSoapbIXcoMaaCYR/AjIL+bA\n\tSURFccCezbVXGh3vk0ou1F/kG6FBQQVj7JQWM3xCt72O/OdSLagokw9dy0fYV03mDcWg\n\tWkmm+R3+2MBmmZUb0JirSOe4ieNSr8MuZhThI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=pCA2819zwHAt1VdndIDBz0V+VQcLAvdGTW+mM48T/7c=;\n\tb=MerMmKtcyx3JWD3iUelQ06BEYsLjLOdC+qAf2KFFs4PSQ/nZwZfH/xx0aYKEJAA1ci\n\twIx8IRtn9J+47snfIZT84+7vRLqorIu05/3PQhiC/gpCwGDwiF00BfXI+vyZfW9Gandk\n\tqtKiibk06BbFyxb1tmmvjdA2l2ewZMB0QGBtzCj60ZN02h+aoe0+ZMASDVOG1fQIwVnw\n\tFf+LJasZPPBsgjsnr6IS1CsigHoOWvsoPcU2GB1E+kpXVae5GTnUwIfSnYJdaYbE3wnW\n\tjdGRdW84Qz6HdZUi/V2OeeFdvO/71IN2Jz/u+WME6+hIUO9HHmtGSWfeTbDRNkFfQYvH\n\tOY/Q==","X-Gm-Message-State":"AHPjjUh8m9KzL9GduNhaZwM6GOHXgiAMn8FXOFHFb/L/ndFYsJZdrbQB\n\t3XywS2Sq8E6mFrJ/IiEepQ==","X-Google-Smtp-Source":"ADKCNb6kWuPU7FEBb2YDGmvP+hOaGXyvA+wxizNis+N7NuqFOFoiGHfQ1+Ev2rz/b63uRfAV1P61dg==","X-Received":"by 10.99.120.197 with SMTP id t188mr31228675pgc.3.1505713789866; \n\tSun, 17 Sep 2017 22:49:49 -0700 (PDT)","From":"Daniel Axtens ","To":"linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org","Cc":"benh@kernel.crashing.org, z.liuxinliang@hisilicon.com,\n\tzourongrong@gmail.com, catalin.marinas@arm.com,\n\twill.deacon@arm.com, gabriele.paoloni@huawei.com,\n\thelgaas@kernel.org, airlied@linux.ie, daniel.vetter@intel.com,\n\talex.williamson@redhat.com, dri-devel@lists.freedesktop.org,\n\tlukas@wunner.de, ard.biesheuvel@linaro.org, lorenzo.pieralisi@arm.com","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"<20170901072744.2409-1-dja@axtens.net>","References":"<20170901072744.2409-1-dja@axtens.net>","Date":"Mon, 18 Sep 2017 15:49:45 +1000","Message-ID":"<87d16oeeti.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1774848,"web_url":"http://patchwork.ozlabs.org/comment/1774848/","msgid":"<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-09-25T16:39:48","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Fri, Sep 01, 2017 at 05:27:41PM +1000, Daniel Axtens wrote:\n> This patch set:\n> \n> - splits the default display handling out from VGA arbiter, into its\n> own file and behind its own Kconfig option (and gives the functions\n> better names).\n> \n> - adds extra detection of default devices. To be nominated, the vga\n> arbiter and platform hooks must not have nominated a default. A\n> card will then only be nominated if it has a driver attached and\n> has IO or memory decoding enabled.\n> \n> - adds relevant documentation.\n> \n> The practical impact of this is improved X autoconfiguration on some\n> arm64 systems.\n\nI think I gave you bad advice about trying to separate the \"default\ndevice\" idea from the VGA arbiter.\n\nIt is true that the \"VGA arbiter\" per se is related to routing the\nlegacy VGA resources, and the arbiter currently only selects a default\ndevice if it finds a device to which those resources are routed.\n\nWe have some cases where we want to select a default device that may\nnot support the legacy VGA resources, or where they might not be\nrouted to the device:\n\n - systems where we match the EFI framebuffer address with a BAR, and\n select that device as default,\n\n - powerpc systems where there may be no host bridge window that maps\n to the legacy VGA resources,\n\n - your ARM64 systems where the default device may be behind a bridge\n that doesn't support legacy VGA routing (PCI_BRIDGE_CTL_VGA)\n\nBut I think trying to split the \"default device\" part out from the VGA\narbiter ends up being overkill and making things more complicated\ninstead of simpler.\n\nWould something like the following work for you as well as the powerpc\ncase? On powerpc, we already use vga_set_default_device() to select a\ndevice that doesn't use legacy VGA resources, so maybe we can just do\nthe same on ARM64?\n\nI suppose there might be wrinkles in how the arbiter deals with\nmultiple graphics devices on those systems, since I don't think it\nidentifies these devices that don't use the legacy resources, but it\nseems like we live with whatever those on are powerpc and probably can\non ARM64 as well.\n\n\ndiff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\nindex 02831a396419..0ac7aa346c69 100644\n--- a/arch/powerpc/kernel/pci-common.c\n+++ b/arch/powerpc/kernel/pci-common.c\n@@ -1740,15 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n }\n DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n-\n-static void fixup_vga(struct pci_dev *pdev)\n-{\n-\tu16 cmd;\n-\n-\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n-\tif ((cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) || !vga_default_device())\n-\t\tvga_set_default_device(pdev);\n-\n-}\n-DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n-\t\t\t PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\ndiff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c\nindex 76875f6299b8..9df4802c5f04 100644\n--- a/drivers/gpu/vga/vgaarb.c\n+++ b/drivers/gpu/vga/vgaarb.c\n@@ -1468,6 +1468,21 @@ static int __init vga_arb_device_init(void)\n \t\t\tvgaarb_info(dev, \"no bridge control possible\\n\");\n \t}\n \n+\tif (!vga_default_device()) {\n+\t\tlist_for_each_entry(vgadev, &vga_list, list) {\n+\t\t\tstruct device *dev = &vgadev->pdev->dev;\n+\t\t\tu16 cmd;\n+\n+\t\t\tpdev = vgadev->pdev;\n+\t\t\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n+\t\t\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {\n+\t\t\t\tvgaarb_info(dev, \"setting as boot device\\n\");\n+\t\t\t\tvga_set_default_device(pdev);\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n \tpr_info(\"loaded\\n\");\n \treturn rc;\n }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y18vF1QYnz9t3k\n\tfor ;\n\tTue, 26 Sep 2017 02:39:53 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S935920AbdIYQjv (ORCPT );\n\tMon, 25 Sep 2017 12:39:51 -0400","from mail.kernel.org ([198.145.29.99]:54918 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S935560AbdIYQjv (ORCPT );\n\tMon, 25 Sep 2017 12:39:51 -0400","from localhost (unknown [69.71.4.159])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 5A84A2148C;\n\tMon, 25 Sep 2017 16:39:50 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 5A84A2148C","Date":"Mon, 25 Sep 2017 11:39:48 -0500","From":"Bjorn Helgaas ","To":"Daniel Axtens ","Cc":"linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org, benh@kernel.crashing.org,\n\tz.liuxinliang@hisilicon.com, zourongrong@gmail.com,\n\tcatalin.marinas@arm.com, will.deacon@arm.com,\n\tgabriele.paoloni@huawei.com, airlied@linux.ie,\n\tdaniel.vetter@intel.com, alex.williamson@redhat.com,\n\tdri-devel@lists.freedesktop.org, lukas@wunner.de,\n\tard.biesheuvel@linaro.org, lorenzo.pieralisi@arm.com","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","Message-ID":"<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170901072744.2409-1-dja@axtens.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901072744.2409-1-dja@axtens.net>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1775035,"web_url":"http://patchwork.ozlabs.org/comment/1775035/","msgid":"<87zi9ixsfn.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-25T23:35:40","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Bjorn,\n\n> But I think trying to split the \"default device\" part out from the VGA\n> arbiter ends up being overkill and making things more complicated\n> instead of simpler.\nFair enough.\n\n> Would something like the following work for you as well as the powerpc\n> case? On powerpc, we already use vga_set_default_device() to select a\n> device that doesn't use legacy VGA resources, so maybe we can just do\n> the same on ARM64?\n\nIt looks good. I'll try to get some time on the test system to test it\nand I'll pester my friends at IBM to give it a go as well.\n\n> I suppose there might be wrinkles in how the arbiter deals with\n> multiple graphics devices on those systems, since I don't think it\n> identifies these devices that don't use the legacy resources, but it\n> seems like we live with whatever those on are powerpc and probably can\n> on ARM64 as well.\n\nI would say so, yes.\n\nThanks for sticking with this!\n\nRegards,\nDaniel\n\n>\n>\n> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\n> index 02831a396419..0ac7aa346c69 100644\n> --- a/arch/powerpc/kernel/pci-common.c\n> +++ b/arch/powerpc/kernel/pci-common.c\n> @@ -1740,15 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n> }\n> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> -\n> -static void fixup_vga(struct pci_dev *pdev)\n> -{\n> -\tu16 cmd;\n> -\n> -\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> -\tif ((cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) || !vga_default_device())\n> -\t\tvga_set_default_device(pdev);\n> -\n> -}\n> -DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n> -\t\t\t PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\n> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c\n> index 76875f6299b8..9df4802c5f04 100644\n> --- a/drivers/gpu/vga/vgaarb.c\n> +++ b/drivers/gpu/vga/vgaarb.c\n> @@ -1468,6 +1468,21 @@ static int __init vga_arb_device_init(void)\n> \t\t\tvgaarb_info(dev, \"no bridge control possible\\n\");\n> \t}\n> \n> +\tif (!vga_default_device()) {\n> +\t\tlist_for_each_entry(vgadev, &vga_list, list) {\n> +\t\t\tstruct device *dev = &vgadev->pdev->dev;\n> +\t\t\tu16 cmd;\n> +\n> +\t\t\tpdev = vgadev->pdev;\n> +\t\t\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> +\t\t\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {\n> +\t\t\t\tvgaarb_info(dev, \"setting as boot device\\n\");\n> +\t\t\t\tvga_set_default_device(pdev);\n> +\t\t\t\tbreak;\n> +\t\t\t}\n> +\t\t}\n> +\t}\n> +\n> \tpr_info(\"loaded\\n\");\n> \treturn rc;\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"egmHQ8Gs\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1L772dLjz9t2Q\n\tfor ;\n\tTue, 26 Sep 2017 09:35:47 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S966446AbdIYXfq (ORCPT );\n\tMon, 25 Sep 2017 19:35:46 -0400","from mail-pf0-f194.google.com ([209.85.192.194]:34262 \"EHLO\n\tmail-pf0-f194.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S966206AbdIYXfp (ORCPT\n\t); Mon, 25 Sep 2017 19:35:45 -0400","by mail-pf0-f194.google.com with SMTP id g65so4246084pfe.1\n\tfor ; Mon, 25 Sep 2017 16:35:44 -0700 (PDT)","from localhost (114-198-116-25.dyn.iinet.net.au. [114.198.116.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tx8sm13209181pff.104.2017.09.25.16.35.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 25 Sep 2017 16:35:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version;\n\tbh=V50pAjIi0RbEDtISkae4udQJQ7u8Q3BoSX6Zv1wU0Wo=;\n\tb=egmHQ8Gs1ZVqN/4IfyIPODIjgLEQLql4F0qPThFBRs+JBuP0o4Jgg3F+3h0L49IaUb\n\tgpxDute4dE76JD/shkeWG/lJ4WxzdML+bRMnol3FRpclDLaOwqMyadI2aK2p1HW2ciyE\n\tJ7sIxNLA5n443ezqweGuSyC39rbVluAnYDyIs=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=V50pAjIi0RbEDtISkae4udQJQ7u8Q3BoSX6Zv1wU0Wo=;\n\tb=VjQxf6gLQ87MjjqOKVuN8iL+itWf+UcwnYIM9HIHDgs9c7hvWhyRngvGqj/bp5PpQc\n\tXb++o03x/EcPBX8fN0wu3InucIWSlhIui3xb+QeveTnqiixWyCUedxGqymThl7vAFzkO\n\tXeEkiJqpCDZBJrIwwELEub9kcsnOKcIESTNNuNgbihZeVYSuntp14Dy7xRNVA+A7jDhq\n\tk/F0KPs6evttLnVIGqXvo9eeltekFZuqf5TuYoN5paHop5IESHSD1kKFdc8qO0obEGkS\n\tUfGKNR+KygKJg7Crqz3LTfQOLbYkTZz8RKzXAEk4rOOKe8Fd+eS/YqjjUFhjCygHGwOg\n\tb0cA==","X-Gm-Message-State":"AHPjjUgSIN87MZvVvTIwNAUaGsffQa0inidAT7aYvyXpzKzLktqTM1Zn\n\thkLoIDA0BEkLmRwoEnxyT2z2QA==","X-Google-Smtp-Source":"AOwi7QBpwdjXnt+2YxQ8SdiYlmt4u7cQUk48lCNIS4wDX6xvRUeAgBUFr19MYh0Te0ApD6v0lXEkiw==","X-Received":"by 10.159.198.11 with SMTP id f11mr9057924plo.290.1506382544519; \n\tMon, 25 Sep 2017 16:35:44 -0700 (PDT)","From":"Daniel Axtens ","To":"Bjorn Helgaas ","Cc":"linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org, benh@kernel.crashing.org,\n\tz.liuxinliang@hisilicon.com, zourongrong@gmail.com,\n\tcatalin.marinas@arm.com, will.deacon@arm.com,\n\tgabriele.paoloni@huawei.com, airlied@linux.ie,\n\tdaniel.vetter@intel.com, alex.williamson@redhat.com,\n\tdri-devel@lists.freedesktop.org, lukas@wunner.de,\n\tard.biesheuvel@linaro.org, lorenzo.pieralisi@arm.com","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","Date":"Tue, 26 Sep 2017 09:35:40 +1000","Message-ID":"<87zi9ixsfn.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1775149,"web_url":"http://patchwork.ozlabs.org/comment/1775149/","msgid":"","list_archive_url":null,"date":"2017-09-26T04:50:47","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":1959,"url":"http://patchwork.ozlabs.org/api/people/1959/","name":"Daniel Vetter","email":"daniel@ffwll.ch"},"content":"On Mon, Sep 18, 2017 at 7:49 AM, Daniel Axtens wrote:\n> Hi all,\n>\n> The merge window is well over by now - is there anything else I can do\n> to get this series to a mergeable state? I'm not particularly across the\n> rules for drm-misc, so please let me know if there are things I need to\n> be doing.\n\ndrm-misc is always open for feature merging, but the patch series\nlacks full r-b by someone with clue on this stuff (i.e. probably not\nme). Pls find someone who can do the in-depth review. Just an Ack\nfeels a bit thin.\n-Daniel\n\n>\n> Regards,\n> Daniel\n>\n> Daniel Axtens writes:\n>\n>> This patch set:\n>>\n>> - splits the default display handling out from VGA arbiter, into its\n>> own file and behind its own Kconfig option (and gives the functions\n>> better names).\n>>\n>> - adds extra detection of default devices. To be nominated, the vga\n>> arbiter and platform hooks must not have nominated a default. A\n>> card will then only be nominated if it has a driver attached and\n>> has IO or memory decoding enabled.\n>>\n>> - adds relevant documentation.\n>>\n>> The practical impact of this is improved X autoconfiguration on some\n>> arm64 systems.\n>>\n>> Changes in v3:\n>>\n>> - Add documentation - thanks Daniel Vetter for pointing it out.\n>>\n>> - Clarify explanations. Thanks to everyone for continuing to bear\n>> with my incomplete understanding of PCI and provide some clarity.\n>>\n>> - Split refactoring and adding functionality.\n>>\n>> Changes in v2: https://www.spinics.net/lists/linux-pci/msg64007.html\n>>\n>> Drop all the powerpc patches. [explanation snipped]\n>>\n>> v1: https://www.spinics.net/lists/linux-pci/msg63581.html\n>>\n>> Regards,\n>> Daniel\n>>\n>> Daniel Axtens (3):\n>> drm: split default display handler out of VGA arbiter\n>> drm: add fallback default device detection\n>> drm: documentation for default display device\n>>\n>> Documentation/gpu/default_display.rst | 93 +++++++++++++++++++\n>> Documentation/gpu/index.rst | 1 +\n>> arch/ia64/pci/fixup.c | 6 +-\n>> arch/powerpc/kernel/pci-common.c | 6 +-\n>> arch/x86/pci/fixup.c | 6 +-\n>> arch/x86/video/fbdev.c | 4 +-\n>> drivers/gpu/vga/Kconfig | 12 +++\n>> drivers/gpu/vga/Makefile | 1 +\n>> drivers/gpu/vga/default_display.c | 163 ++++++++++++++++++++++++++++++++++\n>> drivers/gpu/vga/vga_switcheroo.c | 8 +-\n>> drivers/gpu/vga/vgaarb.c | 61 +++----------\n>> drivers/pci/pci-sysfs.c | 4 +-\n>> include/linux/default_display.h | 44 +++++++++\n>> include/linux/vgaarb.h | 15 ----\n>> 14 files changed, 344 insertions(+), 80 deletions(-)\n>> create mode 100644 Documentation/gpu/default_display.rst\n>> create mode 100644 drivers/gpu/vga/default_display.c\n>> create mode 100644 include/linux/default_display.h\n>>\n>> --\n>> 2.11.0\n> _______________________________________________\n> dri-devel mailing list\n> dri-devel@lists.freedesktop.org\n> https://lists.freedesktop.org/mailman/listinfo/dri-devel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ffwll.ch header.i=@ffwll.ch header.b=\"H3Tzntws\";\n\tdkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y1T6f3YKmz9sNr\n\tfor ;\n\tTue, 26 Sep 2017 14:50:50 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S936200AbdIZEut (ORCPT );\n\tTue, 26 Sep 2017 00:50:49 -0400","from mail-io0-f196.google.com ([209.85.223.196]:35475 \"EHLO\n\tmail-io0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S935426AbdIZEus (ORCPT\n\t); Tue, 26 Sep 2017 00:50:48 -0400","by mail-io0-f196.google.com with SMTP id d16so3958833ioj.2\n\tfor ; Mon, 25 Sep 2017 21:50:48 -0700 (PDT)","by 10.79.196.218 with HTTP; Mon, 25 Sep 2017 21:50:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google;\n\th=mime-version:sender:in-reply-to:references:from:date:message-id\n\t:subject:to:cc;\n\tbh=ALaR7ZPUKJAvxC9ec44smT1itV2hk5mm+wlcPk8/Szg=;\n\tb=H3TzntwsJBGEkgqCp7bqNqVAnMqbFwSSH2E95Ou3WUuDVd5JsaLsgLF4YcIwyPkJMk\n\tZEgxSqqDEqFDauZLW37YUw9+qOpkN8diLKlahoaIBR+cRlvKN2wJn8xYvqu/qotfvZLV\n\t5I5PoXdqYkn+RuFLzo5XXOqu1qI08dsJfAnx0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:sender:in-reply-to:references:from\n\t:date:message-id:subject:to:cc;\n\tbh=ALaR7ZPUKJAvxC9ec44smT1itV2hk5mm+wlcPk8/Szg=;\n\tb=F6sVmOdm2KX0y/xwu3jkCx7h1PDGIGH1T431sgGqmJ/eOSqJV19Y2Wjz0sW2ENvddz\n\tw2V872iL770UVY+BKcfVukJxTC1+CR5eeunLP+8IQLZCv2xht+Pf+LMe/EV6wXzYiTgA\n\tdLAeuNc5OpNmvuDXafTKoNSpp98avcz29DIof39tOfAZkRzDCxTda/O0084WcBNUrwc/\n\trkJs/QQWkQbgKCO0G265mk8SwcSI94wS5rZx231wvC3HZBsxw+iqz8XhLjzxkY0I+ZPi\n\t5i0pxRgrRtoGVLoSZIgUtlRzD1vUbLttAjGqGp6ZX+HzQbsBdxn1N5iD3OkiSqwCD3oA\n\tbTXg==","X-Gm-Message-State":"AHPjjUiNNFDtpgFHmmyNBOVyRn+wWu2YI7lsy5pIGD/Y2BWEVijDpc8n\n\t48N0X6GcjiT3xM8wfaUSDDVs+xjQpSv/bEq6tc/Trw==","X-Google-Smtp-Source":"AOwi7QADp6IJE9+VdK2+9dma+1Tid9d28AIGXgaKl9CJgflJRkz0V4PyriRhq7Yyp71wP9xnA2xbIRFRSe8qgVZ/RJ8=","X-Received":"by 10.107.78.19 with SMTP id c19mr12199367iob.205.1506401447938; \n\tMon, 25 Sep 2017 21:50:47 -0700 (PDT)","MIME-Version":"1.0","X-Originating-IP":"[2a02:168:5635:0:39d2:f87e:2033:9f6]","In-Reply-To":"<87d16oeeti.fsf@linkitivity.dja.id.au>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<87d16oeeti.fsf@linkitivity.dja.id.au>","From":"Daniel Vetter ","Date":"Tue, 26 Sep 2017 06:50:47 +0200","X-Google-Sender-Auth":"rri8DyWNfxLwjPRRXClnCNPlmLM","Message-ID":"","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","To":"Daniel Axtens ","Cc":"Linux PCI ,\n\tlinuxppc-dev ,\n\t\"linux-arm-kernel@lists.infradead.org\" \n\t, lorenzo.pieralisi@arm.com,\n\tgabriele.paoloni@huawei.com, ard.biesheuvel@linaro.org,\n\tWill Deacon ,\n\tdri-devel ,\n\tXinliang Liu ,\n\tAlex Williamson ,\n\tBjorn Helgaas ,\n\tCatalin Marinas ,\n\tRongrong Zou ,\n\tDaniel Vetter ","Content-Type":"text/plain; charset=\"UTF-8\"","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1776017,"web_url":"http://patchwork.ozlabs.org/comment/1776017/","msgid":"<87k20kyezs.fsf@linkitivity.dja.id.au>","list_archive_url":null,"date":"2017-09-27T03:52:55","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":65792,"url":"http://patchwork.ozlabs.org/api/people/65792/","name":"Daniel Axtens","email":"dja@axtens.net"},"content":"Hi Bjorn,\n\nYes, this works:\n\nTested-by: Daniel Axtens # arm64, ppc64-qemu-tcg\n\n\nRegards,\nDaniel\n> On Fri, Sep 01, 2017 at 05:27:41PM +1000, Daniel Axtens wrote:\n>> This patch set:\n>> \n>> - splits the default display handling out from VGA arbiter, into its\n>> own file and behind its own Kconfig option (and gives the functions\n>> better names).\n>> \n>> - adds extra detection of default devices. To be nominated, the vga\n>> arbiter and platform hooks must not have nominated a default. A\n>> card will then only be nominated if it has a driver attached and\n>> has IO or memory decoding enabled.\n>> \n>> - adds relevant documentation.\n>> \n>> The practical impact of this is improved X autoconfiguration on some\n>> arm64 systems.\n>\n> I think I gave you bad advice about trying to separate the \"default\n> device\" idea from the VGA arbiter.\n>\n> It is true that the \"VGA arbiter\" per se is related to routing the\n> legacy VGA resources, and the arbiter currently only selects a default\n> device if it finds a device to which those resources are routed.\n>\n> We have some cases where we want to select a default device that may\n> not support the legacy VGA resources, or where they might not be\n> routed to the device:\n>\n> - systems where we match the EFI framebuffer address with a BAR, and\n> select that device as default,\n>\n> - powerpc systems where there may be no host bridge window that maps\n> to the legacy VGA resources,\n>\n> - your ARM64 systems where the default device may be behind a bridge\n> that doesn't support legacy VGA routing (PCI_BRIDGE_CTL_VGA)\n>\n> But I think trying to split the \"default device\" part out from the VGA\n> arbiter ends up being overkill and making things more complicated\n> instead of simpler.\n>\n> Would something like the following work for you as well as the powerpc\n> case? On powerpc, we already use vga_set_default_device() to select a\n> device that doesn't use legacy VGA resources, so maybe we can just do\n> the same on ARM64?\n>\n> I suppose there might be wrinkles in how the arbiter deals with\n> multiple graphics devices on those systems, since I don't think it\n> identifies these devices that don't use the legacy resources, but it\n> seems like we live with whatever those on are powerpc and probably can\n> on ARM64 as well.\n>\n>\n> diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\n> index 02831a396419..0ac7aa346c69 100644\n> --- a/arch/powerpc/kernel/pci-common.c\n> +++ b/arch/powerpc/kernel/pci-common.c\n> @@ -1740,15 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n> }\n> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> -\n> -static void fixup_vga(struct pci_dev *pdev)\n> -{\n> -\tu16 cmd;\n> -\n> -\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> -\tif ((cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) || !vga_default_device())\n> -\t\tvga_set_default_device(pdev);\n> -\n> -}\n> -DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n> -\t\t\t PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\n> diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c\n> index 76875f6299b8..9df4802c5f04 100644\n> --- a/drivers/gpu/vga/vgaarb.c\n> +++ b/drivers/gpu/vga/vgaarb.c\n> @@ -1468,6 +1468,21 @@ static int __init vga_arb_device_init(void)\n> \t\t\tvgaarb_info(dev, \"no bridge control possible\\n\");\n> \t}\n> \n> +\tif (!vga_default_device()) {\n> +\t\tlist_for_each_entry(vgadev, &vga_list, list) {\n> +\t\t\tstruct device *dev = &vgadev->pdev->dev;\n> +\t\t\tu16 cmd;\n> +\n> +\t\t\tpdev = vgadev->pdev;\n> +\t\t\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> +\t\t\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {\n> +\t\t\t\tvgaarb_info(dev, \"setting as boot device\\n\");\n> +\t\t\t\tvga_set_default_device(pdev);\n> +\t\t\t\tbreak;\n> +\t\t\t}\n> +\t\t}\n> +\t}\n> +\n> \tpr_info(\"loaded\\n\");\n> \treturn rc;\n> }","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=axtens.net header.i=@axtens.net\n\theader.b=\"rXPPJvwL\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y23nW1vrjz9sRg\n\tfor ;\n\tWed, 27 Sep 2017 13:53:03 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S970811AbdI0DxB (ORCPT );\n\tTue, 26 Sep 2017 23:53:01 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:32997 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S968951AbdI0DxA (ORCPT\n\t); Tue, 26 Sep 2017 23:53:00 -0400","by mail-pg0-f66.google.com with SMTP id i130so7948958pgc.0\n\tfor ; Tue, 26 Sep 2017 20:53:00 -0700 (PDT)","from localhost (114-198-116-25.dyn.iinet.net.au. [114.198.116.25])\n\tby smtp.gmail.com with ESMTPSA id\n\tz78sm122006pfd.178.2017.09.26.20.52.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 26 Sep 2017 20:52:58 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google;\n\th=from:to:cc:subject:in-reply-to:references:date:message-id\n\t:mime-version;\n\tbh=2zm4YkB0xmZwxQhUEwq4HYM1b/zI46iK9KMneDwvCUU=;\n\tb=rXPPJvwLKHOeSbR26eQ6xU1ltTjGi6qggEG65sWa+Nk6I2PZs0dwToFPzYdW75/s+p\n\ts2kpIaK3wwR7Al0giHIcQS3KBkCA58a8tGemhWvIbY0XJJ+KZ2/+iAu8MRrEgkrahaEp\n\tuuE6NFLCVbz71vuvCjNivYMFd7tka/3wpGwuo=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date\n\t:message-id:mime-version;\n\tbh=2zm4YkB0xmZwxQhUEwq4HYM1b/zI46iK9KMneDwvCUU=;\n\tb=H+TSYmXElC0BnCMIXnH4VKGsODubUTJ5XaY0MboGk4EnXa/FxQyJLipPeI/j8/+yj4\n\tR3aRKWP0I7lqHh+TQESb0cD1NbaOzwqRrUbx9UrC7hu9LI9qmVaZ4AJtysOx1B3XvrwQ\n\tXLtgmQ+AOZzcc45QT8+v+cnodpT9X73WJK7iazq9Pm7Fq6yQyCQdXeogxCyYH6DrfVlL\n\tNPHtKTGgcS3zIqGSNr1u6gXYn3pKml6zIpYmeXMQpDaIg6+m1j4w3rmzZrxkjcJeSeGT\n\tPv96EunRE/Pc3DM1WQmUNB/ItGoRJvxMbQJdGypBLh4Y1pD9CtAcJG+0ppgXMZaYCcyo\n\tpJtQ==","X-Gm-Message-State":"AHPjjUhHNQHPKQPEzMOnRsMdAAX3r92Kl9Uz+q5BfFpDtKPfPB01xBOa\n\tct1qldtitGXTBr8K1eGBrQGDOQ==","X-Google-Smtp-Source":"AOwi7QAQ4+M6mdFDpdv+DrhRjLZlPoXg+niDkoqCZTtj3f8jNq0Srv24b4sdw/kwsi5gdVbUAglWxQ==","X-Received":"by 10.99.104.6 with SMTP id d6mr82666pgc.168.1506484379705;\n\tTue, 26 Sep 2017 20:52:59 -0700 (PDT)","From":"Daniel Axtens ","To":"Bjorn Helgaas ","Cc":"linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org, benh@kernel.crashing.org,\n\tz.liuxinliang@hisilicon.com, zourongrong@gmail.com,\n\tcatalin.marinas@arm.com, will.deacon@arm.com,\n\tgabriele.paoloni@huawei.com, airlied@linux.ie,\n\tdaniel.vetter@intel.com, alex.williamson@redhat.com,\n\tdri-devel@lists.freedesktop.org, lukas@wunner.de,\n\tard.biesheuvel@linaro.org, lorenzo.pieralisi@arm.com","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","In-Reply-To":"<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>","Date":"Wed, 27 Sep 2017 13:52:55 +1000","Message-ID":"<87k20kyezs.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","Content-Type":"text/plain","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}},{"id":1781871,"web_url":"http://patchwork.ozlabs.org/comment/1781871/","msgid":"<20171006195118.GG25517@bhelgaas-glaptop.roam.corp.google.com>","list_archive_url":null,"date":"2017-10-06T19:51:18","subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","submitter":{"id":67298,"url":"http://patchwork.ozlabs.org/api/people/67298/","name":"Bjorn Helgaas","email":"helgaas@kernel.org"},"content":"On Wed, Sep 27, 2017 at 01:52:55PM +1000, Daniel Axtens wrote:\n> Hi Bjorn,\n> \n> Yes, this works:\n> \n> Tested-by: Daniel Axtens # arm64, ppc64-qemu-tcg\n\nI guess I was assuming you'd pick this up, but that doesn't really\nmake sense because I didn't give you a signed-off-by or anything.\nI'll post this with a changelog and signed-off-by so it doesn't get\nlost.\n\nI also noticed that I didn't correctly handle the powerpc quirk case\nwhere it doesn't require the device to be enabled at all. I'll try to\nfix that up, too.\n\nBjorn\n\n> > On Fri, Sep 01, 2017 at 05:27:41PM +1000, Daniel Axtens wrote:\n> >> This patch set:\n> >> \n> >> - splits the default display handling out from VGA arbiter, into its\n> >> own file and behind its own Kconfig option (and gives the functions\n> >> better names).\n> >> \n> >> - adds extra detection of default devices. To be nominated, the vga\n> >> arbiter and platform hooks must not have nominated a default. A\n> >> card will then only be nominated if it has a driver attached and\n> >> has IO or memory decoding enabled.\n> >> \n> >> - adds relevant documentation.\n> >> \n> >> The practical impact of this is improved X autoconfiguration on some\n> >> arm64 systems.\n> >\n> > I think I gave you bad advice about trying to separate the \"default\n> > device\" idea from the VGA arbiter.\n> >\n> > It is true that the \"VGA arbiter\" per se is related to routing the\n> > legacy VGA resources, and the arbiter currently only selects a default\n> > device if it finds a device to which those resources are routed.\n> >\n> > We have some cases where we want to select a default device that may\n> > not support the legacy VGA resources, or where they might not be\n> > routed to the device:\n> >\n> > - systems where we match the EFI framebuffer address with a BAR, and\n> > select that device as default,\n> >\n> > - powerpc systems where there may be no host bridge window that maps\n> > to the legacy VGA resources,\n> >\n> > - your ARM64 systems where the default device may be behind a bridge\n> > that doesn't support legacy VGA routing (PCI_BRIDGE_CTL_VGA)\n> >\n> > But I think trying to split the \"default device\" part out from the VGA\n> > arbiter ends up being overkill and making things more complicated\n> > instead of simpler.\n> >\n> > Would something like the following work for you as well as the powerpc\n> > case? On powerpc, we already use vga_set_default_device() to select a\n> > device that doesn't use legacy VGA resources, so maybe we can just do\n> > the same on ARM64?\n> >\n> > I suppose there might be wrinkles in how the arbiter deals with\n> > multiple graphics devices on those systems, since I don't think it\n> > identifies these devices that don't use the legacy resources, but it\n> > seems like we live with whatever those on are powerpc and probably can\n> > on ARM64 as well.\n> >\n> >\n> > diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c\n> > index 02831a396419..0ac7aa346c69 100644\n> > --- a/arch/powerpc/kernel/pci-common.c\n> > +++ b/arch/powerpc/kernel/pci-common.c\n> > @@ -1740,15 +1740,3 @@ static void fixup_hide_host_resource_fsl(struct pci_dev *dev)\n> > }\n> > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_MOTOROLA, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> > DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_FREESCALE, PCI_ANY_ID, fixup_hide_host_resource_fsl);\n> > -\n> > -static void fixup_vga(struct pci_dev *pdev)\n> > -{\n> > -\tu16 cmd;\n> > -\n> > -\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> > -\tif ((cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) || !vga_default_device())\n> > -\t\tvga_set_default_device(pdev);\n> > -\n> > -}\n> > -DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_ANY_ID, PCI_ANY_ID,\n> > -\t\t\t PCI_CLASS_DISPLAY_VGA, 8, fixup_vga);\n> > diff --git a/drivers/gpu/vga/vgaarb.c b/drivers/gpu/vga/vgaarb.c\n> > index 76875f6299b8..9df4802c5f04 100644\n> > --- a/drivers/gpu/vga/vgaarb.c\n> > +++ b/drivers/gpu/vga/vgaarb.c\n> > @@ -1468,6 +1468,21 @@ static int __init vga_arb_device_init(void)\n> > \t\t\tvgaarb_info(dev, \"no bridge control possible\\n\");\n> > \t}\n> > \n> > +\tif (!vga_default_device()) {\n> > +\t\tlist_for_each_entry(vgadev, &vga_list, list) {\n> > +\t\t\tstruct device *dev = &vgadev->pdev->dev;\n> > +\t\t\tu16 cmd;\n> > +\n> > +\t\t\tpdev = vgadev->pdev;\n> > +\t\t\tpci_read_config_word(pdev, PCI_COMMAND, &cmd);\n> > +\t\t\tif (cmd & (PCI_COMMAND_IO | PCI_COMMAND_MEMORY)) {\n> > +\t\t\t\tvgaarb_info(dev, \"setting as boot device\\n\");\n> > +\t\t\t\tvga_set_default_device(pdev);\n> > +\t\t\t\tbreak;\n> > +\t\t\t}\n> > +\t\t}\n> > +\t}\n> > +\n> > \tpr_info(\"loaded\\n\");\n> > \treturn rc;\n> > }\n> \n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-pci-owner@vger.kernel.org;\n\treceiver=)","mail.kernel.org;\n\tdmarc=none (p=none dis=none) header.from=kernel.org","mail.kernel.org;\n\tspf=none smtp.mailfrom=helgaas@kernel.org"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3y80d56drJz9t34\n\tfor ;\n\tSat, 7 Oct 2017 06:51:21 +1100 (AEDT)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752533AbdJFTvU (ORCPT );\n\tFri, 6 Oct 2017 15:51:20 -0400","from mail.kernel.org ([198.145.29.99]:34932 \"EHLO mail.kernel.org\"\n\trhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP\n\tid S1752390AbdJFTvU (ORCPT );\n\tFri, 6 Oct 2017 15:51:20 -0400","from localhost (unknown [69.55.156.165])\n\t(using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits))\n\t(No client certificate requested)\n\tby mail.kernel.org (Postfix) with ESMTPSA id 5782A217C5;\n\tFri, 6 Oct 2017 19:51:19 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mail.kernel.org 5782A217C5","Date":"Fri, 6 Oct 2017 14:51:18 -0500","From":"Bjorn Helgaas ","To":"Daniel Axtens ","Cc":"linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,\n\tlinux-arm-kernel@lists.infradead.org, benh@kernel.crashing.org,\n\tz.liuxinliang@hisilicon.com, zourongrong@gmail.com,\n\tcatalin.marinas@arm.com, will.deacon@arm.com,\n\tgabriele.paoloni@huawei.com, airlied@linux.ie,\n\tdaniel.vetter@intel.com, alex.williamson@redhat.com,\n\tdri-devel@lists.freedesktop.org, lukas@wunner.de,\n\tard.biesheuvel@linaro.org, lorenzo.pieralisi@arm.com","Subject":"Re: [PATCH v3 0/3] Split default display handling out from VGA\n\tarbiter","Message-ID":"<20171006195118.GG25517@bhelgaas-glaptop.roam.corp.google.com>","References":"<20170901072744.2409-1-dja@axtens.net>\n\t<20170925163948.GD15970@bhelgaas-glaptop.roam.corp.google.com>\n\t<87k20kyezs.fsf@linkitivity.dja.id.au>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<87k20kyezs.fsf@linkitivity.dja.id.au>","User-Agent":"Mutt/1.5.21 (2010-09-15)","Sender":"linux-pci-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-pci@vger.kernel.org"}}]