[{"id":1761398,"web_url":"http://patchwork.ozlabs.org/comment/1761398/","msgid":"<150422562278.204.10709806603962737796@b5667b65043c>","list_archive_url":null,"date":"2017-09-01T00:27:04","subject":"Re: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing","submitter":{"id":69632,"url":"http://patchwork.ozlabs.org/api/people/69632/","name":null,"email":"no-reply@patchew.org"},"content":"Hi,\n\nThis series seems to have some coding style problems. See output below for\nmore information:\n\nMessage-id: 20170901001502.29915-1-jsnow@redhat.com\nSubject: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing\nType: series\n\n=== TEST SCRIPT BEGIN ===\n#!/bin/bash\n\nBASE=base\nn=1\ntotal=$(git log --oneline $BASE.. | wc -l)\nfailed=0\n\ngit config --local diff.renamelimit 0\ngit config --local diff.renames True\n\ncommits=\"$(git log --format=%H --reverse $BASE..)\"\nfor c in $commits; do\n echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n failed=1\n echo\n fi\n n=$((n+1))\ndone\n\nexit $failed\n=== TEST SCRIPT END ===\n\nUpdating 3c8cf5a9c21ff8782164d1def7f44bd888713384\nFrom https://github.com/patchew-project/qemu\n t [tag update] patchew/1503938283-12404-1-git-send-email-sundeep.lkml@gmail.com -> patchew/1503938283-12404-1-git-send-email-sundeep.lkml@gmail.com\n t [tag update] patchew/1504190408-11143-1-git-send-email-thuth@redhat.com -> patchew/1504190408-11143-1-git-send-email-thuth@redhat.com\n * [new tag] patchew/20170901001502.29915-1-jsnow@redhat.com -> patchew/20170901001502.29915-1-jsnow@redhat.com\nSwitched to a new branch 'test'\nb45bc7135d AHCI: remove DPRINTF macro\n52a114ea94 AHCI: pretty-print FIS to buffer instead of stderr\ndc1fb9df07 AHCI: Rework IRQ constants\n01eb2629b7 AHCI: Replace DPRINTF with trace-events\nb64224c313 IDE: replace DEBUG_AIO with trace events\n0a54222e15 ATAPI: Replace DEBUG_IDE_ATAPI with tracing events\n1c976d454b IDE: add tracing for data ports\nb46b3c2141 IDE: Add register hints to tracing\n1da9fe67ec IDE: replace DEBUG_IDE with tracing system\n\n=== OUTPUT BEGIN ===\nChecking PATCH 1/9: IDE: replace DEBUG_IDE with tracing system...\nERROR: spaces required around that '|' (ctx:VxV)\n#143: FILE: hw/ide/core.c:1197:\n+ if (reg_num != 7 && (s->status & (BUSY_STAT|DRQ_STAT))) {\n ^\n\ntotal: 1 errors, 0 warnings, 337 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 2/9: IDE: Add register hints to tracing...\nChecking PATCH 3/9: IDE: add tracing for data ports...\nChecking PATCH 4/9: ATAPI: Replace DEBUG_IDE_ATAPI with tracing events...\nChecking PATCH 5/9: IDE: replace DEBUG_AIO with trace events...\nChecking PATCH 6/9: AHCI: Replace DPRINTF with trace-events...\nERROR: Hex numbers must be prefixed with '0x'\n#544: FILE: hw/ide/trace-events:91:\n+handle_reg_h2d_fis_pmp(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Port Multiplier not supported, FIS: 0x%02x-%02x-%02x\"\n\nERROR: Hex numbers must be prefixed with '0x'\n#545: FILE: hw/ide/trace-events:92:\n+handle_reg_h2d_fis_res(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Reserved flags set in H2D Register FIS, FIS: 0x%02x-%02x-%02x\"\n\nERROR: Hex numbers must be prefixed with '0x'\n#551: FILE: hw/ide/trace-events:98:\n+handle_cmd_unhandled_fis(void *s, int port, uint8_t b0, uint8_t b1, uint8_t b2) \"ahci(%p)[%d]: unhandled FIS type. cmd_fis: 0x%02x-%02x-%02x\"\n\ntotal: 3 errors, 0 warnings, 496 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\n\nChecking PATCH 7/9: AHCI: Rework IRQ constants...\nChecking PATCH 8/9: AHCI: pretty-print FIS to buffer instead of stderr...\nWARNING: line over 80 characters\n#52: FILE: hw/ide/ahci.c:1206:\n+ char *pretty_fis = ahci_pretty_buffer_fis(ide_state->io_buffer, 0x10);\n\ntotal: 0 errors, 1 warnings, 60 lines checked\n\nYour patch has style problems, please review. If any of these errors\nare false positives report them to the maintainer, see\nCHECKPATCH in MAINTAINERS.\nChecking PATCH 9/9: AHCI: remove DPRINTF macro...\n=== OUTPUT END ===\n\nTest command exited with code: 1\n\n\n---\nEmail generated automatically by Patchew [http://patchew.org/].\nPlease send your feedback to patchew-devel@freelists.org","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk0Sl2MDJz9s81\n\tfor ;\n\tFri, 1 Sep 2017 10:27:50 +1000 (AEST)","from localhost ([::1]:35085 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnZoJ-0000R0-RV\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 20:27:47 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54301)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnZnu-0000Pj-J8\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 20:27:24 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnZnr-0001Bf-CB\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 20:27:22 -0400","from sender-of-o52.zoho.com ([135.84.80.217]:21312)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnZnr-00019I-5V; Thu, 31 Aug 2017 20:27:19 -0400","from [172.17.0.2] (23.253.156.214 [23.253.156.214]) by\n\tmx.zohomail.com with SMTPS id 1504225624835915.9828615117933;\n\tThu, 31 Aug 2017 17:27:04 -0700 (PDT)"],"Resent-Date":"Thu, 31 Aug 2017 20:27:22 -0400","Resent-Message-Id":"","In-Reply-To":"<20170901001502.29915-1-jsnow@redhat.com>","Message-ID":"<150422562278.204.10709806603962737796@b5667b65043c>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Resent-From":"","From":"no-reply@patchew.org","To":"jsnow@redhat.com","Date":"Thu, 31 Aug 2017 17:27:04 -0700 (PDT)","X-ZohoMailClient":"External","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 3.x [fuzzy]","X-Received-From":"135.84.80.217","Subject":"Re: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"qemu-devel@nongnu.org","Cc":"famz@redhat.com, qemu-block@nongnu.org, qemu-devel@nongnu.org,\n\tf4bug@amsat.org, stefanha@redhat.com, jsnow@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761410,"web_url":"http://patchwork.ozlabs.org/comment/1761410/","msgid":"<431cc1c3-adaf-0159-93f4-d5ed76aea4b3@redhat.com>","list_archive_url":null,"date":"2017-09-01T00:37:57","subject":"Re: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 08/31/2017 08:27 PM, no-reply@patchew.org wrote:\n> Hi,\n> \n> This series seems to have some coding style problems. See output below for\n> more information:\n> \n> Message-id: 20170901001502.29915-1-jsnow@redhat.com\n> Subject: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing\n> Type: series\n> \n> === TEST SCRIPT BEGIN ===\n> #!/bin/bash\n> \n> BASE=base\n> n=1\n> total=$(git log --oneline $BASE.. | wc -l)\n> failed=0\n> \n> git config --local diff.renamelimit 0\n> git config --local diff.renames True\n> \n> commits=\"$(git log --format=%H --reverse $BASE..)\"\n> for c in $commits; do\n> echo \"Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)...\"\n> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then\n> failed=1\n> echo\n> fi\n> n=$((n+1))\n> done\n> \n> exit $failed\n> === TEST SCRIPT END ===\n> \n> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384\n> From https://github.com/patchew-project/qemu\n> t [tag update] patchew/1503938283-12404-1-git-send-email-sundeep.lkml@gmail.com -> patchew/1503938283-12404-1-git-send-email-sundeep.lkml@gmail.com\n> t [tag update] patchew/1504190408-11143-1-git-send-email-thuth@redhat.com -> patchew/1504190408-11143-1-git-send-email-thuth@redhat.com\n> * [new tag] patchew/20170901001502.29915-1-jsnow@redhat.com -> patchew/20170901001502.29915-1-jsnow@redhat.com\n> Switched to a new branch 'test'\n> b45bc7135d AHCI: remove DPRINTF macro\n> 52a114ea94 AHCI: pretty-print FIS to buffer instead of stderr\n> dc1fb9df07 AHCI: Rework IRQ constants\n> 01eb2629b7 AHCI: Replace DPRINTF with trace-events\n> b64224c313 IDE: replace DEBUG_AIO with trace events\n> 0a54222e15 ATAPI: Replace DEBUG_IDE_ATAPI with tracing events\n> 1c976d454b IDE: add tracing for data ports\n> b46b3c2141 IDE: Add register hints to tracing\n> 1da9fe67ec IDE: replace DEBUG_IDE with tracing system\n> \n> === OUTPUT BEGIN ===\n> Checking PATCH 1/9: IDE: replace DEBUG_IDE with tracing system...\n> ERROR: spaces required around that '|' (ctx:VxV)\n> #143: FILE: hw/ide/core.c:1197:\n> + if (reg_num != 7 && (s->status & (BUSY_STAT|DRQ_STAT))) {\n\nExisting damage, but I suppose I'll fix it since I'm here.\n\n> ^\n> \n> total: 1 errors, 0 warnings, 337 lines checked\n> \n> Your patch has style problems, please review. If any of these errors\n> are false positives report them to the maintainer, see\n> CHECKPATCH in MAINTAINERS.\n> \n> Checking PATCH 2/9: IDE: Add register hints to tracing...\n> Checking PATCH 3/9: IDE: add tracing for data ports...\n> Checking PATCH 4/9: ATAPI: Replace DEBUG_IDE_ATAPI with tracing events...\n> Checking PATCH 5/9: IDE: replace DEBUG_AIO with trace events...\n> Checking PATCH 6/9: AHCI: Replace DPRINTF with trace-events...\n> ERROR: Hex numbers must be prefixed with '0x'\n> #544: FILE: hw/ide/trace-events:91:\n> +handle_reg_h2d_fis_pmp(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Port Multiplier not supported, FIS: 0x%02x-%02x-%02x\"\n> \n\nFalse positive, it's part of a hex sequence so the context is obvious.\n\n> ERROR: Hex numbers must be prefixed with '0x'\n> #545: FILE: hw/ide/trace-events:92:\n> +handle_reg_h2d_fis_res(void *s, int port, char b0, char b1, char b2) \"ahci(%p)[%d]: Reserved flags set in H2D Register FIS, FIS: 0x%02x-%02x-%02x\"\n> \n\nSame\n\n> ERROR: Hex numbers must be prefixed with '0x'\n> #551: FILE: hw/ide/trace-events:98:\n> +handle_cmd_unhandled_fis(void *s, int port, uint8_t b0, uint8_t b1, uint8_t b2) \"ahci(%p)[%d]: unhandled FIS type. cmd_fis: 0x%02x-%02x-%02x\"\n> \n\nSame\n\n> total: 3 errors, 0 warnings, 496 lines checked\n> \n> Your patch has style problems, please review. If any of these errors\n> are false positives report them to the maintainer, see\n> CHECKPATCH in MAINTAINERS.\n> \n> Checking PATCH 7/9: AHCI: Rework IRQ constants...\n> Checking PATCH 8/9: AHCI: pretty-print FIS to buffer instead of stderr...\n> WARNING: line over 80 characters\n> #52: FILE: hw/ide/ahci.c:1206:\n> + char *pretty_fis = ahci_pretty_buffer_fis(ide_state->io_buffer, 0x10);\n> \n\nWill adjust.\n\n> total: 0 errors, 1 warnings, 60 lines checked\n> \n> Your patch has style problems, please review. If any of these errors\n> are false positives report them to the maintainer, see\n> CHECKPATCH in MAINTAINERS.\n> Checking PATCH 9/9: AHCI: remove DPRINTF macro...\n> === OUTPUT END ===\n> \n> Test command exited with code: 1\n> \n> \n> ---\n> Email generated automatically by Patchew [http://patchew.org/].\n> Please send your feedback to patchew-devel@freelists.org\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx01.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xk0jC55SDz9s8J\n\tfor ;\n\tFri, 1 Sep 2017 10:38:38 +1000 (AEST)","from localhost ([::1]:35531 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnZym-0004Ok-1Q\n\tfor incoming@patchwork.ozlabs.org; Thu, 31 Aug 2017 20:38:36 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:55778)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnZyN-0004MC-1h\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 20:38:12 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnZyL-0006IX-Pk\n\tfor qemu-devel@nongnu.org; Thu, 31 Aug 2017 20:38:11 -0400","from mx1.redhat.com ([209.132.183.28]:37306)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnZyG-0006FL-6G; Thu, 31 Aug 2017 20:38:04 -0400","from smtp.corp.redhat.com\n\t(int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 457CE7F3E2;\n\tFri, 1 Sep 2017 00:38:02 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id BFEC89ECFF;\n\tFri, 1 Sep 2017 00:37:57 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 457CE7F3E2","To":"qemu-devel@nongnu.org","References":"<150422562278.204.10709806603962737796@b5667b65043c>","From":"John Snow ","Message-ID":"<431cc1c3-adaf-0159-93f4-d5ed76aea4b3@redhat.com>","Date":"Thu, 31 Aug 2017 20:37:57 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<150422562278.204.10709806603962737796@b5667b65043c>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.16","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.25]);\n\tFri, 01 Sep 2017 00:38:02 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [PATCH v3 0/9] IDE: replace printfs with tracing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"famz@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org,\n\tf4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761589,"web_url":"http://patchwork.ozlabs.org/comment/1761589/","msgid":"<20170901105654.GA20672@stefanha-x1.localdomain>","list_archive_url":null,"date":"2017-09-01T10:56:54","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/9] IDE: replace printfs\n\twith tracing","submitter":{"id":2747,"url":"http://patchwork.ozlabs.org/api/people/2747/","name":"Stefan Hajnoczi","email":"stefanha@gmail.com"},"content":"On Thu, Aug 31, 2017 at 08:14:53PM -0400, John Snow wrote:\n> Wherever possible, replace all printfs with proper tracing.\n> In most places I've tried to do a straight replacement, but\n> forthcoming patches may calibrate the tracing to be a little nicer.\n> \n> For now, it's nice to just remove the all-or-nothing tracing.\n> \n> Key:\n> [----] : patches are identical\n> [####] : number of functional differences between upstream/downstream patch\n> [down] : patch is downstream-only\n> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively\n> \n> 001/9:[----] [--] 'IDE: replace DEBUG_IDE with tracing system'\n> 002/9:[----] [--] 'IDE: Add register hints to tracing'\n> 003/9:[----] [--] 'IDE: add tracing for data ports'\n> 004/9:[0002] [FC] 'ATAPI: Replace DEBUG_IDE_ATAPI with tracing events'\n> 005/9:[0011] [FC] 'IDE: replace DEBUG_AIO with trace events'\n> 006/9:[----] [--] 'AHCI: Replace DPRINTF with trace-events'\n> 007/9:[0004] [FC] 'AHCI: Rework IRQ constants'\n> 008/9:[0052] [FC] 'AHCI: pretty-print FIS to buffer instead of stderr'\n> 009/9:[----] [--] 'AHCI: remove DPRINTF macro'\n> \n> ===\n> v3:\n> ===\n> \n> 04: Change preprocessor gate mechanism for building cmd\n> packet buffer dumps (Stefan)\n> 05: Add getter for IDE_DMA_CMD enumeration (Philippe)\n> 07: Changed AHCI enumeration to match changes in 05,\n> (But leave assert in place to guard lookup table instead\n> of adding getter.)\n> 08: Replace FIS buffer printer with something simpler (Stefan)\n> Change preprocessor gate mechanism for building AHCI buffer dumps (Stefan)\n> enconstify char parameters in trace-events file (Stefan)\n> \n> ===\n> v2:\n> ===\n> \n> 01: Rehabilitate commit message.\n> Fix switch () statement spacing. (Eric)\n> Adjust spacing in ide-tracing file to maintain columns.\n> Change filename orderings in trace-events. (Eric)\n> Fixed newline issue in trace-events. (Eric)\n> \n> 02: Context / Added R-B.\n> \n> 03: Added trace-events items to appropriate patch (removed from 04) (Eric)\n> Added a verbose warning for data tracers (Eric)\n> \n> 04: Shifted items to 03 (Eric)\n> Fixed newline issue (Eric)\n> \n> 05: Changed __END to __COUNT (Philippe)\n> Removed __BEGIN enumerator (Philippe)\n> \n> 06: Added more information to unknown write (Philippe)\n> \n> 08: Context (Entropy)\n> \n> John Snow (9):\n> IDE: replace DEBUG_IDE with tracing system\n> IDE: Add register hints to tracing\n> IDE: add tracing for data ports\n> ATAPI: Replace DEBUG_IDE_ATAPI with tracing events\n> IDE: replace DEBUG_AIO with trace events\n> AHCI: Replace DPRINTF with trace-events\n> AHCI: Rework IRQ constants\n> AHCI: pretty-print FIS to buffer instead of stderr\n> AHCI: remove DPRINTF macro\n> \n> Makefile.objs | 1 +\n> hw/ide/ahci.c | 243 +++++++++++++++++++++++-----------------------\n> hw/ide/ahci_internal.h | 44 +++++++--\n> hw/ide/atapi.c | 69 +++++--------\n> hw/ide/cmd646.c | 10 +-\n> hw/ide/core.c | 185 ++++++++++++++++++++++-------------\n> hw/ide/pci.c | 17 +---\n> hw/ide/piix.c | 11 +--\n> hw/ide/trace-events | 111 +++++++++++++++++++++\n> hw/ide/via.c | 10 +-\n> include/hw/ide/internal.h | 8 +-\n> 11 files changed, 437 insertions(+), 272 deletions(-)\n> create mode 100644 hw/ide/trace-events\n> \n> -- \n> 2.9.5\n> \n> \n\nReviewed-by: Stefan Hajnoczi ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"g6wzeW/b\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkGSX1kb1z9rxl\n\tfor ;\n\tFri, 1 Sep 2017 20:58:36 +1000 (AEST)","from localhost ([::1]:35113 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnjek-0008DO-DS\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 06:58:34 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:50891)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnjdR-0007fC-26\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 06:57:17 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnjdM-0000kT-97\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 06:57:13 -0400","from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:38732)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnjdD-0000hw-P6; Fri, 01 Sep 2017 06:56:59 -0400","by mail-wm0-x242.google.com with SMTP id u26so2109701wma.5;\n\tFri, 01 Sep 2017 03:56:58 -0700 (PDT)","from localhost ([51.15.41.238]) by smtp.gmail.com with ESMTPSA id\n\tg45sm404242eda.21.2017.09.01.03.56.55\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 01 Sep 2017 03:56:55 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:in-reply-to:user-agent;\n\tbh=vVI5xndHzYiUiZ1E4FAi2mPhlh6/1q7cpYYIz2uO1qQ=;\n\tb=g6wzeW/bHWR4DmfEvD8TL87oGyf81IGZYkN5/CBcQ3tupZk+VkxlUfsWlbDNkwydd9\n\tcIDGtT2GO614EzgDCuPcOsDUKBESYvTtJHB5iXTsnvSPU0UPl/grw8BdxSTvToU21hny\n\tNkEp00ypaZsxMXKNN8owd00slkr9Bx1Voum6W2FbbtWJJ2SAGPj7X1heR/DNJW2CNK2b\n\tMYHbvWlcImbggF4E5ew1NsEjjhKsVysZmr4qGGh56KLATbRlgRVIFhRnOnwBH/cqNJzI\n\tqqO52gc9r2MaCqDoNFAacc8z4AF7BGVKdN1umqBP7fSNaGweo6BBqTPL+USw2iaAlY7b\n\tJNOw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=vVI5xndHzYiUiZ1E4FAi2mPhlh6/1q7cpYYIz2uO1qQ=;\n\tb=avt0dFbfbGMt8zRnBDkMvRypIhxGSnFKy6uZ9uzaFcNVe5xUMu/BPXj6TCLPXn+G/A\n\tC2luE0QdE4nx+ttJFc1y5wY7njjCdgr/fHEDmxhS75o7rTHBt3DmQhQ+6Zo0N4NjKXYu\n\t9C8v/wEFh+hzk9/aptRBJHEIpjZzDOzIHSBUTosv4/0lCpnmgazVrvXy/3Vu4fLJHl2F\n\trhw7zYPpb2UjakJADSTyBDqafnZn3z/cu+7TNJnd9M+ddgrANCYKy+UDedexVXRzE+2Z\n\tbxXLh0BEEFSS8HsX4n8wHTrYAofyNCubpZvHeGI6JVUfLf1a5n2tLcc0XAMwWxfTtV7f\n\tm7nQ==","X-Gm-Message-State":"AHPjjUikYZpkMoUY6DnmmgxICQUrda6DxOWGvvXR+Hb9LddPs9NDr0pQ\n\tLC8R6lcZ+4pExEaCtEg=","X-Google-Smtp-Source":"ADKCNb7C+x8T6l4/Zc9mJeswVN0Ti2uespJ4fgandH+/n4fZYZb6H1R3Ppp431C3KB0Bv8z3Ortu5w==","X-Received":"by 10.80.164.30 with SMTP id u30mr1377240edb.246.1504263417155; \n\tFri, 01 Sep 2017 03:56:57 -0700 (PDT)","Date":"Fri, 1 Sep 2017 11:56:54 +0100","From":"Stefan Hajnoczi ","To":"John Snow ","Message-ID":"<20170901105654.GA20672@stefanha-x1.localdomain>","References":"<20170901001502.29915-1-jsnow@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20170901001502.29915-1-jsnow@redhat.com>","User-Agent":"Mutt/1.8.3 (2017-05-23)","X-detected-operating-system":"by eggs.gnu.org: Genre and OS details not\n\trecognized.","X-Received-From":"2a00:1450:400c:c09::242","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/9] IDE: replace printfs\n\twith tracing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"stefanha@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,\n\tf4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}},{"id":1761919,"web_url":"http://patchwork.ozlabs.org/comment/1761919/","msgid":"<105ec27c-63e1-cbac-1bca-da9b2685fe8b@redhat.com>","list_archive_url":null,"date":"2017-09-01T18:57:49","subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/9] IDE: replace printfs\n\twith tracing","submitter":{"id":64343,"url":"http://patchwork.ozlabs.org/api/people/64343/","name":"John Snow","email":"jsnow@redhat.com"},"content":"On 09/01/2017 06:56 AM, Stefan Hajnoczi wrote:\n> On Thu, Aug 31, 2017 at 08:14:53PM -0400, John Snow wrote:\n>> Wherever possible, replace all printfs with proper tracing.\n>> In most places I've tried to do a straight replacement, but\n>> forthcoming patches may calibrate the tracing to be a little nicer.\n>>\n>> For now, it's nice to just remove the all-or-nothing tracing.\n>>\n>> Key:\n>> [----] : patches are identical\n>> [####] : number of functional differences between upstream/downstream patch\n>> [down] : patch is downstream-only\n>> The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively\n>>\n>> 001/9:[----] [--] 'IDE: replace DEBUG_IDE with tracing system'\n>> 002/9:[----] [--] 'IDE: Add register hints to tracing'\n>> 003/9:[----] [--] 'IDE: add tracing for data ports'\n>> 004/9:[0002] [FC] 'ATAPI: Replace DEBUG_IDE_ATAPI with tracing events'\n>> 005/9:[0011] [FC] 'IDE: replace DEBUG_AIO with trace events'\n>> 006/9:[----] [--] 'AHCI: Replace DPRINTF with trace-events'\n>> 007/9:[0004] [FC] 'AHCI: Rework IRQ constants'\n>> 008/9:[0052] [FC] 'AHCI: pretty-print FIS to buffer instead of stderr'\n>> 009/9:[----] [--] 'AHCI: remove DPRINTF macro'\n>>\n>> ===\n>> v3:\n>> ===\n>>\n>> 04: Change preprocessor gate mechanism for building cmd\n>> packet buffer dumps (Stefan)\n>> 05: Add getter for IDE_DMA_CMD enumeration (Philippe)\n>> 07: Changed AHCI enumeration to match changes in 05,\n>> (But leave assert in place to guard lookup table instead\n>> of adding getter.)\n>> 08: Replace FIS buffer printer with something simpler (Stefan)\n>> Change preprocessor gate mechanism for building AHCI buffer dumps (Stefan)\n>> enconstify char parameters in trace-events file (Stefan)\n>>\n>> ===\n>> v2:\n>> ===\n>>\n>> 01: Rehabilitate commit message.\n>> Fix switch () statement spacing. (Eric)\n>> Adjust spacing in ide-tracing file to maintain columns.\n>> Change filename orderings in trace-events. (Eric)\n>> Fixed newline issue in trace-events. (Eric)\n>>\n>> 02: Context / Added R-B.\n>>\n>> 03: Added trace-events items to appropriate patch (removed from 04) (Eric)\n>> Added a verbose warning for data tracers (Eric)\n>>\n>> 04: Shifted items to 03 (Eric)\n>> Fixed newline issue (Eric)\n>>\n>> 05: Changed __END to __COUNT (Philippe)\n>> Removed __BEGIN enumerator (Philippe)\n>>\n>> 06: Added more information to unknown write (Philippe)\n>>\n>> 08: Context (Entropy)\n>>\n>> John Snow (9):\n>> IDE: replace DEBUG_IDE with tracing system\n>> IDE: Add register hints to tracing\n>> IDE: add tracing for data ports\n>> ATAPI: Replace DEBUG_IDE_ATAPI with tracing events\n>> IDE: replace DEBUG_AIO with trace events\n>> AHCI: Replace DPRINTF with trace-events\n>> AHCI: Rework IRQ constants\n>> AHCI: pretty-print FIS to buffer instead of stderr\n>> AHCI: remove DPRINTF macro\n>>\n>> Makefile.objs | 1 +\n>> hw/ide/ahci.c | 243 +++++++++++++++++++++++-----------------------\n>> hw/ide/ahci_internal.h | 44 +++++++--\n>> hw/ide/atapi.c | 69 +++++--------\n>> hw/ide/cmd646.c | 10 +-\n>> hw/ide/core.c | 185 ++++++++++++++++++++++-------------\n>> hw/ide/pci.c | 17 +---\n>> hw/ide/piix.c | 11 +--\n>> hw/ide/trace-events | 111 +++++++++++++++++++++\n>> hw/ide/via.c | 10 +-\n>> include/hw/ide/internal.h | 8 +-\n>> 11 files changed, 437 insertions(+), 272 deletions(-)\n>> create mode 100644 hw/ide/trace-events\n>>\n>> -- \n>> 2.9.5\n>>\n>>\n> \n> Reviewed-by: Stefan Hajnoczi \n> \n\nThank you Philippe, Eric, and Stefan.\n\nThanks, applied to my IDE tree:\n\nhttps://github.com/jnsnow/qemu/commits/ide\nhttps://github.com/jnsnow/qemu.git\n\n--js","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx03.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=jsnow@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xkT6Q54T4z9sQl\n\tfor ;\n\tSat, 2 Sep 2017 04:58:37 +1000 (AEST)","from localhost ([::1]:55415 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dnr9H-0002Mh-0T\n\tfor incoming@patchwork.ozlabs.org; Fri, 01 Sep 2017 14:58:35 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:54746)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dnr8l-0002KP-28\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:58:08 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dnr8j-0001bT-Ql\n\tfor qemu-devel@nongnu.org; Fri, 01 Sep 2017 14:58:03 -0400","from mx1.redhat.com ([209.132.183.28]:52630)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dnr8c-0001YP-O5; Fri, 01 Sep 2017 14:57:54 -0400","from smtp.corp.redhat.com\n\t(int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 570E17E43A;\n\tFri, 1 Sep 2017 18:57:53 +0000 (UTC)","from [10.18.17.130] (dhcp-17-130.bos.redhat.com [10.18.17.130])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 0701A179E5;\n\tFri, 1 Sep 2017 18:57:49 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 570E17E43A","To":"Stefan Hajnoczi ","References":"<20170901001502.29915-1-jsnow@redhat.com>\n\t<20170901105654.GA20672@stefanha-x1.localdomain>","From":"John Snow ","Message-ID":"<105ec27c-63e1-cbac-1bca-da9b2685fe8b@redhat.com>","Date":"Fri, 1 Sep 2017 14:57:49 -0400","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101\n\tThunderbird/52.2.1","MIME-Version":"1.0","In-Reply-To":"<20170901105654.GA20672@stefanha-x1.localdomain>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-US","Content-Transfer-Encoding":"7bit","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.14","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]);\n\tFri, 01 Sep 2017 18:57:53 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"Re: [Qemu-devel] [Qemu-block] [PATCH v3 0/9] IDE: replace printfs\n\twith tracing","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com,\n\tf4bug@amsat.org","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"}}]