[{"id":1762610,"web_url":"http://patchwork.ozlabs.org/comment/1762610/","msgid":"","list_archive_url":null,"date":"2017-09-04T12:55:39","subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-09-01 8:20 GMT+09:00 Keiji Hayashibara :\n> Add uniphier-efuse dt-bindings documentation.\n>\n> Signed-off-by: Keiji Hayashibara \n> ---\n> .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45 ++++++++++++++++++++++\n> 1 file changed, 45 insertions(+)\n> create mode 100644 Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n>\n> diff --git a/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> new file mode 100644\n> index 0000000..09024a2\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> @@ -0,0 +1,45 @@\n> += UniPhier eFuse device tree bindings =\n> +\n> +This UniPhier eFuse must be under soc-glue.\n> +\n> +Required properties:\n> +- compatible: should be \"socionext,uniphier-efuse\"\n> +- reg: should contain the register base and length\n> +\n> += Data cells =\n> +Are child nodes of efuse, bindings of which as described in\n> +bindings/nvmem/nvmem.txt\n> +\n> +Example:\n> +\n> + soc-glue@5f900000 {\n> + compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n> + \"simple-mfd\";\n> + #address-cells = <1>;\n> + #size-cells = <1>;\n> + ranges = <0x0 0x5f900000 0x2000>;\n\n\nIMHO, I think an empty \"ranges;\" will clarify the code,\nbut it is up to your taste.\n\n\n> +\n> + efuse {\n> + compatible = \"socionext,uniphier-efuse\",\n> + \"syscon\";\n\n\nYou are adding a dedicated driver for \"socionext,uniphier-efuse\".\n\nThen, \"syscon\" as well?\n\n\n\n\n> + reg = <0x100 0xf00>;\n\n\nNot so many efuse registers exist on the SoC.\n\nreg = <0x100 0x200>; will be enough.\n\n\nOr if you want to be strict to the hw spec, you can write as follows:\n\n soc-glue@5f900000 {\n compatible = \"socionext,uniphier-ld20-soc-glue-debug\";\n \"simple-mfd\";\n #address-cells = <1>;\n #size-cells = <1>;\n ranges = <0x0 0x5f900000 0x2000>;\n\n efuse@100 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x100 0x28>;\n };\n\n efuse@200 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x200 0x68>;\n };\n };\n\n\n\n\n> + #address-cells = <1>;\n> + #size-cells = <1>;\n> +\n> + /* Data cells */\n> + usb_mon: usb_mon {\n> + reg = <0x154 0xc>;\n> + };\n\n\nThis <0x154 0xc> represents 0x5f900254 in CPU address view.\n(0x5f900000 + 0x100 + 0x154)\n\nSo many ranges conversion, and how error-prone..\n\n\n\n\n\n> + };\n> +\n> += Data consumers =\n> +Are device nodes which consume nvmem data cells.\n> +\n> +Example:\n> +\n> + usb {\n> + ...\n> + nvmem-cells = <&usb_mon>;\n> + nvmem-cell-names = \"usb_mon\";\n> + }\n> --\n> 2.7.4\n>\n> --\n> To unsubscribe from this list: send the line \"unsubscribe devicetree\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at http://vger.kernel.org/majordomo-info.html","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"g6Xi2ull\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"aqaMYLcH\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm8xw6sdbz9sNr\n\tfor ;\n\tMon, 4 Sep 2017 22:57:08 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doqw6-0003IZ-0W; Mon, 04 Sep 2017 12:57:06 +0000","from conssluserg-06.nifty.com ([210.131.2.91])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doqw0-00039f-Df for linux-arm-kernel@lists.infradead.org;\n\tMon, 04 Sep 2017 12:57:04 +0000","from mail-yw0-f180.google.com (mail-yw0-f180.google.com\n\t[209.85.161.180]) (authenticated)\n\tby conssluserg-06.nifty.com with ESMTP id v84CuKWo030573\n\tfor ;\n\tMon, 4 Sep 2017 21:56:21 +0900","by mail-yw0-f180.google.com with SMTP id i66so1796705ywc.0\n\tfor ;\n\tMon, 04 Sep 2017 05:56:21 -0700 (PDT)","by 10.37.164.225 with HTTP; Mon, 4 Sep 2017 05:55:39 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Urwlc2zy9bOYLIRXzlAFyI43fTZONcBQKrmnO1YWVP8=;\n\tb=g6Xi2ullt+cwPe\n\tVkv4TVzYmgsXV5BL64VN5zc12/GDZlW/V9oWafFamh7dlmt+J499mseZV+e9s1++FYmrv+XOi1DHI\n\tC8wXpWuZeJk4PeIOC3hX+8m+1DFU3Vc40yeiVDpVrG/zKC6OEgBdK6OjWnj6HjlJnj7Qurqxj8S3P\n\tLM9ZsRZoauaWIKNWkd2IH52mfA27nQzKb+smd04KPv4LoN4B1XYOtuy9P4rOTEclBjCy6UP/SVP1R\n\tsGqhpOKW1GjN+6XbK40pdqWTcC1svHUkYRvES1XynXuocSfxcCawkJUJ/SMhK17D//2BWJjhSNMDB\n\tqHYDoVqzSSGA0nZ/gTJw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1504529781;\n\tbh=zf/1SA8JJAOcer7KDUvLvx7d1sa2pEV8zkawZUkMTJY=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=aqaMYLcHpacVgucIJuUChMklejkQG9zhzRNfC7f1Z55+TXgn4ULkeXH1gbj7ezCUe\n\tkiwUix/lu0slqVWXB9JFTcRyj3hX7ZAuA644Py5DRbp1i9aAsR2sc4197WHj2hx+zt\n\tBk2zwkeaBr/s5mgIzEBFLH0o2sgJXXMVjkho5ultNN5Aru/YUMPsBBRB+oSD1+WbmR\n\tmB5NZ2IVIyHEr5YUhiCN1YVGe8Wx1QSbDhwpbIp9A5IYr78QbS4AJcJjD3x9IP3zqo\n\tY4e2ZHnrjcAQ9jZ8oaW40fkwUamnk2E37DWFyYxscMUYj0CiY/oBlDbaCusMPBtFXq\n\tr6ehCqva10ziw=="],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-06.nifty.com v84CuKWo030573","X-Nifty-SrcIP":"[209.85.161.180]","X-Gm-Message-State":"AHPjjUj9aS3RpGEIls0zizcSLbHnYrqoQAxdwJ1T+5AUQofLsrKu8Yia\n\tNlMIu4y28xLRUq5U6JtNutLkNCFlgw==","X-Google-Smtp-Source":"ADKCNb5PMuVhdiWfEEYuOZh8xOgjTIdYj/wcM+OKZzZ8Xg7+RSaZnVJI3+/UXp8kO/hTMuNLahwzZn1cFqiTNT3vS+I=","X-Received":"by 10.37.80.213 with SMTP id e204mr435834ybb.215.1504529780115; \n\tMon, 04 Sep 2017 05:56:20 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>","From":"Masahiro Yamada ","Date":"Mon, 4 Sep 2017 21:55:39 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","To":"Keiji Hayashibara ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170904_055700_710249_61283877 ","X-CRM114-Status":"GOOD ( 17.46 )","X-Spam-Score":"-0.7 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source\n\t[209.85.161.180 listed in dnsbl.sorbs.net]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Kiyoshi Owada , \n\tKunihiko Hayashi ,\n\tMasami Hiramatsu ,\n\tLinux Kernel Mailing List ,\n\tJassi Brar ,\n\tRob Herring , \n\tSrinivas Kandagatla ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1762616,"web_url":"http://patchwork.ozlabs.org/comment/1762616/","msgid":"","list_archive_url":null,"date":"2017-09-04T12:58:03","subject":"Re: [PATCH v1 2/3] nvmem: uniphier: add UniPhier eFuse driver","submitter":{"id":65882,"url":"http://patchwork.ozlabs.org/api/people/65882/","name":"Masahiro Yamada","email":"yamada.masahiro@socionext.com"},"content":"2017-09-01 8:20 GMT+09:00 Keiji Hayashibara :\n> Add eFuse driver for Socionext UniPhier series SoC.\n> Note that eFuse device is under soc-glue and this register\n> implements as read only.\n>\n> Signed-off-by: Keiji Hayashibara \n> ---\n> arch/arm64/configs/defconfig | 1 +\n> drivers/nvmem/Kconfig | 11 +++++\n> drivers/nvmem/Makefile | 2 +\n> drivers/nvmem/uniphier-efuse.c | 98 ++++++++++++++++++++++++++++++++++++++++++\n> 4 files changed, 112 insertions(+)\n> create mode 100644 drivers/nvmem/uniphier-efuse.c\n>\n> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig\n> index 6c7d147..5c38b4a 100644\n> --- a/arch/arm64/configs/defconfig\n> +++ b/arch/arm64/configs/defconfig\n> @@ -514,6 +514,7 @@ CONFIG_PHY_XGENE=y\n> CONFIG_PHY_TEGRA_XUSB=y\n> CONFIG_QCOM_L2_PMU=y\n> CONFIG_QCOM_L3_PMU=y\n> +CONFIG_UNIPHIER_EFUSE=y\n> CONFIG_ARM_SCPI_PROTOCOL=y\n> CONFIG_RASPBERRYPI_FIRMWARE=y\n> CONFIG_EFI_CAPSULE_LOADER=y\n\n\nYou need to send this separately\n(after this driver is accepted)\n\n\n\n> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig\n> index 101ced4..aaeaebe 100644\n> --- a/drivers/nvmem/Kconfig\n> +++ b/drivers/nvmem/Kconfig\n> @@ -123,6 +123,17 @@ config NVMEM_SUNXI_SID\n> This driver can also be built as a module. If so, the module\n> will be called nvmem_sunxi_sid.\n>\n> +config UNIPHIER_EFUSE\n> + tristate \"UniPhier SoCs eFuse support\"\n> + depends on ARCH_UNIPHIER || COMPILE_TEST\n> + depends on OF && MFD_SYSCON\n> + help\n> + This is a simple drive to dump specified values of UniPhier SoC\n> + from eFuse.\n\n\ns/drive/driver/\n\n\nI see the same typo in ROCKCHIP_EFUSE.\n\nYou copied it verbatim.\n\n\n\n\n> + This driver can also be built as a module. If so, the module\n> + will be called nvmem_uniphier-efuse.\n\n\nI do not like a mixture of '_' and '-' though...\n\n\n\n\n\n> config NVMEM_VF610_OCOTP\n> tristate \"VF610 SoC OCOTP support\"\n> depends on SOC_VF610 || COMPILE_TEST\n> diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile\n> index 1731406..f5277c3 100644\n> --- a/drivers/nvmem/Makefile\n> +++ b/drivers/nvmem/Makefile\n> @@ -26,6 +26,8 @@ obj-$(CONFIG_ROCKCHIP_EFUSE) += nvmem_rockchip_efuse.o\n> nvmem_rockchip_efuse-y := rockchip-efuse.o\n> obj-$(CONFIG_NVMEM_SUNXI_SID) += nvmem_sunxi_sid.o\n> nvmem_sunxi_sid-y := sunxi_sid.o\n> +obj-$(CONFIG_UNIPHIER_EFUSE) += nvmem_uniphier-efuse.o\n> +nvmem_uniphier-efuse-y := uniphier-efuse.o\n> obj-$(CONFIG_NVMEM_VF610_OCOTP) += nvmem-vf610-ocotp.o\n> nvmem-vf610-ocotp-y := vf610-ocotp.o\n> obj-$(CONFIG_MESON_EFUSE) += nvmem_meson_efuse.o\n> diff --git a/drivers/nvmem/uniphier-efuse.c b/drivers/nvmem/uniphier-efuse.c\n> new file mode 100644\n> index 0000000..d553fa3\n> --- /dev/null\n> +++ b/drivers/nvmem/uniphier-efuse.c\n> @@ -0,0 +1,98 @@\n> +/*\n> + * UniPhier eFuse driver\n> + *\n> + * Copyright (C) 2017 Socionext Inc.\n> + *\n> + * This program is free software; you can redistribute it and/or modify\n> + * it under the terms of the GNU General Public License version 2 as\n> + * published by the Free Software Foundation.\n> + *\n> + * This program is distributed in the hope that it will be useful,\n> + * but WITHOUT ANY WARRANTY; without even the implied warranty of\n> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> + * GNU General Public License for more details.\n> + */\n> +\n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> +#define UNIPHIER_EFUSE_WORD_SIZE 4\n> +#define UNIPHIER_EFUSE_STRIDE 4\n> +\n> +static int uniphier_reg_read(void *context,\n> + unsigned int offset, void *val, size_t bytes)\n> +{\n> + int words = bytes / UNIPHIER_EFUSE_WORD_SIZE;\n> +\n> + return regmap_bulk_read(context, offset, val, words);\n> +}\n> +\n> +static struct nvmem_config econfig = {\n> + .name = \"uniphier-efuse\",\n> + .owner = THIS_MODULE,\n> + .read_only = true,\n> + .reg_read = uniphier_reg_read,\n> + .word_size = UNIPHIER_EFUSE_WORD_SIZE,\n> + .stride = UNIPHIER_EFUSE_STRIDE,\n> +};\n\n\n\n\"struct nvmem_config\" exists for the purpose of containing\ndriver-specific parameters.\nDo you still want to use\nUNIPHIER_EFUSE_WORD_SIZE / UNIPHIER_EFUSE_STRIDE macros here?\n\n\n\n\nstatic struct nvmem_config econfig = {\n .name = \"uniphier-efuse\",\n .owner = THIS_MODULE,\n .read_only = true,\n .reg_read = uniphier_reg_read,\n .word_size = 4,\n .stride = 4,\n};\n\nlooks nicer in my taste.\n\n\n\nBTW, is there really no possibility\nwhere the unphier_efuse_probe() is run concurrently?\n\nMany other drivers pass statically allocated memory\nto nvmem_register() like this...\n\n\n\n\n> +static int uniphier_efuse_probe(struct platform_device *pdev)\n> +{\n> + struct device *dev = &pdev->dev;\n> + struct nvmem_device *nvmem;\n> + struct regmap *regmap;\n> + struct resource res;\n> + int ret;\n> +\n> + ret = of_address_to_resource(dev->of_node, 0, &res);\n> + if (ret)\n> + return ret;\n> +\n> + regmap = syscon_node_to_regmap(dev->of_node);\n> + if (IS_ERR(regmap))\n> + return PTR_ERR(regmap);\n\n\nIn my understanding,\nsyscon_node_to_regmap() is generally useful\nto get regmap of another node,\ni.e. it is often used together with of_get_parent / of_parse_phandle etc.\n\nYou can use devm_regmap_init_mmio()\nto init regmap for itself.\n\n\nBTW, what is your motivation of using regmap?\n\n\nI think what you want to do is\nthe same as mtk-efuse.c, right?\n(and qfprom.c is similar, the difference is just register width)\n\n\n\n\n\n\n> + econfig.size = resource_size(&res);\n> + econfig.priv = regmap;\n> + econfig.dev = dev;\n> +\n> + nvmem = nvmem_register(&econfig);\n> + if (IS_ERR(nvmem))\n> + return PTR_ERR(nvmem);\n> +\n> + platform_set_drvdata(pdev, nvmem);\n> +\n> + return 0;\n> +}\n> +\n> +static int uniphier_efuse_remove(struct platform_device *pdev)\n> +{\n> + struct nvmem_device *nvmem = platform_get_drvdata(pdev);\n> +\n> + return nvmem_unregister(nvmem);\n> +}\n> +\n> +static const struct of_device_id uniphier_efuse_of_match[] = {\n> + { .compatible = \"socionext,uniphier-efuse\",},\n> + {/* sentinel */},\n> +};\n> +MODULE_DEVICE_TABLE(of, uniphier_efuse_of_match);\n> +\n> +static struct platform_driver uniphier_efuse_driver = {\n> + .probe = uniphier_efuse_probe,\n> + .remove = uniphier_efuse_remove,\n> + .driver = {\n> + .name = \"uniphier-efuse\",\n> + .of_match_table = uniphier_efuse_of_match,\n> + },\n> +};\n> +module_platform_driver(uniphier_efuse_driver);\n> +\n> +MODULE_AUTHOR(\"Keiji Hayashibara \");\n> +MODULE_DESCRIPTION(\"UniPhier eFuse driver\");\n> +MODULE_LICENSE(\"GPL v2\");\n> --\n> 2.7.4\n>","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"MOJn3QfB\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=nifty.com header.i=@nifty.com\n\theader.b=\"y1EtS6sH\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xm90g6qc4z9sNr\n\tfor ;\n\tMon, 4 Sep 2017 22:59:31 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doqyO-0003qs-NW; Mon, 04 Sep 2017 12:59:28 +0000","from conssluserg-05.nifty.com ([210.131.2.90])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1doqyK-0003qA-N0 for linux-arm-kernel@lists.infradead.org;\n\tMon, 04 Sep 2017 12:59:26 +0000","from mail-yw0-f181.google.com (mail-yw0-f181.google.com\n\t[209.85.161.181]) (authenticated)\n\tby conssluserg-05.nifty.com with ESMTP id v84CwiqW016031\n\tfor ;\n\tMon, 4 Sep 2017 21:58:45 +0900","by mail-yw0-f181.google.com with SMTP id k78so1789607ywe.1\n\tfor ;\n\tMon, 04 Sep 2017 05:58:44 -0700 (PDT)","by 10.37.164.225 with HTTP; Mon, 4 Sep 2017 05:58:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:\n\tReferences:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=EOGO2j7zmbQvOVMI19CEKHjS/a8jl93ZuyJm3Ls8+eM=;\n\tb=MOJn3QfBIlHxWe\n\t7bkDYou2Trlq+1NCeSyTTZLiC7GLpdcLkxUMBZA86XU7MZCNna9fIG9fvLG4UmrxMobUL/KTbA6ud\n\t7ACsOx3DHrr6fYkz7BiwA7y4aAEs4v09k1PLxdSnVa2o6MEJ8jzgLU15JoXtITvU755sbVFe5Gumg\n\tuI/Hz4bqfRto+vdHjOBRhHlDfvZF5YS4ZmNeQH8q0QAfKKp+Wb8e3y7f79oPab2OlirFDX5LLQk3H\n\tT8TMtq3KvLcLoCs7HX9BW3Rs3XJin6a12LWOXqa4On5sgh5k5fx1kwhZ11wulZjbD10gZKM7p/uiZ\n\tzV3hWR+EJRtKSR83FhrQ==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com;\n\ts=dec2015msa; t=1504529925;\n\tbh=ZXeCNk//3O16J+ytoX6suibjtiCM9ZhsH+n6r5zxP4Y=;\n\th=In-Reply-To:References:From:Date:Subject:To:Cc:From;\n\tb=y1EtS6sHqICsUGNwPHcBUdVYkO4HHak0vElhYcDiXWSmfaYbhhkxoreZt3BAItv5l\n\tYD100v6IKgm2tMUovbYNI5VGQ2AXWaW+duaHaWLb3QhzK+PWanbWcOkgPDDikGKWSA\n\t1FZxCjlUY+YgAF0FGT+5PMek03a/zZ0KFpbIPeqx9vTxbmSOvG9NV/qXgKPjsLaoGY\n\t27wXm+ZRoTGDkbfCWngZxVrA7xGD33h2LSI62yWovfOaq6t/nV3ZepXUjtgQ9tgkPt\n\tmTPZoxeczZPMcarI+I5Gz7sTtfNayn8428MUURqttTIgF9Sg9udavDH/6d/tcoETrH\n\t/6TFbA6xpNnHQ=="],"DKIM-Filter":"OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v84CwiqW016031","X-Nifty-SrcIP":"[209.85.161.181]","X-Gm-Message-State":"AHPjjUgha1ajGc0cQcxIJKLo80dq5Z6OknjQ7SHLPoByViTVrMuHX41Z\n\tXsDntl/B34I5TIFKnFUrVZ3LS7l98Q==","X-Google-Smtp-Source":"ADKCNb7O/5uDfBh8vv9djWmZR4HhSTatTjKttUSlMIVWHqjg78vViRLYiaPHfWzc5zxg3uf4D1RYqUYcCmOwJzf57MQ=","X-Received":"by 10.129.123.194 with SMTP id w185mr240814ywc.333.1504529923801;\n\tMon, 04 Sep 2017 05:58:43 -0700 (PDT)","MIME-Version":"1.0","In-Reply-To":"<1504221620-358-3-git-send-email-hayashibara.keiji@socionext.com>","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-3-git-send-email-hayashibara.keiji@socionext.com>","From":"Masahiro Yamada ","Date":"Mon, 4 Sep 2017 21:58:03 +0900","X-Gmail-Original-Message-ID":"","Message-ID":"","Subject":"Re: [PATCH v1 2/3] nvmem: uniphier: add UniPhier eFuse driver","To":"Keiji Hayashibara ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170904_055925_025162_8C299CCA ","X-CRM114-Status":"GOOD ( 24.91 )","X-Spam-Score":"-0.7 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.7 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source\n\t[209.85.161.181 listed in dnsbl.sorbs.net]\n\t0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, Kiyoshi Owada , \n\tKunihiko Hayashi ,\n\tMasami Hiramatsu ,\n\tLinux Kernel Mailing List ,\n\tJassi Brar ,\n\tRob Herring , \n\tSrinivas Kandagatla ,\n\tlinux-arm-kernel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1763007,"web_url":"http://patchwork.ozlabs.org/comment/1763007/","msgid":"<000001d32615$38e1b0c0$aaa51240$@socionext.com>","list_archive_url":null,"date":"2017-09-05T07:04:31","subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":71746,"url":"http://patchwork.ozlabs.org/api/people/71746/","name":"Keiji Hayashibara","email":"hayashibara.keiji@socionext.com"},"content":"Hello Yamada-san,\n\nThank you for your comment.\n\n> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]\n> Sent: Monday, September 4, 2017 9:56 PM\n> \n> 2017-09-01 8:20 GMT+09:00 Keiji Hayashibara\n> :\n> > Add uniphier-efuse dt-bindings documentation.\n> >\n> > Signed-off-by: Keiji Hayashibara \n> > ---\n> > .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45\n> ++++++++++++++++++++++\n> > 1 file changed, 45 insertions(+)\n> > create mode 100644\n> > Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> >\n> > diff --git\n> > a/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> > b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> > new file mode 100644\n> > index 0000000..09024a2\n> > --- /dev/null\n> > +++ b/Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> > @@ -0,0 +1,45 @@\n> > += UniPhier eFuse device tree bindings =\n> > +\n> > +This UniPhier eFuse must be under soc-glue.\n> > +\n> > +Required properties:\n> > +- compatible: should be \"socionext,uniphier-efuse\"\n> > +- reg: should contain the register base and length\n> > +\n> > += Data cells =\n> > +Are child nodes of efuse, bindings of which as described in\n> > +bindings/nvmem/nvmem.txt\n> > +\n> > +Example:\n> > +\n> > + soc-glue@5f900000 {\n> > + compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n> > + \"simple-mfd\";\n> > + #address-cells = <1>;\n> > + #size-cells = <1>;\n> > + ranges = <0x0 0x5f900000 0x2000>;\n> \n> \n> IMHO, I think an empty \"ranges;\" will clarify the code, but it is up to\n> your taste.\n> \n> \n> > +\n> > + efuse {\n> > + compatible = \"socionext,uniphier-efuse\",\n> > + \"syscon\";\n> \n> \n> You are adding a dedicated driver for \"socionext,uniphier-efuse\".\n> \n> Then, \"syscon\" as well?\n> \n\nSince I was using the syscon interface to implement the driver,\nI specified \"syscon\". It's interface is syscon_node_to_regmap().\n\nI will rethink this in v2.\n\n> \n> \n> > + reg = <0x100 0xf00>;\n> \n> \n> Not so many efuse registers exist on the SoC.\n> \n> reg = <0x100 0x200>; will be enough.\n> \n> \n> Or if you want to be strict to the hw spec, you can write as follows:\n> \n> soc-glue@5f900000 {\n> compatible = \"socionext,uniphier-ld20-soc-glue-debug\";\n> \"simple-mfd\";\n> #address-cells = <1>;\n> #size-cells = <1>;\n> ranges = <0x0 0x5f900000 0x2000>;\n> \n> efuse@100 {\n> compatible = \"socionext,uniphier-efuse\";\n> reg = <0x100 0x28>;\n> };\n> \n> efuse@200 {\n> compatible = \"socionext,uniphier-efuse\";\n> reg = <0x200 0x68>;\n> };\n> };\n> \n> \n> \n> \n> > + #address-cells = <1>;\n> > + #size-cells = <1>;\n> > +\n> > + /* Data cells */\n> > + usb_mon: usb_mon {\n> > + reg = <0x154 0xc>;\n> > + };\n> \n> \n> This <0x154 0xc> represents 0x5f900254 in CPU address view.\n> (0x5f900000 + 0x100 + 0x154)\n> \n> So many ranges conversion, and how error-prone..\n> \n\nYes, indeed...\nI will modify as below.\n\n soc-glue@5f900000 {\n compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n \"simple-mfd\";\n #address-cells = <1>;\n #size-cells = <1>;\n ranges;\n\n efuse@5f900100 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x5f900100 0x28>;\n };\n\n efuse@5f900200 {\n compatible = \"socionext,uniphier-efuse\";\n reg = <0x5f900200 0x68>;\n };\n };\n\n\n> \n> \n> \n> > + };\n> > +\n> > += Data consumers =\n> > +Are device nodes which consume nvmem data cells.\n> > +\n> > +Example:\n> > +\n> > + usb {\n> > + ...\n> > + nvmem-cells = <&usb_mon>;\n> > + nvmem-cell-names = \"usb_mon\";\n> > + }\n> > --\n> > 2.7.4\n> >\n> > --\n> > To unsubscribe from this list: send the line \"unsubscribe devicetree\"\n> > in the body of a message to majordomo@vger.kernel.org More majordomo\n> > info at http://vger.kernel.org/majordomo-info.html\n> \n> \n> \n> --\n> Best Regards\n> Masahiro Yamada\n\nBest Regards,\nKeiji Hayashibara","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"QHOdjszA\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xmd5K5Gg1z9sNc\n\tfor ;\n\tTue, 5 Sep 2017 17:05:09 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dp7v0-0007ED-A7; Tue, 05 Sep 2017 07:05:06 +0000","from mx.socionext.com ([202.248.49.38])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dp7ur-0006oU-Au for linux-arm-kernel@lists.infradead.org;\n\tTue, 05 Sep 2017 07:05:04 +0000","from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54])\n\tby mx.socionext.com with ESMTP; 05 Sep 2017 16:04:34 +0900","from mail.mfilter.local (unknown [10.213.24.62])\n\tby iyokan-ex.css.socionext.com (Postfix) with ESMTP id 0E2E1610C6;\n\tTue, 5 Sep 2017 16:04:35 +0900 (JST)","from 172.31.9.53 (172.31.9.53) by m-FILTER with ESMTP;\n\tTue, 5 Sep 2017 16:04:35 +0900","from yuzu.css.socionext.com (yuzu [172.31.8.45])\n\tby iyokan.css.socionext.com (Postfix) with ESMTP id AE1FC408BD;\n\tTue, 5 Sep 2017 16:04:34 +0900 (JST)","from DESKTOP0FARE34 (unknown [10.213.134.218])\n\tby yuzu.css.socionext.com (Postfix) with ESMTP id 74855120453;\n\tTue, 5 Sep 2017 16:04:34 +0900 (JST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:\n\tIn-Reply-To:References:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=yud8LVvhduS8TSraYOgd5XC/7MJbuLjqtqW9NH756uM=;\n\tb=QHOdjszAsIPoK2\n\t7r4pxp+LVyywwRVdy63IucHwjctyDupCz2H5qeG4kLZIjiRn0X11ILU9ueT4FxDiQqdIl+ajO0sKi\n\tWV2eCjRQtxb7mupsZ47Uc1lf1tYGi0u/nu4nmpkQkGDWHKJJ3S6S8291f9eWN4YZGUycSA9SK0gs3\n\tl6ZMAbpsB8madAh9boe5n/9SuZSrp448stv3cp99pl3ysPk0goAH1ILSl++3V1IkhpgP6DFNGEHOe\n\tAcCxadoi3gKJnNBOk1Ml5GhOfYq9oO1UipkxWqOqcDG/9kXRHnotOpbzItQKqfY+wdnnVkPjs9kyL\n\tEbz30JgGwkyz5EFjSulA==;","From":"\"Keiji Hayashibara\" ","To":"\"'Masahiro Yamada'\" ","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>\n\t","In-Reply-To":"","Subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","Date":"Tue, 5 Sep 2017 16:04:31 +0900","Message-ID":"<000001d32615$38e1b0c0$aaa51240$@socionext.com>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 15.0","Thread-Index":"AQHTIq+404wQIKzt80GBKvEJt/m0IqKkHfiAgAGl+SA=","Content-Language":"ja","x-securitypolicycheck":"OK by SHieldMailChecker v2.5.2","x-shieldmailcheckerpolicyversion":"POLICY170302","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170905_000457_626234_627CB000 ","X-CRM114-Status":"GOOD ( 19.70 )","X-Spam-Score":"-0.4 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.4 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t1.5 FSL_HELO_BARE_IP_2 No description available.","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, =?utf-8?b?T3dhZGEsIEtpeW9zaGkv5aSn5ZKM55Sw?=\n\t=?utf-8?b?IOa4heW/lw==?= ,\n\t=?utf-8?b?SGF5YXNoaSwgS3VuaWhpa28v5p6X?= =?utf-8?b?IOmCpuW9pg==?=\n\t, Masami Hiramatsu\n\t, Linux Kernel Mailing List\n\t, Jassi Brar ,\n\tRob Herring , Srinivas Kandagatla\n\t, linux-arm-kernel\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1764443,"web_url":"http://patchwork.ozlabs.org/comment/1764443/","msgid":"<000001d32771$544d0dc0$fce72940$@socionext.com>","list_archive_url":null,"date":"2017-09-07T00:36:21","subject":"RE: [PATCH v1 2/3] nvmem: uniphier: add UniPhier eFuse driver","submitter":{"id":71746,"url":"http://patchwork.ozlabs.org/api/people/71746/","name":"Keiji Hayashibara","email":"hayashibara.keiji@socionext.com"},"content":"Hello Yamada-san,\n\nThank you for your comment.\n\n> From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]\n> Sent: Monday, September 4, 2017 9:58 PM\n> \n> 2017-09-01 8:20 GMT+09:00 Keiji Hayashibara\n> :\n> > Add eFuse driver for Socionext UniPhier series SoC.\n> > Note that eFuse device is under soc-glue and this register implements\n> > as read only.\n> >\n> > Signed-off-by: Keiji Hayashibara \n> > ---\n> > arch/arm64/configs/defconfig | 1 +\n> > drivers/nvmem/Kconfig | 11 +++++\n> > drivers/nvmem/Makefile | 2 +\n> > drivers/nvmem/uniphier-efuse.c | 98\n> > ++++++++++++++++++++++++++++++++++++++++++\n> > 4 files changed, 112 insertions(+)\n> > create mode 100644 drivers/nvmem/uniphier-efuse.c\n> >\n> > diff --git a/arch/arm64/configs/defconfig\n> > b/arch/arm64/configs/defconfig index 6c7d147..5c38b4a 100644\n> > --- a/arch/arm64/configs/defconfig\n> > +++ b/arch/arm64/configs/defconfig\n> > @@ -514,6 +514,7 @@ CONFIG_PHY_XGENE=y CONFIG_PHY_TEGRA_XUSB=y\n> > CONFIG_QCOM_L2_PMU=y CONFIG_QCOM_L3_PMU=y\n> > +CONFIG_UNIPHIER_EFUSE=y\n> > CONFIG_ARM_SCPI_PROTOCOL=y\n> > CONFIG_RASPBERRYPI_FIRMWARE=y\n> > CONFIG_EFI_CAPSULE_LOADER=y\n> \n> \n> You need to send this separately\n> (after this driver is accepted)\n\nI see.\nNext I will post this separately.\n\n> \n> > diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index\n> > 101ced4..aaeaebe 100644\n> > --- a/drivers/nvmem/Kconfig\n> > +++ b/drivers/nvmem/Kconfig\n> > @@ -123,6 +123,17 @@ config NVMEM_SUNXI_SID\n> > This driver can also be built as a module. If so, the module\n> > will be called nvmem_sunxi_sid.\n> >\n> > +config UNIPHIER_EFUSE\n> > + tristate \"UniPhier SoCs eFuse support\"\n> > + depends on ARCH_UNIPHIER || COMPILE_TEST\n> > + depends on OF && MFD_SYSCON\n> > + help\n> > + This is a simple drive to dump specified values of UniPhier\n> SoC\n> > + from eFuse.\n> \n> \n> s/drive/driver/\n> \n> \n> I see the same typo in ROCKCHIP_EFUSE.\n> \n> You copied it verbatim.\n> \n\nI will fix it...\n\n> \n> \n> > + This driver can also be built as a module. If so, the module\n> > + will be called nvmem_uniphier-efuse.\n> \n> \n> I do not like a mixture of '_' and '-' though...\n> \n\nI will fix it.\n> \n> \n> > config NVMEM_VF610_OCOTP\n> > tristate \"VF610 SoC OCOTP support\"\n> > depends on SOC_VF610 || COMPILE_TEST diff --git\n> > a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile index\n> > 1731406..f5277c3 100644\n> > --- a/drivers/nvmem/Makefile\n> > +++ b/drivers/nvmem/Makefile\n> > @@ -26,6 +26,8 @@ obj-$(CONFIG_ROCKCHIP_EFUSE) +=\n> nvmem_rockchip_efuse.o\n> > nvmem_rockchip_efuse-y := rockchip-efuse.o\n> > obj-$(CONFIG_NVMEM_SUNXI_SID) += nvmem_sunxi_sid.o\n> > nvmem_sunxi_sid-y := sunxi_sid.o\n> > +obj-$(CONFIG_UNIPHIER_EFUSE) += nvmem_uniphier-efuse.o\n> > +nvmem_uniphier-efuse-y := uniphier-efuse.o\n> > obj-$(CONFIG_NVMEM_VF610_OCOTP) += nvmem-vf610-ocotp.o\n> > nvmem-vf610-ocotp-y := vf610-ocotp.o\n> > obj-$(CONFIG_MESON_EFUSE) += nvmem_meson_efuse.o\n> > diff --git a/drivers/nvmem/uniphier-efuse.c\n> > b/drivers/nvmem/uniphier-efuse.c new file mode 100644 index\n> > 0000000..d553fa3\n> > --- /dev/null\n> > +++ b/drivers/nvmem/uniphier-efuse.c\n> > @@ -0,0 +1,98 @@\n> > +/*\n> > + * UniPhier eFuse driver\n> > + *\n> > + * Copyright (C) 2017 Socionext Inc.\n> > + *\n> > + * This program is free software; you can redistribute it and/or\n> > +modify\n> > + * it under the terms of the GNU General Public License version 2 as\n> > + * published by the Free Software Foundation.\n> > + *\n> > + * This program is distributed in the hope that it will be useful,\n> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of\n> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n> > + * GNU General Public License for more details.\n> > + */\n> > +\n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +\n> > +#define UNIPHIER_EFUSE_WORD_SIZE 4\n> > +#define UNIPHIER_EFUSE_STRIDE 4\n> > +\n> > +static int uniphier_reg_read(void *context,\n> > + unsigned int offset, void *val, size_t\n> > +bytes) {\n> > + int words = bytes / UNIPHIER_EFUSE_WORD_SIZE;\n> > +\n> > + return regmap_bulk_read(context, offset, val, words); }\n> > +\n> > +static struct nvmem_config econfig = {\n> > + .name = \"uniphier-efuse\",\n> > + .owner = THIS_MODULE,\n> > + .read_only = true,\n> > + .reg_read = uniphier_reg_read,\n> > + .word_size = UNIPHIER_EFUSE_WORD_SIZE,\n> > + .stride = UNIPHIER_EFUSE_STRIDE, };\n> \n> \n> \n> \"struct nvmem_config\" exists for the purpose of containing driver-specific\n> parameters.\n> Do you still want to use\n> UNIPHIER_EFUSE_WORD_SIZE / UNIPHIER_EFUSE_STRIDE macros here?\n> \n> \n> \n> \n> static struct nvmem_config econfig = {\n> .name = \"uniphier-efuse\",\n> .owner = THIS_MODULE,\n> .read_only = true,\n> .reg_read = uniphier_reg_read,\n> .word_size = 4,\n> .stride = 4,\n> };\n> \n> looks nicer in my taste.\n> \n\nI will fix it.\n\n> \n> BTW, is there really no possibility\n> where the unphier_efuse_probe() is run concurrently?\n> \n> Many other drivers pass statically allocated memory to nvmem_register()\n> like this...\n> \nIn the case of the uniphier system, since there is only one efuse device,\nit will not run concurrently. \nI would like to fix it when I need it in the future.\n\n> \n> > +static int uniphier_efuse_probe(struct platform_device *pdev) {\n> > + struct device *dev = &pdev->dev;\n> > + struct nvmem_device *nvmem;\n> > + struct regmap *regmap;\n> > + struct resource res;\n> > + int ret;\n> > +\n> > + ret = of_address_to_resource(dev->of_node, 0, &res);\n> > + if (ret)\n> > + return ret;\n> > +\n> > + regmap = syscon_node_to_regmap(dev->of_node);\n> > + if (IS_ERR(regmap))\n> > + return PTR_ERR(regmap);\n> \n> \n> In my understanding,\n> syscon_node_to_regmap() is generally useful to get regmap of another node,\n> i.e. it is often used together with of_get_parent / of_parse_phandle etc.\n> \n> You can use devm_regmap_init_mmio()\n> to init regmap for itself.\n> \n> \n> BTW, what is your motivation of using regmap?\n>\n> \n> I think what you want to do is\n> the same as mtk-efuse.c, right?\n> (and qfprom.c is similar, the difference is just register width)\n\nSince redundancy can be omitted, implementation is easier, I think so.\nHowever, since I can't find the merit of using regmap,\nI will implement it in a method that does not use it.\n\n> \n> \n> > + econfig.size = resource_size(&res);\n> > + econfig.priv = regmap;\n> > + econfig.dev = dev;\n> > +\n> > + nvmem = nvmem_register(&econfig);\n> > + if (IS_ERR(nvmem))\n> > + return PTR_ERR(nvmem);\n> > +\n> > + platform_set_drvdata(pdev, nvmem);\n> > +\n> > + return 0;\n> > +}\n> > +\n> > +static int uniphier_efuse_remove(struct platform_device *pdev) {\n> > + struct nvmem_device *nvmem = platform_get_drvdata(pdev);\n> > +\n> > + return nvmem_unregister(nvmem); }\n> > +\n> > +static const struct of_device_id uniphier_efuse_of_match[] = {\n> > + { .compatible = \"socionext,uniphier-efuse\",},\n> > + {/* sentinel */},\n> > +};\n> > +MODULE_DEVICE_TABLE(of, uniphier_efuse_of_match);\n> > +\n> > +static struct platform_driver uniphier_efuse_driver = {\n> > + .probe = uniphier_efuse_probe,\n> > + .remove = uniphier_efuse_remove,\n> > + .driver = {\n> > + .name = \"uniphier-efuse\",\n> > + .of_match_table = uniphier_efuse_of_match,\n> > + },\n> > +};\n> > +module_platform_driver(uniphier_efuse_driver);\n> > +\n> > +MODULE_AUTHOR(\"Keiji Hayashibara \");\n> > +MODULE_DESCRIPTION(\"UniPhier eFuse driver\"); MODULE_LICENSE(\"GPL\n> > +v2\");\n> > --\n> > 2.7.4\n> >\n> \n> \n> \n> --\n> Best Regards\n> Masahiro Yamada\n\nBest Regards,\nKeiji Hayashibara","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"oj/lCjGz\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xnhNX5Gjdz9s8J\n\tfor ;\n\tThu, 7 Sep 2017 10:36:58 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpkoQ-0004UE-De; Thu, 07 Sep 2017 00:36:54 +0000","from mx.socionext.com ([202.248.49.38])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dpkoL-0004Pd-2q for linux-arm-kernel@lists.infradead.org;\n\tThu, 07 Sep 2017 00:36:51 +0000","from unknown (HELO iyokan-ex.css.socionext.com) ([172.31.9.54])\n\tby mx.socionext.com with ESMTP; 07 Sep 2017 09:36:26 +0900","from mail.mfilter.local (unknown [10.213.24.61])\n\tby iyokan-ex.css.socionext.com (Postfix) with ESMTP id 2B91F610C6;\n\tThu, 7 Sep 2017 09:36:26 +0900 (JST)","from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP;\n\tThu, 7 Sep 2017 09:36:26 +0900","from yuzu.css.socionext.com (yuzu [172.31.8.45])\n\tby kinkan.css.socionext.com (Postfix) with ESMTP id 87F041A0E16;\n\tThu, 7 Sep 2017 09:36:25 +0900 (JST)","from DESKTOP0FARE34 (unknown [10.213.134.218])\n\tby yuzu.css.socionext.com (Postfix) with ESMTP id 49C99120453;\n\tThu, 7 Sep 2017 09:36:25 +0900 (JST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:\n\tIn-Reply-To:References:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=Ri4dEw4clsQdCiAwQIrfsKW4qce/NQtC6qOSh+e4tJo=;\n\tb=oj/lCjGzx3qCBO\n\tz71MYpcy/BFwwiptgkMnYt0B7ufNTeIwk7Zui3O6ZHrFXQWjXY3G33UF1lGtgdwUonymKobhAgB+/\n\tyiSaZ4X1xS77Nl0qjZ7kwoml306tf1HfpXEfUGIiN3xui2F1JOYWN7/zVrqONUsN/Z9Ohu4jnfhEJ\n\tHbWQNUmxePx7lvhVHWf8JyAfkj/adO1m6doWCcjGCgZQk0apZWVnmDysp7Hk6tmvIHPQ6KI/KqEys\n\tJKl4N6TgInYqKOgUvDqlhCGeF6A9LfpylLSjKC3HQM0kOGJrdzmokfKl3HqOH/mzlQNFpkZVQiedk\n\tJrkF0XApj4qQTQ3GcYuw==;","From":"\"Keiji Hayashibara\" ","To":"\"'Masahiro Yamada'\" ","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-3-git-send-email-hayashibara.keiji@socionext.com>\n\t","In-Reply-To":"","Subject":"RE: [PATCH v1 2/3] nvmem: uniphier: add UniPhier eFuse driver","Date":"Thu, 7 Sep 2017 09:36:21 +0900","Message-ID":"<000001d32771$544d0dc0$fce72940$@socionext.com>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 15.0","Thread-Index":"AQHTIq+4DHAsvjFxIE+6uGRrOXeKMqKkHqOAgARq8SA=","Content-Language":"ja","x-securitypolicycheck":"OK by SHieldMailChecker v2.5.2","x-shieldmailcheckerpolicyversion":"POLICY170302","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170906_173649_514116_C59A7117 ","X-CRM114-Status":"GOOD ( 32.95 )","X-Spam-Score":"-0.4 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.4 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t1.5 FSL_HELO_BARE_IP_2 No description available.","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, =?utf-8?b?T3dhZGEsIEtpeW9zaGkv5aSn5ZKM55Sw?=\n\t=?utf-8?b?IOa4heW/lw==?= ,\n\t=?utf-8?b?SGF5YXNoaSwgS3VuaWhpa28v5p6X?= =?utf-8?b?IOmCpuW9pg==?=\n\t, Masami Hiramatsu\n\t, Linux Kernel Mailing List\n\t, Jassi Brar ,\n\tRob Herring , Srinivas Kandagatla\n\t, linux-arm-kernel\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1767214,"web_url":"http://patchwork.ozlabs.org/comment/1767214/","msgid":"<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","list_archive_url":null,"date":"2017-09-12T16:15:46","subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":62529,"url":"http://patchwork.ozlabs.org/api/people/62529/","name":"Rob Herring (Arm)","email":"robh@kernel.org"},"content":"On Tue, Sep 05, 2017 at 04:04:31PM +0900, Keiji Hayashibara wrote:\n> Hello Yamada-san,\n> \n> Thank you for your comment.\n> \n> > From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]\n> > Sent: Monday, September 4, 2017 9:56 PM\n> > \n> > 2017-09-01 8:20 GMT+09:00 Keiji Hayashibara\n> > :\n> > > Add uniphier-efuse dt-bindings documentation.\n> > >\n> > > Signed-off-by: Keiji Hayashibara \n> > > ---\n> > > .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45\n> > ++++++++++++++++++++++\n> > > 1 file changed, 45 insertions(+)\n> > > create mode 100644\n> > > Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n\n> > > +Example:\n> > > +\n> > > + soc-glue@5f900000 {\n> > > + compatible = \"socionext,uniphier-ld20-soc-glue-debug\",\n> > > + \"simple-mfd\";\n> > > + #address-cells = <1>;\n> > > + #size-cells = <1>;\n> > > + ranges = <0x0 0x5f900000 0x2000>;\n> > \n> > \n> > IMHO, I think an empty \"ranges;\" will clarify the code, but it is up to\n> > your taste.\n> > \n> > \n> > > +\n> > > + efuse {\n> > > + compatible = \"socionext,uniphier-efuse\",\n> > > + \"syscon\";\n> > \n> > \n> > You are adding a dedicated driver for \"socionext,uniphier-efuse\".\n> > \n> > Then, \"syscon\" as well?\n> > \n> \n> Since I was using the syscon interface to implement the driver,\n> I specified \"syscon\". It's interface is syscon_node_to_regmap().\n> \n> I will rethink this in v2.\n> \n> > \n> > \n> > > + reg = <0x100 0xf00>;\n> > \n> > \n> > Not so many efuse registers exist on the SoC.\n> > \n> > reg = <0x100 0x200>; will be enough.\n> > \n> > \n> > Or if you want to be strict to the hw spec, you can write as follows:\n> > \n> > soc-glue@5f900000 {\n> > compatible = \"socionext,uniphier-ld20-soc-glue-debug\";\n> > \"simple-mfd\";\n> > #address-cells = <1>;\n> > #size-cells = <1>;\n> > ranges = <0x0 0x5f900000 0x2000>;\n> > \n> > efuse@100 {\n> > compatible = \"socionext,uniphier-efuse\";\n> > reg = <0x100 0x28>;\n> > };\n> > \n> > efuse@200 {\n> > compatible = \"socionext,uniphier-efuse\";\n> > reg = <0x200 0x68>;\n> > };\n> > };\n> > \n> > \n> > \n> > \n> > > + #address-cells = <1>;\n> > > + #size-cells = <1>;\n> > > +\n> > > + /* Data cells */\n> > > + usb_mon: usb_mon {\n> > > + reg = <0x154 0xc>;\n> > > + };\n> > \n> > \n> > This <0x154 0xc> represents 0x5f900254 in CPU address view.\n> > (0x5f900000 + 0x100 + 0x154)\n> > \n> > So many ranges conversion, and how error-prone..\n> > \n> \n> Yes, indeed...\n> I will modify as below.\n\nPlease don't. A non-empty ranges is preferred. It limits the scope and \nchance for errors (smaller range allows fewer possible values and \nlimits the chances of having address ranges duplicated in multiple \nnodes). But yes, it does add the requirement of doing addition and/or \nOR operations. I can't review whether the address ends up being correct \neither way, but having non-empty ranges helps enforce the other things.\n\nRob","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"uaUVyGwO\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xs9033fp3z9s7f\n\tfor ;\n\tWed, 13 Sep 2017 02:16:19 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drnrD-00014F-6j; Tue, 12 Sep 2017 16:16:15 +0000","from mail-io0-f193.google.com ([209.85.223.193])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drnr9-00011d-3w for linux-arm-kernel@lists.infradead.org;\n\tTue, 12 Sep 2017 16:16:12 +0000","by mail-io0-f193.google.com with SMTP id n69so5579794ioi.3\n\tfor ;\n\tTue, 12 Sep 2017 09:15:48 -0700 (PDT)","from localhost (216-188-254-6.dyn.grandenetworks.net.\n\t[216.188.254.6]) by smtp.gmail.com with ESMTPSA id\n\tt205sm11228959oig.53.2017.09.12.09.15.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tTue, 12 Sep 2017 09:15:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:\n\tMessage-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=9yMiKQr3GIUDQDepHOAKNdGYhM13ahM0Fwb6V9gaFYc=;\n\tb=uaUVyGwOufmJh+\n\toiu5JpciMS3E1Q1x4s73s/ktwbl8+/UnaTnZzb9i2rtrUEaLDYq6gf7kU/n4eqrDill0KLdnkss4f\n\tKn32xWVWK7YgFjKeOTDPtOdINLGuO5oiWyhseXTxz23znBRmEghf2jUDA/vbbvoIo8eYhQlNTUlTZ\n\tS8xoz44t+OmdUIPMQ2fYr5Br2m+EmuDcJ+P8FwyPuy6tJ5JGM5ddflH4WAY8ToMO9y7XjaOGxPnqF\n\t3DVKKeegqBZy7y/PxiIjuRQZNkWNUVBEofAU2Ev7TBCLr29Aa8eHf/TbdwZ8wGDEmEtcZQo2h0im+\n\t/+dP6wz6IpI+y5i9Blxw==;","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:in-reply-to:user-agent;\n\tbh=HfwGpAUfOIMQ72MV8yuOO1bOB2ZxcI8RnnU3g4kLpw8=;\n\tb=japQNyuot6HSJN4ZX05rMD0zO9sVYDqtffpnDEaVf+asInEeLlOU7sREkFm/ho6Upc\n\tMVPPOEVDjGgLW8U7VpIApH2bhKEvvighVekLstueahYG2cbeqSfXqZJxQAIr+nEerkZG\n\tYXf2xSp8FqfviAh2yPnN0aetgPJ2AwmjfPYZv2fVcmhpwihk6UevDiUJUV9Aier3zvH7\n\tjTD49MNW4/fqoXterJ1g2NE0LUWsKQLdqnTQS/qzRsZJP9/iTiAXZsRPQw1DhfNLKRWC\n\tf4XpVM3dTfCvAI+K+Taj3mtFEd8kG630m3Gh4tdX/sh/Tj0iBh9RfdWAFMfixPKGi72H\n\tqp6w==","X-Gm-Message-State":"AHPjjUhnF8Nig5iqGdvm7kF0vPWaRD5r3/64Y71LbXb6+zuBUXlyEkOH\n\tDlV7YEXz5TgSuw==","X-Google-Smtp-Source":"AOwi7QDbAcuI34xqIaPM20/R2MaXRbWf5foFoHvcDujemlnZsiKjSEhUJ9z/qGhzWDkBkLdhCjlncw==","X-Received":"by 10.202.179.137 with SMTP id\n\tc131mr15173493oif.298.1505232947625; \n\tTue, 12 Sep 2017 09:15:47 -0700 (PDT)","Date":"Tue, 12 Sep 2017 11:15:46 -0500","From":"Rob Herring ","To":"Keiji Hayashibara ","Subject":"Re: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","Message-ID":"<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>\n\t\n\t<000001d32615$38e1b0c0$aaa51240$@socionext.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<000001d32615$38e1b0c0$aaa51240$@socionext.com>","User-Agent":"NeoMutt/20170113 (1.7.2)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170912_091611_211581_75C91D8A ","X-CRM114-Status":"GOOD ( 20.87 )","X-Spam-Score":"-3.8 (---)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-3.8 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t0.5 RCVD_IN_SORBS_SPAM RBL: SORBS: sender is a spam source\n\t[209.85.223.193 listed in dnsbl.sorbs.net]\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno trust [209.85.223.193 listed in list.dnswl.org]\n\t-2.8 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2)\n\t[209.85.223.193 listed in wl.mailspike.net]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends\n\tin digit (robherring2[at]gmail.com)\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (robherring2[at]gmail.com)\n\t0.0 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level\n\tmail domains are different\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and\n\tEnvelopeFrom freemail headers are different","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, =?utf-8?b?T3dhZGEsIEtpeW9zaGkv5aSn5ZKM55Sw?=\n\t=?utf-8?b?IOa4heW/lw==?= ,\n\t=?utf-8?b?SGF5YXNoaSwgS3VuaWhpa28v5p6X?= =?utf-8?b?IOmCpuW9pg==?=\n\t, Masami Hiramatsu\n\t, Jassi Brar , \n\tLinux Kernel Mailing List , \n\t'Masahiro Yamada' , Srinivas Kandagatla\n\t, linux-arm-kernel\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}},{"id":1767471,"web_url":"http://patchwork.ozlabs.org/comment/1767471/","msgid":"<000301d32c38$5fe8a830$1fb9f890$@socionext.com>","list_archive_url":null,"date":"2017-09-13T02:31:16","subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","submitter":{"id":71746,"url":"http://patchwork.ozlabs.org/api/people/71746/","name":"Keiji Hayashibara","email":"hayashibara.keiji@socionext.com"},"content":"Hello Rob,\n\nThank you for your comment.\n\n> From: Rob Herring [mailto:robh@kernel.org]\n> Sent: Wednesday, September 13, 2017 1:16 AM\n> \n> On Tue, Sep 05, 2017 at 04:04:31PM +0900, Keiji Hayashibara wrote:\n> > Hello Yamada-san,\n> >\n> > Thank you for your comment.\n> >\n> > > From: Masahiro Yamada [mailto:yamada.masahiro@socionext.com]\n> > > Sent: Monday, September 4, 2017 9:56 PM\n> > >\n> > > 2017-09-01 8:20 GMT+09:00 Keiji Hayashibara\n> > > :\n> > > > Add uniphier-efuse dt-bindings documentation.\n> > > >\n> > > > Signed-off-by: Keiji Hayashibara \n> > > > ---\n> > > > .../devicetree/bindings/nvmem/uniphier-efuse.txt | 45\n> > > ++++++++++++++++++++++\n> > > > 1 file changed, 45 insertions(+)\n> > > > create mode 100644\n> > > > Documentation/devicetree/bindings/nvmem/uniphier-efuse.txt\n> \n> > > > +Example:\n> > > > +\n> > > > + soc-glue@5f900000 {\n> > > > + compatible =\n> \"socionext,uniphier-ld20-soc-glue-debug\",\n> > > > + \"simple-mfd\";\n> > > > + #address-cells = <1>;\n> > > > + #size-cells = <1>;\n> > > > + ranges = <0x0 0x5f900000 0x2000>;\n> > >\n> > >\n> > > IMHO, I think an empty \"ranges;\" will clarify the code, but it is up\n> > > to your taste.\n> > >\n> > >\n> > > > +\n> > > > + efuse {\n> > > > + compatible = \"socionext,uniphier-efuse\",\n> > > > + \"syscon\";\n> > >\n> > >\n> > > You are adding a dedicated driver for \"socionext,uniphier-efuse\".\n> > >\n> > > Then, \"syscon\" as well?\n> > >\n> >\n> > Since I was using the syscon interface to implement the driver, I\n> > specified \"syscon\". It's interface is syscon_node_to_regmap().\n> >\n> > I will rethink this in v2.\n> >\n> > >\n> > >\n> > > > + reg = <0x100 0xf00>;\n> > >\n> > >\n> > > Not so many efuse registers exist on the SoC.\n> > >\n> > > reg = <0x100 0x200>; will be enough.\n> > >\n> > >\n> > > Or if you want to be strict to the hw spec, you can write as follows:\n> > >\n> > > soc-glue@5f900000 {\n> > > compatible =\n> \"socionext,uniphier-ld20-soc-glue-debug\";\n> > > \"simple-mfd\";\n> > > #address-cells = <1>;\n> > > #size-cells = <1>;\n> > > ranges = <0x0 0x5f900000 0x2000>;\n> > >\n> > > efuse@100 {\n> > > compatible = \"socionext,uniphier-efuse\";\n> > > reg = <0x100 0x28>;\n> > > };\n> > >\n> > > efuse@200 {\n> > > compatible = \"socionext,uniphier-efuse\";\n> > > reg = <0x200 0x68>;\n> > > };\n> > > };\n> > >\n> > >\n> > >\n> > >\n> > > > + #address-cells = <1>;\n> > > > + #size-cells = <1>;\n> > > > +\n> > > > + /* Data cells */\n> > > > + usb_mon: usb_mon {\n> > > > + reg = <0x154 0xc>;\n> > > > + };\n> > >\n> > >\n> > > This <0x154 0xc> represents 0x5f900254 in CPU address view.\n> > > (0x5f900000 + 0x100 + 0x154)\n> > >\n> > > So many ranges conversion, and how error-prone..\n> > >\n> >\n> > Yes, indeed...\n> > I will modify as below.\n> \n> Please don't. A non-empty ranges is preferred. It limits the scope and\nchance\n> for errors (smaller range allows fewer possible values and limits the\n> chances of having address ranges duplicated in multiple nodes). But yes,\n> it does add the requirement of doing addition and/or OR operations. I\ncan't\n> review whether the address ends up being correct either way, but having\n> non-empty ranges helps enforce the other things.\n\nI see. \nI will proceed with implementation by non-empty ranges.\n\nBest Regards,\nKeiji Hayashibara","headers":{"Return-Path":"","X-Original-To":"incoming-imx@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming-imx@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.infradead.org\n\t(client-ip=65.50.211.133; helo=bombadil.infradead.org;\n\tenvelope-from=linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org\n\theader.b=\"Jg+Fehtu\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xsQfq6dhhz9sPt\n\tfor ;\n\tWed, 13 Sep 2017 12:32:19 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drxTL-0005gg-Tp; Wed, 13 Sep 2017 02:32:15 +0000","from mx.socionext.com ([202.248.49.38])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1drxSu-0005AB-JZ for linux-arm-kernel@lists.infradead.org;\n\tWed, 13 Sep 2017 02:32:03 +0000","from unknown (HELO kinkan-ex.css.socionext.com) ([172.31.9.52])\n\tby mx.socionext.com with ESMTP; 13 Sep 2017 11:31:20 +0900","from mail.mfilter.local (unknown [10.213.24.62])\n\tby kinkan-ex.css.socionext.com (Postfix) with ESMTP id D442C180223;\n\tWed, 13 Sep 2017 11:31:19 +0900 (JST)","from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP;\n\tWed, 13 Sep 2017 11:31:19 +0900","from yuzu.css.socionext.com (yuzu [172.31.8.45])\n\tby kinkan.css.socionext.com (Postfix) with ESMTP id 7A9A01A1223;\n\tWed, 13 Sep 2017 11:31:19 +0900 (JST)","from DESKTOP0FARE34 (unknown [10.213.134.218])\n\tby yuzu.css.socionext.com (Postfix) with ESMTP id 437381204AE;\n\tWed, 13 Sep 2017 11:31:19 +0900 (JST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:\n\tIn-Reply-To:References:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=qWUQH4LfjDVkumpoG9jk3bIZaNQBLWbJjpPp9HALhk8=;\n\tb=Jg+FehtuBCygiv\n\t0Pe1mdqq4FDVV3NRiXn5jxXO+2CcYGQ4tyqAju1YP5eSudkGMOXKC45cZg0WSJwiCd8hB21TS90Ea\n\tj2cVHq/M7WWnn3vKqp4xFRaAqm0PTUqY1Eac0+ApLNOL5AqX46nTumJ7rFRyWuh8UFTirNmFCTv7u\n\tnrbxa9yyFSbpKIKvH3Qb7xXoacEHY+UC5L0PXC2/1gpyLeex/0GDfr8AHmsYJjqxwAwLYmAkwKq5V\n\t81VlM+wi8Xg6Foucbc/x/rmLb0gx+S95dFnUF6ptJsYeQD2kWdyWypWbYWaNVS4y3NW77jFd7x4WV\n\tSmFqhmEh1ebGhUeVRdWA==;","From":"\"Keiji Hayashibara\" ","To":"\"'Rob Herring'\" ","References":"<1504221620-358-1-git-send-email-hayashibara.keiji@socionext.com>\n\t<1504221620-358-2-git-send-email-hayashibara.keiji@socionext.com>\n\t\n\t<000001d32615$38e1b0c0$aaa51240$@socionext.com>\n\t<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","In-Reply-To":"<20170912161546.q5xr5pfdxin3qujf@rob-hp-laptop>","Subject":"RE: [PATCH v1 1/3] dt-bindings: nvmem: add description for UniPhier\n\teFuse","Date":"Wed, 13 Sep 2017 11:31:16 +0900","Message-ID":"<000301d32c38$5fe8a830$1fb9f890$@socionext.com>","MIME-Version":"1.0","X-Mailer":"Microsoft Outlook 15.0","Thread-Index":"AQHTIq+404wQIKzt80GBKvEJt/m0IqKkHfiAgA1hdeKAAKck0A==","Content-Language":"ja","x-securitypolicycheck":"OK by SHieldMailChecker v2.5.2","x-shieldmailcheckerpolicyversion":"POLICY170302","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170912_193152_543977_F6E68E86 ","X-CRM114-Status":"GOOD ( 18.35 )","X-Spam-Score":"-0.4 (/)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-0.4 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t-0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay\n\tdomain\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t1.5 FSL_HELO_BARE_IP_2 No description available.","X-BeenThere":"linux-arm-kernel@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"devicetree@vger.kernel.org, =?iso-2022-jp?b?T3dhZGEsIEtpeW9zaGkv?=\n\t=?iso-2022-jp?b?GyRCQmdPQkVEGyhCIBskQkA2O1YbKEI=?=\n\t, =?iso-2022-jp?b?SGF5YXNoaSwgS3VuaWhp?=\n\t=?iso-2022-jp?b?a28vGyRCTlMbKEIgGyRCSy5JJxsoQg==?=\n\t, Masami Hiramatsu\n\t, Jassi Brar , \n\tLinux Kernel Mailing List , \n\t=?iso-2022-jp?b?WWFtYWRhLCBNYXNhaGly?=\n\t=?iso-2022-jp?b?by8bJEI7M0VEGyhCIBskQj8/OTAbKEI=?=\n\t, Srinivas Kandagatla\n\t, linux-arm-kernel\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-arm-kernel\" ","Errors-To":"linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org","List-Id":"linux-imx-kernel.lists.patchwork.ozlabs.org"}}]